On Mon, Feb 23, 2015 at 1:45 PM, Radim Krčmář <rkrc...@redhat.com> wrote:
> 2015-02-23 10:45+0000, Stefan Hajnoczi:
>> On Thu, Feb 19, 2015 at 09:37:46PM +0100, Radim Krčmář wrote:
>> > 2015-02-19 20:24+0100, Radim Krčmář:
>> > > diff --git a/hw/net/e1000.c b/hw/net/e1000.c
>> > > @@ -138,6 +138,10 @@ typedef struct E1000State_st {
>> > > +#define E1000_WIN8_WORKAROUND_ICR E1000_ICR_RXT0
>> > > +#define E1000_WIN8_WORKAROUND_DELAY_US 10
>> > > + bool win8_workaround_needed;
>> > > @@ -288,7 +292,7 @@ set_interrupt_cause(E1000State *s, int index,
>> > > uint32_t val)
>> > > @@ -316,13 +320,17 @@ set_interrupt_cause(E1000State *s, int index,
>> > > uint32_t val)
>> > > + if (s->win8_workround_needed) {
>> >
>> > So I read the patch again and noticed a typo here, which reminds me that
>> > QEMU does not compile on rawhide for several reasons ...
>> > I'll fix that to compensate.
>>
>> Just to clarify, you are NACKing this patch and will send a new series?
>
> I would only change this line in v2 so far, so I wait for more comments
> before respin. It is possible that maintainers find fixing a typo
> easier than handling v2, but it most likely is a NACK.
Since the typo breaks compilation, it shows that the patch was not
tested. That makes me nervous.
Please send v2 after testing the Windows 8 guest.
Stefan
