Re: [Qemu-devel] [RFC PATCH v9 22/23] replay: command line options

2015-02-20 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 18/02/2015 12:57, Pavel Dovgalyuk wrote: > > @@ -2751,6 +2757,7 @@ int main(int argc, char **argv, char **envp) > > { > > int i; > > int snapshot, linux_boot; > > +const char *icount_option = NU

Re: [Qemu-devel] unable to set SATA serial with a spaces

2015-02-20 Thread Alan Latteri
Yes, left pad. This is a strace of the authorization program via VirtualBox data[96]=["\0\200\0\24ABCD1234\0\0\0\0\0\0\0\0"…] then the same thing using the serial setting no spaces in QEMU. data[96]=["\0\200\0\024ABCD1234\0\0\0\0\0\0\0\0"…] The spaces matter here. I tr

Re: [Qemu-devel] [PATCH v3 2/3] Add migrate_incoming

2015-02-20 Thread Markus Armbruster
I'd like Eric's opinion on on encoding configuration tuples as URIs rather than JSON in QMP. "Dr. David Alan Gilbert (git)" writes: > From: "Dr. David Alan Gilbert" > > Add migrate_incoming/migrate-incoming to start an incoming > migration. > > Once a qemu has been started with > -incoming

Re: [Qemu-devel] [PATCH v3 1/3] Add -incoming defer

2015-02-20 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" writes: > > > From: "Dr. David Alan Gilbert" > > > > -incoming defer causes qemu to wait for an incoming migration > > to be specified later. The monitor can be used to set migration > > capabilities that may affect

[Qemu-devel] [Bug 1412098] Re: qemu crashes when ctrl-alt-u is pressed

2015-02-20 Thread Ingo Krabbe
A build from the current master attached in gdb reveals Program received signal SIGSEGV, Segmentation fault. sdl_switch (dcl=0x7f4db26e4b20, new_surface=new_surface@entry=0x0) at ui/sdl.c:128 128 PixelFormat pf = qemu_pixelformat_from_pixman(new_surface->format); (gdb) bt #0 sdl_switch (

Re: [Qemu-devel] [PATCH v3 2/3] Add migrate_incoming

2015-02-20 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > I'd like Eric's opinion on on encoding configuration tuples as URIs > rather than JSON in QMP. Old discussion; he's already R-b the previous version of this patch where the only difference was pause/defer. Dave > > "Dr. David Alan Gilbert (git)"

Re: [Qemu-devel] [PATCH v3 3/3] Document -incoming options

2015-02-20 Thread Markus Armbruster
"Dr. David Alan Gilbert (git)" writes: > From: "Dr. David Alan Gilbert" > > Document the various URI formats for -incoming, the previous > manpage and help text was wrong (out of date?) Thanks a lot for updating the docs. > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: Juan Quintela

Re: [Qemu-devel] unable to set SATA serial with a spaces

2015-02-20 Thread Alan Latteri
From what I can tell in the code, padstr() is only coded in the IDE section, not SCSI/SATA? > On Feb 19, 2015, at 11:42 PM, Markus Armbruster wrote: > > John Snow mailto:js...@redhat.com>> writes: > >> On 02/19/2015 02:48 PM, Alan Latteri wrote: >>> I am virtualzing a physical server for whic

[Qemu-devel] [Bug 1412098] Re: qemu crashes when ctrl-alt-u is pressed

2015-02-20 Thread Ingo Krabbe
Actually in any version this can never work, as you call sdl_switch(dcl,NULL); in ui/sdl.c:552. So the dereferncing statement new_surface->format must SEGFAULT. The obvious patch is very simple, of course, as just the statement below line 128 asks if(new_surface). So pf should be initial

Re: [Qemu-devel] unable to set SATA serial with a spaces

2015-02-20 Thread Markus Armbruster
Alan Latteri writes: > Yes, left pad. This is a strace of the authorization program via VirtualBox > data[96]=["\0\200\0\24ABCD1234\0\0\0\0\0\0\0\0"…] > > then the same thing using the serial setting no spaces in QEMU. > > data[96]=["\0\200\0\024ABCD1234\0\0\0\0\0\0\0\0"…

Re: [Qemu-devel] [PATCH v3 1/3] Add -incoming defer

2015-02-20 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert (git)" writes: >> >> > From: "Dr. David Alan Gilbert" >> > >> > -incoming defer causes qemu to wait for an incoming migration >> > to be specified later. The monitor can be used to set

Re: [Qemu-devel] [PATCH 00/11] target-aarch64 fix and improvments

2015-02-20 Thread Laurent Desnogues
On Thu, Feb 19, 2015 at 10:14 PM, Richard Henderson wrote: > While doing the mechanics of a previous patch set converting > translators to use to TCGLabel pointers, I was reminded of > several outstanding OPTME comments in the aarch64 translator. > > I had started with the csel change, which at fi

Re: [Qemu-devel] [RFC PATCH v9 22/23] replay: command line options

2015-02-20 Thread Paolo Bonzini
On 20/02/2015 09:02, Pavel Dovgaluk wrote: >> > >> > Is it possible to call this together with configure_icount (or even from >> > configure_icount)? > I think that it is the best place for replay_configure. > It sets replay_mode which may be checked while configuring the virtual > machine. > T

[Qemu-devel] [PATCH 0/2] vhost: support for cross endian

2015-02-20 Thread Greg Kurz
This patchset allows vhost_net to be used with legacy virtio when guest and host have different endianness. It depends on the following kernel patchset: https://lists.linuxfoundation.org/pipermail/virtualization/2015-February/029347.html --- Cédric Le Goater (1): vhost_net: re-enable when

[Qemu-devel] [PATCH 1/2] vhost: add VHOST_VRING_F_LEGACY_BIG_ENDIAN flag

2015-02-20 Thread Greg Kurz
When the guest and the host have a different endian order, the data being accessed in the vring queues needs to be byteswapped if we run in legacy mode. This patch adds a flag to inform the vhost kernel backend about the endianness to use. This patch is based on previous work by Cédric Le Goater.

[Qemu-devel] [PATCH 2/2] vhost_net: re-enable when cross endian

2015-02-20 Thread Greg Kurz
From: Cédric Le Goater revert 371df9f5e0f1 "vhost-net: disable when cross-endian" Signed-off-by: Cédric Le Goater Signed-off-by: Greg Kurz --- hw/net/vhost_net.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c index 4e3a061..72

Re: [Qemu-devel] [PATCH 00/11] target-aarch64 fix and improvments

2015-02-20 Thread Laurent Desnogues
On Fri, Feb 20, 2015 at 11:00 AM, Laurent Desnogues wrote: > On Thu, Feb 19, 2015 at 10:14 PM, Richard Henderson wrote: >> While doing the mechanics of a previous patch set converting >> translators to use to TCGLabel pointers, I was reminded of >> several outstanding OPTME comments in the aarch6

Re: [Qemu-devel] [PATCH v13 00/17] block: incremental backup series

2015-02-20 Thread Stefan Hajnoczi
On Fri, Feb 13, 2015 at 05:08:41PM -0500, John Snow wrote: > This series requires: [PATCH v3] blkdebug: fix "once" rule > > Welcome to the "incremental backup" newsletter, where we discuss > exciting developments in non-redundant backup technology. > This issue is called the "Max Reitz Fixup" issu

Re: [Qemu-devel] [PATCH v13 15/17] iotests: add simple incremental backup case

2015-02-20 Thread Stefan Hajnoczi
On Fri, Feb 13, 2015 at 05:08:56PM -0500, John Snow wrote: > +def check_incremental(self, target=None): > +if target is None: > +target = self.bitmaps[-1].last_target() > +self.assertTrue(iotests.compare_images(self.test_img, target)) > +return True > + > + >

Re: [Qemu-devel] [PATCH v13 05/17] hbitmap: add hbitmap_merge

2015-02-20 Thread Stefan Hajnoczi
On Fri, Feb 13, 2015 at 05:08:46PM -0500, John Snow wrote: > We add a bitmap merge operation to assist in error cases > where we wish to combine two bitmaps together. > > This is algorithmically O(bits) provided HBITMAP_LEVELS remains > constant. For a full bitmap on a 64bit machine: > sum(bits/64

Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread Peter Maydell
On 19 February 2015 at 18:56, Paolo Bonzini wrote: > > > On 18/02/2015 22:09, Programmingkid wrote: >> + # Take an image and make the image its own icon: >> + sips -i ../pc-bios/qemu-nsis.ico >> + # Extract the icon to its own resource file: >> + DeRez -only icns ../pc-bios/qemu-ns

Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread Paolo Bonzini
On 20/02/2015 13:18, Peter Maydell wrote: > Why not just use the sips --out option to specify a different > output file? That way we automatically put the current icon > into the executable, and don't have to update a hand-created > qemu.rsrc file in git if we change the icon in future (and I > b

[Qemu-devel] [PATCH for-2.3 0/3] Support more than 8 MMU modes, speedup by 10%

2015-02-20 Thread Paolo Bonzini
Patches 1 and 2 enable support from more than 8 MMU modes in TCG (patch 1 is in the targets, patch 2 is in cpu-defs.h). The TLB size is reduced proportionally on targets where that is necessary. Patch 3 uses the new support in the PPC target. Paolo Paolo Bonzini (3): tcg: add TCG_TARGET_TLB_D

[Qemu-devel] [PATCH 3/3] target-ppc: use separate indices for various translation modes

2015-02-20 Thread Paolo Bonzini
PowerPC TCG flushes the TLB on every IR/DR change, which basically means on every user<->kernel context switch. Encode IR/DR in the MMU index. This brings the number of TLB flushes down from ~90 to ~5 for starting up the Debian installer, which is in line with x86 and gives a ~10% perform

[Qemu-devel] [PATCH 2/3] softmmu: support up to 12 MMU modes

2015-02-20 Thread Paolo Bonzini
At 8k per TLB (for 64-bit host or target), 8 or more modes make the TLBs bigger than 64k, and some RISC TCG backends do not like that. On the affected hosts, cut the TLB size in half---there is still a measurable speedup on PPC with the next patch. Signed-off-by: Paolo Bonzini --- include/exec/

[Qemu-devel] [PATCH 1/3] tcg: add TCG_TARGET_TLB_DISPLACEMENT_BITS

2015-02-20 Thread Paolo Bonzini
This will be used to size the TLB when more than 8 MMU modes are used by the target. Limitations come from the limited size of the immediate fields (which sometimes, as in the case of Aarch64, extend to instructions that shift the immediate). Signed-off-by: Paolo Bonzini --- tcg/aarch64/tcg-tar

Re: [Qemu-devel] [PATCH 3/3] target-ppc: use separate indices for various translation modes

2015-02-20 Thread Alexander Graf
On 20.02.15 13:45, Paolo Bonzini wrote: > PowerPC TCG flushes the TLB on every IR/DR change, which basically > means on every user<->kernel context switch. Encode IR/DR in the > MMU index. > > This brings the number of TLB flushes down from ~90 to ~5 > for starting up the Debian install

Re: [Qemu-devel] [PATCH v3 2/3] Add migrate_incoming

2015-02-20 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Markus Armbruster (arm...@redhat.com) wrote: >> I'd like Eric's opinion on on encoding configuration tuples as URIs >> rather than JSON in QMP. > > Old discussion; he's already R-b the previous version of this > patch where the only difference was pause/defer.

[Qemu-devel] [PATCH v2 2/2] target-mips: add missing MSACSR and restore fp_status and hflags

2015-02-20 Thread Leon Alrae
Save MSACSR state. Also remove fp_status, msa_fp_status, hflags and restore them in post_load() from the architectural registers. Float exception flags are not present in vmstate. Information they carry is used only by softfloat caller who translates them into MIPS FCSR.Cause, FCSR.Flags and then t

[Qemu-devel] [PATCH v2 1/2] target-mips: replace cpu_save/cpu_load with VMStateDescription

2015-02-20 Thread Leon Alrae
Create VMStateDescription for MIPS CPU. The new structure contains exactly the same fields as before, therefore leaving existing version_id. Signed-off-by: Leon Alrae --- target-mips/cpu-qom.h | 4 + target-mips/cpu.c | 1 + target-mips/cpu.h | 2 - target-mips/machine.c | 567

[Qemu-devel] [PATCH v2 0/2] target-mips: port MIPS CPU to VMState

2015-02-20 Thread Leon Alrae
Hi, This small patchset converts MIPS CPU to use VMStateDescription: [1/2]: ports all the MIPS CPU fields to new VMStateDescription structure [2/2]: adds MSACSR and uses post_load() to restore *fp_status from *CSR registers. These changes include ported Maciej's updates made for old

Re: [Qemu-devel] [PATCH] target-ppc: Use movcond in isel

2015-02-20 Thread Alexander Graf
On 20.02.15 07:20, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target-ppc/translate.c | 29 +++-- > 1 file changed, 11 insertions(+), 18 deletions(-) > --- > Note that this is relative to an outstanding TCG patch set. > The full tree is at > >

Re: [Qemu-devel] [PATCH] target-mips: fix CP0.BadVAddr by stopping translation on Address error

2015-02-20 Thread Maciej W. Rozycki
On Thu, 19 Feb 2015, Leon Alrae wrote: > > I think this deserves a better description as it is about the specific > > case of an unaligned standard MIPS instruction fetch. Address Error > > exceptions can also happen for other reasons: unaligned data accesses or > > any accesses outside memor

Re: [Qemu-devel] [PATCH 2/2] target-mips: add missing MSA and correct FP in VMState

2015-02-20 Thread Maciej W. Rozycki
On Thu, 19 Feb 2015, Leon Alrae wrote: > > Surely these fp_status fields are simply implementation of the architectural > > CSR registers? > > > > IMO you shouldn't store things related to TCG state, but always how the > > architecture represents it. That way you're free to change the TCG > > im

Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread François Revol
On 20/02/2015 13:36, Paolo Bonzini wrote: > > > On 20/02/2015 13:18, Peter Maydell wrote: >> Why not just use the sips --out option to specify a different >> output file? That way we automatically put the current icon >> into the executable, and don't have to update a hand-created >> qemu.rsrc fi

Re: [Qemu-devel] [PATCH 2/3] spapr: Clean up misuse of qdev_init() in xics-kvm creation

2015-02-20 Thread Alexander Graf
On 05.02.15 10:34, Markus Armbruster wrote: > We call try_create_xics() to create a "xics-kvm". If it fails, we > call it again to fall back to plain "xics". > > try_create_xics() uses qdev_init(). qdev_init()'s error handling has > an unwanted side effect: it calls qerror_report_err(), which

Re: [Qemu-devel] [Fwd: Re: [PATCH 1/2] qemu-img convert: Rewrite copying logic]

2015-02-20 Thread Peter Lieven
Am 20.02.2015 um 14:27 schrieb Peter Lieven: > > On 2015-02-19 at 10:47, Kevin Wolf wrote: >> Am 18.02.2015 um 18:18 hat Max Reitz geschrieben: > [snip] > >>> Actually, now that I'm looking at is_allocated_sectors_min(), if the >>> first sectors is not allocated, it will return false and thus both

Re: [Qemu-devel] [Fwd: [PATCH v2] vpc: Implement bdrv_co_get_block_status()]

2015-02-20 Thread Peter Lieven
Am 19.02.2015 um 13:07 schrieb Kevin Wolf: > Am 18.02.2015 um 22:03 hat Peter Lieven geschrieben: >> Am 18.02.2015 um 21:57 schrieb Peter Lieven: >>> This implements bdrv_co_get_block_status() for VHD images. This can >>> significantly speed up qemu-img convert operation because only with this >>>

[Qemu-devel] [PATCH 0/3] Support streaming to an intermediate layer

2015-02-20 Thread Alberto Garcia
Hello, I added support to the Block Stream API for streaming to an intermediate layer. I followed the proposed API from the wiki, which simply adds an additional 'top' parameter to block-stream specifying the image that data is written to: http://wiki.qemu.org/Features/Snapshots#Streaming_to_an_

[Qemu-devel] [PATCH 3/3] docs: Document how to stream to an intermediate layer

2015-02-20 Thread Alberto Garcia
Signed-off-by: Alberto Garcia --- docs/live-block-ops.txt | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/docs/live-block-ops.txt b/docs/live-block-ops.txt index a257087..63530e8 100644 --- a/docs/live-block-ops.txt +++ b/docs/live-block-ops.txt @

Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models

2015-02-20 Thread Alexander Graf
On 17.02.15 15:24, Michael Mueller wrote: > This patch implements the static part of the s390 cpu class definitions. > It defines s390 cpu models by means of virtual cpu ids (enum) which contain > information on the cpu generation, the machine class, the GA number and > the machine type. The cpu

[Qemu-devel] [PATCH 2/3] block: Add QMP support for streaming to an intermediate layer

2015-02-20 Thread Alberto Garcia
This adds the 'top' parameter to the 'block-stream' QMP command and checks that its value is valid before passing it to stream_start(). Signed-off-by: Alberto Garcia --- blockdev.c| 19 +++ hmp.c | 2 +- include/qapi/qmp/qerror.h | 3 +++ qap

[Qemu-devel] [PATCH 1/3] block: Support streaming to an intermediate layer

2015-02-20 Thread Alberto Garcia
This adds a new 'top' parameter to stream_start(), that specifies the block device where the data will be written. The image is changed to read-write mode during the streaming and back to read-only afterwards. This also unblocks the stream operation in backing files. Signed-off-by: Alberto Garcia

Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models

2015-02-20 Thread Alexander Graf
On 17.02.15 15:24, Michael Mueller wrote: > This patch implements the static part of the s390 cpu class definitions. > It defines s390 cpu models by means of virtual cpu ids (enum) which contain > information on the cpu generation, the machine class, the GA number and > the machine type. The cpu

Re: [Qemu-devel] [PATCH 10/11] target-arm: Implement fccmp branchless

2015-02-20 Thread Laurent Desnogues
Hi Richard, On Thu, Feb 19, 2015 at 10:14 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target-arm/translate-a64.c | 50 > +++--- > 1 file changed, 29 insertions(+), 21 deletions(-) > > diff --git a/target-arm/translate-a64.c b/

Re: [Qemu-devel] [RFC PATCH v2 09/15] cpu-model/s390: Add KVM VM attribute interface routines

2015-02-20 Thread Alexander Graf
On 17.02.15 15:24, Michael Mueller wrote: > The patch implements routines to set and retrieve processor configuration > data and to retrieve machine configuration data. The machine related data > is used together with the cpu model facility lists to determine the list of > supported cpu models of

Re: [Qemu-devel] [RFC PATCH v2 13/15] cpu-model/s390: Add processor property routines

2015-02-20 Thread Alexander Graf
On 17.02.15 15:24, Michael Mueller wrote: > This patch implements the functions: > > - s390_get_proceccor_props() > - s390_set_proceccor_props() > > They can be used to request or retrieve processor related information from an > accelerator. > That information comprises the cpu identifier, the

Re: [Qemu-devel] [PATCH 0/2] ppc: Automatically set vga framebuffer endianness based on guest

2015-02-20 Thread Alexander Graf
On 10.02.15 05:36, David Gibson wrote: > This is a reworked version of BenH's patch to set VGA framebuffer > endianess based on the endianness of the guest (as determined by the > H_SET_MODE hypercall). > > I've split the patch into two parts the first adding the object > property to the VGA dev

[Qemu-devel] [PATCH 0/2] Fix GCC 5.0.0 build errors

2015-02-20 Thread Radim Krčmář
GCC is more strict now. Radim Krčmář (2): fix GCC 5.0.0 logical-not-parentheses warnings milkymist-pfpu: fix GCC 5.0.0 aggressive-loop-optimizations warning hw/misc/milkymist-pfpu.c | 18 -- hw/net/virtio-net.c | 2 +- kvm-all.c| 2 +- qemu-img.c

[Qemu-devel] [PATCH 2/2] milkymist-pfpu: fix GCC 5.0.0 aggressive-loop-optimizations warning

2015-02-20 Thread Radim Krčmář
man gcc: Warn if in a loop with constant number of iterations the compiler detects undefined behavior in some statement during one or more of the iterations. Refactored the code a bit to avoid the GCC warning, in an objectionable way, hw/misc/milkymist-pfpu.c: In function ‘pfpu_write’: h

[Qemu-devel] [PATCH 1/2] fix GCC 5.0.0 logical-not-parentheses warnings

2015-02-20 Thread Radim Krčmář
man gcc: Warn about logical not used on the left hand side operand of a comparison. This option does not warn if the RHS operand is of a boolean type. By preferring bool over int where sensible, but without modifying any depending code, make GCC happy in cases like this, qemu-img.c: In fu

Re: [Qemu-devel] [PATCH v13 15/17] iotests: add simple incremental backup case

2015-02-20 Thread Max Reitz
On 2015-02-20 at 05:02, Stefan Hajnoczi wrote: On Fri, Feb 13, 2015 at 05:08:56PM -0500, John Snow wrote: +def check_incremental(self, target=None): +if target is None: +target = self.bitmaps[-1].last_target() +self.assertTrue(iotests.compare_images(self.test_img,

Re: [Qemu-devel] [PATCH 2/2] milkymist-pfpu: fix GCC 5.0.0 aggressive-loop-optimizations warning

2015-02-20 Thread Radim Krčmář
2015-02-20 15:18+0100, Radim Krčmář: > diff --git a/hw/misc/milkymist-pfpu.c b/hw/misc/milkymist-pfpu.c > @@ -164,6 +164,13 @@ output_queue_advance(MilkymistPFPUState *s) > static int pfpu_decode_insn(MilkymistPFPUState *s) > { > uint32_t pc = s->regs[R_PC]; > + > +if (pc > MICROCODE_WOR

Re: [Qemu-devel] [PATCH RFC V2 14/17] hw/pci: piix - suport multiple host bridges

2015-02-20 Thread Alexander Graf
On 16.02.15 14:29, Marcel Apfelbaum wrote: > On 02/16/2015 03:00 PM, Alexander Graf wrote: >> >> >> On 16.02.15 10:54, Marcel Apfelbaum wrote: >>> From: Marcel Apfelbaum >>> >>> Instead of assuming it has only one bus, it >>> enumerates all the host bridges until it finds >>> the one with bus nu

Re: [Qemu-devel] [PATCH 2/2] milkymist-pfpu: fix GCC 5.0.0 aggressive-loop-optimizations warning

2015-02-20 Thread Paolo Bonzini
On 20/02/2015 15:18, Radim Krčmář wrote: > man gcc: > Warn if in a loop with constant number of iterations the compiler > detects undefined behavior in some statement during one or more of > the iterations. > > Refactored the code a bit to avoid the GCC warning, in an objectionable > way,

Re: [Qemu-devel] [PATCH 1/2] fix GCC 5.0.0 logical-not-parentheses warnings

2015-02-20 Thread Paolo Bonzini
On 20/02/2015 15:18, Radim Krčmář wrote: > man gcc: > Warn about logical not used on the left hand side operand of a > comparison. This option does not warn if the RHS operand is of a > boolean type. > > By preferring bool over int where sensible, but without modifying any > depending cod

Re: [Qemu-devel] [PATCH 2/2] milkymist-pfpu: fix GCC 5.0.0 aggressive-loop-optimizations warning

2015-02-20 Thread Peter Maydell
On 20 February 2015 at 23:18, Radim Krčmář wrote: > man gcc: > Warn if in a loop with constant number of iterations the compiler > detects undefined behavior in some statement during one or more of > the iterations. > > Refactored the code a bit to avoid the GCC warning, in an objectionable

Re: [Qemu-devel] [PATCH 2/2] milkymist-pfpu: fix GCC 5.0.0 aggressive-loop-optimizations warning

2015-02-20 Thread Michael Walle
Am 2015-02-20 15:36, schrieb Paolo Bonzini: On 20/02/2015 15:18, Radim Krčmář wrote: man gcc: Warn if in a loop with constant number of iterations the compiler detects undefined behavior in some statement during one or more of the iterations. Refactored the code a bit to avoid the GCC war

Re: [Qemu-devel] [PATCH 2/2] milkymist-pfpu: fix GCC 5.0.0 aggressive-loop-optimizations warning

2015-02-20 Thread Paolo Bonzini
On 20/02/2015 15:52, Michael Walle wrote: >>> >>> -i = 0; >>> -while (pfpu_decode_insn(s)) { >>> -/* decode at most MICROCODE_WORDS instructions */ >>> -if (i++ >= MICROCODE_WORDS) { >> >> Isn't the fix just to say "++i" instead of "i++"? >

Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models

2015-02-20 Thread Michael Mueller
On Fri, 20 Feb 2015 14:54:23 +0100 Alexander Graf wrote: > > > > +/* machine related properties */ > > +typedef struct S390CPUMachineProps { > > +uint16_t class; /* machine class */ > > +uint16_t ga; /* availability number of machine */ > > +uint16_t order; /* orde

Re: [Qemu-devel] [RFC PATCH v2 09/15] cpu-model/s390: Add KVM VM attribute interface routines

2015-02-20 Thread Michael Mueller
On Fri, 20 Feb 2015 14:59:20 +0100 Alexander Graf wrote: > > +typedef struct S390ProcessorProps { > > +uint64_t cpuid; > > +uint16_t ibc; > > +uint8_t pad[6]; > > +uint64_t fac_list[S390_ARCH_FAC_LIST_SIZE_UINT64]; > > +} S390ProcessorProps; > > + > > +typedef struct S390MachineP

Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models

2015-02-20 Thread Alexander Graf
> Am 20.02.2015 um 16:00 schrieb Michael Mueller : > > On Fri, 20 Feb 2015 14:54:23 +0100 > Alexander Graf wrote: > >>> >>> +/* machine related properties */ >>> +typedef struct S390CPUMachineProps { >>> +uint16_t class; /* machine class */ >>> +uint16_t ga; /* availabil

[Qemu-devel] [Bug 1412098] Re: qemu crashes when ctrl-alt-u is pressed

2015-02-20 Thread Legorol
Ingo Krabbe's suggested change fixes the issue for me. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1412098 Title: qemu crashes when ctrl-alt-u is pressed Status in QEMU: New Bug description:

Re: [Qemu-devel] [RFC PATCH v2 13/15] cpu-model/s390: Add processor property routines

2015-02-20 Thread Michael Mueller
On Fri, 20 Feb 2015 15:03:30 +0100 Alexander Graf wrote: > > > > - s390_get_proceccor_props() > > - s390_set_proceccor_props() > > > > They can be used to request or retrieve processor related information from > > an accelerator. > > That information comprises the cpu identifier, the ICB value

Re: [Qemu-devel] [PATCH 2/2] milkymist-pfpu: fix GCC 5.0.0 aggressive-loop-optimizations warning

2015-02-20 Thread Radim Krčmář
2015-02-20 23:40+0900, Peter Maydell: > On 20 February 2015 at 23:18, Radim Krčmář wrote: > > man gcc: > > Warn if in a loop with constant number of iterations the compiler > > detects undefined behavior in some statement during one or more of > > the iterations. > > > > Refactored the code

Re: [Qemu-devel] [PATCH 1/3] coroutine: Fix use after free with qemu_coroutine_yield()

2015-02-20 Thread Kevin Wolf
Am 10.02.2015 um 11:41 hat Kevin Wolf geschrieben: > Instead of using the same function for entering and exiting coroutines, > and hoping that it doesn't add any functionality that hurts with the > parameters used for exiting, we can just directly call into the real > task switch in qemu_coroutine_

Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models

2015-02-20 Thread Michael Mueller
On Fri, 20 Feb 2015 14:55:32 +0100 Alexander Graf wrote: > > /** > > * S390CPUClass: > > * @parent_realize: The parent class' realize handler. > > @@ -52,6 +69,11 @@ typedef struct S390CPUClass { > > void (*load_normal)(CPUState *cpu); > > void (*cpu_reset)(CPUState *cpu); > >

Re: [Qemu-devel] [PATCH v2 2/2] target-mips: add missing MSACSR and restore fp_status and hflags

2015-02-20 Thread Richard Henderson
On 02/20/2015 05:07 AM, Leon Alrae wrote: > Save MSACSR state. Also remove fp_status, msa_fp_status, hflags and restore > them in post_load() from the architectural registers. > Float exception flags are not present in vmstate. Information they carry > is used only by softfloat caller who translate

Re: [Qemu-devel] [PATCH v3 2/3] Add migrate_incoming

2015-02-20 Thread Eric Blake
On 02/20/2015 01:18 AM, Markus Armbruster wrote: > I'd like Eric's opinion on on encoding configuration tuples as URIs > rather than JSON in QMP. > >> +{ 'command': 'migrate-incoming', 'data': {'uri': 'str' } } >> + >> # @xen-save-devices-state: >> # >> # Save the state of all devices to file.

Re: [Qemu-devel] [RFC PATCH v2 13/15] cpu-model/s390: Add processor property routines

2015-02-20 Thread Andreas Färber
Am 20.02.2015 um 16:32 schrieb Michael Mueller: > On Fri, 20 Feb 2015 15:03:30 +0100 > Alexander Graf wrote: > >>> >>> - s390_get_proceccor_props() >>> - s390_set_proceccor_props() >>> >>> They can be used to request or retrieve processor related information from >>> an accelerator. >>> That inf

Re: [Qemu-devel] [PATCH 1/2] fix GCC 5.0.0 logical-not-parentheses warnings

2015-02-20 Thread Radim Krčmář
2015-02-20 15:38+0100, Paolo Bonzini: > On 20/02/2015 15:18, Radim Krčmář wrote: > > -if (!!n->vhost_started == > > +if ((!!n->vhost_started) == > > (virtio_net_started(n, status) && !nc->peer->link_down)) { > > Does it still break if you just swap the terms? No (there is no logi

Re: [Qemu-devel] [PATCH 2/2] milkymist-pfpu: fix GCC 5.0.0 aggressive-loop-optimizations warning

2015-02-20 Thread Radim Krčmář
2015-02-20 15:55+0100, Paolo Bonzini: > > > On 20/02/2015 15:52, Michael Walle wrote: > >>> > >>> -i = 0; > >>> -while (pfpu_decode_insn(s)) { > >>> -/* decode at most MICROCODE_WORDS instructions */ > >>> -if (i++ >= MICROCODE_WORDS) { > >>

Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models

2015-02-20 Thread Michael Mueller
On Fri, 20 Feb 2015 16:22:20 +0100 Alexander Graf wrote: > >> > >> Just make this uint64_t fac_list[2]. That way we don't have to track any > >> messy allocations. > > > > It will be something like "uint64_t > > fac_list[S390_CPU_FAC_LIST_SIZE_UINT64]" and in total 2KB > > not just 16 bytes

Re: [Qemu-devel] [PATCH 10/11] target-arm: Implement fccmp branchless

2015-02-20 Thread Richard Henderson
On 02/20/2015 05:57 AM, Laurent Desnogues wrote: > The problem with this approach is that you'll always call the FP > compare which might result in FP flags corruption. > > The ARMv8 manual clearly states that the FP compare should only be > called if the condition holds. Ah, I hadn't considered

Re: [Qemu-devel] [RFC PATCH v2 13/15] cpu-model/s390: Add processor property routines

2015-02-20 Thread Michael Mueller
On Fri, 20 Feb 2015 16:41:49 +0100 Andreas Färber wrote: > Can't you just implement the class-level name-to-ObjectClass callback > that other CPUs have grown for the above use case? If it fulfills the requirements sure. Please point me to an example, sounds that s390_select_cpu_model() is doing

Re: [Qemu-devel] [PATCH v13 15/17] iotests: add simple incremental backup case

2015-02-20 Thread John Snow
On 02/20/2015 05:02 AM, Stefan Hajnoczi wrote: On Fri, Feb 13, 2015 at 05:08:56PM -0500, John Snow wrote: +def check_incremental(self, target=None): +if target is None: +target = self.bitmaps[-1].last_target() +self.assertTrue(iotests.compare_images(self.test_im

Re: [Qemu-devel] [RFC PATCH v2 10/15] cpu-model/s390: Add cpu class initialization routines

2015-02-20 Thread Richard Henderson
On 02/17/2015 06:24 AM, Michael Mueller wrote: > +/** > + * s390_test_facility - test if given facility bit is set facility list > + * of given cpu class > + * @class: address of cpu class to test > + * @nr: bit number to test > + * > + * Returns: true in case it is set > + *

Re: [Qemu-devel] [RFC PATCH v2 13/15] cpu-model/s390: Add processor property routines

2015-02-20 Thread Michael Mueller
On Fri, 20 Feb 2015 16:41:49 +0100 Andreas Färber wrote: > Also a general comment: cpu-model/ is not an existing directory nor one > you add, so please use "target-s390x: Add foo to S390CPU" or so. I will address this with v3, thanks a lot for the hint, I never saw this as directories though...

[Qemu-devel] [PATCH 1/2] fix GCC 5.0.0 logical-not-parentheses warnings

2015-02-20 Thread Radim Krčmář
man gcc: Warn about logical not used on the left hand side operand of a comparison. This option does not warn if the RHS operand is of a boolean type. By preferring bool over int where sensible, but without modifying any depending code, make GCC happy in cases like this, qemu-img.c: In fu

[Qemu-devel] [PATCH 2/2] milkymist-pfpu: fix GCC 5.0.0 aggressive-loop-optimizations warning

2015-02-20 Thread Radim Krčmář
man gcc: Warn if in a loop with constant number of iterations the compiler detects undefined behavior in some statement during one or more of the iterations. Milkymist pfpu has no jump instructions, so checking for MICROCODE_WORDS instructions should have kept us in bounds of s->microcode, b

Re: [Qemu-devel] [RFC PATCH v2 10/15] cpu-model/s390: Add cpu class initialization routines

2015-02-20 Thread Michael Mueller
On Fri, 20 Feb 2015 08:02:42 -0800 Richard Henderson wrote: > > +/** > > + * s390_test_facility - test if given facility bit is set facility list > > + * of given cpu class > > + * @class: address of cpu class to test > > + * @nr: bit number to test > > + * > > + * Returns: t

Re: [Qemu-devel] [PATCH 2/2] milkymist-pfpu: fix GCC 5.0.0 aggressive-loop-optimizations warning

2015-02-20 Thread Michael Walle
Am 2015-02-20 16:37, schrieb Radim Krčmář: 2015-02-20 23:40+0900, Peter Maydell: On 20 February 2015 at 23:18, Radim Krčmář wrote: > man gcc: > Warn if in a loop with constant number of iterations the compiler > detects undefined behavior in some statement during one or more of > the iter

[Qemu-devel] [PATCH 0/2] Fix GCC 5.0.0 build errors

2015-02-20 Thread Radim Krčmář
Future patches should address the out-of-bounds access that is left by using proposed solution for [2/2]. Radim Krčmář (2): fix GCC 5.0.0 logical-not-parentheses warnings milkymist-pfpu: fix GCC 5.0.0 aggressive-loop-optimizations warning hw/misc/milkymist-pfpu.c | 2 +- hw/net/virtio-net.c

[Qemu-devel] [PATCH 3/3] iothread: release iothread around aio_poll

2015-02-20 Thread Paolo Bonzini
This is the first step towards having fine-grained critical sections in dataplane threads, which resolves lock ordering problems between address_space_* functions (which need the BQL when doing MMIO, even after we complete RCU-based dispatch) and the AioContext. Because AioContext does not use con

[Qemu-devel] [PATCH 2/3] AioContext: acquire/release AioContext during aio_poll

2015-02-20 Thread Paolo Bonzini
This is the first step in pushing down acquire/release, and will let rfifolock drop the contention callback feature. Signed-off-by: Paolo Bonzini --- aio-posix.c | 9 + aio-win32.c | 8 include/block/aio.h | 15 --- 3 files changed, 25 insertions(+)

[Qemu-devel] [PATCH 1/3] aio-posix: move pollfds to thread-local storage

2015-02-20 Thread Paolo Bonzini
By using thread-local storage, aio_poll can stop using global data during g_poll_ns. This will make it possible to drop callbacks from rfifolock. Signed-off-by: Paolo Bonzini --- aio-posix.c | 77 ++--- async.c | 2 -- include

Re: [Qemu-devel] [RFC PATCH v2 13/15] cpu-model/s390: Add processor property routines

2015-02-20 Thread Andreas Färber
Am 20.02.2015 um 17:04 schrieb Michael Mueller: > On Fri, 20 Feb 2015 16:41:49 +0100 > Andreas Färber wrote: > >> Can't you just implement the class-level name-to-ObjectClass callback >> that other CPUs have grown for the above use case? > > If it fulfills the requirements sure. Please point me

[Qemu-devel] [PATCH RFC 0/3] iothread: release iothread around aio_poll

2015-02-20 Thread Paolo Bonzini
Right now, iothreads are relying on a "contention callback" to release the AioContext (e.g. for block device operations or to do bdrv_drain_all). This is necessary because aio_poll needs to be called within an aio_context_acquire. This series drops this requirement for aio_poll, with two effects:

Re: [Qemu-devel] [RFC PATCH v2 10/15] cpu-model/s390: Add cpu class initialization routines

2015-02-20 Thread Michael Mueller
On Fri, 20 Feb 2015 17:12:49 +0100 Michael Mueller wrote: > Good spot, it's not being used yet. It's planned to be used with a patch that > implements zPCI > related instructions on QEMU side. Maybe you have seen the discussion from > Frank Blaschka in > this e-mail list in regard to that. I w

Re: [Qemu-devel] [RFC PATCH v2 10/15] cpu-model/s390: Add cpu class initialization routines

2015-02-20 Thread Andreas Färber
Am 20.02.2015 um 17:12 schrieb Michael Mueller: > On Fri, 20 Feb 2015 08:02:42 -0800 > Richard Henderson wrote: > >>> +/** >>> + * s390_test_facility - test if given facility bit is set facility list >>> + * of given cpu class >>> + * @class: address of cpu class to test >>>

Re: [Qemu-devel] [PATCH 00/11] target-aarch64 fix and improvments

2015-02-20 Thread Alex Bennée
It's running through LAVA now: https://validation.linaro.org/scheduler/job/268253 On 19 February 2015 at 23:52, Peter Maydell wrote: > On 20 February 2015 at 06:14, Richard Henderson wrote: >> While doing the mechanics of a previous patch set converting >> translators to use to TCGLabel pointe

Re: [Qemu-devel] [PATCH v13 00/17] block: incremental backup series

2015-02-20 Thread Kashyap Chamarthy
On Fri, Feb 20, 2015 at 11:09:20AM +, Stefan Hajnoczi wrote: > On Fri, Feb 13, 2015 at 05:08:41PM -0500, John Snow wrote: > > This series requires: [PATCH v3] blkdebug: fix "once" rule > > > > Welcome to the "incremental backup" newsletter, where we discuss > > exciting developments in non-red

Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread Programmingkid
On Feb 20, 2015, at 7:36 AM, Paolo Bonzini wrote: > > > On 20/02/2015 13:18, Peter Maydell wrote: >> Why not just use the sips --out option to specify a different >> output file? That way we automatically put the current icon >> into the executable, and don't have to update a hand-created >> qe

Re: [Qemu-devel] [RFC PATCH v2 10/15] cpu-model/s390: Add cpu class initialization routines

2015-02-20 Thread Michael Mueller
On Fri, 20 Feb 2015 17:34:28 +0100 Andreas Färber wrote: > Please note that QEMU uses gtk-doc style, where the description goes > between arguments and Returns:, and the function name gets a ':'. > There's also fancy syntax like #CPUClass, %true, etc. On my TODOs... Thanks, Michael

Re: [Qemu-devel] [RFC PATCH v2 13/15] cpu-model/s390: Add processor property routines

2015-02-20 Thread Michael Mueller
On Fri, 20 Feb 2015 17:28:14 +0100 Andreas Färber wrote: Andreas, > Sorry for my ignorance, but what is proc actually needed for? For > initializing the class, there's .class_init (and cc->fac_list apparently > is initialized here). If you need to pass info to KVM, you can do so in yes, it is c

Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models

2015-02-20 Thread Alexander Graf
On 20.02.15 16:49, Michael Mueller wrote: > On Fri, 20 Feb 2015 16:22:20 +0100 > Alexander Graf wrote: > Just make this uint64_t fac_list[2]. That way we don't have to track any messy allocations. >>> >>> It will be something like "uint64_t >>> fac_list[S390_CPU_FAC_LIST_SIZE_

Re: [Qemu-devel] [RFC PATCH v2 09/15] cpu-model/s390: Add KVM VM attribute interface routines

2015-02-20 Thread Alexander Graf
On 20.02.15 16:18, Michael Mueller wrote: > On Fri, 20 Feb 2015 14:59:20 +0100 > Alexander Graf wrote: > >>> +typedef struct S390ProcessorProps { >>> +uint64_t cpuid; >>> +uint16_t ibc; >>> +uint8_t pad[6]; >>> +uint64_t fac_list[S390_ARCH_FAC_LIST_SIZE_UINT64]; >>> +} S390Proc

Re: [Qemu-devel] [PATCH 0/2] Fix GCC 5.0.0 build errors

2015-02-20 Thread Radim Krčmář
Cc: qemu-triv...@nongnu.org

Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread Paolo Bonzini
On 20/02/2015 17:54, Programmingkid wrote: >> I suspect the Windows icon is not a great match for Mac OS X which likes >> to have big sizes (48x48 or 128x128). > > Definitely true. > >> If you want to generate the .rsrc >> file automatically, the right source probably would be the .svg file, >

Re: [Qemu-devel] [PATCH v13 00/17] block: incremental backup series

2015-02-20 Thread John Snow
On 02/20/2015 06:09 AM, Stefan Hajnoczi wrote: On Fri, Feb 13, 2015 at 05:08:41PM -0500, John Snow wrote: This series requires: [PATCH v3] blkdebug: fix "once" rule Welcome to the "incremental backup" newsletter, where we discuss exciting developments in non-redundant backup technology. This

  1   2   >