On Thu, 19 Feb 2015, Leon Alrae wrote: > > I think this deserves a better description as it is about the specific > > case of an unaligned standard MIPS instruction fetch. Address Error > > exceptions can also happen for other reasons: unaligned data accesses or > > any accesses outside memory segments the current execution mode is allowed > > to reach. > > I believe that the one line change in the patch makes that clear. I > agree however that the description itself could be more precise.
I agree the patch itself is clear, but someone reading the commit might infer this is the only place the Address Error exception happens. Also the patch itself does not show up in some places, e.g. `git log' where -p hasn't been also supplied, to complement information provided in the log. > > While at it I think it may be worth double-checking if the other places > > that trigger this exception get it right. > > Other places seem to look fine. Even decode_micromips_opc handles it > correctly whereas decode_opc -– which obviously was implemented before > microMIPS -- never got fixed. Great that you checked, thanks! Maciej
