Re: [Qemu-devel] [PATCH RFC v5 1/5] qemu-iotests: qemu machine type support

2015-02-10 Thread Max Reitz
On 2015-02-10 at 02:59, Xiao Guang Chen wrote: This patch adds qemu machine type support to the io test suite. Based on the qemu default machine type and alias of the default machine type the reference output file can now vary from the default to a machine specific output file if necessary. When

Re: [Qemu-devel] [PATCH RFC v5 2/5] qemu-iotests: run qemu with -nodefaults and fix 067, 071, 087

2015-02-10 Thread Max Reitz
On 2015-02-10 at 02:59, Xiao Guang Chen wrote: This patch fixes an io test suite issue that was introduced with the commit c88930a6866e74953e931ae749781e98e486e5c8 'qemu-char: Permit only a single "stdio" character device'. The option supresses the creation of default devices such as the floopy a

Re: [Qemu-devel] [PATCH RFC v5 4/5] qemu-iotests: s390x: fix test 055

2015-02-10 Thread Max Reitz
On 2015-02-10 at 03:00, Xiao Guang Chen wrote: There is no 'ide-cd' device defined on s390 platform, so test_medium_not_found() test should be skipped. Signed-off-by: Xiao Guang Chen,che...@linux.vnet.ibm.com With this fixed as in the previous patches: Reviewed-by: Max Reitz --- tests/qe

Re: [Qemu-devel] [PATCH RFC v5 3/5] qemu-iotests: s390x: fix test 041

2015-02-10 Thread Max Reitz
On 2015-02-10 at 02:59, Xiao Guang Chen wrote: There is no 'ide-cd' device defined on s390 platform, so test_medium_not_found() test should be skipped. Signed-off-by: Xiao Guang Chen,che...@linux.vnet.ibm.com Again, should be "Xiao Guang Chen ". --- tests/qemu-iotests/041 | 6 ++ 1 fi

Re: [Qemu-devel] Revert commit 5af35d7feccaa7d26b72c6c3d14116421d736b36 - "usb-host-libusb: Fix reset handling"

2015-02-10 Thread Dennis Ostermann
Hello Hans, thanks for taking care. 09-02-15 09:09, Hans de Goede wrote: Hi, On 09-02-15 22:09, Dennis Ostermann wrote: Hi there, please revert commit 5af35d7feccaa7d26b72c6c3d14116421d736b36 - "usb-host-libusb: Fix reset handling" This breaks usb pass through of FTDI based usb devices:

Re: [Qemu-devel] [PATCH 2/9] monitor: Clean up around monitor_handle_fd_param()

2015-02-10 Thread Eric Blake
On 02/10/2015 09:34 AM, Markus Armbruster wrote: > monitor_handle_fd_param() is a wrapper around > monitor_handle_fd_param2() that feeds errors to qerror_report_err() > instead of returning them. qerror_report_err() is inappropriate in > many contexts. monitor_handle_fd_param() looks simpler than

Re: [Qemu-devel] [PATCH] block: vmdk - fixed sizeof() error

2015-02-10 Thread Eric Blake
On 02/10/2015 11:22 AM, Jeff Cody wrote: > The size compared should be PATH_MAX, rather than sizeof(char *). > > Reported-by: Paolo Bonzini > Signed-off-by: Jeff Cody > --- > block/vmdk.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Eric Blake > > diff --git a/bloc

Re: [Qemu-devel] [PATCH RFC v5 5/5] qemu-iotests: s390x: fix test 051

2015-02-10 Thread Max Reitz
On 2015-02-10 at 03:00, Xiao Guang Chen wrote: The tests for device type "ide_cd" should only be tested for the pc platform. The default device id of hard disk on the s390 platform differs to that of the x86 platform. A new variable device_id is defined and "virtio0" set for the s390 platform. A

Re: [Qemu-devel] [PATCH RFC v2 1/8] qmp: print dirty bitmap

2015-02-10 Thread John Snow
On 01/27/2015 05:56 AM, Vladimir Sementsov-Ogievskiy wrote: Adds qmp and hmp commands to print dirty bitmap. This is needed only for testing. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 33 + blockdev.c| 13 +++

Re: [Qemu-devel] [PATCH RFC v2 3/8] block: BdrvDirtyBitmap serialization interface

2015-02-10 Thread John Snow
On 01/27/2015 05:56 AM, Vladimir Sementsov-Ogievskiy wrote: Several functions to provide necessary access to BdrvDirtyBitmap for block-migration.c Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 36 include/block/block.h | 12 +++

Re: [Qemu-devel] [PATCH RFC v2 2/8] hbitmap: serialization

2015-02-10 Thread John Snow
On 01/27/2015 05:56 AM, Vladimir Sementsov-Ogievskiy wrote: Functions to serialize / deserialize(restore) HBitmap. HBitmap should be saved to linear sequence of bits independently of endianness and bitmap array element (unsigned long) size. Therefore Little Endian is chosen. These functions ar

Re: [Qemu-devel] [PATCH RFC v2 4/8] block: add dirty-dirty bitmaps

2015-02-10 Thread John Snow
I had hoped it wouldn't come to this :) On 01/27/2015 05:56 AM, Vladimir Sementsov-Ogievskiy wrote: A dirty-dirty bitmap is a dirty bitmap for BdrvDirtyBitmap. It tracks set/unset changes of BdrvDirtyBitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 44 +

Re: [Qemu-devel] [PATCH RFC v2 6/8] block: add bdrv_next_dirty_bitmap()

2015-02-10 Thread John Snow
On 01/27/2015 05:56 AM, Vladimir Sementsov-Ogievskiy wrote: Like bdrv_next() - bdrv_next_dirty_bitmap() is a function to provide access to private dirty bitmaps list. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 10 ++ include/block/block.h | 2 ++ 2 f

Re: [Qemu-devel] [PATCH RFC v2 5/8] block: add bdrv_dirty_bitmap_enabled()

2015-02-10 Thread John Snow
On 01/27/2015 05:56 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 5 + include/block/block.h | 1 + 2 files changed, 6 insertions(+) diff --git a/block.c b/block.c index 8ab724b..15fc621 100644 --- a/block.c +++ b/block

Re: [Qemu-devel] [PATCH RFC v2 7/8] migration: add dirty parameter

2015-02-10 Thread John Snow
On 01/27/2015 05:56 AM, Vladimir Sementsov-Ogievskiy wrote: Add dirty parameter to qmp-migrate command. If this parameter is true, migration/block.c will migrate dirty bitmaps. This parameter can be used without "blk" parameter to migrate only dirty bitmaps, skipping block migration. Signed-of

Re: [Qemu-devel] [PATCH RFC v2 8/8] migration: add migration/dirty-bitmap.c

2015-02-10 Thread John Snow
Peter Maydell: What's the right way to license a file as copied from a previous version? See below, please; Max, Markus: ctrl+f "bdrv_get_device_name" and let me know what you think, if you would. Juan, Amit, David: Copying migration maintainers. On 01/27/2015 05:56 AM, Vladimir Sementsov-Og

Re: [Qemu-devel] [PATCH] block: vmdk - fixed sizeof() error

2015-02-10 Thread Max Reitz
On 2015-02-10 at 13:22, Jeff Cody wrote: The size compared should be PATH_MAX, rather than sizeof(char *). Reported-by: Paolo Bonzini Signed-off-by: Jeff Cody --- block/vmdk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) I just noticed iotest 059 failing, bisected it and the ch

Re: [Qemu-devel] [PATCH v12 02/17] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove

2015-02-10 Thread Max Reitz
On 2015-02-09 at 20:35, John Snow wrote: The new command pair is added to manage user created dirty bitmap. The dirty bitmap's name is mandatory and must be unique for the same device, but different devices can have bitmaps with the same names. The granularity is an optional field. If it is not

Re: [Qemu-devel] [PATCH v12 03/17] block: Introduce bdrv_dirty_bitmap_granularity()

2015-02-10 Thread Max Reitz
On 2015-02-09 at 20:35, John Snow wrote: This returns the granularity (in bytes) of dirty bitmap, which matches the QMP interface and the existing query interface. Small adjustments are made to ensure that granularity-- in bytes-- I guess these should be ASCII replacements of an em dash? But t

Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err()

2015-02-10 Thread Eduardo Habkost
On Tue, Feb 10, 2015 at 05:44:59PM +0100, Paolo Bonzini wrote: > > > On 10/02/2015 17:34, Markus Armbruster wrote: > > I've typed error_report("%s", error_get_pretty(ERR)) too many times > > already, and I've fixed too many instances of qerror_report_err(ERR) > > to error_report("%s", error_get_p

Re: [Qemu-devel] [PATCH v12 03/17] block: Introduce bdrv_dirty_bitmap_granularity()

2015-02-10 Thread Max Reitz
On 2015-02-09 at 20:35, John Snow wrote: This returns the granularity (in bytes) of dirty bitmap, which matches the QMP interface and the existing query interface. Small adjustments are made to ensure that granularity-- in bytes-- is handled consistently as a uint64_t throughout the code. Just

Re: [Qemu-devel] [PATCH v12 03/17] block: Introduce bdrv_dirty_bitmap_granularity()

2015-02-10 Thread John Snow
On 02/10/2015 05:13 PM, Max Reitz wrote: On 2015-02-09 at 20:35, John Snow wrote: This returns the granularity (in bytes) of dirty bitmap, which matches the QMP interface and the existing query interface. Small adjustments are made to ensure that granularity-- in bytes-- is handled consistent

Re: [Qemu-devel] [PATCH v12 04/17] hbitmap: add hbitmap_merge

2015-02-10 Thread Max Reitz
On 2015-02-09 at 20:35, John Snow wrote: We add a bitmap merge operation to assist in error cases where we wish to combine two bitmaps together. This is algorithmically O(bits) provided HBITMAP_LEVELS remains constant. For a full bitmap on a 64bit machine: sum(bits/64^k, k, 0, HBITMAP_LEVELS) ~=

Re: [Qemu-devel] [PATCH 0/2] qcow2: Respect new_block in alloc_refcount_block()

2015-02-10 Thread Eric Blake
On 02/10/2015 01:02 PM, Max Reitz wrote: > Under certain circumstances, making the refcount table grow can result > in leaking clusters. The first patch fixes at least some of those > circumstances (maybe there are more, but these are the ones I am aware > of), and the second patch adds a test case

Re: [Qemu-devel] [PATCH 0/2] qcow2: Respect new_block in alloc_refcount_block()

2015-02-10 Thread Max Reitz
On 2015-02-10 at 17:19, Eric Blake wrote: On 02/10/2015 01:02 PM, Max Reitz wrote: Under certain circumstances, making the refcount table grow can result in leaking clusters. The first patch fixes at least some of those circumstances (maybe there are more, but these are the ones I am aware of),

[Qemu-devel] [PATCH] balloon: Fix typo

2015-02-10 Thread Eric Blake
Commit 422e0501 introduced a typo (unless removing an 'o' from balloon is how you deflate it?) Signed-off-by: Eric Blake --- I'm usually good at spotting typos when giving my R-b. Oh well, Dave is doing well to make sure my ego doesn't get too inflated :) balloon.c | 6 +++--- 1 file changed,

Re: [Qemu-devel] [PATCH 8/9] balloon: Factor out common "is balloon active" test

2015-02-10 Thread Eric Blake
On 02/10/2015 11:39 AM, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: >> Signed-off-by: Markus Armbruster >> --- >> balloon.c | 29 +++-- >> 1 file changed, 15 insertions(+), 14 deletions(-) >> >> diff --git a/balloon.c b/balloon.c >> index

Re: [Qemu-devel] [PATCH RFC] scripts/update-linux-headers.sh: pull virtio hdrs

2015-02-10 Thread Chen, Tiejun
On 2015/2/10 3:56, Michael S. Tsirkin wrote: It doesn't make sense to copy values manually: the only issue with getting headers from linux seems to be dealing with linux/types, we can easily fix that automatically while importing. Signed-off-by: Michael S. Tsirkin --- FYI this is what I propos

Re: [Qemu-devel] [PATCH v1 1/2] vhost-user: support SET_MEM_TABLE waite the result of mmap

2015-02-10 Thread Linhaifeng
On 2015/2/10 20:04, Michael S. Tsirkin wrote: > So that's not good. We need a way to negotiate the capability, > we can't just deadlock with legacy slaves. Should we wait many seconds if slave not reply we just return error? -- Regards, Haifeng

Re: [Qemu-devel] [PATCH RFC] scripts/update-linux-headers.sh: pull virtio hdrs

2015-02-10 Thread Peter Maydell
On 11 February 2015 at 01:36, Chen, Tiejun wrote: > On 2015/2/10 3:56, Michael S. Tsirkin wrote: >> >> It doesn't make sense to copy values manually: >> the only issue with getting headers from linux >> seems to be dealing with linux/types, we >> can easily fix that automatically while importing.

Re: [Qemu-devel] [PATCH RFC] scripts/update-linux-headers.sh: pull virtio hdrs

2015-02-10 Thread Peter Maydell
On 9 February 2015 at 19:56, Michael S. Tsirkin wrote: > +rm -rf "$output/standard-headers/linux" > +mkdir -p "$output/standard-headers/linux" > +for f in $tmpdir/include/linux/virtio*h; do > +header=$(expr "$f" : '.*/\(.*\)'); > +sed -e 's/__u\([0-9][0-9]*\)/uint\1_t/g' \ > +-e 's

[Qemu-devel] block: low level read from disk for IDE_DMA_READ

2015-02-10 Thread Shailesh Kumar
Hi, I am implementing read equivalent routine in qemu. Can some one help me understand control flow of the qemu read/write implementation. I am using xen-4.2.0 and qemu-1.6.1 My requirement is simple: I have a 1024*1024 buffer already filled with some useful data. Now when windows (my gue

Re: [Qemu-devel] [Xen-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-02-10 Thread Chen, Tiejun
On 2015/2/9 19:05, Ian Campbell wrote: On Mon, 2015-02-09 at 14:28 +0800, Chen, Tiejun wrote: What about this? I've not read the code in detail,since I'm travelling but from a quick glance it looks to be implementing the sort of thing I meant, thanks. Thanks for your time. A couple of hi

Re: [Qemu-devel] [PATCH RFC] scripts/update-linux-headers.sh: pull virtio hdrs

2015-02-10 Thread Chen, Tiejun
On 2015/2/11 10:03, Peter Maydell wrote: On 11 February 2015 at 01:36, Chen, Tiejun wrote: On 2015/2/10 3:56, Michael S. Tsirkin wrote: It doesn't make sense to copy values manually: the only issue with getting headers from linux seems to be dealing with linux/types, we can easily fix that au

Re: [Qemu-devel] [PATCH 7/9] cosmetic changes preparing for the following patches

2015-02-10 Thread Fam Zheng
On Fri, 02/06 17:55, Paolo Bonzini wrote: > From: Mike Day > > Signed-off-by: Mike Day > Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng

[Qemu-devel] [v5 02/12] migration: Add the framework of multi-thread compression

2015-02-10 Thread Liang Li
Add the code to create and destroy the multiple threads those will be used to do data compression. Left some functions empty to keep clearness, and the code will be added later. Signed-off-by: Liang Li Signed-off-by: Yang Zhang Reviewed-by: Dr.David Alan Gilbert --- arch_init.c

[Qemu-devel] [PATCH v5 0/12] migration: Add a new feature to do live migration

2015-02-10 Thread Liang Li
This feature can help to reduce the data transferred about 60%, and the migration time can also be reduced about 70%. Summary of changed from v4->v5 -Fix some typo errors -Fix the bug related with XBZRLE -Added some comments -Squash setting and querying commands into one

[Qemu-devel] [v5 04/12] qemu-file: Add compression functions to QEMUFile

2015-02-10 Thread Liang Li
qemu_put_compression_data() compress the data and put it to QEMUFile. qemu_put_qemu_file() put the data in the buffer of source QEMUFile to destination QEMUFile. Signed-off-by: Liang Li Signed-off-by: Yang Zhang --- include/migration/qemu-file.h | 3 +++ migration/qemu-file.c | 39

[Qemu-devel] [v5 06/12] arch_init: Add and free data struct for decompression

2015-02-10 Thread Liang Li
Define the data structure and variables used to do multiple thread decompression, and add the code to initialize and free them. Signed-off-by: Liang Li Signed-off-by: Yang Zhang Reviewed-by: Dr.David Alan Gilbert --- arch_init.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(

[Qemu-devel] [v5 01/12] docs: Add a doc about multiple thread compression

2015-02-10 Thread Liang Li
Give some details about the multiple thread (de)compression and how to use it in live migration. Signed-off-by: Liang Li Signed-off-by: Yang Zhang Reviewed-by: Dr.David Alan Gilbert --- docs/multi-thread-compression.txt | 149 ++ 1 file changed, 149 insertio

[Qemu-devel] [v5 03/12] migration: Add the framework of multi-thread decompression

2015-02-10 Thread Liang Li
Add the code to create and destroy the multiple threads those will be used to do data decompression. Left some functions empty just to keep clearness, and the code will be added later. Signed-off-by: Liang Li Signed-off-by: Yang Zhang Reviewed-by: Dr.David Alan Gilbert --- arch_init.c

[Qemu-devel] [PATCH v17 1/2] sPAPR: Implement EEH RTAS calls

2015-02-10 Thread Gavin Shan
The emulation for EEH RTAS requests from guest isn't covered by QEMU yet and the patch implements them. The patch defines constants used by EEH RTAS calls and adds callbacks sPAPRPHBClass::{eeh_set_option, eeh_get_state, eeh_reset, eeh_configure}, which are going to be used as follows: * RTAS c

[Qemu-devel] [PATCH v17 2/2] sPAPR: Implement sPAPRPHBClass EEH callbacks

2015-02-10 Thread Gavin Shan
The patch implements sPAPRPHBClass EEH callbacks so that the EEH RTAS requests can be routed to VFIO for further handling. Signed-off-by: Gavin Shan --- hw/ppc/spapr_pci_vfio.c | 98 + hw/vfio/common.c| 1 + 2 files changed, 99 insertions(

[Qemu-devel] [v5 05/12] arch_init: Alloc and free data struct for compression

2015-02-10 Thread Liang Li
Define the data structure and variables used to do multiple thread compression, and add the code to initialize and free them. Signed-off-by: Liang Li Signed-off-by: Yang Zhang Reviewed-by: Dr.David Alan Gilbert --- arch_init.c | 34 +- 1 file changed, 33 inserti

[Qemu-devel] [v5 07/12] migration: Split the function ram_save_page

2015-02-10 Thread Liang Li
Split the function ram_save_page for code reuse purpose. Signed-off-by: Liang Li Signed-off-by: Yang Zhang --- arch_init.c | 51 +-- 1 file changed, 33 insertions(+), 18 deletions(-) diff --git a/arch_init.c b/arch_init.c index 66f4bc1..fe062db 1

[Qemu-devel] [v5 09/12] migration: Make compression co-work with xbzrle

2015-02-10 Thread Liang Li
Now, multiple thread compression can co-work with xbzrle. when xbzrle is on, multiple thread compression will only work at the first round of RAM data sync. Signed-off-by: Liang Li Signed-off-by: Yang Zhang Reviewed-by: Dr.David Alan Gilbert --- arch_init.c | 11 ++- 1 file changed, 10

[Qemu-devel] [PATCH v17 0/2] EEH Support for VFIO Devices

2015-02-10 Thread Gavin Shan
The series of patches adds support EEH for VFIO PCI devices on sPAPR platform. It requires corresponding host kernel support, which was merged during 3.17 merge window. This patchset has been rebased to Alex Graf's QEMU repository: git://github.com/agraf/qemu.git (branch: ppc-next) The impleme

[Qemu-devel] [v5 11/12] migration: Add interface to control compression

2015-02-10 Thread Liang Li
The multiple compression threads can be turned on/off through qmp and hmp interface before doing live migration. Signed-off-by: Liang Li Signed-off-by: Yang Zhang Reviewed-by: Dr.David Alan Gilbert Reviewed-by: Eric Blake --- migration/migration.c | 7 +-- qapi-schema.json | 7 ++

[Qemu-devel] [v5 08/12] migration: Add the core code of multi-thread compression

2015-02-10 Thread Liang Li
Implement the core logic of the multiple thread compression. At this point, multiple thread compression can't co-work with xbzrle yet. Signed-off-by: Liang Li Signed-off-by: Yang Zhang --- arch_init.c | 193 +--- 1 file changed, 185 insert

Re: [Qemu-devel] [PATCH 6/9] exec: protect mru_block with RCU

2015-02-10 Thread Fam Zheng
On Fri, 02/06 17:55, Paolo Bonzini wrote: > Hence, freeing a RAMBlock has to be switched to call_rcu. > > Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng

[Qemu-devel] [v5 10/12] migration: Add the core code for decompression

2015-02-10 Thread Liang Li
Implement the core logic of multiple thread decompression, the decompression can work now. Signed-off-by: Liang Li Signed-off-by: Yang Zhang --- arch_init.c | 50 -- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/arch_init.c b/arch

[Qemu-devel] [v5 12/12] migration: Add commands to set and query parameter

2015-02-10 Thread Liang Li
Add the qmp and hmp commands to tune and query the parameters used in live migration. Signed-off-by: Liang Li Signed-off-by: Yang Zhang --- hmp-commands.hx | 17 hmp.c | 56 + hmp.h | 4 ++ include/m

Re: [Qemu-devel] [PATCH 8/9] exec: convert ram_list to QLIST

2015-02-10 Thread Fam Zheng
On Fri, 02/06 17:55, Paolo Bonzini wrote: > From: Mike Day > > QLIST has RCU-friendly primitives, so switch to it. > > Signed-off-by: Mike Day > Signed-off-by: Paolo Bonzini > --- > arch_init.c | 19 > exec.c | 52 >

Re: [Qemu-devel] CPU TLB flush with multithread TCG.

2015-02-10 Thread Alex Bennée
Frederic Konrad writes: > Hi everybody, > > In multithread tlb_flush is broken as CPUA can flush an other CPUB and > CPUB can be > executing code, and fixing this can be quite hard: >* We need to exit the CPU which is flushed. >* Makes sure the CPU is stopped. >* Then we can flush t

Re: [Qemu-devel] [PATCH RFC] scripts/update-linux-headers.sh: pull virtio hdrs

2015-02-10 Thread Peter Maydell
On 11 February 2015 at 02:50, Chen, Tiejun wrote: > On 2015/2/11 10:03, Peter Maydell wrote: >> The linux-headers/ directory contains header files which can only >> validly be included if the host we're compiling on is Linux. Some >> of them will cause compile failures on OSX or Windows if they >>

[Qemu-devel] [Xen-devel] [Block dev] : Qemu block ide_dma_read call routine

2015-02-10 Thread Shailesh Kumar
Hi, I am implementing read equivalent routine in qemu. Can some one help me understand control flow of the qemu read/write implementation. I am using xen-4.2.0 and qemu-1.6.1 My requirement is simple: I have a 1024*1024 buffer already filled with some useful data. Now when windows (my gue

Re: [Qemu-devel] [PATCH v1] add intel restricted transactional memory test case.

2015-02-10 Thread Xin Tong
Please someone review this patch. Thanks, Xin On Thu, Feb 5, 2015 at 2:04 PM, Xin Tong wrote: > I am planning to implement support for Intel RTM. similar to what is > done for PowerPC. we can default to fault (transaction abort) to the > fallback code path. Would like to check in this test case

Re: [Qemu-devel] [PATCH v4 1/4] target-arm: Add CPU property to disable AArch64

2015-02-10 Thread Peter Maydell
On 10 February 2015 at 10:50, Greg Bellows wrote: > Adds registration and get/set functions for enabling/disabling the AArch64 > execution state on AArch64 CPUs. By default AArch64 execution state is > enabled > on AArch64 CPUs, setting the property to off, will disable the execution > state. >

[Qemu-devel] [PATCH 05/11] Remove superfluous '\n' around error_report()

2015-02-10 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- exec.c | 2 +- hw/ide/pci.c | 2 +- hw/microblaze/boot.c | 2 +- migration/rdma.c | 2 +- qemu-img.c | 2 +- target-s390x/kvm.c | 2 +- trace/control.c | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) d

[Qemu-devel] [PATCH 10/11] arm/digic_boards: Remove superfluous '\n' around error_report()

2015-02-10 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/arm/digic_boards.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/arm/digic_boards.c b/hw/arm/digic_boards.c index 2a4b872..7114c36 100644 --- a/hw/arm/digic_boards.c +++ b/hw/arm/digic_boards.c @@ -65,7 +65,7 @@ static v

[Qemu-devel] [PATCH 09/11] tpm: Remove superfluous '\n' around error_report()

2015-02-10 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/tpm/tpm_passthrough.c | 12 ++-- tpm.c| 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/tpm/tpm_passthrough.c b/hw/tpm/tpm_passthrough.c index 2bf3c6f..13ac1d2 100644 --- a/hw/tpm/tpm_passthrough.c

[Qemu-devel] [PATCH 08/11] xtensa: Remove superfluous '\n' around error_report()

2015-02-10 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/xtensa/sim.c| 2 +- hw/xtensa/xtfpga.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/xtensa/sim.c b/hw/xtensa/sim.c index 37ea9ae..328d209 100644 --- a/hw/xtensa/sim.c +++ b/hw/xtensa/sim.c @@ -64,7 +64,7 @@ s

[Qemu-devel] [PATCH 03/11] pl330.c: remove superfluous '\n' around error_setg

2015-02-10 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/dma/pl330.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/dma/pl330.c b/hw/dma/pl330.c index 16cf77e..0f72b59 100644 --- a/hw/dma/pl330.c +++ b/hw/dma/pl330.c @@ -1566,7 +1566,7 @@ static void pl330_realize(DeviceState *de

[Qemu-devel] [PATCH 01/11] block: remove superfluous '\n' around error_report/error_setg

2015-02-10 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- block/archipelago.c | 6 +++--- hw/block/nand.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/block/archipelago.c b/block/archipelago.c index a8114b5..855655c 100644 --- a/block/archipelago.c +++ b/block/archipelago.c @@ -291

[Qemu-devel] [PATCH 04/11] numa: remove superfluous '\n' around error_setg

2015-02-10 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- numa.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/numa.c b/numa.c index afd2866..6decd13 100644 --- a/numa.c +++ b/numa.c @@ -59,7 +59,7 @@ static void numa_node_parse(NumaNodeOptions *node, QemuOpts *opts, Error **errp)

[Qemu-devel] [PATCH 07/11] vfio: Remove superfluous '\n' around error_report()

2015-02-10 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/vfio/common.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index e71385e..6c49cc4 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -201,7 +201,7 @@ static int vfio_dma_unmap(

Re: [Qemu-devel] [PATCH v4 3/4] target-arm: Add 32/64-bit register sync

2015-02-10 Thread Peter Maydell
On 10 February 2015 at 10:50, Greg Bellows wrote: > Add AArch32 to AArch64 register sychronization functions. > Replace manual register synchronization with new functions in > aarch64_cpu_do_interrupt() and HELPER(exception_return)(). > > Signed-off-by: Greg Bellows > > --- > > v3 -> v4 > - Rewor

[Qemu-devel] [PATCH 02/11] a9gtimer: remove superfluous '\n' around error_setg

2015-02-10 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/timer/a9gtimer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/timer/a9gtimer.c b/hw/timer/a9gtimer.c index 435142a..b087bbd 100644 --- a/hw/timer/a9gtimer.c +++ b/hw/timer/a9gtimer.c @@ -289,7 +289,7 @@ static void a9_gtimer_

[Qemu-devel] [PATCH 11/11] vhost: Remove superfluous '\n' around error_report()

2015-02-10 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/virtio/vhost-backend.c | 2 +- net/vhost-user.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio/vhost-backend.c b/hw/virtio/vhost-backend.c index ff4f200..4d68a27 100644 --- a/hw/virtio/vhost-backend.c +++ b

Re: [Qemu-devel] [PATCH v4 4/4] target-arm: Add AArch32 guest support to KVM64

2015-02-10 Thread Peter Maydell
On 10 February 2015 at 10:50, Greg Bellows wrote: > Add 32-bit to/from 64-bit register synchronization on register gets and puts. > Set EL1_32BIT feature flag passed to KVM > > Signed-off-by: Greg Bellows > > --- > > v3 -> v4 > - Add check that to make sure KVM64 is only being used on AArch64 fam

[Qemu-devel] [PATCH 06/11] vhost-scsi: Remove superfluous '\n' around error_report()

2015-02-10 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/scsi/vhost-scsi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c index dcb2bc5..54f916e 100644 --- a/hw/scsi/vhost-scsi.c +++ b/hw/scsi/vhost-scsi.c @@ -82,7 +82,7 @@ static int vh

[Qemu-devel] [PATCH 00/11] trivial: Remove superfluous '\n' around error_report/error_setg

2015-02-10 Thread arei.gonglei
From: Gonglei Yestoday, I found that some files have superflous '\n' charactor around error_report/error_setg when reviewed patches. By a simply script, the below files were listed. Classify and fix them. It's suitable for appling via qemu-trivial IMHO. Gonglei (11): block: remove superfluo

Re: [Qemu-devel] [PATCH v4 1/4] target-arm: Add CPU property to disable AArch64

2015-02-10 Thread Greg Bellows
On Tue, Feb 10, 2015 at 10:03 PM, Peter Maydell wrote: > On 10 February 2015 at 10:50, Greg Bellows > wrote: > > Adds registration and get/set functions for enabling/disabling the > AArch64 > > execution state on AArch64 CPUs. By default AArch64 execution state is > enabled > > on AArch64 CPUs,

Re: [Qemu-devel] [PATCH v4 4/4] target-arm: Add AArch32 guest support to KVM64

2015-02-10 Thread Greg Bellows
On Tue, Feb 10, 2015 at 10:16 PM, Peter Maydell wrote: > On 10 February 2015 at 10:50, Greg Bellows > wrote: > > Add 32-bit to/from 64-bit register synchronization on register gets and > puts. > > Set EL1_32BIT feature flag passed to KVM > > > > Signed-off-by: Greg Bellows > > > > --- > > > > v

Re: [Qemu-devel] [PATCH] memory: unregister AddressSpace MemoryListener within BQL

2015-02-10 Thread Michael Roth
Quoting Paolo Bonzini (2015-02-10 06:52:49) > address_space_destroy_dispatch is called from an RCU callback and hence > outside the iothread mutex (BQL). However, after address_space_destroy > no new accesses can hit the destroyed AddressSpace so it is not necessary > to observe changes to the mem

Re: [Qemu-devel] [PATCH v4 1/4] target-arm: Add CPU property to disable AArch64

2015-02-10 Thread Peter Maydell
On 11 February 2015 at 04:27, Greg Bellows wrote: > > > On Tue, Feb 10, 2015 at 10:03 PM, Peter Maydell > wrote: >> >> On 10 February 2015 at 10:50, Greg Bellows >> wrote: >> > +if (!kvm_enabled()) { >> > +error_setg(errp, >> > + "'aarch64' option only supported wit

Re: [Qemu-devel] [PULL 0/6] vfio fixes

2015-02-10 Thread Peter Maydell
On 10 February 2015 at 18:37, Alex Williamson wrote: > Sorry for the short interval of vfio pull requests, but this fixes > hotplug of vfio-pci devices after the last RCU merge. Thanks, > > Alex > > The following changes since commit a2f2d288b5a06e6c680c387c9980d91363f59c61: > > softfloat: expa

Re: [Qemu-devel] [PATCH v4 3/4] target-arm: Add 32/64-bit register sync

2015-02-10 Thread Greg Bellows
On Tue, Feb 10, 2015 at 10:13 PM, Peter Maydell wrote: > On 10 February 2015 at 10:50, Greg Bellows > wrote: > > Add AArch32 to AArch64 register sychronization functions. > > Replace manual register synchronization with new functions in > > aarch64_cpu_do_interrupt() and HELPER(exception_return)

Re: [Qemu-devel] [PATCH v4 3/4] target-arm: Add 32/64-bit register sync

2015-02-10 Thread Peter Maydell
On 11 February 2015 at 06:08, Greg Bellows wrote: > > > On Tue, Feb 10, 2015 at 10:13 PM, Peter Maydell > wrote: >> >> On 10 February 2015 at 10:50, Greg Bellows >> wrote: >> > +void aarch64_sync_64_to_32(CPUARMState *env) >> > +{ >> > +int i; >> > + >> > +for (i = 0; i < 15; i++) { >> >

[Qemu-devel] [PATCH] monitor: Fix Resource leak

2015-02-10 Thread arei.gonglei
From: Gonglei Coverity spot: qemu_using_spice allocates memory that is stored into err, but not freed before return. Cc:Markus Armbruster Signed-off-by: Gonglei --- monitor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index c3cc060..137d23f 100

Re: [Qemu-devel] [PATCH v1 1/2] vhost-user: support SET_MEM_TABLE waite the result of mmap

2015-02-10 Thread Linhaifeng
On 2015/2/10 20:04, Michael S. Tsirkin wrote: > So that's not good. We need a way to negotiate the capability, > we can't just deadlock with legacy slaves. Or add a new message to query slaves' version if slaves not reply we don't wait otherwise if the version as same as QEMU we wait the reply.

[Qemu-devel] [PATCH] monitor: Fix Resource leak

2015-02-10 Thread arei.gonglei
From: Gonglei Coverity spot: qemu_using_spice allocates memory that is stored into err, but not freed before return. Cc: Markus Armbruster Signed-off-by: Gonglei --- monitor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index c3cc060..137d23f 10

Re: [Qemu-devel] Revert commit 5af35d7feccaa7d26b72c6c3d14116421d736b36 - "usb-host-libusb: Fix reset handling"

2015-02-10 Thread Hans de Goede
Hi, On 10-02-15 22:02, Dennis Ostermann wrote: Hello Hans, thanks for taking care. 09-02-15 09:09, Hans de Goede wrote: Hi, On 09-02-15 22:09, Dennis Ostermann wrote: Hi there, please revert commit 5af35d7feccaa7d26b72c6c3d14116421d736b36 - "usb-host-libusb: Fix reset handling" This bre

Re: [Qemu-devel] [PATCH] memory: unregister AddressSpace MemoryListener within BQL

2015-02-10 Thread Paolo Bonzini
On 11/02/2015 06:13, Michael Roth wrote: > (gdb) print node > $1 = (struct rcu_head *) 0x11189a68 > (gdb) print node->func > $2 = (RCUCBFunc *) 0x0 > (gdb) print node->next > $3 = (struct rcu_head *) 0x3fff9800d4f0 > > I've seen it on both x86 and pseries (with spapr hotplug patches applied), an

[Qemu-devel] [PATCH RFC v5 1/5] qemu-iotests: qemu machine type support

2015-02-10 Thread Xiao Guang Chen
This patch adds qemu machine type support to the io test suite. Based on the qemu default machine type and alias of the default machine type the reference output file can now vary from the default to a machine specific output file if necessary. When using a machine specific reference file if the de

[Qemu-devel] [PATCH RFC v5 0/5] Update tests/qemu-iotests failing cases for the s390 platform

2015-02-10 Thread Xiao Guang Chen
v5: 1. Add a pc specific output file for test 051. 2. Add a filter to test case 051 to filter s390 specific warnings. 3. Check whether the machine type is pc or not rather than check whether the machine type is s390. 4. When using a machine specific reference file if the default machine has an a

[Qemu-devel] [PATCH RFC v5 5/5] qemu-iotests: s390x: fix test 051

2015-02-10 Thread Xiao Guang Chen
The tests for device type "ide_cd" should only be tested for the pc platform. The default device id of hard disk on the s390 platform differs to that of the x86 platform. A new variable device_id is defined and "virtio0" set for the s390 platform. A x86 platform specific output file is also needed.

[Qemu-devel] [PATCH RFC v5 4/5] qemu-iotests: s390x: fix test 055

2015-02-10 Thread Xiao Guang Chen
There is no 'ide-cd' device defined on s390 platform, so test_medium_not_found() test should be skipped. Signed-off-by: Xiao Guang Chen,che...@linux.vnet.ibm.com --- tests/qemu-iotests/055 | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/qemu-iotests/055 b/tests/qemu-iotests/055

[Qemu-devel] [PATCH RFC v5 2/5] qemu-iotests: run qemu with -nodefaults and fix 067, 071, 087

2015-02-10 Thread Xiao Guang Chen
This patch fixes an io test suite issue that was introduced with the commit c88930a6866e74953e931ae749781e98e486e5c8 'qemu-char: Permit only a single "stdio" character device'. The option supresses the creation of default devices such as the floopy and cdrom. Output files for test case 067, 071 and

[Qemu-devel] [PATCH RFC v5 3/5] qemu-iotests: s390x: fix test 041

2015-02-10 Thread Xiao Guang Chen
There is no 'ide-cd' device defined on s390 platform, so test_medium_not_found() test should be skipped. Signed-off-by: Xiao Guang Chen,che...@linux.vnet.ibm.com --- tests/qemu-iotests/041 | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041 in

Re: [Qemu-devel] [PATCH] checkpatch: port fix from kernel "## is not a valid modifier"

2015-02-10 Thread Christian Borntraeger
Am 09.02.2015 um 23:54 schrieb Peter Maydell: > On 9 February 2015 at 19:43, Christian Borntraeger > wrote: >> From: Andy Whitcroft >> >> checkpatch currently loops on fpu/softfloat.c >> Turns out this is fixed in the Linux version of checkpatch. >> >> So this is a port of Andy Whitcrofts fix fro

Re: [Qemu-devel] Revert commit 5af35d7feccaa7d26b72c6c3d14116421d736b36 - "usb-host-libusb: Fix reset handling"

2015-02-10 Thread Hans de Goede
Hi, On 09-02-15 22:09, Dennis Ostermann wrote: Hi there, please revert commit 5af35d7feccaa7d26b72c6c3d14116421d736b36 - "usb-host-libusb: Fix reset handling" This breaks usb pass through of FTDI based usb devices: On the host: lsusb | grep FT2232 Bus 003 Device 008: ID 0403:6010 Future Tec

Re: [Qemu-devel] [PATCH v2 2/2] xen-pt: fix Out-of-bounds read

2015-02-10 Thread Stefano Stabellini
On Tue, 10 Feb 2015, arei.gong...@huawei.com wrote: > From: Gonglei > > The array length of s->real_device.io_regions[] is > "PCI_NUM_REGIONS - 1". > > Signed-off-by: Gonglei Acked-by: Stefano Stabellini I am happy for these patches to go in via the qemu-trivial tree. > hw/xen/xen_pt_confi

Re: [Qemu-devel] [PATCH v2 2/2] xen-pt: fix Out-of-bounds read

2015-02-10 Thread Gonglei
On 2015/2/10 16:11, Stefano Stabellini wrote: > On Tue, 10 Feb 2015, arei.gong...@huawei.com wrote: >> From: Gonglei >> >> The array length of s->real_device.io_regions[] is >> "PCI_NUM_REGIONS - 1". >> >> Signed-off-by: Gonglei > > Acked-by: Stefano Stabellini > > I am happy for these patches

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-10 Thread Teruaki Ishizaki
(2015/02/10 12:10), Liu Yuan wrote: On Tue, Jan 27, 2015 at 05:35:27PM +0900, Teruaki Ishizaki wrote: Previously, qemu block driver of sheepdog used hard-coded VDI object size. This patch enables users to handle "block_size_shift" value for calculating VDI object size. When you start qemu, you

Re: [Qemu-devel] [PATCH v2 00/22] block: Rework bdrv_close_all()

2015-02-10 Thread Paolo Bonzini
On 09/02/2015 19:38, Max Reitz wrote: > Currently, bdrv_close_all() force-closes all BDSs with a BlockBackend, > which can lead to data corruption (see the iotest added in the final > patch of this series) and is most certainly very ugly. > > This series reworks bdrv_close_all() to notify all ow

Re: [Qemu-devel] [PATCH v1 1/2] vhost-user: support SET_MEM_TABLE waite the result of mmap

2015-02-10 Thread Michael S. Tsirkin
On Tue, Feb 10, 2015 at 01:48:12PM +0800, linhaifeng wrote: > From: Linhaifeng > > Slave should reply to master and set u64 to 0 if > mmap all regions success otherwise set u64 to 1. > > Signed-off-by: Linhaifeng How does this work with existig slaves though? > --- > docs/specs/vhost-user.tx

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-10 Thread Liu Yuan
On Tue, Feb 10, 2015 at 05:22:02PM +0900, Teruaki Ishizaki wrote: > (2015/02/10 12:10), Liu Yuan wrote: > >On Tue, Jan 27, 2015 at 05:35:27PM +0900, Teruaki Ishizaki wrote: > >>Previously, qemu block driver of sheepdog used hard-coded VDI object size. > >>This patch enables users to handle "block_s

[Qemu-devel] [PULL 21/46] libcacard: stop linking against every single 3rd party library

2015-02-10 Thread Michael Tokarev
From: "Daniel P. Berrange" Building QEMU results in a libcacard.so that links against practically the entire world linux-vdso.so.1 => (0x7fff71e99000) libssl3.so => /usr/lib64/libssl3.so (0x7f49f94b6000) libsmime3.so => /usr/lib64/libsmime3.so (0x7f49f928e000

[Qemu-devel] [PULL 39/46] migration: Fix warning caused by missing declaration of vmstate_dummy

2015-02-10 Thread Michael Tokarev
From: Stefan Weil Warning from the Sparse static analysis tool: stubs/vmstate.c:4:26: warning: symbol 'vmstate_dummy' was not declared. Should it be static? Cc: Juan Quintela Cc: Amit Shah Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- include/migration/vmstate.h | 2 -- 1

  1   2   3   4   >