On 02/10/2015 09:34 AM, Markus Armbruster wrote: > monitor_handle_fd_param() is a wrapper around > monitor_handle_fd_param2() that feeds errors to qerror_report_err() > instead of returning them. qerror_report_err() is inappropriate in > many contexts. monitor_handle_fd_param() looks simpler than > monitor_handle_fd_param2(), which tempts use. Remove the temptation: > drop the wrapper and open-code the (trivial) error handling instead. > > Replace the open-coded qerror_report_err() by error_report_err() in > places that already use error_report(). Turns out that's everywhere. > > While there, rename monitor_handle_fd_param2() to monitor_fd_param(). > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > hw/i386/kvm/pci-assign.c | 5 ++--- > hw/scsi/vhost-scsi.c | 2 +- > include/monitor/monitor.h | 3 +-- > monitor.c | 15 +-------------- > net/socket.c | 4 +++- > net/tap.c | 11 ++++++++--- > 6 files changed, 16 insertions(+), 24 deletions(-)
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
