Re: [Qemu-devel] [PATCH v2 1/2] configure: Default to enable module build

2015-02-03 Thread Paolo Bonzini
On 03/02/2015 02:29, Fam Zheng wrote: > > Peter reported that module linking fails on ARM host: > > LINK block/curl.so > > /usr/bin/ld: block/curl.o: relocation R_ARM_THM_MOVW_ABS_NC against > > `__stack_chk_guard' can not be used when making a shared object; > > recompile with -fPIC > > block

Re: [Qemu-devel] [PATCH 1/3] nbd: Drop BDS backpointer

2015-02-03 Thread Paolo Bonzini
On 02/02/2015 22:40, Max Reitz wrote: > Before this patch, the "opaque" pointer in an NBD BDS points to a > BDRVNBDState, which contains an NbdClientSession object, which in turn > contains a pointer to the BDS. This pointer may become invalid due to > bdrv_swap(), so drop it, and instead pass th

Re: [Qemu-devel] [PATCH 3/3] iotests: Add test for drive-mirror with NBD target

2015-02-03 Thread Paolo Bonzini
On 02/02/2015 22:40, Max Reitz wrote: > When the drive-mirror block job is completed, it will call bdrv_swap() > on the source and the target BDS; this should obviously not result in a > segmentation fault. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/094 | 81 > +++

Re: [Qemu-devel] [PATCH 2/3] iotests: Add "wait" functionality to _cleanup_qemu

2015-02-03 Thread Paolo Bonzini
On 02/02/2015 22:40, Max Reitz wrote: > The qemu process does not always need to be killed, just waiting for it > can be fine, too. This introduces a way to do so. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/common.qemu | 12 +++- > 1 file changed, 11 insertions(+), 1 delet

Re: [Qemu-devel] [PATCH v2 0/5] Common unplug and unplug request cb for memory and CPU hot-unplug

2015-02-03 Thread Zhi Yong Wu
HI, If you can push the patchset to a branch on github, it will be convenient for other guys to do some tests. On Wed, Jan 28, 2015 at 3:45 PM, Zhu Guihua wrote: > Memory and CPU hot unplug are both asynchronous procedures. > When the unplug operation happens, unplug request cb is called first.

Re: [Qemu-devel] [PATCH v2 00/11] cpu: add i386 cpu hot remove support

2015-02-03 Thread Zhi Yong Wu
HI, Can you push the patchset to a branch on github? It will be convenient for other guys to do some tests. On Wed, Jan 14, 2015 at 3:44 PM, Zhu Guihua wrote: > This series is based on chen fan's previous i386 cpu hot remove patchset: > https://lists.nongnu.org/archive/html/qemu-devel/2013-12/ms

Re: [Qemu-devel] [RESEND PATCH v1 00/13] QEmu memory hot unplug support.

2015-02-03 Thread Zhi Yong Wu
HI, Can you push the patchset to a branch on github? It will be convenient for other guys to do some tests. On Thu, Jan 8, 2015 at 9:06 AM, Tang Chen wrote: > Memory hot unplug are both asynchronize procedures. > When the unplug operation happens, unplug request cb is called first. > And when gh

Re: [Qemu-devel] [question] the patch which affect performance of virtio-scsi

2015-02-03 Thread Paolo Bonzini
On 03/02/2015 03:31, Wangting (Kathy) wrote: > Hi Paolo, > > Recently I test IO performance with virtio-scsi, and find out that the patch > of > "virtio-scsi: add support for the any_layout feature" affects IO performance > of model > with 4KB 32iodepth sequence read. > > Why cdb and sense is

Re: [Qemu-devel] [question] the patch which affect performance of virtio-scsi

2015-02-03 Thread Paolo Bonzini
On 03/02/2015 03:56, Wangting (Kathy) wrote: > Sorry, I find that the patch of "virtio-scsi: Optimize virtio_scsi_init_req" > can slove this problem. Great that you could confirm that. :) > By the way, can you tell me the reason of the change about cdb and sense? cdb and sense are variable-size

Re: [Qemu-devel] [PATCH 13/19] libqos/ahci: add ahci command size setters

2015-02-03 Thread Paolo Bonzini
On 02/02/2015 22:09, John Snow wrote: > > In this case, only the command header had a utility written for it to > flip the bits for me. This is part of the FIS, instead, which has no > explicit flip-on-write mechanism inside of commit. > > So, it's correct, but not terribly consistent. > > I c

Re: [Qemu-devel] [PATCH 2/2] bootdevice: add check in restore_boot_order()

2015-02-03 Thread Gonglei
On 2015/2/3 15:49, Markus Armbruster wrote: > You're right. pc.c's set_boot_dev() fails when its boot order argument > is invalid. > > The boot order interface is crap, because it makes detecting > configuration errors early hard. Two solutions: > > A. It may be hard, but not too hard for the

Re: [Qemu-devel] [PATCH 17/19] qtest/ahci: Add a macro bootup routine

2015-02-03 Thread Paolo Bonzini
On 02/02/2015 22:12, John Snow wrote: > > It comes in handy later for testing migration so I don't have to do a > lot of boilerplate for each instance, though it is just a convenience > subroutine with no logic of its own. > > I like to cut down on boilerplate as much as possible to expose the

Re: [Qemu-devel] [PATCH v2 0/5] vhost-scsi: support to assign boot order

2015-02-03 Thread Gonglei
On 2015/1/29 15:08, Gonglei (Arei) wrote: > From: Gonglei > > Qemu haven't provide a bootindex property for vhost-scsi device. > So, we can not assign the boot order for it at present. But > Some clients/users have requirements for that in some scenarios. > This patch achieve the aim in Qemu sid

Re: [Qemu-devel] [Qemu-ppc] [RFC] pseries: Enable in-kernel H_LOGICAL_CI_{LOAD, STORE} implementations

2015-02-03 Thread Nikunj A Dadhania
David Gibson writes: > qemu currently implements the hypercalls H_LOGICAL_CI_LOAD and > H_LOGICAL_CI_STORE as PAPR extensions. These are used by the SLOF firmware > for IO, because performing cache inhibited MMIO accesses with the MMU off > (real mode) is very awkward on POWER. > > This approach

Re: [Qemu-devel] [PATCH] quorum: don't share qiov

2015-02-03 Thread Kevin Wolf
Am 02.02.2015 um 02:19 hat Wen Congyang geschrieben: > On 01/30/2015 09:39 PM, Kevin Wolf wrote: > > Am 30.01.2015 um 09:07 hat Wen Congyang geschrieben: > >> If the child touches qiov->iov, it will cause unexpected results. > >> > >> Signed-off-by: Wen Congyang > > > > Any specific child you're

Re: [Qemu-devel] [PATCH 0/4] block: Drop BDS.filename

2015-02-03 Thread Kevin Wolf
Am 24.09.2014 um 21:48 hat Max Reitz geschrieben: > The BDS filename field is generally only used when opening disk images > or emitting error or warning messages, the only exception to this rule > is the map command of qemu-img. However, using exact_filename there > instead should not be a problem

Re: [Qemu-devel] [RFC 09/10] cpu: remove exit_request global.

2015-02-03 Thread Frederic Konrad
On 29/01/2015 16:52, Peter Maydell wrote: On 16 January 2015 at 17:19, wrote: From: KONRAD Frederic This removes exit_request global and adds a variable in CPUState for this. Only the flag for the first cpu is used for the moment as we are still with one TCG thread. --- a/cpus.c +++ b/cpus.c

Re: [Qemu-devel] [PATCH v5 08/10] rocker: add tests

2015-02-03 Thread Stefan Hajnoczi
On Thu, Jan 22, 2015 at 12:03:57AM -0800, sfel...@gmail.com wrote: > From: Scott Feldman > > Add some basic test for rocker to test L2/L3/L4 functionality. Requires an > external test environment, simp, located here: > > https://github.com/scottfeldman/simp > > To run tests, simp environment m

Re: [Qemu-devel] [PATCH v5 06/10] rocker: add new rocker switch device

2015-02-03 Thread Stefan Hajnoczi
On Thu, Jan 22, 2015 at 12:03:55AM -0800, sfel...@gmail.com wrote: > +iov[iovcnt].iov_len = frag_len; > +iov[iovcnt].iov_base = g_malloc(frag_len); > +if (!iov[iovcnt].iov_base) { > +err = -ROCKER_ENOMEM; > +goto err_no_mem; > +} > + > +

Re: [Qemu-devel] [PATCH v5 03/10] rocker: add register programming guide

2015-02-03 Thread Stefan Hajnoczi
On Thu, Jan 22, 2015 at 12:03:52AM -0800, sfel...@gmail.com wrote: Minor typos, not worth respinning. I can fix them when merging. > +Endianess s/Endianess/Endianness/ > +- > + > +Device registers are hard-coding to little-endian (LE). The driver should s/hard-coding/hard-coded/ > +

Re: [Qemu-devel] [PATCH v5 03/10] rocker: add register programming guide

2015-02-03 Thread Stefan Hajnoczi
On Thu, Jan 22, 2015 at 12:03:52AM -0800, sfel...@gmail.com wrote: > +SECTION 7: Switch Control > += > + > +This section covers switch-wide register settings. > + > +Control > +--- > + > +This register is used for low level control of the switch. > + > + CONTROL: off

Re: [Qemu-devel] [PATCH v5 00/10] rocker: add new rocker ethernet switch device

2015-02-03 Thread Stefan Hajnoczi
On Thu, Jan 22, 2015 at 12:03:49AM -0800, sfel...@gmail.com wrote: > From: Scott Feldman > > v5: > > - Per Jason Wang review: > - Fix some missing/wrong references in the rocker.txt spec > - mark rocker as unmigratable. > > v4: > > - Per Paolo Bonzini review: > - move reg_guid

Re: [Qemu-devel] This patch hunk will hang scripts/checkpatch.pl...

2015-02-03 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > The following patch file (a cut down lump of an actual change > I was making) seems to cause scripts/checkpatch.pl to hang. > I find that script too opaque to try to debug, but I post the > offending input here in case anybody else wishes to inves

Re: [Qemu-devel] [PATCH 10/15] exec: RCUify AddressSpaceDispatch

2015-02-03 Thread Paolo Bonzini
On 28/01/2015 06:45, Fam Zheng wrote: > If I understand it, this code doesn't hold iothread lock when releasing the > memory region, but in one of the memroy region destructors, > memory_region_destructor_ram_from_ptr: > > void qemu_ram_free_from_ptr(ram_addr_t addr) > { > RAMBlo

Re: [Qemu-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-02-03 Thread Wei Liu
On Tue, Feb 03, 2015 at 09:01:53AM +0800, Chen, Tiejun wrote: > > On 2015/2/2 20:19, Wei Liu wrote: > >On Mon, Feb 02, 2015 at 09:17:23AM +0800, Tiejun Chen wrote: > >>When we're working to support IGD GFX passthrough with qemu > >>upstream, instead of "-gfx_passthru" we'd like to make that > >>a

Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line

2015-02-03 Thread Amit Shah
On (Fri) 30 Jan 2015 [10:50:26], Paolo Bonzini wrote: > > > On 30/01/2015 10:38, Dr. David Alan Gilbert wrote: > > * Eric Blake (ebl...@redhat.com) wrote: > >> On 01/29/2015 01:21 PM, Dr. David Alan Gilbert wrote: > >>> * Eric Blake (ebl...@redhat.com) wrote: > On 01/29/2015 09:28 AM, Dr. Da

Re: [Qemu-devel] [PATCH] iotests: Specify format for qemu-nbd

2015-02-03 Thread Kevin Wolf
Am 23.01.2015 um 20:28 hat Max Reitz geschrieben: > This patch is necessary to suppress the "probed raw" warning when > running raw over nbd tests. > > Signed-off-by: Max Reitz Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [RFC 09/10] cpu: remove exit_request global.

2015-02-03 Thread Peter Maydell
On 3 February 2015 at 09:37, Frederic Konrad wrote: > Actually, what we want to do is remove exit_requested global because when it > exits > the loop in tcg_exec_all it does exit_requested = 0, and other vcpu doesn't > exit. > > This is not clear to me why we have both exit_requested global and >

Re: [Qemu-devel] [PULL v3 00/11] RCU, scsi, icount changes for 2015-01-30

2015-02-03 Thread Peter Maydell
On 2 February 2015 at 19:29, Paolo Bonzini wrote: > The following changes since commit 83761b9244ad2ed39d3cfabe8a0e901ab906f7bf: > > Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20150127' > into staging (2015-01-27 22:25:56 +) > > are available in the git repository at: >

Re: [Qemu-devel] [PULL 0/2] OpenRISC patch queue for 2.3

2015-02-03 Thread Peter Maydell
On 3 February 2015 at 02:19, Jia Liu wrote: > Hi Anthony, > > This is my OpenRISC patch queue for 2.3, it have been well tested, please > pull. ...it can't have been very well tested, because it doesn't compile: target-openrisc/interrupt.c: In function ‘openrisc_cpu_do_interrupt’: target-openri

Re: [Qemu-devel] [RFC PATCH v8 11/21] replay: recording and replaying clock ticks

2015-02-03 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 22/01/2015 09:52, Pavel Dovgalyuk wrote: > > Clock ticks are considered as the sources of non-deterministic data for > > virtual machine. This patch implements saving the clock values when they > > are acquired (virtual, host clock, rdtsc, and

Re: [Qemu-devel] [PATCH] block: fix off-by-one error in qcow and qcow2

2015-02-03 Thread Kevin Wolf
Am 27.01.2015 um 14:33 hat Jeff Cody geschrieben: > This fixes an off-by-one error introduced in 9a29e18. Both qcow and > qcow2 need to make sure to leave room for string terminator '\0' for > the backing file, so the max length of the non-terminated string is > either 1023 or PATH_MAX - 1. > > R

Re: [Qemu-devel] [PATCH] quorum: don't share qiov

2015-02-03 Thread Paolo Bonzini
On 03/02/2015 10:22, Kevin Wolf wrote: > Paolo, I think it's rather surprising that iov_send_recv() modifies its > iov. The modification is undone at the end, so you seem to have > considered that a caller might be reusing it after and you can't "use it > up", but we still get problems with concu

Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line

2015-02-03 Thread Paolo Bonzini
On 03/02/2015 11:12, Amit Shah wrote: >> > >> > -S is just the same. > (just putting this in w/o actually checking..) > > Does -S and -incoming differ in the 'do not read disks' case? I > recall we had to add consistency checks so that the destination qemu > didn't inadvertently read disk meta

Re: [Qemu-devel] [RFC PATCH v8 11/21] replay: recording and replaying clock ticks

2015-02-03 Thread Paolo Bonzini
On 03/02/2015 11:51, Pavel Dovgaluk wrote: >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> On 22/01/2015 09:52, Pavel Dovgalyuk wrote: >>> Clock ticks are considered as the sources of non-deterministic data for >>> virtual machine. This patch implements saving the clock values when they >>

Re: [Qemu-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-02-03 Thread Ian Campbell
On Tue, 2015-02-03 at 09:04 +0800, Chen, Tiejun wrote: > > On 2015/2/2 20:54, Ian Jackson wrote: > > Wei Liu writes ("Re: [v2][PATCH] libxl: add one machine property to support > > IGD GFX passthrough"): > >> On Mon, Feb 02, 2015 at 09:17:23AM +0800, Tiejun Chen wrote: > >>> When we're working to

Re: [Qemu-devel] [PATCH v5 03/10] rocker: add register programming guide

2015-02-03 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/02/2015 17:19, Stefan Hajnoczi wrote: > How does the CPU detect that the device has completed the reset > procedure? Is this supposed to be synchronous? If yes, is that a > good idea (i.e. hopefully resetting doesn't involve any blocking >

Re: [Qemu-devel] [PATCH v2 0/5] vhost-scsi: support to assign boot order

2015-02-03 Thread Paolo Bonzini
On 03/02/2015 09:55, Gonglei wrote: > On 2015/1/29 15:08, Gonglei (Arei) wrote: > >> From: Gonglei >> >> Qemu haven't provide a bootindex property for vhost-scsi device. >> So, we can not assign the boot order for it at present. But >> Some clients/users have requirements for that in some scena

Re: [Qemu-devel] [PATCH 0/4] nbd: iotest fixes and error message improvement

2015-02-03 Thread Kevin Wolf
Am 27.01.2015 um 03:02 hat Max Reitz geschrieben: > This series is a follow-up to my previous patch "iotests: Specify format > for qemu-nbd" and as such relies on it. > > The first three patches of this series fix the qemu-iotests so they once > again pass when using NBD. > > The fourth patch of

Re: [Qemu-devel] [RFC PATCH v8 11/21] replay: recording and replaying clock ticks

2015-02-03 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 03/02/2015 11:51, Pavel Dovgaluk wrote: > >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > >> On 22/01/2015 09:52, Pavel Dovgalyuk wrote: > >>> Clock ticks are considered as the sources of non-deterministic data for > >>> virtual machine.

Re: [Qemu-devel] [PATCH v2 0/5] vhost-scsi: support to assign boot order

2015-02-03 Thread Gonglei
On 2015/2/3 19:11, Paolo Bonzini wrote: > > > On 03/02/2015 09:55, Gonglei wrote: >> On 2015/1/29 15:08, Gonglei (Arei) wrote: >> >>> From: Gonglei >>> >>> Qemu haven't provide a bootindex property for vhost-scsi device. >>> So, we can not assign the boot order for it at present. But >>> Some c

Re: [Qemu-devel] [PATCH 1/3] softfloat: Expand out the STATUS_PARAM macro

2015-02-03 Thread Peter Maydell
On 2 February 2015 at 21:37, Richard Henderson wrote: > On 02/02/2015 12:31 PM, Peter Maydell wrote: >> -void float_raise( int8 flags STATUS_PARAM ) >> +void float_raise(int8 flags , float_status *status) > > Extra space before comma. Thanks, fixed. I don't propose to send out a respin just for t

Re: [Qemu-devel] [PATCH 1/2] glusterfs: fix max_discard

2015-02-03 Thread Peter Lieven
Am 03.02.2015 um 08:31 schrieb Denis V. Lunev: > On 02/02/15 23:46, Denis V. Lunev wrote: >> On 02/02/15 23:40, Peter Lieven wrote: >>> Am 02.02.2015 um 21:09 schrieb Denis V. Lunev: qemu_gluster_co_discard calculates size to discard as follows size_t size = nb_sectors * BDRV_SECTOR_

[Qemu-devel] [PATCH] libcacard: stop linking against every single 3rd party library

2015-02-03 Thread Daniel P. Berrange
Building QEMU results in a libcacard.so that links against practically the entire world linux-vdso.so.1 => (0x7fff71e99000) libssl3.so => /usr/lib64/libssl3.so (0x7f49f94b6000) libsmime3.so => /usr/lib64/libsmime3.so (0x7f49f928e000) libnss3.so => /usr/

Re: [Qemu-devel] [PATCH v2 00/11] target-arm: handle mmu_idx/translation regimes properly

2015-02-03 Thread Peter Maydell
On 29 January 2015 at 18:55, Peter Maydell wrote: > This patchseries fixes up our somewhat broken handling of mmu_idx values: > * implement the full set of 7 mmu_idxes we need for supporting EL2 and EL3 > * pass the mmu_idx in the TB flags rather than EL or a priv flag, >so we can generate c

Re: [Qemu-devel] [PATCH 1/2] glusterfs: fix max_discard

2015-02-03 Thread Kevin Wolf
Am 03.02.2015 um 12:30 hat Peter Lieven geschrieben: > Am 03.02.2015 um 08:31 schrieb Denis V. Lunev: > > On 02/02/15 23:46, Denis V. Lunev wrote: > >> On 02/02/15 23:40, Peter Lieven wrote: > >>> Am 02.02.2015 um 21:09 schrieb Denis V. Lunev: > qemu_gluster_co_discard calculates size to disca

Re: [Qemu-devel] [PATCH 1/2] glusterfs: fix max_discard

2015-02-03 Thread Peter Lieven
Am 03.02.2015 um 12:37 schrieb Kevin Wolf: > Am 03.02.2015 um 12:30 hat Peter Lieven geschrieben: >> Am 03.02.2015 um 08:31 schrieb Denis V. Lunev: >>> On 02/02/15 23:46, Denis V. Lunev wrote: On 02/02/15 23:40, Peter Lieven wrote: > Am 02.02.2015 um 21:09 schrieb Denis V. Lunev: >> qe

Re: [Qemu-devel] [PATCH v2] target-arm: check that LSB <= MSB in BFI instruction

2015-02-03 Thread Peter Maydell
On 30 January 2015 at 12:59, Kirill Batuzov wrote: > The documentation states that if LSB > MSB in BFI instruction behaviour > is unpredictable. Currently QEMU crashes because of assertion failure in > this case: > > tcg/tcg-op.h:2061: tcg_gen_deposit_i32: Assertion `len <= 32' failed. > > While a

Re: [Qemu-devel] [PATCH] hw/arm/virt: explain device-to-transport mapping in create_virtio_devices()

2015-02-03 Thread Peter Maydell
On 30 January 2015 at 04:34, Laszlo Ersek wrote: > Peter, > > On 01/30/15 05:31, Laszlo Ersek wrote: >> Signed-off-by: Laszlo Ersek >> --- >> hw/arm/virt.c | 32 >> 1 file changed, 28 insertions(+), 4 deletions(-) >> >> diff --git a/hw/arm/virt.c b/hw/arm/virt.c

Re: [Qemu-devel] [PATCH 1/2] glusterfs: fix max_discard

2015-02-03 Thread Denis V. Lunev
On 03/02/15 14:47, Peter Lieven wrote: Am 03.02.2015 um 12:37 schrieb Kevin Wolf: Am 03.02.2015 um 12:30 hat Peter Lieven geschrieben: Am 03.02.2015 um 08:31 schrieb Denis V. Lunev: On 02/02/15 23:46, Denis V. Lunev wrote: On 02/02/15 23:40, Peter Lieven wrote: Am 02.02.2015 um 21:09 schrieb

Re: [Qemu-devel] [PATCH] libcacard: stop linking against every single 3rd party library

2015-02-03 Thread Paolo Bonzini
Cc: qemu-triv...@nongnu.org Cc: qemu-sta...@nongnu.org Reviewed-by: Paolo Bonzini On 03/02/2015 12:31, Daniel P. Berrange wrote: > Building QEMU results in a libcacard.so that links against > practically the entire world > > linux-vdso.so.1 => (0x7fff71e99000) > libssl3.so => /u

Re: [Qemu-devel] [RFC PATCH v8 11/21] replay: recording and replaying clock ticks

2015-02-03 Thread Paolo Bonzini
On 03/02/2015 12:23, Pavel Dovgaluk wrote: > > Only to the cpu_get_ticks usage. The others are okay. > > cpu_get_ticks cannot call cpu_get_real_ticks in icount mode. You're right, but... > And other functions can. ... which functions? cpu_enable_ticks and cpu_disable_ticks call it, but the

Re: [Qemu-devel] [PATCH] hw/arm/virt: explain device-to-transport mapping in create_virtio_devices()

2015-02-03 Thread Laszlo Ersek
On 02/03/15 12:51, Peter Maydell wrote: > On 30 January 2015 at 04:34, Laszlo Ersek wrote: >> Peter, >> >> On 01/30/15 05:31, Laszlo Ersek wrote: >>> Signed-off-by: Laszlo Ersek >>> --- >>> hw/arm/virt.c | 32 >>> 1 file changed, 28 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [PATCH] hw/arm/virt: explain device-to-transport mapping in create_virtio_devices()

2015-02-03 Thread Peter Maydell
On 3 February 2015 at 12:04, Laszlo Ersek wrote: > On 02/03/15 12:51, Peter Maydell wrote: >> Sure, no problem. I also suggest I add this para: >> * >> * In any case, the kernel makes no guarantee about the stability of >> * enumeration order of virtio devices (as demonstrated by it changing >>

[Qemu-devel] [PATCH RFC 0/1] KVM: ioctl for reading/writing guest memory

2015-02-03 Thread Thomas Huth
tl;dr: This patch adds a new ioctl to KVM on s390x for reading and writing from/to virtual guest memory, to take account of the so-called IPTE-lock on s390x (a locking mechanism for the host to walk MMU tables of the guest). Long story: Certain instruction interception handlers in QEMU have to acc

[Qemu-devel] [PATCH RFC 1/1] KVM: s390: Add MEMOP ioctl for reading/writing guest memory

2015-02-03 Thread Thomas Huth
On s390, we've got to make sure to hold the IPTE lock while accessing virtual memory. So let's add an ioctl for reading and writing virtual memory to provide this feature for userspace, too. Signed-off-by: Thomas Huth Reviewed-by: Dominik Dingel Reviewed-by: David Hildenbrand --- Documentation

[Qemu-devel] [PATCH] block: introduce BDRV_REQUEST_MAX_SECTORS

2015-02-03 Thread Peter Lieven
we check and adjust request sizes at several places with sometimes inconsistent checks or default values: INT_MAX INT_MAX >> BDRV_SECTOR_BITS UINT_MAX >> BDRV_SECTOR_BITS SIZE_MAX >> BDRV_SECTOR_BITS This patches introdocues a macro for the maximal allowed sectors per request and uses it at se

Re: [Qemu-devel] [PATCH 1/2] glusterfs: fix max_discard

2015-02-03 Thread Peter Lieven
Am 03.02.2015 um 12:51 schrieb Denis V. Lunev: > On 03/02/15 14:47, Peter Lieven wrote: >> Am 03.02.2015 um 12:37 schrieb Kevin Wolf: >>> Am 03.02.2015 um 12:30 hat Peter Lieven geschrieben: Am 03.02.2015 um 08:31 schrieb Denis V. Lunev: > On 02/02/15 23:46, Denis V. Lunev wrote: >> On

[Qemu-devel] [PATCH v2 0/3] bootdevcie: change the boot order validation logic

2015-02-03 Thread arei.gonglei
From: Gonglei The reset logic can be done by both machine reset and boot handler. So we shouldn't return error when the boot handler callback don't be set in patch 1. Patch 2 check boot order argument validation before vm running. Patch 3 passing &error_abort instead of NULL. v2 -> v1: - add

[Qemu-devel] [PATCH v2 2/3] bootdevice: check boot order argument validation before vm running

2015-02-03 Thread arei.gonglei
From: Gonglei Either 'once' option or 'order' option can take effect for -boot at the same time, that is say initial startup processing can check only one. And pc.c's set_boot_dev() fails when its boot order argument is invalid. This patch provide a solution fix this problem: 1. If "once" is gi

[Qemu-devel] [PATCH v2 3/3] bootdevice: add check in restore_boot_order()

2015-02-03 Thread arei.gonglei
From: Gonglei qemu_boot_set() can't fail in restore_boot_order(), then simply assert it doesn't fail, by passing &error_abort. Signed-off-by: Gonglei --- bootdevice.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bootdevice.c b/bootdevice.c index 52d3f9e..d3d4277 100644 -

[Qemu-devel] [PATCH v2 1/3] bootdevice: remove the check about boot_set_handler

2015-02-03 Thread arei.gonglei
From: Gonglei The reset logic can be done by both machine reset and boot handler. So we shouldn't return error when the boot handler callback don't be set. Signed-off-by: Gonglei Reviewed-by: Alexander Graf --- bootdevice.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) dif

[Qemu-devel] [PATCH] vfio: free dynamically-allocated data in instance_finalize

2015-02-03 Thread Paolo Bonzini
In order to enable out-of-BQL address space lookup, destruction of devices needs to be split in two phases. Unrealize is the first phase; once it complete no new accesses will be started, but there may still be pending memory accesses can still be completed. The second part is freeing the device,

[Qemu-devel] [PATCH v2 0/9] RCUification of the memory API, part 2

2015-02-03 Thread Paolo Bonzini
Part 2 converts ram_list to RCU. It is enough of a base for Stefan's work on thread-safe migration bitmaps. TCG folks, please review. Parts 3 (posted today) and 3.5 (to be done) will separate removal and reclamation of device data. Part 4 will switch KVM MMIO and PIO to unlocked lookup and conv

[Qemu-devel] [PATCH 4/9] rcu: introduce RCU-enabled QLIST

2015-02-03 Thread Paolo Bonzini
From: Mike Day Add RCU-enabled variants on the existing bsd DQ facility. Each operation has the same interface as the existing (non-RCU) version. Also, each operation is implemented as macro. Using the RCU-enabled QLIST, existing QLIST users will be able to convert to RCU without using a differe

[Qemu-devel] [PATCH 3/9] exec: RCUify AddressSpaceDispatch

2015-02-03 Thread Paolo Bonzini
Note that even after this patch, most callers of address_space_* functions must still be under the big QEMU lock, otherwise the memory region returned by address_space_translate can disappear as soon as address_space_translate returns. This will be fixed in the next part of this series. Signed-of

[Qemu-devel] [PATCH 6/9] cosmetic changes preparing for the following patches

2015-02-03 Thread Paolo Bonzini
From: Mike Day Signed-off-by: Mike Day Signed-off-by: Paolo Bonzini --- arch_init.c| 5 +-- exec.c | 84 +- include/exec/cpu-all.h | 1 + 3 files changed, 57 insertions(+), 33 deletions(-) diff --git a/arch_init.c b

[Qemu-devel] [PATCH 1/9] exec: introduce cpu_reload_memory_map

2015-02-03 Thread Paolo Bonzini
This for now is a simple TLB flush. This can change later for two reasons: 1) an AddressSpaceDispatch will be cached in the CPUState object 2) it will not be possible to do tlb_flush once the TCG-generated code runs outside the BQL. Signed-off-by: Paolo Bonzini --- cpu-exec.c | 6

[Qemu-devel] [PATCH 9/9] Convert ram_list to RCU

2015-02-03 Thread Paolo Bonzini
From: Mike Day Allow "unlocked" reads of the ram_list by using an RCU-enabled QLIST. The ramlist mutex is kept, because call_rcu callbacks are not run within the iothread lock. Thus, writers still need to take the ramlist mutex, but they no longer need to assume that the iothread lock is taken.

[Qemu-devel] [PATCH 7/9] rcu: prod call_rcu thread when calling synchronize_rcu

2015-02-03 Thread Paolo Bonzini
call_rcu operates on the principle that either there is a steady stream of incoming RCU callbacks, or it is not worthwhile to wake up and process the few that are there. This however makes it hard to assert in testcases that all RCU callbacks are processed. To avoid this, make call_rcu also proce

[Qemu-devel] [PATCH 8/9] exec: convert ram_list to QLIST

2015-02-03 Thread Paolo Bonzini
From: Mike Day QLIST has RCU-friendly primitives, so switch to it. Signed-off-by: Mike Day Signed-off-by: Paolo Bonzini Signed-off-by: Mike Day --- arch_init.c | 19 exec.c | 52 +--- include/exe

[Qemu-devel] [PATCH 5/9] exec: protect mru_block with RCU

2015-02-03 Thread Paolo Bonzini
Hence, freeing a RAMBlock has to be switched to call_rcu. Signed-off-by: Paolo Bonzini --- exec.c | 60 +++--- include/exec/cpu-all.h | 2 ++ 2 files changed, 44 insertions(+), 18 deletions(-) diff --git a/exec.c b/exec.c index a423de

Re: [Qemu-devel] [PATCH 1/2] kvm_stat: Define RESET ioctl number for PPC

2015-02-03 Thread Paolo Bonzini
On 30/01/2015 19:17, Wei Huang wrote: > This patch defines the RESET ioctl number for PPC architecture. Without it, > the reset() function of Event class can potentionally cause exception on > PPC. > > Signed-off-by: Wei Huang > --- > scripts/kvm/kvm_stat | 1 + > 1 file changed, 1 insertion(+

[Qemu-devel] [PATCH 2/9] exec: make iotlb RCU-friendly

2015-02-03 Thread Paolo Bonzini
After the previous patch, TLBs will be flushed on every change to the memory mapping. This patch augments that with synchronization of the MemoryRegionSections referred to in the iotlb array. With this change, it is guaranteed that iotlb_to_region will access the correct memory map, even once the

Re: [Qemu-devel] [PATCH RFC 0/1] KVM: ioctl for reading/writing guest memory

2015-02-03 Thread Paolo Bonzini
On 03/02/2015 13:11, Thomas Huth wrote: > The userspace (QEMU) then can simply call this ioctl when it wants > to read or write from/to virtual guest memory. Then kernel then takes > the IPTE-lock, walks the MMU table of the guest to find out the > physical address that corresponds to the virtual

Re: [Qemu-devel] [PATCH RFC 1/1] KVM: s390: Add MEMOP ioctl for reading/writing guest memory

2015-02-03 Thread Paolo Bonzini
On 03/02/2015 13:11, Thomas Huth wrote: > On s390, we've got to make sure to hold the IPTE lock while accessing > virtual memory. So let's add an ioctl for reading and writing virtual > memory to provide this feature for userspace, too. > > Signed-off-by: Thomas Huth > Reviewed-by: Dominik Ding

Re: [Qemu-devel] [PULL 0/2] OpenRISC patch queue for 2.3

2015-02-03 Thread Sebastian Macke
Hi Peter, unfortunately you are right. The correct line is this: /* invalidate lock */ -env->cpu_lock_addr = -1; +env->lock_addr = -1; I am sorry. It was most likely the last line which I added. But I forgot, that I disabled the system emulation already. Therefore my make proces

Re: [Qemu-devel] [PATCH RFC 0/1] KVM: ioctl for reading/writing guest memory

2015-02-03 Thread Christian Borntraeger
Am 03.02.2015 um 13:59 schrieb Paolo Bonzini: > > > On 03/02/2015 13:11, Thomas Huth wrote: >> The userspace (QEMU) then can simply call this ioctl when it wants >> to read or write from/to virtual guest memory. Then kernel then takes >> the IPTE-lock, walks the MMU table of the guest to find out

Re: [Qemu-devel] [PULL 0/2] OpenRISC patch queue for 2.3

2015-02-03 Thread Peter Maydell
On 3 February 2015 at 13:04, Sebastian Macke wrote: > Hi Peter, > > unfortunately you are right. > > The correct line is this: > > /* invalidate lock */ > -env->cpu_lock_addr = -1; > +env->lock_addr = -1; > > I am sorry. It was most likely the last line which I added. But I forgot, >

Re: [Qemu-devel] KVM call for agenda for 2015-02-03

2015-02-03 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please, send any topic that you are interested in covering. > > Thanks, Juan. > > Call details: As there are no agenda, call got cancelled. Could I do anything to improve the chances to have a call? Time change, call for agenda timing, etc? Just ping me if you h

[Qemu-devel] [PULL 0/9] s390x bugfixes and cleanups

2015-02-03 Thread Cornelia Huck
The following changes since commit 16017c48547960539fcadb1f91d252124f442482: softfloat: Clarify license status (2015-01-29 16:45:45 +) are available in the git repository at: git://github.com/cohuck/qemu tags/s390x-20150203 for you to fetch changes up to

[Qemu-devel] [PULL 1/9] s390: Plug memory leak on s390_pci_generate_event() error path

2015-02-03 Thread Cornelia Huck
From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Cornelia Huck --- hw/s390x/s390-pci-bus.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index 1201b8d..d25ac74 100644 --- a/hw/s390x/s390-pci-bus

[Qemu-devel] [PULL 7/9] s390x/ipl: Improved code indentation in s390_ipl_init()

2015-02-03 Thread Cornelia Huck
From: Thomas Huth The indentation of the code in s390_ipl_init() can be simplified a little bit by removing superfluous else-statements. Suggested-by: Michael Mueller Signed-off-by: Thomas Huth Acked-by: Cornelia Huck Signed-off-by: Cornelia Huck --- hw/s390x/ipl.c | 47 ++

[Qemu-devel] [PULL 2/9] s390x/pci: avoid sign extension in stpcifc

2015-02-03 Thread Cornelia Huck
From: Frank Blaschka This patch avoids sign extension and fixes a data conversion bug in stpcifc. Both issues where found by Coverity. Reviewed-by: Markus Armbruster Signed-off-by: Frank Blaschka Signed-off-by: Cornelia Huck --- hw/s390x/s390-pci-inst.c |8 1 file changed, 4 ins

Re: [Qemu-devel] [PATCH v1] vhost-user: fix not send all hugepage files to vhost-user

2015-02-03 Thread Linhaifeng
On 2015/2/2 7:29, Paolo Bonzini wrote: > > > On 17/12/2014 07:02, haifeng@huawei.com wrote: >> From: linhaifeng >> >> If we create VM with two or more numa nodes qemu will create two >> or more hugepage files but qemu only send one hugepage file fd >> to vhost-user when VM's memory size is

[Qemu-devel] [PULL 5/9] s390x/kvm: Fix diag-308 register decoding

2015-02-03 Thread Cornelia Huck
From: Thomas Huth Fix the decoding of the r1 register number in the diagnose 308 handler. Signed-off-by: Thomas Huth Reviewed-by: Michael Mueller Signed-off-by: Cornelia Huck --- target-s390x/kvm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-s390x/kvm.c b/ta

[Qemu-devel] [PULL 3/9] s390x/pci: check for invalid function handle

2015-02-03 Thread Cornelia Huck
From: Frank Blaschka broken guest may provide 0 (invalid) function handle to zpci instructions. Since we use function handle 0 to indicate an empty slot in the PHB we have to add an additional check to spot this kind of error. Signed-off-by: Frank Blaschka Signed-off-by: Cornelia Huck --- hw/

[Qemu-devel] [PULL 6/9] s390x/kvm: unknown DIAGNOSE code should give a specification exception

2015-02-03 Thread Cornelia Huck
From: Christian Borntraeger As described in CP programming services an unimplemented DIAGNOSE function should return a specification exception. Today we give the guest an operation exception. As both exception types are suppressing and Linux as a guest does not care about the type of program chec

[Qemu-devel] [PULL 4/9] s390x/pci: fix dma notifications in rpcit instruction

2015-02-03 Thread Cornelia Huck
From: Yi Min Zhao The virtual I/O address range passed to rpcit instruction might not map to consecutive physical guest pages. For this we have to translate and create mapping notifications for each vioa page separately. Signed-off-by: Yi Min Zhao Signed-off-by: Cornelia Huck --- hw/s390x/s39

[Qemu-devel] [PULL 8/9] pc-bios/s390-ccw: fix sparse warnings

2015-02-03 Thread Cornelia Huck
From: Christian Borntraeger Fix some sparse warnings in the s390-ccw bios. Signed-off-by: Christian Borntraeger Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/bootmap.c |4 ++-- pc-bios/s390-ccw/bootmap.h |2 +- pc-bios/s390-ccw/main.c |2 +- pc-bios/s390-ccw/s390-ccw.h |

[Qemu-devel] [PULL 9/9] pc-bios/s390-ccw: update binary

2015-02-03 Thread Cornelia Huck
Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw.img | Bin 17752 -> 17752 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/pc-bios/s390-ccw.img b/pc-bios/s390-ccw.img index 44873ad1817f44a5610ea556f86394b2c4a4c1ff..dbe5a38262cf6f2013154a77e850cda90e0fcaec 100644 GIT binary

Re: [Qemu-devel] [PATCH] block: introduce BDRV_REQUEST_MAX_SECTORS

2015-02-03 Thread Denis V. Lunev
On 03/02/15 15:12, Peter Lieven wrote: we check and adjust request sizes at several places with sometimes inconsistent checks or default values: INT_MAX INT_MAX >> BDRV_SECTOR_BITS UINT_MAX >> BDRV_SECTOR_BITS SIZE_MAX >> BDRV_SECTOR_BITS This patches introdocues a macro for the maximal

Re: [Qemu-devel] [PATCH] FMULX should flushes operators to zero when FZ is set.

2015-02-03 Thread Alex Bennée
Peter Maydell writes: > On 28 January 2015 at 15:57, Peter Maydell wrote: >> On 28 January 2015 at 15:54, Alex Bennée wrote: >>> Do we have test cases that trip up here? It would be nice to include >>> them in our testing as the random nature of RISU has obviously failed to >>> trip up on this

Re: [Qemu-devel] [PULL 0/9] s390x bugfixes and cleanups

2015-02-03 Thread Peter Maydell
On 3 February 2015 at 13:08, Cornelia Huck wrote: > The following changes since commit 16017c48547960539fcadb1f91d252124f442482: > > softfloat: Clarify license status (2015-01-29 16:45:45 +) > > are available in the git repository at: > > git://github.com/cohuck/qem

Re: [Qemu-devel] [PULL 0/9] s390x bugfixes and cleanups

2015-02-03 Thread Christian Borntraeger
vailable in the git repository at: >> >> git://github.com/cohuck/qemu tags/s390x-20150203 >> >> for you to fetch changes up to 553ce81c31e49d834b1bf635ab486695a4694333: >> >> pc-bios/s390-ccw: update binary (2015-02-03 13:42:40 +0100) >> >>

Re: [Qemu-devel] [PATCH 0/4] block: Drop BDS.filename

2015-02-03 Thread Max Reitz
On 2015-02-03 at 04:32, Kevin Wolf wrote: Am 24.09.2014 um 21:48 hat Max Reitz geschrieben: The BDS filename field is generally only used when opening disk images or emitting error or warning messages, the only exception to this rule is the map command of qemu-img. However, using exact_filename

Re: [Qemu-devel] [PATCH 1/3] nbd: Drop BDS backpointer

2015-02-03 Thread Max Reitz
On 2015-02-03 at 03:37, Paolo Bonzini wrote: On 02/02/2015 22:40, Max Reitz wrote: Before this patch, the "opaque" pointer in an NBD BDS points to a BDRVNBDState, which contains an NbdClientSession object, which in turn contains a pointer to the BDS. This pointer may become invalid due to bdrv_

Re: [Qemu-devel] [RFC PATCH v8 12/21] replay: recording and replaying different timers

2015-02-03 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 22/01/2015 09:52, Pavel Dovgalyuk wrote: > > This patch introduces functions for recording and replaying realtime > > sources, > > that do not use qemu-clock interface. These include return value of time() > > function in time_t and struct tm

Re: [Qemu-devel] [PULL 0/9] s390x bugfixes and cleanups

2015-02-03 Thread Peter Maydell
On 3 February 2015 at 13:08, Cornelia Huck wrote: > The following changes since commit 16017c48547960539fcadb1f91d252124f442482: > > softfloat: Clarify license status (2015-01-29 16:45:45 +) > > are available in the git repository at: > > git://github.com/cohuck/qem

Re: [Qemu-devel] [PATCH] block: introduce BDRV_REQUEST_MAX_SECTORS

2015-02-03 Thread Peter Lieven
Am 03.02.2015 um 14:29 schrieb Denis V. Lunev: On 03/02/15 15:12, Peter Lieven wrote: we check and adjust request sizes at several places with sometimes inconsistent checks or default values: INT_MAX INT_MAX >> BDRV_SECTOR_BITS UINT_MAX >> BDRV_SECTOR_BITS SIZE_MAX >> BDRV_SECTOR_BITS T

  1   2   3   >