Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-27 Thread Markus Armbruster
Eric Blake writes: > On 01/26/2015 01:48 AM, Javier Celaya wrote: >> Sorry, I forgot to patch the command-line help. Hope it helps. >> > Recently, SPICE included the lz4 compression algorithm. This patch adds a command line option to select it. > >>> >>> How is libvirt going to in

[Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-01-27 Thread Teruaki Ishizaki
Previously, qemu block driver of sheepdog used hard-coded VDI object size. This patch enables users to handle "block_size_shift" value for calculating VDI object size. When you start qemu, you don't need to specify additional command option. But when you create the VDI which doesn't have default

Re: [Qemu-devel] [PATCH 2/2] bootdevice: update boot_order in MachineState

2015-01-27 Thread Dinar Valeev
On 01/27/2015 03:51 AM, Gonglei wrote: > On 2015/1/27 7:52, dval...@suse.de wrote: > >> From: Dinar Valeev >> >> on sPAPR we need to update boot_order in MachineState in case it >> got changed on reset. >> >> Signed-off-by: Dinar Valeev >> --- >> bootdevice.c | 3 +++ >> 1 file changed, 3 inser

Re: [Qemu-devel] [PATCH 0/4] nbd: iotest fixes and error message improvement

2015-01-27 Thread Paolo Bonzini
On 27/01/2015 03:02, Max Reitz wrote: > This series is a follow-up to my previous patch "iotests: Specify format > for qemu-nbd" and as such relies on it. > > The first three patches of this series fix the qemu-iotests so they once > again pass when using NBD. > > The fourth patch of this serie

[Qemu-devel] [PATCH] scsi: Fix scsi_req_cancel_async for no aiocb req

2015-01-27 Thread Fam Zheng
scsi_req_cancel_complete is responsible for releasing the request, so we shouldn't skip it in any case. This doesn't affect the only existing caller, virtio-scsi, but is useful for other devices once they use it. Suggested-by: Paolo Bonzini Signed-off-by: Fam Zheng --- hw/scsi/scsi-bus.c | 2 ++

Re: [Qemu-devel] [PATCH 2/2] bootdevice: update boot_order in MachineState

2015-01-27 Thread Gonglei
On 2015/1/27 16:57, Dinar Valeev wrote: > On 01/27/2015 03:51 AM, Gonglei wrote: >> On 2015/1/27 7:52, dval...@suse.de wrote: >> >>> From: Dinar Valeev >>> >>> on sPAPR we need to update boot_order in MachineState in case it >>> got changed on reset. >>> >>> Signed-off-by: Dinar Valeev >>> --- >

Re: [Qemu-devel] [PATCH v2 3/3] pc-dimm: Add Error argument to pc_existing_dimms_capacity

2015-01-27 Thread Igor Mammedov
On Tue, 27 Jan 2015 09:35:02 +0530 Bharata B Rao wrote: > Now that pc_existing_dimms_capacity() is an API, include Error pointer > as an argument and modify the caller appropriately. > > Suggested-by: Igor Mammedov > Signed-off-by: Bharata B Rao > --- > hw/i386/pc.c | 4 ++-- > h

Re: [Qemu-devel] [PATCH v2 3/4] arm: Add PCIe host bridge in virt machine

2015-01-27 Thread Claudio Fontana
On 22.01.2015 16:52, Alexander Graf wrote: > > > On 22.01.15 16:28, Claudio Fontana wrote: >> Hi Alexander, >> >> thank you for the respin. I retested with the new mappings on OSv for >> AArch64, >> and they show up ok in the guest. >> >> Just a couple minor comments below, otherwise I think thi

Re: [Qemu-devel] [RFC PATCH 03/11] hw/arm/virt-acpi-build: Generate RSDP table

2015-01-27 Thread Shannon Zhao
On 2015/1/26 18:22, Igor Mammedov wrote: > On Sat, 24 Jan 2015 17:21:12 +0800 > Shannon Zhao wrote: > >> > RSDP points to XSDT which in turn points to other tables. >> > >> > Signed-off-by: Shannon Zhao >> > --- >> > hw/arm/virt-acpi-build.c | 22 ++ >> > 1 files changed,

Re: [Qemu-devel] [PATCH v4 37/47] Page request: Consume pages off the post-copy queue

2015-01-27 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Wed, Jan 14, 2015 at 08:13:27PM +, Dr. David Alan Gilbert wrote: > > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > > On Fri, Oct 03, 2014 at 06:47:43PM +0100, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David A

Re: [Qemu-devel] [RFC PATCH 03/11] hw/arm/virt-acpi-build: Generate RSDP table

2015-01-27 Thread Igor Mammedov
On Tue, 27 Jan 2015 17:36:29 +0800 Shannon Zhao wrote: > On 2015/1/26 18:22, Igor Mammedov wrote: > > On Sat, 24 Jan 2015 17:21:12 +0800 > > Shannon Zhao wrote: > > > >> > RSDP points to XSDT which in turn points to other tables. > >> > > >> > Signed-off-by: Shannon Zhao > >> > --- > >> > hw

Re: [Qemu-devel] [PATCH 2/2] bootdevice: update boot_order in MachineState

2015-01-27 Thread Dinar Valeev
On 01/27/2015 10:18 AM, Gonglei wrote: > On 2015/1/27 16:57, Dinar Valeev wrote: > >> On 01/27/2015 03:51 AM, Gonglei wrote: >>> On 2015/1/27 7:52, dval...@suse.de wrote: >>> From: Dinar Valeev on sPAPR we need to update boot_order in MachineState in case it got changed on res

Re: [Qemu-devel] [PATCH v4 43/47] Host page!=target page: Cleanup bitmaps

2015-01-27 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Wed, Dec 17, 2014 at 06:21:34PM +, Dr. David Alan Gilbert wrote: > > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > > On Fri, Oct 03, 2014 at 06:47:49PM +0100, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David A

Re: [Qemu-devel] [PATCH v2 3/4] arm: Add PCIe host bridge in virt machine

2015-01-27 Thread Peter Maydell
On 27 January 2015 at 09:24, Claudio Fontana wrote: > On 22.01.2015 16:52, Alexander Graf wrote: >> On 22.01.15 16:28, Claudio Fontana wrote: >>> Alex wrote; +for (devfn = 0; devfn <= 0x18; devfn+=0x8) { >>> >>> devfn += 0x8 (spaces) >> >> Yeah, I had it like that and it looked uglier. I

Re: [Qemu-devel] [PATCH v4 43/47] Host page!=target page: Cleanup bitmaps

2015-01-27 Thread Peter Maydell
On 3 October 2014 at 18:47, Dr. David Alan Gilbert (git) wrote: Just noticed after writing most of this email that this is an old patch with new review comments. I'm sending the below anyway in case some of it is still valid... > /* > + * Utility for the outgoing postcopy code. > + * > + * Disc

Re: [Qemu-devel] [RFC PATCH 02/11] hw/arm/virt-acpi-build: Basic framework for building ACPI tables

2015-01-27 Thread Igor Mammedov
On Tue, 27 Jan 2015 14:47:44 +0800 Shannon Zhao wrote: > On 2015/1/26 18:19, Igor Mammedov wrote: > > On Sat, 24 Jan 2015 17:21:11 +0800 > > Shannon Zhao wrote: > > > >> Introduce a preliminary framework in virt-acpi-build.c with the main > >> ACPI build functions. It exposes the generated ACPI

Re: [Qemu-devel] [PULL 0/9] tricore patches

2015-01-27 Thread Peter Maydell
On 26 January 2015 at 20:03, Bastian Koppelmann wrote: > The following changes since commit 1ac0206b2ae1ffaeec564f110664a3a77bafafd2: > > qemu-timer.c: Trim list of included headers (2015-01-26 18:15:54 +) > > are available in the git repository at: > > https://github.com/bkoppelmann/qemu-

Re: [Qemu-devel] [PULL 0/9] tricore patches

2015-01-27 Thread Bastian Koppelmann
On 01/27/2015 10:40 AM, Peter Maydell wrote: On 26 January 2015 at 20:03, Bastian Koppelmann wrote: The following changes since commit 1ac0206b2ae1ffaeec564f110664a3a77bafafd2: qemu-timer.c: Trim list of included headers (2015-01-26 18:15:54 +) are available in the git repository at:

Re: [Qemu-devel] [PATCH 2/2] bootdevice: update boot_order in MachineState

2015-01-27 Thread Dinar Valeev
On 01/27/2015 10:18 AM, Gonglei wrote: > On 2015/1/27 16:57, Dinar Valeev wrote: > >> On 01/27/2015 03:51 AM, Gonglei wrote: >>> On 2015/1/27 7:52, dval...@suse.de wrote: >>> From: Dinar Valeev on sPAPR we need to update boot_order in MachineState in case it got changed on res

[Qemu-devel] [PATCH RFC v2 3/8] block: BdrvDirtyBitmap serialization interface

2015-01-27 Thread Vladimir Sementsov-Ogievskiy
Several functions to provide necessary access to BdrvDirtyBitmap for block-migration.c Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 36 include/block/block.h | 12 2 files changed, 48 insertions(+) diff --git a/block.c

[Qemu-devel] [PATCH RFC v2 4/8] block: add dirty-dirty bitmaps

2015-01-27 Thread Vladimir Sementsov-Ogievskiy
A dirty-dirty bitmap is a dirty bitmap for BdrvDirtyBitmap. It tracks set/unset changes of BdrvDirtyBitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 44 include/block/block.h | 5 + 2 files changed, 49 insertions(+)

[Qemu-devel] [PATCH RFC v2 6/8] block: add bdrv_next_dirty_bitmap()

2015-01-27 Thread Vladimir Sementsov-Ogievskiy
Like bdrv_next() - bdrv_next_dirty_bitmap() is a function to provide access to private dirty bitmaps list. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 10 ++ include/block/block.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/block.c b/block.c inde

[Qemu-devel] [PATCH RFC v2 7/8] migration: add dirty parameter

2015-01-27 Thread Vladimir Sementsov-Ogievskiy
Add dirty parameter to qmp-migrate command. If this parameter is true, migration/block.c will migrate dirty bitmaps. This parameter can be used without "blk" parameter to migrate only dirty bitmaps, skipping block migration. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hmp-commands.hx

[Qemu-devel] [PATCH RFC v2 2/8] hbitmap: serialization

2015-01-27 Thread Vladimir Sementsov-Ogievskiy
Functions to serialize / deserialize(restore) HBitmap. HBitmap should be saved to linear sequence of bits independently of endianness and bitmap array element (unsigned long) size. Therefore Little Endian is chosen. These functions are appropriate for dirty bitmap migration, restoring the bitmap i

[Qemu-devel] [PATCH RFC v2 5/8] block: add bdrv_dirty_bitmap_enabled()

2015-01-27 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 5 + include/block/block.h | 1 + 2 files changed, 6 insertions(+) diff --git a/block.c b/block.c index 8ab724b..15fc621 100644 --- a/block.c +++ b/block.c @@ -5551,6 +5551,11 @@ uint64_t bdrv_dirty_bitmap_granularity(Bl

[Qemu-devel] [PATCH RFC v2 1/8] qmp: print dirty bitmap

2015-01-27 Thread Vladimir Sementsov-Ogievskiy
Adds qmp and hmp commands to print dirty bitmap. This is needed only for testing. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 33 + blockdev.c| 13 + hmp-commands.hx | 15 +++ hmp.c

[Qemu-devel] [PATCH RFC v2 8/8] migration: add migration/dirty-bitmap.c

2015-01-27 Thread Vladimir Sementsov-Ogievskiy
Live migration of dirty bitmaps. Only named dirty bitmaps are migrated. If destination qemu is already containing a dirty bitmap with the same name as a migrated bitmap, then their granularities should be the same, otherwise the error will be generated. If destination qemu doesn't contain such bitm

[Qemu-devel] [PATCH RFC v2 0/8] Dirty bitmaps migration

2015-01-27 Thread Vladimir Sementsov-Ogievskiy
v2: 1. bug-fixes, that are already in upstream, and renaming of function bdrv_reset_dirty_bitmap (which is already in Snow's series) are dropped 2. bitmap store/restore: the concept renamed to serialization, added function hbitmap_deserialize_part0, to not transfer zero blocks 3. migration di

Re: [Qemu-devel] [PATCH v2] linux-user/syscall.c: Free the vec[i] in failure processing code block

2015-01-27 Thread Michael Tokarev
23.01.2015 13:01, Chen Gang S wrote: > When failure occurs during allocating vec[i], also need free all > allocated vec[i] in failure processing code block before return. > > In unlock_user(), it will check vec[i].iov_base whether is NULL, so need > not check it again outside. > > If error is EFA

Re: [Qemu-devel] [PATCH 0/8] block: persistent dirty bitmaps (RFC)

2015-01-27 Thread Vladimir Sementsov-Ogievskiy
ping Best regards, Vladimir On 13.01.2015 20:02, Vladimir Sementsov-Ogievskiy wrote: The bitmaps are saved into qcow2 file format. It provides both 'internal' and 'external' dirty bitmaps feature: - for qcow2 drives we can store bitmaps in the same file - for other formats we can store bitm

[Qemu-devel] [PULL v2 3/9] target-tricore: calculate av bits before saturation

2015-01-27 Thread Bastian Koppelmann
64 bit mac instructions calculated the av bits after the saturation, which resulted in a wrong PSW. This moves the av bit calculation before the saturation. Signed-off-by: Bastian Koppelmann --- target-tricore/op_helper.c | 28 1 file changed, 16 insertions(+), 12 de

[Qemu-devel] [PULL v2 8/9] target-tricore: Add instructions of RRPW opcode format

2015-01-27 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann Reviewed-by: Richard Henderson --- target-tricore/translate.c | 70 ++ 1 file changed, 70 insertions(+) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index ea0a2fc..8943a39 100644 --- a/target-t

[Qemu-devel] [PULL v2 0/9] tricore patches

2015-01-27 Thread Bastian Koppelmann
The following changes since commit 1ac0206b2ae1ffaeec564f110664a3a77bafafd2: qemu-timer.c: Trim list of included headers (2015-01-26 18:15:54 +) are available in the git repository at: https://github.com/bkoppelmann/qemu-tricore-upstream.git tags/pull-tricore-20150127 for you to fetch

[Qemu-devel] [PULL v2 2/9] target-tricore: Several translator and cpu model fixes

2015-01-27 Thread Bastian Koppelmann
Fix tc1796 cpu model using wrong ISA version. Fix cond_add sometimes writing back wrong result. Fix RCR_SEL and RCR_SELN using wrong registers for result and cond. Signed-off-by: Bastian Koppelmann --- target-tricore/cpu.c | 2 +- target-tricore/op_helper.c | 1 + target-tricore/translate.

[Qemu-devel] [PULL v2 1/9] target-tricore: Add missing ULL suffix on 64 bit constant

2015-01-27 Thread Bastian Koppelmann
From: Peter Maydell Add a missing ULL suffix to a 64 bit constant: this suppresses a compiler warning from mingw32 gcc. Signed-off-by: Peter Maydell Signed-off-by: Bastian Koppelmann --- target-tricore/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-tric

[Qemu-devel] [PULL v2 7/9] target-tricore: Add instructions of RR2 opcode format

2015-01-27 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann Reviewed-by: Richard Henderson --- target-tricore/translate.c | 37 + 1 file changed, 37 insertions(+) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index 5e9eb28..ea0a2fc 100644 --- a/target-tricore/tr

[Qemu-devel] [PULL v2 9/9] target-tricore: Add instructions of RRR opcode format

2015-01-27 Thread Bastian Koppelmann
Add microcode generator function gen_cond_sub. Add helper functions: * ixmax/ixmin: search for the max/min value and its related index in a vector of 16-bit values. * pack: dack two data registers into an IEEE-754 single precision floating point format number

Re: [Qemu-devel] [PATCH v3 3/6] pci: define PCI_HOST_BRIDGE_CONFIG_ADDR and PCI_HOST_BRIDGE_CONFIG_DATA.

2015-01-27 Thread Michael S. Tsirkin
On Thu, Dec 11, 2014 at 10:20:25AM +0800, Hu Tao wrote: > PCI_HOST_BRIDGE_CONFIG_ADDR and PCI_HOST_BRIDGE_CONFIG_DATA are > defined in PCI specification, so move them to common place. > > Signed-off-by: Hu Tao > Reviewed-by: Marcel Apfelbaum If you read spec carefully you will see that it says

Re: [Qemu-devel] [PATCH v3 4/6] pci: remove the limit parameter of pci_host_config_read_common

2015-01-27 Thread Michael S. Tsirkin
On Thu, Dec 11, 2014 at 10:20:26AM +0800, Hu Tao wrote: > Since the limit parameter is always set to the size of pci device's > configuration space, That's not true in case of pci_data_read, is it? While the patch might be correct, a better analysis why that's so seems called for. > and we can d

Re: [Qemu-devel] [PULL 0/9] tricore patches

2015-01-27 Thread Peter Maydell
On 27 January 2015 at 11:45, Bastian Koppelmann wrote: > Sure thing. With this many clang warning, I think I should also build with > clang on my machine too. You don't have to (though of course you can if you like): I build pull requests with a pretty wide set of target configs which I don't exp

[Qemu-devel] [PULL v2 5/9] target-tricore: split up suov32 into suov32_pos and suov32_neg

2015-01-27 Thread Bastian Koppelmann
suov checks unsigned for an overflow and an underflow, after some arithmetic operations and saturates the result to either max_uint32 or 0. So far we handled this by expanding to the next bigger data type and compare whether the result is > max_uint32 or < 0. However this approach can fail for an

Re: [Qemu-devel] [PATCH v4 43/47] Host page!=target page: Cleanup bitmaps

2015-01-27 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 3 October 2014 at 18:47, Dr. David Alan Gilbert (git) > wrote: > > Just noticed after writing most of this email that this is an > old patch with new review comments. I'm sending the below > anyway in case some of it is still valid... Still

[Qemu-devel] [PULL v2 4/9] target-tricore: Fix bugs found by coverity

2015-01-27 Thread Bastian Koppelmann
This fixes one bug and one false positive found by coverity. The bug is, that gen_mtcr was missing a mask to check the flag, which resulted in dead code. The false positive is a intentional missing break for a jump and link address insn followed by a jump and link insn. This adds a fall through co

[Qemu-devel] [PULL v2 6/9] target-tricore: Add instructions of RR1 opcode format, that have 0x93 as first opcode

2015-01-27 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann Reviewed-by: Richard Henderson --- target-tricore/translate.c | 182 + 1 file changed, 182 insertions(+) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index 57949fa..5e9eb28 100644 --- a/target-

[Qemu-devel] [PATCH] block: Simplify a few g_try_malloc() error checks

2015-01-27 Thread Markus Armbruster
Unlike malloc(), g_try_malloc() & friends return a null pointer only on failure, never for a zero size. Simplify tests for failure accordingly. This helps Coverity see returned null pointers can't be dereferenced. Also makes the code easier to read. Tracked down with this Coccinelle semantic pa

Re: [Qemu-devel] [PATCH v5 2/5] acpi: move generic aml building helpers into dedictated file

2015-01-27 Thread Michael S. Tsirkin
On Wed, Jan 21, 2015 at 09:09:10AM +, Igor Mammedov wrote: > the will be later used for composing AML primitives > and all that could be reused later for ARM machines > as well. > > Signed-off-by: Igor Mammedov OK so the only thing holding this up is really that you have indicated that in th

Re: [Qemu-devel] [PATCH v2 00/11] cpu: add i386 cpu hot remove support

2015-01-27 Thread Bharata B Rao
On Tue, Jan 27, 2015 at 7:30 AM, Zhu Guihua wrote: > On Mon, 2015-01-26 at 12:27 +0100, Alexandre DERUMIER wrote: >> >>About this, I can do it successfully on my qemu. >> >>So can you tell us more information about your operation? >> simply start with >> >> -smp 2,sockets=2,cores=2,maxcpus=4 -devi

Re: [Qemu-devel] [RFC PATCH 02/11] hw/arm/virt-acpi-build: Basic framework for building ACPI tables

2015-01-27 Thread Hanjun Guo
On 2015年01月24日 17:21, Shannon Zhao wrote: Introduce a preliminary framework in virt-acpi-build.c with the main ACPI build functions. It exposes the generated ACPI contents to guest over fw_cfg. Some codes borrowed from hw/i386/acpi-build.c. The minimum required ACPI v5.1 tables for ARM are: - RS

Re: [Qemu-devel] [PULL v2 0/9] tricore patches

2015-01-27 Thread Peter Maydell
.com/bkoppelmann/qemu-tricore-upstream.git > tags/pull-tricore-20150127 > > for you to fetch changes up to 0953225588ee30de2e92485331ad1bb3d7c7d089: > > target-tricore: Add instructions of RRR opcode format (2015-01-27 11:48:02 > +) > > -

Re: [Qemu-devel] Submit your Google Summer of Code project ideas and volunteer to mentor

2015-01-27 Thread Hannes Reinecke
On 01/23/2015 06:21 PM, Stefan Hajnoczi wrote: > Dear libvirt, KVM, and QEMU contributors, > The Google Summer of Code season begins soon and it's time to collect > our thoughts for mentoring students this summer working full-time on > libvirt, KVM, and QEMU. > > What is GSoC? > Google Summer of C

[Qemu-devel] [PATCH] qemu-log: Correct help text of 'log cpu_reset'

2015-01-27 Thread Thomas Huth
The logging of the CPU state during reset is done for all architectures nowadays (see cpu_common_reset() in qom/cpu.c), so the "x86 only" text does not apply here anymore. Signed-off-by: Thomas Huth --- qemu-log.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-log

Re: [Qemu-devel] [PATCH] block: Simplify a few g_try_malloc() error checks

2015-01-27 Thread Paolo Bonzini
On 27/01/2015 13:25, Markus Armbruster wrote: > Unlike malloc(), g_try_malloc() & friends return a null pointer only > on failure, never for a zero size. Simplify tests for failure > accordingly. This helps Coverity see returned null pointers can't be > dereferenced. Also makes the code easier

[Qemu-devel] [PULL 04/16] pc: acpi: fix WindowsXP BSOD when memory hotplug is enabled

2015-01-27 Thread Michael S. Tsirkin
From: Igor Mammedov ACPI parser in XP considers PNP0A06 devices of CPU and memory hotplug as duplicates. Adding unique _UID to CPU hotplug device fixes BSOD. Cc: qemu-sta...@nongnu.org Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/

[Qemu-devel] [PULL 14/16] pc: Fix DIMMs capacity calculation

2015-01-27 Thread Michael S. Tsirkin
From: Bharata B Rao pc_existing_dimms_capacity() is returning DIMMs count rather than capacity. Fix this to return the capacity. Also consider only realized devices for capacity calculation. Signed-off-by: Bharata B Rao Reviewed-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by:

[Qemu-devel] [PULL 06/16] acpi: update generated hex files

2015-01-27 Thread Michael S. Tsirkin
Previous patch pc: acpi: fix WindowsXP BSOD when memory hotplug is enabled changed DSDT, update hex files for non-iasl builds. Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-dsdt.hex.generated | 43 +-- hw/i386/q35-acpi-dsdt.hex.generated | 45

[Qemu-devel] [PULL 15/16] pc-dimm: Make pc_existing_dimms_capacity global

2015-01-27 Thread Michael S. Tsirkin
From: Bharata B Rao Move pc_existing_dimms_capacity() to pc-dimm.c since it would be needed by PowerPC memory hotplug code too. Signed-off-by: Bharata B Rao Reviewed-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/mem/pc-dimm.h | 1 + hw/i

[Qemu-devel] [PULL 16/16] pc-dimm: Add Error argument to pc_existing_dimms_capacity

2015-01-27 Thread Michael S. Tsirkin
From: Bharata B Rao Now that pc_existing_dimms_capacity() is an API, include Error pointer as an argument and modify the caller appropriately. Suggested-by: Igor Mammedov Signed-off-by: Bharata B Rao Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov

Re: [Qemu-devel] [PATCH v2 21/47] acpi: add acpi_resource_template() helper

2015-01-27 Thread Claudio Fontana
Hello Igor, On 22.01.2015 15:50, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > hw/acpi/acpi-build-utils.c | 8 > include/hw/acpi/acpi-build-utils.h | 1 + > 2 files changed, 9 insertions(+) > > diff --git a/hw/acpi/acpi-build-utils.c b/hw/acpi/acpi-build-utils.c >

[Qemu-devel] [PULL 01/16] ich9: add disable_s3, disable_s4, s4_val properties

2015-01-27 Thread Michael S. Tsirkin
From: Amit Shah PIIX4 has disable_s3 and disable_s4 properties to enable or disable PM functions. Add such properties to the ICH9 chipset as well for the Q35 machine type. S3 / S4 are not guaranteed to always work (needs work in the guest as well as QEMU for things to work properly), and disabl

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2015-01-27 Thread Pasi Kärkkäinen
Hello, On Fri, Aug 22, 2014 at 08:45:03AM +, Gonglei (Arei) wrote: > > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > > Sent: Thursday, August 21, 2014 6:31 AM > > To: Fabio Fantoni > > Cc: Ross Philipson; Ian Campbell; Paul Durrant; ke...@koconnor.net; > > Huangweidong (C); Han

[Qemu-devel] [PULL 05/16] acpi-test: update expected DSDT

2015-01-27 Thread Michael S. Tsirkin
Previous patch pc: acpi: fix WindowsXP BSOD when memory hotplug is enabled changed DSDT, update expected test files. Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/pc/DSDT | Bin 3592 -> 3621 bytes tests/acpi-test-data/q35/DSDT | Bin 8182 -> 8211 bytes tests/acpi-test-data/q35/

[Qemu-devel] [PATCH] block: fix off-by-one error in qcow and qcow2

2015-01-27 Thread Jeff Cody
This fixes an off-by-one error introduced in 9a29e18. Both qcow and qcow2 need to make sure to leave room for string terminator '\0' for the backing file, so the max length of the non-terminated string is either 1023 or PATH_MAX - 1. Reported-by: Kevin Wolf Signed-off-by: Jeff Cody --- block/q

[Qemu-devel] [PULL 12/16] smbios: Fix dimm size calculation when RAM is multiple of 16GB

2015-01-27 Thread Michael S. Tsirkin
From: Eduardo Habkost The Memory Device size calculation logic is broken when the RAM size is a multiple of 16GB, making the size of the last entry be 0 instead of 16GB. Fix the logic to handle that case correctly. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: M

Re: [Qemu-devel] [PATCH v2 21/47] acpi: add acpi_resource_template() helper

2015-01-27 Thread Michael S. Tsirkin
On Tue, Jan 27, 2015 at 02:26:34PM +0100, Claudio Fontana wrote: > Hello Igor, > > On 22.01.2015 15:50, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > hw/acpi/acpi-build-utils.c | 8 > > include/hw/acpi/acpi-build-utils.h | 1 + > > 2 files changed, 9 insertio

Re: [Qemu-devel] [PATCH] block: Simplify a few g_try_malloc() error checks

2015-01-27 Thread Markus Armbruster
Paolo Bonzini writes: > On 27/01/2015 13:25, Markus Armbruster wrote: >> Unlike malloc(), g_try_malloc() & friends return a null pointer only >> on failure, never for a zero size. Simplify tests for failure >> accordingly. This helps Coverity see returned null pointers can't be >> dereferenced.

[Qemu-devel] [Bug 897750] Re: libvirt/kvm problem with disk attach/detach/reattach on running virt

2015-01-27 Thread Stefan Bader
Serge, Scott, somehow I think we all left here in a confused state and I do not think we still have the problem (at least not Trusty). From my last comment it seems I did not even find something that I could change for Precise. For now I would unassign myself and maybe this report should be closed

[Qemu-devel] [PULL 09/16] virtio: fix feature bit checks

2015-01-27 Thread Michael S. Tsirkin
From: Cornelia Huck Several places check against the feature bit number instead of against the feature bit. Fix them. Cc: qemu-sta...@nongnu.org Reported-by: Thomas Huth Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/scsi/virtio-scsi.c

Re: [Qemu-devel] [PATCH v2 0/8] qemu: guest agent: implement guest-exec command for Linux

2015-01-27 Thread Denis V. Lunev
On 31/12/14 16:06, Denis V. Lunev wrote: hese patches for guest-agent add the functionality to execute commands on a guest UNIX machine. These patches add the following interfaces: guest-pipe-open guest-exec guest-exec-status With these interfaces it's possible to: * Open an anonymous pipe an

[Qemu-devel] [PATCH 7/7] block/raw-posix: set max_write_zeroes to INT_MAX for regular files

2015-01-27 Thread Denis V. Lunev
fallocate() works fine and could handle properly with arbitrary size requests. There is no sense to reduce the amount of space to fallocate. The bigger is the size, the better is the performance as the amount of journal updates is reduced. Signed-off-by: Denis V. Lunev CC: Kevin Wolf CC: Stefan

[Qemu-devel] [PATCH 3/7] block/raw-posix: refactor handle_aiocb_write_zeroes a bit

2015-01-27 Thread Denis V. Lunev
move code dealing with a block device to a separate function. This will allow to implement additional processing for ordinary files. Pls note, that xfs_code has been moved before checking for s->has_write_zeroes as xfs_write_zeroes does not touch this flag inside. This makes code a bit more consis

[Qemu-devel] [PATCH 1/7] block/raw-posix: create translate_err helper to merge errno values

2015-01-27 Thread Denis V. Lunev
actually the code if (ret == -ENODEV || ret == -ENOSYS || ret == -EOPNOTSUPP || ret == -ENOTTY) { ret = -ENOTSUP; } is present twice and will be added a couple more times. Create helper for this. Signed-off-by: Denis V. Lunev CC: Kevin Wolf CC: Stefan Hajnoczi CC: Peter

[Qemu-devel] [PATCH 6/7] block/raw-posix: call plain fallocate in handle_aiocb_write_zeroes

2015-01-27 Thread Denis V. Lunev
There is a possibility that we are extending our image and thus writing zeroes beyond the end of the file. In this case we do not need to care about the hole to make sure that there is no data in the file under this offset (pre-condition to fallocate(0) to work). We could simply call fallocate(0).

Re: [Qemu-devel] [PATCH v2 1/4] pci: Split pcie_host_mmcfg_map()

2015-01-27 Thread Peter Maydell
On 21 January 2015 at 16:18, Alexander Graf wrote: > The mmcfg space is a memory region that allows access to PCI config space > in the PCIe world. To maintain abstraction layers, I would like to expose > the mmcfg space as a sysbus mmio region rather than have it mapped straight > into the system

[Qemu-devel] [PULL 00/16] pci, pc, virtio fixes and cleanups

2015-01-27 Thread Michael S. Tsirkin
The following changes since commit 1e42c353469cb58ca4f3b450eea4211af7d0b147: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20150116' into staging (2015-01-16 12:06:41 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags

Re: [Qemu-devel] [PATCH v5 1/3] qcow2: Add qcow2_shrink_l1_and_l2_table for qcow2 shrinking

2015-01-27 Thread Jun Li
On Thu, 01/22 14:14, Max Reitz wrote: > On 2015-01-19 at 08:16, Jun Li wrote: > >On Thu, 01/15 13:47, Max Reitz wrote: > >>On 2015-01-03 at 07:23, Jun Li wrote: > >>>On Fri, 11/21 11:56, Max Reitz wrote: > So, as for what I think we do need to do when shrinking (and keep in mind: > The offs

Re: [Qemu-devel] [PATCH] block: Simplify a few g_try_malloc() error checks

2015-01-27 Thread Kevin Wolf
Am 27.01.2015 um 14:42 hat Markus Armbruster geschrieben: > Paolo Bonzini writes: > > > On 27/01/2015 13:25, Markus Armbruster wrote: > >> Unlike malloc(), g_try_malloc() & friends return a null pointer only > >> on failure, never for a zero size. Simplify tests for failure > >> accordingly. Th

Re: [Qemu-devel] [PATCH] block: fix off-by-one error in qcow and qcow2

2015-01-27 Thread Kevin Wolf
Am 27.01.2015 um 14:33 hat Jeff Cody geschrieben: > This fixes an off-by-one error introduced in 9a29e18. Both qcow and > qcow2 need to make sure to leave room for string terminator '\0' for > the backing file, so the max length of the non-terminated string is > either 1023 or PATH_MAX - 1. > > R

[Qemu-devel] [PULL 11/16] bios-linker-loader: move source to common location

2015-01-27 Thread Michael S. Tsirkin
There are plans to use bios linker by MIPS, ARM. It's only used by ACPI ATM, so put it in hw/acpi and make it depend on CONFIG_ACPI. Signed-off-by: Michael S. Tsirkin --- hw/{i386 => acpi}/bios-linker-loader.c | 0 hw/acpi/Makefile.objs | 1 + hw/i386/Makefile.objs

[Qemu-devel] [PULL 03/16] pci: Split pcie_host_mmcfg_map()

2015-01-27 Thread Michael S. Tsirkin
From: Alexander Graf The mmcfg space is a memory region that allows access to PCI config space in the PCIe world. To maintain abstraction layers, I would like to expose the mmcfg space as a sysbus mmio region rather than have it mapped straight into the system's memory address space though. So t

[Qemu-devel] [PULL 02/16] Add some trace calls to pci.c.

2015-01-27 Thread Michael S. Tsirkin
From: Don Koch Signed-off-by: Don Koch Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/pci/pci.c | 9 + trace-events | 4 2 files changed, 13 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 371699c..d5e0e41 100644 --- a/hw/pci/pci.c +++ b/hw/pc

[Qemu-devel] [PULL 13/16] smbios: Don't report unknown CPU speed (fix SVVP regression)

2015-01-27 Thread Michael S. Tsirkin
From: Eduardo Habkost SVVP requires processor speed on Type 4 structures to not be unknown. This was fixed in SeaBIOS 0.5.0 (in 2009), but the bug was reintroduced in QEMU 2.1. Revert to old behavior and report CPU speed as 2000 MHz instead of unknown. Signed-off-by: Eduardo Habkost Reviewed-b

Re: [Qemu-devel] [PATCH v2 1/4] pci: Split pcie_host_mmcfg_map()

2015-01-27 Thread Michael S. Tsirkin
On Tue, Jan 27, 2015 at 01:55:32PM +, Peter Maydell wrote: > On 21 January 2015 at 16:18, Alexander Graf wrote: > > The mmcfg space is a memory region that allows access to PCI config space > > in the PCIe world. To maintain abstraction layers, I would like to expose > > the mmcfg space as a s

[Qemu-devel] [PATCH 4/7] block: use fallocate(FALLOC_FL_ZERO_RANGE) in handle_aiocb_write_zeroes

2015-01-27 Thread Denis V. Lunev
This efficiently writes zeroes on Linux if the kernel is capable enough. FALLOC_FL_ZERO_RANGE correctly handles all cases, including and not including file expansion. Signed-off-by: Denis V. Lunev CC: Kevin Wolf CC: Stefan Hajnoczi CC: Peter Lieven CC: Fam Zheng --- block/raw-posix.c | 16 ++

Re: [Qemu-devel] [RFC 01/10] target-arm: protect cpu_exclusive_*.

2015-01-27 Thread Alex Bennée
fred.kon...@greensocs.com writes: > From: KONRAD Frederic > > This adds a lock to avoid multiple exclusive access at the same time in case > of > TCG multithread. > > Signed-off-by: KONRAD Frederic > > V1 -> V2: > Removed qemu_mutex_destroy(). > --- > target-arm/cpu.c | 14 +++

Re: [Qemu-devel] [PATCH V2 0/4] target-arm: Initial ARMv8 extended EL support

2015-01-27 Thread Sergey Fedorov
On 23.01.2015 19:17, Greg Bellows wrote: > These patches add extended EL support for ARMv8. Specifically the following > changes were made: > > - Fix issue in RVBAR_EL1 CP register definition > - Add missing RVBAR_ELx CP register definitions > - Add missing SP_ELx CP register definitions > - Add re

Re: [Qemu-devel] [PATCH v2 3/4] arm: Add PCIe host bridge in virt machine

2015-01-27 Thread Claudio Fontana
On 27.01.2015 11:09, Peter Maydell wrote: > On 27 January 2015 at 09:24, Claudio Fontana > wrote: >> On 22.01.2015 16:52, Alexander Graf wrote: >>> On 22.01.15 16:28, Claudio Fontana wrote: Alex wrote; > +for (devfn = 0; devfn <= 0x18; devfn+=0x8) { devfn += 0x8 (spaces) >>

Re: [Qemu-devel] [PATCH V2 0/4] target-arm: Initial ARMv8 extended EL support

2015-01-27 Thread Greg Bellows
+Edgar On Tue, Jan 27, 2015 at 8:36 AM, Sergey Fedorov wrote: > On 23.01.2015 19:17, Greg Bellows wrote: > > These patches add extended EL support for ARMv8. Specifically the > following > > changes were made: > > > > - Fix issue in RVBAR_EL1 CP register definition > > - Add missing RVBAR_ELx CP

Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough

2015-01-27 Thread Ian Jackson
Chen, Tiejun writes ("Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"): > On 2015/1/23 8:43, Chen, Tiejun wrote: > > On 2015/1/22 8:51, Chen, Tiejun wrote: > >> At this point I just concern here if we still use 'gfx_passthrou', at > >> least it may

Re: [Qemu-devel] [PATCH v2 1/4] pci: Split pcie_host_mmcfg_map()

2015-01-27 Thread Paolo Bonzini
On 27/01/2015 15:24, Michael S. Tsirkin wrote: > I suspect this is not the only device that leaks memory now. > Paolo? It should be, this is a bug. Commit d8d95814609e89e5438a3318a647ec322fc4ff16 missed this place due to a rebase error. (I can tell it's a rebase error because I have the fixed

[Qemu-devel] [PATCH v4 0/7] eliminate data write in bdrv_write_zeroes on Linux in raw-posix.c

2015-01-27 Thread Denis V. Lunev
These patches eliminate data writes completely on Linux if fallocate FALLOC_FL_ZERO_RANGE or FALLOC_FL_PUNCH_HOLE are supported on underlying filesystem. I have performed several tests with non-aligned fallocate calls and in all cases (with non-aligned fallocates) Linux performs fine, i.e. areas

Re: [Qemu-devel] [RFC 02/10] use a different translation block list for each cpu.

2015-01-27 Thread Alex Bennée
fred.kon...@greensocs.com writes: > From: KONRAD Frederic > > We need a different TranslationBlock list for each core in case of multithread > TCG. > > Signed-off-by: KONRAD Frederic > --- > translate-all.c | 40 ++-- > 1 file changed, 22 insertions(+), 18 d

[Qemu-devel] [PULL 10/16] bios-linker-loader: move header to common location

2015-01-27 Thread Michael S. Tsirkin
Will be usable by MIPS, ARM. Signed-off-by: Michael S. Tsirkin --- {hw/i386 => include/hw/acpi}/bios-linker-loader.h | 0 hw/i386/acpi-build.c | 2 +- hw/i386/bios-linker-loader.c | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) rename {

[Qemu-devel] [PULL 07/16] acpi: build_append_nameseg(): add padding if necessary

2015-01-27 Thread Michael S. Tsirkin
From: Igor Mammedov According to ACPI spec NameSeg shorter than 4 characters must be padded up to 4 characters with "_" symbol. ACPI 5.0: 20.2.2 "Name Objects Encoding" Do it in build_append_nameseg() so that caller shouldn't know or care about it. Signed-off-by: Igor Mammedov Reviewed-by: Cl

[Qemu-devel] [PATCH 2/7] block/raw-posix: create do_fallocate helper

2015-01-27 Thread Denis V. Lunev
The pattern do { if (fallocate(s->fd, mode, offset, len) == 0) { return 0; } } while (errno == EINTR); ret = translate_err(-errno); will be commonly useful in next patches. Create helper for it. Signed-off-by: Denis V. Lunev CC: Kevin Wolf CC: Stefan Hajno

[Qemu-devel] [PULL 08/16] bios-tables-test: split piix4 and q35 tests

2015-01-27 Thread Michael S. Tsirkin
From: Paolo Bonzini This makes it clear which one is failing. Signed-off-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: John Snow --- tests/bios-tables-test.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tes

[Qemu-devel] [PATCH 5/7] block: use fallocate(FALLOC_FL_PUNCH_HOLE) & fallocate(0) to write zeroes

2015-01-27 Thread Denis V. Lunev
This sequence works efficiently if FALLOC_FL_ZERO_RANGE is not supported. Unfortunately, FALLOC_FL_ZERO_RANGE is supported on really modern systems and only for a couple of filesystems. FALLOC_FL_PUNCH_HOLE is much more mature. The sequence of 2 operations FALLOC_FL_PUNCH_HOLE and 0 is necessary d

Re: [Qemu-devel] [PATCH v3 07/14] qemu-img: Use BlockBackend as far as possible

2015-01-27 Thread Max Reitz
On 2015-01-26 at 22:38, Eric Blake wrote: On 01/26/2015 08:00 AM, Max Reitz wrote: Although qemu-img already creates BlockBackends, it does not do accesses to the images through them. This patch converts all of the bdrv_* calls for which this is currently possible to blk_* calls. Most of the rem

Re: [Qemu-devel] [RFC 02/10] use a different translation block list for each cpu.

2015-01-27 Thread Frederic Konrad
On 27/01/2015 15:45, Alex Bennée wrote: fred.kon...@greensocs.com writes: From: KONRAD Frederic We need a different TranslationBlock list for each core in case of multithread TCG. Signed-off-by: KONRAD Frederic --- translate-all.c | 40 ++-- 1 file cha

Re: [Qemu-devel] [PATCH v3 06/14] qemu-img: Use blk_new_open() in img_rebase()

2015-01-27 Thread Max Reitz
On 2015-01-26 at 22:05, Eric Blake wrote: On 01/26/2015 08:00 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- qemu-img.c | 57 - 1 file changed, 24 insertions(+), 33 deletions(-) - /* For safe rebasing we need to compare old an

Re: [Qemu-devel] [PATCH v2 2/4] pci: Add generic PCIe host bridge

2015-01-27 Thread Peter Maydell
On 21 January 2015 at 16:18, Alexander Graf wrote: > With simple exposure of MMFG, ioport window, mmio window and an IRQ line we Four :-) > can successfully create a workable PCIe host bridge that can be mapped > anywhere > and only needs to get described to the OS using whatever means it likes

  1   2   3   4   >