Re: [Qemu-devel] question about live migration with storage

2015-01-14 Thread Zhang Haoyu
On 2015-01-14 15:42:41, Paolo Bonzini wrote: > > On 14/01/2015 03:41, Zhang Haoyu wrote: > > Hi, Paolo, > > what's advantages of drive_mirror over traditional mechanism implemented in > > block-migration.c ? > > Why libvirt use drive_mirror instead of traditional iterative mechanism as > > the

Re: [Qemu-devel] a question for control queue

2015-01-14 Thread Jason Wang
On 01/09/2015 02:41 PM, Ouyang, Changchun wrote: > > Hi all, > > I have a question about the control queue in qemu, > > When the qemu have configured the control queue, and guest also > negotiated the control queue successfully with qemu, > > Will the qemu will let vhost know guest try to use cont

[Qemu-devel] [PATCH v3] PPC: E500: Add FSL i2c controller and integrate RTC with it

2015-01-14 Thread Amit Tomar
This patch adds an emulation model for i2c controller found on most of the FSL SoCs. It also integrates the RTC(ds1338) that sits on the i2c Bus with e500 machine model. Signed-off-by: Amit Singh Tomar --- Changes in v3: * Reordered the subject line to appropriate one Changes in v2:

Re: [Qemu-devel] [Bug 1409246] Re: ARM GIC / PL061 error on uni-processor system

2015-01-14 Thread Chris
On 12 January 2015 22:15:22 GMT+00:00, Christopher Covington wrote: >Hi Christopher, > >On 01/10/2015 11:42 AM, Christopher Horler wrote: >> confirmed - not a bug, patching the kernel fixes the problem. > >Mind pointing to your patch? I've been seeing the "GIC CPU mask not >found - >kernel will f

Re: [Qemu-devel] question about live migration with storage

2015-01-14 Thread Paolo Bonzini
On 14/01/2015 08:58, Zhang Haoyu wrote: >> 2) Finer-grain control the parameters of block migration (dirty bitmap >> granularity). >> >> 3) Block and RAM migration do not share the same socket and thus can >> more easily be parallelized. >> > But, because of the parallelization, how to calculate

Re: [Qemu-devel] [RFC PATCH v7 08/21] replay: interrupts and exceptions

2015-01-14 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 12/01/2015 13:40, Pavel Dovgaluk wrote: > >>> > >> > Perhaps check the replay_interrupt() outside, in an && with "if > >> > (unlikely(interrupt_request))"? > > You mean that I should wrap whole condition into "unlikely"? > > > > No, I wanted

Re: [Qemu-devel] Fedora FC21 - Bug: 100% CPU and hangs in gettimeofday(&tp, NULL); forever

2015-01-14 Thread Gerhard Wiesinger
On 14.01.2015 01:59, Laine Stump wrote: Take a look at the following kernel bug. It specifically deals with a hang in gettimeofday() in a KVM guest: https://bugzilla.redhat.com/show_bug.cgi?id=1178975 There is a link to a patched kernel you can try; it fixed my problems (I was repeatedly getti

[Qemu-devel] [PULL 02/15] vl.c: fix regression when reading machine type from config file

2015-01-14 Thread Paolo Bonzini
From: Marcel Apfelbaum After 'Machine as QOM' series the machine type input triggers the creation of the machine class. If the machine type is set in the configuration file, the machine class is not updated accordingly and remains the default. Fixed that by querying the machine options after the

[Qemu-devel] [PULL 05/15] vl: fix max_cpus check

2015-01-14 Thread Paolo Bonzini
From: Andrew Jones We should confirm max_cpus, which is >= smp_cpus, is <= the machine's true max_cpus, not just smp_cpus. Signed-off-by: Andrew Jones Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost Signed-off-by: Paolo Bonzini --- vl.c | 4 ++-- 1 file changed, 2 insertions(+),

[Qemu-devel] [PULL 07/15] vl.c: fix regression when reading memory size from config file

2015-01-14 Thread Paolo Bonzini
From: Marcel Apfelbaum This is happening because an actual logic is performed on the memory arguments inside the main's switch, disregarding the config file content. Solved by extracting the logic on a separate function and calling it after the switch. Signed-off-by: Marcel Apfelbaum Signed-of

[Qemu-devel] [PULL 00/15] Misc patches for 2015-01-14

2015-01-14 Thread Paolo Bonzini
The following changes since commit f1c5831ca3e3eafb89331233221768b64db113e8: Merge remote-tracking branch 'remotes/amit-virtio-rng/tags/rng-for-2.3' into staging (2015-01-09 18:55:29 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you

[Qemu-devel] [PULL 08/15] target-i386: fix movntsd on big-endian hosts

2015-01-14 Thread Paolo Bonzini
This was accessing an XMM register's low half without going through XMM_Q. Cc: qemu-sta...@nongnu.org Reviewed-by: Eduardo Habkost Signed-off-by: Paolo Bonzini --- target-i386/translate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target-i386/translate.c b/target-i386

[Qemu-devel] [PULL 14/15] qemu-timer: rename timer_init to timer_init_tl

2015-01-14 Thread Paolo Bonzini
timer_init is not called that often. Free the name for an equivalent of timer_new. Signed-off-by: Paolo Bonzini --- include/block/aio.h | 2 +- include/qemu/timer.h | 10 +- qemu-timer.c | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/include/block/

[Qemu-devel] [PULL 03/15] 9pfs: changed to use event_notifier instead of qemu_pipe

2015-01-14 Thread Paolo Bonzini
From: SeokYeon Hwang Changed to use event_notifier instead of qemu_pipe. It is necessary for porting 9pfs to Windows and MacOS. Signed-off-by: SeokYeon Hwang Signed-off-by: Paolo Bonzini --- hw/9pfs/virtio-9p-coth.c | 29 +++-- hw/9pfs/virtio-9p-coth.h | 4 ++-- 2 fil

[Qemu-devel] [PULL 04/15] vl: Avoid unnecessary 'if' nesting

2015-01-14 Thread Paolo Bonzini
From: Eduardo Habkost Just a coding style change, to make other changes easier to review. Signed-off-by: Eduardo Habkost Reviewed-by: Andrew Jones Signed-off-by: Paolo Bonzini --- vl.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/vl.c b/vl.c index 1a2da2b..5

[Qemu-devel] [PULL 15/15] cpus: consistently use QEMU_CLOCK_VIRTUAL_RT for icount_warp_rt timer

2015-01-14 Thread Paolo Bonzini
From: Pavel Dovgalyuk Fix mismatch between timer_new_ms and timer_mod. Signed-off-by: Pavel Dovgalyuk Signed-off-by: Paolo Bonzini --- cpus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpus.c b/cpus.c index 2edb5cd..3a5323b 100644 --- a/cpus.c +++ b/cpus.c @@ -324,7 +

[Qemu-devel] [PULL 01/15] char: restore stdio echo on resume from suspend.

2015-01-14 Thread Paolo Bonzini
From: Gal Hammer The monitor's auto-completion feature stopped working when stdio is used as an input and qemu was resumed after it was suspended (using ctrl-z). Signed-off-by: Gal Hammer Signed-off-by: Paolo Bonzini --- qemu-char.c | 15 +++ 1 file changed, 15 insertions(+) diff

[Qemu-devel] [PULL 09/15] target-i386: do not memcpy in and out of xmm_regs

2015-01-14 Thread Paolo Bonzini
After the next patch, we will move the high parts of AVX and AVX512 registers in the same array as the SSE registers. This will make it impossible to memcpy an array of 128-bit values in and out of xmm_regs in one swoop. Use a for loop instead. Similarly, always use XMM_Q in translate.c. This av

[Qemu-devel] [PULL 10/15] qemu-common.h: optimise muldiv64 if int128 is available

2015-01-14 Thread Paolo Bonzini
From: Frediano Ziglio Let compiler do the job to optimise the function. Signed-off-by: Frediano Ziglio Signed-off-by: Paolo Bonzini Signed-off-by: Frediano Ziglio --- include/qemu-common.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/qemu-common.h b/include/qemu-common.

[Qemu-devel] [PULL 06/15] vl: Don't silently change topology when all -smp options were set

2015-01-14 Thread Paolo Bonzini
From: Eduardo Habkost QEMU tries to change the "threads" option even if it was explicitly set in the command-line, and it shouldn't do that. The right thing to do when all options (cpus, sockets, cores, threds) are explicitly set is to sanity check them and abort in case they don't make sense (i

[Qemu-devel] [PULL 13/15] scsi: fix cancellation when I/O was completed but DMA was not.

2015-01-14 Thread Paolo Bonzini
Commit d577646 (scsi: Introduce scsi_req_cancel_complete, 2014-09-25) was supposed to have no semantic change, but it missed a case. When r->aiocb has already been NULLed, but DMA was not complete and the SCSI layer was waiting for scsi_req_continue, after the patch the SCSI layer will not call th

Re: [Qemu-devel] [RFC PATCH v7 08/21] replay: interrupts and exceptions

2015-01-14 Thread Paolo Bonzini
On 14/01/2015 10:07, Pavel Dovgaluk wrote: >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> On 12/01/2015 13:40, Pavel Dovgaluk wrote: > > Perhaps check the replay_interrupt() outside, in an && with "if > (unlikely(interrupt_request))"? >>> You mean that I should wrap whole cond

[Qemu-devel] [PULL 11/15] hw/scsi/lsi53c895a: add support for additional diag / debug registers

2015-01-14 Thread Paolo Bonzini
From: Peter Lieven Some ancient Linux kernels read from registers 0x09 and 0x3c-3f during boot. According to the spec these registers are for diag and debug purposes only. If they are absend qemu aborts on read. Signed-off-by: Peter Lieven Signed-off-by: Paolo Bonzini --- hw/scsi/lsi53c895a.c

Re: [Qemu-devel] [PATCH v2 2/2] e1000: decrement RDT if equal to RDH

2015-01-14 Thread Jason Wang
On 01/14/2015 05:06 AM, Richard Tollerton wrote: > Jason Wang writes: > >> On Tue, Jan 13, 2015 at 3:12 AM, Richard Tollerton >> wrote: >>> On Thu, Dec 18, 2014 at 12:01:48AM -0500, Jason Wang wrote: >>> > Some drivers set RDT=RDH. Oddly, this works on real hardware. To > work aroun

[Qemu-devel] [PULL 12/15] rules.mak: Fix module build

2015-01-14 Thread Paolo Bonzini
From: Fam Zheng Module build is broken since commit c261d774fb ( rules.mak: Fix DSO build by pulling in archive symbols). That commit added .mo placeholders of DSO to -y variables, in order to pull stub symbols to executable. But the placeholders are unintentionally expanded in -y, rather than fi

Re: [Qemu-devel] [RFC PATCH v7 08/21] replay: interrupts and exceptions

2015-01-14 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 14/01/2015 10:07, Pavel Dovgaluk wrote: > >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > >> On 12/01/2015 13:40, Pavel Dovgaluk wrote: > > > > Perhaps check the replay_interrupt() outside, in an

[Qemu-devel] [PATCH v9 0/4] machvirt dynamic sysbus device instantiation

2015-01-14 Thread Eric Auger
This patch series enables machvirt to dynamically instantiate sysbus devices from command line (using -device option). All those sysbus devices are plugged onto a platform bus. This latter device is instantiated in machvirt and takes care of the binding of children sysbus devices on a machine init

[Qemu-devel] [PATCH v9 3/4] hw/arm/virt: add dynamic sysbus device support

2015-01-14 Thread Eric Auger
Allows sysbus devices to be instantiated from command line by using -device option. Machvirt creates a platform bus at init. The dynamic sysbus devices are attached to this platform bus device. The platform bus device registers a machine init done notifier whose role will be to bind the dynamic sy

[Qemu-devel] [PATCH v9 1/4] hw/arm/sysbus-fdt: helpers for platform bus nodes addition

2015-01-14 Thread Eric Auger
This new C module will be used by ARM machine files to generate platform bus node and their dynamic sysbus device tree nodes. Dynamic sysbus device node addition is done in a machine init done notifier. arm_register_platform_bus_fdt_creator does the registration of this latter and is supposed to b

[Qemu-devel] [PATCH v9 2/4] hw/arm/boot: arm_load_kernel implemented as a machine init done notifier

2015-01-14 Thread Eric Auger
Device tree nodes for the platform bus and its children dynamic sysbus devices are added in a machine init done notifier. To load the dtb once, after those latter nodes are built and before ROM freeze, the actual arm_load_kernel existing code is moved into a notifier notify function, arm_load_kerne

[Qemu-devel] [PATCH v9 4/4] hw/arm/virt: change indentation in a15memmap

2015-01-14 Thread Eric Auger
Re-indent in a15memmap after VIRT_PLATFORM_BUS introduction Signed-off-by: Eric Auger --- hw/arm/virt.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 66cd553..9d65406 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -1

[Qemu-devel] [RFC v3 0/2] Add Generic PCI host device update

2015-01-14 Thread Alvise Rigo
This is just an update to address the comments received on v2. This patch series is based on the previous work [1] and [2] by Rob Herring. This is a stand alone work, but I will not hesitate to split the patches in a more accurate way if needed. Changes from [1] and [2]: - memory topology definit

[Qemu-devel] [RFC v3 2/2] hw/arm/virt: add generic-pci PCI host controller

2015-01-14 Thread Alvise Rigo
The platform memory map has now three more memory ranges to map the device's memory regions (Configuration region, I/O region and Memory region). The dt node interrupt-map property tells how to route the PCI interrupts to system interrupts. In the mach-virt case, four IRQs are swizzled between all

[Qemu-devel] [RFC v3 1/2] pci/pci-host: Add generic-pci PCI host controller device

2015-01-14 Thread Alvise Rigo
Add a generic PCI host controller for virtual platforms, based on the previous work by Rob Herring: http://lists.gnu.org/archive/html/qemu-devel/2014-06/msg03482.html The controller relies on a configuration memory region and provides two PCI memory regions for I/O (one port and one memory mapped)

Re: [Qemu-devel] [PATCH] AIO: Reduce number of threads for 32bit hosts

2015-01-14 Thread Kevin Wolf
Am 14.01.2015 um 08:37 hat Paolo Bonzini geschrieben: > > > On 14/01/2015 01:56, Alexander Graf wrote: > > +if (sizeof(pool) == 4) { > > +/* 32bit systems run out of virtual memory quickly */ > > +pool->max_threads = 4; > > +} else { > > +pool->max_threads = 64; >

[Qemu-devel] [RFH PATCH 0/2] xen-mapcache: fixes for unlocked memory access

2015-01-14 Thread Paolo Bonzini
These are small preparations to let Xen support memory access outside the BQL. Warning: they are not tested beyond compilation. Paolo Bonzini (2): xen: do not use __-named variables in mapcache xen: add a lock for the mapcache xen-mapcache.c | 94 +++-

[Qemu-devel] [RFH PATCH 1/2] xen: do not use __-named variables in mapcache

2015-01-14 Thread Paolo Bonzini
Keep the namespace clean. Signed-off-by: Paolo Bonzini --- xen-mapcache.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/xen-mapcache.c b/xen-mapcache.c index 66da1a6..458069b 100644 --- a/xen-mapcache.c +++ b/xen-mapcache.c @@ -199

[Qemu-devel] [RFH PATCH 2/2] xen: add a lock for the mapcache

2015-01-14 Thread Paolo Bonzini
Extend the existing dummy mapcache_lock/unlock macros to cover all of xen-mapcache.c. This prepares for unlocked memory access, when parts of exec.c will not be protected by the BQL. Signed-off-by: Paolo Bonzini --- xen-mapcache.c | 54 +++--- 1 f

Re: [Qemu-devel] [RFC PATCH v7 08/21] replay: interrupts and exceptions

2015-01-14 Thread Paolo Bonzini
On 14/01/2015 11:06, Pavel Dovgaluk wrote: >> > I think it is okay. INIT executes cpu_loop_exit() on x86 because >> > processors other than the boot processor are halted after they receive >> > INIT. > Then I cannot put everything in one if-else chain because it will change the > behavior of t

Re: [Qemu-devel] [PATCH 4/9] hbitmap: store / restore

2015-01-14 Thread Vladimir Sementsov-Ogievskiy
Best regards, Vladimir On 13.01.2015 20:08, John Snow wrote: On 01/13/2015 07:59 AM, Vladimir Sementsov-Ogievskiy wrote: On 09.01.2015 00:21, John Snow wrote: On 12/11/2014 09:17 AM, Vladimir Sementsov-Ogievskiy wrote: +/** + * hbitmap_restore_finish + * @hb: HBitmap to operate on. + *

Re: [Qemu-devel] [PATCH] block: update string sizes for filename, backing_file, exact_filename

2015-01-14 Thread Kevin Wolf
Am 13.01.2015 um 21:49 hat John Snow geschrieben: > > > On 01/13/2015 12:03 PM, Jeff Cody wrote: > >The string field entries 'filename', 'backing_file', and > >'exact_filename' in the BlockDriverState struct are defined as 1024 > >bytes. > > > >However, most places that use these values accept a

Re: [Qemu-devel] [PATCH] AIO: Reduce number of threads for 32bit hosts

2015-01-14 Thread Paolo Bonzini
On 14/01/2015 11:20, Kevin Wolf wrote: >> > The same problem applies to coroutine stacks, and those cannot be >> > throttled down as easily. But I guess if you limit the number of >> > threads, the guest gets slowed down and doesn't create as many coroutines. > Shouldn't we rather try and decrea

Re: [Qemu-devel] [PATCH 5/9] block: BdrvDirtyBitmap store/restore interface

2015-01-14 Thread Vladimir Sementsov-Ogievskiy
As in previous patch, rename store/restore to serialize/deserialize... Hmm. In this case, isn't it be better to include serialization of granularity, name and name length in these functions? Best regards, Vladimir On 11.12.2014 17:17, Vladimir Sementsov-Ogievskiy wrote: Several functions to

Re: [Qemu-devel] [PATCH for 2.3 v2 1/1] xen-hvm: increase maxmem before calling xc_domain_populate_physmap

2015-01-14 Thread Stefano Stabellini
On Tue, 13 Jan 2015, Don Slutz wrote: > On 01/13/15 13:07, Stefano Stabellini wrote: > > On Mon, 12 Jan 2015, Stefano Stabellini wrote: > >> On Wed, 3 Dec 2014, Don Slutz wrote: > >>> From: Stefano Stabellini > >>> > >>> Increase maxmem before calling xc_domain_populate_physmap_exact to > >>> avoi

Re: [Qemu-devel] [RFH PATCH 1/2] xen: do not use __-named variables in mapcache

2015-01-14 Thread Stefano Stabellini
On Wed, 14 Jan 2015, Paolo Bonzini wrote: > Keep the namespace clean. > > Signed-off-by: Paolo Bonzini Acked-by: Stefano Stabellini > xen-mapcache.c | 40 > 1 file changed, 20 insertions(+), 20 deletions(-) > > diff --git a/xen-mapcache.c b/xen-mapca

Re: [Qemu-devel] [RFH PATCH 2/2] xen: add a lock for the mapcache

2015-01-14 Thread Stefano Stabellini
On Wed, 14 Jan 2015, Paolo Bonzini wrote: > Extend the existing dummy mapcache_lock/unlock macros to cover all of > xen-mapcache.c. This prepares for unlocked memory access, when parts > of exec.c will not be protected by the BQL. > > Signed-off-by: Paolo Bonzini Acked-by: Stefano Stabellini

Re: [Qemu-devel] [PATCH 16/19] block/parallels: no need to flush on each block allocation table update

2015-01-14 Thread Roman Kagan
On Tue, Jan 13, 2015 at 11:16:04PM +0300, Denis V. Lunev wrote: > On 13/01/15 18:17, Denis V. Lunev wrote: > >On 13/01/15 17:50, Roman Kagan wrote: > >>On Tue, Dec 30, 2014 at 01:07:09PM +0300, Denis V. Lunev wrote: > >>>--- a/block/parallels.c > >>>+++ b/block/parallels.c > >>>@@ -194,7 +194,7 @@

Re: [Qemu-devel] [PATCH] pseries: Limit PCI host bridge "index" value

2015-01-14 Thread Paolo Bonzini
On 14/01/2015 03:33, David Gibson wrote: > pseries guests can have large numbers of PCI host bridges. To avoid the > user having to specify a number of different configuration values for every > one, the device supports an "index" property which is a shorthand setting > the various window and co

Re: [Qemu-devel] [PATCH 6/9] block-migration: tiny refactoring

2015-01-14 Thread Vladimir Sementsov-Ogievskiy
On 09.01.2015 00:23, John Snow wrote: On 12/11/2014 09:17 AM, Vladimir Sementsov-Ogievskiy wrote: Add blk_create and blk_free to remove code duplicates. Otherwise, duplicates will rise in the following patches because of BlkMigBlock sturcture extendin. Signed-off-by: Vladimir Sementsov-Ogievs

Re: [Qemu-devel] [PATCH 16/19] block/parallels: no need to flush on each block allocation table update

2015-01-14 Thread Denis V. Lunev
On 14/01/15 15:01, Roman Kagan wrote: On Tue, Jan 13, 2015 at 11:16:04PM +0300, Denis V. Lunev wrote: On 13/01/15 18:17, Denis V. Lunev wrote: On 13/01/15 17:50, Roman Kagan wrote: On Tue, Dec 30, 2014 at 01:07:09PM +0300, Denis V. Lunev wrote: --- a/block/parallels.c +++ b/block/parallels.c

Re: [Qemu-devel] [PATCH 17/19] block/parallels: delay writing to BAT till bdrv_co_flush_to_os

2015-01-14 Thread Roman Kagan
On Tue, Dec 30, 2014 at 01:07:10PM +0300, Denis V. Lunev wrote: > The idea is that we do not need to immediately sync BAT to the image as > from the guest point of view there is a possibility that IO is lost > even in the physical controller until flush command was finished. > bdrv_co_flush_to_os i

Re: [Qemu-devel] [PATCH 17/19] block/parallels: delay writing to BAT till bdrv_co_flush_to_os

2015-01-14 Thread Denis V. Lunev
On 14/01/15 16:03, Roman Kagan wrote: On Tue, Dec 30, 2014 at 01:07:10PM +0300, Denis V. Lunev wrote: The idea is that we do not need to immediately sync BAT to the image as from the guest point of view there is a possibility that IO is lost even in the physical controller until flush command wa

Re: [Qemu-devel] [RFC v3 2/2] hw/arm/virt: add generic-pci PCI host controller

2015-01-14 Thread Claudio Fontana
On 14.01.2015 11:16, Alvise Rigo wrote: > The platform memory map has now three more memory ranges to map the > device's memory regions (Configuration region, I/O region and Memory > region). > > The dt node interrupt-map property tells how to route the PCI interrupts > to system interrupts. In th

Re: [Qemu-devel] [PATCH 1/9] qmp hmp: Factor out common "using spice" test

2015-01-14 Thread Eric Blake
On 01/13/2015 10:50 AM, Markus Armbruster wrote: > Into qemu_using_spice(). For want of a better place, put it next the > existing monitor command handler dummies in qemu-spice.h. > > Signed-off-by: Markus Armbruster > --- > include/ui/qemu-spice.h | 10 ++ > monitor.c |

Re: [Qemu-devel] [RFC v3 1/2] pci/pci-host: Add generic-pci PCI host controller device

2015-01-14 Thread Claudio Fontana
On 14.01.2015 11:16, Alvise Rigo wrote: > Add a generic PCI host controller for virtual platforms, based on the > previous work by Rob Herring: > http://lists.gnu.org/archive/html/qemu-devel/2014-06/msg03482.html > > The controller relies on a configuration memory region and provides two > PCI mem

Re: [Qemu-devel] [PATCH 2/9] qmp hmp: Improve error messages when SPICE is not in use

2015-01-14 Thread Eric Blake
On 01/13/2015 10:50 AM, Markus Armbruster wrote: > Commit 7572150 adopted QERR_DEVICE_NOT_ACTIVE for the purpose, > probably because adding another error seemed cumbersome overkill. > Produces "No spice device has been activated", which is awkward. > > We've since abandoned our quest for "rich" er

Re: [Qemu-devel] [PATCH 1/4] target-i386: fix movntsd on big-endian hosts

2015-01-14 Thread Eduardo Habkost
On Tue, Jan 13, 2015 at 08:49:19PM +0100, Paolo Bonzini wrote: > > > On 13/01/2015 19:48, Eduardo Habkost wrote: > >> > if (b1 & 1) { > >> > -gen_stq_env_A0(s, offsetof(CPUX86State, xmm_regs[reg])); > >> > +gen_stq_env_A0(s, offsetof(CPUX86State, > >>

Re: [Qemu-devel] [PATCH 1/4] target-i386: fix movntsd on big-endian hosts

2015-01-14 Thread Paolo Bonzini
On 14/01/2015 14:17, Eduardo Habkost wrote: >>> > > Do we have (or will patch 4/4 introduce) the same bug on the >>> > > tcg_gen_addi_ptr() calls that don't use the XMM_Q macro? >> > >> > No, they all call into helpers that use the XMM_Q macro themselves. > tcg_gen_addi_ptr() is called sometimes

Re: [Qemu-devel] [PATCH 4/9] qmp: Clean up qmp_query_spice() #ifndef !CONFIG_SPICE dummy

2015-01-14 Thread Eric Blake
On 01/13/2015 10:50 AM, Markus Armbruster wrote: > QMP command query-spice exists only #ifdef CONFIG_SPICE. Due to QAPI > limitations, we need a dummy function anyway, but it's unreachable. > > Our current dummy function goes out of its way to produce the exact > same error as the QMP core does f

Re: [Qemu-devel] [PATCH 8/9] balloon: Factor out common "is balloon active" test

2015-01-14 Thread Eric Blake
On 01/13/2015 10:50 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > balloon.c | 29 +++-- > 1 file changed, 15 insertions(+), 14 deletions(-) > > diff --git a/balloon.c b/balloon.c > index 2884c2d..aa30617 100644 > --- a/balloon.c > +++ b/balloon.c

Re: [Qemu-devel] [PATCH 9/9] balloon: Eliminate silly QERR_ macros

2015-01-14 Thread Eric Blake
On 01/13/2015 10:50 AM, Markus Armbruster wrote: > The QERR_ macros are leftovers from the days of "rich" error objects. > They're used with error_set() and qerror_report(), and expand into the > first *two* arguments. This trickiness has become pointless. Clean > up. I like your wording in 6/9

[Qemu-devel] [virtio] virtqueue allocation and thread-safety

2015-01-14 Thread Vasile Catalin-B50542
Hi, I'm trying to make a new virtio device. I got it running (I made a functional dummy device & guest driver). Now I'm trying to build some communication between the device and guest driver. I can't seem to find where the actual allocation of virtqueues are made. I've looked inside virtio_init

Re: [Qemu-devel] [PATCH 17/19] block/parallels: delay writing to BAT till bdrv_co_flush_to_os

2015-01-14 Thread Roman Kagan
On Wed, Jan 14, 2015 at 04:08:50PM +0300, Denis V. Lunev wrote: > On 14/01/15 16:03, Roman Kagan wrote: > >On Tue, Dec 30, 2014 at 01:07:10PM +0300, Denis V. Lunev wrote: > >>+static int cache_bat(BlockDriverState *bs, uint32_t idx, uint32_t > >>new_data_off) > >>+{ > >>+int ret, i, off, cache

Re: [Qemu-devel] [PATCH] AIO: Reduce number of threads for 32bit hosts

2015-01-14 Thread Kevin Wolf
Am 14.01.2015 um 12:18 hat Paolo Bonzini geschrieben: > > > On 14/01/2015 11:20, Kevin Wolf wrote: > >> > The same problem applies to coroutine stacks, and those cannot be > >> > throttled down as easily. But I guess if you limit the number of > >> > threads, the guest gets slowed down and doesn

[Qemu-devel] [Bug 1410288] Re: qemu-img conversion to qcow2 hangs with blank image less than 100kiB

2015-01-14 Thread Neil Wilson
** Also affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1410288 Title: qemu-img conversion to qcow2 hangs with blank image less than 100kiB

Re: [Qemu-devel] [PATCH 1/4] target-i386: fix movntsd on big-endian hosts

2015-01-14 Thread Eduardo Habkost
On Wed, Jan 14, 2015 at 02:24:57PM +0100, Paolo Bonzini wrote: > On 14/01/2015 14:17, Eduardo Habkost wrote: > >>> > > Do we have (or will patch 4/4 introduce) the same bug on the > >>> > > tcg_gen_addi_ptr() calls that don't use the XMM_Q macro? > >> > > >> > No, they all call into helpers that u

Re: [Qemu-devel] [RFC v3 2/2] hw/arm/virt: add generic-pci PCI host controller

2015-01-14 Thread alvise rigo
Hi Claudio, On Wed, Jan 14, 2015 at 2:10 PM, Claudio Fontana wrote: > On 14.01.2015 11:16, Alvise Rigo wrote: >> The platform memory map has now three more memory ranges to map the >> device's memory regions (Configuration region, I/O region and Memory >> region). >> >> The dt node interrupt-map

Re: [Qemu-devel] [PATCH] AIO: Reduce number of threads for 32bit hosts

2015-01-14 Thread Paolo Bonzini
On 14/01/2015 14:38, Kevin Wolf wrote: > Well, what do you want to use it for? I thought it would only be for a > one-time check where we usually end up rather than something that would > be enabled in production, but maybe I misunderstood. No, you didn't. Though I guess we could limit the chec

Re: [Qemu-devel] [PATCH 2/9] qmp hmp: Improve error messages when SPICE is not in use

2015-01-14 Thread Markus Armbruster
Eric Blake writes: > On 01/13/2015 10:50 AM, Markus Armbruster wrote: >> Commit 7572150 adopted QERR_DEVICE_NOT_ACTIVE for the purpose, >> probably because adding another error seemed cumbersome overkill. >> Produces "No spice device has been activated", which is awkward. >> >> We've since aband

Re: [Qemu-devel] [PATCH 1/9] qmp hmp: Factor out common "using spice" test

2015-01-14 Thread Markus Armbruster
Eric Blake writes: > On 01/13/2015 10:50 AM, Markus Armbruster wrote: >> Into qemu_using_spice(). For want of a better place, put it next the >> existing monitor command handler dummies in qemu-spice.h. >> >> Signed-off-by: Markus Armbruster >> --- >> include/ui/qemu-spice.h | 10 ++ >

Re: [Qemu-devel] [PATCH v5 0/5] Geometry and blocksize detection for backing devices.

2015-01-14 Thread Stefan Hajnoczi
On Tue, Jan 13, 2015 at 08:07:15PM +0100, Christian Borntraeger wrote: > Am 13.01.2015 um 17:04 schrieb Stefan Hajnoczi: > [...] > > I'm really starting to get worried that you are going to break things. > > This DASD hack is a layering violation but okay, go ahead if you want. > > But now you are

Re: [Qemu-devel] [PATCH 1/2] qed: check for header size overflow

2015-01-14 Thread Kevin Wolf
Am 12.01.2015 um 13:31 hat Stefan Hajnoczi geschrieben: > Header size is denoted in clusters. The maximum cluster size is 64 MB > but there is no limit on header size. Check for uint32_t overflow in > case the header size field has a whacky value. > > Signed-off-by: Stefan Hajnoczi > --- > blo

Re: [Qemu-devel] [PATCH] AIO: Reduce number of threads for 32bit hosts

2015-01-14 Thread Kevin Wolf
Am 14.01.2015 um 14:49 hat Paolo Bonzini geschrieben: > > > On 14/01/2015 14:38, Kevin Wolf wrote: > > Well, what do you want to use it for? I thought it would only be for a > > one-time check where we usually end up rather than something that would > > be enabled in production, but maybe I misun

Re: [Qemu-devel] [PATCH] AIO: Reduce number of threads for 32bit hosts

2015-01-14 Thread Alexander Graf
On 01/14/15 15:07, Kevin Wolf wrote: Am 14.01.2015 um 14:49 hat Paolo Bonzini geschrieben: On 14/01/2015 14:38, Kevin Wolf wrote: Well, what do you want to use it for? I thought it would only be for a one-time check where we usually end up rather than something that would be enabled in product

Re: [Qemu-devel] [PATCH 18/19] block/parallels: add prealloc-mode and prealloc-size open paramemets

2015-01-14 Thread Roman Kagan
On Tue, Dec 30, 2014 at 01:07:11PM +0300, Denis V. Lunev wrote: > This is preparational commit for tweaks in Parallels image expansion. > The idea is that enlarge via truncate by one data block is slow. It > would be much better to use fallocate via bdrv_write_zeroes and > expand by some significan

Re: [Qemu-devel] [PATCH 17/19] block/parallels: delay writing to BAT till bdrv_co_flush_to_os

2015-01-14 Thread Denis V. Lunev
On 14/01/15 16:34, Roman Kagan wrote: On Wed, Jan 14, 2015 at 04:08:50PM +0300, Denis V. Lunev wrote: On 14/01/15 16:03, Roman Kagan wrote: On Tue, Dec 30, 2014 at 01:07:10PM +0300, Denis V. Lunev wrote: +static int cache_bat(BlockDriverState *bs, uint32_t idx, uint32_t new_data_off) +{ +i

Re: [Qemu-devel] [PATCH] AIO: Reduce number of threads for 32bit hosts

2015-01-14 Thread Markus Armbruster
Paolo Bonzini writes: > On 14/01/2015 11:20, Kevin Wolf wrote: >>> > The same problem applies to coroutine stacks, and those cannot be >>> > throttled down as easily. But I guess if you limit the number of >>> > threads, the guest gets slowed down and doesn't create as many coroutines. >> Should

Re: [Qemu-devel] [PATCH 18/19] block/parallels: add prealloc-mode and prealloc-size open paramemets

2015-01-14 Thread Denis V. Lunev
On 14/01/15 17:26, Roman Kagan wrote: On Tue, Dec 30, 2014 at 01:07:11PM +0300, Denis V. Lunev wrote: This is preparational commit for tweaks in Parallels image expansion. The idea is that enlarge via truncate by one data block is slow. It would be much better to use fallocate via bdrv_write_zer

[Qemu-devel] [PATCH 4/4] block: Eliminate silly QERR_ macros used for encryption keys

2015-01-14 Thread Markus Armbruster
The QERR_ macros are leftovers from the days of "rich" error objects. They're used with error_set() and qerror_report(), and expand into the first *two* arguments. This trickiness has become pointless. Clean up QERR_DEVICE_ENCRYPTED and QERR_DEVICE_NOT_ENCRYPTED. Signed-off-by: Markus Armbruster

[Qemu-devel] [PATCH 0/4] block: Cleanups around error reporting

2015-01-14 Thread Markus Armbruster
Markus Armbruster (4): blockdev: Give find_block_job() an Error ** parameter blockdev: Eliminate silly QERR_BLOCK_JOB_NOT_ACTIVE macro block: New bdrv_add_key(), convert monitor to use it block: Eliminate silly QERR_ macros used for encryption keys block.c | 31 +

[Qemu-devel] [PATCH 1/4] blockdev: Give find_block_job() an Error ** parameter

2015-01-14 Thread Markus Armbruster
When find_block_job() fails, all its callers build the same Error object. Build it in find_block_job() instead. Signed-off-by: Markus Armbruster --- blockdev.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/blockdev.c b/blockdev.c index d59efd3..8d6ca35

[Qemu-devel] [PATCH 3/4] block: New bdrv_add_key(), convert monitor to use it

2015-01-14 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- block.c | 29 + blockdev.c| 24 ++-- include/block/block.h | 1 + monitor.c | 16 +++- qmp.c | 8 5 files changed, 47 insertions(+), 31

Re: [Qemu-devel] [PATCH 8/9] balloon: Factor out common "is balloon active" test

2015-01-14 Thread Markus Armbruster
Eric Blake writes: > On 01/13/2015 10:50 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> balloon.c | 29 +++-- >> 1 file changed, 15 insertions(+), 14 deletions(-) >> >> diff --git a/balloon.c b/balloon.c >> index 2884c2d..aa30617 100644 >> --

[Qemu-devel] [PATCH 2/4] blockdev: Eliminate silly QERR_BLOCK_JOB_NOT_ACTIVE macro

2015-01-14 Thread Markus Armbruster
From: Markus Armbruster The QERR_ macros are leftovers from the days of "rich" error objects. They're used with error_set() and qerror_report(), and expand into the first *two* arguments. This trickiness has become pointless. Clean this one up. Signed-off-by: Markus Armbruster --- blockdev.c

[Qemu-devel] [PATCH] tcg: Add doxygen documentation to the tcg frontend

2015-01-14 Thread Bastian Koppelmann
There is no overview, that shows all the frontend operation one can use, as found on the wiki. Unfortunatly the wiki is out of date, so let's try to move this documentation to the source files, which has the benefit, that it is easy to update the documentation, if the frontend is changed. This patc

[Qemu-devel] [PATCH] s390x/pci: fix 2 bugs found by coverity

2015-01-14 Thread Frank Blaschka
Signed-off-by: Frank Blaschka --- hw/s390x/s390-pci-bus.c | 1 + hw/s390x/s390-pci-inst.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index 1201b8d..546dcf1 100644 --- a/hw/s390x/s390-pci-bus.c +++ b/hw/s390x/s390-pci-bu

Re: [Qemu-devel] [PATCH 0/4] block: Cleanups around error reporting

2015-01-14 Thread Eric Blake
On 01/14/2015 07:31 AM, Markus Armbruster wrote: > Markus Armbruster (4): > blockdev: Give find_block_job() an Error ** parameter > blockdev: Eliminate silly QERR_BLOCK_JOB_NOT_ACTIVE macro > block: New bdrv_add_key(), convert monitor to use it > block: Eliminate silly QERR_ macros used for

Re: [Qemu-devel] [PATCH] tcg: Add doxygen documentation to the tcg frontend

2015-01-14 Thread Lluís Vilanova
Bastian Koppelmann writes: > There is no overview, that shows all the frontend operation one can use, as > found on the wiki. Unfortunatly the wiki is out of date, so let's try to move > this documentation to the source files, which has the benefit, that it is easy > to update the documentation, i

Re: [Qemu-devel] cpu hotplug and windows guest (win2012r2)

2015-01-14 Thread Andrey Korolyov
On Fri, Jan 9, 2015 at 4:35 PM, Andrey Korolyov wrote: > On Fri, Jan 9, 2015 at 1:26 PM, Alexandre DERUMIER > wrote: >> Hi, >> >> I'm currently testing cpu hotplug with a windows 2012R2 standard guest, >> >> and I can't get it too work. (works fine with linux guest). >> >> host kernel : rhel7 3.

Re: [Qemu-devel] [PATCH v2 00/12] block/dmg: (compatibility) fixes and bzip2 support

2015-01-14 Thread Stefan Hajnoczi
On Tue, Jan 06, 2015 at 06:48:03PM +0100, Peter Wu wrote: > Hi, > > This is the second revision of improvements to DMG image file support. > See [1] for an overview of the previous patchset. > > Thanks to John Snow for his efforts in reviewing patches and providing > suggestions. The errp suggest

Re: [Qemu-devel] [PATCH v2 01/12] block/dmg: properly detect the UDIF trailer

2015-01-14 Thread Stefan Hajnoczi
On Wed, Jan 07, 2015 at 03:19:13PM +0100, Peter Wu wrote: > On Wednesday 07 January 2015 13:19:34 Stefan Hajnoczi wrote: > > On Tue, Jan 06, 2015 at 06:48:04PM +0100, Peter Wu wrote: > > > DMG files have a variable length with a UDIF trailer at the end of a > > > file. This UDIF trailer is essentia

Re: [Qemu-devel] [PATCH 17/19] block/parallels: delay writing to BAT till bdrv_co_flush_to_os

2015-01-14 Thread Denis V. Lunev
On 14/01/15 17:29, Denis V. Lunev wrote: On 14/01/15 16:34, Roman Kagan wrote: On Wed, Jan 14, 2015 at 04:08:50PM +0300, Denis V. Lunev wrote: On 14/01/15 16:03, Roman Kagan wrote: On Tue, Dec 30, 2014 at 01:07:10PM +0300, Denis V. Lunev wrote: +static int cache_bat(BlockDriverState *bs, uint3

Re: [Qemu-devel] [PATCH 6/9] block-migration: tiny refactoring

2015-01-14 Thread John Snow
On 01/14/2015 07:26 AM, Vladimir Sementsov-Ogievskiy wrote: On 09.01.2015 00:23, John Snow wrote: On 12/11/2014 09:17 AM, Vladimir Sementsov-Ogievskiy wrote: Add blk_create and blk_free to remove code duplicates. Otherwise, duplicates will rise in the following patches because of BlkMigBloc

Re: [Qemu-devel] [PATCH] tcg: Add doxygen documentation to the tcg frontend

2015-01-14 Thread Thomas Huth
On Wed, 14 Jan 2015 16:36:26 +0100 Lluís Vilanova wrote: ... > > Also, AFAIR it was decided to use gtk-doc instead of doxygen. If there's a consensus about which source code documentation style should be used for QEMU, could you (or somebody else) maybe add an appropriate paragraph to the CODING

Re: [Qemu-devel] [PATCH] s390x/pci: fix 2 bugs found by coverity

2015-01-14 Thread Thomas Huth
On Wed, 14 Jan 2015 16:20:47 +0100 Frank Blaschka wrote: > Signed-off-by: Frank Blaschka > --- > hw/s390x/s390-pci-bus.c | 1 + > hw/s390x/s390-pci-inst.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c > index 1201b

Re: [Qemu-devel] [PATCH v6] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so that it reports the correct length of a real CD

2015-01-14 Thread Peter Maydell
On 13 January 2015 at 20:07, Programmingkid wrote: > Allows QEMU on Mac OS X to use a real cdrom again. > > Signed-off-by: John Arbuckle > > --- > Added fallback code - uses lseek() if ioctl() fails. > > block/raw-posix.c | 25 - > 1 files changed, 24 insertions(+), 1 d

Re: [Qemu-devel] [PATCH v2] Makes -full-screen option work on Mac OS X

2015-01-14 Thread Peter Maydell
On 12 January 2015 at 16:46, Programmingkid wrote: > This patch makes the -full-screen option actually instruct QEMU to enter > fullscreen at startup. > > Signed-off-by: John Arbuckle > > --- > Removed the set_to_full_screen variable. > Removed the scanForFullScreenOption() function. > > ui/co

Re: [Qemu-devel] [PATCH] Fixes several full screen issues on Mac OS X

2015-01-14 Thread Peter Maydell
On 4 January 2015 at 23:44, Programmingkid wrote: > This patch makes several changes: > - Fixes issue of returning to window mode and QEMU not setting > the right graphic settings if there was a change during full screen mode. > - Eliminated distorted full screen display. > - Makes full screen mo

Re: [Qemu-devel] [PATCH 18/19] block/parallels: add prealloc-mode and prealloc-size open paramemets

2015-01-14 Thread Roman Kagan
On Wed, Jan 14, 2015 at 05:31:20PM +0300, Denis V. Lunev wrote: > On 14/01/15 17:26, Roman Kagan wrote: > >On Tue, Dec 30, 2014 at 01:07:11PM +0300, Denis V. Lunev wrote: > >>This is preparational commit for tweaks in Parallels image expansion. > >>The idea is that enlarge via truncate by one data

Re: [Qemu-devel] [PATCH] pseries: Limit PCI host bridge "index" value

2015-01-14 Thread Michael Roth
Quoting David Gibson (2015-01-13 20:33:39) > pseries guests can have large numbers of PCI host bridges. To avoid the > user having to specify a number of different configuration values for every > one, the device supports an "index" property which is a shorthand setting > the various window and co

  1   2   >