Re: [Qemu-devel] [PATCH v3 1/3] qmp: Add command 'blockdev-backup'

2014-12-19 Thread Markus Armbruster
Fam Zheng writes: > On Wed, 12/17 10:36, Markus Armbruster wrote: >> Fam Zheng writes: >> >> > Similar to drive-backup, but this command uses a device id as target >> > instead of creating/opening an image file. >> > >> > Also add blocker on target bs, since the target is also a named device >>

Re: [Qemu-devel] [PATCH v4 1/3] qmp: Add command 'blockdev-backup'

2014-12-19 Thread Markus Armbruster
Max Reitz writes: > On 2014-12-04 at 03:29, Fam Zheng wrote: >> Similar to drive-backup, but this command uses a device id as target >> instead of creating/opening an image file. >> >> Also add blocker on target bs, since the target is also a named device >> now. >> >> Add check and report error

Re: [Qemu-devel] [PATCH v6 0/4] qmp: Add "blockdev-backup"

2014-12-19 Thread Markus Armbruster
Fam Zheng writes: > v6: Add Eric's rev-by in 1/4. > Address minor comments in 2/4, 3/4. > Add John's rev-by in 3/4. > > v5: Address Max's and Markus' comments: > Split patch 1. (Markus) > Fix typos and pastos. (Markus, Max) > Actually acquire aio context. (Max) > Drop unne

[Qemu-devel] [PULL 02/10] vnc: remove unused DisplayState parameter, add id instead.

2014-12-19 Thread Gerd Hoffmann
DisplayState isn't used anywhere, drop it. Add the vnc server ID as parameter instead, so it is possible to specify the server instance. Signed-off-by: Gerd Hoffmann Reviewed-by: Gonglei --- include/ui/console.h | 16 ui/vnc.c | 29 ++--- vl

[Qemu-devel] [PULL 09/10] monitor: add query-vnc2 command

2014-12-19 Thread Gerd Hoffmann
Add new query vnc qmp command, for the lack of better ideas just name it "query-vnc2". Changes over query-vnc: * It returns a list of vnc servers, so multiple vnc server instances are covered. * Each vnc server returns a list of server sockets. Followup patch will use that to also report

[Qemu-devel] [PULL 00/10] vnc: add support for multiple vnc displays

2014-12-19 Thread Gerd Hoffmann
lease pull, Gerd The following changes since commit dfa9c2a0f4d0a0c8b2c1449ecdbb1297427e1560: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2014-12-15 16:43:42 +) are available in the git repository at: git://git.kraxel.org/qemu tags/pull

[Qemu-devel] [PULL 10/10] monitor: add vnc websockets

2014-12-19 Thread Gerd Hoffmann
Add websockets bool to VncBasicInfo, report websocket server sockets, flag websocket client connections. Signed-off-by: Gerd Hoffmann --- qapi-schema.json | 5 - ui/vnc.c | 15 --- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/qapi-schema.json b/qapi-sc

[Qemu-devel] [PULL 01/10] vnc: remove vnc_display global

2014-12-19 Thread Gerd Hoffmann
Replace with a vnc_displays list, so we can have multiple vnc server instances. Add vnc_server_find function to lookup a display by id. With no id supplied return the first vnc server, for backward compatibility reasons. It is not possible (yet) to actually create multiple vnc server instances.

[Qemu-devel] [PULL 06/10] vnc: update docs/multiseat.txt

2014-12-19 Thread Gerd Hoffmann
vnc joins the party ;) Also some s/head/seat/ to clarify. Signed-off-by: Gerd Hoffmann --- docs/multiseat.txt | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/docs/multiseat.txt b/docs/multiseat.txt index 67151e0..b963665 100644 --- a/docs/multiseat.txt +++

[Qemu-devel] [PULL 03/10] vnc: add display id to acl names

2014-12-19 Thread Gerd Hoffmann
In case the display id is "default" (which is the one you get if you don't explicitly assign one) we keep the old name scheme, without display, for backward compatibility reasons. Signed-off-by: Gerd Hoffmann Reviewed-by: Gonglei --- ui/vnc.c | 22 -- 1 file changed, 20 inse

[Qemu-devel] [PULL 04/10] vnc: switch to QemuOpts, allow multiple servers

2014-12-19 Thread Gerd Hoffmann
This patch switches vnc over to QemuOpts, and it (more or less as side effect) allows multiple vnc server instances. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 4 +- qmp.c| 15 ++- ui/vnc.c | 270 --- vl.

[Qemu-devel] [PULL 05/10] vnc: allow binding servers to qemu consoles

2014-12-19 Thread Gerd Hoffmann
This patch adds a display= parameter to the vnc options. This allows to bind a vnc server instance to a specific display, allowing to create a multiseat setup with a vnc server for each seat. Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 50 +++--- 1 fi

[Qemu-devel] [PULL 07/10] vnc: track & limit connections

2014-12-19 Thread Gerd Hoffmann
Also track the number of connections in "connecting" and "shared" state (in addition to the "exclusive" state). Apply a configurable limit to these connections. The logic to apply the limit to connections in "shared" state is pretty simple: When the limit is reached no new connections are allowe

[Qemu-devel] [PULL 08/10] vnc: factor out qmp_query_client_list

2014-12-19 Thread Gerd Hoffmann
so we can reuse it for the new vnc query command. Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 2ed16dc..d7c7865 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -385,6 +385,20 @@ st

Re: [Qemu-devel] [PATCH V3] net: don't use set/get_pointer() in set/get_netdev()

2014-12-19 Thread Markus Armbruster
This one fell through the cracks, sorry. Jason Wang writes: > Commit 1ceef9f27359cbe92ef124bf74de6f792e71f6fb (net: multiqueue > support) tries to use set_pointer() and get_pointer() to set and get > NICPeers which is not a pointer defined in DEFINE_PROP_NETDEV. This > trick works but result a u

[Qemu-devel] [PULL 06/12] sdl2: overhaul window size handling

2014-12-19 Thread Gerd Hoffmann
Split do_sdl_resize function (which does alot more than just resizing) into three: sdl2_window_{create,destroy,resize}. Fix SDL_Renderer handling: must be guest display size not host window size, and SDL2 will magically handle all scaling for us. Make fullscreen actually enter fullscreen mode and

[Qemu-devel] [PULL 02/12] sdl2: rename sdl2_state to sdl2_console, move to header file

2014-12-19 Thread Gerd Hoffmann
Create sdl2.h header file, in preparation for sdl2 code splitup. Populate it with sdl2_console struct (renamed from sdl2_state). Signed-off-by: Gerd Hoffmann Reviewed-by: Max Reitz --- include/ui/sdl2.h | 16 ++ ui/sdl2.c | 63

[Qemu-devel] [PULL 00/12] sdl2: fixes, cleanups and opengl preparation.

2014-12-19 Thread Gerd Hoffmann
#x27; into staging (2014-12-15 16:43:42 +) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-sdl-20141219-1 for you to fetch changes up to d3f3a0f453ea590be529079ae214c200bb5ecc1a: sdl2: Work around SDL2 SDL_ShowWindow() bug (2014-12-17 12:4

[Qemu-devel] [PULL 03/12] sdl2: move keyboard input code to new sdl2-input.c

2014-12-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Max Reitz --- include/ui/sdl2.h | 4 +++ ui/Makefile.objs | 2 +- ui/sdl2-input.c | 106 ++ ui/sdl2.c | 75 ++ 4 files changed, 114 insertions(+), 73

[Qemu-devel] [PULL 10/12] sdl2: move sdl2_2d_refresh to sdl2-2d.c

2014-12-19 Thread Gerd Hoffmann
Now that common event handling code is split off, we can move over sdl_refresh to sdl2-2d.c, and rename it to sdl2_2d_refresh. Signed-off-by: Gerd Hoffmann Reviewed-by: Max Reitz --- include/ui/sdl2.h | 1 + ui/sdl2-2d.c | 8 ui/sdl2.c | 10 +- 3 files changed, 1

[Qemu-devel] [PULL 07/12] sdl2: move sdl_switch to sdl2-2d.c

2014-12-19 Thread Gerd Hoffmann
Move sdl_switch to sdl2-2d.c file, rename to sdl2_2d_switch. Signed-off-by: Gerd Hoffmann Reviewed-by: Max Reitz --- include/ui/sdl2.h | 6 ++ ui/sdl2-2d.c | 42 ++ ui/sdl2.c | 50 -- 3 fil

[Qemu-devel] [PULL 11/12] sdl2: Use correct sdl2_console for window events

2014-12-19 Thread Gerd Hoffmann
From: Max Reitz SDL_PollEvent() polls events for all windows; therefore, sdl2_poll_events() will poll the events for all windows and not only for the one identified by the given sdl2_console. This should be considered in handle_windowevent(): The window affected by the event is not necessarily t

[Qemu-devel] [PULL 09/12] sdl2: factor out sdl2_poll_events

2014-12-19 Thread Gerd Hoffmann
Create a new function to poll and handle sdl2 events, which is then just called from the refresh timer. Signed-off-by: Gerd Hoffmann Reviewed-by: Max Reitz --- include/ui/sdl2.h | 1 + ui/sdl2.c | 23 +-- 2 files changed, 14 insertions(+), 10 deletions(-) diff --gi

[Qemu-devel] [PULL 08/12] sdl2: add+use sdl2_2d_redraw function.

2014-12-19 Thread Gerd Hoffmann
Add a new sdl2_2d_redraw function for a complete screen refresh, so we can stop using graphic_hw_invalidate for that. There is no need to bother console / gfx emulation code if we are just going to re-blit the screen after window resizes. Signed-off-by: Gerd Hoffmann Reviewed-by: Max Reitz ---

[Qemu-devel] [PULL 12/12] sdl2: Work around SDL2 SDL_ShowWindow() bug

2014-12-19 Thread Gerd Hoffmann
From: Max Reitz Apparently it is possible for X to send an event to a hidden SDL2 window, leading to SDL2 believing it is now shown. SDL2 will pass the SDL_WINDOWEVENT_SHOWN message to the application without actually showing the window; the problem is that the next SDL_ShowWindow() will be a no-

[Qemu-devel] [PULL 05/12] sdl2: move sdl_update to new sdl2-2d.c

2014-12-19 Thread Gerd Hoffmann
Create new sdl2-2d file for 2d display rendering. Move over sdl_update code, and rename to sdl2_2d_update. Signed-off-by: Gerd Hoffmann Reviewed-by: Max Reitz --- include/ui/sdl2.h | 3 +++ ui/Makefile.objs | 2 +- ui/sdl2-2d.c | 61 ++

[Qemu-devel] [PULL 04/12] sdl2: turn on keyboard grabs

2014-12-19 Thread Gerd Hoffmann
Makes quite some keys actually go to the guest instead of being captured by the host window manager. Signed-off-by: Gerd Hoffmann Reviewed-by: Max Reitz --- ui/sdl2.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index b8d592f..9b66017 100644 -

[Qemu-devel] [PULL 01/12] sdl: move version logic from source code to makefile

2014-12-19 Thread Gerd Hoffmann
Compile sdl.c / sdl2.c depending on CONFIG_SDLABI instead of compiling both and have version #ifdefs in the source code. Signed-off-by: Gerd Hoffmann Reviewed-by: Max Reitz --- ui/Makefile.objs | 7 ++- ui/sdl.c | 3 --- ui/sdl2.c| 3 --- 3 files changed, 6 insertions(+), 7

Re: [Qemu-devel] [PATCH V2 3/8] pc: acpi-build: cleanup AcpiPmInfo initialization

2014-12-19 Thread Claudio Fontana
On 16.12.2014 11:58, Igor Mammedov wrote: > zero initialize AcpiPmInfo struct to reduce code bloat > a little bit. > > Signed-off-by: Igor Mammedov > --- > hw/i386/acpi-build.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-b

Re: [Qemu-devel] [PATCH 02/14] block: Add blk_new_open()

2014-12-19 Thread Max Reitz
On 2014-12-18 at 16:19, Kevin Wolf wrote: Am 11.12.2014 um 14:20 hat Max Reitz geschrieben: blk_new_with_bs() creates a BlockBackend with an empty BlockDriverState attached to it. Empty BDSs are not nice, therefore add an alternative function which combines blk_new_with_bs() with bdrv_open(). N

Re: [Qemu-devel] [PATCH V2 4/8] acpi: build_append_nameseg(): add padding if necessary

2014-12-19 Thread Claudio Fontana
On 16.12.2014 11:58, Igor Mammedov wrote: > According to ACPI spec NameSeg shorter than 4 characters > must be padded up to 4 characters with "_" symbol. > ACPI 5.0: 20.2.2 "Name Objects Encoding" > > Do it in build_append_nameseg() so that caller shouldn't know > or care about it. > > Signed-of

Re: [Qemu-devel] [PATCH V2 5/8] acpi: move generic aml building helpers into dedictated file

2014-12-19 Thread Claudio Fontana
On 16.12.2014 11:58, Igor Mammedov wrote: > the will be later used for composing AML primitives > and all that could be reused later for ARM machines > as well. > > Signed-off-by: Igor Mammedov > --- > hw/acpi/Makefile.objs| 1 + > hw/acpi/acpi_gen_utils.c | 166 >

Re: [Qemu-devel] [PATCH v5 00/11] fw_cfg, bootorder, and UEFI+'-kernel' on arm/virt

2014-12-19 Thread Gerd Hoffmann
Hi, Attached is a patch drafting a dma interface for fw_cfg, lousily based on the ideas I've outlined a few days ago on this list. Applies on top of this patch series. Host side only, unfinished, untested. Mainly sending this out as notification that I've looked into this, to avoid duplicatin

Re: [Qemu-devel] [PATCH V2 5/8] acpi: move generic aml building helpers into dedictated file

2014-12-19 Thread Igor Mammedov
On Fri, 19 Dec 2014 10:31:18 +0100 Claudio Fontana wrote: > On 16.12.2014 11:58, Igor Mammedov wrote: > > the will be later used for composing AML primitives > > and all that could be reused later for ARM machines > > as well. > > > > Signed-off-by: Igor Mammedov > > --- > > hw/acpi/Makefile.o

Re: [Qemu-devel] [PATCH 0/2] tcg: Move TCG arch-specific initialization inside TCG code

2014-12-19 Thread Andreas Färber
Am 19.12.2014 um 05:26 schrieb Eduardo Habkost: > Many architectures manually call arch-specific TCG initialization at CPU init > time[1], instead of having tcg_init() doing all initialization steps. This > series introduces a tcg_arch_init() function that may be implemented by > architecture-speci

Re: [Qemu-devel] [PATCH v6 0/4] qmp: Add "blockdev-backup"

2014-12-19 Thread Max Reitz
On 2014-12-18 at 11:37, Fam Zheng wrote: v6: Add Eric's rev-by in 1/4. Address minor comments in 2/4, 3/4. Add John's rev-by in 3/4. v5: Address Max's and Markus' comments: Split patch 1. (Markus) Fix typos and pastos. (Markus, Max) Actually acquire aio context. (Max)

Re: [Qemu-devel] [PATCH v5 00/11] fw_cfg, bootorder, and UEFI+'-kernel' on arm/virt

2014-12-19 Thread Alexander Graf
On 19.12.14 10:39, Gerd Hoffmann wrote: > Hi, > > Attached is a patch drafting a dma interface for fw_cfg, lousily based > on the ideas I've outlined a few days ago on this list. Applies on top > of this patch series. > > Host side only, unfinished, untested. Mainly sending this out as > no

Re: [Qemu-devel] [PATCH V2 6/8] acpi: add build_append_namestring() helper

2014-12-19 Thread Claudio Fontana
On 16.12.2014 11:58, Igor Mammedov wrote: > Use build_append_namestring() instead of build_append_nameseg() > So user won't have to care whether name is NameSeg, NamePath or > NameString. > > See for refernce ACPI 5.0: 20.2.2 Name Objects Encoding > > Signed-off-by: Igor Mammedov > --- > hw/acp

Re: [Qemu-devel] [PATCH 1/5] pseries: Move sPAPR RTC code into its own file

2014-12-19 Thread Alexander Graf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 19.12.14 06:39, David Gibson wrote: > On Fri, Dec 19, 2014 at 12:36:11AM +0100, Alexander Graf wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> >> >> >> On 18.12.14 06:43, David Gibson wrote: >>> On Tue, Dec 16, 2014 at 10:41:16AM +01

Re: [Qemu-devel] [PATCHv3 0/2] Fix virtio-serial migration on bi-endian targets

2014-12-19 Thread Alexander Graf
On 19.12.14 04:57, David Gibson wrote: > On a bi-endian target, with a guest in the non-default endian mode, > attempting to migrate twice in a row with a virtio-serial device wil > cause a qemu SEGV on the second outgoing migration. > > The problem is that virtio_serial_save_device() (and other

Re: [Qemu-devel] [PATCH V2 6/8] acpi: add build_append_namestring() helper

2014-12-19 Thread Igor Mammedov
On Fri, 19 Dec 2014 10:53:03 +0100 Claudio Fontana wrote: > On 16.12.2014 11:58, Igor Mammedov wrote: > > Use build_append_namestring() instead of build_append_nameseg() > > So user won't have to care whether name is NameSeg, NamePath or > > NameString. > > > > See for refernce ACPI 5.0: 20.2.2

Re: [Qemu-devel] [PATCHv3 0/2] Fix virtio-serial migration on bi-endian targets

2014-12-19 Thread Alexander Graf
On 19.12.14 04:57, David Gibson wrote: > On a bi-endian target, with a guest in the non-default endian mode, > attempting to migrate twice in a row with a virtio-serial device wil > cause a qemu SEGV on the second outgoing migration. > > The problem is that virtio_serial_save_device() (and other

Re: [Qemu-devel] [PATCH 0/2] tcg: Move TCG arch-specific initialization inside TCG code

2014-12-19 Thread Paolo Bonzini
On 19/12/2014 10:47, Andreas Färber wrote: > How do you imagine this to work with multiple CPU types? From the looks > of it, this is for the target CPU, not the TCG architecture, so > tcg_arch_init() limits us to one implementation unlike now. > On the other hand it doesn't seem to be a per-CPU,

Re: [Qemu-devel] [PATCH 9/9] target-ppc: Introduce Privileged TM Noops

2014-12-19 Thread Fam Zheng
On Thu, 12/18 10:34, Tom Musta wrote: > Add the supervisory Transactional Memory instructions treclaim. and > trechkpt. The implementation is a degenerate one that simply > checks privileged state, TM availability and then sets CR[0] to > 0b, just like the unprivileged noops. And also s-o-b f

Re: [Qemu-devel] [Qemu-ppc] Unable to loadvm on qemu-system-ppc -M g3beige (keyboard freeze)

2014-12-19 Thread Mark Cave-Ayland
On 18/12/14 23:01, Alexander Graf wrote: > On 18.12.14 22:36, Mark Cave-Ayland wrote: >> On 18/12/14 15:13, Peter Maydell wrote: >> >>> On 18 December 2014 at 14:46, Alexander Graf wrote: On 18.12.14 14:54, Mark Cave-Ayland wrote: > So it looks like several of the device MemoryRegions ar

[Qemu-devel] broken backward migration due to commit 461a275 "parallel: adding vmstate for save/restore"

2014-12-19 Thread Igor Mammedov
steps to reproduce: Current master source: qemu-system-x86_64 -monitor stdio -M pc-i440fx-2.1 (qemu) stop (qemu) migrate "exec:gzip -c > STATEFILE.gz" Target: qemu-system-x86_64-2.1 -monitor stdio -M pc-i440fx-2.1 -incoming "exec: gzip -c -d STATEFILE.gz"

Re: [Qemu-devel] broken backward migration due to commit 461a275 "parallel: adding vmstate for save/restore"

2014-12-19 Thread Paolo Bonzini
On 19/12/2014 12:03, Igor Mammedov wrote: > steps to reproduce: > > Current master source: > qemu-system-x86_64 -monitor stdio -M pc-i440fx-2.1 > (qemu) stop > (qemu) migrate "exec:gzip -c > STATEFILE.gz" > > Target: > qemu-system-x86_64-2.1 -monitor stdio -M pc-i440fx-2.1 -incoming "exec: >

Re: [Qemu-devel] [PATCH 5/8] target-i386: Set APIC ID using cpu_index on CONFIG_USER

2014-12-19 Thread Paolo Bonzini
On 19/12/2014 03:41, Eduardo Habkost wrote: > +object_property_set_int(OBJECT(cpu), CPU(cpu)->cpu_index, "apic-id", > +&error); > +if (error) { > +goto out; > +} > + Should this use &error_abort? Paolo

Re: [Qemu-devel] [PATCH 4/8] target-i386: Keep track of apic-id setting

2014-12-19 Thread Paolo Bonzini
On 19/12/2014 03:41, Eduardo Habkost wrote: > Set a flag indicating that the apic-id property was set, so we can later > ensure we won't try to realize a X86CPU object before apic-id was set. > > Signed-off-by: Eduardo Habkost > Cc: Gu Zheng > --- > target-i386/cpu-qom.h | 1 + > target-i386/

Re: [Qemu-devel] [PATCH 7/8] target-i386: Move topology.h to hw/i386/topology.h

2014-12-19 Thread Paolo Bonzini
On 19/12/2014 03:41, Eduardo Habkost wrote: > This will allow the PC code to use the header, and lets us eliminate the > QEMU_INCLUDES hack inside tests/Makefile. > > Signed-off-by: Eduardo Habkost Please use include/hw/i386/topology.h (the toplevel build and source directories should not be p

Re: [Qemu-devel] [PATCH V3] net: don't use set/get_pointer() in set/get_netdev()

2014-12-19 Thread Stefan Hajnoczi
On Mon, Oct 13, 2014 at 01:16:37PM +0800, Jason Wang wrote: > Commit 1ceef9f27359cbe92ef124bf74de6f792e71f6fb (net: multiqueue > support) tries to use set_pointer() and get_pointer() to set and get > NICPeers which is not a pointer defined in DEFINE_PROP_NETDEV. This > trick works but result a uncl

Re: [Qemu-devel] broken backward migration due to commit 461a275 "parallel: adding vmstate for save/restore"

2014-12-19 Thread Igor Mammedov
On Fri, 19 Dec 2014 12:15:20 +0100 Paolo Bonzini wrote: > > > On 19/12/2014 12:03, Igor Mammedov wrote: > > steps to reproduce: > > > > Current master source: > > qemu-system-x86_64 -monitor stdio -M pc-i440fx-2.1 > > (qemu) stop > > (qemu) migrate "exec:gzip -c > STATEFILE.gz" > > > > Target

[Qemu-devel] [PATCH v3] target-tricore: pretty-print register dump and show more status registers

2014-12-19 Thread Alex Zuepke
Now using psw_read() to retrieve the status bits correctly. Signed-off-by: Alex Zuepke --- target-tricore/translate.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index e3eeedb..3d87346 100644

Re: [Qemu-devel] broken backward migration due to commit 461a275 "parallel: adding vmstate for save/restore"

2014-12-19 Thread Igor Mammedov
On Fri, 19 Dec 2014 12:32:52 +0100 Igor Mammedov wrote: > On Fri, 19 Dec 2014 12:15:20 +0100 > Paolo Bonzini wrote: > > > > > > > On 19/12/2014 12:03, Igor Mammedov wrote: > > > steps to reproduce: > > > > > > Current master source: > > > qemu-system-x86_64 -monitor stdio -M pc-i440fx-2.1 >

Re: [Qemu-devel] [PATCH] block-migration: fix pending() return value

2014-12-19 Thread Vladimir Sementsov-Ogievskiy
Hi there.. Can someone review my bug fix? I'll surely fix typos in description after it. Best regards, Vladimir On 11.12.2014 18:07, Eric Blake wrote: On 12/11/2014 04:55 AM, Vladimir Sementsov-Ogievskiy wrote: Because of wrong return value of .save_live_pending() in block-migration, migratio

[Qemu-devel] [PATCH v3 2/8] pc: acpi: decribe bridge device as not hotpluggable

2014-12-19 Thread Igor Mammedov
when bridge hotplug is disabled, i.e. for machine types less then 2.0, bridge device was created as hotpluggable by mistake since commit 133a2da (2.1). Fix it by just creating it as a present device as it was done in 1.7. Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 2 +- 1 file chang

[Qemu-devel] [PATCH v3 5/8] acpi: move generic aml building helpers into dedictated file

2014-12-19 Thread Igor Mammedov
the will be later used for composing AML primitives and all that could be reused later for ARM machines as well. Signed-off-by: Igor Mammedov --- v2: fix wrong ident in moved code --- hw/acpi/Makefile.objs| 1 + hw/acpi/acpi_gen_utils.c | 166 +

[Qemu-devel] [PATCH v3 0/8] pc: acpi: various fixes and cleanups

2014-12-19 Thread Igor Mammedov
changes from v2: * codding style fixups * check for SegCount earlier * use hotpluggable device object instead of not hotpluggable for non present devices, and add it only when bus itself is hotpluggable changes from v1: * drop: [PATCH 7/9] acpi: replace opencoded notify codes with name

[Qemu-devel] [PATCH v3 3/8] pc: acpi-build: cleanup AcpiPmInfo initialization

2014-12-19 Thread Igor Mammedov
zero initialize AcpiPmInfo struct to reduce code bloat a little bit. Signed-off-by: Igor Mammedov Reviewed-by: Claudio Fontana --- hw/i386/acpi-build.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index c151fde..0351363

[Qemu-devel] [PATCH v3 1/8] pc: acpi: fix WindowsXP BSOD when memory hotplug is enabled

2014-12-19 Thread Igor Mammedov
ACPI parser in XP considers PNP0A06 devices of CPU and memory hotplug as duplicates. Adding unique _UID to CPU hotplug device fixes BSOD. Signed-off-by: Igor Mammedov --- hw/i386/acpi-dsdt-cpu-hotplug.dsl | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/acpi-dsdt-cpu-hotplug.dsl b/hw

[Qemu-devel] [PATCH v3 6/8] acpi: add build_append_namestring() helper

2014-12-19 Thread Igor Mammedov
Use build_append_namestring() instead of build_append_nameseg() So user won't have to care whether name is NameSeg, NamePath or NameString. See for refernce ACPI 5.0: 20.2.2 Name Objects Encoding Signed-off-by: Igor Mammedov --- v2: assert on wrong Segcount earlier and extend condition to seg

[Qemu-devel] [PATCH v3 4/8] acpi: build_append_nameseg(): add padding if necessary

2014-12-19 Thread Igor Mammedov
According to ACPI spec NameSeg shorter than 4 characters must be padded up to 4 characters with "_" symbol. ACPI 5.0: 20.2.2 "Name Objects Encoding" Do it in build_append_nameseg() so that caller shouldn't know or care about it. Signed-off-by: Igor Mammedov Reviewed-by: Claudio Fontana --- v2:

[Qemu-devel] [PATCH v3 7/8] acpi: drop min-bytes in build_package()

2014-12-19 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/acpi_gen_utils.c | 14 -- hw/i386/acpi-build.c | 13 ++--- include/hw/acpi/acpi_gen_utils.h | 4 ++-- 3 files changed, 12 insertions(+), 19 deletions(-) diff --git a/hw/acpi/acpi_gen_utils.c b/hw/acpi/acpi_gen_util

[Qemu-devel] [PATCH v3 8/8] pc: acpi-build: simplify PCI bus tree generation

2014-12-19 Thread Igor Mammedov
it basicaly does the same as original approach, * just without bus/notify tables tracking (less obscure) which is easier to follow. * drops unnecessary loops and bitmaps, creating devices and notification method in the same loop. * saves us ~100LOC change in behavior: * generate hotpluggable d

[Qemu-devel] [PATCH 2/2] exec: change default exception_index value for migration to -1

2014-12-19 Thread Paolo Bonzini
In QEMU 2.2 the exception_index value was added to the migration stream through a subsection. The default was set to 0, which is wrong and should have been -1. However, 2.2 does not have commit e511b4d (cpu-exec: reset exception_index correctly, 2014-11-26), hence in 2.2 the exception_index is ne

[Qemu-devel] [PATCH 0/2] cpu->exception_index fixes

2014-12-19 Thread Paolo Bonzini
Two fixes for cpu->exception_index: - breakage of linux-user from commit e511b4d - wrong subsection definition in 2.2 (see patch 2) Paolo Paolo Bonzini (2): cpu: initialize cpu->exception_index on reset exec: change default exception_index value for migration to -1 cpus.c| 3 --- exec

[Qemu-devel] [PATCH 1/2] cpu: initialize cpu->exception_index on reset

2014-12-19 Thread Paolo Bonzini
This unbreaks linux-user (broken by e511b4d, cpu-exec: reset exception_index correctly, 2014-11-26). Reported-by: Eduardo Habkost Signed-off-by: Paolo Bonzini --- cpus.c| 3 --- qom/cpu.c | 1 + 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/cpus.c b/cpus.c index 1b5168a..2ed

Re: [Qemu-devel] broken backward migration due to commit 461a275 "parallel: adding vmstate for save/restore"

2014-12-19 Thread Paolo Bonzini
On 19/12/2014 12:32, Igor Mammedov wrote: > There is one more commit that breaks it, this time with subsection > 6c3bff0 "exec: Save CPUState::exception_index field" > > qemu: warning: error while loading state for instance 0x0 of device > 'cpu_common' > the same reproducer with -parallel none

Re: [Qemu-devel] Review of ways to create BDSes (was: Review of monitor commands identifying BDS / BB by name)

2014-12-19 Thread Kevin Wolf
Am 18.12.2014 um 16:25 hat Markus Armbruster geschrieben: > = Introduction = > > BDSes can be opened in various ways. Some of them don't provide for > user configuration. Some of them should. > > Example: -drive format=qcow2,file=foo.qcow2 where foo.qcow2 has a raw > backing file foo.raw. This

Re: [Qemu-devel] [PATCH 0/2] cpu->exception_index fixes

2014-12-19 Thread Laurent Desnogues
Hello, On Fri, Dec 19, 2014 at 12:53 PM, Paolo Bonzini wrote: > Two fixes for cpu->exception_index: > > - breakage of linux-user from commit e511b4d Tested-by: Laurent Desnogues Thanks, Laurent > - wrong subsection definition in 2.2 (see patch 2) > > Paolo > > Paolo Bonzini (2): > cpu: ini

Re: [Qemu-devel] [Qemu-ppc] Unable to loadvm on qemu-system-ppc -M g3beige (keyboard freeze)

2014-12-19 Thread Peter Maydell
On 19 December 2014 at 10:53, Mark Cave-Ayland wrote: > It seems that I've misunderstood something mentioned earlier in the > thread, i.e. that loadvm also does the create, initialize, realize and > reset cycle. At least issuing "loadvm" in the monitor doesn't seem to do > that as far as I can see

Re: [Qemu-devel] broken backward migration due to commit 461a275 "parallel: adding vmstate for save/restore"

2014-12-19 Thread Igor Mammedov
On Fri, 19 Dec 2014 13:02:24 +0100 Paolo Bonzini wrote: > > > On 19/12/2014 12:32, Igor Mammedov wrote: > > There is one more commit that breaks it, this time with subsection > > 6c3bff0 "exec: Save CPUState::exception_index field" > > > > qemu: warning: error while loading state for instance

Re: [Qemu-devel] broken backward migration due to commit 461a275 "parallel: adding vmstate for save/restore"

2014-12-19 Thread Igor Mammedov
On Fri, 19 Dec 2014 13:42:37 +0100 Igor Mammedov wrote: > On Fri, 19 Dec 2014 13:02:24 +0100 > Paolo Bonzini wrote: > > > > > > > On 19/12/2014 12:32, Igor Mammedov wrote: > > > There is one more commit that breaks it, this time with subsection > > > 6c3bff0 "exec: Save CPUState::exception_in

Re: [Qemu-devel] [PULL 00/10] vnc: add support for multiple vnc displays

2014-12-19 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > > Ok, here we go with the multiple vnc display patch series. > Compared to the v3 series two patch hunks have been moved > from patch #9 to patch #2. The final result after applying > all patches hasn't changed, so I think it's ok to go straight > for a pull req i

Re: [Qemu-devel] [PULL 0/4] vga: cirrus hwcursor fixes.

2014-12-19 Thread Peter Maydell
On 17 December 2014 at 14:42, Gerd Hoffmann wrote: > Hi, > > vga patches lingering way too long in my queue. > > Finally merging the cirrus hwcursor fixes (for NT4 guests!) > discussed months ago ... > > Also minor tweaks picked up during freeze. > > please pull, > Gerd > > The following chang

Re: [Qemu-devel] [PATCH 4/8] target-i386: Keep track of apic-id setting

2014-12-19 Thread Eduardo Habkost
On Fri, Dec 19, 2014 at 12:23:07PM +0100, Paolo Bonzini wrote: > On 19/12/2014 03:41, Eduardo Habkost wrote: > > Set a flag indicating that the apic-id property was set, so we can later > > ensure we won't try to realize a X86CPU object before apic-id was set. > > > > Signed-off-by: Eduardo Habkos

Re: [Qemu-devel] [PATCH 7/8] target-i386: Move topology.h to hw/i386/topology.h

2014-12-19 Thread Eduardo Habkost
On Fri, Dec 19, 2014 at 12:24:05PM +0100, Paolo Bonzini wrote: > > > On 19/12/2014 03:41, Eduardo Habkost wrote: > > This will allow the PC code to use the header, and lets us eliminate the > > QEMU_INCLUDES hack inside tests/Makefile. > > > > Signed-off-by: Eduardo Habkost > > Please use incl

Re: [Qemu-devel] [PULL 09/10] monitor: add query-vnc2 command

2014-12-19 Thread Markus Armbruster
Gerd Hoffmann writes: > Add new query vnc qmp command, for the lack of better ideas just name it > "query-vnc2". Changes over query-vnc: > > * It returns a list of vnc servers, so multiple vnc server instances >are covered. > * Each vnc server returns a list of server sockets. Followup pa

Re: [Qemu-devel] [PULL 10/10] monitor: add vnc websockets

2014-12-19 Thread Markus Armbruster
Copying Eric again, even though the QAPI schema change here is pretty trivial. Gerd Hoffmann writes: > Add websockets bool to VncBasicInfo, report websocket server sockets, > flag websocket client connections. > > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json | 5 - > ui/vnc.c

Re: [Qemu-devel] broken backward migration due to commit 461a275 "parallel: adding vmstate for save/restore"

2014-12-19 Thread Paolo Bonzini
On 19/12/2014 13:42, Igor Mammedov wrote: > On Fri, 19 Dec 2014 13:02:24 +0100 > Paolo Bonzini wrote: > >> >> >> On 19/12/2014 12:32, Igor Mammedov wrote: >>> There is one more commit that breaks it, this time with subsection >>> 6c3bff0 "exec: Save CPUState::exception_index field" >>> >>> qemu

Re: [Qemu-devel] [PATCH] net: Add persistent flag to -net tap option

2014-12-19 Thread Stefan Hajnoczi
On Mon, Dec 15, 2014 at 02:05:23PM +0200, Roy Vardi wrote: > From: Roy Vardi > > Add 'persistent' boolean flag to -net tap option. > When set to off - tap interface will be released on shutdown > When set to on\not specified - tap interface will remain > > Running with -net tap,p

Re: [Qemu-devel] [PATCH 0/2] net: Trivial cleanups around g_malloc()

2014-12-19 Thread Stefan Hajnoczi
On Thu, Dec 04, 2014 at 02:28:15PM +0100, Markus Armbruster wrote: > Markus Armbruster (2): > net: Fuse g_malloc(); memset() into g_new0() > net: Use g_new() & friends where that makes obvious sense > > net/l2tpv3.c | 9 - > net/queue.c | 2 +- > net/slirp.c | 2 +- > 3 files change

Re: [Qemu-devel] [PATCH 0/2] tcg: Move TCG arch-specific initialization inside TCG code

2014-12-19 Thread Eduardo Habkost
On Fri, Dec 19, 2014 at 11:29:34AM +0100, Paolo Bonzini wrote: > On 19/12/2014 10:47, Andreas Färber wrote: > > How do you imagine this to work with multiple CPU types? From the looks > > of it, this is for the target CPU, not the TCG architecture, so > > tcg_arch_init() limits us to one implementa

Re: [Qemu-devel] [PATCH v2] e1000: defer packets until BM enabled

2014-12-19 Thread Stefan Hajnoczi
On Mon, Dec 01, 2014 at 08:06:52PM +0200, Michael S. Tsirkin wrote: > Some guests seem to set BM for e1000 after > enabling RX. > If packets arrive in the window, device is wedged. > Probably works by luck on real hardware, work around > this by making can_receive depend on BM. > > Tested-by: Gabr

[Qemu-devel] [PULL 0/5] Net patches

2014-12-19 Thread Stefan Hajnoczi
The following changes since commit 86b182ac0e0b44726d85598cbefb468ed22517fc: Merge remote-tracking branch 'remotes/xtensa/tags/20141217-xtensa' into staging (2014-12-17 17:31:26 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/net-pull-request for you

[Qemu-devel] [PULL 2/5] net: don't use set/get_pointer() in set/get_netdev()

2014-12-19 Thread Stefan Hajnoczi
From: Jason Wang Commit 1ceef9f27359cbe92ef124bf74de6f792e71f6fb (net: multiqueue support) tries to use set_pointer() and get_pointer() to set and get NICPeers which is not a pointer defined in DEFINE_PROP_NETDEV. This trick works but result a unclean and fragile implementation (e.g print_netdev

[Qemu-devel] [PULL 3/5] net: Fuse g_malloc(); memset() into g_new0()

2014-12-19 Thread Stefan Hajnoczi
From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- net/l2tpv3.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/l2tpv3.c b/net/l2tpv3.c index 3b805a7..6014c43 100644 --- a/net/l2tpv3.c +++ b/net/l2tpv3.c @@ -695,8 +695,7 @@ int

Re: [Qemu-devel] [PATCH] net: Add persistent flag to -net tap option

2014-12-19 Thread Daniel P. Berrange
On Fri, Dec 19, 2014 at 01:13:50PM +, Stefan Hajnoczi wrote: > On Mon, Dec 15, 2014 at 02:05:23PM +0200, Roy Vardi wrote: > > From: Roy Vardi > > > > Add 'persistent' boolean flag to -net tap option. > > When set to off - tap interface will be released on shutdown > > When set to

[Qemu-devel] [PULL 4/5] net: Use g_new() & friends where that makes obvious sense

2014-12-19 Thread Stefan Hajnoczi
From: Markus Armbruster g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, for two reasons. One, it catches multiplication overflowing size_t. Two, it returns T * rather than void *, which lets the compiler catch more type errors. This commit only touches allocations with siz

Re: [Qemu-devel] broken backward migration due to commit 461a275 "parallel: adding vmstate for save/restore"

2014-12-19 Thread Paolo Bonzini
On 19/12/2014 13:49, Igor Mammedov wrote: >> source: >> qemu-system-x86_64 -monitor stdio -M pc-i440fx-1.7 -parallel none >> xpsp3x86.qcow2 >> >> switch to text screen where you could select Safe Mode and stop/migrate at >> this point > > one more issue if you continue normal boot and wait til

[Qemu-devel] [PULL 5/5] e1000: defer packets until BM enabled

2014-12-19 Thread Stefan Hajnoczi
From: "Michael S. Tsirkin" Some guests seem to set BM for e1000 after enabling RX. If packets arrive in the window, device is wedged. Probably works by luck on real hardware, work around this by making can_receive depend on BM. Tested-by: Gabriel Somlo Signed-off-by: Michael S. Tsirkin Reviewe

[Qemu-devel] [PULL 1/5] tap: fix vcpu long time io blocking on tap

2014-12-19 Thread Stefan Hajnoczi
From: "Wangkai (Kevin,C)" [Adjusted doc comment for grammar. --Stefan] Signed-off-by: Wangkai Signed-off-by: Stefan Hajnoczi --- net/tap.c | 12 1 file changed, 12 insertions(+) diff --git a/net/tap.c b/net/tap.c index bde6b58..1fe0edf 100644 --- a/net/tap.c +++ b/net/tap.c @@ -

[Qemu-devel] [PATCH] check return value of fcntl() to detect invalid fd

2014-12-19 Thread Amos Kong
Passing some invalid fds in QEMU commandline, the fds don't exist. QEMU will get error "TUNGETIFF ioctl() failed: Bad file descriptor", and coredump in setting queues. This patch checked return value of first operate to fd, QEMU will report error and exit without coredump. It's effected for both n

Re: [Qemu-devel] [PATCH v3 4/5] Split the QEMU buffered file code out

2014-12-19 Thread Eduardo Habkost
On Thu, Dec 18, 2014 at 09:24:11AM +, Dr. David Alan Gilbert wrote: > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > On Fri, Dec 12, 2014 at 11:13:41AM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > The splitting of qemu-file and addi

Re: [Qemu-devel] [PATCH v3 6/8] acpi: add build_append_namestring() helper

2014-12-19 Thread Claudio Fontana
On 19.12.2014 12:47, Igor Mammedov wrote: > Use build_append_namestring() instead of build_append_nameseg() > So user won't have to care whether name is NameSeg, NamePath or > NameString. > > See for refernce ACPI 5.0: 20.2.2 Name Objects Encoding > > Signed-off-by: Igor Mammedov > --- > v2: >

Re: [Qemu-devel] [PATCH 1/2] cpu: initialize cpu->exception_index on reset

2014-12-19 Thread Eduardo Habkost
On Fri, Dec 19, 2014 at 12:53:13PM +0100, Paolo Bonzini wrote: > This unbreaks linux-user (broken by e511b4d, cpu-exec: reset exception_index > correctly, 2014-11-26). > > Reported-by: Eduardo Habkost > Signed-off-by: Paolo Bonzini Fixes the problem. Thanks! Tested-by: Eduardo Habkost -- Ed

Re: [Qemu-devel] Review of ways to create BDSes

2014-12-19 Thread Markus Armbruster
Kevin Wolf writes: > Am 18.12.2014 um 16:25 hat Markus Armbruster geschrieben: >> = Introduction = >> >> BDSes can be opened in various ways. Some of them don't provide for >> user configuration. Some of them should. >> >> Example: -drive format=qcow2,file=foo.qcow2 where foo.qcow2 has a raw

Re: [Qemu-devel] [PATCH 1/2] tcg: Introduce tcg_arch_init() function

2014-12-19 Thread Richard Henderson
On 12/18/2014 10:26 PM, Eduardo Habkost wrote: > +void tcg_arch_init(void); I'm not keen on the name, because it's fairly ambiguous whether "arch" is talking about the host or target. It doesn't help that "tcg_target" is the host. ;-P Assuming we do this (see hook discussion), what about "trans

Re: [Qemu-devel] [Qemu-ppc] Unable to loadvm on qemu-system-ppc -M g3beige (keyboard freeze)

2014-12-19 Thread Mark Cave-Ayland
On 19/12/14 12:29, Peter Maydell wrote: > On 19 December 2014 at 10:53, Mark Cave-Ayland > wrote: >> It seems that I've misunderstood something mentioned earlier in the >> thread, i.e. that loadvm also does the create, initialize, realize and >> reset cycle. At least issuing "loadvm" in the monit

[Qemu-devel] Live migration bug, possible missing ram in migration?

2014-12-19 Thread Frerot , Jean-Sébastien
Hi, I've been using kvm for some time now using live migration as well with ceph backend. Recently I started running into an issue with only one of my VM, which happens to be a windows server (2012). When I migrate this particular VM it seems that not all the ram is transferred. So when the migrati

  1   2   >