On 2014-12-18 at 11:37, Fam Zheng wrote:
v6: Add Eric's rev-by in 1/4.
Address minor comments in 2/4, 3/4.
Add John's rev-by in 3/4.
v5: Address Max's and Markus' comments:
Split patch 1. (Markus)
Fix typos and pastos. (Markus, Max)
Actually acquire aio context. (Max)
Drop unnecessary initialization of fields in blockdev_backup_prepare. (Max)
Add "sync" in the document example.
Add Max's rev-by in patch 4.
The existing drive-backup command accepts a target file path, but that
interface provides little flexibility on the properties of target block device,
compared to what is possible with "blockdev-add", "drive_add" or "-drive".
This is also a building block to allow image fleecing (creating a point in time
snapshot and export with nbd-server-add).
(For symmetry, blockdev-mirror will be added in a separate series.)
Fam
Fam Zheng (4):
qapi: Comment version info in TransactionAction
qmp: Add command 'blockdev-backup'
block: Add blockdev-backup to transaction
qemu-iotests: Test blockdev-backup in 055
block/backup.c | 28 ++++++
blockdev.c | 133 ++++++++++++++++++++++++++++
qapi-schema.json | 8 ++
qapi/block-core.json | 54 ++++++++++++
qmp-commands.hx | 42 +++++++++
tests/qemu-iotests/055 | 211 +++++++++++++++++++++++++++++++++++++--------
tests/qemu-iotests/055.out | 4 +-
7 files changed, 441 insertions(+), 39 deletions(-)
(Trusting Markus to fix QERR_* and non-ERROR_CLASS_GENERIC_ERROR uses in
a follow-up)
Thanks, applied to my block tree:
https://github.com/XanClic/qemu/commits/block