Re: [Qemu-devel] [PATCH] seccomp: add mbind() to the syscall whitelist

2014-12-18 Thread Eduardo Otubo
On Wed, Dec 17, 2014 at 03:50:09PM -0500, Paul Moore wrote: > The "memory-backend-ram" QOM object utilizes the mbind(2) syscall to > set the policy for a memory range. Add the syscall to the seccomp > sandbox whitelist. > > Signed-off-by: Paul Moore > --- > qemu-seccomp.c |3 ++- > 1 file c

[Qemu-devel] [PATCH 0/3 V2] add PCI support for the s390 platform

2014-12-18 Thread Frank Blaschka
This set of patches implemets PCI support for the s390 platform. Now it is possible to run virtio-net-pci and potentially all virtual pci devices conforming to s390 platform constrains. V1 added lot of feedback from Alex Graf fixed tons of endian issues V2 added couple of small improvments and

[Qemu-devel] [PATCH 1/3 V2] s390: Add PCI bus support

2014-12-18 Thread Frank Blaschka
From: Frank Blaschka This patch implements a pci bus for s390x together with infrastructure to generate and handle hotplug events, to configure/unconfigure via sclp instruction, to do iommu translations and provide s390 support for MSI/MSI-X notification processing. Signed-off-by: Frank Blaschka

[Qemu-devel] [PATCH 2/3 V2] s390: implement pci instructions

2014-12-18 Thread Frank Blaschka
From: Frank Blaschka This patch implements the s390 pci instructions in qemu. It allows to access and drive pci devices attached to the s390 pci bus. Because of platform constrains devices using IO BARs are not supported. Also a device has to support MSI/MSI-X to run on s390. Signed-off-by: Fran

[Qemu-devel] [PATCH 3/3 V2] kvm: extend kvm_irqchip_add_msi_route to work on s390

2014-12-18 Thread Frank Blaschka
From: Frank Blaschka on s390 MSI-X irqs are presented as thin or adapter interrupts for this we have to reorganize the routing entry to contain valid information for the adapter interrupt code on s390. To minimize impact on existing code we introduce an architecture function to fixup the routing

Re: [Qemu-devel] [RFC PATCH] target-arm: protect cpu_exclusive_*.

2014-12-18 Thread Mark Burton
> On 17 Dec 2014, at 17:39, Peter Maydell wrote: > > On 17 December 2014 at 16:29, Mark Burton wrote: >>> On 17 Dec 2014, at 17:27, Peter Maydell wrote: >>> I think a mutex is fine, personally -- I just don't want >>> to see fifteen hand-hacked mutexes in the target-* code. >>> >> >> Which w

[Qemu-devel] [PATCH 2/2] e1000: unconditionally enable bus mastering

2014-12-18 Thread Amos Kong
After enabled network debug of e1000 in Win2012-64r2 guest, Bus mastering of e1000 can't be enabled by e1000 driver. It caused guest can't get IP address. # bcdedit /debug on # bcdedit /dbgsettings net hostip:192.168.122.100 port:5 (We can use non-existed IP here, it's just used to pass

[Qemu-devel] [PATCH 0/2] ignore bus master for e1000

2014-12-18 Thread Amos Kong
Win2012-64r2 guest doesn't set bus mastering correctly, it caused guest network down, this patch ignored it for e1000 nic for workarounding the guest issue. Patch 1 is an update version of: http://lists.gnu.org/archive/html/qemu-devel/2014-12/msg00048.html transmit packets are also defered in late

[Qemu-devel] [PATCH 1/2] e1000: defer packets until BM enabled

2014-12-18 Thread Amos Kong
From: "Michael S. Tsirkin" Some guests seem to set BM for e1000 after enabling RX. If packets arrive in the window, device is wedged. Probably works by luck on real hardware, work around this by making can_receive depend on BM. This patch defer transmit packets, only start transmit when BM is ena

Re: [Qemu-devel] [PATCH v3 4/5] Split the QEMU buffered file code out

2014-12-18 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Fri, Dec 12, 2014 at 11:13:41AM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > The splitting of qemu-file and addition of the buffered file landed > > at the same time; so now split the buffered file c

Re: [Qemu-devel] [PATCH 2/2] e1000: unconditionally enable bus mastering

2014-12-18 Thread Jason Wang
On Thu, Dec 18, 2014 at 5:22 PM, Amos Kong wrote: After enabled network debug of e1000 in Win2012-64r2 guest, Bus mastering of e1000 can't be enabled by e1000 driver. It caused guest can't get IP address. # bcdedit /debug on # bcdedit /dbgsettings net hostip:192.168.122.100 port:5 (

Re: [Qemu-devel] [PATCH 0/2] ignore bus master for e1000

2014-12-18 Thread Jason Wang
On Thu, Dec 18, 2014 at 5:22 PM, Amos Kong wrote: Win2012-64r2 guest doesn't set bus mastering correctly, it caused guest network down, this patch ignored it for e1000 nic for workarounding the guest issue. Patch 1 is an update version of: http://lists.gnu.org/archive/html/qemu-devel/2014-12/

Re: [Qemu-devel] [PATCH v2 0/7] coroutine: optimizations

2014-12-18 Thread Fam Zheng
On Tue, 12/02 12:05, Paolo Bonzini wrote: > As discussed in the other thread, this brings speedups from > dropping the coroutine mutex (which serializes multiple iothreads, > too) and using ELF thread-local storage. > > The speedup in perf/cost is about 50% (190->125). Windows port tested > with

Re: [Qemu-devel] [PATCH] target-mips: Correct 32-bit address space wrapping

2014-12-18 Thread Leon Alrae
On 15/12/2014 18:07, Maciej W. Rozycki wrote: > Great! I have now posted all the changes I had outstanding, there will > be no more. Thanks for the patches, they are very valuable - especially IEEE 754-2008, it's a significant improvement for MIPS! I'll take a closer look at the remaining ones,

Re: [Qemu-devel] [PATCH v5 2/4] qmp: Add command 'blockdev-backup'

2014-12-18 Thread Fam Zheng
On Wed, 12/17 15:53, John Snow wrote: > >+aio_context = bdrv_get_aio_context(bs); > >+aio_context_acquire(aio_context); > >+ > >+target_bs = bdrv_find(target); > >+if (!target_bs) { > >+error_set(errp, QERR_DEVICE_NOT_FOUND, target); > >+goto out; > >+} > >+ > >+

Re: [Qemu-devel] [PATCH 2/2] e1000: unconditionally enable bus mastering

2014-12-18 Thread Amos Kong
On Thu, Dec 18, 2014 at 09:57:29AM +0008, Jason Wang wrote: > > > On Thu, Dec 18, 2014 at 5:22 PM, Amos Kong wrote: > >After enabled network debug of e1000 in Win2012-64r2 guest, > >Bus mastering of e1000 can't be enabled by e1000 driver. It > >caused guest can't get IP address. > > > > # bcded

Re: [Qemu-devel] [PATCH v5 3/4] block: Add blockdev-backup to transaction

2014-12-18 Thread Fam Zheng
On Wed, 12/17 16:20, John Snow wrote: > On 12/17/2014 07:51 AM, Fam Zheng wrote: > >Signed-off-by: Fam Zheng > >--- > > blockdev.c | 79 > > > > qapi-schema.json | 2 ++ > > 2 files changed, 81 insertions(+) > > > >diff --git a/bloc

Re: [Qemu-devel] [PATCH V2 0/4] *virtio-blk: add multiread support

2014-12-18 Thread Kevin Wolf
Am 16.12.2014 um 17:00 hat Peter Lieven geschrieben: > On 16.12.2014 16:48, Kevin Wolf wrote: > >Am 16.12.2014 um 16:21 hat Peter Lieven geschrieben: > >>this series adds the long missing multiread support to virtio-blk. > >> > >>some remarks: > >> - i introduced rd_merged and wr_merged block acco

[Qemu-devel] [PATCH v6 0/4] qmp: Add "blockdev-backup"

2014-12-18 Thread Fam Zheng
v6: Add Eric's rev-by in 1/4. Address minor comments in 2/4, 3/4. Add John's rev-by in 3/4. v5: Address Max's and Markus' comments: Split patch 1. (Markus) Fix typos and pastos. (Markus, Max) Actually acquire aio context. (Max) Drop unnecessary initialization of fields in b

[Qemu-devel] [PATCH v6 3/4] block: Add blockdev-backup to transaction

2014-12-18 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: John Snow --- blockdev.c | 79 qapi-schema.json | 2 ++ 2 files changed, 81 insertions(+) diff --git a/blockdev.c b/blockdev.c index d6ccc5e..f2b3b25 100644 --- a/blockdev.c +++ b/blockdev.c @@

[Qemu-devel] [PATCH v6 2/4] qmp: Add command 'blockdev-backup'

2014-12-18 Thread Fam Zheng
Similar to drive-backup, but this command uses a device id as target instead of creating/opening an image file. Also add blocker on target bs, since the target is also a named device now. Add check and report error for bs == target which became possible but is an illegal case with introduction of

[Qemu-devel] [PATCH v6 4/4] qemu-iotests: Test blockdev-backup in 055

2014-12-18 Thread Fam Zheng
This applies cases on drive-backup on blockdev-backup, except cases with target format and mode. Also add a case to check source == target. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- tests/qemu-iotests/055 | 211 + tests/qemu-iotests/055

[Qemu-devel] [PATCH v6 1/4] qapi: Comment version info in TransactionAction

2014-12-18 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Eric Blake --- qapi-schema.json | 6 ++ 1 file changed, 6 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index 563b4ad..47d99cf 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -1254,6 +1254,12 @@ # # A discriminated record of o

Re: [Qemu-devel] [PATCH 0/2] ignore bus master for e1000

2014-12-18 Thread Denis V. Lunev
On 18/12/14 13:05, Jason Wang wrote: On Thu, Dec 18, 2014 at 5:22 PM, Amos Kong wrote: Win2012-64r2 guest doesn't set bus mastering correctly, it caused guest network down, this patch ignored it for e1000 nic for workarounding the guest issue. Patch 1 is an update version of: http://lists.gn

[Qemu-devel] [PATCH v5 3/5] block: Add driver methods to probe blocksizes and geometry

2014-12-18 Thread Ekaterina Tumanova
Introduce driver methods of defining disk blocksizes (physical and logical) and hard drive geometry. Methods are only implemented for "host_device". For "raw" devices driver calls child's method. For now geometry detection will only work for DASD devices. To check that a local check_for_dasd funct

[Qemu-devel] [PATCH v5 0/5] Geometry and blocksize detection for backing devices.

2014-12-18 Thread Ekaterina Tumanova
Updates v4 -> v5: Minor Updates according the last review from Markus: 1. update commit message for patch 2 2. fix comment typos 3. fix check_for_dasd to return -1 instead of -ENOTSUP Thanks, Kate. --- Patchset Description (didn't ch

[Qemu-devel] [PATCH v5 1/5] block: add bdrv functions for geometry and blocksize

2014-12-18 Thread Ekaterina Tumanova
Add driver functions for geometry and blocksize detection Signed-off-by: Ekaterina Tumanova Reviewed-by: Thomas Huth Reviewed-by: Markus Armbruster --- block.c | 35 +++ include/block/block.h | 13 + include/block/block_int.h |

[Qemu-devel] [PATCH v5 5/5] BlockConf: Call backend functions to detect geometry and blocksizes

2014-12-18 Thread Ekaterina Tumanova
geometry: hd_geometry_guess function autodetects the drive geometry. This patch adds a block backend call, that probes the backing device geometry. If the inner driver method is implemented and succeeds (currently only for DASDs), the blkconf_geometry will pass-through the backing device geometry.

[Qemu-devel] [PATCH v5 2/5] raw-posix: Refactor logical block size detection.

2014-12-18 Thread Ekaterina Tumanova
1. Move block size detection into dedicated function. 2. Select exactly one IOCTL that detects blocksize, specific to the host OS. Signed-off-by: Ekaterina Tumanova Reviewed-by: Markus Armbruster --- block/raw-posix.c | 41 - 1 file changed, 24 insertions

[Qemu-devel] [PATCH v5 4/5] block-backend: Add wrappers for blocksizes and geometry probing

2014-12-18 Thread Ekaterina Tumanova
Signed-off-by: Ekaterina Tumanova Reviewed-by: Markus Armbruster --- block/block-backend.c | 10 ++ include/sysemu/block-backend.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index ef16d73..4b9ed85 100644 --- a/block/blo

Re: [Qemu-devel] [PATCH v5 00/11] fw_cfg, bootorder, and UEFI+'-kernel' on arm/virt

2014-12-18 Thread Paolo Bonzini
On 17/12/2014 22:10, Laszlo Ersek wrote: > Addressing review comments received for v4 (with many thanks). > > Deeper changes in v5 include (see also the notes per patch): > > - The I/O port mapping and the MMIO mapping have been split into > separate QOM subclasses. This is new territory for

Re: [Qemu-devel] [PATCH v5 01/11] fw_cfg: hard separation between the MMIO and I/O port mappings

2014-12-18 Thread Paolo Bonzini
On 17/12/2014 22:10, Laszlo Ersek wrote: > +static Property fw_cfg_mem_properties[] = { > +DEFINE_PROP_UINT64("ctl_addr", FWCfgMemState, ctl_addr, -1), > +DEFINE_PROP_UINT64("data_addr", FWCfgMemState, data_addr, -1), > +DEFINE_PROP_END_OF_LIST(), > +}; > + > +static void fw_cfg_mem_r

Re: [Qemu-devel] [PATCH v5 02/11] fw_cfg: move boards to fw_cfg_init_io() / fw_cfg_init_mem()

2014-12-18 Thread Paolo Bonzini
On 17/12/2014 22:10, Laszlo Ersek wrote: > This allows us to drop the fw_cfg_init() shim and to enforce the possible > mappings at compile time. > > Signed-off-by: Laszlo Ersek > --- > > Notes: > v5: > - new in v5 [Laszlo] > > include/hw/nvram/fw_cfg.h | 2 -- > hw/i386/pc.c

Re: [Qemu-devel] [PATCH 0/2] ignore bus master for e1000

2014-12-18 Thread Denis V. Lunev
On 18/12/14 14:01, Denis V. Lunev wrote: On 18/12/14 13:05, Jason Wang wrote: On Thu, Dec 18, 2014 at 5:22 PM, Amos Kong wrote: Win2012-64r2 guest doesn't set bus mastering correctly, it caused guest network down, this patch ignored it for e1000 nic for workarounding the guest issue. Patch

Re: [Qemu-devel] alt-gr on Windows

2014-12-18 Thread Kevin Wolf
Am 17.12.2014 um 01:11 hat Thebault, Remi geschrieben: > Hi list! > > This is not the first post on this topic, but I haven't seen any > solution about it. > I tested so far linux guest on windows host and the AltGr key is > dead in the guest. (using git master branch) > > On french keyboard, the

Re: [Qemu-devel] [RFC PATCH] target-arm: protect cpu_exclusive_*.

2014-12-18 Thread Alexander Graf
On 18.12.14 10:12, Mark Burton wrote: > >> On 17 Dec 2014, at 17:39, Peter Maydell wrote: >> >> On 17 December 2014 at 16:29, Mark Burton wrote: On 17 Dec 2014, at 17:27, Peter Maydell wrote: I think a mutex is fine, personally -- I just don't want to see fifteen hand-hacked mu

Re: [Qemu-devel] [PATCH 0/3] block: three optimizations

2014-12-18 Thread Kevin Wolf
Am 17.12.2014 um 16:09 hat Paolo Bonzini geschrieben: > These are three unrelated micro-optimizations of the block layer. > The first is only visible on non-dataplane operation, the others > are generic. Thanks, applied all to the block branch. Kevin

Re: [Qemu-devel] [RFC PATCH] target-arm: protect cpu_exclusive_*.

2014-12-18 Thread Dr. David Alan Gilbert
* Alexander Graf (ag...@suse.de) wrote: > > > On 18.12.14 10:12, Mark Burton wrote: > > > >> On 17 Dec 2014, at 17:39, Peter Maydell wrote: > >> > >> On 17 December 2014 at 16:29, Mark Burton > >> wrote: > On 17 Dec 2014, at 17:27, Peter Maydell wrote: > I think a mutex is fine, pe

Re: [Qemu-devel] [PATCH v5 3/5] block: Add driver methods to probe blocksizes and geometry

2014-12-18 Thread Thomas Huth
On Thu, 18 Dec 2014 12:18:02 +0100 Ekaterina Tumanova wrote: > Introduce driver methods of defining disk blocksizes (physical and > logical) and hard drive geometry. > Methods are only implemented for "host_device". For "raw" devices > driver calls child's method. > > For now geometry detection

Re: [Qemu-devel] [PATCH v5 01/11] fw_cfg: hard separation between the MMIO and I/O port mappings

2014-12-18 Thread Peter Maydell
On 18 December 2014 at 11:18, Paolo Bonzini wrote: > > > On 17/12/2014 22:10, Laszlo Ersek wrote: >> +static Property fw_cfg_mem_properties[] = { >> +DEFINE_PROP_UINT64("ctl_addr", FWCfgMemState, ctl_addr, -1), >> +DEFINE_PROP_UINT64("data_addr", FWCfgMemState, data_addr, -1), >> +DEFI

Re: [Qemu-devel] [RFC PATCH] target-arm: protect cpu_exclusive_*.

2014-12-18 Thread Paolo Bonzini
On 18/12/2014 13:24, Alexander Graf wrote: > That's the nice thing about transactions - they guarantee that no other > CPU accesses the same cache line at the same time. So you're safe > against other vcpus even without blocking them manually. > > For the non-transactional implementation we prob

Re: [Qemu-devel] [PATCH v5 01/11] fw_cfg: hard separation between the MMIO and I/O port mappings

2014-12-18 Thread Paolo Bonzini
On 18/12/2014 13:58, Peter Maydell wrote: > On 18 December 2014 at 11:18, Paolo Bonzini wrote: >> >> >> On 17/12/2014 22:10, Laszlo Ersek wrote: >>> +static Property fw_cfg_mem_properties[] = { >>> +DEFINE_PROP_UINT64("ctl_addr", FWCfgMemState, ctl_addr, -1), >>> +DEFINE_PROP_UINT64("dat

Re: [Qemu-devel] [Qemu-ppc] Unable to loadvm on qemu-system-ppc -M g3beige (keyboard freeze)

2014-12-18 Thread Mark Cave-Ayland
On 17/12/14 11:23, Peter Maydell wrote: > On 17 December 2014 at 11:11, Alexander Graf wrote: >> Phew - 0.7.0 maybe? If you say that only CUDA is broken, I don't think >> it'd be too hard to fix :). Check that there are VMSTATEs for everything >> and maybe retrigger interrupts after migration. >

Re: [Qemu-devel] [RFC PATCH] target-arm: protect cpu_exclusive_*.

2014-12-18 Thread Mark Burton
> On 18 Dec 2014, at 13:24, Alexander Graf wrote: > > > > On 18.12.14 10:12, Mark Burton wrote: >> >>> On 17 Dec 2014, at 17:39, Peter Maydell wrote: >>> >>> On 17 December 2014 at 16:29, Mark Burton wrote: > On 17 Dec 2014, at 17:27, Peter Maydell wrote: > I think a mutex is fine

[Qemu-devel] Qemu on the Android platform

2014-12-18 Thread Apps Embedded
Hi, We would like to know if one is able to compile and run the qemu binaries on the Android platform, would it be possible to create an app - from a trademark point of view (Qemu is a trademark in France) ? - from a licence point of view (The whole app would be under the GPL v3 licence and source

Re: [Qemu-devel] [RFC PATCH] target-arm: protect cpu_exclusive_*.

2014-12-18 Thread Mark Burton
> On 18/12/2014 13:24, Alexander Graf wrote: >> That's the nice thing about transactions - they guarantee that no other >> CPU accesses the same cache line at the same time. So you're safe >> against other vcpus even without blocking them manually. >> >> For the non-transactional implementation

Re: [Qemu-devel] [PATCH v6 1/4] qapi: Comment version info in TransactionAction

2014-12-18 Thread Max Reitz
On 2014-12-18 at 11:37, Fam Zheng wrote: Signed-off-by: Fam Zheng Reviewed-by: Eric Blake --- qapi-schema.json | 6 ++ 1 file changed, 6 insertions(+) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH 1/3 V2] s390: Add PCI bus support

2014-12-18 Thread Cornelia Huck
On Thu, 18 Dec 2014 09:52:06 +0100 Frank Blaschka wrote: > From: Frank Blaschka > > This patch implements a pci bus for s390x together with infrastructure > to generate and handle hotplug events, to configure/unconfigure via > sclp instruction, to do iommu translations and provide s390 support

Re: [Qemu-devel] [PATCH 0/3 V2] add PCI support for the s390 platform

2014-12-18 Thread Cornelia Huck
On Thu, 18 Dec 2014 09:52:05 +0100 Frank Blaschka wrote: > This set of patches implemets PCI support for the s390 platform. > Now it is possible to run virtio-net-pci and potentially all > virtual pci devices conforming to s390 platform constrains. > > V1 added lot of feedback from Alex Graf >

Re: [Qemu-devel] [RFC PATCH] target-arm: protect cpu_exclusive_*.

2014-12-18 Thread Alexander Graf
On 18.12.14 15:20, Mark Burton wrote: > > >> On 18/12/2014 13:24, Alexander Graf wrote: >>> That's the nice thing about transactions - they guarantee that no other >>> CPU accesses the same cache line at the same time. So you're safe >>> against other vcpus even without blocking them manually.

Re: [Qemu-devel] [PATCH v6 3/4] block: Add blockdev-backup to transaction

2014-12-18 Thread Max Reitz
On 2014-12-18 at 11:37, Fam Zheng wrote: Signed-off-by: Fam Zheng Reviewed-by: John Snow --- blockdev.c | 79 qapi-schema.json | 2 ++ 2 files changed, 81 insertions(+) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH V2 0/4] *virtio-blk: add multiread support

2014-12-18 Thread Peter Lieven
Am 18.12.2014 um 11:34 schrieb Kevin Wolf: > Am 16.12.2014 um 17:00 hat Peter Lieven geschrieben: >> On 16.12.2014 16:48, Kevin Wolf wrote: >>> Am 16.12.2014 um 16:21 hat Peter Lieven geschrieben: this series adds the long missing multiread support to virtio-blk. some remarks:

Re: [Qemu-devel] [PATCH v5 4/5] block-backend: Add wrappers for blocksizes and geometry probing

2014-12-18 Thread Thomas Huth
On Thu, 18 Dec 2014 12:18:03 +0100 Ekaterina Tumanova wrote: > Signed-off-by: Ekaterina Tumanova > Reviewed-by: Markus Armbruster > --- > block/block-backend.c | 10 ++ > include/sysemu/block-backend.h | 2 ++ > 2 files changed, 12 insertions(+) > > diff --git a/block/block-

Re: [Qemu-devel] [Qemu-ppc] Unable to loadvm on qemu-system-ppc -M g3beige (keyboard freeze)

2014-12-18 Thread Alexander Graf
On 18.12.14 14:54, Mark Cave-Ayland wrote: > On 17/12/14 11:23, Peter Maydell wrote: > >> On 17 December 2014 at 11:11, Alexander Graf wrote: >>> Phew - 0.7.0 maybe? If you say that only CUDA is broken, I don't think >>> it'd be too hard to fix :). Check that there are VMSTATEs for everything >

Re: [Qemu-devel] [RFC PATCH] target-arm: protect cpu_exclusive_*.

2014-12-18 Thread Mark Burton
> On 18 Dec 2014, at 15:44, Alexander Graf wrote: > > > > On 18.12.14 15:20, Mark Burton wrote: >> >> >>> On 18/12/2014 13:24, Alexander Graf wrote: That's the nice thing about transactions - they guarantee that no other CPU accesses the same cache line at the same time. So you're

Re: [Qemu-devel] [PATCH v5 5/5] BlockConf: Call backend functions to detect geometry and blocksizes

2014-12-18 Thread Thomas Huth
On Thu, 18 Dec 2014 12:18:04 +0100 Ekaterina Tumanova wrote: > geometry: hd_geometry_guess function autodetects the drive geometry. > This patch adds a block backend call, that probes the backing device > geometry. If the inner driver method is implemented and succeeds > (currently only for DASDs

Re: [Qemu-devel] [PATCH v6 2/4] qmp: Add command 'blockdev-backup'

2014-12-18 Thread Max Reitz
On 2014-12-18 at 11:37, Fam Zheng wrote: Similar to drive-backup, but this command uses a device id as target instead of creating/opening an image file. Also add blocker on target bs, since the target is also a named device now. Add check and report error for bs == target which became possible

Re: [Qemu-devel] [RFC PATCH] target-arm: protect cpu_exclusive_*.

2014-12-18 Thread Alexander Graf
On 18.12.14 15:51, Mark Burton wrote: > >> On 18 Dec 2014, at 15:44, Alexander Graf wrote: >> >> >> >> On 18.12.14 15:20, Mark Burton wrote: >>> >>> On 18/12/2014 13:24, Alexander Graf wrote: > That's the nice thing about transactions - they guarantee that no other > CPU accesses t

Re: [Qemu-devel] [RFC PATCH] target-arm: protect cpu_exclusive_*.

2014-12-18 Thread Mark Burton
>> >> In other words — the back-end (slow path) memory interface should look >> ‘transactional’…? > > Yeah, the semantics should be tied to what TM would give you. We can > always be more safe than TM in our fallback implementation, but I > wouldn't want to see semantic optimizations tied to the

Re: [Qemu-devel] [Qemu-ppc] Unable to loadvm on qemu-system-ppc -M g3beige (keyboard freeze)

2014-12-18 Thread Peter Maydell
On 18 December 2014 at 14:46, Alexander Graf wrote: > On 18.12.14 14:54, Mark Cave-Ayland wrote: >> So it looks like several of the device MemoryRegions aren't being added >> after the "loadvm". Does this mean there is an object lifecycle issue >> here in that some of the initialisation needs to b

Re: [Qemu-devel] [PATCH 00/14] block: Remove "growable", add blk_new_open()

2014-12-18 Thread Kevin Wolf
Am 11.12.2014 um 14:20 hat Max Reitz geschrieben: > This series removes the "growable" field from the BlockDriverState > object. Its use was to clamp guest requests against the limits of the > BDS; however, this can now be done more easily by moving those checks > into the BlockBackend functions. >

Re: [Qemu-devel] [PATCH 02/14] block: Add blk_new_open()

2014-12-18 Thread Kevin Wolf
Am 11.12.2014 um 14:20 hat Max Reitz geschrieben: > blk_new_with_bs() creates a BlockBackend with an empty BlockDriverState > attached to it. Empty BDSs are not nice, therefore add an alternative > function which combines blk_new_with_bs() with bdrv_open(). > > Note: In contrast to bdrv_open() whi

[Qemu-devel] Review of ways to create BDSes (was: Review of monitor commands identifying BDS / BB by name)

2014-12-18 Thread Markus Armbruster
= Introduction = BDSes can be opened in various ways. Some of them don't provide for user configuration. Some of them should. Example: -drive format=qcow2,file=foo.qcow2 where foo.qcow2 has a raw backing file foo.raw. This creates the the following tree of BDSes: (qcow2,foo.qcow2)

[Qemu-devel] 2.1 unexpected stop after exporting blockdev via nbd server

2014-12-18 Thread Andrey Korolyov
Hello, 2.1-stable is currently crashing with the Co-routine re-entered recursively 2014-12-16 15:06:23.578+: shutting down after execution of (for example) following when using virtio-dp as a disk backend: '{ "execute": "nbd-server-start", "arguments": { "addr": { "type": "inet", "data": {

Re: [Qemu-devel] [PATCH v5 0/5] Geometry and blocksize detection for backing devices.

2014-12-18 Thread Christian Borntraeger
Am 18.12.2014 um 12:17 schrieb Ekaterina Tumanova: > Updates v4 -> v5: > > Minor Updates according the last review from Markus: > 1. update commit message for patch 2 > 2. fix comment typos > 3. fix check_for_dasd to return -1 instead of -ENOTSUP > > Thanks, > Kate. > > -

[Qemu-devel] [PATCH] hw/ppc/e500.c : Fix GPIO IRQ Number.

2014-12-18 Thread Amit Tomar
Provided appropriate subject line. Signed-off-by: Amit Singh Tomar --- hw/ppc/e500.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index 2832fc0..2cd69a9 100644 --- a/hw/ppc/e500.c +++ b/hw/ppc/e500.c @@ -65,7 +65,7 @@ #define MPC8544_UTIL

[Qemu-devel] [PATCH 1/1] dev-serial: report when data are ready to be read

2014-12-18 Thread Jean-Christophe PLAGNIOL-VILLARD
So we can pull it on software without IRQ support Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD --- hw/usb/dev-serial.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial.c index 500fbb0..4c14126 100644 --- a/hw/usb/dev-serial.c +++ b/hw/usb/dev-seria

[Qemu-devel] [PULL v2 0/7] s390x patches for 2.3

2014-12-18 Thread Cornelia Huck
in the git repository at: git://github.com/cohuck/qemu tags/s390x-20141218-v2 for you to fetch changes up to 312bf875ce90a588c12b0119dd4514aea4fad1d8: kvm: extend kvm_irqchip_add_msi_route to work on s390 (2014-12-18 15:33:24 +0100)

[Qemu-devel] [PULL v2 1/7] s390x/ccw: fix oddity in machine class init

2014-12-18 Thread Cornelia Huck
ccw_machine_class_init() uses ',' instead of ';' while initializing the class' fields. This is almost certainly a copy/paste error and, while legal C, rather on the unusual side. Just use ';' everywhere. Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck Signed-off-by: Jens Freimann Signed-o

[Qemu-devel] [PULL v2 7/7] kvm: extend kvm_irqchip_add_msi_route to work on s390

2014-12-18 Thread Cornelia Huck
From: Frank Blaschka on s390 MSI-X irqs are presented as thin or adapter interrupts for this we have to reorganize the routing entry to contain valid information for the adapter interrupt code on s390. To minimize impact on existing code we introduce an architecture function to fixup the routing

[Qemu-devel] [PULL v2 2/7] s390x/css: Clean up unnecessary CONFIG_USER_ONLY wrappers

2014-12-18 Thread Cornelia Huck
From: Thomas Huth The css functions are only used from ioinst.c and other files that are only built for CONFIG_SOFTMMU. So we do not need the dummy wrappers for the CONFIG_USER_ONLY target in the cpu.h header. Signed-off-by: Thomas Huth Signed-off-by: Jens Freimann Reviewed-by: Jason J. Herne

[Qemu-devel] [PATCH 0/9] target-ppc: Rudimentary Support for Transactional Memory

2014-12-18 Thread Tom Musta
This patch series introduces rudimentary support for the Transactional Memory (TM) feature of Power ISA V2.07. In a nutshell, software uses the feature by initiating a transaction via the tbegin instruction. Hardware then accumulates storage accesses until the transaction is committed via the ten

[Qemu-devel] [PULL v2 5/7] s390: Add PCI bus support

2014-12-18 Thread Cornelia Huck
From: Frank Blaschka This patch implements a pci bus for s390x together with infrastructure to generate and handle hotplug events, to configure/unconfigure via sclp instruction, to do iommu translations and provide s390 support for MSI/MSI-X notification processing. [CH: fixed typo in css_genera

[Qemu-devel] [PATCH 2/9] target-ppc: Introduce Feature Flag for Transactional Memory

2014-12-18 Thread Tom Musta
Add a flag (POWERPC_FLAG_TM) for the Transactional Memory Facility introduced in Power ISA 2.07. Signed-off-by: Tom Musta --- target-ppc/cpu.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h index 3510083..38176c0 100644 --- a/target-

[Qemu-devel] [PATCH 3/9] target-ppc: Introduce tm_enabled Bit to CPU State

2014-12-18 Thread Tom Musta
Add a bit (tm_enabled) to CPU state that mirrors the MSR[TM] bit. This is analogous to the other "available" bits in the MSR (FP, VSX, etc.). NOTE: Since MSR[TM] occupies big-endian bit 31, the code is wrapped with a PPC64 bit check. Signed-off-by: Tom Musta --- target-ppc/translate.c |8 ++

[Qemu-devel] [PULL v2 3/7] s390x/kvm: sync register support helper function

2014-12-18 Thread Cornelia Huck
From: David Hildenbrand Let's unify the code to sync registers by moving the checks into a helper function can_sync_regs(). Signed-off-by: David Hildenbrand Signed-off-by: Jens Freimann Reviewed-by: Cornelia Huck Signed-off-by: Cornelia Huck --- target-s390x/kvm.c | 22 ---

[Qemu-devel] [PATCH 6/9] target-ppc: Introduce tbegin

2014-12-18 Thread Tom Musta
Provide a degenerate implementation of the tbegin instruction. This implementation always fails the transaction, recording the failure per Book II Section 5.3.2 of the Power ISA V2.07. Signed-off-by: Tom Musta --- target-ppc/helper.h |2 ++ target-ppc/mem_helper.c | 22 +++

[Qemu-devel] [PULL v2 6/7] s390: implement pci instructions

2014-12-18 Thread Cornelia Huck
From: Frank Blaschka This patch implements the s390 pci instructions in qemu. It allows to access and drive pci devices attached to the s390 pci bus. Because of platform constrains devices using IO BARs are not supported. Also a device has to support MSI/MSI-X to run on s390. Signed-off-by: Fran

[Qemu-devel] [PATCH 4/9] target-ppc: Power8 Supports Transactional Memory

2014-12-18 Thread Tom Musta
The Power8 processor implements the Transactional Memory Facility as defined in Power ISA 2.07. Update the initialization code to indicate this. Signed-off-by: Tom Musta --- target-ppc/translate_init.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/target-ppc/trans

[Qemu-devel] [PATCH 8/9] target-ppc: Introduce tcheck

2014-12-18 Thread Tom Musta
Add a degenerate implementation of the Transaction Check (tcheck) instruction. Since transaction always immediately fail, this implementation simply sets CR[BF] to 0b1000, i.e. TDOOMED = 1 and MSR[TS] == 0. Signed-off-by: Tom Musta --- target-ppc/translate.c | 17 + 1 files ch

[Qemu-devel] [PULL v2 4/7] s390x/kvm: avoid syscalls by syncing registers with kvm_run

2014-12-18 Thread Cornelia Huck
From: David Hildenbrand We can avoid loads of syscalls when dropping to user space by storing the values of more registers directly within kvm_run. Support is added for: - ARCH0: CPU timer, clock comparator, TOD programmable register, guest breaking-event register, program parameter - P

[Qemu-devel] [PATCH 1/9] target-ppc: Introduce Instruction Type for Transactional Memory

2014-12-18 Thread Tom Musta
Add a category (PPC2_TM) for the Transactional Memory instructions introduced in Power ISA 2.07. Signed-off-by: Tom Musta --- target-ppc/cpu.h |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h index 068fcb2..3510083 100644 --- a/targe

[Qemu-devel] [PATCH 5/9] target-ppc: Introduce TEXASRU Bit Fields

2014-12-18 Thread Tom Musta
Define mnemonics for the various bit fields in the Transaction EXception And Summary Register (TEXASR). --- target-ppc/cpu.h | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h index 38176c0..91a03f6 100644 --- a/target-p

[Qemu-devel] [PATCH 9/9] target-ppc: Introduce Privileged TM Noops

2014-12-18 Thread Tom Musta
Add the supervisory Transactional Memory instructions treclaim. and trechkpt. The implementation is a degenerate one that simply checks privileged state, TM availability and then sets CR[0] to 0b, just like the unprivileged noops. --- target-ppc/translate.c | 38

[Qemu-devel] [PATCH 7/9] target-ppc: Introduce TM Noops

2014-12-18 Thread Tom Musta
Add degenerate implementations of the non-privileged Transactional Memory instructions tend., tabort*. and tsr. This implementation simply checks the MSR[TM] bit and then sets CR0 to 0b. This is a reasonable degenerate implementation since transactions are never allowed to begin and hence MSR

Re: [Qemu-devel] [PATCH] hw/ppc/e500.c : Fix GPIO IRQ Number.

2014-12-18 Thread Alexander Graf
On 18.12.14 15:28, Amit Tomar wrote: > > Provided appropriate subject line. This time around the patch description is wrong :(. Please just post a full new patch with a good subject line and a good patch description. In the git tree, all history from email communication will be gone. People wi

Re: [Qemu-devel] [PATCH RFC v6 17/20] virtio-net: enable virtio 1.0

2014-12-18 Thread Cornelia Huck
On Tue, 16 Dec 2014 15:10:04 +0200 "Michael S. Tsirkin" wrote: > On Thu, Dec 11, 2014 at 02:25:19PM +0100, Cornelia Huck wrote: > > virtio-net (non-vhost) now should have everything in place to support > > virtio 1.0: let's enable the feature bit for it. > > > > Note that VIRTIO_F_VERSION_1 is t

Re: [Qemu-devel] [RFC PATCH] target-arm: protect cpu_exclusive_*.

2014-12-18 Thread Paolo Bonzini
On 18/12/2014 16:05, Alexander Graf wrote: > Yeah, the semantics should be tied to what TM would give you. We can > always be more safe than TM in our fallback implementation, but I > wouldn't want to see semantic optimizations tied to the MMIO > implementation put in. > > This is mostly theory

Re: [Qemu-devel] [PATCH 5/9] target-ppc: Introduce TEXASRU Bit Fields

2014-12-18 Thread Alexander Graf
On 18.12.14 17:34, Tom Musta wrote: > Define mnemonics for the various bit fields in the Transaction > EXception And Summary Register (TEXASR). This is missing an SoB line. Alex

Re: [Qemu-devel] [PATCH v6 2/4] qmp: Add command 'blockdev-backup'

2014-12-18 Thread John Snow
On 12/18/2014 05:37 AM, Fam Zheng wrote: Similar to drive-backup, but this command uses a device id as target instead of creating/opening an image file. Also add blocker on target bs, since the target is also a named device now. Add check and report error for bs == target which became possibl

Re: [Qemu-devel] [PATCH 5/9] target-ppc: Introduce TEXASRU Bit Fields

2014-12-18 Thread Tom Musta
On 12/18/2014 11:02 AM, Alexander Graf wrote: > > > On 18.12.14 17:34, Tom Musta wrote: >> Define mnemonics for the various bit fields in the Transaction >> EXception And Summary Register (TEXASR). > > This is missing an SoB line. > > > Alex > Sorry about that. I will publish a V2 but may w

Re: [Qemu-devel] [PATCH 5/9] target-ppc: Introduce TEXASRU Bit Fields

2014-12-18 Thread Alexander Graf
On 18.12.14 19:10, Tom Musta wrote: > On 12/18/2014 11:02 AM, Alexander Graf wrote: >> >> >> On 18.12.14 17:34, Tom Musta wrote: >>> Define mnemonics for the various bit fields in the Transaction >>> EXception And Summary Register (TEXASR). >> >> This is missing an SoB line. >> >> >> Alex >> > >

Re: [Qemu-devel] [PATCH 5/9] target-ppc: Introduce TEXASRU Bit Fields

2014-12-18 Thread Tom Musta
On 12/18/2014 12:29 PM, Alexander Graf wrote: > > > On 18.12.14 19:10, Tom Musta wrote: >> On 12/18/2014 11:02 AM, Alexander Graf wrote: >>> >>> >>> On 18.12.14 17:34, Tom Musta wrote: Define mnemonics for the various bit fields in the Transaction EXception And Summary Register (TEXASR)

Re: [Qemu-devel] [PATCH v2 0/8] acpi: make ROMs resizeable

2014-12-18 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > This is v2 of the patchset. > Changes since v1: > - Any RAM can now be resizeable - there's no requirement > that it's device RAM any longer. > - For simplicity, max_size RAM is always pre-allocated > - Added memory_region_set_size,

Re: [Qemu-devel] [PATCH 2/2] atapi migration: Throw recoverable error to avoid recovery

2014-12-18 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: > > > > > > On 09/12/2014 19:15, Dr. David Alan Gilbert (git) wrote: > > > (With the previous atapi_dma flag recovery) > > > If migration happens between the ATAPI command being written and the >

Re: [Qemu-devel] [PATCH v2 0/8] acpi: make ROMs resizeable

2014-12-18 Thread Michael S. Tsirkin
On Thu, Dec 18, 2014 at 06:49:09PM +, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > This is v2 of the patchset. > > Changes since v1: > > - Any RAM can now be resizeable - there's no requirement > > that it's device RAM any longer. > > - For sim

Re: [Qemu-devel] [PATCH v2 0/8] acpi: make ROMs resizeable

2014-12-18 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Thu, Dec 18, 2014 at 06:49:09PM +, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > I'm generally happy with this set for what you're using it for, > > except that I'd like some big hairy warnings in comments

Re: [Qemu-devel] [PATCH v1] [Review Request] RTC Support in e500

2014-12-18 Thread Amit Tomar
Thank you for reviewing the patches and providing the comments. I'm able to follow most of the comments except below two. >Is this true for a real MPC8544DS as well? If not, we'll need to >conditionalize it to only spawn >the i2c controller (and rtc clock) on the >virt machine. I could not a

Re: [Qemu-devel] [Qemu-ppc] Unable to loadvm on qemu-system-ppc -M g3beige (keyboard freeze)

2014-12-18 Thread Mark Cave-Ayland
On 18/12/14 15:13, Peter Maydell wrote: > On 18 December 2014 at 14:46, Alexander Graf wrote: >> On 18.12.14 14:54, Mark Cave-Ayland wrote: >>> So it looks like several of the device MemoryRegions aren't being added >>> after the "loadvm". Does this mean there is an object lifecycle issue >>> her

Re: [Qemu-devel] [PATCH v2 0/8] acpi: make ROMs resizeable

2014-12-18 Thread Michael S. Tsirkin
On Thu, Dec 18, 2014 at 08:16:26PM +, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Thu, Dec 18, 2014 at 06:49:09PM +, Dr. David Alan Gilbert wrote: > > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > > I'm generally happy with this set for what

  1   2   >