Re: [Qemu-devel] [PATCH 8/9] migration: add dirty parameter

Thanks. It's interesting that checkpatch.pl doesn't warn about this line. Best regards, Vladimir On 11.12.2014 18:18, Eric Blake wrote: On 12/11/2014 07:17 AM, Vladimir Sementsov-Ogievskiy wrote: Add dirty parameter to qmp-migrate command. If this parameter is true, block-migration.c will migr

Re: [Qemu-devel] [PATCH v2] block: fix spoiling all dirty bitmaps by mirror and migration

ping v2 just fixes over 80 characters lines mentioned by Fam Zheng in previous version of this patch: [PATCH RFC] block: fix spoiling all dirty bitmaps by mirror and migration Best regards, Vladimir On 27.11.2014 12:40, Vladimir Sementsov-Ogievskiy wrote: Mirror and migration use dirty bitma

Re: [Qemu-devel] [PATCH v9 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove

Stefan Hajnoczi writes: > On Wed, Dec 10, 2014 at 01:43:47PM +0100, Markus Armbruster wrote: >> Stefan Hajnoczi writes: >> >> > On Mon, Dec 01, 2014 at 03:30:08PM -0500, John Snow wrote: >> >> diff --git a/block.c b/block.c >> >> index e5c6ccf..3f27519 100644 >> >> --- a/block.c >> >> +++ b/blo

Re: [Qemu-devel] [PATCH] NetKVM: fix for indirectc mode when vring is full

okay, thank you, I think it is better for net and other feature with one virtio code set like linux. On 2014-12-14 21:30, Yan Vugenfirer wrote: > Thanks! > > The fix is correct, but I am not sure this patch is needed. > This is a frozen part of the code with XP and Windows 2003 support for NetKV

Re: [Qemu-devel] [PATCH 1/4] block: vhdx - remove redundant comments

Stefan Hajnoczi writes: > On Mon, Dec 08, 2014 at 01:07:42AM -0500, Jeff Cody wrote: >> Minor cleanup. >> >> Signed-off-by: Jeff Cody >> --- >> block/vhdx.c | 8 >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/block/vhdx.c b/block/vhdx.c >> index 12bfe75..f1e1e2

Re: [Qemu-devel] [PATCH] Add 'setup' phase to docs for query-migrate QMP command

Copying migration maintainers. Alex Bligh writes: > The QMP command 'query-migrate' returns the state 'setup' during > the setup phase. This patch documents it. > > Signed-off-by: Alex Bligh > --- > qmp-commands.hx | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --

Re: [Qemu-devel] paaudio race condition on close

If Gerd (cc'ed) doesn't know, then I'm afraid nobody around here does. Peter Maydell writes: > There seems to be a race condition in the pulseaudio backend on > closing of a voice... > > There are two threads involved here. The first one is a worker > thread that just sits executing our qpa_thre

[Qemu-devel] [PATCH 07/16] parallels: change copyright information in the image header

Signed-off-by: Denis V. Lunev Acked-by: Roman Kagan Reviewed-by: Jeff Cody CC: Kevin Wolf CC: Stefan Hajnoczi --- block/parallels.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/parallels.c b/block/parallels.c index fedb009..5fcede8 100644 --- a/block/parallels.

[Qemu-devel] [PATCH 04/16] iotests: simple parallels XML disk descriptor file test added

Signed-off-by: Denis V. Lunev Acked-by: Roman Kagan Reviewed-by: Jeff Cody CC: Kevin Wolf CC: Stefan Hajnoczi --- tests/qemu-iotests/076| 6 ++ tests/qemu-iotests/076.out| 4 tests/qemu-iotests/sample_images/para

[Qemu-devel] [PATCH 05/16] block/parallels: support padded Parallels images

Unfortunately, old guest OSes do not align partitions to page size by default. This is true for Windows 2003 and Windows XP. For the time being Parallels was created an optimization for such OSes in its desktop product. Desktop users are not qualified enough to create properly aligned installation

[Qemu-devel] [PATCH 06/16] iotests: padded parallels image test

Unfortunately, old guest OSes do not align partitions to page size by default. This is true for Windows 2003 and Windows XP. "Padding" is a value which should be added to guest LBA to obtain sector number inside the image. This results in a shifted images. 0123offset inside image (in 51

[Qemu-devel] [PATCH 03/16] iotests, parallels: quote TEST_IMG in 076 test to be path-safe

suggested by Jeff Cody Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Kevin Wolf CC: Stefan Hajnoczi --- tests/qemu-iotests/076 | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/qemu-iotests/076 b/tests/qemu-iotests/076 index ed2be35..0139976 100755 --- a/t

[Qemu-devel] [PATCH 15/16] block/parallels: support read-only parallels snapshots

This patch reads snapshot information from the XML descriptor file. The lastest snapshot (read-write one) could be located using the following rules: GUID could be used as a source to locate leaf in the snapshot tree: - TopGUID tag is specified in the XML file - {704718E1-2314-44c8-9087-D78ED36B0F

[Qemu-devel] [PATCH 02/16] block/parallels: allow to specify DiskDescriptor.xml instead of image file

Typically Parallels disk bundle consists of several images which are glued by XML disk descriptor. Also XML hides inside several important parameters which are not available in the image header. This patch allows to specify this XML file as a filename for an image to open. It is allowed only to op

[Qemu-devel] [PATCH 01/16] configure: add dependency from libxml2

This dependency is required for adequate Parallels images support. Typically the disk consists of several images which are glued by XML disk descriptor. Also XML hides inside several important parameters which are not available in the image header. The patch also adds clause to checkpatch.pl to un

[Qemu-devel] [PATCH 16/16] iotests: testcase parallels image with snapshots

Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Kevin Wolf CC: Stefan Hajnoczi --- tests/qemu-iotests/076| 7 +++ tests/qemu-iotests/076.out| 4 .../qemu-iotests/sample_images/parallels-snapshot.xml.bz2 | Bin 0 ->

[Qemu-devel] [PATCH 13/16] block/parallels: read disk size from XML if DiskDescriptor.xml is passed

as an image filename. This is preparational commit to read snapshot information from XML. This is the only global parameter which will be kept in BDRVParallelsState, the rest should be layered down into snapshots information structure. Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Kevin Wolf

[Qemu-devel] [PATCH 11/16] block/parallels: add support for backing files

From: Roman Kagan Add backing file support to Parallels format driver. That said, I think backing file operations should end up in the generic block layer, but that's a longer story... Signed-off-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Kevin Wolf CC: Stefan Hajnoczi

[Qemu-devel] [PATCH 14/16] block/parallels: introduce ParallelsSnapshot data structure

In order to support snapshots of parallels images we should maintain snapshots list in BDRVParallelsState. Snapshots actually forms tree. Though, in read-only case, we do need to traverse only from current snapshot leaf to the snapshot tree root. Thus interesting for us snapshots forms old good lin

[Qemu-devel] [PATCH v4 0/16] parallels format support improvements

The patchset implements additional compatibility bits for Parallels format: - initial support of parsing of Parallels DiskDeskriptor.xml Typically Parallels disk bundle consists of several images which are glued by XML disk descriptor. Also XML hides inside several important parameters which

[Qemu-devel] [PATCH 10/16] block/parallels: add get_block_status

From: Roman Kagan Implement VFS method for get_block_status to Parallels format driver. Signed-off-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Kevin Wolf CC: Stefan Hajnoczi --- block/parallels.c | 21 + 1 file changed, 21 insertions(+) diff --git a

[Qemu-devel] [PATCH 09/16] block/parallels: read up to cluster end in one go

From: Roman Kagan Teach parallels_read() to do reads in coarser granularity than just a single sector: if requested, read up the cluster end in one go. Signed-off-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Kevin Wolf CC: Stefan Hajnoczi --- block/parallels.c | 18 +

[Qemu-devel] [PATCH 12/16] iotests: testcase for backing in parallels format

From: Roman Kagan This patch adds a testcase for reading from a backing file when both the current image and the backing one are in parallels format. Signed-off-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Kevin Wolf CC: Stefan Hajnoczi --- tests/qemu-iotests/076 | 2

Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command

Hi, > > > > So better add a 'vencrypt-subauth' enum with this list? > > Yeah probably a good idea How does this look like (incremental fixup attached, docs to be updated) ? cheers, Gerd >From c2de144be939412f8923d20e22983e16ab418404 Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Mon,

[Qemu-devel] [PATCH 08/16] block/parallels: switch to bdrv_read

From: Roman Kagan Switch the .bdrv_read method implementation from using bdrv_pread() to bdrv_read() on the underlying file, since the latter is subject to i/o throttling while the former is not. Besides, since bdrv_read() operates in sectors rather than bytes, adjust the helper functions to do

Re: [Qemu-devel] paaudio race condition on close

Hi, > > Usually this works. Unfortunately if the input thread is in the > > middle of actually writing to the buffer then things can go pear > > shaped, because the sample buffer itself is freed earlier, by > > audio_pcm_hw_gc_in(): > > > > glue (s->nb_hw_voices_, TYPE) += 1; > >

Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command

On Mon, Dec 15, 2014 at 10:16:39AM +0100, Gerd Hoffmann wrote: > Hi, > > > > > > > So better add a 'vencrypt-subauth' enum with this list? > > > > Yeah probably a good idea > > How does this look like (incremental fixup attached, docs to be > updated) ? Looks fine to me. Regards, Daniel --

Re: [Qemu-devel] [PATCH v3 1/7] Move target_words_bigendian() prototype to exec-all.h

On Fri, 12 Dec 2014 16:20:16 -0200 Eduardo Habkost wrote: > On Wed, Dec 10, 2014 at 07:44:04PM +, Peter Maydell wrote: > > On 10 December 2014 at 19:26, Eduardo Habkost wrote: > > > Signed-off-by: Eduardo Habkost > > > --- > > > exec.c | 1 - > > > hw/virtio/virtio.c

Re: [Qemu-devel] [PATCH v2 0/3] tests: Add check-block to "make check"

Am 15.12.2014 um 06:07 hat Fam Zheng geschrieben: > qemu-iotests contains useful tests that have a nice coverage of block layer > code. Adding check-block (which calls tests/qemu-iotests-quick.sh) to "make > check" is good for developers' self-testing. > > v2: Address comments from reviewing of v1

Re: [Qemu-devel] [PATCH v2 00/12] qcow2: Add new overlap check functions

On 2014-11-24 at 16:56, Max Reitz wrote: As has been requested, this series adds new overlap check functions to the qcow2 code. My local branch is called "qcow2-improved-overlap-v1", but I am not so sure whether it is actually an improvement; that is left for you to decide, dear reviewers. See p

Re: [Qemu-devel] [PATCH v4 0/6] block: Relative backing files

On 2014-11-26 at 17:20, Max Reitz wrote: Cover letter of v1: Sometimes, qemu does not have a filename to work with (it then generates a JSON filename), so it does not know which directory to use for a backing file specified by a relative filename. In this case, qemu should not somehow try to ap

Re: [Qemu-devel] [PATCH v3 0/2] balloon: add a feature bit to let Guest OS deflate virtio_balloon on OOM

On 27/11/14 15:44, Denis V. Lunev wrote: Excessive virtio_balloon inflation can cause invocation of OOM-killer, when Linux is under severe memory pressure. Various mechanisms are responsible for correct virtio_balloon memory management. Nevertheless it is often the case that these control tools d

Re: [Qemu-devel] [PATCH] target-mips: add CPU definition for MIPS-II

Hello Petar, I've seen some older threads in the mailing list and I'm aware that adding generic CPU definitions is something that should be avoided. However, I don't have any real MIPS-II machine readily available at the moment. We need support for the MIPS-II ISA because we enabled the MIPS-II t

Re: [Qemu-devel] [PATCH v3 1/7] Move target_words_bigendian() prototype to exec-all.h

On Fri, 12 Dec 2014 16:20:16 -0200 Eduardo Habkost wrote: > On Wed, Dec 10, 2014 at 07:44:04PM +, Peter Maydell wrote: > > On 10 December 2014 at 19:26, Eduardo Habkost wrote: > > > Signed-off-by: Eduardo Habkost > > > --- > > > exec.c | 1 - > > > hw/virtio/virtio.c

[Qemu-devel] [PATCH] Makefile: Remove config.status and common.env during 'make distclean'

config.status and tests/qemu-iotests/common.env are generated files that should be deleted during 'make distclean'. Signed-off-by: Thomas Huth --- Makefile |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index f505202..6817c6f 100644 --- a/Makefile

Re: [Qemu-devel] [PATCH 02/16] block/parallels: allow to specify DiskDescriptor.xml instead of image file

Am 15.12.2014 um 09:27 hat Denis V. Lunev geschrieben: > Typically Parallels disk bundle consists of several images which are > glued by XML disk descriptor. Also XML hides inside several important > parameters which are not available in the image header. > > This patch allows to specify this XML

Re: [Qemu-devel] [PATCH v3 1/4] serial: reset thri_pending on IER writes with THRI=0

* Paolo Bonzini (pbonz...@redhat.com) wrote: > This is responsible for failure of migration from 2.2 to 2.1, because > thr_ipending is always one in practice. > > serial.c is setting thr_ipending unconditionally. However, thr_ipending > is not used at all if THRI=0, and it will be overwritten aga

Re: [Qemu-devel] [PATCH 04/16] iotests: simple parallels XML disk descriptor file test added

Am 15.12.2014 um 09:27 hat Denis V. Lunev geschrieben: > Signed-off-by: Denis V. Lunev > Acked-by: Roman Kagan > Reviewed-by: Jeff Cody > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > tests/qemu-iotests/076| 6 ++ > tests/qemu-iotests/076.out

Re: [Qemu-devel] [PATCH 05/16] block/parallels: support padded Parallels images

Am 15.12.2014 um 09:27 hat Denis V. Lunev geschrieben: > Unfortunately, old guest OSes do not align partitions to page size by > default. This is true for Windows 2003 and Windows XP. > > For the time being Parallels was created an optimization for such OSes > in its desktop product. Desktop users

Re: [Qemu-devel] [PATCH 07/16] parallels: change copyright information in the image header

Am 15.12.2014 um 09:27 hat Denis V. Lunev geschrieben: > Signed-off-by: Denis V. Lunev > Acked-by: Roman Kagan > Reviewed-by: Jeff Cody > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > block/parallels.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/block/parallels

Re: [Qemu-devel] [PULL 00/19] Block patches

On 12 December 2014 at 17:09, Stefan Hajnoczi wrote: > The following changes since commit 99c9c3cb24e566258a0a141178934f9cb5198842: > > Merge remote-tracking branch > 'remotes/mjt/tags/pull-trivial-patches-2014-12-11' into staging (2014-12-11 > 18:27:02 +) > > are available in the git repo

Re: [Qemu-devel] [PATCH v4] block: add event when disk usage exceeds threshold

ping? - Original Message - > From: "Francesco Romani" > To: qemu-devel@nongnu.org > Cc: kw...@redhat.com, mdr...@linux.vnet.ibm.com, stefa...@redhat.com, > lcapitul...@redhat.com > Sent: Thursday, December 4, 2014 10:00:18 AM > Subject: Re: [Qemu-devel] [PATCH v4] block: add event when d

Re: [Qemu-devel] [PATCH 05/16] block/parallels: support padded Parallels images

On 15/12/14 14:05, Kevin Wolf wrote: Am 15.12.2014 um 09:27 hat Denis V. Lunev geschrieben: Unfortunately, old guest OSes do not align partitions to page size by default. This is true for Windows 2003 and Windows XP. For the time being Parallels was created an optimization for such OSes in its

[Qemu-devel] [PULL 00/11] s390x changes for 2.3

The following changes since commit 99c9c3cb24e566258a0a141178934f9cb5198842: Merge remote-tracking branch 'remotes/mjt/tags/pull-trivial-patches-2014-12-11' into staging (2014-12-11 18:27:02 +) are available in the git repository at: git://github.com/cohuck/qemu tags/s390

[Qemu-devel] [PULL 03/11] kvm: extend kvm_irqchip_add_msi_route to work on s390

From: Frank Blaschka on s390 MSI-X irqs are presented as thin or adapter interrupts for this we have to reorganize the routing entry to contain valid information for the adapter interrupt code on s390. To minimize impact on existing code we introduce an architecture function to fixup the routing

[Qemu-devel] [PULL 10/11] s390/pci: remove unnecessary cpu_synchronize_state

From: Frank Blaschka Remove all unnecessary calls to cpu_synchronize_state Signed-off-by: Frank Blaschka Signed-off-by: Cornelia Huck Reviewed-by: Thomas Huth --- hw/s390x/s390-pci-inst.c |6 -- 1 file changed, 6 deletions(-) diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci

[Qemu-devel] [PULL 01/11] s390: Add PCI bus support

From: Frank Blaschka This patch implements a pci bus for s390x together with infrastructure to generate and handle hotplug events, to configure/unconfigure via sclp instruction, to do iommu translations and provide s390 support for MSI/MSI-X notification processing. Signed-off-by: Frank Blaschka

[Qemu-devel] [PULL 05/11] s390x/css: Clean up unnecessary CONFIG_USER_ONLY wrappers

From: Thomas Huth The css functions are only used from ioinst.c and other files that are only built for CONFIG_SOFTMMU. So we do not need the dummy wrappers for the CONFIG_USER_ONLY target in the cpu.h header. Signed-off-by: Thomas Huth Signed-off-by: Jens Freimann Reviewed-by: Jason J. Herne

[Qemu-devel] [PULL 04/11] s390x/ccw: fix oddity in machine class init

ccw_machine_class_init() uses ',' instead of ';' while initializing the class' fields. This is almost certainly a copy/paste error and, while legal C, rather on the unusual side. Just use ';' everywhere. Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck Signed-off-by: Jens Freimann Signed-o

[Qemu-devel] [PULL 07/11] s390x/kvm: avoid syscalls by syncing registers with kvm_run

From: David Hildenbrand We can avoid loads of syscalls when dropping to user space by storing the values of more registers directly within kvm_run. Support is added for: - ARCH0: CPU timer, clock comparator, TOD programmable register, guest breaking-event register, program parameter - P

[Qemu-devel] [PULL 08/11] s390/pci: add error event support

From: Frank Blaschka This patch adds support to generate s390 pci error events and makes use of it to support iota error handling. Signed-off-by: Frank Blaschka Signed-off-by: Cornelia Huck --- hw/s390x/s390-pci-bus.c | 50 --- hw/s390x/s390-pci-bus.h | 35 ++

[Qemu-devel] [PULL 11/11] s390x: update MAINTAINERS

Make sure the new pci support is sorted to the right maintainers. Acked-by: Christian Borntraeger Signed-off-by: Cornelia Huck --- MAINTAINERS |2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index bcb69e8..2792e63 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[Qemu-devel] [PULL 06/11] s390x/kvm: sync register support helper function

From: David Hildenbrand Let's unify the code to sync registers by moving the checks into a helper function can_sync_regs(). Signed-off-by: David Hildenbrand Signed-off-by: Jens Freimann Reviewed-by: Cornelia Huck Signed-off-by: Cornelia Huck --- target-s390x/kvm.c | 22 ---

Re: [Qemu-devel] [PATCH v3 2/4] serial: clean up THRE/TEMT handling

* Paolo Bonzini (pbonz...@redhat.com) wrote: > - assert THRE cleared and FIFO not empty (if enabled) before > sending a character. Also assert TEMT cleared, since it is > the combination of THRE && transmitter shift register empty. > > - raise THRI immediately after setting THRE > > - check THRE

[Qemu-devel] [PULL 02/11] s390: implement pci instructions

From: Frank Blaschka This patch implements the s390 pci instructions in qemu. It allows to access and drive pci devices attached to the s390 pci bus. Because of platform constrains devices using IO BARs are not supported. Also a device has to support MSI/MSI-X to run on s390. Signed-off-by: Fran

[Qemu-devel] [PULL 09/11] s390/pci: implement stpcifc instruction

From: Frank Blaschka This patch implements the last remaining s390 pci instruction to query the function information block. Signed-off-by: Frank Blaschka Signed-off-by: Cornelia Huck --- hw/s390x/s390-pci-bus.h |1 + hw/s390x/s390-pci-inst.c | 64 +++

Re: [Qemu-devel] [PATCH 02/16] block/parallels: allow to specify DiskDescriptor.xml instead of image file

On 15/12/14 13:45, Kevin Wolf wrote: Am 15.12.2014 um 09:27 hat Denis V. Lunev geschrieben: An explicit error check should make gcc happy and would also improve the error message for corrupt images without such an element (currently "Parallels images with snapshots are not supported"). +

Re: [Qemu-devel] [PATCH v3 1/4] serial: reset thri_pending on IER writes with THRI=0

On 15/12/2014 11:46, Dr. David Alan Gilbert wrote: > I can see this causes the thr_ipending to be 0 more of the time, but I don't > see why it's sufficient. > > If the transmitter has just transmitted it's last byte, then thr_ipending is > set > true by serial_xmit, however if there is a higher

Re: [Qemu-devel] [PATCH 10/16] block/parallels: add get_block_status

On 15/12/14 11:27, Denis V. Lunev wrote: From: Roman Kagan Implement VFS method for get_block_status to Parallels format driver. Signed-off-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Kevin Wolf CC: Stefan Hajnoczi --- block/parallels.c | 21 + 1

Re: [Qemu-devel] [PATCH 07/16] parallels: change copyright information in the image header

On 15/12/14 14:06, Kevin Wolf wrote: Am 15.12.2014 um 09:27 hat Denis V. Lunev geschrieben: Signed-off-by: Denis V. Lunev Acked-by: Roman Kagan Reviewed-by: Jeff Cody CC: Kevin Wolf CC: Stefan Hajnoczi --- block/parallels.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff -

Re: [Qemu-devel] [PATCH v3 2/4] serial: clean up THRE/TEMT handling

On 15/12/2014 12:40, Dr. David Alan Gilbert wrote: >> > do { >> > +assert(!(s->lsr & UART_LSR_TEMT)); >> > +assert(!(s->lsr & UART_LSR_THRE)); >> > + >> > if (s->tsr_retry <= 0) { >> > if (s->fcr & UART_FCR_FE) { >> > -if (fifo8_is_empty(

Re: [Qemu-devel] [PULL 0/3] Collected target-i386 patches

On 14 December 2014 at 23:00, Richard Henderson wrote: > I'm sure I haven't gotten all of them that have been outstanding > over the last couple of months, but at least here's a couple. > > > r~ > > > The following changes since commit 99c9c3cb24e566258a0a141178934f9cb5198842: > > Merge remote-t

Re: [Qemu-devel] [PATCH 10/16] block/parallels: add get_block_status

Am 15.12.2014 um 12:52 hat Denis V. Lunev geschrieben: > On 15/12/14 11:27, Denis V. Lunev wrote: > >From: Roman Kagan > > > >Implement VFS method for get_block_status to Parallels format driver. > > > >Signed-off-by: Roman Kagan > >Signed-off-by: Denis V. Lunev > >CC: Jeff Cody > >CC: Kevin Wo

Re: [Qemu-devel] [PATCH 11/16] block/parallels: add support for backing files

Am 15.12.2014 um 09:27 hat Denis V. Lunev geschrieben: > From: Roman Kagan > > Add backing file support to Parallels format driver. > > That said, I think backing file operations should end up in the generic > block layer, but that's a longer story... > > Signed-off-by: Roman Kagan > Signed-of

Re: [Qemu-devel] [PATCH 13/16] block/parallels: read disk size from XML if DiskDescriptor.xml is passed

Am 15.12.2014 um 09:27 hat Denis V. Lunev geschrieben: > as an image filename. This is preparational commit to read snapshot > information from XML. This is the only global parameter which will be > kept in BDRVParallelsState, the rest should be layered down into > snapshots information structure.

Re: [Qemu-devel] [PATCH 14/16] block/parallels: introduce ParallelsSnapshot data structure

Am 15.12.2014 um 09:27 hat Denis V. Lunev geschrieben: > In order to support snapshots of parallels images we should maintain > snapshots list in BDRVParallelsState. Snapshots actually forms tree. > Though, in read-only case, we do need to traverse only from current > snapshot leaf to the snapshot

[Qemu-devel] [PATCH] qga: add guest-set-admin-password command

Add a new 'guest-set-admin-password' command for changing the root/administrator password. This command is needed to allow OpenStack to support its API for changing the admin password on a running guest. Accepts either the raw password string: $ virsh -c qemu:///system qemu-agent-command f21x86_

[Qemu-devel] [PATCH v5 03/26] qcow2: Do not return new value after refcount update

qcow2_update_cluster_refcount() does not have any quick access to the new refcount value, it has to call qcow2_get_refcount(). Some callers do not need that new value at all, others call qcow2_get_refcount() themselves anyway (albeit in a different code path, which can however be easily changed), t

[Qemu-devel] [PATCH v5 00/26] qcow2: Support refcount orders != 4

As of version 3, the qcow2 file format supports different widths for refcount entries, ranging from 1 to 64 bit (only powers of two). Currently, qemu only supports 16 bit, which is the only width supported by version 2 (compat=0.10) images. This series adds support to qemu for all other valid refc

[Qemu-devel] [PATCH v5 02/26] qcow2: Add refcount_bits to format-specific info

Add the bit width of every refcount entry to the format-specific information. In contrast to lazy_refcounts and the corrupt flag, this should be always emitted, even for compat=0.10 although it does not support any refcount width other than 16 bits. This is because if a boolean is optional, one no

[Qemu-devel] [PATCH v5 06/26] qcow2: Use 64 bits for refcount values

Refcounts may have a width of up to 64 bits, so qemu should use the same width to represent refcount values internally. Signed-off-by: Max Reitz --- block/qcow2-cluster.c | 2 +- block/qcow2-refcount.c | 46 ++ block/qcow2.h | 4 ++-- 3 fil

[Qemu-devel] [PATCH v5 10/26] qcow2: Helper function for refcount modification

Since refcounts do not always have to be a uint16_t, all refcount blocks and arrays in memory should not have a specific type (thus they become pointers to void) and for accessing them, two helper functions are used (a getter and a setter). Those functions are called indirectly through function poi

[Qemu-devel] [PATCH v5 04/26] qcow2: Only return status from qcow2_get_refcount

Refcounts can theoretically be of type uint64_t; in order to be able to represent the full range, qcow2_get_refcount() cannot use a single variable to represent both all refcount values and also keep some values reserved for errors. One solution would be to add an Error pointer parameter to qcow2_

[Qemu-devel] [PATCH v5 05/26] qcow2: Use unsigned addend for update_refcount()

update_refcount() and qcow2_update_cluster_refcount() currently take a signed addend. At least one caller passes a value directly derived from an absolute refcount that should be reached ("l2_refcount - 1" in expand_zero_clusters_in_l1()). Therefore, the addend should be unsigned because unsigned o

[Qemu-devel] [PATCH v5 15/26] iotests: Prepare for refcount_bits option

Some tests do not work well with certain refcount widths (i.e. you cannot create internal snapshots with refcount_bits=1), so make those widths unsupported. Furthermore, add another filter to _filter_img_create in common.filter which filters out the refcount_bits value. This is necessary for test

[Qemu-devel] [PATCH v5 12/26] qcow2: Open images with refcount order != 4

No longer refuse to open images with a different refcount entry width than 16 bits; only reject images with a refcount width larger than 64 bits (which is prohibited by the specification). Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block/qcow2.c | 8 -

[Qemu-devel] [PATCH v5 01/26] qcow2: Add two new fields to BDRVQcowState

Add two new fields regarding refcount information (the bit width of every entry and the maximum refcount value) to the BDRVQcowState. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block/qcow2-refcount.c | 2 +- block/qcow2.c | 3 +++ block/qcow2.h

[Qemu-devel] [PATCH v5 08/26] qcow2: Refcount overflow and qcow2_alloc_bytes()

qcow2_alloc_bytes() may reuse a cluster multiple times, in which case the refcount is increased accordingly. However, if this would lead to an overflow the function should instead just not reuse this cluster and allocate a new one. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: St

[Qemu-devel] [PATCH v5 21/26] qcow2: Split upgrade/downgrade paths for amend

If the image version should be upgraded, that is the first we should do; if it should be downgraded, that is the last we should do. So split the version change block into an upgrade part at the start and a downgrade part at the end. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: S

[Qemu-devel] [PATCH v5 07/26] qcow2: Respect error in qcow2_alloc_bytes()

qcow2_update_cluster_refcount() may fail, and qcow2_alloc_bytes() should mind that case. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block/qcow2-refcount.c | 33 + 1 file changed, 21 insertions(+), 12 deletions(-) diff --gi

[Qemu-devel] [PATCH v5 13/26] qcow2: refcount_order parameter for qcow2_create2

Add a refcount_order parameter to qcow2_create2(), use that value for the image header and for calculating the size required for preallocation. For now, always pass 4. This addition requires changes to the calculation of the file size for the "full" and "falloc" preallocation modes. That in turn

[Qemu-devel] [PATCH v5 09/26] qcow2: Helper for refcount array reallocation

Add a helper function for reallocating a refcount array, independent of the refcount order. The newly allocated space is zeroed and the function handles failed reallocations gracefully. The helper function will always align the buffer size to a cluster boundary; if storing the refcounts in such an

[Qemu-devel] [PATCH v5 22/26] qcow2: Use intermediate helper CB for amend

If there is more than one time-consuming operation to be performed for qcow2_amend_options(), we need an intermediate CB which coordinates the progress of the individual operations and passes the result to the original status callback. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by

[Qemu-devel] [PATCH v5 11/26] qcow2: More helpers for refcount modification

Add helper functions for getting and setting refcounts in a refcount array for any possible refcount order, and choose the correct one during refcount initialization. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block/qcow2-refcount.c | 121

[Qemu-devel] [PATCH v5 19/26] qcow2: Use error_report() in qcow2_amend_options()

Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block/qcow2.c | 14 ++ tests/qemu-iotests/061.out | 14 +++--- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index dfdab18..c174a23

[Qemu-devel] [PATCH v5 16/26] qcow2: Allow creation with refcount order != 4

Add a creation option to qcow2 for setting the refcount order of images to be created, and respect that option's value. This breaks some test outputs, fix them. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block/qcow2.c | 20 + includ

[Qemu-devel] [PATCH v5 23/26] qcow2: Add function for refcount order amendment

Add a function qcow2_change_refcount_order() which allows changing the refcount order of a qcow2 image. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block/qcow2-refcount.c | 452 + block/qcow2.h | 4

[Qemu-devel] [PATCH v5 14/26] qcow2: Use symbolic macros in qcow2_amend_options

qcow2_amend_options() should not compare options against some inline strings but rather use the symbolic macros available for each of the creation options. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block/qcow2.c | 31 --- 1 fi

[Qemu-devel] [PATCH v5 20/26] qcow2: Use abort() instead of assert(false)

Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block/qcow2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index c174a23..258e0df 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -2729,9 +2729,9 @@ stati

[Qemu-devel] [PATCH v5 17/26] progress: Allow regressing progress

Progress may regress; this should be displayed correctly by qemu_progress_print(). While touching that area of code, drop the redundant parentheses in the same condition. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- util/qemu-progress.c | 3 ++- 1 file cha

[Qemu-devel] [PATCH v5 18/26] block: Add opaque value to the amend CB

Add an opaque value which is to be passed to the bdrv_amend_options() status callback. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block.c | 4 ++-- block/qcow2-cluster.c | 14 -- block/qcow2.c | 9 +

[Qemu-devel] Atomic Instructions - comments please

Comments please…. Choices for Atomic instructions: The current approach (for ARM at least) for Ld and St exclusive inside Qemu simply records the address and the value that atomic read instructions attempt to read from. When an atomic write happens, it checks the value and address remain the sa

[Qemu-devel] [PATCH v5 26/26] iotests: Add test for different refcount widths

Add a test for conversion between different refcount widths and errors specific to certain widths (i.e. snapshots with refcount_bits=1). Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/qemu-iotests/112 | 296 + tests/qemu-iotests/112.ou

[Qemu-devel] [PATCH v5 24/26] qcow2: Invoke refcount order amendment function

Make use of qcow2_change_refcount_order() to support changing the refcount order with qemu-img amend. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block/qcow2.c | 44 +++- 1 file changed, 35 insertions(+), 9 deletions

[Qemu-devel] [PATCH v5 25/26] qcow2: Point to amend function in check

If a reference count is not representable with the current refcount order, the image check should point to qemu-img amend for increasing the refcount order. However, qemu-img amend needs write access to the image which cannot be provided if the image is marked corrupt; and the image check will not

Re: [Qemu-devel] [PATCH v3 2/5] raw-posix: Factor block size detection out of raw_probe_alignment()

Ekaterina Tumanova writes: > Put it in new probe_logical_blocksize(). > > Signed-off-by: Ekaterina Tumanova > --- > block/raw-posix.c | 44 +++- > 1 file changed, 27 insertions(+), 17 deletions(-) > > diff --git a/block/raw-posix.c b/block/raw-posix.c > i

Re: [Qemu-devel] [PATCH v3 1/5] block: add bdrv functions for geometry and blocksize

Ekaterina Tumanova writes: > Add driver functions for geometry and blocksize detection > > Signed-off-by: Ekaterina Tumanova > --- > block.c | 35 +++ > include/block/block.h | 13 + > include/block/block_int.h | 5 + > 3 fi

Re: [Qemu-devel] TCG multithread plan.

(please note the address of the match list server is mt...@listserver.greensocs.com ) > On 9 Dec 2014, at 18:57, Lluís Vilanova wrote: > > Frederic Konrad writes: > >> Hi everybody, >> Here is the plan we will follow: > >> We will be focusing - from the

Re: [Qemu-devel] [PULL 00/11] s390x changes for 2.3

; > are available in the git repository at: > > > git://github.com/cohuck/qemu tags/s390x-20141215 > > for you to fetch changes up to 5a9403c9bc36aaa3431083f152251e775c38b386: > > s390x: update MAINTAINERS (2014-12-15 10:43:17 +0100) Hi; I'm afraid this doesn't bui

Re: [Qemu-devel] Atomic Instructions - comments please

On 15/12/2014 13:56, Mark Burton wrote: > A third proposal is to mark pages as IO when a ld/st ex is performed to > them. Then to augment the memory API to indicate that a ld/st ex is in > hand, allowing the memory chain to decide if it should allow the write > or cause a fault. This would seem t

  1   2   3   4   >