Re: [Qemu-devel] [PATCH 2/2] acpi-build: Make DPRINTF working for acpi-build

2014-11-13 Thread Markus Armbruster
writes: > From: Gonglei > > Signed-off-by: Gonglei > --- > hw/i386/acpi-build.c | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 4ab44bf..8cec9aa 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/

Re: [Qemu-devel] [PATCH 0/4] qom: Replace "automatic arrayification"

2014-11-13 Thread Markus Armbruster
Paolo Bonzini writes: > On 12/11/2014 18:08, Markus Armbruster wrote: >> "Automatic arrayification" is a convenience feature for creating a >> bunch of properties with a common type, accessors and so forth, named >> in a peculiar way: "foo[0]", "foo[1]", ... It's implemented by making >> propert

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-13 Thread Gerd Hoffmann
Hi, > My understanding from an IRC conversation yesterday was that at > least some of these ACPI blobs contain data which has to be constructed > at the point it is requested (ie is not fixed at the point when > QEMU starts up), because OVMF will do: > * startup > * prod some parts of the hard

Re: [Qemu-devel] [PATCH 2/2] acpi-build: Make DPRINTF working for acpi-build

2014-11-13 Thread Gonglei
On 2014/11/13 16:01, Markus Armbruster wrote: > writes: > >> From: Gonglei >> >> Signed-off-by: Gonglei >> --- >> hw/i386/acpi-build.c | 18 -- >> 1 file changed, 12 insertions(+), 6 deletions(-) >> >> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c >> index 4ab44bf..

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-13 Thread Gerd Hoffmann
On Mi, 2014-11-12 at 16:01 +0100, Claudio Fontana wrote: > I ask because on OSv at the moment, the situation is that for x86 we > don't need to reprogram anything on PCI, > as everything is already nicely set up by the time the guest starts, > and thus the BAR addresses can be read directly. > On A

Re: [Qemu-devel] [PATCH 2/2] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP

2014-11-13 Thread Markus Armbruster
Fam Zheng writes: > On Wed, 11/12 20:27, Markus Armbruster wrote: >> Commit 5500316 (May 2012) implemented raw_co_is_allocated() as >> follows: >> >> 1. If defined(CONFIG_FIEMAP), use the FS_IOC_FIEMAP ioctl >> >> 2. Else if defined(SEEK_HOLE) && defined(SEEK_DATA), use lseek() >> >> 3. Else p

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-13 Thread Gerd Hoffmann
Hi, > The PowerPC folks are using u-boot as the firmware. I know Peter > disagrees, but I don't understand why so I'll throw this up for > discussion too; it is definitely lighter-weight than UEFI. Would that > make sense for ARM? Played around with that. Look here: https://www.kraxel.org/c

Re: [Qemu-devel] [PATCH] xen_disk: fix unmapping of persistent grants

2014-11-13 Thread Roger Pau Monné
El 12/11/14 a les 18.41, Stefano Stabellini ha escrit: > On Wed, 12 Nov 2014, Roger Pau Monne wrote: >> This patch fixes two issues with persistent grants and the disk PV backend >> (Qdisk): >> >> - Don't use batch mappings when using persistent grants, doing so prevents >>unmapping single gra

Re: [Qemu-devel] [PATCH 2/2] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP

2014-11-13 Thread Max Reitz
On 2014-11-12 at 20:27, Markus Armbruster wrote: Commit 5500316 (May 2012) implemented raw_co_is_allocated() as follows: 1. If defined(CONFIG_FIEMAP), use the FS_IOC_FIEMAP ioctl 2. Else if defined(SEEK_HOLE) && defined(SEEK_DATA), use lseek() 3. Else pretend there are no holes Later on, raw_

Re: [Qemu-devel] [PATCH 1/2] raw-posix: Fix comment for raw_co_get_block_status()

2014-11-13 Thread Max Reitz
On 2014-11-12 at 20:27, Markus Armbruster wrote: Missed in commit 705be72. Signed-off-by: Markus Armbruster --- block/raw-posix.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index e100ae2..706d3c0 100644 --- a/block/raw-posix.c

Re: [Qemu-devel] [PATCH 2/2] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP

2014-11-13 Thread Markus Armbruster
Eric Blake writes: > On 11/12/2014 01:27 PM, Markus Armbruster wrote: >> Commit 5500316 (May 2012) implemented raw_co_is_allocated() as >> follows: >> > >> Thus, the FIEMAP code executes rarely. Makes it a nice hidey-hole for >> bugs. Worse, bugs hiding there can theoretically bite even on a h

Re: [Qemu-devel] [PATCH 0/2] raw-posix: Get rid of FIEMAP

2014-11-13 Thread Markus Armbruster
Paolo Bonzini writes: > On 12/11/2014 20:27, Markus Armbruster wrote: >> See PATCH 2/2 for rationale. >> >> Would you like this included in 2.2? >> >> Markus Armbruster (2): >> raw-posix: Fix comment for raw_co_get_block_status() >> raw-posix: SEEK_HOLE suffices, get rid of FIEMAP >> >> b

Re: [Qemu-devel] [PATCH 2/2] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP

2014-11-13 Thread Markus Armbruster
Max Reitz writes: > On 2014-11-12 at 20:27, Markus Armbruster wrote: >> Commit 5500316 (May 2012) implemented raw_co_is_allocated() as >> follows: >> >> 1. If defined(CONFIG_FIEMAP), use the FS_IOC_FIEMAP ioctl >> >> 2. Else if defined(SEEK_HOLE) && defined(SEEK_DATA), use lseek() >> >> 3. Else p

Re: [Qemu-devel] [RFC PATCH] virtio-mmio: support for multiple irqs

2014-11-13 Thread Shannon Zhao
On 2014/11/13 2:33, Pawel Moll wrote: > On Wed, 2014-11-12 at 08:32 +, Shannon Zhao wrote: >> On 2014/11/11 23:11, Pawel Moll wrote: >>> On Tue, 2014-11-04 at 09:35 +, Shannon Zhao wrote: As the current virtio-mmio only support single irq, so some advanced features such as vhost-n

Re: [Qemu-devel] runtime configurable semihosting

2014-11-13 Thread Liviu Ionescu
On 12 Nov 2014, at 21:17, Liviu Ionescu wrote: > >> semihosting ... be runtime configurable on this, I think. > > I took a quick look at the syntax of command options and monitor commands, > and I would suggest the following: > > - extend the option "-semihosting" with an optional "target=na

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-13 Thread Claudio Fontana
On 12.11.2014 19:10, Peter Maydell wrote: > On 12 November 2014 09:08, Claudio Fontana wrote: >> As mentioned by others, I'd rather see an implementation of ACPI in QEMU >> which >> learns from the experience of X86 (and possibly shares some code if >> possible), >> rather than going in a differ

Re: [Qemu-devel] [PATCH v1 01/15] android-console: Fix goldfish audio misnaming

2014-11-13 Thread Alex Bennée
Greg Bellows writes: > Replaced goldfish_audio misnaming to goldfish_battery where appropriate in > goldfish_battery.c Ahh good 'ole copy pasta bugs ;-) This will probably be worth squash merging when we clean-up the tree. > > Signed-off-by: Greg Bellows > --- > hw/misc/goldfish_battery.c |

Re: [Qemu-devel] [PATCH v1 06/15] android-console: Add missing hw_has_battery prop

2014-11-13 Thread Alex Bennée
Greg Bellows writes: > Added the missing hw_has_battery property to the Goldfish batter state. This > property indicates whether the device has a battery and controls whether some > power commands are available. > > In the Android emulator this property is acquired from the AVD for the device.

Re: [Qemu-devel] [block PATCH v2 0/3] AHCI device fixes

2014-11-13 Thread Stefan Hajnoczi
On Fri, Oct 31, 2014 at 04:03:36PM -0400, John Snow wrote: > This is a v2 patch series that collects patches 3, 4 and 5 > from the v1 series that was only partially merged. > > This series, as a subset, generally cleans up the usage and > handling of the scatter-gather list implementation in QEMU

Re: [Qemu-devel] [PATCH 4/4] Revert "qom: Add automatic arrayification to object_property_add()"

2014-11-13 Thread Paolo Bonzini
On 12/11/2014 23:47, Peter Maydell wrote: > On 12 November 2014 22:25, Paolo Bonzini wrote: > > The plan was to move [*] down into the devices. Devices that do not > > need to arrayify properties (e.g. most qdev-ified devices) can then skip > > the [*] and have nicer names. > > Qdev devices hav

Re: [Qemu-devel] [PATCH v1 07/15] android-console: Init the battery ID state field

2014-11-13 Thread Alex Bennée
Greg Bellows writes: > Adds initialization of the battery ID field so that it is discoverable by name > (ID) when needed by power commands. > > Signed-off-by: Greg Bellows > --- > hw/misc/goldfish_battery.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/hw/misc/goldfish_battery.

Re: [Qemu-devel] [PATCH 0/5] ahci: fis decomposition improvements

2014-11-13 Thread Stefan Hajnoczi
On Mon, Nov 03, 2014 at 06:56:14PM -0500, John Snow wrote: > This patch series may require, and is based on another > AHCI series pending on-list: > http://lists.gnu.org/archive/html/qemu-devel/2014-10/msg04143.html > > This series aims to improve the way that handle_cmd > reads and behaves in int

Re: [Qemu-devel] [PATCH 0/4] qom: Replace "automatic arrayification"

2014-11-13 Thread Paolo Bonzini
On 13/11/2014 09:08, Markus Armbruster wrote: >> > >> > I like the idea, but the API is just too ugly. :( Unfortunately I have >> > nothing better to propose. > For what it's worth, three out of four uses already need to free, > because they append "[*]" to an argument string. Yes, your API wor

Re: [Qemu-devel] [Spice-devel] screen freezed for 2-3 minutes on spice connect on xen windows 7 domU's with qxl after save/restore

2014-11-13 Thread Fabio Fantoni
Il 19/09/2014 15:18, Fabio Fantoni ha scritto: Il 12/09/2014 16:46, Fabio Fantoni ha scritto: Il 08/07/2014 12:34, Fabio Fantoni ha scritto: Il 08/07/2014 12:06, Fabio Fantoni ha scritto: Il 08/07/2014 10:53, David Jaša ha scritto: Hi, On Út, 2014-07-08 at 10:13 +0200, Fabio Fantoni wrote: O

[Qemu-devel] [PATCH v2 4/4] raw-posix: Clean up around raw_co_get_block_status()

2014-11-13 Thread Markus Armbruster
try_seek_hole() doesn't really seek to a hole, it tries to find out whether its argument is in a hole or not, and where the hole or non-hole ends. Rename to find_allocation() and add a proper function comment. Using arguments passed by reference like local variables is a bad habit. Only assign t

[Qemu-devel] [PATCH v2 1/4] raw-posix: Fix comment for raw_co_get_block_status()

2014-11-13 Thread Markus Armbruster
Missed in commit 705be72. Signed-off-by: Markus Armbruster Reviewed-by: Paolo Bonzini Reviewed-by: Fam Zheng Reviewed-by: Eric Blake Reviewed-by: Max Reitz --- block/raw-posix.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index

[Qemu-devel] [PATCH v2 2/4] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP

2014-11-13 Thread Markus Armbruster
Commit 5500316 (May 2012) implemented raw_co_is_allocated() as follows: 1. If defined(CONFIG_FIEMAP), use the FS_IOC_FIEMAP ioctl 2. Else if defined(SEEK_HOLE) && defined(SEEK_DATA), use lseek() 3. Else pretend there are no holes Later on, raw_co_is_allocated() was generalized to raw_co_get_blo

[Qemu-devel] [PATCH v2 3/4] raw-posix: Fix try_seek_hole()'s handling of SEEK_DATA failure

2014-11-13 Thread Markus Armbruster
When SEEK_HOLE tells us we're in a hole, we try SEEK_DATA to find its end. When that fails, we pretend the hole extends to the end of file. Wrong. Except when SEEK_END fails, we screw up and claim it extends to offset -1. More wrong. Fortunately, these seeks are very unlikely to fail. Fix it a

[Qemu-devel] [PATCH v2 0/4] raw-posix: Get rid of FIEMAP, and more

2014-11-13 Thread Markus Armbruster
See PATCH 2/4 for why FIEMAP needs to go. Minor fixes in 1+3/4, cleanup in 4/4. Would you like this included in 2.2? Maybe just the first three? v2: * PATCH 1 unchanged * PATCH 2 revised and split up [Paolo, Fam, Eric, Max] Markus Armbruster (4): raw-posix: Fix comment for raw_co_get_block_s

Re: [Qemu-devel] [PATCH v2 2/4] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP

2014-11-13 Thread Max Reitz
On 2014-11-13 at 11:17, Markus Armbruster wrote: Commit 5500316 (May 2012) implemented raw_co_is_allocated() as follows: 1. If defined(CONFIG_FIEMAP), use the FS_IOC_FIEMAP ioctl 2. Else if defined(SEEK_HOLE) && defined(SEEK_DATA), use lseek() 3. Else pretend there are no holes Later on, raw_

Re: [Qemu-devel] [PATCH v1 15/15] android-console: Add power capacity command

2014-11-13 Thread Alex Bennée
Greg Bellows writes: > Add the Android emulator console "power capacity" command along associated > help > messages. The "capacity" command allows the battery capacity of the device to > be manipulated. > > Signed-off-by: Greg Bellows > --- > android-commands.h | 7 +++ > android-consol

Re: [Qemu-devel] [PATCH v2 3/4] raw-posix: Fix try_seek_hole()'s handling of SEEK_DATA failure

2014-11-13 Thread Max Reitz
On 2014-11-13 at 11:17, Markus Armbruster wrote: When SEEK_HOLE tells us we're in a hole, we try SEEK_DATA to find its end. When that fails, we pretend the hole extends to the end of file. Wrong. Except when SEEK_END fails, we screw up and claim it extends to offset -1. More wrong. Fortunatel

[Qemu-devel] [PATCH 0/2] ahci: small cleanups

2014-11-13 Thread Stefan Hajnoczi
Two small cleanups for QEMU 2.3: 1. Avoid DEBUG_AHCI bitrot 2. Use FIS type constants instead of magic numbers See commit descriptions for details. Stefan Hajnoczi (2): ahci: avoid #ifdef DEBUG_AHCI bitrot ahci: replace SATA FIS type magic numbers with constants hw/ide/ahci.c | 24

[Qemu-devel] [PATCH 2/2] ahci: replace SATA FIS type magic numbers with constants

2014-11-13 Thread Stefan Hajnoczi
SATA 3.0 "10.3.1 FIS Type values" defines the constants used to differentiate between FIS types. Signed-off-by: Stefan Hajnoczi --- hw/ide/ahci.c | 6 +++--- hw/ide/ahci.h | 5 - 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 3f1e39e..e4cd7

[Qemu-devel] [PULL for-2.2 2/2] QMP/input-send-event: make console parameter optional

2014-11-13 Thread Gerd Hoffmann
From: Amos Kong The 'QemuConsole' is the input source for handler, we share some input handlers to process the input events from different QemuConsole. Normally we only have one set of keyboard, mouse, usbtablet, etc. The devices have different mask, it's fine to just checking mask to insure tha

[Qemu-devel] [PATCH 1/2] ahci: avoid #ifdef DEBUG_AHCI bitrot

2014-11-13 Thread Stefan Hajnoczi
Debug code using #ifdef is susceptible to bitrot because the compiler never checks the debug code. This is easy to avoid, change the DPRINTF() macro to use if (DEBUG_AHCI) and always give it a 0 or 1 value. This also allows us to drop an #ifdef DEBUG_AHCI in ahci_start_dma() since the compiler ca

[Qemu-devel] [PULL for-2.2 1/2] QMP/input-send-event: update document of union InputEvent

2014-11-13 Thread Gerd Hoffmann
From: Amos Kong Signed-off-by: Amos Kong Reviewed-by: Eric Blake Signed-off-by: Gerd Hoffmann --- qapi-schema.json | 5 + 1 file changed, 5 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index 24379ab..7e7468f 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3231,

Re: [Qemu-devel] [PATCH] mips: Fix the 64-bit case for microMIPS MOVE16 and MOVEP

2014-11-13 Thread Leon Alrae
On 12/11/2014 18:46, Maciej W. Rozycki wrote: > On Wed, 12 Nov 2014, Andreas Färber wrote: > >> Please consistently use "target-mips: " when that's what you're >> touching. (For hw/mips/ it's less consistent what to use.) > > Sure. What about MIPS changes that span files contained within > tar

Re: [Qemu-devel] [PATCH for-2.2 1/2] QMP/input-send-event: update document of union InputEvent

2014-11-13 Thread Gerd Hoffmann
> >> +# @btn: Input event of pointer bottons > > s/bottons/buttons/ before my R-b applies (maintainer could opt to do > this without needing a v2) Fixed up, queued, pull req sent. thanks, Gerd

Re: [Qemu-devel] [PATCH v2 4/4] raw-posix: Clean up around raw_co_get_block_status()

2014-11-13 Thread Max Reitz
On 2014-11-13 at 11:17, Markus Armbruster wrote: try_seek_hole() doesn't really seek to a hole, it tries to find out whether its argument is in a hole or not, and where the hole or non-hole ends. Rename to find_allocation() and add a proper function comment. Using arguments passed by reference

[Qemu-devel] [PULL for-2.2 0/2] QMP/input-send-event: make console parameter optional

2014-11-13 Thread Gerd Hoffmann
it repository at: git://git.kraxel.org/qemu tags/pull-input-20141113-1 for you to fetch changes up to 51fc44768a5b71ad78fa40e609a58f71ed62775a: QMP/input-send-event: make console parameter optional (2014-11-13 11:06:40 +0100) Q

Re: [Qemu-devel] [PATCH v2 6/9] block: Read only one sector for format probing

2014-11-13 Thread Stefan Hajnoczi
On Mon, Nov 10, 2014 at 03:48:52PM +0100, Max Reitz wrote: > On 2014-11-07 at 20:39, Kevin Wolf wrote: > >The only image format driver that even potentially accesses anything > >after 512 bytes in its bdrv_probe() implementation is VMDK, which reads > >a plain-text descriptor file. In practice, the

Re: [Qemu-devel] [PATCH v4 14/21] target-mips: add AUI, LSA and PCREL instruction families

2014-11-13 Thread Leon Alrae
On 12/11/2014 21:07, Paolo Bonzini wrote: > > > On 08/10/2014 12:55, Leon Alrae wrote: >> case OPC_LUI: >> -tcg_gen_movi_tl(cpu_gpr[rt], imm << 16); >> -MIPS_DEBUG("lui %s, " TARGET_FMT_lx, regnames[rt], uimm); >> +if (rs != 0 && (ctx->insn_flags & ISA_MIPS32R6)) { >>

[Qemu-devel] [Bug 1258168] Re: QEMU fails to build on CentOS 5.10 with --disable-pie reporting "/usr/bin/ld: -f may not be used without -shared "

2014-11-13 Thread Paolo Bonzini
Can you please test this patch? ** Patch added: "patch to fix the bug" https://bugs.launchpad.net/qemu/+bug/1258168/+attachment/4259802/+files/libtool-sp.patch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpa

Re: [Qemu-devel] [PATCH v2 7/9] raw: Prohibit dangerous writes for probed images

2014-11-13 Thread Stefan Hajnoczi
On Fri, Nov 07, 2014 at 08:39:23PM +0100, Kevin Wolf wrote: > diff --git a/block/raw_bsd.c b/block/raw_bsd.c > index 401b967..462498e 100644 > --- a/block/raw_bsd.c > +++ b/block/raw_bsd.c > @@ -58,8 +58,52 @@ static int coroutine_fn raw_co_readv(BlockDriverState *bs, > int64_t sector_num, > stat

Re: [Qemu-devel] [PATCH v2 1/9] qemu-io: Allow explicitly specifying format

2014-11-13 Thread Stefan Hajnoczi
On Fri, Nov 07, 2014 at 08:39:17PM +0100, Kevin Wolf wrote: > This adds a -f option to qemu-io which allows to explicitly specify the > block driver to use for the given image. > > Signed-off-by: Kevin Wolf > --- > qemu-io.c | 28 > 1 file changed, 20 insertions(+),

Re: [Qemu-devel] [PATCH v2 4/9] qtests: Specify image format explicitly

2014-11-13 Thread Stefan Hajnoczi
On Fri, Nov 07, 2014 at 08:39:20PM +0100, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > tests/ahci-test.c | 3 ++- > tests/bios-tables-test.c | 2 +- > tests/drive_del-test.c| 2 +- > tests/fdc-test.c | 2 +- > tests/hd-geo-test.c | 2 +- > tests/i440fx-test.c

Re: [Qemu-devel] [PATCH v2 8/9] qemu-iotests: Fix stderr handling in common.qemu

2014-11-13 Thread Stefan Hajnoczi
On Fri, Nov 07, 2014 at 08:39:24PM +0100, Kevin Wolf wrote: > The original intention was to pipe stderr of qemu into $fifo_out. > However, the redirections were specified in the wrong order for this. > This patch fixes it. > > Now qemu's output on stderr can be retrieved with _send_qemu_cmd, which

Re: [Qemu-devel] [PATCH v2 2/9] qemu-iotests: Use qemu-io -f $IMGFMT

2014-11-13 Thread Stefan Hajnoczi
On Fri, Nov 07, 2014 at 08:39:18PM +0100, Kevin Wolf wrote: > This patch changes $QEMU_IO so that all tests by default pass a format > argument to qemu-io. > > There are a few cases where -f $IMGFMT is not wanted because it selects > the wrong driver or json: filenames including a driver are used.

Re: [Qemu-devel] [PATCH v2 5/9] block: Factor bdrv_probe_all() out of find_image_format()

2014-11-13 Thread Stefan Hajnoczi
On Fri, Nov 07, 2014 at 08:39:21PM +0100, Kevin Wolf wrote: > From: Markus Armbruster > > Signed-off-by: Markus Armbruster > Signed-off-by: Kevin Wolf > --- > block.c | 45 - > 1 file changed, 32 insertions(+), 13 deletions(-) Reviewed-by: Stefan Ha

Re: [Qemu-devel] [PATCH v2 0/9] raw: Prohibit dangerous writes for probed images

2014-11-13 Thread Stefan Hajnoczi
On Fri, Nov 07, 2014 at 08:39:16PM +0100, Kevin Wolf wrote: > See the commit message of patch 7 for the why and how. This series > will probably be only part of the solution and doesn't mean that we > should stop looking for other patches which improve different parts of > the problem. > > See the

Re: [Qemu-devel] [PATCH v2 3/9] qemu-iotests: Add qemu-io format option in Python tests

2014-11-13 Thread Stefan Hajnoczi
On Fri, Nov 07, 2014 at 08:39:19PM +0100, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/030 | 22 +++--- > tests/qemu-iotests/040 | 32 > tests/qemu-iotests/055 | 18 +- > 3 files changed, 36 insertions(+)

Re: [Qemu-devel] [PATCH v2 9/9] qemu-iotests: Test writing non-raw image headers to raw image

2014-11-13 Thread Stefan Hajnoczi
On Fri, Nov 07, 2014 at 08:39:25PM +0100, Kevin Wolf wrote: > This is forbidden if the raw driver was probed. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/109 | 100 ++ > tests/qemu-iotests/109.out | 149 > +

Re: [Qemu-devel] [PATCH 4/4] Revert "qom: Add automatic arrayification to object_property_add()"

2014-11-13 Thread Peter Maydell
On 13 November 2014 10:05, Paolo Bonzini wrote: > > > On 12/11/2014 23:47, Peter Maydell wrote: >> On 12 November 2014 22:25, Paolo Bonzini wrote: >> > The plan was to move [*] down into the devices. Devices that do not >> > need to arrayify properties (e.g. most qdev-ified devices) can then ski

Re: [Qemu-devel] seabios 1.7.5.1 stable release -- last call for patches

2014-11-13 Thread Gerd Hoffmann
On Mo, 2014-11-10 at 11:40 +0100, Gerd Hoffmann wrote: > I'm busy preparing a 1.7.5.1 stable release for seabios, to be > released > within the next few days, so we can include it into the upcoming qemu > 2.2 release. Release tagged & pushed, tarball uploaded, qemu update will follow shortly. che

Re: [Qemu-devel] [PATCH v3 4/4] target-ppc: Handle ibm, nmi-register RTAS call

2014-11-13 Thread David Gibson
On Thu, Nov 13, 2014 at 11:28:30AM +0530, Aravinda Prasad wrote: > > > On Thursday 13 November 2014 09:22 AM, David Gibson wrote: > > On Tue, Nov 11, 2014 at 12:14:31PM +0530, Aravinda Prasad wrote: > >> On Tuesday 11 November 2014 08:46 AM, David Gibson wrote: > >>> On Wed, Nov 05, 2014 at 12:43

Re: [Qemu-devel] [PATCH] block: Fix max nb_sectors in bdrv_make_zero

2014-11-13 Thread Stefan Hajnoczi
On Mon, Nov 10, 2014 at 03:07:44PM +0800, Fam Zheng wrote: > In bdrv_rw_co we report -EINVAL for nb_sectors > INT_MAX / > BDRV_SECTOR_SIZE, so a caller shouldn't exceed it. > > Signed-off-by: Fam Zheng > --- > block.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks, applied t

[Qemu-devel] [PULL for-2.2 0/1] update seabios to 1.7.5.1 stable release

2014-11-13 Thread Gerd Hoffmann
(2014-11-10 16:28:51 +) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-seabios-1.7.5.1-20141113-1 for you to fetch changes up to 953ea14d66371f239f80e5d14191467b00d82439: update seabios to 1.7.5.1 stable release (2014-11-13 11:5

[Qemu-devel] [PULL for-2.2 1/1] update seabios to 1.7.5.1 stable release

2014-11-13 Thread Gerd Hoffmann
git shortlog since 1.7.5: Hannes Reinecke (1): megasas: read addional PCI I/O bar Kevin O'Connor (5): boot: Change ":rom%d" boot order rom instance to ":rom%x" vgabios: Return from handle_1011() if handler found. Don't enable thread preemption during S3 resume vga option r

Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

2014-11-13 Thread Stefan Hajnoczi
On Wed, Nov 12, 2014 at 06:48:18PM +, Gary Hook wrote: > -return qemu_ftell(f) - last_ftell; > +delta_ftell = qemu_ftell(f) - last_ftell; > +return( (delta_ftell > 0) ? 1 : (delta_ftell < 0) ? -1 : 0 ); Good find! Please don't nest the ternary operator, it is hard to read. if (de

Re: [Qemu-devel] [PATCH] virtio-bus: avoid breaking build when open DEBUG switch

2014-11-13 Thread Stefan Hajnoczi
On Thu, Nov 13, 2014 at 10:39:32AM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > Signed-off-by: Gonglei > --- > hw/virtio/virtio-bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi pgpeHiBx0_nBT.pgp Description: PGP signature

[Qemu-devel] [PATCH 1/3] pc-dimm: add a function to calculate VM's current RAM size

2014-11-13 Thread zhanghailiang
The global parameter 'ram_size' does not take into account the hotplugged memory. In some codes, we use 'ram_size' as current VM's real RAM size, which is not correct. Add function 'get_current_ram_size' to calculate VM's current RAM size, it will enumerate present memory devices and also plus ra

[Qemu-devel] [PATCH 2/3] virtio-balloon: Fix balloon not working correctly when hotplug memory

2014-11-13 Thread zhanghailiang
When do memory balloon, it takes the 'ram_size' as the VM's current ram size, But 'ram_size' is the startup configured ram size, it does not take into account the hotplugged memory. As a result, the balloon result will be confused. Steps to reproduce: (1)Start VM: qemu -m size=1024,slots=4,maxmem=

[Qemu-devel] [PATCH 3/3] virtio-balloon: Add some trace events

2014-11-13 Thread zhanghailiang
Add some trace events for easier debugging Signed-off-by: zhanghailiang --- hw/virtio/virtio-balloon.c | 6 ++ trace-events | 4 2 files changed, 10 insertions(+) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index 41b24c9..8a48d2a 100644 --- a/hw/v

[Qemu-devel] [PATCH 0/3] fix bug about balloon working incorrect when hotplug memeory

2014-11-13 Thread zhanghailiang
Patch 1 and 2 mainly fix bug about balloon not working correctly when we do hotplug memory. It takes 'ram_size' as VM's real RAM size which is wrong after we hotplug memory. This bug exists since we begin to support hotplug memory, and it is better to fix it. Patch 3 add some trace events, it hel

Re: [Qemu-devel] [PATCH] virtio-bus: avoid breaking build when open DEBUG switch

2014-11-13 Thread Stefan Hajnoczi
On Thu, Nov 13, 2014 at 10:39:32AM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > Signed-off-by: Gonglei > --- > hw/virtio/virtio-bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/virtio/virtio-bus.c b/hw/virtio/virtio-bus.c > index eb77019..dfd2d8c 1

Re: [Qemu-devel] [PATCH] virtio-net: correctly advertise host features

2014-11-13 Thread Stefan Hajnoczi
On Thu, Nov 13, 2014 at 01:55:45PM +0800, Jason Wang wrote: > We should not advertise the feature that depends on ctrl vq is it was not > enabled. And not advertise the VIRTIO_NET_F_CTRL_RX_EXTRA is s/is/if/ > VIRTIO_NET_F_CTRL_RX is not enabled. s/is/it/ These can be fixed up while merging.

Re: [Qemu-devel] when to bdrv_co_flush()?

2014-11-13 Thread Stefan Hajnoczi
On Mon, Nov 10, 2014 at 12:41:45PM +0800, lihuiba wrote: > bdrv_co_flush() will flush all cached data to persistent storage, and I'm > wondering whether guest sync() will eventually trigger bdrv_co_flush() be > called. virtio-blk and other emulated storage controllers use bdrv_aio_flush() to impl

Re: [Qemu-devel] Is there a way for passing parameter directly to a module

2014-11-13 Thread Stefan Hajnoczi
On Sun, Nov 09, 2014 at 04:41:17PM +, Lior Nahmanson wrote: > Is there a way for passing a parameter directly to a module (i.e. device > driver within QEMU), for example file path (when I am working at Full system > emulation)? > My goal is to have a device emulation which will be able to rea

Re: [Qemu-devel] [PATCH 2/2] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP

2014-11-13 Thread Kevin Wolf
Am 13.11.2014 um 00:25 hat Eric Blake geschrieben: > On 11/12/2014 01:27 PM, Markus Armbruster wrote: > > +/* in hole, end not yet known */ > > +offs = lseek(s->fd, start, SEEK_DATA); > > +if (offs < 0) { > > +/* no idea where the hole ends, give up (unlikely to happen) */ > > +

Re: [Qemu-devel] [RFC PATCH v4 06/25] cpu-exec: reset exception_index correctly

2014-11-13 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 07/11/2014 11:32, Pavel Dovgalyuk wrote: > > Exception index is reset at every entry at every entry into cpu_exec() > > function. This may cause missing the exceptions while replaying them. > > This patch move

Re: [Qemu-devel] [PATCH] xen_disk: fix unmapping of persistent grants

2014-11-13 Thread Kevin Wolf
Am 12.11.2014 um 18:41 hat Stefano Stabellini geschrieben: > On Wed, 12 Nov 2014, Roger Pau Monne wrote: > > This patch fixes two issues with persistent grants and the disk PV backend > > (Qdisk): > > > > - Don't use batch mappings when using persistent grants, doing so prevents > >unmapping

Re: [Qemu-devel] [PATCH 2/2] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP

2014-11-13 Thread Max Reitz
On 2014-11-13 at 12:40, Kevin Wolf wrote: Am 13.11.2014 um 00:25 hat Eric Blake geschrieben: On 11/12/2014 01:27 PM, Markus Armbruster wrote: +/* in hole, end not yet known */ +offs = lseek(s->fd, start, SEEK_DATA); +if (offs < 0) { +/* no idea where the hole ends, give up (

Re: [Qemu-devel] [PATCH v3 4/4] target-ppc: Handle ibm, nmi-register RTAS call

2014-11-13 Thread Aravinda Prasad
On Thursday 13 November 2014 04:02 PM, David Gibson wrote: > On Thu, Nov 13, 2014 at 11:28:30AM +0530, Aravinda Prasad wrote: >> >> >> On Thursday 13 November 2014 09:22 AM, David Gibson wrote: >>> On Tue, Nov 11, 2014 at 12:14:31PM +0530, Aravinda Prasad wrote: On Tuesday 11 November 2014 0

Re: [Qemu-devel] [PATCH] virtio-bus: avoid breaking build when open DEBUG switch

2014-11-13 Thread Gonglei
On 2014/11/13 19:27, Stefan Hajnoczi wrote: > On Thu, Nov 13, 2014 at 10:39:32AM +0800, arei.gong...@huawei.com wrote: >> From: Gonglei >> >> Signed-off-by: Gonglei >> --- >> hw/virtio/virtio-bus.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/virtio/virtio-bus.

Re: [Qemu-devel] [PULL for-2.2 0/3] usb bugfixes for 2.2

2014-11-13 Thread Peter Maydell
On 12 November 2014 15:13, Gerd Hoffmann wrote: > Hi, > > usb patch queue with three little fixes. > > please pull, > Gerd > > The following changes since commit 558c2c8ddfb165a36eb95dc93125c04829d68aa7: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2014

Re: [Qemu-devel] [PATCH] qcow2-cache: conditionally call bdrv_flush() in qcow2_cache_flush()

2014-11-13 Thread Stefan Hajnoczi
On Fri, Nov 07, 2014 at 09:30:59AM +0800, Zhang Haoyu wrote: > Needless to call bdrv_flush() in qcow2_cache_flush() > if no cache entry is dirty. Did you audit all qcow2 cache callers to make sure they don't rely on the cache flush? Maybe it's not safe to optimize it away if callers assume previo

Re: [Qemu-devel] [PATCH 2/2] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP

2014-11-13 Thread Kevin Wolf
Am 13.11.2014 um 12:45 hat Max Reitz geschrieben: > On 2014-11-13 at 12:40, Kevin Wolf wrote: > >Am 13.11.2014 um 00:25 hat Eric Blake geschrieben: > >>On 11/12/2014 01:27 PM, Markus Armbruster wrote: > >>>+/* in hole, end not yet known */ > >>>+offs = lseek(s->fd, start, SEEK_DATA); > >>>+

Re: [Qemu-devel] [PATCH 2/2] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP

2014-11-13 Thread Max Reitz
On 2014-11-13 at 13:00, Kevin Wolf wrote: Am 13.11.2014 um 12:45 hat Max Reitz geschrieben: On 2014-11-13 at 12:40, Kevin Wolf wrote: Am 13.11.2014 um 00:25 hat Eric Blake geschrieben: On 11/12/2014 01:27 PM, Markus Armbruster wrote: +/* in hole, end not yet known */ +offs = lseek(s->

[Qemu-devel] [PATCH 0/2] virtfs-proxy-helper: Fix Coverity warning

2014-11-13 Thread arei.gonglei
From: Gonglei Gonglei (2): virtfs-proxy-helper: Fix possible socket leak. virtfs-proxy-helper: Fix handle leak to make Coverity happy fsdev/virtfs-proxy-helper.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) -- 1.7.12.4

[Qemu-devel] [PATCH 2/2] virtfs-proxy-helper: Fix handle leak to make Coverity happy

2014-11-13 Thread arei.gonglei
From: Gonglei Coverity report: (94) Event open_fn: Returning handle opened by function "proxy_socket(char const *, uid_t, gid_t)". [details] (95) Event var_assign: Assigning: "sock" = handle returned from "proxy_socket(sock_name, own_u, own_g)". (103) Event leaked_handle: Handle variable "so

[Qemu-devel] [PATCH 1/2] virtfs-proxy-helper: Fix possible socket leak.

2014-11-13 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- fsdev/virtfs-proxy-helper.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c index cd291d3..c1da2d7 100644 --- a/fsdev/virtfs-proxy-helper.c +++ b/fsdev/virtfs-pro

Re: [Qemu-devel] [Spice-devel] screen freezed for 2-3 minutes on spice connect on xen windows 7 domU's with qxl after save/restore

2014-11-13 Thread Fabio Fantoni
Il 13/11/2014 11:14, Fabio Fantoni ha scritto: Il 19/09/2014 15:18, Fabio Fantoni ha scritto: Il 12/09/2014 16:46, Fabio Fantoni ha scritto: Il 08/07/2014 12:34, Fabio Fantoni ha scritto: Il 08/07/2014 12:06, Fabio Fantoni ha scritto: Il 08/07/2014 10:53, David Jaša ha scritto: Hi, On Út, 2

Re: [Qemu-devel] [PATCH 2/2] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP

2014-11-13 Thread Markus Armbruster
Kevin Wolf writes: > Am 13.11.2014 um 12:45 hat Max Reitz geschrieben: >> On 2014-11-13 at 12:40, Kevin Wolf wrote: >> >Am 13.11.2014 um 00:25 hat Eric Blake geschrieben: >> >>On 11/12/2014 01:27 PM, Markus Armbruster wrote: >> >>>+/* in hole, end not yet known */ >> >>>+offs = lseek(s->f

Re: [Qemu-devel] [PATCH v3 4/4] target-ppc: Handle ibm, nmi-register RTAS call

2014-11-13 Thread David Gibson
On Thu, Nov 13, 2014 at 05:18:16PM +0530, Aravinda Prasad wrote: > On Thursday 13 November 2014 04:02 PM, David Gibson wrote: > > On Thu, Nov 13, 2014 at 11:28:30AM +0530, Aravinda Prasad wrote: [snip] > > Having to retry the hcall from here seems very awkward. This is a > > private hcall,

Re: [Qemu-devel] [PATCH 1/1] block migration: fix return value mismatch

2014-11-13 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Wed, Nov 12, 2014 at 06:48:18PM +, Gary Hook wrote: >> -return qemu_ftell(f) - last_ftell; >> +delta_ftell = qemu_ftell(f) - last_ftell; >> +return( (delta_ftell > 0) ? 1 : (delta_ftell < 0) ? -1 : 0 ); > > Good find! > > Please don't nest the ternary

Re: [Qemu-devel] [PATCH v2 4/4] raw-posix: Clean up around raw_co_get_block_status()

2014-11-13 Thread Markus Armbruster
Max Reitz writes: > On 2014-11-13 at 11:17, Markus Armbruster wrote: >> try_seek_hole() doesn't really seek to a hole, it tries to find out >> whether its argument is in a hole or not, and where the hole or >> non-hole ends. Rename to find_allocation() and add a proper function >> comment. >> >>

Re: [Qemu-devel] [PULL for-2.2 0/2] QMP/input-send-event: make console parameter optional

2014-11-13 Thread Peter Maydell
h 'remotes/kevin/tags/for-upstream' into staging > (2014-11-10 16:28:51 +) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-input-20141113-1 > > for you to fetch changes up to 51fc44768a5b71ad78fa40e609a58f71ed62775a

Re: [Qemu-devel] [PATCH v2 3/4] raw-posix: Fix try_seek_hole()'s handling of SEEK_DATA failure

2014-11-13 Thread Kevin Wolf
Am 13.11.2014 um 11:17 hat Markus Armbruster geschrieben: > When SEEK_HOLE tells us we're in a hole, we try SEEK_DATA to find its > end. When that fails, we pretend the hole extends to the end of file. > Wrong. Wrong only in some cases, see below. > Except when SEEK_END fails, we screw up and cl

[Qemu-devel] qemu arm gic assert failed.

2014-11-13 Thread Johan Karlsson
Hi, Enabled DEBUG_GIC in arm_gic.c Use case: Core0 wakes up core1 using irq and then core1 acks and runs eoi until it gets 0x3ff. Note that core1 do not have interrupts enabled and does this in SVC. >From what I can see s->current_pending[1] isn't updated in gic_update because >the following

Re: [Qemu-devel] dynamic sysbus instantiation and load_dtb implementation

2014-11-13 Thread Eric Auger
On 11/13/2014 05:02 AM, David Gibson wrote: > On Fri, Oct 24, 2014 at 02:38:39PM +0200, David Gibson wrote: >> On Thu, Oct 23, 2014 at 01:26:08PM +0200, Alexander Graf wrote: >>> >>> >>> On 23.10.14 13:24, Peter Maydell wrote: On 23 October 2014 12:23, Alexander Graf wrote: > On 23.10.14

Re: [Qemu-devel] [PATCH 2/2] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP

2014-11-13 Thread Kevin Wolf
Am 13.11.2014 um 13:38 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 13.11.2014 um 12:45 hat Max Reitz geschrieben: > >> On 2014-11-13 at 12:40, Kevin Wolf wrote: > >> >Am 13.11.2014 um 00:25 hat Eric Blake geschrieben: > >> >>On 11/12/2014 01:27 PM, Markus Armbruster wrote: >

Re: [Qemu-devel] [PATCH v2 0/4] raw-posix: Get rid of FIEMAP, and more

2014-11-13 Thread Eric Blake
On 11/13/2014 03:16 AM, Markus Armbruster wrote: > See PATCH 2/4 for why FIEMAP needs to go. Minor fixes in 1+3/4, > cleanup in 4/4. > > Would you like this included in 2.2? Maybe just the first three? I'm okay with removing FIEMAP in 2.2; I'm okay if the entire series goes in, once it passes r

Re: [Qemu-devel] [PULL for-2.2 0/1] update seabios to 1.7.5.1 stable release

2014-11-13 Thread Peter Maydell
9d68aa7: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2014-11-10 16:28:51 +) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-seabios-1.7.5.1-20141113-1 > > for you to fetch c

Re: [Qemu-devel] State of ARM FIQ in Qemu

2014-11-13 Thread Tim Sander
Am Mittwoch, 12. November 2014, 10:00:03 schrieb Greg Bellows: > On 12 November 2014 07:56, Tim Sander wrote: > > Hi Greg > > > > > > Bad mode in data abort handler detected > > > > Internal error: Oops - bad mode: 0 [#1] PREEMPT SMP ARM > > > > Modules linked in: firq(O) ipv6 > > > > CPU: 0 PID:

[Qemu-devel] [PATCH 0/4] Add TriCore RCPW, RCRR, RCRW, RLC and RCR instructions

2014-11-13 Thread Bastian Koppelmann
Hi, this patch depends on the previous TriCore patches (https://patchwork.ozlabs.org/patch/405459/) and will hopefully end up in 2.3 QEMU. Other than adding the RCPW, RCRR, RCRW, RLC and RCR instructions, it cleans up how ISA versions in the feature bitmask are handled, to simplify the checks,

[Qemu-devel] [PATCH 3/4] target-tricore: Add instructions of RLC opcode format

2014-11-13 Thread Bastian Koppelmann
Add instructions of RLC opcode format. Add helper psw_write/read. Add microcode generator gen_mtcr/mfcr, which loads/stores a value to a core special function register, which are defined in csfr.def Signed-off-by: Bastian Koppelmann --- target-tricore/csfr.def | 124 +++

[Qemu-devel] [PATCH 1/4] target-tricore: Make TRICORE_FEATURES implying others.

2014-11-13 Thread Bastian Koppelmann
Since all the TriCore instructionsets are subsets of each other (1.3 C 1.3.1 C 1.6), make the features implying each other, e.g 1.6 also has 1.3.1 and 1.3. This way we only need to check our features for the instructionset, where a instruction was first introduced. Signed-off-by: Bastian Koppelma

[Qemu-devel] [PATCH 2/4] target-tricore: Add instructions of RCPW, RCRR and RCRW opcode format

2014-11-13 Thread Bastian Koppelmann
Add instructions of RCPW, RCRR and RCRW opcode format. Add microcode generator function gen_insert. Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 132 +++-- 1 file changed, 129 insertions(+), 3 deletions(-) diff --git a/target-tricore

[Qemu-devel] [PATCH 4/4] target-tricore: Add instructions of RCR opcode format

2014-11-13 Thread Bastian Koppelmann
Add instructions of RCR opcode format. Add helper for madd32/64_ssov and madd32/64_suov. Add helper for msub32/64_ssov and msub32/64_suov. Add microcode generator function madd/msub for 32bit and 64bit, which calculate a mul and a add/sub. OPC2_32_RCR_MSUB_U_32 -> OPC2_32_RCR_MSUB_U_32. Signed-of

  1   2   3   >