Re: [Qemu-devel] [PATCH v2 1/2] blkdebug: Simplify and improve filename generation

2014-11-11 Thread Max Reitz
On 2014-11-10 at 20:15, Eric Blake wrote: On 11/10/2014 09:59 AM, Max Reitz wrote: Instead of actually recreating the options from scratch, just reuse the options given for creating the BDS, which are the configuration file name and additional options. In case there are no additional options we

Re: [Qemu-devel] [Qemu-trivial] [PATCH] pc-bios: petalogix-s3adsp1800.dtb: Use 'xlnx, xps-ethernetlite-2.00.a' instead of 'xlnx, xps-ethernetlite-2.00.b'

2014-11-11 Thread Chen Gang
On 11/11/14 14:12, Michael Tokarev wrote: > 03.11.2014 12:26, Chen Gang wrote: >> For Linux upstream kernel (e.g. 3.17-rc7), the related compatible string >> 'xlnx,xps-ethernetlite-2.00.a' is supported, but 'b' is not supported, >> so change qemu dtb file to match kernel driver. >> >> The related o

Re: [Qemu-devel] [Qemu-trivial] [PATCH] coroutine-sigaltstack: Change jmp_buf to sigjmp_buf

2014-11-11 Thread Michael Tokarev
Applied to -trivial, adding Peter's comment. Thanks, /mjt

Re: [Qemu-devel] [PATCH 02/21] qcow2: Add refcount_width to format-specific info

2014-11-11 Thread Max Reitz
On 2014-11-10 at 20:06, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Add the bit width of every refcount entry to the format-specific information. This breaks some test outputs, fix them. Signed-off-by: Max Reitz --- block/qcow2.c | 4 +++- qapi/block-core.json

Re: [Qemu-devel] [PATCH 03/21] qcow2: Use 64 bits for refcount values

2014-11-11 Thread Max Reitz
On 2014-11-10 at 21:59, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Refcounts may have a width of up to 64 bit, so qemu should use the same s/bit/bits/ See my reply to your review on patch 2. I keep swapping knowing which to use - now I know, thanks! width to represent refc

Re: [Qemu-devel] [PATCH 05/21] qcow2: Refcount overflow and qcow2_alloc_bytes()

2014-11-11 Thread Max Reitz
On 2014-11-10 at 22:12, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: qcow2_alloc_bytes() may reuse a cluster multiple times, in which case the refcount is increased accordingly. However, if this would lead to an overflow the function should instead just not reuse this cluster and a

Re: [Qemu-devel] Image probing: how it can be insecure, and what we could do about it

2014-11-11 Thread Markus Armbruster
Jeff Cody writes: > On Mon, Nov 10, 2014 at 11:30:25AM +0100, Markus Armbruster wrote: >> Kevin Wolf writes: >> >> > Am 10.11.2014 um 09:12 hat Markus Armbruster geschrieben: >> >> Jeff Cody writes: >> >> > So that would mean .img would always require format=, right? >> >> > >> >> > That also

Re: [Qemu-devel] [PATCH for-2.2] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-11 Thread Igor Mammedov
On Mon, 10 Nov 2014 18:56:30 +0100 Paolo Bonzini wrote: > > > On 10/11/2014 18:48, Igor Mammedov wrote: > >> > Does this need to be specific to pc-2.2? > > Why not, It's bug fix. > > But I don't care if it's merged later. > > No, I mean can you do it also for pc-2.1 and earlier? Or should it

Re: [Qemu-devel] [PATCH 06/21] qcow2: Helper function for refcount modification

2014-11-11 Thread Max Reitz
On 2014-11-10 at 23:30, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Since refcounts do not always have to be a uint16_t, all refcount blocks and arrays in memory should not have a specific type (thus they become pointers to void) and for accessing them, two helper functions are us

Re: [Qemu-devel] [PATCH 07/21] qcow2: Helper for refcount array size calculation

2014-11-11 Thread Max Reitz
On 2014-11-10 at 23:49, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Add a helper function which correctly calculates the byte size of a refcount array for any refcount order, and use that function. Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 39 ++

Re: [Qemu-devel] [PATCH 08/21] qcow2: More helpers for refcount modification

2014-11-11 Thread Max Reitz
On 2014-11-11 at 01:29, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Add helper functions for getting and setting refcounts in a refcount array for any possible refcount order, and choose the correct one during refcount initialization. Signed-off-by: Max Reitz --- block/qcow2-r

Re: [Qemu-devel] [PATCH 10/21] qcow2: refcount_order parameter for qcow2_create2

2014-11-11 Thread Max Reitz
On 2014-11-11 at 06:40, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Add a refcount_order parameter to qcow2_create2(), use that value for the image header and for calculating the size required for preallocation. For now, always pass 4. Signed-off-by: Max Reitz --- block/qcow2

[Qemu-devel] [PULL 0/3] Patches to MAINTAINERS that haven't been picked up

2014-11-11 Thread Markus Armbruster
The following changes since commit 558c2c8ddfb165a36eb95dc93125c04829d68aa7: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2014-11-10 16:28:51 +) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/for-upstream for you to fetch

[Qemu-devel] [PULL 1/3] MAINTAINERS: add myself as bootdevice.c maintainer

2014-11-11 Thread Markus Armbruster
From: Gonglei bootdevice.c was created by me, and I wrote most of the code in this file. And now I can maintain it, I'd hope nobody object this. Cc: Gerd Hoffmann Signed-off-by: Gonglei Signed-off-by: Markus Armbruster --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/

[Qemu-devel] [PULL 2/3] MAINTAINERS: add section for QEMU Guest Agent

2014-11-11 Thread Markus Armbruster
From: Michael Roth Signed-off-by: Michael Roth Reviewed-by: Stefan Hajnoczi Signed-off-by: Markus Armbruster --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2287b18..1faf45f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -880,6 +880,12

[Qemu-devel] [PULL 3/3] Add Migration maintainer

2014-11-11 Thread Markus Armbruster
From: Juan Quintela Signed-off-by: Juan Quintela Reviewed-by: Amit Shah Signed-off-by: Markus Armbruster --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1faf45f..bcb69e8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -926,6 +926,15 @

Re: [Qemu-devel] [PATCH] MAINTAINERS: add myself as bootdevice.c maintainer

2014-11-11 Thread Markus Armbruster
writes: > From: Gonglei > > bootdevice.c was created by me, and I wrote most of > the code in this file. And now I can maintain it, > I'd hope nobody object this. > > Cc: Gerd Hoffmann > Signed-off-by: Gonglei Picked up for my MAINTAINERS catch all pull request, thanks!

Re: [Qemu-devel] [PATCH] MAINTAINERS: add section for QEMU Guest Agent

2014-11-11 Thread Markus Armbruster
Michael Roth writes: > Signed-off-by: Michael Roth Picked up for my MAINTAINERS catch all pull request, thanks!

Re: [Qemu-devel] [PATCH] Add Migration maintainer

2014-11-11 Thread Markus Armbruster
Juan Quintela writes: > From: Juan Quintela > > Signed-off-by: Juan Quintela Picked up for my MAINTAINERS catch all pull request, thanks!

[Qemu-devel] [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate'

2014-11-11 Thread Chen Gang
In xen_hvm_change_state_handler(), can pass 'opaque' with type cast to xen_main_loop_prepare() directly, need not use additional variable for it. Signed-off-by: Chen Gang --- xen-hvm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen-hvm.c b/xen-hvm.c index 21f1cbb..7548

Re: [Qemu-devel] [PATCH] x86: Update VT-d Posted-Interrupts related information

2014-11-11 Thread Wu, Feng
> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Tuesday, November 11, 2014 5:58 AM > To: Wu, Feng > Cc: pbonz...@redhat.com; r...@twiddle.net; mtosa...@redhat.com; > qemu-devel@nongnu.org; k...@vger.kernel.org > Subject: Re: [PATCH] x86: Update VT-

Re: [Qemu-devel] [PATCH 03/21] qcow2: Use 64 bits for refcount values

2014-11-11 Thread Kevin Wolf
Am 10.11.2014 um 21:59 hat Eric Blake geschrieben: > On 11/10/2014 06:45 AM, Max Reitz wrote: > > Refcounts may have a width of up to 64 bit, so qemu should use the same > > s/bit/bits/ > > > width to represent refcount values internally. > > > > Signed-off-by: Max Reitz > > --- > > block/qcow

[Qemu-devel] [PATCH v3 0/2] block: Improve filename generation for blkdebug

2014-11-11 Thread Max Reitz
Eric has gloriously reviewed v2 of this series, and by adopting v2 averted a kitten crisis and the need for me to find a freely usable kitten picture (although I guess Wikipedia would have been the way to go). I do have own pictures, but they are currently about 400 km air distance away from me.

[Qemu-devel] [PATCH v3 1/2] blkdebug: Simplify and improve filename generation

2014-11-11 Thread Max Reitz
Instead of actually recreating the options from scratch, just reuse the options given for creating the BDS, which are the configuration file name and additional options. In case there are no additional options we can thus create a plain filename. This obviously results in a different output for qe

[Qemu-devel] [PATCH v3 2/2] iotests: Plain blkdebug filename generation

2014-11-11 Thread Max Reitz
Add one test whether blkdebug is able to generate a plain filename if given a configuration file and a file to be tested only; and add another test whether blkdebug is able to do the same without being given a configuration file. Signed-off-by: Max Reitz --- tests/qemu-iotests/099 | 15 +

Re: [Qemu-devel] [PATCH 03/21] qcow2: Use 64 bits for refcount values

2014-11-11 Thread Max Reitz
On 2014-11-11 at 10:22, Kevin Wolf wrote: Am 10.11.2014 um 21:59 hat Eric Blake geschrieben: On 11/10/2014 06:45 AM, Max Reitz wrote: Refcounts may have a width of up to 64 bit, so qemu should use the same s/bit/bits/ width to represent refcount values internally. Signed-off-by: Max Reitz

Re: [Qemu-devel] [PATCH 03/21] qcow2: Use 64 bits for refcount values

2014-11-11 Thread Max Reitz
On 2014-11-11 at 10:25, Max Reitz wrote: On 2014-11-11 at 10:22, Kevin Wolf wrote: Am 10.11.2014 um 21:59 hat Eric Blake geschrieben: On 11/10/2014 06:45 AM, Max Reitz wrote: Refcounts may have a width of up to 64 bit, so qemu should use the same s/bit/bits/ width to represent refcount valu

Re: [Qemu-devel] [PATCH 03/21] qcow2: Use 64 bits for refcount values

2014-11-11 Thread Kevin Wolf
Am 11.11.2014 um 10:25 hat Max Reitz geschrieben: > On 2014-11-11 at 10:22, Kevin Wolf wrote: > >Am 10.11.2014 um 21:59 hat Eric Blake geschrieben: > >>On 11/10/2014 06:45 AM, Max Reitz wrote: > >>>Refcounts may have a width of up to 64 bit, so qemu should use the same > >>s/bit/bits/ > >> > >>>wid

[Qemu-devel] [PATCH] sysbus: Correct SYSTEM_BUS(obj) defines

2014-11-11 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- include/hw/sysbus.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h index 6175bf9..d1f3f00 100644 --- a/include/hw/sysbus.h +++ b/include/hw/sysbus.h @@ -10,7 +10,7 @@ #define QDEV_MAX_PIO 32

Re: [Qemu-devel] [RFC PATCH v4 07/25] icount: implement icount requesting

2014-11-11 Thread Pavel Dovgaluk
> From: Frederic Konrad [mailto:fred.kon...@greensocs.com] > On 07/11/2014 12:36, Pavel Dovgaluk wrote: > >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > >> On 07/11/2014 11:32, Pavel Dovgalyuk wrote: > >>> Replay uses number of executed instructions to determine corrent events > >>> injectio

Re: [Qemu-devel] [PATCH 06/21] qcow2: Helper function for refcount modification

2014-11-11 Thread Max Reitz
On 2014-11-11 at 09:35, Max Reitz wrote: On 2014-11-10 at 23:30, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Since refcounts do not always have to be a uint16_t, all refcount blocks and arrays in memory should not have a specific type (thus they become pointers to void) and for

Re: [Qemu-devel] [RFC PATCH v4 11/25] cpu-exec: allow temporary disabling icount

2014-11-11 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 07/11/2014 11:32, Pavel Dovgalyuk wrote: > > This patch is required for deterministic replay to generate an exception > > by trying executing an instruction without changing icount. > > It adds new flag to TB for disabling icount while transla

Re: [Qemu-devel] [PATCH] sysbus: Correct SYSTEM_BUS(obj) defines

2014-11-11 Thread Markus Armbruster
writes: > From: Gonglei > > Signed-off-by: Gonglei > --- > include/hw/sysbus.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h > index 6175bf9..d1f3f00 100644 > --- a/include/hw/sysbus.h > +++ b/include/hw/sysbus.h > @@ -10,7 +

Re: [Qemu-devel] [PATCH v2 0/9] raw: Prohibit dangerous writes for probed images

2014-11-11 Thread Markus Armbruster
Kevin Wolf writes: > See the commit message of patch 7 for the why and how. This series > will probably be only part of the solution and doesn't mean that we > should stop looking for other patches which improve different parts of > the problem. > > See the mailing list thread "Image probing: how

Re: [Qemu-devel] [PATCH 07/21] qcow2: Helper for refcount array size calculation

2014-11-11 Thread Max Reitz
On 2014-11-11 at 09:37, Max Reitz wrote: On 2014-11-10 at 23:49, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Add a helper function which correctly calculates the byte size of a refcount array for any refcount order, and use that function. Signed-off-by: Max Reitz --- block/qc

Re: [Qemu-devel] [PULL 2.2 0/2] target-xtensa: fix entry opcode

2014-11-11 Thread Peter Maydell
On 10 November 2014 15:04, Max Filippov wrote: > Hi Peter, > > please pull the fix for target-xtensa. > The following changes since commit 2d9177588bde9881c6602284d1b0b08e4dfe361e: > > Merge remote-tracking branch 'remotes/lalrae/tags/mips-20141107' into > staging (2014-11-10 13:56:47 +) >

Re: [Qemu-devel] [RFC PATCH 0/8] Add Generic PCI host device update

2014-11-11 Thread Claudio Fontana
On 11.11.2014 05:22, Ming Lei wrote: > On Tue, Nov 11, 2014 at 11:24 AM, Ming Lei wrote: >> On Mon, Nov 10, 2014 at 6:00 PM, alvise rigo >> wrote: >>> Hi Claudio, >>> >>> On Fri, Nov 7, 2014 at 4:40 PM, Claudio Fontana >>> wrote: Hi Alvise, I now got to test the series for my

Re: [Qemu-devel] [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate'

2014-11-11 Thread Stefano Stabellini
On Tue, 11 Nov 2014, Chen Gang wrote: > In xen_hvm_change_state_handler(), can pass 'opaque' with type cast to > xen_main_loop_prepare() directly, need not use additional variable for > it. > > Signed-off-by: Chen Gang Acked-by: Stefano Stabellini > xen-hvm.c | 3 +-- > 1 file changed, 1 ins

Re: [Qemu-devel] [PATCH 06/21] qcow2: Helper function for refcount modification

2014-11-11 Thread Max Reitz
On 2014-11-11 at 09:35, Max Reitz wrote: On 2014-11-10 at 23:30, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Since refcounts do not always have to be a uint16_t, all refcount blocks and arrays in memory should not have a specific type (thus they become pointers to void) and for

Re: [Qemu-devel] [PATCH v1 1/2] virtio-scsi: dataplane: fix allocation for 'cmd_vrings'

2014-11-11 Thread Paolo Bonzini
On 11/11/2014 02:17, Ming Lei wrote: > The size of each element should be sizeof(VirtIOSCSIVring *). > > Signed-off-by: Ming Lei > --- > hw/scsi/virtio-scsi-dataplane.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/scsi/virtio-scsi-dataplane.c b/hw/scsi/virtio

Re: [Qemu-devel] [PULL 0/2] linux-user fixes after -rc0

2014-11-11 Thread Peter Maydell
available in the git repository at: > > git://git.linaro.org/people/riku.voipio/qemu.git > tags/pull-linux-user-2014 > > for you to fetch changes up to aecc88616a64a4e0a1ae0d6986de0054ea9f37d2: > > linux-us

Re: [Qemu-devel] [PATCH for-2.2] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-11 Thread Paolo Bonzini
On 11/11/2014 09:35, Igor Mammedov wrote: > > > > No, I mean can you do it also for pc-2.1 and earlier? Or should it be > > only for the last machine type? > > As Michael sad it's for all machine types or have you meant 2.1 stable > branch? My thought was that it's closed now. I meant pc-2.1.

Re: [Qemu-devel] [PATCH 0/3] vl: smp_parse sanity checks

2014-11-11 Thread Paolo Bonzini
On 07/11/2014 17:04, Andrew Jones wrote: > See individual patches. > > Andrew Jones (3): > vl: fix max_cpus check > vl: sanity check cpu topology > vl: warn on topology <-> maxcpus mismatch > > vl.c | 38 -- > 1 file changed, 32 insertions(+), 6 deleti

[Qemu-devel] uniquely identifying KDUMP files that originate from QEMU

2014-11-11 Thread Laszlo Ersek
(Note: I'm not subscribed to either qemu-devel or the kexec list; please keep me CC'd.) QEMU is able to dump the guest's memory in KDUMP format (kdump-zlib, kdump-lzo, kdump-snappy) with the "dump-guest-memory" QMP command. The resultant vmcore is usually analyzed with the "crash" utility. The o

Re: [Qemu-devel] [PATCH] sysbus: Correct SYSTEM_BUS(obj) defines

2014-11-11 Thread Gonglei
> Subject: Re: [Qemu-devel] [PATCH] sysbus: Correct SYSTEM_BUS(obj) defines > > writes: > > > From: Gonglei > > > > Signed-off-by: Gonglei > > --- > > include/hw/sysbus.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h >

Re: [Qemu-devel] uniquely identifying KDUMP files that originate from QEMU

2014-11-11 Thread Peter Maydell
On 11 November 2014 11:22, Laszlo Ersek wrote: > For this reason, the kdump preparation logic in QEMU hardcodes a number > of fields in the kdump header. The direct issue is the "phys_base" > field. Refer to dump.c, functions create_header32(), create_header64(), > and "include/sysemu/dump.h", mac

Re: [Qemu-devel] [PATCH RFC 0/7] Translate guest vector operations to host vector operations

2014-11-11 Thread Kirill Batuzov
On Thu, 16 Oct 2014, Kirill Batuzov wrote: > > (4) Consider supporting generic vector operations in the TCG? > > I gave it a go and was quite happy with the result. I have implemented the > add_i32x4 > opcode which is addition of 128-bit vectors composed of four 32-bit integers > and used it to

Re: [Qemu-devel] [PULL 0/3] Patches to MAINTAINERS that haven't been picked up

2014-11-11 Thread Peter Maydell
On 11 November 2014 08:57, Markus Armbruster wrote: > The following changes since commit 558c2c8ddfb165a36eb95dc93125c04829d68aa7: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2014-11-10 16:28:51 +) > > are available in the git repository at: > > > gi

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 4/4] target-ppc: Handle ibm, nmi-register RTAS call

2014-11-11 Thread David Gibson
On Tue, Nov 11, 2014 at 12:21:49PM +0530, Aravinda Prasad wrote: > > > On Tuesday 11 November 2014 11:41 AM, David Gibson wrote: > > On Tue, Nov 11, 2014 at 11:18:05AM +0530, Aravinda Prasad wrote: > >> > >> > >> On Tuesday 11 November 2014 08:49 AM, David Gibson wrote: > >>> On Thu, Nov 06, 2014

Re: [Qemu-devel] [PATCH 2/3] s390: implement pci instructions

2014-11-11 Thread Frank Blaschka
On Mon, Nov 10, 2014 at 04:56:21PM +0100, Alexander Graf wrote: > > > On 10.11.14 15:20, Frank Blaschka wrote: > > From: Frank Blaschka > > > > This patch implements the s390 pci instructions in qemu. It allows > > to access and drive pci devices attached to the s390 pci bus. > > Because of pla

Re: [Qemu-devel] [PATCH 2/3] s390: implement pci instructions

2014-11-11 Thread Alexander Graf
On 11.11.14 13:10, Frank Blaschka wrote: > On Mon, Nov 10, 2014 at 04:56:21PM +0100, Alexander Graf wrote: >> >> >> On 10.11.14 15:20, Frank Blaschka wrote: >>> From: Frank Blaschka >>> >>> This patch implements the s390 pci instructions in qemu. It allows >>> to access and drive pci devices att

Re: [Qemu-devel] [PATCH 2/3] s390: implement pci instructions

2014-11-11 Thread Peter Maydell
On 11 November 2014 12:10, Frank Blaschka wrote: > On Mon, Nov 10, 2014 at 04:56:21PM +0100, Alexander Graf wrote: >> > +static uint8_t barsize(uint64_t size) >> > +{ >> > +uint64_t mask = 1; >> > +int i; >> > + >> > +if (!size) { >> > +return 0; >> > +} >> > + >> > +fo

Re: [Qemu-devel] [PATCH] target-i386/FPU: wrong conversion infinity from float80 to int32/int64

2014-11-11 Thread Dmitry Poletaev
From: Dmitry Poletaev Signed-off-by: Dmitry Poletaev --- target-i386/fpu_helper.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/target-i386/fpu_helper.c b/target-i386/fpu_helper.c index ab19b71..fc25a03 100644 --- a/target-i386/fpu_helper.c +++ b/

Re: [Qemu-devel] [PATCH] target-i386/fpu_helper.c: fbld instruction doesn't set minus sign

2014-11-11 Thread Dmitry Poletaev
ping 25.07.2014, 15:48, "Dmitry Poletaev" : > Obviously, there is a misprint in function implementation. > > From: Dmitry Poletaev > Signed-off-by: Dmitry Poletaev > > --- >  target-i386/fpu_helper.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target-i386/fpu_helper.

Re: [Qemu-devel] [PATCHv2] esp: Do not overwrite ESP_TCHI after reset

2014-11-11 Thread Paolo Bonzini
On 10/11/2014 21:11, Hannes Reinecke wrote: > On 11/10/2014 07:32 PM, Paolo Bonzini wrote: >> On 10/11/2014 16:52, Hannes Reinecke wrote: >>> After a reset ESP_TCHI should contain the unique ID >>> of the chip. This value will be overwritten with the >>> current tranfer count if the transfer coun

Re: [Qemu-devel] [PATCH 2/3] s390: implement pci instructions

2014-11-11 Thread Frank Blaschka
On Tue, Nov 11, 2014 at 01:16:04PM +0100, Alexander Graf wrote: > > > On 11.11.14 13:10, Frank Blaschka wrote: > > On Mon, Nov 10, 2014 at 04:56:21PM +0100, Alexander Graf wrote: > >> > >> > >> On 10.11.14 15:20, Frank Blaschka wrote: > >>> From: Frank Blaschka > >>> > >>> This patch implements

[Qemu-devel] [PATCH] spice: do not require TCP ports

2014-11-11 Thread Marc-André Lureau
It is possible to use Spice server without TCP port. On local VM, qemu (and libvirt) can add new clients thanks to QMP add_client command. Signed-off-by: Marc-André Lureau --- ui/spice-core.c | 4 1 file changed, 4 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 6467fa4.

Re: [Qemu-devel] [PATCH 2/3] vl: sanity check cpu topology

2014-11-11 Thread Eduardo Habkost
On Fri, Nov 07, 2014 at 05:04:39PM +0100, Andrew Jones wrote: > smp_parse allows partial or complete cpu topology to be given. > In either case there may be inconsistencies in the input which > are currently not sounding any alarms. In some cases the input > is even being silently corrected. We sho

Re: [Qemu-devel] [PATCH 0/3] vl: smp_parse sanity checks

2014-11-11 Thread Eduardo Habkost
On Tue, Nov 11, 2014 at 12:15:26PM +0100, Paolo Bonzini wrote: > > > On 07/11/2014 17:04, Andrew Jones wrote: > > See individual patches. > > > > Andrew Jones (3): > > vl: fix max_cpus check > > vl: sanity check cpu topology > > vl: warn on topology <-> maxcpus mismatch > > > > vl.c | 38

Re: [Qemu-devel] [PATCH 2/3] s390: implement pci instructions

2014-11-11 Thread Frank Blaschka
On Tue, Nov 11, 2014 at 12:17:17PM +, Peter Maydell wrote: > On 11 November 2014 12:10, Frank Blaschka wrote: > > On Mon, Nov 10, 2014 at 04:56:21PM +0100, Alexander Graf wrote: > >> > +static uint8_t barsize(uint64_t size) > >> > +{ > >> > +uint64_t mask = 1; > >> > +int i; > >> > + >

Re: [Qemu-devel] [PATCHv2] esp: Do not overwrite ESP_TCHI after reset

2014-11-11 Thread Hannes Reinecke
On 11/11/2014 01:37 PM, Paolo Bonzini wrote: > > > On 10/11/2014 21:11, Hannes Reinecke wrote: >> On 11/10/2014 07:32 PM, Paolo Bonzini wrote: >>> On 10/11/2014 16:52, Hannes Reinecke wrote: After a reset ESP_TCHI should contain the unique ID of the chip. This value will be overwritten

Re: [Qemu-devel] [PATCH 2/3] s390: implement pci instructions

2014-11-11 Thread Alexander Graf
> Am 11.11.2014 um 13:39 schrieb Frank Blaschka : > >> On Tue, Nov 11, 2014 at 01:16:04PM +0100, Alexander Graf wrote: >> >> >>> On 11.11.14 13:10, Frank Blaschka wrote: On Mon, Nov 10, 2014 at 04:56:21PM +0100, Alexander Graf wrote: > On 10.11.14 15:20, Frank Blaschka wr

[Qemu-devel] [PATCH 0/3] chardev: Add -qmp-pretty

2014-11-11 Thread Max Reitz
This series does not add new functionality. Adding a QMP monitor with prettily formatted JSON output can be done as follows: $ qemu -chardev stdio,id=mon0 -mon chardev=mon0,mode=control,pretty=on However, this is rather cumbersome, so this series (its first patch) adds a shortcut in the form of t

[Qemu-devel] [PATCH 1/3] chardev: Add -qmp-pretty

2014-11-11 Thread Max Reitz
Add a command line option for adding a QMP monitor using pretty JSON formatting. Signed-off-by: Max Reitz --- qemu-options.hx | 8 vl.c| 15 ++- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index da9851d..bc7b

[Qemu-devel] [PATCH 2/3] iotests: _filter_qmp for pretty JSON output

2014-11-11 Thread Max Reitz
_filter_qmp should be able to correctly filter out the QMP version object for pretty JSON output. Signed-off-by: Max Reitz --- tests/qemu-iotests/common.filter | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotes

[Qemu-devel] [PATCH 3/3] iotests: Use -qmp-pretty in 067

2014-11-11 Thread Max Reitz
067 invokes query-block, resulting in a reference output with really long lines (which may pose a problem in email patches and always poses a problem when the output changes, because it is hard to see what has actually changed). Use -qmp-pretty to mitigate this issue. Signed-off-by: Max Reitz ---

Re: [Qemu-devel] KVM call for agenda for 2014-11-11

2014-11-11 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please, send any topic that you are interested in covering. As there are no agenda, call is cancelled. Have a nice day. Later, Juan. > > Thanks, Juan. > > Call details: > > 15:00 CEST > 13:00 UTC > 09:00 EDT > > Every two weeks > > By popular demand, a goog

Re: [Qemu-devel] [PATCH 2/3] s390: implement pci instructions

2014-11-11 Thread Frank Blaschka
On Tue, Nov 11, 2014 at 01:51:25PM +0100, Alexander Graf wrote: > > > > > Am 11.11.2014 um 13:39 schrieb Frank Blaschka : > > > >> On Tue, Nov 11, 2014 at 01:16:04PM +0100, Alexander Graf wrote: > >> > >> > >>> On 11.11.14 13:10, Frank Blaschka wrote: > On Mon, Nov 10, 2014 at 04:56:21PM

[Qemu-devel] [PATCH 1/3] apic: avoid getting out of halted state on masked PIC interrupts

2014-11-11 Thread Paolo Bonzini
After the next patch, if a masked PIC interrupts causes CPU_INTERRUPT_POLL to be set, the CPU will spuriously get out of halted state. While this is technically valid, we should avoid that. Make CPU_INTERRUPT_POLL run apic_update_irq in the right thread and then look at CPU_INTERRUPT_HARD. If CP

[Qemu-devel] [PATCH 0/3] apic: ExtINT fixes for QNX

2014-11-11 Thread Paolo Bonzini
Richard Bilson reported some QNX emulation bugs. I sent him offlist a prototype patch, that he commented on. The first patch here works around what is arguably a QNX bug, that is triggered by the last two patches; but it is better to avoid spurious HLT wakeups, so here it is. The last two patche

[Qemu-devel] [PATCH 2/3] apic: fix loss of IPI due to masked ExtINT

2014-11-11 Thread Paolo Bonzini
This patch fixes an obscure failure of the QNX kernel on QEMU x86 SMP. In QNX, all hardware interrupts come via the PIC, and are delivered by the cpu 0 LAPIC in ExtINT mode, while IPIs are delivered by the LAPIC in fixed mode. This bug happens as follows: - cpu 0 masks a particular PIC interrupt -

[Qemu-devel] [PATCH 3/3] apic: fix incorrect handling of ExtINT interrupts wrt processor priority

2014-11-11 Thread Paolo Bonzini
This fixes another failure with ExtINT, demonstrated by QNX. The failure mode is as follows: - IPI sent to cpu 0 (bit set in APIC irr) - IPI accepted by cpu 0 (bit cleared in irr, set in isr) - IPI sent to cpu 0 (bit set in both irr and isr) - PIC interrupt sent to cpu 0 The PIC interrupt causes

Re: [Qemu-devel] [Xen-devel] [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate'

2014-11-11 Thread Chen Gang
On 11/11/14 22:24, Konrad Rzeszutek Wilk wrote: > On Tue, Nov 11, 2014 at 10:53:01AM +, Stefano Stabellini wrote: >> On Tue, 11 Nov 2014, Chen Gang wrote: >>> In xen_hvm_change_state_handler(), can pass 'opaque' with type cast to >>> xen_main_loop_prepare() directly, need not use additional va

Re: [Qemu-devel] [Qemu-trivial] [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate'

2014-11-11 Thread Michael Tokarev
11.11.2014 12:23, Chen Gang wrote: > In xen_hvm_change_state_handler(), can pass 'opaque' with type cast to > xen_main_loop_prepare() directly, need not use additional variable for > it. gcc most likely eliminates it anyway, but heck, why not? Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [Xen-devel] [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate'

2014-11-11 Thread Konrad Rzeszutek Wilk
On Tue, Nov 11, 2014 at 10:53:01AM +, Stefano Stabellini wrote: > On Tue, 11 Nov 2014, Chen Gang wrote: > > In xen_hvm_change_state_handler(), can pass 'opaque' with type cast to > > xen_main_loop_prepare() directly, need not use additional variable for > > it. The title of your patch should s

Re: [Qemu-devel] [Qemu-trivial] [PATCH] sysbus: Correct SYSTEM_BUS(obj) defines

2014-11-11 Thread Michael Tokarev
A nice one. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH for-2.2] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-11 Thread Igor Mammedov
On Tue, 11 Nov 2014 12:08:06 +0100 Paolo Bonzini wrote: > > > On 11/11/2014 09:35, Igor Mammedov wrote: > > > > > > No, I mean can you do it also for pc-2.1 and earlier? Or should it be > > > only for the last machine type? > > > > As Michael sad it's for all machine types or have you meant

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-i386: cpu: keeping function parameters alignment on new line

2014-11-11 Thread Michael Tokarev
> -static int sstrcmp(const char *s1, const char *e1, const char *s2, > -const char *e2) > +static int sstrcmp(const char *s1, const char *e1, > + const char *s2, const char *e2) ... Not that it's hugely important, but since the patch is here anyway, there's no reason to not

Re: [Qemu-devel] [Qemu-trivial] [PATCH] block: Fix comment for bdrv_co_get_block_status

2014-11-11 Thread Michael Tokarev
10.11.2014 12:10, Fam Zheng wrote: > It returns more information than binary, fix the comment. Applied to -trivial, with the fixup suggested by Markus -- hope that's okay with you, Fam and Max... ;) Thanks, /mjt

Re: [Qemu-devel] [Qemu-trivial] [Xen-devel] [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate'

2014-11-11 Thread Michael Tokarev
11.11.2014 17:32, Chen Gang wrote: >> The title of your patch should say 'variable'. > > Oh, yes, thanks. If necessary to send patch v2 for it, please let me > know. Not only 'varialbe', but also 'redandant'. I fixed both on commit, plus fixed grammar in commit message. Thanks, /mjt

Re: [Qemu-devel] [PATCH 2/3] vl: sanity check cpu topology

2014-11-11 Thread Andrew Jones
On Tue, Nov 11, 2014 at 10:41:00AM -0200, Eduardo Habkost wrote: > On Fri, Nov 07, 2014 at 05:04:39PM +0100, Andrew Jones wrote: > > smp_parse allows partial or complete cpu topology to be given. > > In either case there may be inconsistencies in the input which > > are currently not sounding any a

[Qemu-devel] [PULL 11/11] block: Fix comment for bdrv_co_get_block_status

2014-11-11 Thread Michael Tokarev
From: Fam Zheng It returns more information than binary, fix the comment. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz Reviewed-by: Markus Armbruster Signed-off-by: Michael Tokarev --- block.c |6 +++--- include/block/block.h |4 +++- 2 files changed, 6 insertions(+

[Qemu-devel] [PULL 07/11] coroutine-sigaltstack: Change jmp_buf to sigjmp_buf

2014-11-11 Thread Michael Tokarev
From: Willem Pinckaers This is a simple patch to change the type of old_env from jmp_buf to sigjmp_buf. old_env is used by sigsetjmp and as such should be a sigjmp_buf. This fixes a stack_chk fail in a OSX 32bit build. Since at least on OSX sigjmp_buf is four bytes larger then a jmpbuf, resulti

[Qemu-devel] [PULL 01/11] icc_bus: fix typo ICC_BRIGDE -> ICC_BRIDGE

2014-11-11 Thread Michael Tokarev
From: Zhu Guihua Rename ICC_BRIGDE for better readability. Signed-off-by: Zhu Guihua Reviewed-by: Markus Armbruster Signed-off-by: Michael Tokarev --- hw/cpu/icc_bus.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/cpu/icc_bus.c b/hw/cpu/icc_bus.c index 9575fd6

[Qemu-devel] [PULL 02/11] qemu-doc.texi: fix typos in x509 examples

2014-11-11 Thread Michael Tokarev
From: Gonglei Signed-off-by: Gonglei Signed-off-by: Michael Tokarev --- qemu-doc.texi |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-doc.texi b/qemu-doc.texi index 9973090..ad418f8 100644 --- a/qemu-doc.texi +++ b/qemu-doc.texi @@ -1631,7 +1631,7 @@ EOF # cert

[Qemu-devel] [PULL 00/11 for-2.2] Trivial patches for 2014-11-11

2014-11-11 Thread Michael Tokarev
Here's another week's trivial patches pull req, for 2.2 release. There's nothing exciting in there, but some patches are worth to mention. 4/11: numa: make 'info numa' take into account hotplugged memory this one has been pinged several times, and the numa maintainer agreed to push it us

[Qemu-devel] [PULL 09/11] target-i386: cpu: keeping function parameters alignment on new line

2014-11-11 Thread Michael Tokarev
From: Chen Fan Signed-off-by: Chen Fan Signed-off-by: Michael Tokarev --- target-i386/cpu.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index e4ccee1..236bbee 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -533,8

[Qemu-devel] [PULL 10/11] sysbus: Correct SYSTEM_BUS(obj) defines

2014-11-11 Thread Michael Tokarev
From: Gonglei Signed-off-by: Gonglei Reviewed-by: Markus Armbruster Signed-off-by: Michael Tokarev --- include/hw/sysbus.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h index 9fb1782..9bddfde 100644 --- a/include/hw/sysbus.h +

[Qemu-devel] [PULL 04/11] numa: make 'info numa' take into account hotplugged memory

2014-11-11 Thread Michael Tokarev
From: zhanghailiang When do memory hotplug, if there is numa node, we should add the memory size to the corresponding node memory size. It affects the result of hmp command "info numa". Reviewed-by: Igor Mammedov Signed-off-by: zhanghailiang Signed-off-by: Michael Tokarev --- include/sysemu

[Qemu-devel] [PULL 03/11] slirp/smbd: modify/set several parameters in generated smbd.conf

2014-11-11 Thread Michael Tokarev
From: Peter Wu The file sharing module should not handle printers, so disable it. The options 'load printers' and 'printing' have been available since the beginning (May 1996, commit 0e8fd3398771da2f016d72830179507f3edda51b). Option 'disable spoolss' is available since Samba 2.0.4, commit de5f42c

[Qemu-devel] [PULL 06/11] pc-bios: petalogix-s3adsp1800.dtb: Use 'xlnx, xps-ethernetlite-2.00.a' instead of 'xlnx, xps-ethernetlite-2.00.b'

2014-11-11 Thread Michael Tokarev
From: Chen Gang For Linux upstream kernel (e.g. 3.17-rc7), the related compatible string 'xlnx,xps-ethernetlite-2.00.a' is supported, but 'b' is not supported, so change qemu dtb file to match kernel driver. The related operation for qemu (after this patch): yum install libvirt yum instal

[Qemu-devel] [PULL 05/11] gdbstub: Add a missing case of signal number translation in gdbstub

2014-11-11 Thread Michael Tokarev
From: Martin Simmons While using qemu with gdb "target remote" to debug an application that uses fork and exec, the qemu process receives SIGSTOP every time the forked process terminates (sending SIGCHLD). This is caused by a missing call to gdb_signal_to_target in gdbstub.c, which is fixed by t

[Qemu-devel] [PULL 08/11] xen-hvm: Remove redundant variable 'xstate'

2014-11-11 Thread Michael Tokarev
From: Chen Gang In xen_hvm_change_state_handler(), we can pass 'opaque' with type cast to xen_main_loop_prepare() directly, there's no need to use additional variable for it. Signed-off-by: Chen Gang Acked-by: Stefano Stabellini Signed-off-by: Michael Tokarev --- xen-hvm.c |3 +-- 1 file

Re: [Qemu-devel] [PATCH 2/3] s390: implement pci instructions

2014-11-11 Thread Alexander Graf
On 11.11.14 15:08, Frank Blaschka wrote: > On Tue, Nov 11, 2014 at 01:51:25PM +0100, Alexander Graf wrote: >> >> >> >>> Am 11.11.2014 um 13:39 schrieb Frank Blaschka : >>> On Tue, Nov 11, 2014 at 01:16:04PM +0100, Alexander Graf wrote: > On 11.11.14 13:10, Frank Blaschka wrote:

[Qemu-devel] [PATCH v6] qcow2: Buffer L1 table in snapshot refcount update

2014-11-11 Thread Max Reitz
From: Zhang Haoyu Buffer the active L1 table in qcow2_update_snapshot_refcount() in order to prevent in-place conversion of the L1 table buffer in the BDRVQcowState to big endian and back, which would lead to data corruption if that buffer was accessed concurrently. This should not happen but bet

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-11 Thread Mark Rutland
Hi, On Thu, Nov 06, 2014 at 01:33:20PM +, Alexander Spyridakis wrote: > On 6 November 2014 14:44, Peter Maydell wrote: > > > > > > > We need ACPI guest support in QEMU for AArch64 over here, with all > > > features > > > (including the ability to run ACPI code and add specific tables), for >

Re: [Qemu-devel] [PATCH 2/3] vl: sanity check cpu topology

2014-11-11 Thread Eduardo Habkost
On Tue, Nov 11, 2014 at 03:37:11PM +0100, Andrew Jones wrote: > On Tue, Nov 11, 2014 at 10:41:00AM -0200, Eduardo Habkost wrote: > > On Fri, Nov 07, 2014 at 05:04:39PM +0100, Andrew Jones wrote: > > > smp_parse allows partial or complete cpu topology to be given. > > > In either case there may be i

Re: [Qemu-devel] [PATCH 02/21] qcow2: Add refcount_width to format-specific info

2014-11-11 Thread Eric Blake
On 11/11/2014 01:11 AM, Max Reitz wrote: >>> +.compat = g_strdup("0.10"), >>> +.refcount_width = s->refcount_bits, >> Hmm - is it really worth displaying a constant? Since the 0.10 format >> cannot change the width from 16, I'm not sure if it adds anything t

Re: [Qemu-devel] [PULL 00/11 for-2.2] Trivial patches for 2014-11-11

2014-11-11 Thread Peter Maydell
On 11 November 2014 14:46, Michael Tokarev wrote: > Here's another week's trivial patches pull req, for 2.2 release. > There's nothing exciting in there, but some patches are worth to > mention. > > 4/11: numa: make 'info numa' take into account hotplugged memory > this one has been pinged s

Re: [Qemu-devel] [PATCH 05/21] qcow2: Refcount overflow and qcow2_alloc_bytes()

2014-11-11 Thread Eric Blake
On 11/11/2014 01:22 AM, Max Reitz wrote: > On 2014-11-10 at 22:12, Eric Blake wrote: >> On 11/10/2014 06:45 AM, Max Reitz wrote: >>> qcow2_alloc_bytes() may reuse a cluster multiple times, in which case >>> the refcount is increased accordingly. However, if this would lead to an >>> overflow the fu

  1   2   >