Re: [Qemu-devel] Adding SMP support for Sparc Target

2014-11-07 Thread Artyom Tarasenko
On Thu, Nov 6, 2014 at 11:05 PM, Damien Hilloulin wrote: > Le 06/11/2014 19:23, Artyom Tarasenko a écrit : > >> On Thu, Nov 6, 2014 at 6:36 PM, Damien Hilloulin >> wrote: >>> >>> Le 06/11/2014 16:27, Artyom Tarasenko a écrit : Hello Damien, On Thu, Nov 6, 2014 at 8:38 AM, Dami

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-07 Thread Hanjun Guo
On 2014-11-6 23:57, Paolo Bonzini wrote: > On 06/11/2014 07:53, Hanjun Guo wrote: >>> So the important question is _why_ the guest needs to see an ACPI >>> environment. What exactly can ACPI provide to the guest that DT does not >>> already provide, and why is that necessary? What infrastrucutre is

Re: [Qemu-devel] Adding SMP support for Sparc Target

2014-11-07 Thread Damien Hilloulin
Le 07/11/2014 09:05, Artyom Tarasenko a écrit : On Thu, Nov 6, 2014 at 11:05 PM, Damien Hilloulin wrote: Le 06/11/2014 19:23, Artyom Tarasenko a écrit : On Thu, Nov 6, 2014 at 6:36 PM, Damien Hilloulin wrote: Le 06/11/2014 16:27, Artyom Tarasenko a écrit : Hello Damien, On Thu, Nov 6, 201

Re: [Qemu-devel] [PATCH for-2.2 1/2] QMP/input-send-event: update document of union InputEvent

2014-11-07 Thread Eric Blake
On 11/07/2014 05:41 AM, Amos Kong wrote: > Signed-off-by: Amos Kong > --- > qapi-schema.json | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Eric Blake > > diff --git a/qapi-schema.json b/qapi-schema.json > index 24379ab..a1573d8 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.j

Re: [Qemu-devel] [PATCH for-2.2 1/2] QMP/input-send-event: update document of union InputEvent

2014-11-07 Thread Eric Blake
On 11/07/2014 09:49 AM, Eric Blake wrote: > On 11/07/2014 05:41 AM, Amos Kong wrote: >> Signed-off-by: Amos Kong >> --- >> qapi-schema.json | 5 + >> 1 file changed, 5 insertions(+) > > Reviewed-by: Eric Blake Shoot - I hit "send" too soon. > >> >> diff --git a/qapi-schema.json b/qapi-sc

Re: [Qemu-devel] [PATCH for-2.2 2/2] QMP/input-send-event: make console parameter optional

2014-11-07 Thread Eric Blake
On 11/07/2014 05:41 AM, Amos Kong wrote: > The 'QemuConsole' is the input source for handler, we share some > input handlers to process the input events from different QemuConsole. > > Normally we only have one set of keyboard, mouse, usbtablet, etc. > The devices have different mask, it's fine to

[Qemu-devel] guest sync and bdrv_co_flush

2014-11-07 Thread lihuiba
Hi, all I'm a user of qemu/kvm, and I'm wondering some internals of qemu/kvm, so I'd better post it in this developer's mailing list. To be specific, I'm wondering how data is flushed to disk. Intuitively, when the guest issues a SYNCHRONIZE CACHE command in the SCSI layer, qemu/kvm should

Re: [Qemu-devel] [PATCH v2] block/vdi: Limit maximum size even futher

2014-11-07 Thread Max Reitz
On 2014-10-28 at 11:12, Max Reitz wrote: The block layer read and write functions do not like requests which are bigger than INT_MAX bytes. Since the VDI bmap is read and written in a single operation, its size is therefore limited accordingly. This reduces the maximum VDI image size supported by

[Qemu-devel] [PATCHv3] seccomp: change configure to avoid arm 32 to break

2014-11-07 Thread Eduardo Otubo
Current stable version of libseccomp (2.1.1) only supports i386 and x86_64 archs correctly. This patch limits the usage of the syscall filter for those archs and updates to the correct last version of libseccomp. This patch also fixes the bug: https://bugs.launchpad.net/qemu/+bug/1363641 Signed-o

Re: [Qemu-devel] Geometry and blocksize support for backing devices

2014-11-07 Thread Markus Armbruster
Christian Borntraeger writes: > Markus, Kevin, Stefan, > > here is a (somewhat late) followup of some KVM forum discussions regarding > block size and geometry of pass-through block devices. Let's just do a quick > wrap-up (as of my understanding) and a proposal at the end of the mail > > > > > >

Re: [Qemu-devel] [PATCH] vl: rework smp_parse

2014-11-07 Thread Andrew Jones
On Thu, Nov 06, 2014 at 05:17:44PM -0200, Eduardo Habkost wrote: > On Thu, Nov 06, 2014 at 05:09:35PM +0100, Andrew Jones wrote: > > smp_parse has a couple problems. First, it should use max_cpus, > > not smp_cpus when calculating missing topology information. > > Conversely, if maxcpus is not inpu

Re: [Qemu-devel] [PATCH] vl: rework smp_parse

2014-11-07 Thread Andrew Jones
On Thu, Nov 06, 2014 at 11:11:30PM +0100, Paolo Bonzini wrote: > > > On 06/11/2014 17:09, Andrew Jones wrote: > > +if (sockets * cores * threads != max_cpus) { > > +fprintf(stderr, "cpu topology: " > > +"sockets (%u) * cores (%u) * threads (%u) != max_cpus

Re: [Qemu-devel] [PATCH] vl: rework smp_parse

2014-11-07 Thread Paolo Bonzini
On 07/11/2014 10:29, Andrew Jones wrote: >> > I think this would cause too many failures in the wild. Perhaps error >> > out if it is lower, and warn if sockets * cores * threads > max_cpus >> > since we actually allow hot-plug a thread at a time? > We'd still have more failures if we choose to

Re: [Qemu-devel] Geometry and blocksize support for backing devices

2014-11-07 Thread Christian Borntraeger
Am 07.11.2014 10:17, schrieb Markus Armbruster: > Christian Borntraeger writes: > >> Markus, Kevin, Stefan, >> >> here is a (somewhat late) followup of some KVM forum discussions regarding >> block size and geometry of pass-through block devices. Let's just do a quick >> wrap-up (as of my underst

Re: [Qemu-devel] [PATCH] vl: rework smp_parse

2014-11-07 Thread Andrew Jones
On Fri, Nov 07, 2014 at 10:40:14AM +0100, Paolo Bonzini wrote: > > > On 07/11/2014 10:29, Andrew Jones wrote: > >> > I think this would cause too many failures in the wild. Perhaps error > >> > out if it is lower, and warn if sockets * cores * threads > max_cpus > >> > since we actually allow ho

Re: [Qemu-devel] Image probing: how it can be insecure, and what we could do about it

2014-11-07 Thread Markus Armbruster
Max Reitz writes: > On 2014-11-06 at 13:26, Markus Armbruster wrote: >> Max Reitz writes: >> >>> On 2014-11-04 at 19:45, Markus Armbruster wrote: I'll try to explain all solutions fairly. Isn't easy when you're as biased towards one of them as I am. Please bear with me. >>>

[Qemu-devel] [PATCH] xhci: add sanity checks to xhci_lookup_uport

2014-11-07 Thread Gerd Hoffmann
Also catch xhci_lookup_uport failures in post_load. https://bugzilla.redhat.com/show_bug.cgi?id=1074219 Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 2930b72..9a942cf 100644 --- a/hw/us

[Qemu-devel] Add CMP2 instruction

2014-11-07 Thread Guo, Lei
This patch aims to add CMP2 instruction for m68k family. Description: Compares the value in Rn to each bound. The effective address contains the bounds pair: upper bound following the lower bound. For signed comparisons, the arithmetically smaller value should be used as the lower bound. For unsi

[Qemu-devel] [RFC PATCH v4 00/25] Deterministic replay and reverse execution

2014-11-07 Thread Pavel Dovgalyuk
This set of patches is related to the reverse execution and deterministic replay of qemu execution Our implementation of deterministic replay can be used for deterministic and reverse debugging of guest code through gdb remote interface. Execution recording writes non-deterministic events log,

[Qemu-devel] [RFC PATCH v4 05/25] replay: internal functions for replay log

2014-11-07 Thread Pavel Dovgalyuk
This patch adds functions to perform read and write operations with replay log. Signed-off-by: Pavel Dovgalyuk --- replay/Makefile.objs |1 replay/replay-internal.c | 141 ++ replay/replay-internal.h | 50 3 files changed,

[Qemu-devel] [RFC PATCH v4 06/25] cpu-exec: reset exception_index correctly

2014-11-07 Thread Pavel Dovgalyuk
Exception index is reset at every entry at every entry into cpu_exec() function. This may cause missing the exceptions while replaying them. This patch moves exception_index reset to the locations where they are processed. Signed-off-by: Pavel Dovgalyuk --- cpu-exec.c |2 +- cpus.c |

[Qemu-devel] [RFC PATCH v4 13/25] replay: asynchronous events infrastructure

2014-11-07 Thread Pavel Dovgalyuk
This patch adds module for saving and replaying asynchronous events. These events include network packets, keyboard and mouse input, USB packets, thread pool and bottom halves callbacks. All events are stored in the queue to be processed at synchronization points such as beginning of TB execution,

[Qemu-devel] [RFC PATCH v4 01/25] acpi: accurate overflow check

2014-11-07 Thread Pavel Dovgalyuk
Compare clock in ns, because acpi_pm_tmr_update uses rounded to ns value instead of ticks. Signed-off-by: Pavel Dovgalyuk --- hw/acpi/core.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/acpi/core.c b/hw/acpi/core.c index a7368fb..51913d6 100644 --- a/hw/acpi/

[Qemu-devel] [RFC PATCH v4 08/25] icount: improve enable/disable ticks

2014-11-07 Thread Pavel Dovgalyuk
This patch eliminates call of the cpu_get_real_ticks while enabling or disabling the virtual timer in icount mode. These calls are used for cpu_ticks_offset which is not needed in this mode. Signed-off-by: Pavel Dovgalyuk --- cpus.c | 12 1 files changed, 8 insertions(+), 4 deleti

[Qemu-devel] [RFC PATCH v4 07/25] icount: implement icount requesting

2014-11-07 Thread Pavel Dovgalyuk
Replay uses number of executed instructions to determine corrent events injection moments. This patch introduces new function for querying the instructions counter. Signed-off-by: Pavel Dovgalyuk --- cpus.c | 26 +++--- include/qemu/timer.h |1 + 2 files c

[Qemu-devel] [RFC PATCH v4 14/25] cpu: replay instructions sequence

2014-11-07 Thread Pavel Dovgalyuk
This patch adds calls to replay functions into the icount setup block. In record mode number of executed instructions is written to the log. In replay mode number of istructions to execute is taken from the replay log. Signed-off-by: Pavel Dovgalyuk --- cpu-exec.c |1 + cpus.c

[Qemu-devel] [RFC PATCH v4 02/25] mc146818rtc: add missed field to vmstate

2014-11-07 Thread Pavel Dovgalyuk
This patch adds irq_reinject_on_ack_count field to VMState to allow correct saving/loading the state of MC146818 RTC. Signed-off-by: Pavel Dovgalyuk --- hw/timer/mc146818rtc.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c

[Qemu-devel] [RFC PATCH v4 09/25] replay: introduce icount event

2014-11-07 Thread Pavel Dovgalyuk
This patch adds icount event to the replay subsystem. This event corresponds to execution of several instructions and used to synchronize input events in the replay phase. Signed-off-by: Pavel Dovgalyuk --- replay/replay-internal.c | 14 ++ replay/replay-internal.h | 18 +

[Qemu-devel] [RFC PATCH v4 10/25] i386: do not cross the pages boundaries in replay mode

2014-11-07 Thread Pavel Dovgalyuk
This patch denies crossing the boundary of the pages in the replay mode, because it can cause an exception. Do it only when boundary is crossed by the first instruction in the block. If current instruction already crossed the bound - it's ok, because an exception hasn't stopped this code. Signed-o

[Qemu-devel] [RFC PATCH v4 15/25] replay: recording and replaying clock ticks

2014-11-07 Thread Pavel Dovgalyuk
Clock ticks are considered as the sources of non-deterministic data for virtual machine. This patch implements saving the clock values when they are acquired (virtual, host clock, rdtsc, and some other timers). When replaying the execution corresponding values are read from log and transfered to th

[Qemu-devel] [RFC PATCH v4 03/25] replay: global variables and function stubs

2014-11-07 Thread Pavel Dovgalyuk
This patch adds global variables, defines, functions declarations, and function stubs for deterministic VM replay used by external modules. Signed-off-by: Pavel Dovgalyuk --- Makefile.target |1 + qapi-schema.json | 32 replay/Makefile.objs |1

[Qemu-devel] [RFC PATCH v4 12/25] replay: interrupts and exceptions

2014-11-07 Thread Pavel Dovgalyuk
This patch includes modifications of common cpu files. All interrupts and exceptions occured during recording are written into the replay log. These events allow correct replaying the execution by kicking cpu thread when one of these events is found in the log. Signed-off-by: Pavel Dovgalyuk ---

[Qemu-devel] [RFC PATCH v4 16/25] replay: recording and replaying different timers

2014-11-07 Thread Pavel Dovgalyuk
This patch introduces functions for recording and replaying realtime sources, that do not use qemu-clock interface. These include return value of time() function in time_t and struct tm forms. Patch also adds warning to get_timedate function to prevent its usage in recording mode, because it may le

[Qemu-devel] [RFC PATCH v4 04/25] sysemu: system functions for replay

2014-11-07 Thread Pavel Dovgalyuk
This patch removes "static" specifier from several qemu function to make them visible to the replay module. It also invents several system functions that will be used by replay. Signed-off-by: Pavel Dovgalyuk --- cpus.c |4 ++-- include/exec/exec-all.h |1 + include/qom/

[Qemu-devel] [RFC PATCH v4 17/25] cpus: make icount warp deterministic in replay mode

2014-11-07 Thread Pavel Dovgalyuk
This patch adds saving and replaying warping parameters in record and replay modes. These parameters affect on virtual clock values and therefore should be deterministic. Signed-off-by: Pavel Dovgalyuk --- cpus.c | 24 +--- 1 files changed, 17 insertions(+), 7 deletions(-)

[Qemu-devel] [RFC PATCH v4 19/25] replay: checkpoints

2014-11-07 Thread Pavel Dovgalyuk
This patch introduces checkpoints that synchronize cpu thread and iothread. When checkpoint is met in the code all asynchronous events from the queue are executed. Signed-off-by: Pavel Dovgalyuk --- block.c | 11 +++ cpus.c |2 +- include/qemu/tim

[Qemu-devel] [RFC PATCH v4 18/25] replay: shutdown event

2014-11-07 Thread Pavel Dovgalyuk
This patch records and replays simulator shutdown event. Signed-off-by: Pavel Dovgalyuk --- include/sysemu/sysemu.h |1 + replay/replay-internal.h |2 ++ replay/replay.c | 11 +++ replay/replay.h |5 + vl.c |8 +++- 5 files

[Qemu-devel] [RFC PATCH v4 11/25] cpu-exec: allow temporary disabling icount

2014-11-07 Thread Pavel Dovgalyuk
This patch is required for deterministic replay to generate an exception by trying executing an instruction without changing icount. It adds new flag to TB for disabling icount while translating it. Signed-off-by: Pavel Dovgalyuk --- cpu-exec.c |6 +++--- include/exec/exec-all.h

[Qemu-devel] [RFC PATCH v4 22/25] replay: thread pool

2014-11-07 Thread Pavel Dovgalyuk
This patch modifies thread pool to allow replaying asynchronous thread tasks synchronously in replay mode. Signed-off-by: Pavel Dovgalyuk --- block/raw-posix.c |6 - block/raw-win32.c |4 +++- include/block/thread-pool.h |4 +++- replay/replay-events.c |

[Qemu-devel] [RFC PATCH v4 21/25] replay: replay aio requests

2014-11-07 Thread Pavel Dovgalyuk
This patch adds identifier to aio requests. ID is used for creating bottom halves and identifying them while replaying. The patch also introduces several functions that make possible replaying of the aio requests. Signed-off-by: Pavel Dovgalyuk --- block.c| 81 +

[Qemu-devel] [RFC PATCH v4 20/25] replay: bottom halves

2014-11-07 Thread Pavel Dovgalyuk
This patch introduces bottom half event for replay queue. It saves the events into the queue and process them at the checkpoints and instructions execution. Signed-off-by: Pavel Dovgalyuk --- async.c | 46 -- dma-helpers.c

Re: [Qemu-devel] [PATCH RESEND] mips: Ensure PC update with MTC0 single-stepping

2014-11-07 Thread Leon Alrae
On 06/11/2014 20:38, Maciej W. Rozycki wrote: > Correct the way PC is updated when single-stepping instructions, by > keeping the old PC only for the BS_EXCP (exception condition) state. > > Some MTC0 (and possibly other) instructions switch to the BS_STOP state > to terminate the current transl

[Qemu-devel] [RFC PATCH v4 23/25] replay: initialization and deinitialization

2014-11-07 Thread Pavel Dovgalyuk
This patch introduces the functions for enabling the record/replay and for freeing the resources when simulator closes. Signed-off-by: Pavel Dovgalyuk --- block.c |2 - exec.c |1 replay/replay-internal.h |2 + replay/replay.c | 134 +

Re: [Qemu-devel] [RFC PATCH v4 03/25] replay: global variables and function stubs

2014-11-07 Thread Eric Blake
On 11/07/2014 11:31 AM, Pavel Dovgalyuk wrote: > This patch adds global variables, defines, functions declarations, > and function stubs for deterministic VM replay used by external modules. > > Signed-off-by: Pavel Dovgalyuk > --- Just focusing on interface review: > +++ b/qapi-schema.json > @

[Qemu-devel] [RFC PATCH v4 24/25] replay: command line options

2014-11-07 Thread Pavel Dovgalyuk
This patch introduces command line options for enabling recording or replaying virtual machine behavior. "-record" option starts recording of the execution and saves it into the log, specified with "fname" parameter. "-replay" option is intended for replaying previously saved log. Signed-off-by: P

[Qemu-devel] [RFC PATCH v4 25/25] replay: recording of the user input

2014-11-07 Thread Pavel Dovgalyuk
This records user input (keyboard and mouse events) in record mode and replays these input events in replay mode. Signed-off-by: Pavel Dovgalyuk --- include/ui/input.h |2 + replay/Makefile.objs |1 replay/replay-events.c | 48 replay/replay-input.c

Re: [Qemu-devel] [PATCH] mips: Respect CP0.Status.CU1 for microMIPS FP branches

2014-11-07 Thread Leon Alrae
On 05/11/2014 20:16, Maciej W. Rozycki wrote: > Now as to CP0.Status.CU1, while fixing the 5Kc and 5KEc processors is an > obvious change, I think the removal of the extra check may not be such. > The thing is in the original architecture -- and it still stands for CP2 > -- these bits used to

[Qemu-devel] [PATCH] target-mips: fix multiple TCG registers covering same data

2014-11-07 Thread Yongbok Kim
Avoid to allocate different TCG registers for the FPU registers that are mapped on the MSA vectore registers. Signed-off-by: Yongbok Kim --- target-mips/translate.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c i

Re: [Qemu-devel] [RFC PATCH v4 13/25] replay: asynchronous events infrastructure

2014-11-07 Thread Eric Blake
On 11/07/2014 11:32 AM, Pavel Dovgalyuk wrote: > This patch adds module for saving and replaying asynchronous events. > These events include network packets, keyboard and mouse input, > USB packets, thread pool and bottom halves callbacks. > All events are stored in the queue to be processed at syn

Re: [Qemu-devel] [PATCH] target-mips: fix multiple TCG registers covering same data

2014-11-07 Thread Richard Henderson
On 11/07/2014 11:43 AM, Yongbok Kim wrote: > Avoid to allocate different TCG registers for the FPU registers > that are mapped on the MSA vectore registers. > > Signed-off-by: Yongbok Kim > --- > target-mips/translate.c |8 +++- > 1 files changed, 3 insertions(+), 5 deletions(-) Reviewe

[Qemu-devel] about qga on windows

2014-11-07 Thread Thomas Stein
Hello. A quick question about qga and windows. Is setting vpus supposed to work? I compiled qemu-guest-agent myself and installed it on a windows7 ultimate machine. Libvirt is version 1.2.10. Qemu is version 2.1.2. Here the output of a setvcpu command: virsh # qemu-agent-command windows7 '{"execu

Re: [Qemu-devel] Add CMP2 instruction

2014-11-07 Thread Alex Bennée
Guo, Lei writes: > This patch aims to add CMP2 instruction for m68k family. > > Description: Compares the value in Rn to each bound. The effective address > contains the > bounds pair: upper bound following the lower bound. For signed comparisons, > the > arithmetically smaller value should be

Re: [Qemu-devel] Add CMP2 instruction

2014-11-07 Thread Andreas Färber
Hi, Am 07.11.2014 um 11:14 schrieb Guo, Lei: > This patch aims to add CMP2 instruction for m68k family. > > > > *Description: *Compares the value in Rn to each bound. The effective > address contains the > > bounds pair: upper bound following the lower bound. For signed > comparisons, the >

Re: [Qemu-devel] [RFC PATCH v4 01/25] acpi: accurate overflow check

2014-11-07 Thread Paolo Bonzini
On 07/11/2014 11:31, Pavel Dovgalyuk wrote: > Compare clock in ns, because acpi_pm_tmr_update uses rounded > to ns value instead of ticks. > > Signed-off-by: Pavel Dovgalyuk > --- > hw/acpi/core.c |7 +-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/hw/acpi/core

Re: [Qemu-devel] [RFC PATCH v4 02/25] mc146818rtc: add missed field to vmstate

2014-11-07 Thread Paolo Bonzini
On 07/11/2014 11:31, Pavel Dovgalyuk wrote: > This patch adds irq_reinject_on_ack_count field to VMState to allow correct > saving/loading the state of MC146818 RTC. > > Signed-off-by: Pavel Dovgalyuk > --- > hw/timer/mc146818rtc.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) >

Re: [Qemu-devel] [RFC PATCH v4 07/25] icount: implement icount requesting

2014-11-07 Thread Paolo Bonzini
On 07/11/2014 11:32, Pavel Dovgalyuk wrote: > Replay uses number of executed instructions to determine corrent events > injection moments. This patch introduces new function for querying the > instructions counter. > > Signed-off-by: Pavel Dovgalyuk > --- > cpus.c | 26

Re: [Qemu-devel] [RFC PATCH v4 10/25] i386: do not cross the pages boundaries in replay mode

2014-11-07 Thread Paolo Bonzini
On 07/11/2014 11:32, Pavel Dovgalyuk wrote: > This patch denies crossing the boundary of the pages in the replay mode, > because it can cause an exception. Do it only when boundary is > crossed by the first instruction in the block. > If current instruction already crossed the bound - it's ok, >

Re: [Qemu-devel] [RFC PATCH v4 08/25] icount: improve enable/disable ticks

2014-11-07 Thread Paolo Bonzini
On 07/11/2014 11:32, Pavel Dovgalyuk wrote: > This patch eliminates call of the cpu_get_real_ticks while enabling > or disabling the virtual timer in icount mode. These calls are used > for cpu_ticks_offset which is not needed in this mode. > > Signed-off-by: Pavel Dovgalyuk > --- > cpus.c |

Re: [Qemu-devel] [PATCH] vl: rework smp_parse

2014-11-07 Thread Andrew Jones
On Fri, Nov 07, 2014 at 10:52:31AM +0100, Andrew Jones wrote: > On Fri, Nov 07, 2014 at 10:40:14AM +0100, Paolo Bonzini wrote: > > > > > > On 07/11/2014 10:29, Andrew Jones wrote: > > >> > I think this would cause too many failures in the wild. Perhaps error > > >> > out if it is lower, and warn

Re: [Qemu-devel] [RFC PATCH v4 11/25] cpu-exec: allow temporary disabling icount

2014-11-07 Thread Paolo Bonzini
On 07/11/2014 11:32, Pavel Dovgalyuk wrote: > This patch is required for deterministic replay to generate an exception > by trying executing an instruction without changing icount. > It adds new flag to TB for disabling icount while translating it. > > Signed-off-by: Pavel Dovgalyuk > --- > cp

Re: [Qemu-devel] [RFC PATCH v4 17/25] cpus: make icount warp deterministic in replay mode

2014-11-07 Thread Paolo Bonzini
On 07/11/2014 11:33, Pavel Dovgalyuk wrote: > This patch adds saving and replaying warping parameters in record and replay > modes. These parameters affect on virtual clock values and therefore should > be deterministic. Why are QEMU_CLOCK_REALTIME timers not recorded/replayed like QEMU_CLOCK_HOST

Re: [Qemu-devel] Add CMP2 instruction

2014-11-07 Thread Richard Henderson
On 11/07/2014 11:14 AM, Guo, Lei wrote: > This patch aims to add CMP2 instruction for m68k family. Mainline target-m68k supports coldfire only. There is an external tree for full m68k support: https://gitorious.org/qemu-m68k That said, before you send this to them... > +if (ext & 0x8000

Re: [Qemu-devel] [RFC PATCH v4 10/25] i386: do not cross the pages boundaries in replay mode

2014-11-07 Thread Andreas Färber
Am 07.11.2014 um 11:32 schrieb Pavel Dovgalyuk: > This patch denies crossing the boundary of the pages in the replay mode, > because it can cause an exception. Do it only when boundary is > crossed by the first instruction in the block. > If current instruction already crossed the bound - it's ok,

Re: [Qemu-devel] [RFC PATCH v4 06/25] cpu-exec: reset exception_index correctly

2014-11-07 Thread Paolo Bonzini
On 07/11/2014 11:32, Pavel Dovgalyuk wrote: > Exception index is reset at every entry at every entry into cpu_exec() > function. This may cause missing the exceptions while replaying them. > This patch moves exception_index reset to the locations where they are > processed. > > Signed-off-by: Pa

Re: [Qemu-devel] [PATCH] vl: rework smp_parse

2014-11-07 Thread Andrew Jones
On Fri, Nov 07, 2014 at 10:22:39AM +0100, Andrew Jones wrote: > On Thu, Nov 06, 2014 at 05:17:44PM -0200, Eduardo Habkost wrote: > > On Thu, Nov 06, 2014 at 05:09:35PM +0100, Andrew Jones wrote: > > > smp_parse has a couple problems. First, it should use max_cpus, > > > not smp_cpus when calculatin

Re: [Qemu-devel] about qga on windows

2014-11-07 Thread Paolo Bonzini
On 07/11/2014 12:01, Thomas Stein wrote: > Hello. > > A quick question about qga and windows. Is setting vpus supposed to > work? I compiled qemu-guest-agent myself and installed it on a windows7 > ultimate machine. Libvirt is version 1.2.10. Qemu is version 2.1.2. Here > the output of a setvcpu c

Re: [Qemu-devel] [RFC PATCH v4 07/25] icount: implement icount requesting

2014-11-07 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 07/11/2014 11:32, Pavel Dovgalyuk wrote: > > Replay uses number of executed instructions to determine corrent events > > injection moments. This patch introduces new function for querying the > > instructions counter. > > > > Signed-off-by: Pa

Re: [Qemu-devel] [RFC PATCH v4 10/25] i386: do not cross the pages boundaries in replay mode

2014-11-07 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 07/11/2014 11:32, Pavel Dovgalyuk wrote: > > This patch denies crossing the boundary of the pages in the replay mode, > > because it can cause an exception. Do it only when boundary is > > crossed by the first instruction in the block. > > If

Re: [Qemu-devel] [RFC PATCH v4 17/25] cpus: make icount warp deterministic in replay mode

2014-11-07 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 07/11/2014 11:33, Pavel Dovgalyuk wrote: > > This patch adds saving and replaying warping parameters in record and replay > > modes. These parameters affect on virtual clock values and therefore should > > be deterministic. > > Why are QEMU_C

Re: [Qemu-devel] [RFC PATCH v4 07/25] icount: implement icount requesting

2014-11-07 Thread Frederic Konrad
On 07/11/2014 12:36, Pavel Dovgaluk wrote: From: Paolo Bonzini [mailto:pbonz...@redhat.com] On 07/11/2014 11:32, Pavel Dovgalyuk wrote: Replay uses number of executed instructions to determine corrent events injection moments. This patch introduces new function for querying the instructions coun

Re: [Qemu-devel] about qga on windows

2014-11-07 Thread Thomas Stein
Am 07.11.14 12:31, schrieb Paolo Bonzini: > On 07/11/2014 12:01, Thomas Stein wrote: >> Hello. >> >> A quick question about qga and windows. Is setting vpus supposed to >> work? I compiled qemu-guest-agent myself and installed it on a windows7 >> ultimate machine. Libvirt is version 1.2.10. Qemu i

Re: [Qemu-devel] Add CMP2 instruction

2014-11-07 Thread Laurent Vivier
Hi, did you test it ? because after just a first glance this patch seems wrong as the tmp variables cannot be used beyond the first tcg_gen_cond() (conditional branches clobber temporary vars), you must use tcg_temp_local_new() and tcg_temp_free(). Regards, Laurent > Le 7 novembre 2014 à 11:1

Re: [Qemu-devel] [PATCH] mips: Set the CP0.Config3.DSP and CP0.Config3.DSP2P bits

2014-11-07 Thread Leon Alrae
On 05/11/2014 15:26, Leon Alrae wrote: > On 04/11/2014 15:41, Maciej W. Rozycki wrote: >> Set the CP0.Config3.DSP2P bit for the 74kf processor and both that bit >> and the CP0.Config3.DSP bit for the artificial mips32r5-generic and >> mips64dspr2 processors. They have the DSPr2 ASE enabled in `i

Re: [Qemu-devel] [RFC PATCH v4 17/25] cpus: make icount warp deterministic in replay mode

2014-11-07 Thread Paolo Bonzini
On 07/11/2014 12:45, Pavel Dovgaluk wrote: >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> On 07/11/2014 11:33, Pavel Dovgalyuk wrote: >>> This patch adds saving and replaying warping parameters in record and replay >>> modes. These parameters affect on virtual clock values and therefore s

Re: [Qemu-devel] [PATCH] vl: rework smp_parse

2014-11-07 Thread Eduardo Habkost
On Fri, Nov 07, 2014 at 12:21:26PM +0100, Andrew Jones wrote: > On Fri, Nov 07, 2014 at 10:52:31AM +0100, Andrew Jones wrote: > > On Fri, Nov 07, 2014 at 10:40:14AM +0100, Paolo Bonzini wrote: > > > > > > > > > On 07/11/2014 10:29, Andrew Jones wrote: > > > >> > I think this would cause too many

[Qemu-devel] [PATCH] esp-pci: fixup deadlock with linux

2014-11-07 Thread Hannes Reinecke
A linux guest will be issuing messages: [ 32.124042] DC390: Deadlock in DataIn_0: DMA aborted unfinished: 00 bytes remain!! [ 32.126348] DC390: DataIn_0: DMA State: 0 and the HBA will fail to work properly. Reason is the emulation is not setting the 'DMA transfer done' status correctly.

Re: [Qemu-devel] [PATCH] vl: rework smp_parse

2014-11-07 Thread Andrew Jones
On Fri, Nov 07, 2014 at 10:16:06AM -0200, Eduardo Habkost wrote: > On Fri, Nov 07, 2014 at 12:21:26PM +0100, Andrew Jones wrote: > > On Fri, Nov 07, 2014 at 10:52:31AM +0100, Andrew Jones wrote: > > > On Fri, Nov 07, 2014 at 10:40:14AM +0100, Paolo Bonzini wrote: > > > > > > > > > > > > On 07/11/

Re: [Qemu-devel] [PATCH] vl: rework smp_parse

2014-11-07 Thread Eduardo Habkost
On Fri, Nov 07, 2014 at 01:23:12PM +0100, Andrew Jones wrote: > On Fri, Nov 07, 2014 at 10:16:06AM -0200, Eduardo Habkost wrote: > > On Fri, Nov 07, 2014 at 12:21:26PM +0100, Andrew Jones wrote: > > > On Fri, Nov 07, 2014 at 10:52:31AM +0100, Andrew Jones wrote: [...] > > > After talking with Igor,

Re: [Qemu-devel] [PATCH] esp-pci: fixup deadlock with linux

2014-11-07 Thread Paolo Bonzini
On 07/11/2014 13:22, Hannes Reinecke wrote: > A linux guest will be issuing messages: > > [ 32.124042] DC390: Deadlock in DataIn_0: DMA aborted unfinished: 00 > bytes remain!! > [ 32.126348] DC390: DataIn_0: DMA State: 0 > > and the HBA will fail to work properly. > Reason is the emula

Re: [Qemu-devel] [PATCH] mips: Set the CP0.Config3.DSP and CP0.Config3.DSP2P bits

2014-11-07 Thread Maciej W. Rozycki
On Fri, 7 Nov 2014, Leon Alrae wrote: > When I've been applying this patch to my mips-next candidate branch for > 2.2 I realized that you haven't rebased it onto the recent version where > MSA has been added to mips32r5-generic. Now I don't think that having > DSP and MSA on one CPU makes sense, t

Re: [Qemu-devel] [PATCH v6 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove

2014-11-07 Thread Vladimir Sementsov-Ogievskiy
+if (!name || name[0] == '\0') { Isn't is better to move "name[0] == '\0'" check to bdrv_create_dirty_bitmap, near existed name checking? +if (granularity < 512 || is_power_of_2(granularity)) { +error_setg(errp, "Granularity must be power of 2 " +

Re: [Qemu-devel] [PATCH v2 16/16] hw/intc/arm_gic: add gic_update() for grouping

2014-11-07 Thread Daniel Thompson
On 30/10/14 22:12, Greg Bellows wrote: > From: Fabian Aggeler > > GICs with grouping (GICv2 or GICv1 with Security Extensions) have a > different exception generation model which is more complicated than > without interrupt grouping. We add a new function to handle this model. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v6 01/10] qapi: Add optional field "name" to block dirty bitmap

2014-11-07 Thread Eric Blake
On 10/30/2014 04:22 AM, Fam Zheng wrote: > This field will be set for user created dirty bitmap. Also pass in an > error pointer to bdrv_create_dirty_bitmap, so when a name is already > taken on this BDS, it can report an error message. This is not global > check, two BDSes can have dirty bitmap wi

Re: [Qemu-devel] [PATCH] linux-user: Do not subtract offset from end address

2014-11-07 Thread Jonas Maebe
On 07 Nov 2014, at 08:23, Riku Voipio wrote: On Thu, Nov 06, 2014 at 01:43:13PM -0600, Tom Musta wrote: When computing the upper address of a program segment, do not subtract the offset from the virtual address; instead compute the sum of the virtual address and the memory size. Thanks,

Re: [Qemu-devel] [PATCH v6 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove

2014-11-07 Thread Eric Blake
On 10/30/2014 04:22 AM, Fam Zheng wrote: > The new command pair is added to manage user created dirty bitmap. The > dirty bitmap's name is mandatory and must be unique for the same device, > but different devices can have bitmaps with the same names. > > Signed-off-by: Fam Zheng > --- > blockdev

[Qemu-devel] [RFC][PATCH v2] add write threshold reporting for block devices

2014-11-07 Thread Francesco Romani
v1 was: "add watermark reporting for block devices", but "watermark" is incorrectly unused. Hence the change in subject. Sorry for long pause from v1 [0]; Only recently I was able to sort out all the missing details. Context for this RFC/patch is presented below as remider. Why RFC? See

[Qemu-devel] [RFC][PATCH v2] block: add write threshold reporting for block devices

2014-11-07 Thread Francesco Romani
Managing applications, like oVirt (http://www.ovirt.org), make extensive use of thin-provisioned disk images. To let the guest run smoothly and be not unnecessarily paused, oVirt sets a disk usage threshold (so called 'high water mark') based on the occupation of the device, and automatically exte

Re: [Qemu-devel] [PATCH] mips: Set the CP0.Config3.DSP and CP0.Config3.DSP2P bits

2014-11-07 Thread Leon Alrae
On 07/11/2014 12:33, Maciej W. Rozycki wrote: > On Fri, 7 Nov 2014, Leon Alrae wrote: > >> When I've been applying this patch to my mips-next candidate branch for >> 2.2 I realized that you haven't rebased it onto the recent version where >> MSA has been added to mips32r5-generic. Now I don't thin

Re: [Qemu-devel] Geometry and blocksize support for backing devices

2014-11-07 Thread Ekaterina Tumanova
On 11/07/2014 12:17 PM, Markus Armbruster wrote: Christian Borntraeger writes: Markus, Kevin, Stefan, here is a (somewhat late) followup of some KVM forum discussions regarding block size and geometry of pass-through block devices. Let's just do a quick wrap-up (as of my understanding) and a

Re: [Qemu-devel] Add CMP2 instruction

2014-11-07 Thread Laurent Vivier
> Le 7 novembre 2014 à 11:14, "Guo, Lei" a écrit : > > > This patch aims to add CMP2 instruction for m68k family. > > > > Description: Compares the value in Rn to each bound. The effective address > contains the > > bounds pair: upper bound following the lower bound. For signed compa

Re: [Qemu-devel] [PATCHv3] seccomp: change configure to avoid arm 32 to break

2014-11-07 Thread Peter Maydell
On 7 November 2014 09:05, Eduardo Otubo wrote: > Current stable version of libseccomp (2.1.1) only supports i386 and > x86_64 archs correctly. This patch limits the usage of the syscall > filter for those archs and updates to the correct last version of > libseccomp. > > This patch also fixes the

[Qemu-devel] What "opaque" stand for?

2014-11-07 Thread Kaiyuan
Hello, all I am reviewing source of Qemu. I can see parameter called "opaque" from a lot of function like this: //@hw/timer/xilinx_timer.c static uint64_t timer_read(void *opaque, hwaddr addr, unsigned int size) { ... } , and its meaning confuse me. What does "opaque" stand for? Thanks, Kai

[Qemu-devel] [PATCH] snapshot: fixed bdrv_get_full_backing_filename can not get correct full_backing_filename

2014-11-07 Thread Jun Li
When bs->filename and bs->backing_file are relative pathname and not under the same directory, path_combine() can not give the correct path for bs->backing_file. So add get_localfile_absolute_path to get absolute path for local file. e.g: $ pwd /tmp $ /opt/qemu-git-arm/bin/qemu-img create -f qcow2

Re: [Qemu-devel] Image probing: how it can be insecure, and what we could do about it

2014-11-07 Thread Markus Armbruster
Kevin Wolf writes: > Am 06.11.2014 um 13:26 hat Markus Armbruster geschrieben: >> >> * Reuse the image *without* specifying the raw format. QEMU guesses the >> >>format based on untrusted image contents. Now QEMU guesses a format >> >>chosen by the guest, with meta-data chosen by the gu

Re: [Qemu-devel] Image probing: how it can be insecure, and what we could do about it

2014-11-07 Thread Markus Armbruster
Max Reitz writes: > On 2014-11-06 at 15:56, Jeff Cody wrote: >> On Thu, Nov 06, 2014 at 01:53:35PM +0100, Max Reitz wrote: >>> On 2014-11-06 at 13:26, Markus Armbruster wrote: Max Reitz writes: > On 2014-11-04 at 19:45, Markus Armbruster wrote: [...] >> = How this lets the gues

Re: [Qemu-devel] [PATCH v6 05/10] block: Add bdrv_copy_dirty_bitmap and bdrv_reset_dirty_bitmap

2014-11-07 Thread Vladimir Sementsov-Ogievskiy
from [PATCH v6 02/10] +void qmp_block_dirty_bitmap_remove(const char *device, const char *name, + Error **errp) +{ +BlockDriverState *bs; +BdrvDirtyBitmap *bitmap; + +bs = bdrv_find(device); +if (!bs) { +error_set(errp, QERR_DEVICE_NOT_FOU

Re: [Qemu-devel] Image probing: how it can be insecure, and what we could do about it

2014-11-07 Thread Max Reitz
On 2014-11-07 at 15:52, Markus Armbruster wrote: Max Reitz writes: On 2014-11-06 at 15:56, Jeff Cody wrote: On Thu, Nov 06, 2014 at 01:53:35PM +0100, Max Reitz wrote: On 2014-11-06 at 13:26, Markus Armbruster wrote: Max Reitz writes: On 2014-11-04 at 19:45, Markus Armbruster wrote: [...

Re: [Qemu-devel] Image probing: how it can be insecure, and what we could do about it

2014-11-07 Thread Markus Armbruster
Kevin Wolf writes: > Am 06.11.2014 um 14:57 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 04.11.2014 um 19:45 hat Markus Armbruster geschrieben: >> >> I'll try to explain all solutions fairly. Isn't easy when you're as >> >> biased towards one of them as I am. Please bea

Re: [Qemu-devel] What "opaque" stand for?

2014-11-07 Thread Peter Maydell
On 7 November 2014 14:42, Kaiyuan wrote: > > Hello, all > > I am reviewing source of Qemu. I can see parameter called "opaque" from a lot > of function like this: > //@hw/timer/xilinx_timer.c > static uint64_t timer_read(void *opaque, hwaddr addr, unsigned int size) > > { > ... > } > > > , and it

[Qemu-devel] [PATCH] virtio-scsi: work around bug in old BIOSes

2014-11-07 Thread Paolo Bonzini
Old BIOSes left some padding by mistake after the req_size/resp_size. New QEMU does not like it, thinking it is a bidirectional command. As a workaround, we can check if the ANY_LAYOUT bit is set; if not, we always consider the first buffer as the virtio-scsi request/response, because, back when Q

  1   2   >