Re: [Qemu-devel] [PULL 00/28] Changes for 2014-10-27

2014-10-28 Thread Paolo Bonzini
On 10/27/2014 07:02 PM, Andreas Färber wrote: > Thanks for picking up and reworking these. The only nit I stumbled upon > is that Peter added a new function with qdev_ prefix, which can be > renamed to device_ in a follow-up. So if a respin is needed, Which one exactly? Paolo

[Qemu-devel] [PATCH RFC 01/10] pci: Convert core to realize

2014-10-28 Thread Markus Armbruster
Implement DeviceClass methods realize() and unrealize() instead of init() and exit(). The core's initialization errors now get propagated properly, and QMP sends them instead of an unspecific "Device initialization failed" error. Unrealize can't fail, so no change there. PCIDeviceClass is unchan

[Qemu-devel] [PATCH RFC 10/10] pci-assign: Convert to realize

2014-10-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/i386/kvm/pci-assign.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c index bb206da..5a92800 100644 --- a/hw/i386/kvm/pci-assign.c +++ b/hw/i386/kvm/pci-assign.c @@ -1742,7 +

[Qemu-devel] [PATCH RFC 06/10] serial-pci: Convert to realize

2014-10-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/char/serial-pci.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/hw/char/serial-pci.c b/hw/char/serial-pci.c index f05c9b4..467c3b4 100644 --- a/hw/char/serial-pci.c +++ b/hw/char/serial-pci.c @@ -48,7 +48,7 @@ t

[Qemu-devel] [PATCH RFC 00/10] pci: Partial conversion to realize

2014-10-28 Thread Markus Armbruster
While discussing Gonglei's "[PATCH v2 00/19] usb: convert device init to realize", Paolo called the PCI conversion job "Gargantuan". This series attempts to crack it into manageable jobs. The basic idea comes from qdev core: have the core deal with just realize, but default the device models' rea

[Qemu-devel] [PATCH RFC 04/10] pcnet: pcnet_common_init() always returns 0, change to void

2014-10-28 Thread Markus Armbruster
The next commit will exploit the fact it never fails. This one makes it obvious. Signed-off-by: Markus Armbruster --- hw/net/lance.c | 3 ++- hw/net/pcnet-pci.c | 3 ++- hw/net/pcnet.c | 4 +--- hw/net/pcnet.h | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH RFC 07/10] ide/ich: Convert to realize

2014-10-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/ide/ich.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/ide/ich.c b/hw/ide/ich.c index fb1d095..b1d8874 100644 --- a/hw/ide/ich.c +++ b/hw/ide/ich.c @@ -98,7 +98,7 @@ static void pci_ich9_reset(DeviceState *dev) a

[Qemu-devel] [PATCH RFC 08/10] cirrus-vga: Convert to realize

2014-10-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/display/cirrus_vga.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index 8a5b76c..1ad1073 100644 --- a/hw/display/cirrus_vga.c +++ b/hw/display/cirrus_vga.c @@ -2969,7 +2969

[Qemu-devel] [PATCH RFC 03/10] pci: Trivial device model conversions to realize

2014-10-28 Thread Markus Armbruster
Convert the device models where initialization obviously can't fail. Signed-off-by: Markus Armbruster --- hw/acpi/piix4.c| 5 ++--- hw/audio/ac97.c| 5 ++--- hw/audio/es1370.c | 5 ++--- hw/audio/intel-hda.c | 6 ++ hw/display/vga-pci.c | 11 +

[Qemu-devel] [PATCH RFC 09/10] qxl: Convert to realize

2014-10-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/display/qxl.c | 36 +--- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index b540dd6..090b66c 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -1917,7 +1917,7 @@ st

[Qemu-devel] [PATCH RFC 02/10] pci: Permit incremental conversion of device models to realize

2014-10-28 Thread Markus Armbruster
Call the new PCIDeviceClass method realize(). Default it to pci_default_realize(), which calls old method init(). To convert a device model, make it implement realize() rather than init(). Signed-off-by: Markus Armbruster --- hw/pci/pci.c | 24 +++- include/hw/pci/p

[Qemu-devel] [PATCH RFC 05/10] pcnet: Convert to realize

2014-10-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/net/pcnet-pci.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/net/pcnet-pci.c b/hw/net/pcnet-pci.c index 50eb069..e5122a0 100644 --- a/hw/net/pcnet-pci.c +++ b/hw/net/pcnet-pci.c @@ -297,7 +297,7 @@ static NetClientInfo net_pci

Re: [Qemu-devel] [PATCH] MAINTAINERS: add myself as bootdevice.c maintainer

2014-10-28 Thread Paolo Bonzini
On 10/28/2014 02:44 AM, Gonglei wrote: > On 2014/10/23 20:27, Gerd Hoffmann wrote: > >> Hi, >> >>> I expect some of the patches to be in the Kevin's, Paolos and Gerd's >>> next pull requests. Happy to collect whatever's left after the dust >>> settled. >> >> I happily leave this one to you. >

Re: [Qemu-devel] [PATCH RFC 00/10] pci: Partial conversion to realize

2014-10-28 Thread Gonglei
On 2014/10/28 15:35, Markus Armbruster wrote: > While discussing Gonglei's "[PATCH v2 00/19] usb: convert device init > to realize", Paolo called the PCI conversion job "Gargantuan". This > series attempts to crack it into manageable jobs. > > The basic idea comes from qdev core: have the core d

Re: [Qemu-devel] [PATCH 0/2] tests: Add check-block to "make check"

2014-10-28 Thread Markus Armbruster
Fam Zheng writes: > qemu-iotests contains useful tests that have a nice coverage of block layer > code. Adding check-block (which calls tests/qemu-iotests-quick.sh) to "make > check" is good for developers' self-testing. > > With the first patch, this set takes a half minute on my laptop. If "-j"

Re: [Qemu-devel] [PATCH 2/2] iotests: Add test for non-existing backing file

2014-10-28 Thread Max Reitz
On 2014-10-27 at 18:14, Eric Blake wrote: On 10/27/2014 06:30 AM, Max Reitz wrote: Test the error message when a COW file is about to be created which is supposed to inherit the size of its backing file, while the backing file given does not actually exist. Signed-off-by: Max Reitz --- + +$QEM

Re: [Qemu-devel] [PATCH RFC 01/10] pci: Convert core to realize

2014-10-28 Thread Gonglei
On 2014/10/28 15:35, Markus Armbruster wrote: > Implement DeviceClass methods realize() and unrealize() instead of > init() and exit(). The core's initialization errors now get > propagated properly, and QMP sends them instead of an unspecific > "Device initialization failed" error. Unrealize ca

Re: [Qemu-devel] [PATCH RFC 02/10] pci: Permit incremental conversion of device models to realize

2014-10-28 Thread Gonglei
On 2014/10/28 15:35, Markus Armbruster wrote: > Call the new PCIDeviceClass method realize(). Default it to > pci_default_realize(), which calls old method init(). > > To convert a device model, make it implement realize() rather than > init(). > > Signed-off-by: Markus Armbruster > --- > hw/

Re: [Qemu-devel] [PATCH v2 1/2] hw/core/loader: implement address translation in uimage loader

2014-10-28 Thread Max Filippov
Hi, On Sun, Oct 19, 2014 at 8:04 AM, Max Filippov wrote: > Such address translation is needed when load address recorded in uImage > is a virtual address. When the actual load address is requested, return > untranslated address: user that needs the translated address can always > apply translatio

Re: [Qemu-devel] [PATCH RFC 03/10] pci: Trivial device model conversions to realize

2014-10-28 Thread Gonglei
On 2014/10/28 15:35, Markus Armbruster wrote: > Convert the device models where initialization obviously can't fail. > > Signed-off-by: Markus Armbruster > --- > hw/acpi/piix4.c| 5 ++--- > hw/audio/ac97.c| 5 ++--- > hw/audio/es1370.c | 5 ++--- > hw/audio/i

Re: [Qemu-devel] [PATCH RFC 04/10] pcnet: pcnet_common_init() always returns 0, change to void

2014-10-28 Thread Gonglei
On 2014/10/28 15:35, Markus Armbruster wrote: > The next commit will exploit the fact it never fails. This one makes > it obvious. > > Signed-off-by: Markus Armbruster > --- > hw/net/lance.c | 3 ++- > hw/net/pcnet-pci.c | 3 ++- > hw/net/pcnet.c | 4 +--- > hw/net/pcnet.h | 2 +- >

Re: [Qemu-devel] [PATCH RFC 06/10] serial-pci: Convert to realize

2014-10-28 Thread Gonglei
On 2014/10/28 15:35, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > hw/char/serial-pci.c | 22 +- > 1 file changed, 9 insertions(+), 13 deletions(-) Reviewed-by: Gonglei Best regards, -Gonglei

Re: [Qemu-devel] [PATCH RFC 07/10] ide/ich: Convert to realize

2014-10-28 Thread Gonglei
On 2014/10/28 15:35, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > hw/ide/ich.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) Reviewed-by: Gonglei Best regards, -Gonglei

Re: [Qemu-devel] [PATCH RFC 08/10] cirrus-vga: Convert to realize

2014-10-28 Thread Gonglei
On 2014/10/28 15:35, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > hw/display/cirrus_vga.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) Reviewed-by: Gonglei Best regards, -Gonglei

Re: [Qemu-devel] [PATCH RFC 09/10] qxl: Convert to realize

2014-10-28 Thread Gonglei
On 2014/10/28 15:35, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > hw/display/qxl.c | 36 +--- > 1 file changed, 17 insertions(+), 19 deletions(-) Reviewed-by: Gonglei Best regards, -Gonglei

[Qemu-devel] [PATCH 1/2] rules.mak: Allow .mo-objs and .mo-cflags in -y variables

2014-10-28 Thread Fam Zheng
Expand %.mo-objs in -y nested objects, so that we can write combined object -cflags rules like what will be done in the coming patch. Signed-off-by: Fam Zheng --- rules.mak | 5 + 1 file changed, 5 insertions(+) diff --git a/rules.mak b/rules.mak index cf76b88..f500fef 100644 --- a/rules.ma

Re: [Qemu-devel] [PATCH] hw/virtio/virtio.c: fix the vring_avail_event error

2014-10-28 Thread Bin Wu
On 2014/10/28 13:32, Michael S. Tsirkin wrote: > On Tue, Oct 28, 2014 at 02:13:02AM +, Bin Wu wrote: >> The event idx in virtio is an effective way to reduce the number of >> interrupts and exits of the guest. When the guest puts an request >> into the virtio ring, it doesn't exit immediately t

[Qemu-devel] [PATCH 0/2] buildsys: Convert SDL_CFLAGS to .mo-cflags

2014-10-28 Thread Fam Zheng
This is actually the first user of the *.mo rule syntax. It's the recommended way to specify per object flags, which also makes the sophisticated rules in rules.mak less likely to bit rot. Fam Fam Zheng (2): rules.mak: Allow .mo-objs and .mo-cflags in -y variables ui: Use the new ".mo-cflag

[Qemu-devel] [PATCH 2/2] ui: Use the new ".mo-cflags" rule syntax for SDL_CFLAGS

2014-10-28 Thread Fam Zheng
Signed-off-by: Fam Zheng --- ui/Makefile.objs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ui/Makefile.objs b/ui/Makefile.objs index 6afb52a..801cba2 100644 --- a/ui/Makefile.objs +++ b/ui/Makefile.objs @@ -10,12 +10,13 @@ vnc-obj-y += vnc-jobs.o common-obj-y += keyma

Re: [Qemu-devel] [PATCH RFC 10/10] pci-assign: Convert to realize

2014-10-28 Thread Gonglei
On 2014/10/28 15:35, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > hw/i386/kvm/pci-assign.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) Reviewed-by: Gonglei Best regards, -Gonglei

[Qemu-devel] [PATCH 2/2] vga: flip qemu 2.2 pc machine types from cirrus to stdvga

2014-10-28 Thread Gerd Hoffmann
This patch switches the default display from cirrus to vga for the new (qemu 2.2+) machine types. Old machines types stay as-is for compatibility reasons. Signed-off-by: Gerd Hoffmann --- hw/i386/pc_piix.c | 7 +-- hw/i386/pc_q35.c | 7 +-- 2 files changed, 10 insertions(+), 4 deletion

[Qemu-devel] [PATCH 0/2] vga: demote cirrus

2014-10-28 Thread Gerd Hoffmann
Hi, Time to flip the default to stdvga. Done for 2.2+ machine types only, for obvious compatibility reasons. https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful/ Gerd Hoffmann (2): vga: add default display to machine class vga: flip qemu 2.2 pc machine types from cirr

[Qemu-devel] [PATCH 1/2] vga: add default display to machine class

2014-10-28 Thread Gerd Hoffmann
This allows machine classes to specify which display device they want as default. If unspecified the current behavior (try cirrus, failing that try stdvga, failing that use no display) will be used. Signed-off-by: Gerd Hoffmann --- hw/i386/pc.c| 1 + include/hw/boards.h | 2 ++ vl.c

Re: [Qemu-devel] [PATCH] target-arm: Add guest cpu endianness determination for virtio in KVM ARM64

2014-10-28 Thread Greg Kurz
On Tue, 28 Oct 2014 12:08:01 +0530 Pranavkumar Sawargaonkar wrote: > This patch implements a fucntion pointer virtio_is_big_endian() > from "CPUClass" structure for arm64. > Function aarch64_cpu_virtio_endianness() is added to determine and > returns the guest cpu endianness to virtio. > This is

Re: [Qemu-devel] [PATCH RFC 01/10] pci: Convert core to realize

2014-10-28 Thread Markus Armbruster
Gonglei writes: > On 2014/10/28 15:35, Markus Armbruster wrote: > >> Implement DeviceClass methods realize() and unrealize() instead of >> init() and exit(). The core's initialization errors now get >> propagated properly, and QMP sends them instead of an unspecific >> "Device initialization fai

Re: [Qemu-devel] [PATCH RFC 04/10] pcnet: pcnet_common_init() always returns 0, change to void

2014-10-28 Thread Markus Armbruster
Gonglei writes: > On 2014/10/28 15:35, Markus Armbruster wrote: > >> The next commit will exploit the fact it never fails. This one makes >> it obvious. >> >> Signed-off-by: Markus Armbruster >> --- >> hw/net/lance.c | 3 ++- >> hw/net/pcnet-pci.c | 3 ++- >> hw/net/pcnet.c | 4 +--- >

[Qemu-devel] [PATCH v3 0/5] vmware-vga: fix CVE-2014-3689

2014-10-28 Thread Gerd Hoffmann
Hi, vmware-vga emulation lacks sanity checks in the hardware acceleration (blit + fill) functions. This patch series plugs the holes. v3 changes: * throw badcmd errors in case the rectangles fail the sanity checks. v2 changes: * small whitespace fixup. * do fullscreen update on invalid upda

[Qemu-devel] [PATCH v3 3/5] vmware-vga: use vmsvga_verify_rect in vmsvga_update_rect

2014-10-28 Thread Gerd Hoffmann
Switch vmsvga_update_rect over to use vmsvga_verify_rect. Slight change in behavior: We don't try to automatically fixup rectangles any more. In case we find invalid update requests we'll do a full-screen update instead. Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann Reviewed-by: Don K

[Qemu-devel] [PATCH v3 1/5] vmware-vga: CVE-2014-3689: turn off hw accel

2014-10-28 Thread Gerd Hoffmann
Quick & easy stopgap for CVE-2014-3689: We just compile out the hardware acceleration functions which lack sanity checks. Thankfully we have capability bits for them (SVGA_CAP_RECT_COPY and SVGA_CAP_RECT_FILL), so guests should deal just fine, in theory. Subsequent patches will add the missing c

[Qemu-devel] [PATCH v3 4/5] vmware-vga: use vmsvga_verify_rect in vmsvga_copy_rect

2014-10-28 Thread Gerd Hoffmann
Add verification to vmsvga_copy_rect, re-enable HW_RECT_ACCEL. Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann --- hw/display/vmware_vga.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c index 9d7

[Qemu-devel] [PATCH v3 2/5] vmware-vga: add vmsvga_verify_rect

2014-10-28 Thread Gerd Hoffmann
Add verification function for rectangles, returning true if verification passes and false otherwise. Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann Reviewed-by: Don Koch --- hw/display/vmware_vga.c | 53 - 1 file changed, 52 insertions(+)

[Qemu-devel] [PATCH v3 5/5] vmware-vga: use vmsvga_verify_rect in vmsvga_fill_rect

2014-10-28 Thread Gerd Hoffmann
Add verification to vmsvga_fill_rect, re-enable HW_FILL_ACCEL. Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann --- hw/display/vmware_vga.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c index 73a1b5

[Qemu-devel] [PATCH v2] xhci: add property to turn on/off streams support

2014-10-28 Thread Gerd Hoffmann
streams support in usb-redir and usb-host works only with recent enough versions of the support libraries (libusbredir and libusbx). Failure mode is rather unelegant: Any stream usb transfers will throw stall errors. Turning off support for streams in the xhci host controller will work better as

Re: [Qemu-devel] [PATCH v2] xhci: add property to turn on/off streams support

2014-10-28 Thread Hans de Goede
Hi, On 10/28/2014 10:57 AM, Gerd Hoffmann wrote: > streams support in usb-redir and usb-host works only with recent enough > versions of the support libraries (libusbredir and libusbx). Failure > mode is rather unelegant: Any stream usb transfers will throw stall > errors. Turning off support f

[Qemu-devel] [PATCH v2] block/vdi: Limit maximum size even futher

2014-10-28 Thread Max Reitz
The block layer read and write functions do not like requests which are bigger than INT_MAX bytes. Since the VDI bmap is read and written in a single operation, its size is therefore limited accordingly. This reduces the maximum VDI image size supported by QEMU to half of what it currently is (down

[Qemu-devel] [PULL 0/2] gtk: fix two warnings with gtk 3.14+

2014-10-28 Thread Gerd Hoffmann
in the git repository at: git://git.kraxel.org/qemu tags/pull-gtk-20141028-1 for you to fetch changes up to 316cb068bdaf456040934f7368e09be7be4d942e: gtk: avoid gd_widget_reparent with gtk 3.14+ (2014-10-28 11:25:14 +0100) gt

[Qemu-devel] [PULL 1/2] gtk: drop gtk_widget_set_double_buffered call

2014-10-28 Thread Gerd Hoffmann
Dunno why it is here. Removing it seems to have no ill side effects. It is depricated in 3.14+. In some cases it has no effect since 3.10 according to the docs: https://developer.gnome.org/gtk3/stable/GtkWidget.html#gtk-widget-set-double-buffered Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 1

[Qemu-devel] [PULL 2/2] gtk: avoid gd_widget_reparent with gtk 3.14+

2014-10-28 Thread Gerd Hoffmann
gtk_widget_reparent is depricated in gtk 3.14, stop using it. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 9727dec..a5f6869 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -435,6 +435,15 @@ static v

Re: [Qemu-devel] [PATCH RFC 04/10] pcnet: pcnet_common_init() always returns 0, change to void

2014-10-28 Thread Gonglei
On 2014/10/28 17:41, Markus Armbruster wrote: > Gonglei writes: > >> On 2014/10/28 15:35, Markus Armbruster wrote: >> >>> The next commit will exploit the fact it never fails. This one makes >>> it obvious. >>> >>> Signed-off-by: Markus Armbruster >>> --- >>> hw/net/lance.c | 3 ++- >>> h

Re: [Qemu-devel] [PATCH 2/2] vga: flip qemu 2.2 pc machine types from cirrus to stdvga

2014-10-28 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > This patch switches the default display from cirrus to vga > for the new (qemu 2.2+) machine types. Old machines types > stay as-is for compatibility reasons. > > Signed-off-by: Gerd Hoffmann > --- > hw/i386/pc_piix.c | 7 +-- > hw/i386/pc_q35.c

[Qemu-devel] Better Cortex-M support?

2014-10-28 Thread Liviu Ionescu
Hi! I'm currently maintaining the GNU ARM Eclipse plug-ins (http://gnuarmeclipse.livius.net/blog/), and I'm considering, for the mid-term future, adding a new debugging plug-in to run certain tests under un emulator, and the first choice was QEMU. Do you know if there are any plans to improve

Re: [Qemu-devel] [PATCH v14 00/14] qemu-img: Implement commit like QMP

2014-10-28 Thread Kevin Wolf
Am 24.10.2014 um 15:57 hat Max Reitz geschrieben: > qemu-img should use QMP commands whenever possible in order to ensure > feature completeness of both online and offline image operations. For > the "commit" command, this is relatively easy, so implement it first > (in the hope that indeed others

Re: [Qemu-devel] [PATCH 2/2] vga: flip qemu 2.2 pc machine types from cirrus to stdvga

2014-10-28 Thread Gerd Hoffmann
On Di, 2014-10-28 at 10:37 +, Dr. David Alan Gilbert wrote: > * Gerd Hoffmann (kra...@redhat.com) wrote: > > This patch switches the default display from cirrus to vga > > for the new (qemu 2.2+) machine types. Old machines types > > stay as-is for compatibility reasons. > > > > Signed-off-by

Re: [Qemu-devel] [PATCH] target-arm: Add guest cpu endianness determination for virtio in KVM ARM64

2014-10-28 Thread Peter Maydell
On 28 October 2014 06:38, Pranavkumar Sawargaonkar wrote: > This patch implements a fucntion pointer virtio_is_big_endian() > from "CPUClass" structure for arm64. > Function aarch64_cpu_virtio_endianness() is added to determine and > returns the guest cpu endianness to virtio. > This is required f

[Qemu-devel] [PULL 3/5] libcacard: don't free sign buffer while sign op is pending

2014-10-28 Thread Gerd Hoffmann
From: Ray Strode commit 57f97834efe0c208ffadc9d2959f3d3d55580e52 cleaned up the cac_applet_pki_process_apdu function to have a single exit point. Unfortunately, that commit introduced a bug where the sign buffer can get free'd and nullified while it's still being used. This commit corrects the b

[Qemu-devel] [PULL 4/5] xhci: add property to turn on/off streams support

2014-10-28 Thread Gerd Hoffmann
streams support in usb-redir and usb-host works only with recent enough versions of the support libraries (libusbredir and libusbx). Failure mode is rather unelegant: Any stream usb transfers will throw stall errors. Turning off support for streams in the xhci host controller will work better as

[Qemu-devel] [PULL 1/5] libcacard: introduce new vcard_emul_logout

2014-10-28 Thread Gerd Hoffmann
From: Ray Strode vcard_emul_reset currently only logs NSS out, but there is a TODO for potentially sending insertion/removal events when powering down or powering up. For clarity, this commit moves the current guts of vcard_emul_reset to a new vcard_emul_logout function which will never send ins

[Qemu-devel] [PULL 5/5] uhci: remove useless DEBUG

2014-10-28 Thread Gerd Hoffmann
From: Gonglei commit 50dcc0f8 (uhci: tracing support) had removed DPRINTF, the DEBUG marco is useless now, remove it. Signed-off-by: Gonglei Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-uhci.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c index 5b8

[Qemu-devel] [PULL 0/5] usb patch queue.

2014-10-28 Thread Gerd Hoffmann
0-27 15:05:09 +) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-usb-20141028-1 for you to fetch changes up to a65e4ef90f0fb437b8e74e250a6f94aa4ecfa25c: uhci: remove useless DEBUG (2014-10-28 11:3

[Qemu-devel] [PULL 2/5] libcacard: Lock NSS cert db when selecting an applet on an emulated card

2014-10-28 Thread Gerd Hoffmann
From: Ray Strode When a process in a guest uses an emulated smartcard, libcacard running on the host passes the PIN from the guest to the PK11_Authenticate NSS function. The first time PK11_Authenticate is called the passed in PIN is used to unlock the certificate database. Subsequent calls to PK

Re: [Qemu-devel] [PATCH] MAINTAINERS: add section for QEMU Guest Agent

2014-10-28 Thread Stefan Hajnoczi
On Wed, Oct 22, 2014 at 07:05:36AM -0500, Michael Roth wrote: > Signed-off-by: Michael Roth > --- > MAINTAINERS | 6 ++ > 1 file changed, 6 insertions(+) Reviewed-by: Stefan Hajnoczi pgpEzITpprnSz.pgp Description: PGP signature

Re: [Qemu-devel] [PATCHv3 0/6] multiwrite patches for 2.2

2014-10-28 Thread Stefan Hajnoczi
On Sat, Oct 25, 2014 at 06:55:47PM +0200, Peter Lieven wrote: > This adds some preparing patches for upcoming multiwrite modifications. > I will leave the dangerous patches for after 2.2 release. Soft freeze was 1st October: http://qemu-project.org/Planning/2.2 This series seems to be a new featu

[Qemu-devel] [PULL 1/2] vnc: sanitize bits_per_pixel from the client

2014-10-28 Thread Gerd Hoffmann
From: Petr Matousek bits_per_pixel that are less than 8 could result in accessing non-initialized buffers later in the code due to the expectation that bytes_per_pixel value that is used to initialize these buffers is never zero. To fix this check that bits_per_pixel from the client is one of th

[Qemu-devel] [PULL 0/2] vnc patch queue

2014-10-28 Thread Gerd Hoffmann
ository at: git://git.kraxel.org/qemu tags/pull-vnc-20141028-1 for you to fetch changes up to 9d6b20704734fe1ab789400806ebd54f579d50a2: vnc: return directly if no vnc client connected (2014-10-28 11:51:04 +0100) vnc: return dire

[Qemu-devel] [PULL 2/2] vnc: return directly if no vnc client connected

2014-10-28 Thread Gerd Hoffmann
From: ChenLiang graphic_hw_update and vnc_refresh_server_surface aren't need to do when no vnc client connected. It can reduce lock contention, because vnc_refresh will hold global big lock two millisecond every three seconds. Signed-off-by: ChenLiang Signed-off-by: Gonglei Signed-off-by: Gerd

Re: [Qemu-devel] [PATCHv3 1/6] block: add accounting for merged requests

2014-10-28 Thread Stefan Hajnoczi
On Sat, Oct 25, 2014 at 06:55:48PM +0200, Peter Lieven wrote: > diff --git a/block/accounting.c b/block/accounting.c > index edbb1cc..f3162d1 100644 > --- a/block/accounting.c > +++ b/block/accounting.c > @@ -52,3 +52,10 @@ void block_acct_highest_sector(BlockAcctStats *stats, > int64_t sector_num

Re: [Qemu-devel] [PATCH] vhost-user-test: revert changes to make 'make check' happy

2014-10-28 Thread Gonglei
On 2014/10/26 15:46, Gonglei (Arei) wrote: > From: Gonglei > > After commit 89b516d8, some logics is turbid. > First, vhost-usr-test.c rely on glib-compat.h because > of using G_TIME_SPAN_SECOND [glib < 2.26] and g_get_monotonic_time(), > but vhost-usr-test.c defined QEMU_GLIB_COMPAT_H, which ma

Re: [Qemu-devel] [PATCHv3 4/6] hw/virtio-blk: add a constant for max number of merged requests

2014-10-28 Thread Stefan Hajnoczi
On Sat, Oct 25, 2014 at 06:55:51PM +0200, Peter Lieven wrote: > As it was not obvious (at least for me) where the 32 comes from; > add a constant for it. > > Signed-off-by: Peter Lieven > Reviewed-by: Max Reitz > --- > hw/block/virtio-blk.c |4 +++- > 1 file changed, 3 insertions(+), 1 dele

Re: [Qemu-devel] [PATCHv3 2/6] block: introduce bdrv_runtime_opts

2014-10-28 Thread Stefan Hajnoczi
On Sat, Oct 25, 2014 at 06:55:49PM +0200, Peter Lieven wrote: > This patch (orginally by Kevin) adds a bdrv_runtime_opts QemuOptsList. > The list will absorb all options that belong to the BDS (and not the > BlockBackend) and will be parsed and handled in bdrv_open_common. > > Signed-off-by: Kevin

Re: [Qemu-devel] [PATCHv3 3/6] block: add a knob to disable multiwrite_merge

2014-10-28 Thread Stefan Hajnoczi
On Sat, Oct 25, 2014 at 06:55:50PM +0200, Peter Lieven wrote: > diff --git a/block.c b/block.c > index f05ea0c..f3da5dd 100644 > --- a/block.c > +++ b/block.c > @@ -884,6 +884,10 @@ static QemuOptsList bdrv_runtime_opts = { > .name = "node-name", > .type = QEMU_OPT_STRING,

Re: [Qemu-devel] [PATCHv3 3/6] block: add a knob to disable multiwrite_merge

2014-10-28 Thread Peter Lieven
On 28.10.2014 12:11, Stefan Hajnoczi wrote: On Sat, Oct 25, 2014 at 06:55:50PM +0200, Peter Lieven wrote: diff --git a/block.c b/block.c index f05ea0c..f3da5dd 100644 --- a/block.c +++ b/block.c @@ -884,6 +884,10 @@ static QemuOptsList bdrv_runtime_opts = { .name = "node-name",

Re: [Qemu-devel] [PATCH] MAINTAINERS: add myself as bootdevice.c maintainer

2014-10-28 Thread Gonglei
On 2014/10/28 15:52, Paolo Bonzini wrote: > > > On 10/28/2014 02:44 AM, Gonglei wrote: >> On 2014/10/23 20:27, Gerd Hoffmann wrote: >> >>> Hi, >>> I expect some of the patches to be in the Kevin's, Paolos and Gerd's next pull requests. Happy to collect whatever's left after the dust

Re: [Qemu-devel] [PATCHv3 6/6] block: fix qemu-iotest reference output for test 067

2014-10-28 Thread Stefan Hajnoczi
On Sat, Oct 25, 2014 at 06:55:53PM +0200, Peter Lieven wrote: > Output is changed by the addition of the write-merging parameter > > Signed-off-by: Peter Lieven > Reviewed-by: Max Reitz > --- > tests/qemu-iotests/067.out | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Plea

Re: [Qemu-devel] [PATCHv3 2/6] block: introduce bdrv_runtime_opts

2014-10-28 Thread Max Reitz
On 2014-10-28 at 12:14, Stefan Hajnoczi wrote: On Sat, Oct 25, 2014 at 06:55:49PM +0200, Peter Lieven wrote: This patch (orginally by Kevin) adds a bdrv_runtime_opts QemuOptsList. The list will absorb all options that belong to the BDS (and not the BlockBackend) and will be parsed and handled in

Re: [Qemu-devel] Better Cortex-M support?

2014-10-28 Thread Peter Maydell
On 28 October 2014 10:43, Liviu Ionescu wrote: > Do you know if there are any plans to improve the Cortex-M support? > As it is now, for my needs, I would consider it barely usable. I don't know of anybody actively working on it. If people want to contribute patches to improve it I'm happy to rev

Re: [Qemu-devel] [PATCH 0/2] block: Propagate error in bdrv_img_create()

2014-10-28 Thread Kevin Wolf
Am 27.10.2014 um 13:30 hat Max Reitz geschrieben: > Currently, when trying to create a backed image without specifying its > size, when the backing file does not exist or is not accessible, an > appropriate error message will be generated which is then (in > bdrv_img_create()) prefixed with the ima

Re: [Qemu-devel] Better Cortex-M support?

2014-10-28 Thread Liviu Ionescu
On 28 Oct 2014, at 14:22, Peter Maydell wrote: > ... We do see a steady trickle of > people complaining that the M profile emulation is not > very good, so it would be nice to see it more actively > maintained upstream. ok, than I'll probably clone the repo, add a 'gnuarmeclipse' branch and ex

Re: [Qemu-devel] Better Cortex-M support?

2014-10-28 Thread Peter Maydell
On 28 October 2014 12:40, Liviu Ionescu wrote: > as for the semihosting support, if I try to use it, I get: > > qemu: Unsupported SemiHosting SWI 0x00 > R00= R01= R02= R03= > R04= R05= R06= R07=200ffed8 > R08= R09= R10=000

Re: [Qemu-devel] Better Cortex-M support?

2014-10-28 Thread Liviu Ionescu
On 28 Oct 2014, at 14:45, Peter Maydell wrote: >> qemu: Unsupported SemiHosting SWI 0x00 >> R00= R01= R02= R03= >> R04= R05= R06= R07=200ffed8 >> R08= R09= R10= R11= >> R12= R13=200ffed8 R14=22c5

Re: [Qemu-devel] Better Cortex-M support?

2014-10-28 Thread Peter Maydell
On 28 October 2014 12:52, Liviu Ionescu wrote: > > On 28 Oct 2014, at 14:45, Peter Maydell wrote: > >>> qemu: Unsupported SemiHosting SWI 0x00 >>> R00= R01= R02= R03= >>> R04= R05= R06= R07=200ffed8 >>> R08= R09= R10=

[Qemu-devel] QEMU command line security property

2014-10-28 Thread Greg Bellows
Hello all, I am in the process of adding ARM security extension support to QEMU and need a mechanism for enabling it and changing the boot default security state. In the case of ARM, the security extensions apply to multiple HW components (CPU, GIC, ...) so it makes the most sense to add a machin

Re: [Qemu-devel] Better Cortex-M support?

2014-10-28 Thread Liviu Ionescu
On 28 Oct 2014, at 14:57, Peter Maydell wrote: > On 28 October 2014 12:52, Liviu Ionescu wrote: >> >> On 28 Oct 2014, at 14:45, Peter Maydell wrote: >> qemu: Unsupported SemiHosting SWI 0x00 R00= R01= R02= R03= R04= R05= R06=

Re: [Qemu-devel] [PATCHv6 0/6] introduce max_transfer_length

2014-10-28 Thread Stefan Hajnoczi
On Mon, Oct 27, 2014 at 10:18:42AM +0100, Peter Lieven wrote: > This series adds the basics for introducing a maximum transfer length > to the block layer. Its main purpose is currently avoiding that > a multiwrite_merge exceeds the max_xfer_len of an attached iSCSI LUN. > This is a required bug fi

Re: [Qemu-devel] Better Cortex-M support?

2014-10-28 Thread Peter Maydell
On 28 October 2014 13:23, Liviu Ionescu wrote: > > On 28 Oct 2014, at 14:57, Peter Maydell wrote: > >> On 28 October 2014 12:52, Liviu Ionescu wrote: >>> >>> On 28 Oct 2014, at 14:45, Peter Maydell wrote: >>> > qemu: Unsupported SemiHosting SWI 0x00 > R00= R01= R02=0

Re: [Qemu-devel] [PATCH 0/6] AHCI Device Fixes

2014-10-28 Thread Stefan Hajnoczi
On Wed, Oct 01, 2014 at 06:55:45PM -0400, John Snow wrote: > Based off of feedback from the RFC of the same name, > this series batches together a group of fixes that > improve the AHCI device to fix a number of bugs. > > A number of fixes included in the RFC that provide more > radical changes ar

Re: [Qemu-devel] Better Cortex-M support?

2014-10-28 Thread Liviu Ionescu
> Do you have a test binary (plus qemu command line) you > can send me? sure: https://dl.dropboxusercontent.com/u/78151643/minimal.elf for reference, when running the code with Bechus (2.1.1), the result is: ilg-mbp:build ilg$ /Users/ilg/bin/qemu-system-arm -machine stm32-p103 -nographic -moni

Re: [Qemu-devel] [PATCH] target-arm: Add guest cpu endianness determination for virtio in KVM ARM64

2014-10-28 Thread Pranavkumar Sawargaonkar
Hi Greg, On 28 October 2014 14:56, Greg Kurz wrote: > > On Tue, 28 Oct 2014 12:08:01 +0530 > Pranavkumar Sawargaonkar wrote: > > > This patch implements a fucntion pointer virtio_is_big_endian() > > from "CPUClass" structure for arm64. > > Function aarch64_cpu_virtio_endianness() is added to det

Re: [Qemu-devel] Better Cortex-M support?

2014-10-28 Thread Peter Maydell
On 28 October 2014 13:54, Liviu Ionescu wrote: > >> Do you have a test binary (plus qemu command line) you >> can send me? > > sure: https://dl.dropboxusercontent.com/u/78151643/minimal.elf > exactly the same binary, with 2.1.50: > > ilg-mbp:build ilg$ > /Users/ilg/Work/NoBackup/qemu/qemu.git/a

Re: [Qemu-devel] [PATCH] target-arm: Add guest cpu endianness determination for virtio in KVM ARM64

2014-10-28 Thread Pranavkumar Sawargaonkar
Hi PMM, On 28 October 2014 16:18, Peter Maydell wrote: > On 28 October 2014 06:38, Pranavkumar Sawargaonkar > wrote: >> This patch implements a fucntion pointer virtio_is_big_endian() >> from "CPUClass" structure for arm64. >> Function aarch64_cpu_virtio_endianness() is added to determine and >>

Re: [Qemu-devel] [PATCH v4 0/3] raw-posix: Fix raw_co_get_block_status()

2014-10-28 Thread Kevin Wolf
Am 24.10.2014 um 12:57 hat Max Reitz geschrieben: > raw_co_get_block_status() should return 0 and set *pnum to 0 after the > EOF; currently it does this merely by accident, so implement it > directly. Also, nb_sectors should be clamped against the image end. > > While doing that, centralize the ge

Re: [Qemu-devel] [PATCH] block/curl: Improve type safety of s->timeout.

2014-10-28 Thread Stefan Hajnoczi
On Mon, Oct 06, 2014 at 03:32:10PM +0100, Richard W.M. Jones wrote: > qemu_opt_get_number returns a uint64_t, and curl_easy_setopt expects a > long (not an int). > > Store the timeout (which is a positive number of seconds) as a > uint64_t. Check that the number given by the user is reasonable. >

Re: [Qemu-devel] Better Cortex-M support?

2014-10-28 Thread Liviu Ionescu
On 28 Oct 2014, at 16:18, Peter Maydell wrote: > Thanks. I've identified what's happening here, and > it's not a bug in QEMU as such. The 'lm3s6965evb' > model is of a microcontroller with 64KB of SRAM, > so valid RAM is only from 0x2000 to 0x2001, > but your binary is trying to use the

Re: [Qemu-devel] [PATCH] snapshot: Reset err to NULL to avoid double free

2014-10-28 Thread Stefan Hajnoczi
On Mon, Oct 06, 2014 at 09:33:45AM -0700, Chris Spiegel wrote: > If an error occurs in bdrv_snapshot_delete_by_id_or_name(), "err" is > freed. If "err" is not set to NULL before calling > bdrv_snapshot_delete_by_id_or_name() again, it will not be updated on > error, and will be freed again. > > T

Re: [Qemu-devel] [PATCH v5] linux-user: Let user specify random seed

2014-10-28 Thread Magnus Reftel
On Thu, Oct 23, 2014 at 12:03 PM, Riku Voipio wrote: > On Wed, Oct 22, 2014 at 03:17:33PM +0200, Magnus Reftel wrote: >> Ping. >> http://patchwork.ozlabs.org/patch/399483/ > > Applied to linux-user que, thanks Thanks! BR Magnus Reftel

Re: [Qemu-devel] Better Cortex-M support?

2014-10-28 Thread Peter Maydell
On 28 October 2014 14:37, Liviu Ionescu wrote: > On 28 Oct 2014, at 16:18, Peter Maydell wrote: >> Thanks. I've identified what's happening here, and >> it's not a bug in QEMU as such. The 'lm3s6965evb' >> model is of a microcontroller with 64KB of SRAM, >> so valid RAM is only from 0x2000 to

Re: [Qemu-devel] [PATCH 0/3] parallels: additional iotests and a minor bugfix

2014-10-28 Thread Stefan Hajnoczi
On Wed, Oct 08, 2014 at 01:13:27PM +0400, Denis V. Lunev wrote: > Pls find here test authentic test material, i.e. parallels images > with "WithoutFreeSpace" and "WithouFreSpacExt" signatures created > in authentic way + a minor bug fix for access to non-initialized > memory found by valgrind. > >

Re: [Qemu-devel] [PATCH v7 08/32] target-arm: add async excp target_el function

2014-10-28 Thread Greg Bellows
This is the table we were talking about in patch 7. A table has been added and the function reworked in v8. On 24 October 2014 11:26, Peter Maydell wrote: > On 21 October 2014 17:55, Greg Bellows wrote: > > From: Fabian Aggeler > > > > Adds a dedicated function for IRQ and FIQ exceptions to

Re: [Qemu-devel] Better Cortex-M support?

2014-10-28 Thread Liviu Ionescu
On 28 Oct 2014, at 16:40, Peter Maydell wrote: > There's no such thing as a "generic Cortex-M3 emulation". > We model actual hardware (though in this case not a very > useful set of boards). at least for now I do not plan to go into emulating actual hardware, I'd like to first fix the generic

[Qemu-devel] [PATCH v3 1/1] virtio: serial: expose a 'guest_writable' callback for users

2014-10-28 Thread Amit Shah
Users of virtio-serial may want to know when a port becomes writable. A port can stop accepting writes if the guest port is open but not being read from. In this case, data gets queued up in the virtqueue, and after the vq is full, writes to the port do not succeed. When the guest reads off a vq

Re: [Qemu-devel] [PATCH 2/2] spice-char: notify the server when chardev is writable

2014-10-28 Thread Amit Shah
On (Mon) 27 Oct 2014 [17:32:31], Marc-André Lureau wrote: > On Mon, Oct 27, 2014 at 1:43 PM, Amit Shah wrote: > > > Great, so there's no other change required to actually use the > > functionality in my patch? Does my patch fit your need fine, or do > > you need to tweak the notification somehow

  1   2   >