On 10/22/2014 04:39 PM, Zhang Haoyu wrote:
> Use local variable to bdrv_pwrite_sync L1 table,
> needless to make conversion of cached L1 table between
> big-endian and host style.
...
Okay, so, why do you think that a patch which prompted such a hot
discussion and is at v5 already is applicable to
Am 23.10.2014 um 00:18 hat Eric Blake geschrieben:
> On 10/21/2014 03:24 AM, Max Reitz wrote:
> > On 2014-10-21 at 10:04, Zhang Haoyu wrote:
> >> Use local variable to bdrv_pwrite_sync L1 table,
> >> needless to make conversion of cached L1 table between
> >> big-endian and host style.
> >>
> >> Si
On 2014-10-22 at 13:56, Kevin Wolf wrote:
Am 21.10.2014 um 10:51 hat Max Reitz geschrieben:
The bmap size in block/vdi.c may exceed INT_MAX. Using
bdrv_pwrite_sync() (which takes an int byte count) is therefore not a
good idea. The second patch of this series fixes this by replacing
bdrv_pwrite_
On 2014-10-22 at 13:56, Kevin Wolf wrote:
Am 21.10.2014 um 10:51 hat Max Reitz geschrieben:
The bmap size in block/vdi.c may exceed INT_MAX. Using
bdrv_pwrite_sync() (which takes an int byte count) is therefore not a
good idea. The second patch of this series fixes this by replacing
bdrv_pwrite_
On 10/23/2014 09:39 AM, arei.gong...@huawei.com wrote:
[]
> --- a/vl.c
> +++ b/vl.c
> @@ -4318,7 +4318,7 @@ int main(int argc, char **argv, char **envp)
> if (vnc_display) {
> Error *local_err = NULL;
> vnc_display_init(ds);
> -vnc_display_open(ds, vnc_display, &local
On Thu, Oct 23, 2014 at 07:34:16AM +1100, Benjamin Herrenschmidt wrote:
> On Wed, 2014-10-22 at 16:17 +0200, Jan Kiszka wrote:
> > I thought about this again, and I'm not sure anymore if we can use
> > ACPI
> > to "black-list" the incompatible virtio devices. Reason: hotplug. To
> > my
> > understa
On 10/23/2014 09:39 AM, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> vnc_display_close() is called in vnc_display_open().
> And in this moment, the ds variable is initilized
> at vnc_display_init(). Calling vnc_display_close()
> is superfluous.
Maybe the intent was to be able to open/close
On 2014-10-23 at 09:03, Kevin Wolf wrote:
Am 23.10.2014 um 00:18 hat Eric Blake geschrieben:
On 10/21/2014 03:24 AM, Max Reitz wrote:
On 2014-10-21 at 10:04, Zhang Haoyu wrote:
Use local variable to bdrv_pwrite_sync L1 table,
needless to make conversion of cached L1 table between
big-endian an
On 23 October 2014 07:49, Michael Tokarev wrote:
> If upstream already have a patch for this, why not take the
> upstream's solution now, so we wont need to revert our solution
> before applying next drop from upstream?
Upstream haven't released it yet.
> BTW, how the "upstream drop" is done, an
On 23 October 2014 07:33, Michael Tokarev wrote:
> On 09/22/2014 11:34 AM, Michael Tokarev wrote:
>> 22.09.2014 10:23, Markus Armbruster wrote:
>>> Michael Tokarev writes:
>>>
Applied to -trivial, thank you!
>>>
>>> Makes my 'hmp: Remove "info pcmcia"' conflict. Either revert this one
>>> b
On 2014-10-22 at 18:50, Eric Blake wrote:
On 10/22/2014 09:57 AM, Max Reitz wrote:
It should not be happening, but it is possible to truncate an image
outside of qemu while qemu is running (or any of the qemu tools using
the block layer. raw_co_get_block_status() should not break then.
Signed-o
On 2014-10-22 at 18:57, Eric Blake wrote:
On 10/22/2014 09:57 AM, Max Reitz wrote:
As its comment states, raw_co_get_block_status() should unconditionally
return 0 and set *pnum to 0 for after EOF.
An assertion after lseek(..., SEEK_HOLE) tried to catch this case by
asserting that errno != -ENX
On 2014-10-23 at 09:27, Max Reitz wrote:
On 2014-10-22 at 18:57, Eric Blake wrote:
On 10/22/2014 09:57 AM, Max Reitz wrote:
As its comment states, raw_co_get_block_status() should unconditionally
return 0 and set *pnum to 0 for after EOF.
An assertion after lseek(..., SEEK_HOLE) tried to catch
On 2014-10-22 at 19:00, Eric Blake wrote:
On 10/22/2014 09:57 AM, Max Reitz wrote:
Instead of generating the full return value thrice in try_fiemap(),
try_seek_hole() and as a fall-back in raw_co_get_block_status() itself,
generate the value only in raw_co_get_block_status().
While at it, also
On 23/10/2014 07:57, Pavel Dovgaluk wrote:
From: Frederic Konrad [mailto:fred.kon...@greensocs.com]
On 22/10/2014 13:38, Pavel Dovgalyuk wrote:
Hi Pavel,
This patch fixes instructions counting when execution is stopped on
breakpoint (e.g. set from gdb). Without a patch extra instruction is tran
On 2014/10/23 15:09, Michael Tokarev wrote:
> On 10/23/2014 09:39 AM, arei.gong...@huawei.com wrote:
>> From: Gonglei
>>
>> vnc_display_close() is called in vnc_display_open().
>> And in this moment, the ds variable is initilized
>> at vnc_display_init(). Calling vnc_display_close()
>> is superfl
Am 23.10.2014 um 09:26 hat Max Reitz geschrieben:
> On 2014-10-22 at 18:50, Eric Blake wrote:
> >On 10/22/2014 09:57 AM, Max Reitz wrote:
> >>It should not be happening, but it is possible to truncate an image
> >>outside of qemu while qemu is running (or any of the qemu tools using
> >>the block l
On 2014-10-23 at 09:46, Kevin Wolf wrote:
Am 23.10.2014 um 09:26 hat Max Reitz geschrieben:
On 2014-10-22 at 18:50, Eric Blake wrote:
On 10/22/2014 09:57 AM, Max Reitz wrote:
It should not be happening, but it is possible to truncate an image
outside of qemu while qemu is running (or any of th
On 2014-10-22 at 20:35, Kevin Wolf wrote:
Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
bdrv_make_empty() is currently only called if the current image
represents an external snapshot that has been committed to its base
image; it is therefore unlikely to have internal snapshots. In this
case
> From: Frederic Konrad [mailto:fred.kon...@greensocs.com]
> On 23/10/2014 07:57, Pavel Dovgaluk wrote:
> >> From: Frederic Konrad [mailto:fred.kon...@greensocs.com]
> >> On 22/10/2014 13:38, Pavel Dovgalyuk wrote:
> >>
> >> Hi Pavel,
> >>> This patch fixes instructions counting when execution is s
On Do, 2014-10-23 at 14:33 +0800, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> When using qmp change vnc interface, will leak fd
> of vs->lsock and vs->lwebsock (if configed). Close
> them before: re-evaluate.
I think we can do that before "if (reverse)", then we'll need the code
only once
On 2014/10/23 15:09, Michael Tokarev wrote:
> On 10/23/2014 09:39 AM, arei.gong...@huawei.com wrote:
> []
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -4318,7 +4318,7 @@ int main(int argc, char **argv, char **envp)
>> if (vnc_display) {
>> Error *local_err = NULL;
>> vnc_display_init(d
On Do, 2014-10-23 at 14:33 +0800, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> When using qmp change vnc interface, will leak fd
> of vs->lsock and vs->lwebsock (if configed). Close
> them before: re-evaluate.
Ah, the file handles are leaked because you dropped the
vnc_display_close() call
Michael Tokarev writes:
> On 10/22/2014 05:25 PM, Arthur Gautier wrote:
>> We can not rely on int cast to get a correct number of cylinders. The
>> cylinders information was wrong in 49.% of cases.
>>
>> This ensures the cylinders always gets the ceiling value.
>
> Good thing, especially the
On 2014/10/23 15:57, Gerd Hoffmann wrote:
> On Do, 2014-10-23 at 14:33 +0800, arei.gong...@huawei.com wrote:
>> From: Gonglei
>>
>> When using qmp change vnc interface, will leak fd
>> of vs->lsock and vs->lwebsock (if configed). Close
>> them before: re-evaluate.
>
> Ah, the file handles are le
On Do, 2014-10-23 at 13:39 +0800, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> Beside those problems, I also found another issue, see below pls.
>
> Qemu command line:
> $ ./qemu-system-x86_64 -enable-kvm -m 4096 -smp 4 -name redhat6.2 -drive
> file=/home/redhat.img,if=none,id=drive-ide0-
On 10/09/2014 06:00 PM, Chen Gang wrote:
> The related variables are useless, need be removed, or can not pass
> microblaze building, after fix it, can build microblaze, successfully.
...
Applied to trivial (with subject fixup), thanks!
/mjt
The allocator in malloc-pc has been extracted, so it can be used in every arch.
This operation showed that both the alloc and free functions can be also
generic.
Because of this, the QGuestAllocator has been removed from is function to wrap
the alloc and free function, and now just contains the all
On 2014/10/23 16:08, Gerd Hoffmann wrote:
> On Do, 2014-10-23 at 13:39 +0800, arei.gong...@huawei.com wrote:
>> From: Gonglei
>>
>> Beside those problems, I also found another issue, see below pls.
>>
>> Qemu command line:
>> $ ./qemu-system-x86_64 -enable-kvm -m 4096 -smp 4 -name redhat6.2 -driv
On Wed, Oct 22, 2014 at 11:17:11AM -0600, Alex Williamson wrote:
> On Wed, 2014-10-22 at 17:13 +0200, Frank Blaschka wrote:
> > From: Frank Blaschka
> >
> > Let the kernel announce if INTx is available. Yes, there are platforms
> > (e.g. s390) which do not support INTx.
> >
> > Signed-off-by: Fr
Am 23.10.2014 um 09:46 hat Max Reitz geschrieben:
> On 2014-10-22 at 20:35, Kevin Wolf wrote:
> >Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
> >>bdrv_make_empty() is currently only called if the current image
> >>represents an external snapshot that has been committed to its base
> >>image; i
Gerd Hoffmann writes:
> On Mi, 2014-10-22 at 11:07 +0800, arei.gong...@huawei.com wrote:
>> From: Gonglei
>>
>> bootdevice.c was created by me, and I wrote most of
>> the code in this file. And now I can maintain it,
>> I'd hope nobody object this.
>
> That is perfectly fine. I'll go add it in
On 2014-10-23 at 10:29, Kevin Wolf wrote:
Am 23.10.2014 um 09:46 hat Max Reitz geschrieben:
On 2014-10-22 at 20:35, Kevin Wolf wrote:
Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
bdrv_make_empty() is currently only called if the current image
represents an external snapshot that has been
On 10/23/2014 10:33 AM, Markus Armbruster wrote:
> Since I already collected them to find out by how much they reduce the
> number of unmaintained files: Peter, would you find a pull request for
> the collection useful?
I was going to submit mine today in a pull request.
Paolo
Am 23.10.2014 um 10:36 hat Max Reitz geschrieben:
> On 2014-10-23 at 10:29, Kevin Wolf wrote:
> >Am 23.10.2014 um 09:46 hat Max Reitz geschrieben:
> >>On 2014-10-22 at 20:35, Kevin Wolf wrote:
> >>>Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
> bdrv_make_empty() is currently only called if
On 23/10/2014 09:52, Pavel Dovgaluk wrote:
From: Frederic Konrad [mailto:fred.kon...@greensocs.com]
On 23/10/2014 07:57, Pavel Dovgaluk wrote:
From: Frederic Konrad [mailto:fred.kon...@greensocs.com]
On 22/10/2014 13:38, Pavel Dovgalyuk wrote:
Hi Pavel,
This patch fixes instructions counting w
On 23 October 2014 09:09, Michael Tokarev wrote:
> On 10/09/2014 06:00 PM, Chen Gang wrote:
>> The related variables are useless, need be removed, or can not pass
>> microblaze building, after fix it, can build microblaze, successfully.
> ...
>
> Applied to trivial (with subject fixup), thanks!
P
On Wed, Oct 22, 2014 at 2:50 PM, Stefan Hajnoczi wrote:
> * International Obfuscated C Coding Competition 2004 entry - 32-bit
> multitasking operating system (http://www.ioccc.org/2004/gavin.hint)
For the record, I created a floppy image (with SYSLINUX) but it
doesn't boot successfully. Tried a
On 2014-10-23 at 10:41, Kevin Wolf wrote:
Am 23.10.2014 um 10:36 hat Max Reitz geschrieben:
On 2014-10-23 at 10:29, Kevin Wolf wrote:
Am 23.10.2014 um 09:46 hat Max Reitz geschrieben:
On 2014-10-22 at 20:35, Kevin Wolf wrote:
Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
bdrv_make_empty(
On Thu, Oct 23, 2014 at 08:44:09AM +0200, Jan Kiszka wrote:
> On 2014-10-22 22:34, Benjamin Herrenschmidt wrote:
> > On Wed, 2014-10-22 at 16:17 +0200, Jan Kiszka wrote:
> >> I thought about this again, and I'm not sure anymore if we can use
> >> ACPI
> >> to "black-list" the incompatible virtio de
From: "Dr. David Alan Gilbert"
This looks like an old merge error and should have no effect.
(Build tested only)
Found by Coccinelle using Julia Lawall's script:
https://lkml.org/lkml/2014/8/23/128
Signed-off-by: Dr. David Alan Gilbert
---
hw/misc/omap_gpmc.c | 2 --
1 file changed, 2 deletio
On 23 October 2014 09:33, Markus Armbruster wrote:
> Gerd Hoffmann writes:
>> That is perfectly fine. I'll go add it into one of the next pull
>> requests, unless someone collects all the MAINTAINERS patches on the
>> list earlier ;)
>
> Since I already collected them to find out by how much the
Am 23.10.2014 um 11:11 hat Max Reitz geschrieben:
> >>>Leaves the question, is it worth the hassle?
> >>Probably not. Would you be fine with setting bs->drv to NULL in the
> >>problematic error paths?
> >By calling qcow2_signal_corruption(), right? I think that's fine.
>
> I don't know. The image
On 2014-10-23 at 11:42, Kevin Wolf wrote:
Am 23.10.2014 um 11:11 hat Max Reitz geschrieben:
Leaves the question, is it worth the hassle?
Probably not. Would you be fine with setting bs->drv to NULL in the
problematic error paths?
By calling qcow2_signal_corruption(), right? I think that's fine
On 22 October 2014 13:59, Michael Roth wrote:
> The following changes since commit 01a2050fa5fb3d290134b67ee82eb3ebbd91d95b:
>
> hw/i386/pc_q35.c: Avoid g_assert_cmpint() as it is not in glib 2.12
> (2014-10-22 11:32:44 +0100)
>
> are available in the git repository at:
>
> git://github.com/m
> From: Frederic Konrad [mailto:fred.kon...@greensocs.com]
> On 23/10/2014 09:52, Pavel Dovgaluk wrote:
> >> From: Frederic Konrad [mailto:fred.kon...@greensocs.com]
> >> On 23/10/2014 07:57, Pavel Dovgaluk wrote:
> From: Frederic Konrad [mailto:fred.kon...@greensocs.com]
> On 22/10/2014
On 2014-10-22 at 15:21, Peter Lieven wrote:
Signed-off-by: Peter Lieven
---
tests/qemu-iotests/108 | 108
It's a pity, but 108 is already taken (by me and on Kevin's block branch
at least). 108 having 108 lines would have been nice, though.
Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
> When a block job signals readiness, this is currently reported only
> through QMP. If qemu wants to use block jobs for internal tasks, there
> needs to be another way to correctly detect when a block job may be
> completed.
>
> For this reason, i
On 2014-10-22 at 15:22, Peter Lieven wrote:
Output is changed by the addition of the write-merging parameter
Signed-off-by: Peter Lieven
---
tests/qemu-iotests/067.out | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Max Reitz
On Wed, Oct 22, 2014 at 03:17:33PM +0200, Magnus Reftel wrote:
> On Tue, Oct 14, 2014 at 5:18 PM, Magnus Reftel wrote:
> > linux-user uses the rand function for generating the value of the AT_RANDOM
> > elf
> > aux vector entry, and explicitly seeds the random number generator with the
> > curren
Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
> As of a follow-up patch to this one, the length of a mirror block job
> will no longer directly depend on the size of the block device;
> therefore, drop these checks from this test. Instead, just check whether
> the final offset equals the block
On 2014-10-23 at 12:06, Kevin Wolf wrote:
Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
As of a follow-up patch to this one, the length of a mirror block job
will no longer directly depend on the size of the block device;
therefore, drop these checks from this test. Instead, just check wheth
On 23 October 2014 10:02, Peter Maydell wrote:
> On 23 October 2014 09:09, Michael Tokarev wrote:
>> Applied to trivial (with subject fixup), thanks!
>
> Please don't -- as I said, I have a libvixl update in my queue,
> and these will conflict. I'll apply an appropriate variation of
> this patch
Dear all,
The goal of this mail is to summarize how dynamic sysbus device tree
nodes were created on ARM with "machvirt dynamic sysbus device
instantiation",
https://lists.gnu.org/archive/html/qemu-devel/2014-09/msg01626.html
and request some advises after commit "hw/arm/boot: load DTB as a ROM
im
On 2014-10-16 at 09:54, Peter Lieven wrote:
at least in block layer we have the case of limits being defined for a
BlockDriverState. However, in this context often zero (0) has the special
meanining of undefined which means no limit. If two of those limits are
combined and the minimum is needed t
On 23.10.14 12:10, Eric Auger wrote:
> Dear all,
>
> The goal of this mail is to summarize how dynamic sysbus device tree
> nodes were created on ARM with "machvirt dynamic sysbus device
> instantiation",
> https://lists.gnu.org/archive/html/qemu-devel/2014-09/msg01626.html
> and request some ad
> Dear all,
>
> The goal of this mail is to summarize how dynamic sysbus device tree
> nodes were created on ARM with "machvirt dynamic sysbus device
> instantiation",
> https://lists.gnu.org/archive/html/qemu-devel/2014-09/msg01626.html
> and request some advises after commit "hw/arm/boot: load DT
On 10/23/2014 02:09 PM, Peter Maydell wrote:
> On 23 October 2014 10:02, Peter Maydell wrote:
>> On 23 October 2014 09:09, Michael Tokarev wrote:
>>> Applied to trivial (with subject fixup), thanks!
>>
>> Please don't -- as I said, I have a libvixl update in my queue,
>> and these will conflict.
Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
> Instead of taking the total length of the block device as the block
> job's length, use the number of dirty sectors. The progress is now the
> number of sectors mirrored to the target block device. Note that this
> may result in the job's length i
On 23 October 2014 11:27, Michael Tokarev wrote:
> On 10/23/2014 02:09 PM, Peter Maydell wrote:
>> On 23 October 2014 10:02, Peter Maydell wrote:
>>> On 23 October 2014 09:09, Michael Tokarev wrote:
Applied to trivial (with subject fixup), thanks!
>>>
>>> Please don't -- as I said, I have a
On 2014-10-23 at 12:52, Kevin Wolf wrote:
Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
Instead of taking the total length of the block device as the block
job's length, use the number of dirty sectors. The progress is now the
number of sectors mirrored to the target block device. Note that
On 2014-10-16 at 09:54, Peter Lieven wrote:
Signed-off-by: Peter Lieven
---
block.c |4
include/block/block_int.h |3 +++
2 files changed, 7 insertions(+)
Reviewed-by: Max Reitz
On 2014-10-16 at 09:54, Peter Lieven wrote:
the limit of 0xff for 16 byte CDBs is intentional to
avoid overflows on 32-bit architectures.
How is it related to 32 bit? I somehow feel like it has to do something
with the result of sector_lun2qemu() which involves block_size...
Signed-off-
On 23.10.14 12:19, Ard Biesheuvel wrote:
>> Dear all,
>>
>> The goal of this mail is to summarize how dynamic sysbus device tree
>> nodes were created on ARM with "machvirt dynamic sysbus device
>> instantiation",
>> https://lists.gnu.org/archive/html/qemu-devel/2014-09/msg01626.html
>> and reque
On 2014-10-16 at 09:54, Peter Lieven wrote:
Signed-off-by: Peter Lieven
Reviewed-by: Ronnie Sahlberg
---
block.c |5 +
1 file changed, 5 insertions(+)
diff --git a/block.c b/block.c
index 0fbf916..9ad2287 100644
--- a/block.c
+++ b/block.c
@@ -4554,6 +4554,11 @@ static int multiwrit
On 23 October 2014 12:23, Alexander Graf wrote:
> On 23.10.14 12:19, Ard Biesheuvel wrote:
>> The reason for this change was that, before, the DTB would only be
>> generated once, and after a reset, the machine would go through the
>> kernel boot protocol as before but the DTB pointer would point
On 23.10.14 13:24, Peter Maydell wrote:
> On 23 October 2014 12:23, Alexander Graf wrote:
>> On 23.10.14 12:19, Ard Biesheuvel wrote:
>>> The reason for this change was that, before, the DTB would only be
>>> generated once, and after a reset, the machine would go through the
>>> kernel boot pro
Hi,
Thanks everyone for entering the thread & reading my long email.
Alex, I indeed can register the notifier in the machine file after the
platform bus instantiation. This indeed guarantees the notifiers are
called in the right order ...
Thanks
Best Regards
Eric
On 10/23/2014 01:26 PM, Alexa
From: Riku Voipio
On AArch64 the si_addr field of siginfo_t is truncated to 32 bits
because the fault address passes through an uint32_t variable. This
is fixed by changing the variable to uint64_t.
v2 by Riku - follow Peters suggestion and drop the addr variable
since its only used once in the
Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
> qemu-img should use QMP commands whenever possible in order to ensure
> feature completeness of both online and offline image operations. As
> qemu-img itself has no access to QMP (since this would basically require
> just everything being linked
Am 23.10.2014 um 13:09 hat Max Reitz geschrieben:
> On 2014-10-23 at 12:52, Kevin Wolf wrote:
> >Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
> >>Instead of taking the total length of the block device as the block
> >>job's length, use the number of dirty sectors. The progress is now the
> >>n
On 23 October 2014 12:55, wrote:
> From: Riku Voipio
>
> On AArch64 the si_addr field of siginfo_t is truncated to 32 bits
> because the fault address passes through an uint32_t variable. This
> is fixed by changing the variable to uint64_t.
>
> v2 by Riku - follow Peters suggestion and drop the
Peter Maydell writes:
> On 23 October 2014 09:33, Markus Armbruster wrote:
>> Gerd Hoffmann writes:
>>> That is perfectly fine. I'll go add it into one of the next pull
>>> requests, unless someone collects all the MAINTAINERS patches on the
>>> list earlier ;)
>>
>> Since I already collected
On 2014/10/17 20:49, GAUGUEY Rémy 228890 wrote:
> Thanks for your feedback,
>
>> static irqreturn_t vm_interrupt(int irq, void *opaque) {
>> ..
>>
>> /* Read and acknowledge interrupts */
>> /*status = readl(vm_dev->base + VIRTIO_MMIO_INTERRUPT_STATUS);
>> writel(status,
"Need BlockBackend" has been a recurring theme for a long time. It's
finally on master now. Plenty of work left to do. Let's coordinate
next steps to avoid duplicate work.
A few obvious tasks:
* Complete monitor command conversion
Commands deal with complete backends and with individual nod
Hi,
> >> Though we call qmp_change_vnc() failed, the content of global variable
> >> vnc_display
> >> still will change, such as 'vs->auth = VNC_AUTH_NONE' now. I think this is
> >> not
> >> reasonable, but I have not good idea to address this issue.
> >
> > I think the current behavior is fi
* Paolo Bonzini (pbonz...@redhat.com) wrote:
> Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto:
> > +bool one_message = false;
> > +/* This looks good, but it's possible that the device loading in
> > the
> > + * main thread hasn't finished yet, and so we might
On 2014/10/23 20:16, Gerd Hoffmann wrote:
> Hi,
>
Though we call qmp_change_vnc() failed, the content of global variable
vnc_display
still will change, such as 'vs->auth = VNC_AUTH_NONE' now. I think this is
not
reasonable, but I have not good idea to address this iss
Hi,
> I expect some of the patches to be in the Kevin's, Paolos and Gerd's
> next pull requests. Happy to collect whatever's left after the dust
> settled.
I happily leave this one to you.
Looking forward to see your first pull req ;)
cheers,
Gerd
On Thu, Oct 23, 2014 at 10:35:47AM +0400, Michael Tokarev wrote:
> On 09/26/2014 11:46 PM, Eduardo Habkost wrote:
> > This series adds a missing include, kills a circular header dependency, and
> > avoid including qemu-common.h from a header to avoid new circular
> > dependencies.
> >
> > Eduardo
On 2014/10/23 20:27, Gerd Hoffmann wrote:
> Hi,
>
>> I expect some of the patches to be in the Kevin's, Paolos and Gerd's
>> next pull requests. Happy to collect whatever's left after the dust
>> settled.
>
> I happily leave this one to you.
> Looking forward to see your first pull req ;)
>
On 2014-10-23 at 13:59, Kevin Wolf wrote:
Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
qemu-img should use QMP commands whenever possible in order to ensure
feature completeness of both online and offline image operations. As
qemu-img itself has no access to QMP (since this would basically
Am 23.10.2014 um 14:35 hat Max Reitz geschrieben:
> On 2014-10-23 at 13:59, Kevin Wolf wrote:
> >Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
> >>qemu-img should use QMP commands whenever possible in order to ensure
> >>feature completeness of both online and offline image operations. As
> >>q
On 10/23/2014 01:41 PM, Eric Auger wrote:
> Hi,
>
> Thanks everyone for entering the thread & reading my long email.
>
> Alex, I indeed can register the notifier in the machine file after
s/after/before
Eric
the
> platform bus instantiation. This indeed guarantees the notifiers are
> called in t
On 2014-10-23 at 14:40, Kevin Wolf wrote:
Am 23.10.2014 um 14:35 hat Max Reitz geschrieben:
On 2014-10-23 at 13:59, Kevin Wolf wrote:
Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
qemu-img should use QMP commands whenever possible in order to ensure
feature completeness of both online and
Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
> After the top image has been committed, it should be emptied unless
> specified otherwise.
>
> Signed-off-by: Max Reitz
> Reviewed-by: Eric Blake
Reviewed-by: Kevin Wolf
Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
> Implement progress output for the commit command by querying the
> progress of the block job.
>
> Signed-off-by: Max Reitz
> Reviewed-by: Eric Blake
Reviewed-by: Kevin Wolf
Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
> Introduce a new parameter for qemu-img commit which may be used to
> explicitly specify the backing file into which an image should be
> committed if the backing chain has more than a single layer.
>
> Signed-off-by: Max Reitz
Reviewed-by: Kevi
Hi,
> Disk images:
> * Need a disk image for each day: 1-25 December
> * Must be freely redistributable (i.e. no proprietary license that
> prevents distribution)
> * Ideally under 100 MB per disk image
> * Please include a command-line for launching the disk image
> * Please include a shor
Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
> As different image formats most probably map guest addresses to
> different host addresses, add a filter to filter the host addresses out;
> also, the image filename should be filtered.
>
> Signed-off-by: Max Reitz
> Reviewed-by: Eric Blake
Re
This is a brief writeup of what we discussed at the QEMU Summit 2014
at KVM Forum last week. Unfortunately I didn't have the presence of
mind to request that anybody took notes, so this is based on my
memory and on the agenda we sent out, and may contain errors. Please
feel free to correct me if I
Hi Frank,
On Wed, 22 Oct 2014 17:11:59 +0200
Frank Blaschka wrote:
> From: Frank Blaschka
>
> This patch implements the s390 pci instructions in qemu. It allows
> to access and drive pci devices attached to the s390 pci bus.
> Because of platform constrains devices using IO BARs are not
> su
On 23 October 2014 10:17, Dr. David Alan Gilbert (git)
wrote:
> From: "Dr. David Alan Gilbert"
>
> This looks like an old merge error and should have no effect.
> (Build tested only)
>
> Found by Coccinelle using Julia Lawall's script:
> https://lkml.org/lkml/2014/8/23/128
>
> Signed-off-by: Dr.
On 21 October 2014 13:14, Pavel Dovgalyuk wrote:
> Sometimes page faults happen during the translation of the target
> instructions.
> To avoid the faults in the middle of the TB we have to stop translation at
> the end of the page. Current implementation of ARM translation assumes that
> instruc
Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
> Add a test for qemu-img commit on backing chains with more than two
> images. This test also checks whether the top image is emptied (unless
> this is prevented by specifying either -d or -b) and does therefore not
> work for qed and vmdk which re
On 2014-10-23 at 09:07, Max Reitz wrote:
On 2014-10-22 at 13:56, Kevin Wolf wrote:
Am 21.10.2014 um 10:51 hat Max Reitz geschrieben:
The bmap size in block/vdi.c may exceed INT_MAX. Using
bdrv_pwrite_sync() (which takes an int byte count) is therefore not a
good idea. The second patch of this s
On Tue, 21 Oct 2014 19:46:03 +0800
Zhu Guihua wrote:
> After inputting device_del command in monitor, we expect to list all
> hotpluggable devices automatically by pressing tab key. This patchset provides
> the function to list all peripheral devices such as memory devices.
Applied to the qmp br
Currently, if bdrv_check() fails either by returning -errno or having
check_errors set, qemu-img check just exits with 1 after having told the
user that there were no errors on the image. This is bad.
Instead of printing the check result if there were internal errors which
were so bad that bdrv_ch
Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
> Add a test for qcow2's fast bdrv_make_empty implementation on images
> without internal snapshots.
>
> Signed-off-by: Max Reitz
We'll probably want to add more test cases, but what's there looks
reasonable.
Reviewed-by: Kevin Wolf
The following changes since commit 5f77ef69a195098baddfdc6d189f1b4a94587378:
glib: add compatibility interface for g_strcmp0() (2014-10-16 23:02:31 +0100)
are available in the git repository at:
git://github.com/bonzini/qemu.git tags/for-upstream
for you to fetch changes up to 6dad2b7b17ddf
1 - 100 of 221 matches
Mail list logo
