"Michael S. Tsirkin" writes:
> On Tue, Oct 21, 2014 at 03:34:46PM +0200, Markus Armbruster wrote:
>> Paolo Bonzini writes:
>>
>> > On 10/20/2014 04:15 PM, Michael S. Tsirkin wrote:
>> >> What do you want to happen in this case?
>> >> Won't this cause even more patches to fall to the floor?
>> >
On Wed, Oct 22, 2014 at 09:01:24AM +0200, Markus Armbruster wrote:
> "Michael S. Tsirkin" writes:
>
> > On Tue, Oct 21, 2014 at 03:34:46PM +0200, Markus Armbruster wrote:
> >> Paolo Bonzini writes:
> >>
> >> > On 10/20/2014 04:15 PM, Michael S. Tsirkin wrote:
> >> >> What do you want to happen
On 2014-10-22 at 05:08, Sandeep Joshi wrote:
Another small question. I noticed that all block drivers call
block_init ("module_init") and qemu_system binary has the
"--enable-modules" command line option.
But does QEMU support building block drivers outside the main source
tree ? And ca
On Tue, Oct 21, 2014 at 02:35:09PM +0300, Michael S. Tsirkin wrote:
> We have a bunch of modules in "Odd fixes"
> status, scripts/get_maintainer.pl ignores that.
>
> Reported-by: Gerd Hoffmann
> Cc: Paolo Bonzini
> Cc: Peter Maydell
> Cc: Markus Armbruster
> Signed-off-by: Michael S. Tsirkin
On Tue, Oct 21, 2014 at 5:40 PM, Peter Crosthwaite
wrote:
> On Tue, Oct 21, 2014 at 5:05 PM, Alistair Francis
> wrote:
>> On Mon, Oct 20, 2014 at 5:18 PM, Peter Crosthwaite
>> wrote:
>>> Sorry about the review delay...
>>>
>>> On Thu, Oct 16, 2014 at 10:53 PM, Alistair Francis
>>> wrote:
The following changes since commit 5f77ef69a195098baddfdc6d189f1b4a94587378:
glib: add compatibility interface for g_strcmp0() (2014-10-16 23:02:31 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
for you to fetch changes up
From: Gal Hammer
Add a 16-bytes buffer to allow storing a 128-bit UUID value in an
ACPI table.
Signed-off-by: Gal Hammer
Reviewed-by: Paolo Bonzini
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
scripts/acpi_extract.py | 23 ++-
1 file changed, 14
From: Eduardo Habkost
QEMU currently allows the number of VCPUs to not be a multiple of the
number of threads per socket, but the smbios socket count calculation
introduced by commit c97294ec1b9e36887e119589d456557d72ab37b5 doesn't
take that into account, triggering an assertion. e.g.:
$ ./x86
From: Laszlo Ersek
With this patch applied, the output of -M \? is
> Supported machines are:
> pc Standard PC (i440FX + PIIX, 1996) (alias of
> pc-i440fx-2.2)
> pc-i440fx-2.2Standard PC (i440FX + PIIX, 1996) (default)
> pc-i440fx-2.1Standard PC (i440FX + PIIX,
From: Laszlo Ersek
Commit 261747f1 ("vl: Use MachineClass instead of global QEMUMachine
list") broke the ordering of the machine types in the user-visible output
of
qemu-system- -M \?
This occurred because registration was rebased from a manually maintained
linked list to GLib hash tables
From: Jan Kiszka
We used to be able to address both the QEMU and the KVM APIC via "apic".
This doesn't work anymore. So we need to use their parent class to turn
off the vapic on machines that should not expose them.
Signed-off-by: Jan Kiszka
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Mich
Current support for bus master (clearing OK bit) together with the need to
support guests which do not enable PCI bus mastering, leads to extra state in
VIRTIO_PCI_FLAG_BUS_MASTER_BUG bit, which isn't robust in case of cross-version
migration for the case when guests use the device before setting D
From: Gonglei
This comment applies to all functions below it.
It is not appropriate that called capability allocation
functions, change it into capability list management functions.
Signed-off-by: Gonglei
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/pci/pcie.c | 2
On Wed, 2014-10-22 at 09:18 +0300, Michael S. Tsirkin wrote:
> On Tue, Oct 21, 2014 at 03:37:12PM +0300, Marcel Apfelbaum wrote:
> > ROM images must be loaded at startup. Usage of rombar=0 after that
> > is not allowed, but should not crash QEMU.
> >
> > Check that the device is not hotplugged bef
On Wed, 2014-10-22 at 10:26 +0300, Michael S. Tsirkin wrote:
> From: Laszlo Ersek
>
> Commit 261747f1 ("vl: Use MachineClass instead of global QEMUMachine
> list") broke the ordering of the machine types in the user-visible output
> of
>
> qemu-system- -M \?
>
> This occurred because regi
The fix for the syscalls problem is already upstream at libseccomp [0] .
The maintainer said he has no plans yet to make a new release, though.
[0] -- http://sourceforge.net/p/libseccomp/mailman/libseccomp-
discuss/thread/1661272.9kVko5ssCn%40sifl/#msg32956301
--
You received this bug notificati
On Wed, 2014-10-22 at 00:06 +0200, Paolo Bonzini wrote:
>
> On 10/21/2014 02:37 PM, Marcel Apfelbaum wrote:
> > ROM images must be loaded at startup. Usage of rombar=0 after that
> > is not allowed, but should not crash QEMU.
> >
> > Check that the device is not hotplugged before trying to
> > in
On Sun, 2014-10-19 at 16:12 +0300, Marcel Apfelbaum wrote:
> Commit: 501f28ca9db08e84819b26314525b6369e7704dd
> tests: rename acpi-test to bios-tables-test
>
> modified acpi-test file from acpi-test.c to bios-tables-test.c.
> However, the tables regeneration script was not modified
> according
On 10/22/2014 09:22 AM, Michael S. Tsirkin wrote:
> Actually, it does not ignore that.
> What it does it list status as "odd fixer".
>
> So this boils down to the fact that we use
> "odd fixer" incorrectly.
>
> I will apply this for now but maybe we should
> change MAINTAINERS switching all "Odd
On 10/22/2014 09:12 AM, Michael S. Tsirkin wrote:
> > $ scripts/get_maintainer.pl -f util/cutils.c
> > Luiz Capitulino (commit_signer:1/2=50%)
> > Eric Blake (commit_signer:1/2=50%)
> > Alexey Kardashevskiy (commit_signer:1/2=50%)
> > Laszlo Ersek (commit_signer:1/2=50%)
>
"Michael S. Tsirkin" writes:
> On Tue, Oct 21, 2014 at 02:35:09PM +0300, Michael S. Tsirkin wrote:
>> We have a bunch of modules in "Odd fixes"
>> status, scripts/get_maintainer.pl ignores that.
>>
>> Reported-by: Gerd Hoffmann
>> Cc: Paolo Bonzini
>> Cc: Peter Maydell
>> Cc: Markus Armbruste
On Wed, Oct 22, 2014 at 10:34:21AM +0300, Marcel Apfelbaum wrote:
> On Wed, 2014-10-22 at 09:18 +0300, Michael S. Tsirkin wrote:
> > On Tue, Oct 21, 2014 at 03:37:12PM +0300, Marcel Apfelbaum wrote:
> > > ROM images must be loaded at startup. Usage of rombar=0 after that
> > > is not allowed, but s
On 10/22/2014 09:47 AM, Markus Armbruster wrote:
> Like this:
>
> $ scripts/get_maintainer.pl -f --no-git-fallback hw/ide/core.c
> Kevin Wolf (odd fixer:IDE)
> Stefan Hajnoczi (odd fixer:IDE)
>
> What's wrong with that?
Michael's patch fixes the case where you do _not_ have --no
On Wed, Oct 22, 2014 at 10:41:05AM +0300, Marcel Apfelbaum wrote:
> On Wed, 2014-10-22 at 00:06 +0200, Paolo Bonzini wrote:
> >
> > On 10/21/2014 02:37 PM, Marcel Apfelbaum wrote:
> > > ROM images must be loaded at startup. Usage of rombar=0 after that
> > > is not allowed, but should not crash QE
On Wed, Oct 22, 2014 at 10:39:16AM +0300, Marcel Apfelbaum wrote:
> On Wed, 2014-10-22 at 10:26 +0300, Michael S. Tsirkin wrote:
> > From: Laszlo Ersek
> >
> > Commit 261747f1 ("vl: Use MachineClass instead of global QEMUMachine
> > list") broke the ordering of the machine types in the user-visib
On Wed, Oct 22, 2014 at 10:42:26AM +0300, Marcel Apfelbaum wrote:
> On Sun, 2014-10-19 at 16:12 +0300, Marcel Apfelbaum wrote:
> > Commit: 501f28ca9db08e84819b26314525b6369e7704dd
> > tests: rename acpi-test to bios-tables-test
> >
> > modified acpi-test file from acpi-test.c to bios-tables-te
"Michael S. Tsirkin" writes:
> On Wed, Oct 22, 2014 at 09:01:24AM +0200, Markus Armbruster wrote:
>> "Michael S. Tsirkin" writes:
>>
>> > On Tue, Oct 21, 2014 at 03:34:46PM +0200, Markus Armbruster wrote:
>> >> Paolo Bonzini writes:
>> >>
>> >> > On 10/20/2014 04:15 PM, Michael S. Tsirkin wro
On Fri, Sep 19, 2014 at 08:11:14AM -0700, Peter Maydell wrote:
> On 19 September 2014 07:38, Eduardo Otubo
> wrote:
> > On Fri, Sep 19, 2014 at 4:15 PM, Peter Maydell
> > wrote:
> >> ...how about fixing your compile errors on non-x86 platforms
> >> before adding more stuff here?
> >
> > Hm, inde
On Wed, Oct 22, 2014 at 09:45:13AM +0200, Paolo Bonzini wrote:
> On 10/22/2014 09:22 AM, Michael S. Tsirkin wrote:
> > Actually, it does not ignore that.
> > What it does it list status as "odd fixer".
> >
> > So this boils down to the fact that we use
> > "odd fixer" incorrectly.
> >
> > I will
Paolo Bonzini writes:
> On 10/22/2014 09:47 AM, Markus Armbruster wrote:
>> Like this:
>>
>> $ scripts/get_maintainer.pl -f --no-git-fallback hw/ide/core.c
>> Kevin Wolf (odd fixer:IDE)
>> Stefan Hajnoczi (odd fixer:IDE)
>>
>> What's wrong with that?
>
> Michael's patch fixes the
On 10/22/2014 10:08 AM, Michael S. Tsirkin wrote:
>> >
>> > To me "odd fixes" means I may help shepherding your patches into the
>> > tree, but I would rather revert a buggy patch than fix it.
> OK but this is not what MAINTAINERS says:
>
>
>Odd Fixes: It has a maintainer but the
As can be seen in the final patch of this series, there are certain
cases where the current repair implementation of qcow2 actually damages
the image further because it allocates new clusters for the refcount
structure which overlap with existing but according to the on-disk
refcounts (which are as
Put the code for calculating the reference counts and comparing them
during qemu-img check into own functions.
Signed-off-by: Max Reitz
Reviewed-by: Benoît Canet
Reviewed-by: Kevin Wolf
---
block/qcow2-refcount.c | 153 -
1 file changed, 102 inse
These functions call their non-0-counterparts and then fill the
allocated buffer with 0 (if the allocation has been successful).
Signed-off-by: Max Reitz
---
block.c | 16
include/block/block.h | 2 ++
2 files changed, 18 insertions(+)
diff --git a/block.c b/bloc
If the qcow2 check function detects a refcount block located beyond the
image end, grow the image appropriately. This cannot break anything and
is the logical fix for such a case.
Signed-off-by: Max Reitz
---
block/qcow2-refcount.c | 63 ++
1 file
On Wed, 22 Oct 2014 10:01:43 +0300
"Michael S. Tsirkin" wrote:
> On Wed, Oct 22, 2014 at 08:39:59AM +0200, Markus Armbruster wrote:
> > "Michael S. Tsirkin" writes:
> >
> > > On Tue, Oct 21, 2014 at 03:29:14PM +0200, Markus Armbruster wrote:
> > >> "Michael S. Tsirkin" writes:
> > >>
> > >> >
When opening dirty images, qcow2's repair function should not only
repair errors but leaks as well.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Benoît Canet
Reviewed-by: Kevin Wolf
---
block/qcow2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/qc
The size of a refblock entry is (in theory) variable; calculate
therefore the number of entries per refblock and the according bit shift
(1 << x == entry count) when opening an image.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block/qcow2.c | 3 +++
block/qcow2.h | 2 ++
2 files chang
When implementing variable refcounts, we want to be able to easily find
all the places in qemu which are tied to a certain refcount order.
Replace sizeof(uint16_t) in the check code by sizeof(**refcount_table)
so we can later find it more easily.
Signed-off-by: Max Reitz
---
block/qcow2-refcount
Pull check_refblocks() before calculate_refcounts() so we can drop its
static declaration.
Signed-off-by: Max Reitz
Reviewed-by: Benoît Canet
Reviewed-by: Kevin Wolf
---
block/qcow2-refcount.c | 102 -
1 file changed, 49 insertions(+), 53 deletio
We will later call calculate_refcounts multiple times, so reuse the
refcount table if possible.
Signed-off-by: Max Reitz
Reviewed-by: Benoît Canet
Reviewed-by: Kevin Wolf
---
block/qcow2-refcount.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/block/qcow2-ref
From: Eduardo Habkost
QEMU currently allows the number of VCPUs to not be a multiple of the
number of threads per socket, but the smbios socket count calculation
introduced by commit c97294ec1b9e36887e119589d456557d72ab37b5 doesn't
take that into account, triggering an assertion. e.g.:
$ ./x86
The previous commit introduced the "rebuild" variable to qcow2's
implementation of the image consistency check. Now make use of this by
adding a function which creates a completely new refcount structure
based solely on the in-memory information gathered before.
The old refcount structure will be
From: Laszlo Ersek
Commit 261747f1 ("vl: Use MachineClass instead of global QEMUMachine
list") broke the ordering of the machine types in the user-visible output
of
qemu-system- -M \?
This occurred because registration was rebased from a manually maintained
linked list to GLib hash tables
If a referenced cluster has a refcount of 0, increasing its refcount may
result in clusters being allocated for the refcount structures. This may
overwrite the referenced cluster, therefore we cannot simply increase
the refcount then.
In such cases, we can either try to replicate all the refcount
There are certain cases where repairing a qcow2 image might actually
damage it further (or rather, where repairing it has in fact damaged it
further with the old qcow2 check implementation). This should not
happen, so add a test for these cases.
Furthermore, the repair function now repairs refbloc
From: Gonglei
This comment applies to all functions below it.
It is not appropriate that called capability allocation
functions, change it into capability list management functions.
Signed-off-by: Gonglei
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/pci/pcie.c | 2
On Wed, Oct 22, 2014 at 10:10:58AM +0200, Thomas Huth wrote:
> On Wed, 22 Oct 2014 10:01:43 +0300
> "Michael S. Tsirkin" wrote:
>
> > On Wed, Oct 22, 2014 at 08:39:59AM +0200, Markus Armbruster wrote:
> > > "Michael S. Tsirkin" writes:
> > >
> > > > On Tue, Oct 21, 2014 at 03:29:14PM +0200, Mar
Because the old refcount structure will be leaked after having rebuilt
it, we need to recalculate the refcounts and run a leak-fixing operation
afterwards (if leaks should be fixed at all).
Signed-off-by: Max Reitz
---
block/qcow2-refcount.c | 45 +
1
Current support for bus master (clearing OK bit) together with the need to
support guests which do not enable PCI bus mastering, leads to extra state in
VIRTIO_PCI_FLAG_BUS_MASTER_BUG bit, which isn't robust in case of cross-version
migration for the case when guests use the device before setting D
On Wed, Oct 22, 2014 at 10:07:52AM +0200, Paolo Bonzini wrote:
>
>
> On 10/22/2014 10:08 AM, Michael S. Tsirkin wrote:
> >> >
> >> > To me "odd fixes" means I may help shepherding your patches into the
> >> > tree, but I would rather revert a buggy patch than fix it.
> > OK but this is not what
039, 060 and 061 all create images with referenced clusters having a
refcount of 0. Because previous commits changed handling of such errors,
these tests now have a different output. Fix it.
Furthermore, 060 created a refblock with a refcount greater than one
which now results in having to rebuild
From: Paolo Bonzini
This is now called bios-tables-test.
Signed-off-by: Paolo Bonzini
Acked-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
tests/acpi-test-data/rebuild-expected-aml.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/acpi-test-data
The following changes since commit 5f77ef69a195098baddfdc6d189f1b4a94587378:
glib: add compatibility interface for g_strcmp0() (2014-10-16 23:02:31 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
for you to fetch changes up
On 10/22/2014 10:13 AM, Michael S. Tsirkin wrote:
> > To me it means that I have time to review patches, but not to do my own
> > work on it.
>
> Intersting.
> review is "other than throw the odd patch in" so it's hardly
> the literal meaning of this text.
Well, review is just the prerequisite/ne
From: Laszlo Ersek
With this patch applied, the output of -M \? is
> Supported machines are:
> pc Standard PC (i440FX + PIIX, 1996) (alias of
> pc-i440fx-2.2)
> pc-i440fx-2.2Standard PC (i440FX + PIIX, 1996) (default)
> pc-i440fx-2.1Standard PC (i440FX + PIIX,
From: Jan Kiszka
We used to be able to address both the QEMU and the KVM APIC via "apic".
This doesn't work anymore. So we need to use their parent class to turn
off the vapic on machines that should not expose them.
Signed-off-by: Jan Kiszka
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Mich
From: Gal Hammer
Add a 16-bytes buffer to allow storing a 128-bit UUID value in an
ACPI table.
Signed-off-by: Gal Hammer
Reviewed-by: Paolo Bonzini
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
scripts/acpi_extract.py | 23 ++-
1 file changed, 14
Markus Armbruster writes:
> In my experience, too many files are not covered by MAINTAINERS.
> scripts/get_maintainer.pl falls back to git then, unless you say
> --no-git-fallback. Copies sent there tends to annoy their recipients
> without accomplishing all that much.
>
> Two obvious improvemen
Am 22.10.2014 um 00:29 hat Paolo Bonzini geschrieben:
> More work for the block device maintainers!
>
> Signed-off-by: Paolo Bonzini
Thanks, applied to the block branch.
Kevin
(((sid) >> 8) && 0xff) makes no sense
(((sid) >> 8) & 0xff) seems to be what was meant.
https://bugs.launchpad.net/qemu/+bug/1382477
Signed-off-by: Michael S. Tsirkin
---
include/hw/i386/intel_iommu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/i386/intel_iom
On Wed, Oct 22, 2014 at 10:03:53AM +0200, Markus Armbruster wrote:
> "Michael S. Tsirkin" writes:
>
> > On Wed, Oct 22, 2014 at 09:01:24AM +0200, Markus Armbruster wrote:
> >> "Michael S. Tsirkin" writes:
> >>
> >> > On Tue, Oct 21, 2014 at 03:34:46PM +0200, Markus Armbruster wrote:
> >> >> Pao
On Wed, 2014-10-22 at 10:58 +0300, Michael S. Tsirkin wrote:
> On Wed, Oct 22, 2014 at 10:34:21AM +0300, Marcel Apfelbaum wrote:
> > On Wed, 2014-10-22 at 09:18 +0300, Michael S. Tsirkin wrote:
> > > On Tue, Oct 21, 2014 at 03:37:12PM +0300, Marcel Apfelbaum wrote:
> > > > ROM images must be loaded
Am 21.10.2014 um 18:26 hat Max Reitz geschrieben:
> On 2014-10-20 at 16:48, Kevin Wolf wrote:
> >Am 20.10.2014 um 16:39 hat Max Reitz geschrieben:
> >>On 20.10.2014 at 16:25, Kevin Wolf wrote:
> >>>Am 29.08.2014 um 23:40 hat Max Reitz geschrieben:
> The size of a refblock entry is (in theory) v
On Wed, Oct 22, 2014 at 11:16:05AM +0300, Marcel Apfelbaum wrote:
> On Wed, 2014-10-22 at 10:58 +0300, Michael S. Tsirkin wrote:
> > On Wed, Oct 22, 2014 at 10:34:21AM +0300, Marcel Apfelbaum wrote:
> > > On Wed, 2014-10-22 at 09:18 +0300, Michael S. Tsirkin wrote:
> > > > On Tue, Oct 21, 2014 at 0
On Wed, Oct 08, 2014 at 11:04:28AM +0200, Cornelia Huck wrote:
> On Tue, 07 Oct 2014 18:24:22 -0700
> Andy Lutomirski wrote:
>
> > On 10/07/2014 07:39 AM, Cornelia Huck wrote:
> > > This patchset aims to get us some way to implement virtio-1 compliant
> > > and transitional devices in qemu. Branc
On Wed, 22 Oct 2014, Paolo Bonzini wrote:
> Unfortunately, TCG files do not really have a maintainer yet.
> But at least there will be fewer unmaintained files.
>
> Signed-off-by: Paolo Bonzini
> ---
> MAINTAINERS | 16
> 1 file changed, 16 insertions(+)
>
> diff --git a/MAINT
"L" entries that point to qemu-devel are not much better either, but at least
the get_maintainer.pl output is clearer.
Signed-off-by: Paolo Bonzini
---
MAINTAINERS | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index cc457a0..d260d86 1
On Wed, 22 Oct 2014 11:24:32 +0800
Gu Zheng wrote:
> Introduce helper function acpi_set_cpu_present_bit() to simplify
> acpi_cpu_plug_cb
> and acpi_cpu_hotplug_init, so that we can keep bit setting in one place.
>
> Signed-off-by: Gu Zheng
Reviewed-by: Igor Mammedov
> ---
> v6:
> -using err
On Tue, Oct 07, 2014 at 04:39:44PM +0200, Cornelia Huck wrote:
> Provide helper functions that convert from/to LE for virtio devices that
> are not operating in legacy mode. We check for the VERSION_1 feature bit
> to determine that.
>
> Based on original patches by Rusty Russell and Thomas Huth.
> Down to 491 our of 1841 (27%). Progress, but not quite enough.
I think a better analysis would be on patches, not files. Which is
really hard to do, of course.
But as a rule of thumb, tests/ and include/ patches should also touch
files outside those directories. Not many people, unfortunatel
All checks in the loop are guarded by that condition, and there is a
handy "if" just below. Simplify the code.
Signed-off-by: Paolo Bonzini
---
scripts/get_maintainer.pl | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/scripts/get_maintainer.pl b/scripts/
See individual patches. My Perl-fu is limited, but the individual
changes are easy enough.
Paolo Bonzini (4):
get_maintainer.pl: exit with status 1 if no maintainer found
get_maintainer.pl: treat all M entries the same
get_maintainer.pl: move git loop under "if ($email) {"
get_maintainer.
Why should get_maintainer bother if someone puts his name as maintainer
on an "Orphan" entry? Garbage in, email out. The results from the git
fallback are likely to be from someone doing sweeping changes on the
whole tree, and thus not really interesting.
Reported-by: Gerd Hoffmann
Signed-off-b
This can be useful, at the very least, for debugging.
Signed-off-by: Paolo Bonzini
---
scripts/get_maintainer.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 38334de..a3a16d8 100755
--- a/scripts/get_maintainer.
The list emitted by --git-fallback often leads inexperienced contributors
to add pointless CCs. While not discouraging usage of --git-fallback,
we want to warn the contributors about using their common sense.
So, default to *not* enabling --git-fallback, but print a message if
none of the files h
Am 22.10.2014 um 10:08 hat Max Reitz geschrieben:
> Because the old refcount structure will be leaked after having rebuilt
> it, we need to recalculate the refcounts and run a leak-fixing operation
> afterwards (if leaks should be fixed at all).
>
> Signed-off-by: Max Reitz
> ---
> block/qcow2-r
On Wed, Oct 22, 2014 at 11:08:20AM +0200, Paolo Bonzini wrote:
> Why should get_maintainer bother if someone puts his name as maintainer
> on an "Orphan" entry? Garbage in, email out. The results from the git
> fallback are likely to be from someone doing sweeping changes on the
> whole tree, and
Am 22.10.2014 um 10:08 hat Max Reitz geschrieben:
> If the qcow2 check function detects a refcount block located beyond the
> image end, grow the image appropriately. This cannot break anything and
> is the logical fix for such a case.
>
> Signed-off-by: Max Reitz
> ---
> block/qcow2-refcount.c
Am 22.10.2014 um 10:08 hat Max Reitz geschrieben:
> The previous commit introduced the "rebuild" variable to qcow2's
> implementation of the image consistency check. Now make use of this by
> adding a function which creates a completely new refcount structure
> based solely on the in-memory informa
On 2014-10-22 at 11:24, Kevin Wolf wrote:
Am 22.10.2014 um 10:08 hat Max Reitz geschrieben:
If the qcow2 check function detects a refcount block located beyond the
image end, grow the image appropriately. This cannot break anything and
is the logical fix for such a case.
Signed-off-by: Max Reit
On Wed, Oct 22, 2014 at 11:08:22AM +0200, Paolo Bonzini wrote:
> The list emitted by --git-fallback often leads inexperienced contributors
> to add pointless CCs. While not discouraging usage of --git-fallback,
> we want to warn the contributors about using their common sense.
>
> So, default to
On Mi, 2014-10-22 at 11:07 +0800, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> bootdevice.c was created by me, and I wrote most of
> the code in this file. And now I can maintain it,
> I'd hope nobody object this.
That is perfectly fine. I'll go add it into one of the next pull
requests,
On 2014-10-22 at 11:14, Kevin Wolf wrote:
Am 22.10.2014 um 10:08 hat Max Reitz geschrieben:
The previous commit introduced the "rebuild" variable to qcow2's
implementation of the image consistency check. Now make use of this by
adding a function which creates a completely new refcount structure
On 10/22/2014 11:33 AM, Michael S. Tsirkin wrote:
> On Wed, Oct 22, 2014 at 11:08:22AM +0200, Paolo Bonzini wrote:
>> The list emitted by --git-fallback often leads inexperienced contributors
>> to add pointless CCs. While not discouraging usage of --git-fallback,
>> we want to warn the contribu
Hi,
> "if (base < phys_offset)" in early_init_dt_add_memory_arch triggers.
> Seems __pa() isn't working correctly.
>
> Any chance this can be caused by setting some uboot env var incorrectly?
> There is a confusing high number of *_addr_* variables ...
Yep, that was it. Linux kernel wants be
Add a new API named acpi_memory_hotplug_sci() to send memory hotplug SCI.
Doing this is because this procedure will be used by other functions in the
next coming patches.
Signed-off-by: Tang Chen
---
hw/acpi/memory_hotplug.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
dif
From: Hu Tao
Implement acpi_memory_unplug_cb(), sending an sci to guest to trigger
memory hot-remove, and call it in piix4_device_unplug_cb().
Signed-off-by: Hu Tao
Signed-off-by: Tang Chen
---
hw/acpi/piix4.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/acpi/pi
This patch-set implements memory hot-remove for QEmu.
Rebased on Igor's asynchronize hotplug framework (qemu v2.1.2, the latest).
Approach: QEmu sets GPE status bit, then triggers SCI to notify guest os.
Guest os checks device status, and free memory resource if possible,
then generate OST.
NOT
Replace string "slot" in acpi_memory_plug_cb() with MACRO PC_DIMM_SLOT_PROP.
Signed-off-by: Tang Chen
---
hw/acpi/memory_hotplug.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c
index ed39241..c6580da 100644
--- a/hw/acpi
Add a new bool member named is_removing to MemStatus indicating that
the memory solt is being removed. Set it to true in acpi_memory_unplug_cb(),
and send SCI to guest.
Signed-off-by: Tang Chen
---
hw/acpi/memory_hotplug.c | 15 +++
include/hw/acpi/memory_hotplug.h | 3 +++
From: Hu Tao
This patch implements MEMORY_SLOT_EJECT_METHOD according to ACPI spec.
Signed-off-by: Hu Tao
Signed-off-by: Tang Chen
---
hw/i386/ssdt-mem.dsl | 5 +
hw/i386/ssdt-misc.dsl| 13 -
include/hw/acpi/pc-hotplug.h | 2 ++
3 files changed, 19 insertions
Add a new API named acpi_memory_get_slot_status_descriptor() to obtain
a single memory slot status. Doing this is because this procedure will
be used by other functions in the next coming patches.
Signed-off-by: Tang Chen
---
hw/acpi/memory_hotplug.c | 27 +++
1 file chan
From: Hu Tao
Implement unrealize function for pc-dimm device. It remove subregion from
hotplug region, and delete ram address range from guest ram list.
Signed-off-by: Hu Tao
Signed-off-by: Tang Chen
---
hw/mem/pc-dimm.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/hw/mem/p
Implement ich9_pm_device_unplug_cb() to support memory hot-remove,
calling acpi_memory_unplug_cb(). And itself will be called in
ich9_device_unplug_cb().
Signed-off-by: Tang Chen
---
hw/acpi/ich9.c | 12
hw/isa/lpc_ich9.c | 5 +++--
include/hw/acpi/ich9.h | 2 ++
3 fi
This patch adds a new bit to memory hotplug IO port indicating that
memory device is be removed. And set MemStatus->is_removing to false
when the bit is written.
NOTE: MemStatus->is_removing is set to true in acpi_memory_unplug_cb()
when doing memory hot-remove with device_del command.
Signed-off
On Mon, Oct 20, 2014 at 03:08:35PM +0100, Peter Maydell wrote:
> On 20 October 2014 11:25, Stefan Hajnoczi wrote:
> > Hi,
> > At KVM Forum 2014 we discussed a patch checking bot that automates patch
> > format checking and smoke testing:
> >
> > 1. Did the patch submitter include Signed-off-by?
>
From: Hu Tao
Implement device unplug callback for PCMachine. And it now only support
pc-dimm hot-remove. The callback will call piix4 or ich9 callbacks introduced
in previous patches.
Signed-off-by: Hu Tao
Signed-off-by: Tang Chen
---
hw/i386/pc.c | 31 +++
1 file
On 22 October 2014 08:31, Eduardo Otubo <1363...@bugs.launchpad.net> wrote:
> The fix for the syscalls problem is already upstream at libseccomp [0] .
> The maintainer said he has no plans yet to make a new release, though.
Then you're going to have to put a fix of some kind locally
into QEMU. I d
On 22 October 2014 09:04, Eduardo Otubo wrote:
> On Fri, Sep 19, 2014 at 08:11:14AM -0700, Peter Maydell wrote:
>> You have compile problems in current master as well. Your macros
>> probably need to guard themselves on whether the syscall they're
>> adding to the list actually exists on the host.
1 - 100 of 337 matches
Mail list logo
