[Qemu-devel] [PATCH 0/2] guest-agent: make CPU's online/offline state persistent

2014-10-06 Thread Igor Mammedov
Make sure that VCPU online state managed with virsh setvcpus --guest is not lost on reboot. Igor Mammedov (2): guest-agent: keep persistent state on persistent storage guest-agent: preserve online/offline state of VCPUs on guest reboot qga/main.c | 107 +

[Qemu-devel] [PATCH 2/2] guest-agent: preserve online/offline state of VCPUs on guest reboot

2014-10-06 Thread Igor Mammedov
Fixes issue when CPU was offlined via libvirt using command: virsh setvcpus --guest myguest NR_CPUS but it became onlined again after guest was rebooted. Fix issue by storing current state of CPUs online state on persistent storage when GA is being stopped and restore it when it's started at syst

[Qemu-devel] [PATCH 1/2] guest-agent: keep persistent state on persistent storage

2014-10-06 Thread Igor Mammedov
GA was keepeing persistent state info in /var/run/qga.state file. However it's lost after every reboot since /var/run usually is located on tmpfs or cleaned on start-up. Fix issue by keeping state file in /var/lib/qemu-ga/ directory, which is intended for keeping persistent local state according t

Re: [Qemu-devel] Fullscreen Bug with GTK

2014-10-06 Thread Gerd Hoffmann
Hi, > There is a bug where the GTK (SDL appears to be broken due to some sdl2 > incompatibility, as I understood) menu bar won't hide in fullscreen: SDL-1 support is still there. > https://bugs.launchpad.net/qemu/+bug/1294898 > > A patch was provided by the initial reporter a long time ago.

Re: [Qemu-devel] [PATCH 10/17] mm: rmap preparation for remap_anon_pages

2014-10-06 Thread Dr. David Alan Gilbert
* Linus Torvalds (torva...@linux-foundation.org) wrote: > On Fri, Oct 3, 2014 at 10:08 AM, Andrea Arcangeli wrote: > > > > Overall this looks a fairly small change to the rmap code, notably > > less intrusive than the nonlinear vmas created by remap_file_pages. > > Considering that remap_file_pag

Re: [Qemu-devel] [Bug 638955] Re: emulated netcards don't work with recent sunos kernel

2014-10-06 Thread Stefan Hajnoczi
On Sun, Oct 5, 2014 at 9:57 PM, dblade wrote: > I have this problem (as describe in OP) on a Solaris 11.2 install using > the text iso. Archlinux Qemu 2.1.0. It appears that the above patch > has been applied to qemu for some time now (its also in my version). > > Are there any new workarounds?

Re: [Qemu-devel] [PATCH 1/3] libqos: Remove PCI assumptions in virtio driver

2014-10-06 Thread Stefan Hajnoczi
On Fri, Oct 03, 2014 at 01:53:13PM +0200, Marc Marí wrote: > El Thu, 2 Oct 2014 13:02:25 +0100 > Stefan Hajnoczi escribió: > > On Thu, Sep 04, 2014 at 06:24:37PM +0200, Marc Marí wrote: > > > @@ -60,25 +60,25 @@ static void > > > qvirtio_pci_assign_device(QVirtioDevice *d, void *data) *vpcidev = >

Re: [Qemu-devel] [PATCH 0/2 V5] Virtual Machine Generation ID

2014-10-06 Thread Daniel P. Berrange
On Wed, Sep 17, 2014 at 02:39:50PM +0300, Gal Hammer wrote: > Hi, > > A two parts patch to add a QEmu support for Microsoft's Virtual Machine > Generation ID device. > > The first one add a new ACPI directive which allow to use a 16-bytes > buffer in an ACPI table. This buffer is for storing the

Re: [Qemu-devel] Fullscreen Bug with GTK

2014-10-06 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > Hi, > > > There is a bug where the GTK (SDL appears to be broken due to some sdl2 > > incompatibility, as I understood) menu bar won't hide in fullscreen: > > SDL-1 support is still there. Are you recommending building against SDL-1 even when SDL-2

Re: [Qemu-devel] [PATCH 1/8] virtio-gpu/2d: add hardware spec include file

2014-10-06 Thread Gerd Hoffmann
Hi, > >> >> +VIRTIO_GPU_FORMAT_B5G5R5A1_UNORM = 5, > >> >> +VIRTIO_GPU_FORMAT_B5G6R5_UNORM= 7, > >> > > > Ok. But for 2D we can just not support it, right? > > We can, I expect some pushback at some point, people still want to > test with 16bpp for other areas, and it would be nic

Re: [Qemu-devel] [PATCH v2 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-10-06 Thread Stefano Stabellini
On Fri, 3 Oct 2014, Don Slutz wrote: > On 10/03/14 12:23, Stefano Stabellini wrote: > > On Fri, 3 Oct 2014, Don Slutz wrote: > > > On 10/03/14 05:52, Stefano Stabellini wrote: > > > > On Thu, 2 Oct 2014, Don Slutz wrote: > > > > > This adds synchronisation of the 6 vcpu registers (only 32bits of >

Re: [Qemu-devel] [PATCH 1/2] guest-agent: keep persistent state on persistent storage

2014-10-06 Thread Laszlo Ersek
On 10/06/14 09:44, Igor Mammedov wrote: > GA was keepeing persistent state info in /var/run/qga.state > file. However it's lost after every reboot since /var/run > usually is located on tmpfs or cleaned on start-up. > > Fix issue by keeping state file in /var/lib/qemu-ga/ > directory, which is int

Re: [Qemu-devel] [PATCH v2 1/1] -machine vmport=off: Allow disabling of VMWare ioport emulation

2014-10-06 Thread Richard W.M. Jones
On Fri, Oct 03, 2014 at 05:33:37PM -0400, Don Slutz wrote: > From: "Dr. David Alan Gilbert" > > This is a pc & q35 only machine opt. > > VMWare apparently doesn't like running under QEMU due to our > incomplete emulation of it's special IO Port. This adds a > pc & q35 property to allow it to be

Re: [Qemu-devel] [PATCH 10/11] block: let commit blockjob run in BDS AioContext

2014-10-06 Thread Stefan Hajnoczi
On Sat, Oct 04, 2014 at 11:28:22PM +0200, Max Reitz wrote: > On 01.10.2014 19:01, Stefan Hajnoczi wrote: > >The commit block job must run in the BlockDriverState AioContext so that > >it works with dataplane. > > > >Acquire the AioContext in blockdev.c so starting the block job is safe. > >One deta

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/5] target-ppc: Handle ibm, nmi-register RTAS call

2014-10-06 Thread Alexander Graf
On 06.10.14 08:32, Aravinda Prasad wrote: > > > On Monday 08 September 2014 02:17 AM, Alexander Graf wrote: >> >> >> On 25.08.14 15:45, Aravinda Prasad wrote: >>> This patch adds FWNMI support in qemu for powerKVM >>> guests by handling the ibm,nmi-register rtas call. >>> Whenever OS issues ibm

Re: [Qemu-devel] Fullscreen Bug with GTK

2014-10-06 Thread Gerd Hoffmann
On Mo, 2014-10-06 at 10:14 +0100, Dr. David Alan Gilbert wrote: > * Gerd Hoffmann (kra...@redhat.com) wrote: > > Hi, > > > > > There is a bug where the GTK (SDL appears to be broken due to some sdl2 > > > incompatibility, as I understood) menu bar won't hide in fullscreen: > > > > SDL-1 support

Re: [Qemu-devel] [PATCH 2/2] guest-agent: preserve online/offline state of VCPUs on guest reboot

2014-10-06 Thread Laszlo Ersek
On 10/06/14 09:44, Igor Mammedov wrote: > Fixes issue when CPU was offlined via libvirt using command: > virsh setvcpus --guest myguest NR_CPUS > but it became onlined again after guest was rebooted. > > Fix issue by storing current state of CPUs online state > on persistent storage when GA is be

Re: [Qemu-devel] [PATCH v2 0/1] -machine vmport=off: Allow disabling of VMWare ioport emulation

2014-10-06 Thread Dr. David Alan Gilbert
* Don Slutz (dsl...@verizon.com) wrote: > Changes v1 to v2 (Don Slutz): > make vmport a pc & q35 only machine opt I.E. a machine property. > > Dr. David Alan Gilbert (1): > -machine vmport=off: Allow disabling of VMWare ioport emulation Thanks for updating this! Dave > > hw/i386/pc.c

Re: [Qemu-devel] [RFC PATCH] block/migration: Disable cache invalidate for incoming migration

2014-10-06 Thread Stefan Hajnoczi
On Fri, Oct 03, 2014 at 02:12:06PM +1000, Alexey Kardashevskiy wrote: > BDRV_O_INCOMING is only set when QEMU is about to receive migration and > we do not want QEMU to check the file at opening time as there is likely > garbage. Is there any other use of BDRV_O_INCOMING? There must be some as > bd

Re: [Qemu-devel] Fullscreen Bug with GTK

2014-10-06 Thread Cedric Sodhi
> > https://bugs.launchpad.net/qemu/+bug/1294898 > > > > A patch was provided by the initial reporter a long time ago. > > Patch trades one bug for another. Hiding the menu bar also kills the > accelerator keys, which is especially problematic for the fullscreen > hotkey as there is no way out of

[Qemu-devel] [Bug 1294898] Re: gtk: menubar visible in fullscreen mode with gtk3

2014-10-06 Thread ManDay
For what it's worth, Gerd replied on the list that > Patch trades one bug for another. Hiding the menu bar also kills the > accelerator keys, which is especially problematic for the fullscreen > hotkey as there is no way out of fullscreen mode then. -- You received this bug notification because

Re: [Qemu-devel] Fullscreen Bug with GTK

2014-10-06 Thread Gerd Hoffmann
On Mo, 2014-10-06 at 12:14 +0200, Cedric Sodhi wrote: > > > https://bugs.launchpad.net/qemu/+bug/1294898 > > > > > > A patch was provided by the initial reporter a long time ago. > > > > Patch trades one bug for another. Hiding the menu bar also kills the > > accelerator keys, which is especially

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/5] target-ppc: Handle ibm, nmi-register RTAS call

2014-10-06 Thread Aravinda Prasad
On Monday 06 October 2014 03:10 PM, Alexander Graf wrote: > > > On 06.10.14 08:32, Aravinda Prasad wrote: >> >> >> On Monday 08 September 2014 02:17 AM, Alexander Graf wrote: >>> >>> >>> On 25.08.14 15:45, Aravinda Prasad wrote: This patch adds FWNMI support in qemu for powerKVM guest

Re: [Qemu-devel] Fullscreen Bug with GTK

2014-10-06 Thread Peter Maydell
On 6 October 2014 11:28, Gerd Hoffmann wrote: > On Mo, 2014-10-06 at 12:14 +0200, Cedric Sodhi wrote: >> The reporter explicitly mentioned that removing the Menu disables the >> Accels and therefore he has provided a patch which attaches the Accels >> to the Window instead (which, in fact, is how

[Qemu-devel] [PATCH v3 0/2] monitor: add peripheral device del completion support

2014-10-06 Thread Zhu Guihua
After inputting device_del command in monitor, we expect to list all hotpluggable devices automatically by pressing tab key. This patchset provides the function to list all peripheral devices such as memory devices. v3: - commit message changes (Igor) - rename function in patch 1 (Igor) - use 'hot

[Qemu-devel] [PATCH v3 1/2] qdev: add qdev_build_hotpluggable_device_list helper

2014-10-06 Thread Zhu Guihua
For peripheral device del completion, add a function to build a list for hotpluggable devices. Signed-off-by: Zhu Guihua --- hw/core/qdev.c | 14 ++ include/hw/qdev-core.h | 2 ++ 2 files changed, 16 insertions(+) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index fcb1638..

[Qemu-devel] [PATCH v3 2/2] monitor: add del completion for peripheral device

2014-10-06 Thread Zhu Guihua
Add peripheral_device_del_completion() to let peripheral device del completion be possible. Signed-off-by: Zhu Guihua --- monitor.c | 24 1 file changed, 24 insertions(+) diff --git a/monitor.c b/monitor.c index 667efb7..ffe5405 100644 --- a/monitor.c +++ b/monitor.c @@

Re: [Qemu-devel] [PULL 00/23] Block patches

2014-10-06 Thread Peter Maydell
On 4 October 2014 21:24, Stefan Hajnoczi wrote: > The following changes since commit b00a0ddb31a393b8386d30a9bef4d9bbb249e7ec: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-input-20141002-1' > into staging (2014-10-02 15:01:48 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] Fullscreen Bug with GTK

2014-10-06 Thread Cedric Sodhi
Sorry but whom do you expect to sign them off? I'm not a dev.     On 6 October 2014 11:28, Gerd Hoffmann wrote: > On Mo, 2014-10-06 at 12:14 +0200, Cedric Sodhi wrote: >> The reporter explicitly mentioned that removing the Menu disables the >> Accels and therefore he has provided a patch which att

Re: [Qemu-devel] [PATCH 0/2 V5] Virtual Machine Generation ID

2014-10-06 Thread Paolo Bonzini
Il 06/10/2014 11:06, Daniel P. Berrange ha scritto: > Now this can largely be accomplished by libvirt by simply changing the > value of the -vmgenid command line parameter, because most of these > scenarios involve the spawning of a new QEMU process. The exception > I think is when a running guest

Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good

2014-10-06 Thread Paolo Bonzini
Il 02/10/2014 15:49, Michael S. Tsirkin ha scritto: >>> The issue is that incoming migration might have a different >>> fw_cfg size from what we have. >> >> Understood now. >> >>> I think migrating this value will solve the issue in a cleaner way. >> >> Perhaps. The question is whether it would co

Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good

2014-10-06 Thread Paolo Bonzini
Il 06/10/2014 15:52, Michael S. Tsirkin ha scritto: > Maybe we should just modify ACPI and rom files in general to use > something else, not RAM? > It looked like a good fit initially so we went ahead with it, > but these things are fairly small, so it's not a problem to > migrate them as part of t

Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good

2014-10-06 Thread Michael S. Tsirkin
On Mon, Oct 06, 2014 at 03:42:01PM +0200, Paolo Bonzini wrote: > Il 02/10/2014 15:49, Michael S. Tsirkin ha scritto: > >>> The issue is that incoming migration might have a different > >>> fw_cfg size from what we have. > >> > >> Understood now. > >> > >>> I think migrating this value will solve th

Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good

2014-10-06 Thread Michael S. Tsirkin
On Mon, Oct 06, 2014 at 03:55:49PM +0200, Paolo Bonzini wrote: > Il 06/10/2014 15:52, Michael S. Tsirkin ha scritto: > > Maybe we should just modify ACPI and rom files in general to use > > something else, not RAM? > > It looked like a good fit initially so we went ahead with it, > > but these thin

Re: [Qemu-devel] [PATCH 04/17] mm: gup: make get_user_pages_fast and __get_user_pages_fast latency conscious

2014-10-06 Thread Andrea Arcangeli
Hello, On Fri, Oct 03, 2014 at 11:23:53AM -0700, Linus Torvalds wrote: > On Fri, Oct 3, 2014 at 10:07 AM, Andrea Arcangeli wrote: > > This teaches gup_fast and __gup_fast to re-enable irqs and > > cond_resched() if possible every BATCH_PAGES. > > This is disgusting. > > Many (most?) __gup_fast(

[Qemu-devel] [PATCH] aio / timers: De-document -clock

2014-10-06 Thread Markus Armbruster
Commit 6d32717 "aio / timers: Remove alarm timers" has issues: 1. It silently ignores -clock for backward compatibility. Incompatible change: -clock help no longer terminates the program. Tolerable. 2. Failed to update option documentation. In particular, -help still advises users to try -clock

[Qemu-devel] [PATCH] block/curl: Improve type safety of s->timeout.

2014-10-06 Thread Richard W.M. Jones
qemu_opt_get_number returns a uint64_t, and curl_easy_setopt expects a long (not an int). Store the timeout (which is a positive number of seconds) as a uint64_t. Check that the number given by the user is reasonable. Cast it to long before calling curl_easy_setopt. Example error message after t

[Qemu-devel] [PULL 5/5] translate-all.c: memory walker initial address miscalculation

2014-10-06 Thread riku . voipio
From: Mikhail Ilyin The initial base address is miscalculated in walk_memory_regions(). It has to be shifted TARGET_PAGE_BITS more. Holder variables are extended to target_ulong size otherwise they don't fit for MIPS N32 (a 32-bit ABI with a 64-bit address space) and qemu won't compile. The issue

[Qemu-devel] [PULL 3/5] linux-user: Simplify timerid checks on g_posix_timers range

2014-10-06 Thread riku . voipio
From: Alexander Graf We check whether the passed in timer id is negative on all calls that involve g_posix_timers. However, these checks are bogus. First off we limit the timer_id to 16 bits which is not what Linux does. Then we check whether it's negative which it can't be because we masked it.

[Qemu-devel] [PULL 4/5] linux-user: don't include timerfd if not needed

2014-10-06 Thread riku . voipio
From: Riku Voipio Without this, builds on older systems fail with: qemu/linux-user/syscall.c:61:25: warning: sys/timerfd.h: No such file or directory Signed-off-by: Riku Voipio --- linux-user/syscall.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/sys

[Qemu-devel] [PULL 0/5] linux-user patches for 2.2

2014-10-06 Thread riku . voipio
iku.voipio/qemu.git tags/pull-linux-user-20141006 for you to fetch changes up to 88555b7dfa79d7d21100d0b90730bf43d25d735b: translate-all.c: memory walker initial address miscalculation (2014-10-01 16:16:14 +0300) linux-user pull for 2.2

[Qemu-devel] [PULL 2/5] linux-user: Convert blkpg to use a special subop handler

2014-10-06 Thread riku . voipio
From: Alexander Graf The blkpg ioctl can take different payloads depending on the opcode in its payload structure. Create a new special ioctl handler that can only deal with partition style ones for now. This patch fixes running parted for me. Signed-off-by: Alexander Graf Signed-off-by: Riku

[Qemu-devel] [PULL 1/5] linux-user: Enable epoll_pwait syscall for ARM

2014-10-06 Thread riku . voipio
From: Peter Maydell We have support for the epoll_pwait syscall, but it wasn't enabled for ARM guests because we hadn't defined the syscall number; correct this deficiency. Reported-by: Dave Flogeras Signed-off-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/arm/syscall_nr.h | 2

Re: [Qemu-devel] [PATCH] block/curl: Improve type safety of s->timeout.

2014-10-06 Thread Laszlo Ersek
On 10/06/14 16:32, Richard W.M. Jones wrote: > qemu_opt_get_number returns a uint64_t, and curl_easy_setopt expects a > long (not an int). > > Store the timeout (which is a positive number of seconds) as a > uint64_t. Check that the number given by the user is reasonable. > Cast it to long before

Re: [Qemu-devel] [PATCH] block/curl: Improve type safety of s->timeout.

2014-10-06 Thread Richard W.M. Jones
On Mon, Oct 06, 2014 at 04:38:59PM +0200, Laszlo Ersek wrote: > On 10/06/14 16:32, Richard W.M. Jones wrote: > > qemu_opt_get_number returns a uint64_t, and curl_easy_setopt expects a > > long (not an int). > > > > Store the timeout (which is a positive number of seconds) as a > > uint64_t. Check

Re: [Qemu-devel] [PATCH] block/curl: Improve type safety of s->timeout.

2014-10-06 Thread Laszlo Ersek
On 10/06/14 16:40, Richard W.M. Jones wrote: > On Mon, Oct 06, 2014 at 04:38:59PM +0200, Laszlo Ersek wrote: >> On 10/06/14 16:32, Richard W.M. Jones wrote: >>> qemu_opt_get_number returns a uint64_t, and curl_easy_setopt expects a >>> long (not an int). >>> >>> Store the timeout (which is a positi

Re: [Qemu-devel] [PATCH] gdbstub: Allow target CPUs to specify watchpoint STOP_BEFORE_ACCESS flag

2014-10-06 Thread Peter Maydell
On 5 October 2014 23:07, Michael Walle wrote: > Am Sonntag, 5. Oktober 2014, 22:48:05 schrieb Peter Maydell: >> On 5 October 2014 22:36, Peter Maydell wrote: >> > On 5 October 2014 22:00, Michael Walle wrote: >> >> I can confirm that your patch makes qemu stop one instruction earlier. >> >> With

Re: [Qemu-devel] [PATCH v5 01/33] target-arm: increase arrays of registers R13 & R14

2014-10-06 Thread Peter Maydell
On 30 September 2014 22:49, Greg Bellows wrote: > From: Fabian Aggeler > > Increasing banked_r13 and banked_r14 to store LR_mon and SP_mon (bank > index 7). > > Signed-off-by: Fabian Aggeler > Reviewed-by: Edgar E. Iglesias > Signed-off-by: Greg Bellows > --- > target-arm/cpu.h | 4 ++-- >

[Qemu-devel] [PATCH] linuxboot: compute initrd loading address

2014-10-06 Thread Paolo Bonzini
Even though hw/i386/pc.c tries to compute a valid loading address for the initrd, close to the top of RAM, this does not take into account other data that is malloced into that memory by SeaBIOS. Luckily we can easily look at the memory map to find out how much memory is used up there. This patch

Re: [Qemu-devel] [PATCH] aio / timers: De-document -clock

2014-10-06 Thread Alex Bligh
OK by me - sorry about that. Alex On 6 Oct 2014, at 15:19, Markus Armbruster wrote: > Commit 6d32717 "aio / timers: Remove alarm timers" has issues: > > 1. It silently ignores -clock for backward compatibility. > Incompatible change: -clock help no longer terminates the program. > Tolerable. >

[Qemu-devel] [RFC PATCH] target-i386: move generic memory hotplug methods to DSDTs

2014-10-06 Thread Paolo Bonzini
This makes it simpler to keep the SSDT byte-for-byte identical for a given machine type, which is a goal we want to have for 2.2 and newer types. This is not tested well and is still missing update of "make check" data, but I wanted to throw this out for an early look. Signed-off-by: Paolo Bonzin

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-10-06 Thread Greg Kurz
On Wed, 17 Sep 2014 20:39:25 +0300 "Michael S. Tsirkin" wrote: > On Wed, Sep 17, 2014 at 07:21:09PM +0200, Greg Kurz wrote: > > On Sun, 14 Sep 2014 21:30:36 +0300 > > "Michael S. Tsirkin" wrote: > > > > > Current support for bus master (clearing OK bit) > > > together with the need to support g

[Qemu-devel] [PATCH v2 0/3] Migration-safe ACPI table sizing algorithm

2014-10-06 Thread Paolo Bonzini
In the emergency last-minute patches of QEMU 2.1 we did two things: - fixed migration problems from 1.7 or 2.0 to 2.1 due to changes in ACPI table sizes - ensured that future versions will not break migration compatibility with 2.2 for reasonable configurations (with ACPI tables smaller tha

[Qemu-devel] [PATCH v2 1/3] pc: introduce new ACPI table sizing algorithm

2014-10-06 Thread Paolo Bonzini
Add padding after the DSDT. Tables that vary depending on the command-line arguments will have to be byte-equivalent across QEMU versions >= 2.2, while fixed tables (including the DSDT) can be changed freely. This new algorithm will let us present smaller ACPI blobs to the guest, which avoids bug

[Qemu-devel] [PATCH v2 2/3] pc: go back to smaller ACPI tables

2014-10-06 Thread Paolo Bonzini
The new algorithm introduced by the previous patch lets us make tables smaller and avoid bugs due to large tables. Use it for 2.2+ machine types by tweaking the default fixed_table_align and acpi_table_align values. At the same time, preserve backwards-compatible logic for pc-i440fx-2.1. Without

Re: [Qemu-devel] [PATCH v5 02/33] target-arm: add arm_is_secure() function

2014-10-06 Thread Peter Maydell
On 30 September 2014 22:49, Greg Bellows wrote: > From: Fabian Aggeler > > arm_is_secure() function allows to determine CPU security state > if the CPU implements Security Extensions/EL3. > arm_is_secure_below_el3() returns true if CPU is in secure state > below EL3. > > Signed-off-by: Sergey Fed

[Qemu-devel] [PATCH v2 3/3] pc: clean up pre-2.1 compatibility code

2014-10-06 Thread Paolo Bonzini
Now that the alignment is parameterized, we can share the call to acpi_align_size between all three (1.7-2.0/2.1/2.2+) sizing algorithms. Also, with the new rule that SSDT cannot change except with machine-type compat code, the magic 97 constant for a CPU's AML size is not anymore "legacy", so ren

Re: [Qemu-devel] [PULL 0/5] linux-user patches for 2.2

2014-10-06 Thread Peter Maydell
available in the git repository at: > > git://git.linaro.org/people/riku.voipio/qemu.git > tags/pull-linux-user-20141006 > > for you to fetch changes up to 88555b7dfa79d7d21100d0b90730bf43d25d735b: > > translate-all.c: memory walker initi

Re: [Qemu-devel] [PATCH v5 03/33] target-arm: reject switching to monitor mode

2014-10-06 Thread Peter Maydell
On 30 September 2014 22:49, Greg Bellows wrote: > From: Sergey Fedorov > > ...from non-secure state. > > Signed-off-by: Sergey Fedorov > Signed-off-by: Fabian Aggeler > Reviewed-by: Edgar E. Iglesias > Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell though as a style nit I would pre

Re: [Qemu-devel] [PATCH] gdb: provide the name of the architecture in the target.xml

2014-10-06 Thread Cornelia Huck
On Tue, 30 Sep 2014 17:23:47 +0200 Jens Freimann wrote: > From: David Hildenbrand > > This patch provides the name of the architecture in the target.xml if > available. > > This allows the remote gdb to detect the target architecture on its own - so > there is no need to specify it manually (

Re: [Qemu-devel] [PATCH v5 04/33] target-arm: rename arm_current_pl to arm_current_el

2014-10-06 Thread Peter Maydell
On 30 September 2014 22:49, Greg Bellows wrote: > Renamed the arm_current_pl CPU function to more accurately represent that it > returns the ARMv8 EL rather than ARMv7 PL. > > Signed-off-by: Greg Bellows > --- > target-arm/cpu.h | 18 +- > target-arm/helper-a64.c|

Re: [Qemu-devel] [PATCH v5 05/33] target-arm: make arm_current_pl() return PL3

2014-10-06 Thread Peter Maydell
On 30 September 2014 22:49, Greg Bellows wrote: > From: Fabian Aggeler > > Make arm_current_pl() return PL3 for secure PL1 and monitor mode. > Increase MMU modes since mmu_index is directly infered from arm_ > current_pl(). Changes assertion in arm_el_is_aa64() to allow EL3. > > Signed-off-by: Fa

Re: [Qemu-devel] [PATCH v5 06/33] target-arm: A32: Emulate the SMC instruction

2014-10-06 Thread Peter Maydell
On 30 September 2014 22:49, Greg Bellows wrote: > From: Fabian Aggeler > > Implements SMC instruction in Aarch32 using the A32 syndrome. When executing > SMC instruction from monitor CPU mode SCR.NS bit is reset. > > Signed-off-by: Sergey Fedorov > Signed-off-by: Fabian Aggeler > Signed-off-by:

Re: [Qemu-devel] [PATCH v5 07/33] target-arm: extend async excp masking

2014-10-06 Thread Peter Maydell
On 30 September 2014 22:49, Greg Bellows wrote: > From: Fabian Aggeler > > This patch extends arm_excp_unmasked() according to ARM ARMv7 and > ARM ARMv8 (all EL running in Aarch32) and adds comments. "AA" (just do a search and replace through the whole patchset, please.) > > If EL3 is using Aar

Re: [Qemu-devel] [PATCH v5 08/33] target-arm: add async excp target_el function

2014-10-06 Thread Peter Maydell
On 30 September 2014 22:49, Greg Bellows wrote: > From: Fabian Aggeler > > Adds a dedicated function for IRQ and FIQ exceptions to determine > target_el and mode (Aarch32) according to tables in ARM ARMv8 and > ARM ARM v7. > > Signed-off-by: Fabian Aggeler > Signed-off-by: Greg Bellows > >

Re: [Qemu-devel] [PATCH v5 09/33] target-arm: add macros to access banked registers

2014-10-06 Thread Peter Maydell
On 30 September 2014 22:49, Greg Bellows wrote: > From: Fabian Aggeler > > If EL3 is in Aarch32 state certain cp registers are banked (secure and > non-secure instance). When reading or writing to coprocessor registers > the following macros can be used. > > - A32_BANKED macros are used for choos

Re: [Qemu-devel] [PATCH v5 10/33] target-arm: add non-secure Translation Block flag

2014-10-06 Thread Peter Maydell
On 30 September 2014 22:49, Greg Bellows wrote: > From: Sergey Fedorov > > This patch is based on idea found in patch at > git://github.com/jowinter/qemu-trustzone.git > f3d955c6c0ed8c46bc0eb10b634201032a651dd2 by > Johannes Winter . > > This flag prevents QEMU from executing TCG code generated f

Re: [Qemu-devel] [PATCH v5 11/33] target-arm: arrayfying fieldoffset for banking

2014-10-06 Thread Peter Maydell
On 30 September 2014 22:49, Greg Bellows wrote: > From: Fabian Aggeler > > Prepare ARMCPRegInfo to support specifying two fieldoffsets per > register definition. This will allow us to keep one register > definition for banked registers (different offsets for secure/ > non-secure world). > > Signe

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-10-06 Thread Michael S. Tsirkin
On Mon, Oct 06, 2014 at 04:51:35PM +0200, Greg Kurz wrote: > On Wed, 17 Sep 2014 20:39:25 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Sep 17, 2014 at 07:21:09PM +0200, Greg Kurz wrote: > > > On Sun, 14 Sep 2014 21:30:36 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > Current support

Re: [Qemu-devel] [PATCH v5 12/33] target-arm: insert Aarch32 cpregs twice into hashtable

2014-10-06 Thread Peter Maydell
On 30 September 2014 22:49, Greg Bellows wrote: > From: Fabian Aggeler > > Prepare for cp register banking by inserting every cp register twice, > once for secure world and once for non-secure world. > > Signed-off-by: Fabian Aggeler > Signed-off-by: Greg Bellows > > -- > v4 -> v5 > - A

Re: [Qemu-devel] [PATCH v5 32/33] target-arm: add GDB scr register

2014-10-06 Thread Peter Maydell
On 30 September 2014 22:49, Greg Bellows wrote: > Added the ability to print the scr register like can be done with the cpsr. > > Signed-off-by: Greg Bellows Not sure you can just arbitrarily add new core registers if gdb isn't expecting them, and in any case if we want to do this we should prob

Re: [Qemu-devel] [PATCH v5 33/33] target-arm: add cpu feature EL3 to CPUs with Security Extensions

2014-10-06 Thread Peter Maydell
On 30 September 2014 22:49, Greg Bellows wrote: > From: Fabian Aggeler > > Set ARM_FEATURE_EL3 feature for CPUs that implement Security Extensions. > > Signed-off-by: Fabian Aggeler > Signed-off-by: Greg Bellows (as we've discussed, but just as a note for the wider audience:) This is the patch

Re: [Qemu-devel] [PATCH v5 00/33] target-arm: add Security Extensions for CPUs

2014-10-06 Thread Peter Maydell
On 30 September 2014 22:49, Greg Bellows wrote: > Version 5 of the ARM processor security extension (TrustZone) support. > This patchset includes changes to support the processor security extensions > on ARMv7 aarch32 with hooks for later enabling v8 aarch64/32. Thanks. I've reviewed the first do

Re: [Qemu-devel] [PATCH 10/17] mm: rmap preparation for remap_anon_pages

2014-10-06 Thread Andrea Arcangeli
Hello, On Mon, Oct 06, 2014 at 09:55:41AM +0100, Dr. David Alan Gilbert wrote: > * Linus Torvalds (torva...@linux-foundation.org) wrote: > > On Fri, Oct 3, 2014 at 10:08 AM, Andrea Arcangeli > > wrote: > > > > > > Overall this looks a fairly small change to the rmap code, notably > > > less intr

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-10-06 Thread Greg Kurz
On Mon, 6 Oct 2014 19:26:21 +0300 "Michael S. Tsirkin" wrote: > On Mon, Oct 06, 2014 at 04:51:35PM +0200, Greg Kurz wrote: > > On Wed, 17 Sep 2014 20:39:25 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Sep 17, 2014 at 07:21:09PM +0200, Greg Kurz wrote: > > > > On Sun, 14 Sep 2014 21:30

Re: [Qemu-devel] [PULL 0/5] linux-user patches for 2.2

2014-10-06 Thread Peter Maydell
On 6 October 2014 15:59, Peter Maydell wrote: > Hi. I'm afraid this doesn't compile on my ARM box: > > /root/qemu/linux-user/syscall.c: In function ‘do_syscall’: > /root/qemu/linux-user/syscall.c:9695:9: error: implicit declaration of > function ‘timerfd_create’ [-Werror=implicit-function-declarat

Re: [Qemu-devel] Question on qemu threads

2014-10-06 Thread Al Patel
Thank You, Brian and Stefan! -a On Thu, Oct 2, 2014 at 11:15 AM, Stefan Hajnoczi wrote: > On Tue, Sep 30, 2014 at 01:44:48PM -0400, Al Patel wrote: > > In the current system, what are the extra threads? > > The set of thread is dynamic because worker threads are started and > terminated depend

Re: [Qemu-devel] [PATCH] gdb: provide the name of the architecture in the target.xml

2014-10-06 Thread Peter Maydell
On 6 October 2014 16:08, Cornelia Huck wrote: > On Tue, 30 Sep 2014 17:23:47 +0200 > Jens Freimann wrote: > >> From: David Hildenbrand >> >> This patch provides the name of the architecture in the target.xml if >> available. >> >> This allows the remote gdb to detect the target architecture on

Re: [Qemu-devel] [PATCH] gdb: provide the name of the architecture in the target.xml

2014-10-06 Thread Peter Maydell
On 30 September 2014 16:23, Jens Freimann wrote: > From: David Hildenbrand > > This patch provides the name of the architecture in the target.xml if > available. > > This allows the remote gdb to detect the target architecture on its own - so > there is no need to specify it manually (e.g. if gd

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-10-06 Thread Michael S. Tsirkin
On Mon, Oct 06, 2014 at 06:46:17PM +0200, Greg Kurz wrote: > On Mon, 6 Oct 2014 19:26:21 +0300 > "Michael S. Tsirkin" wrote: > > On Mon, Oct 06, 2014 at 04:51:35PM +0200, Greg Kurz wrote: > > > On Wed, 17 Sep 2014 20:39:25 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Wed, Sep 17, 201

Re: [Qemu-devel] [PATCH 08/17] mm: madvise MADV_USERFAULT

2014-10-06 Thread Andrea Arcangeli
Hi, On Sat, Oct 04, 2014 at 08:13:36AM +0900, Mike Hommey wrote: > On Fri, Oct 03, 2014 at 07:07:58PM +0200, Andrea Arcangeli wrote: > > MADV_USERFAULT is a new madvise flag that will set VM_USERFAULT in the > > vma flags. Whenever VM_USERFAULT is set in an anonymous vma, if > > userland touches a

Re: [Qemu-devel] [PATCH v5 02/33] target-arm: add arm_is_secure() function

2014-10-06 Thread Sergey Fedorov
On 06.10.2014 07:56, Peter Maydell wrote: > On 30 September 2014 22:49, Greg Bellows wrote: >> From: Fabian Aggeler >> >> arm_is_secure() function allows to determine CPU security state >> if the CPU implements Security Extensions/EL3. >> arm_is_secure_below_el3() returns true if CPU is in secure

[Qemu-devel] [PATCH 0/2] qemu-char: Clean up socket reporting

2014-10-06 Thread minyard
The first patch fixes some reporting issues for reconnect sockets that fail to connect. It prevents a constant stream of error messages, and reports the error immediately instead of delaying it. This required a small restructure, but nothing big. The second adds an error to non-blocking connect

[Qemu-devel] [PATCH 1/2] qemu-char: Fix reconnect socket error reporting

2014-10-06 Thread minyard
From: Corey Minyard If reconnect was set, errors wouldn't always be reported. Fix that and also only report a connect error once until a connection has been made. The primary purpose of this is to tell the user that a connection failed so they can know they need to figure out what went wrong. S

[Qemu-devel] [PATCH 2/2] qemu-sockets: Add error to non-blocking connect handler

2014-10-06 Thread minyard
From: Corey Minyard An error value here would be quite handy and more consistent with the rest of the code. Corey Minyard --- include/qemu/sockets.h | 2 +- migration-tcp.c| 4 ++-- migration-unix.c | 4 ++-- qemu-char.c| 12 +++- util/qemu-sockets.c| 1

Re: [Qemu-devel] [PATCH v5 02/33] target-arm: add arm_is_secure() function

2014-10-06 Thread Peter Maydell
On 6 October 2014 18:57, Sergey Fedorov wrote: > On 06.10.2014 07:56, Peter Maydell wrote: >> Can these functions live in internals.h rather than cpu.h? >> (The difference is that internals.h is restricted to only >> target-arm/ code whereas cpu.h is auto-included for a much >> wider set of files.

Re: [Qemu-devel] [PATCH v5 10/33] target-arm: add non-secure Translation Block flag

2014-10-06 Thread Sergey Fedorov
On 06.10.2014 09:13, Peter Maydell wrote: > On 30 September 2014 22:49, Greg Bellows wrote: >> From: Sergey Fedorov >> >> This patch is based on idea found in patch at >> git://github.com/jowinter/qemu-trustzone.git >> f3d955c6c0ed8c46bc0eb10b634201032a651dd2 by >> Johannes Winter . >> >> This fl

Re: [Qemu-devel] [PATCH 1/2] qemu-char: Fix reconnect socket error reporting

2014-10-06 Thread Eric Blake
On 10/06/2014 11:59 AM, miny...@acm.org wrote: > From: Corey Minyard > > If reconnect was set, errors wouldn't always be reported. > Fix that and also only report a connect error once until a > connection has been made. > > The primary purpose of this is to tell the user that a > connection fail

Re: [Qemu-devel] [PATCH v4 38/47] Add assertion to check migration_dirty_pages

2014-10-06 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto: > > > > I've seen it go negative once during dev, it shouldn't > > happen. > > You can move it earlier, perhaps even as patch 1, since it does not have > any dependency on postcopy and can

Re: [Qemu-devel] [PATCH v4 20/47] Add migration-capability boolean for postcopy-ram.

2014-10-06 Thread Eric Blake
On 10/03/2014 11:47 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: Eric Blake > --- > include/migration/migration.h | 1 + > migration.c | 9 + > qapi-schema.json | 6 +

Re: [Qemu-devel] [PATCH v4 32/47] postcopy: ram_enable_notify to switch on userfault

2014-10-06 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto: > > +static int postcopy_ram_sensitise_area(const char *block_name, void > > *host_addr, > > + ram_addr_t offset, ram_addr_t > > length, > > +

Re: [Qemu-devel] [PULL 0/5] linux-user patches for 2.2

2014-10-06 Thread Riku Voipio
On Mon, Oct 06, 2014 at 05:49:14PM +0100, Peter Maydell wrote: > On 6 October 2014 15:59, Peter Maydell wrote: > > Hi. I'm afraid this doesn't compile on my ARM box: > > > > /root/qemu/linux-user/syscall.c: In function ‘do_syscall’: > > /root/qemu/linux-user/syscall.c:9695:9: error: implicit decla

Re: [Qemu-devel] [PATCH v4 20/47] Add migration-capability boolean for postcopy-ram.

2014-10-06 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 10/03/2014 11:47 AM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Signed-off-by: Dr. David Alan Gilbert > > Reviewed-by: Eric Blake > > --- > > include/migration/migration.h | 1 + > > migration.c

[Qemu-devel] [PULL v2 2/5] linux-user: Convert blkpg to use a special subop handler

2014-10-06 Thread riku . voipio
From: Alexander Graf The blkpg ioctl can take different payloads depending on the opcode in its payload structure. Create a new special ioctl handler that can only deal with partition style ones for now. This patch fixes running parted for me. Signed-off-by: Alexander Graf Signed-off-by: Riku

[Qemu-devel] [PULL v2 3/5] linux-user: Simplify timerid checks on g_posix_timers range

2014-10-06 Thread riku . voipio
From: Alexander Graf We check whether the passed in timer id is negative on all calls that involve g_posix_timers. However, these checks are bogus. First off we limit the timer_id to 16 bits which is not what Linux does. Then we check whether it's negative which it can't be because we masked it.

[Qemu-devel] [PULL v2 1/5] linux-user: Enable epoll_pwait syscall for ARM

2014-10-06 Thread riku . voipio
From: Peter Maydell We have support for the epoll_pwait syscall, but it wasn't enabled for ARM guests because we hadn't defined the syscall number; correct this deficiency. Reported-by: Dave Flogeras Signed-off-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/arm/syscall_nr.h | 2

[Qemu-devel] [PULL v2 5/5] translate-all.c: memory walker initial address miscalculation

2014-10-06 Thread riku . voipio
From: Mikhail Ilyin The initial base address is miscalculated in walk_memory_regions(). It has to be shifted TARGET_PAGE_BITS more. Holder variables are extended to target_ulong size otherwise they don't fit for MIPS N32 (a 32-bit ABI with a 64-bit address space) and qemu won't compile. The issue

[Qemu-devel] [PULL v2 0/5] linux-user patches for 2.2

2014-10-06 Thread riku . voipio
tags/pull-linux-user-20141006-2 for you to fetch changes up to 1a1c4db9b298956e89caf53b09b6a7a960d55d66: translate-all.c: memory walker initial address miscalculation (2014-10-06 21:53:35 +0300) linux-user pull for 2.2 Clearest

[Qemu-devel] [PULL v2 4/5] linux-user: don't include timerfd if not needed

2014-10-06 Thread riku . voipio
From: Riku Voipio Without this, builds on older systems fail with: qemu/linux-user/syscall.c:61:25: warning: sys/timerfd.h: No such file or directory v2: fix the usual case where CONFIG_TIMERFD is enabled.. Signed-off-by: Riku Voipio --- linux-user/syscall.c | 4 +++- 1 file changed, 3 inse

Re: [Qemu-devel] [PATCH] gdb: provide the name of the architecture in the target.xml

2014-10-06 Thread David Hildenbrand
> On 6 October 2014 16:08, Cornelia Huck wrote: > > On Tue, 30 Sep 2014 17:23:47 +0200 > > Jens Freimann wrote: > > > >> From: David Hildenbrand > >> > >> This patch provides the name of the architecture in the target.xml if > >> available. > >> > >> This allows the remote gdb to detect the tar

  1   2   >