On 6 October 2014 18:57, Sergey Fedorov <serge.f...@gmail.com> wrote: > On 06.10.2014 07:56, Peter Maydell wrote: >> Can these functions live in internals.h rather than cpu.h? >> (The difference is that internals.h is restricted to only >> target-arm/ code whereas cpu.h is auto-included for a much >> wider set of files.) > > Probably arm_is_secure() would be used by ARM GIC emulation until there > is no better way to determine memory transaction NS tag.
We could have the GIC code temporarily include internals.h, which would be a nice big red flag that it was doing things the wrong way :-) -- PMM