Il 27/09/2014 03:13, zwu.ker...@gmail.com ha scritto:
> From: Zhi Yong Wu
>
> lt LINK libcacard.la
> CClibcacard/vscclient.o
> lt LINK vscclient
> /usr/bin/ld: -f may not be used without -shared
> collect2: ld returned 1 exit status
> make: *** [vscclient] Error 1
>
> Signed-off-by: Zhi Yo
Hi,
> Subject: Re: [PATCH v3 0/3] add check for PCIe root ports and downstream
> ports
>
> On Mon, Sep 01, 2014 at 09:29:16PM +0800, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > Root ports and downstream ports of switches are the hot
> > pluggable ports in a PCI Express hierarchy.
>
Il 18/09/2014 15:06, arei.gong...@huawei.com ha scritto:
> we will lose the error message. Using error_report
> to report it.
>
> Cc: Markus Armbruster
> Signed-off-by: Gonglei
> Reviewed-by: Markus Armbruster
> Reviewed-by: Eric Blake
> ---
> v4:
> fix typo in the subject (Eric), Thanks.
> v
Signed-off-by: Peter Lieven
---
block/iscsi.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 5c72ffe..3a01de0 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -316,6 +316,13 @@ static bool is_request_lun_aligned(int6
regular bitmap_new simply aborts if the memory allocation fails.
bitmap_try_new returns NULL on failure and allows for proper
error handling.
Signed-off-by: Peter Lieven
---
include/qemu/bitmap.h | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/include/qemu/bi
this adds a new helper to handle errors when allocation a bitmap and
also introduces its first user.
v1->v2: - derive bitmap_new from bitmap_try_new (Eric)
- fail if allocation fails in iscsi_open (Paolo)
Peter Lieven (2):
util: introduce bitmap_try_new
block/iscsi: handle failure on
Hi,
> Subject: Re: [PATCH v4] pci-hotplug-old: avoid losing error message
>
> Il 18/09/2014 15:06, arei.gong...@huawei.com ha scritto:
> > we will lose the error message. Using error_report
> > to report it.
> >
> > Cc: Markus Armbruster
> > Signed-off-by: Gonglei
> > Reviewed-by: Markus Armbru
On 23.09.2014 12:05, Kevin Wolf wrote:
Am 23.09.2014 um 11:52 hat Peter Lieven geschrieben:
On 23.09.2014 11:47, Kevin Wolf wrote:
Am 23.09.2014 um 11:32 hat Peter Lieven geschrieben:
On 23.09.2014 10:59, Kevin Wolf wrote:
Am 23.09.2014 um 08:15 hat Peter Lieven geschrieben:
On 22.09.2014 21
From: Gonglei
When scsi_bus_legacy_add_drive() produces an error,
we will lose the error message. Using qerror_report_err
to report it because it is an HMP-only command.
Cc: Markus Armbruster
Cc: Paolo Bonzini
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
Reviewed-by: Eric Blake
---
John Snow writes:
> Instead of duplicating the logic for the if_ide
> (bus,unit) mappings, rely on the blockdev layer
> for managing those mappings for us, and use the
> drive_get_by_index call instead.
>
> This allows ide_drive_get to work for AHCI HBAs
> as well, and can be used in the Q35 init
John Snow writes:
> This patch implements the backend for the Q35 board
> for us to be able to pick up and use drives defined
> by the -cdrom, -hda, or -drive if=ide shorthand options.
>
> Signed-off-by: John Snow
> ---
> hw/i386/pc_q35.c | 4
> hw/ide/ahci.c| 15 +++
> hw
On Di, 2014-09-30 at 10:27 +1000, Dave Airlie wrote:
> > Triggered by the framebuffer endian issues we have with stdvga I've
> > started to check where we stand with virtio-gpu and whenever we have to
> > fix something in the virtio protocol before setting in stone with the
> > upstream merge.
>
On Di, 2014-09-30 at 10:27 +1000, Dave Airlie wrote:
> > Triggered by the framebuffer endian issues we have with stdvga I've
> > started to check where we stand with virtio-gpu and whenever we have to
> > fix something in the virtio protocol before setting in stone with the
> > upstream merge.
>
Hi,
> > case 15:
> > -v = VGA_DRAW_LINE15;
> > +v = big_endian_fb ? VGA_DRAW_LINE15_BE : VGA_DRAW_LINE15_LE;
> > bits = 16;
> > break;
> > case 16:
> > -v = VGA_DRAW_LINE16;
> > +v = big_endian_fb ? VGA_D
On Tue, 30 Sep 2014 14:10:26 +0800
wrote:
> From: Gonglei
>
> virtio-$device-{pci, s390, ccw} all duplicate the
> qdev properties of their virtio child. This approach does
> not work well with string or pointer properties since we
> must be careful about leaking or double-freeing them.
>
> Use
John Snow writes:
> The Q35 board initialization does not currently bother to look
> for any drives added by the various syntactical sugar shorthands
> to be added to the AHCI HBA. These include -hda through -hdd,
> -cdrom, and -drive if=ide shorthands.
>
> An obstacle to having implemented this
Am 30.09.2014 um 09:26 hat Peter Lieven geschrieben:
> On 23.09.2014 12:05, Kevin Wolf wrote:
> >Am 23.09.2014 um 11:52 hat Peter Lieven geschrieben:
> >>On 23.09.2014 11:47, Kevin Wolf wrote:
> >>>Am 23.09.2014 um 11:32 hat Peter Lieven geschrieben:
> On 23.09.2014 10:59, Kevin Wolf wrote:
> >
> Subject: Re: [PATCH v2 00/12] virtio: fix virtio child recount in transports
>
> On Tue, 30 Sep 2014 14:10:26 +0800
> wrote:
>
> > From: Gonglei
> >
> > virtio-$device-{pci, s390, ccw} all duplicate the
> > qdev properties of their virtio child. This approach does
> > not work well with strin
Paolo Bonzini writes:
> Il 18/09/2014 15:06, arei.gong...@huawei.com ha scritto:
>> we will lose the error message. Using error_report
>> to report it.
>>
>> Cc: Markus Armbruster
>> Signed-off-by: Gonglei
>> Reviewed-by: Markus Armbruster
>> Reviewed-by: Eric Blake
>> ---
>> v4:
>> fix typ
writes:
> From: Gonglei
>
> When scsi_bus_legacy_add_drive() produces an error,
> we will lose the error message. Using qerror_report_err
> to report it because it is an HMP-only command.
>
> Cc: Markus Armbruster
> Cc: Paolo Bonzini
> Signed-off-by: Gonglei
> Reviewed-by: Markus Armbruster
Il 30/09/2014 03:05, Don Slutz ha scritto:
>
> Basically current_cpu is NULL here, and I think that no CPU objects
> have been created for Xen. So there is no VCPU object to select.
CPU objects are created for Xen HVM, though not for PV.
You would have to visit the list of CPUs and fill in an a
On Tue, 30 Sep 2014 14:10:27 +0800
wrote:
> From: Gonglei
>
> virtio-net-pci, virtio-net-s390, and virtio-net-ccw all duplicate the
> qdev properties of their VirtIONet child. This approach does not work
> well with string or pointer properties since we must be careful about
> leaking or double
Il 30/09/2014 10:12, Markus Armbruster ha scritto:
> error_report() is just fine here. qerror_report() is never necessary in
> HMP-only code. It makes a difference only in QMP context, and even
> there it should only be used in code that hasn't been converted to the
> Error API. For an example,
On Tue, 30 Sep 2014 14:10:28 +0800
wrote:
> From: Gonglei
>
> object_initialize() leaves the object with a refcount of 1.
> object_property_add_child() adds its own reference which is dropped
> again when the property is deleted.
>
> The upshot of this is that we always have a refcount >= 1.
> Subject: Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error
> message
>
> Il 30/09/2014 10:12, Markus Armbruster ha scritto:
> > error_report() is just fine here. qerror_report() is never necessary in
> > HMP-only code. It makes a difference only in QMP context, and even
> > there
Hi,
There exits packets loss when we do packet forwarding in VM,
especially when we use dpdk to do the forwarding. By enlarging vring
can alleviate the problem. But now vring size is limited to 1024 as follows:
VirtQueue *virtio_add_queue(VirtIODevice *vdev, int queue_size,
On 2014/9/29 16:06, Markus Armbruster wrote:
zhanghailiang writes:
Functions shouldn't return an error code and an Error object at the same time.
Turn all these functions that returning Error object to void.
We also judge if a function success or fail by reference to the local_err.
Signed-off
Il 30/09/2014 08:10, arei.gong...@huawei.com ha scritto:
> From: Gonglei
>
> virtio-$device-{pci, s390, ccw} all duplicate the
> qdev properties of their virtio child. This approach does
> not work well with string or pointer properties since we
> must be careful about leaking or double-freeing t
On Tue, 30 Sep 2014 14:10:29 +0800
wrote:
> From: Gonglei
>
> {virtio, vhost}-scsi-{pci, s390, ccw} all duplicate the
> qdev properties of their VirtIOSCSI/VHostSCSI child.
> This approach does not work well with string or pointer
> properties since we must be careful about leaking or
> double-
Il 30/09/2014 05:40, Fam Zheng ha scritto:
> For VIRTIO_SCSI_T_TMF_ABORT_TASK and VIRTIO_SCSI_T_TMF_ABORT_TASK_SET,
> use scsi_req_cancel_async to start the cancellation.
>
> Because each tmf command may cancel multiple requests, we need to use a
> counter to track the number of remaining requests
On Tue, 30 Sep 2014 14:10:30 +0800
wrote:
> From: Gonglei
>
> object_initialize() leaves the object with a refcount of 1.
> object_property_add_child() adds its own reference which is dropped
> again when the property is deleted.
>
> The upshot of this is that we always have a refcount >= 1.
On Mo, 2014-09-29 at 15:15 +0200, Michael Walle wrote:
> Hi Anthony, Hi Gerd,
>
> the GTK frontend does not respect the the "chr_can_read" hook. The
> frontend just writes characters to the device using qemu_chr_be_write()
> without checking if the device can receive any input
> (qemu_chr_be_ca
On Tue, 30 Sep 2014 14:10:31 +0800
wrote:
> From: Gonglei
>
> virtio-serial-{pci, s390, ccw} all duplicate the
> qdev properties of their VirtIOSerial child.
> This approach does not work well with string or pointer
> properties since we must be careful about leaking or
> double-freeing them.
>
On Tue, 30 Sep 2014 14:10:32 +0800
wrote:
> From: Gonglei
>
> object_initialize() leaves the object with a refcount of 1.
> object_property_add_child() adds its own reference which is dropped
> again when the property is deleted.
>
> The upshot of this is that we always have a refcount >= 1.
On Tue, 30 Sep 2014 14:10:33 +0800
wrote:
> From: Gonglei
>
> virtio-rng-{pci, s390, ccw} all duplicate the
> qdev properties of their VirtIORNG child.
> This approach does not work well with string or pointer
> properties since we must be careful about leaking or
> double-freeing them.
>
> Us
On Tue, 30 Sep 2014 14:10:34 +0800
wrote:
> From: Gonglei
>
> object_initialize() leaves the object with a refcount of 1.
> object_property_add_child() adds its own reference which is dropped
> again when the property is deleted.
>
> The upshot of this is that we always have a refcount >= 1.
On Tue, 30 Sep 2014 14:10:35 +0800
wrote:
> From: Gonglei
>
> object_initialize() leaves the object with a refcount of 1.
> object_property_add_child() adds its own reference which is dropped
> again when the property is deleted.
>
> The upshot of this is that we always have a refcount >= 1.
Il 30/09/2014 05:02, arei.gong...@huawei.com ha scritto:
> From: Gonglei
>
> This patch series based on qom-next tree:
> https://github.com/afaerber/qemu-cpu/commits/qom-next
>
> Add a description field in both ObjectProperty and PropertyInfo struct.
> The descriptions can serve as documentatio
From: David Hildenbrand
We need to synchronize registers after a reset has been performed. The
current code does that in qemu_system_reset(), load_normal_reset() and
modified_clear_reset() for all vcpus. After SIGP (INITIAL) CPU RESET,
this needs to be done for the targeted vcpu as well, so let's
From: David Hildenbrand
Until now, when a s390 cpu was stopped or halted, the number of running
CPUs was tracked in a global variable. This was problematic for migration,
so Jason came up with a per-cpu running state.
As it turns out, we want to track the full logical state of a target vcpu,
so w
From: David Hildenbrand
This patch reuses kvm_s390_reset_vcpu() to get rid of some CONFIG_KVM and
CONFIG_USER_ONLY ifdefs in cpu.c.
In order to get rid of CONFIG_USER_ONLY, kvm_s390_reset_vcpu() has to provide a
dummy implementation - the two definitions are moved to the proper section in
cpu.h.
From: David Hildenbrand
This patch makes sure that halting a cpu and stopping a cpu are two different
things. Stopping a cpu will also set the cpu halted - this is needed for common
infrastructure to work (note that the stop and stopped flag cannot be used for
our purpose because they are already
Cornelia, Christian, Alex, Andreas,
This is the QEMU part of the kernel series "Let user space control cpu states".
Patch 1 updates the linux-header files. Needed for the cpu state patches.
Patch 2 adds new cpu states for s390 and gets rid of global counter for
running cpus
Patch 3 uses t
From: David Hildenbrand
Let QEMU propagate the cpu state to kvm. If kvm doesn't yet support it, it is
silently ignored as kvm will still handle the cpu state itself in that case.
The state is not synced back, thus kvm won't have a chance to actively modify
the cpu state. To do so, control has to
Sync headers with 3.17-rc7
Signed-off-by: Jens Freimann
---
linux-headers/asm-mips/kvm_para.h | 6 +-
linux-headers/asm-powerpc/kvm.h | 2 ++
linux-headers/asm-x86/kvm.h | 3 +++
linux-headers/linux/kvm.h | 13 ++---
linux-headers/linux/kvm_para.h| 3 +++
linu
Cornelia, Christian, Alex, Andreas,
this patch enables migration for CPUs on s390x. It should go on top of the
"track the logical cpu state in QEMU and propagate it to kvm" series.
Still missing for full migration support is:
- guest TOD clock
- interrupts
- storage keys
With this patch migratio
From: Thomas Huth
This patch provides the cpu save information for dumps and later life
migration and enables migration of the CPU state. The code is based on
earlier work from Christian Borntraeger and Jason Herne.
Signed-off-by: Thomas Huth
Signed-off-by: David Hildenbrand
[provide cpu_post_
On Tue, Sep 30, 2014 at 09:59:30AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > > case 15:
> > > -v = VGA_DRAW_LINE15;
> > > +v = big_endian_fb ? VGA_DRAW_LINE15_BE : VGA_DRAW_LINE15_LE;
> > > bits = 16;
> > > break;
> > > case 16:
>
On Tue, 30 Sep 2014 14:10:38 +0800
wrote:
> From: Gonglei
>
> For better code sharing, add a wrapper help funciton
typo: s/funciton/function/
> for various virtio devices.
s/for various virtio devices/that handles referencing the virtio
backend for virtio proxy devices/ ?
>
> Cc: Cornelia
Il 30/09/2014 11:04, Cornelia Huck ha scritto:
>> > For better code sharing, add a wrapper help funciton
> typo: s/funciton/function/
>
>> > for various virtio devices.
> s/for various virtio devices/that handles referencing the virtio
> backend for virtio proxy devices/ ?
>
"For better code sha
lt LINK libcacard.la
CClibcacard/vscclient.o
lt LINK vscclient
/usr/bin/ld: -f may not be used without -shared
collect2: ld returned 1 exit status
make: *** [vscclient] Error 1
Suguested-by: Paolo Bonzini
Signed-off-by: Zhi Yong Wu
---
Makefile |2 ++
1 files changed, 2 insertions(+),
Can one of you give some more information about the qcow2 image that can't be
opened any more? What is new is a sanity check of the snapshot metadata (name,
date, etc.) size. It is currently limited to 64 MB, which should be plenty of
space for any real use cases.
I suspect that your qcow2 got som
Il 30/09/2014 11:04, Cornelia Huck ha scritto:
> On Tue, 30 Sep 2014 14:10:38 +0800
> wrote:
>
>> From: Gonglei
>>
>> For better code sharing, add a wrapper help funciton
>
> typo: s/funciton/function/
>
>> for various virtio devices.
>
> s/for various virtio devices/that handles referencing
Hi,
In original code, Function dump_error ignores its second parameter which
contains
error reason, it is better to return the error message to the caller.
Here we use error_setg to return the error info to caller.
And at the same time, we turn functions like write_elf64_note() to void,
Because
Functions shouldn't return an error code and an Error object at the same time.
Turn all these functions that returning Error object to void.
We also judge if a function success or fail by reference to the local_err.
Signed-off-by: zhanghailiang
---
dump.c | 313 ++
Il 30/09/2014 10:57, Jens Freimann ha scritto:
> Sync headers with 3.17-rc7
>
> Signed-off-by: Jens Freimann
> ---
Acked-by: Paolo Bonzini
> linux-headers/asm-mips/kvm_para.h | 6 +-
> linux-headers/asm-powerpc/kvm.h | 2 ++
> linux-headers/asm-x86/kvm.h | 3 +++
> linux-header
The code calls dump_error() on error, and even passes it a suitable
message. However, the message is thrown away, and its callers pass
up only success/failure. All qmp_dump_guest_memory() can do is set
a generic error.
Propagate the errors properly, so qmp_dump_guest_memory() can return
a more u
On Tue, Sep 30, 2014 at 08:23:05AM +, Gonglei (Arei) wrote:
> > Subject: Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error
> > message
> >
> > Il 30/09/2014 10:12, Markus Armbruster ha scritto:
> > > error_report() is just fine here. qerror_report() is never necessary in
> > > H
Il 30/09/2014 11:12, Zhi Yong Wu ha scritto:
> diff --git a/Makefile b/Makefile
> index b33aaac..7cbf7dd 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -149,6 +149,8 @@ ifneq ($(wildcard config-host.mak),)
> include $(SRC_PATH)/tests/Makefile
> endif
> ifeq ($(CONFIG_SMARTCARD_NSS),y)
> +CFLAGS +
> Subject: Re: [PATCH v2 12/12] virtio: add a wrapper for virtio-backend
> initialization
>
> Il 30/09/2014 11:04, Cornelia Huck ha scritto:
> > On Tue, 30 Sep 2014 14:10:38 +0800
> > wrote:
> >
> >> From: Gonglei
> >>
> >> For better code sharing, add a wrapper help funciton
> >
> > typo: s/fun
From: Gonglei
When scsi_bus_legacy_add_drive() produces an error,
we will lose the error message. Using error_report
to report it.
Cc: Markus Armbruster
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
Reviewed-by: Eric Blake
Acked-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirk
This reverts commit 4d43d3f3c8147ade184df9a1e9e82826edd39e19.
Reported to break PPC guests.
Signed-off-by: Michael S. Tsirkin
---
hw/virtio/virtio-pci.c | 39 +++
1 file changed, 19 insertions(+), 20 deletions(-)
diff --git a/hw/virtio/virtio-pci.c b/hw/virt
The following changes since commit ed9114356b587b362f5ed10e75366a4f07ed32af:
raw-posix: Fix build without posix_fallocate() (2014-09-29 16:28:24 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
for you to fetch changes up to
From: zhanghailiang
If we configure mlock=on and memory policy=bind at the same time,
It will consume lots of time for system to treat with memory,
especially when call mbind behind mlockall.
Adjust the place of calling mlockall, calling mbind before mlockall
can remarkably reduce the time of VM
From: Markus Armbruster
Once upon a time, it was decided that qemu_realloc(ptr, 0) should
abort. Switching to glib retired that bright idea. A bit of code
that was added to cope with it (commit 3e372cf) is still around. Bury
it.
See also commit 6528499.
Signed-off-by: Markus Armbruster
Revi
After inputting device_del command in monitor, we expect to list all
hotpluggable devices automatically by pressing tab key. This patchset provides
the function to list all peripheral devices such as memory devices.
v2:
- use object_child_foreach() to simplify the implementation (Andreas)
Zhu Gui
Add peripheral_device_del_completion() to let peripheral device del completion
be possible.
Signed-off-by: Zhu Guihua
---
monitor.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/monitor.c b/monitor.c
index 667efb7..55f4466 100644
--- a/monitor.c
+++ b/monitor.c
@@
For peripheral device del completion, add a function to build a list for
devices.
Signed-off-by: Zhu Guihua
---
hw/core/qdev.c | 13 +
include/hw/qdev-core.h | 2 ++
2 files changed, 15 insertions(+)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index fcb1638..041ac38 100644
On Tue, Sep 30, 2014 at 04:36:00PM +0800, Zhangjie (HZ) wrote:
> Hi,
> There exits packets loss when we do packet forwarding in VM,
> especially when we use dpdk to do the forwarding. By enlarging vring
> can alleviate the problem.
I think this has to do with the fact that dpdk disables
checksum o
> Subject: Re: [PATCH v2 12/12] virtio: add a wrapper for virtio-backend
> initialization
>
> Il 30/09/2014 11:04, Cornelia Huck ha scritto:
> >> > For better code sharing, add a wrapper help funciton
> > typo: s/funciton/function/
> >
> >> > for various virtio devices.
> > s/for various virtio de
From: Gonglei
virtio-$device-{pci, s390, ccw} all duplicate the
qdev properties of their virtio child. This approach does
not work well with string or pointer properties since we
must be careful about leaking or double-freeing them.
Use the QOM alias property to forward property accesses to the
From: Gonglei
virtio-net-pci, virtio-net-s390, and virtio-net-ccw all duplicate the
qdev properties of their VirtIONet child. This approach does not work
well with string or pointer properties since we must be careful about
leaking or double-freeing them.
Use the QOM alias property to forward pr
From: Gonglei
object_initialize() leaves the object with a refcount of 1.
object_property_add_child() adds its own reference which is dropped
again when the property is deleted.
The upshot of this is that we always have a refcount >= 1. Upon hot
unplug the virtio-scsi/vhost-scsi child is not fi
From: Gonglei
virtio-serial-{pci, s390, ccw} all duplicate the
qdev properties of their VirtIOSerial child.
This approach does not work well with string or pointer
properties since we must be careful about leaking or
double-freeing them.
Use the QOM alias property to forward property accesses to
From: Gonglei
object_initialize() leaves the object with a refcount of 1.
object_property_add_child() adds its own reference which is
dropped again when the property is deleted.
The upshot of this is that we always have a refcount >= 1. Upon
unplug the virtio-9p child is not finalized!
Drop our
From: Gonglei
virtio-rng-{pci, s390, ccw} all duplicate the
qdev properties of their VirtIORNG child.
This approach does not work well with string or pointer
properties since we must be careful about leaking or
double-freeing them.
Use the QOM alias property to forward property accesses to the
V
From: Gonglei
object_initialize() leaves the object with a refcount of 1.
object_property_add_child() adds its own reference which is dropped
again when the property is deleted.
The upshot of this is that we always have a refcount >= 1. Upon hot
unplug the virtio-net child is not finalized!
Dr
From: Gonglei
{virtio, vhost}-scsi-{pci, s390, ccw} all duplicate the
qdev properties of their VirtIOSCSI/VHostSCSI child.
This approach does not work well with string or pointer
properties since we must be careful about leaking or
double-freeing them.
Use the QOM alias property to forward prope
What I could see the snapshot offset points somewhere in apache log file.
Related to the discovered bash vulnerability I was rebooting VM last week as
well as prior to release upgrade (all VM's were shut down during the upgrade,
though if I remember it well after the upgrade process and prior to
From: Gonglei
object_initialize() leaves the object with a refcount of 1.
object_property_add_child() adds its own reference which is dropped
again when the property is deleted.
The upshot of this is that we always have a refcount >= 1. Upon hot
unplug the virtio-balloon child is not finalized!
From: Gonglei
object_initialize() leaves the object with a refcount of 1.
object_property_add_child() adds its own reference which is dropped
again when the property is deleted.
The upshot of this is that we always have a refcount >= 1. Upon hot
unplug the virtio-rng child is not finalized!
Dr
From: Gonglei
virtio-9p-pci all duplicate the qdev properties of their
V9fsState child. This approach does not work well with
string or pointer properties since we must be careful
about leaking or double-freeing them.
Use the QOM alias property to forward property accesses to the
V9fsState child
From: Gonglei
object_initialize() leaves the object with a refcount of 1.
object_property_add_child() adds its own reference which is dropped
again when the property is deleted.
The upshot of this is that we always have a refcount >= 1. Upon hot
unplug the virtio-serial child is not finalized!
Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben:
> Much more command code needs conversion. I'm converting these now
> because they's using bdrv_dev_* functions, which I'm about to lift
> into BlockBackend.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Kevin Wolf
From: Gonglei
For better code sharing, add a helper function that handles
reference counting of the virtio backend for virtio proxy devices.
Cc: Cornelia Huck
Cc: Michael S. Tsirkin
Signed-off-by: Gonglei
---
hw/s390x/s390-virtio-bus.c | 42 +--
hw/s390x/v
On Mon, Sep 29, 2014 at 04:07:55PM +0200, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> blockdev.c | 4 +---
> qemu-img.c | 4 +---
> qemu-nbd.c | 4 +---
> 3 files changed, 3 insertions(+), 9 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/c
On 29 September 2014 11:20, Gerd Hoffmann wrote:
> Hi,
>
> Short spice patch queue, adding a new graphic_console_set_hwops function
> to the console core, which in turn allows to simplify switching between
> vga and native mode in qxl.
>
> please pull,
> Gerd
>
> The following changes since co
On Mon, 29 Sep 2014 22:21:45 -0300
Eduardo Habkost wrote:
> QEMU currently allows the number of VCPUs to not be a multiple of the
> number of threads per socket, but the smbios socket count calculation
> introduced by commit c97294ec1b9e36887e119589d456557d72ab37b5 doesn't
> take that into accoun
From: Gonglei
In QEMU, ARI Forwarding is enabled default at emulation of PCIe
ports. ARI Forwarding enable setting at firmware/OS Control handoff.
If the bit is Set when a non-ARI Device is present, the non-ARI
Device can respond to Configuration Space accesses under what it
interprets as being d
From: Gonglei
The below functions is not allocation functions, but
find helper function. The only allocation function is
pcie_add_capability(), but its argument names is not the
same with the comments. So remove this comments which
make people confused.
Signed-off-by: Gonglei
---
hw/pci/pcie.c
Il 30/09/2014 09:09, Peter Lieven ha scritto:
> this adds a new helper to handle errors when allocation a bitmap and
> also introduces its first user.
>
> v1->v2: - derive bitmap_new from bitmap_try_new (Eric)
> - fail if allocation fails in iscsi_open (Paolo)
Thanks, applied to scsi-next
From: Gonglei
We may use it check type of qbus's parent.
Signed-off-by: Gonglei
---
hw/core/qdev.c | 9 +
include/hw/qdev-core.h | 1 +
2 files changed, 10 insertions(+)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index fcb1638..c85bf99 100644
--- a/hw/core/qdev.c
+++ b/hw/co
From: Gonglei
Changes since v3:
- fix some typos in comments and commit message. (Michael)
- rename pcie_cap_ari_check to pcie_cap_slot_check.
Changes since v2:
- make patch 1/3 more simpler and safer.(Hu Tao)
- change check logic from pci.c to pcie.c and change function's name
- judge devi
On Mon, 29 Sep 2014, Don Slutz wrote:
> On 09/29/14 06:25, Stefano Stabellini wrote:
> > On Mon, 29 Sep 2014, Stefano Stabellini wrote:
> > > On Fri, 26 Sep 2014, Don Slutz wrote:
> > > > This adds synchronisation of the vcpu registers
> > > > between Xen and QEMU.
> > > >
> > > > Signed-off-by: D
Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben:
> The pointer from BlockBackend to BlockDriverState is a strong
> reference, managed with bdrv_ref() / bdrv_unref(), the back-pointer is
> a weak one.
>
> Convenience function blk_new_with_bs() creates a BlockBackend with its
> BlockDriverS
On Tue, Sep 30, 2014 at 05:49:32PM +0800, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> virtio-$device-{pci, s390, ccw} all duplicate the
> qdev properties of their virtio child. This approach does
> not work well with string or pointer properties since we
> must be careful about leaking or
Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben:
> Move device model attachment / detachment and the BlockDevOps device
> model callbacks and their wrappers from BlockDriverState to
> BlockBackend.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Kevin Wolf
Cornelia Huck writes:
> On Tue, 30 Sep 2014 14:10:38 +0800
> wrote:
>
>> From: Gonglei
>>
>> For better code sharing, add a wrapper help funciton
>
> typo: s/funciton/function/
>
>> for various virtio devices.
>
> s/for various virtio devices/that handles referencing the virtio
> backend for v
On 29 September 2014 19:26, Peter Maydell wrote:
> ARM pullreq: nothing fantastically exciting, but getting the
> EL2/EL3 patchset in ought to help with ongoing TZ work.
>
> -- PMM
>
>
> The following changes since commit 70556264a89a268efba1d7e8e341adcdd7881eb4:
>
> libqos: use microseconds ins
Kevin Wolf writes:
> Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben:
>> The pointer from BlockBackend to BlockDriverState is a strong
>> reference, managed with bdrv_ref() / bdrv_unref(), the back-pointer is
>> a weak one.
>>
>> Convenience function blk_new_with_bs() creates a BlockBac
1 - 100 of 306 matches
Mail list logo
