John Snow <js...@redhat.com> writes:

> The Q35 board initialization does not currently bother to look
> for any drives added by the various syntactical sugar shorthands
> to be added to the AHCI HBA. These include -hda through -hdd,
> -cdrom, and -drive if=ide shorthands.
>
> An obstacle to having implemented this sooner is debate over
> whether or not to add an additional interface type, and how to
> manage the different units-per-bus mappings of various HBA
> implementations.
>
> This patch series:
> (1) Does not add IF_AHCI, but reuses IF_IDE
> (2) Allows the if_max_devs table to be overridden
> (3) Adds this override to the Q35 board type.
> (4) Finally, adds implementation to Q35 initialization.

General: commit messages' line lengths on the short side (~50 rather
than the customary ~70), but that's better than too long.

I think PATCH 4 could be improved further, but the only issue serious
enough to make me withhold my R-by is the unexplained change from fatal
error to warning there.

Almost there :)

Reply via email to