[Qemu-devel] [PATCH 1/2] vmstate: Allow dynamic allocation for VBUFFER during migration

2014-09-25 Thread Alexey Kardashevskiy
This extends use of VMS_ALLOC flag from arrays to VBUFFER as well. This defines VMSTATE_VBUFFER_ALLOC_UINT32 which makes use of VMS_ALLOC and uses uint32_t type for a size. Signed-off-by: Alexey Kardashevskiy --- include/migration/vmstate.h | 11 +++ vmstate.c | 13 +++

[Qemu-devel] [PATCH 2/2] spapr_nvram: Enable migration

2014-09-25 Thread Alexey Kardashevskiy
The only case when sPAPR NVRAM migrates now is if is backed by a file and copy-storage migration is performed. This enables RAM copy of NVRAM even if NVRAM is backed by a file. This defines a VMSTATE descriptor for NVRAM device so the memory copy of NVRAM can migrate and be written to a backing f

[Qemu-devel] [PATCH 0/2] spapr_nvram: Support migration

2014-09-25 Thread Alexey Kardashevskiy
Here are 2 patches to enable sPAPR NVRAM migration. Please comment. Thanks! Alexey Kardashevskiy (2): vmstate: Allow dynamic allocation for VBUFFER during migration spapr_nvram: Enable migration hw/nvram/spapr_nvram.c | 68 +++-- include/migrati

[Qemu-devel] how can i load qemu-system-arm symbol using gdb?

2014-09-25 Thread MK Kim
hello all, I have one question. i built qemu-system-arm and i want to debug using gdb inside qemu. but i don't know how can i load qemu symbol which address in 64bit. for example, $>gdb --args qemu-system-arm xxx in gdb, (gdb) add-symbol-file qemu-system-arm (?) the additional information is

Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

2014-09-25 Thread Kevin Wolf
Am 25.09.2014 um 08:21 hat Markus Armbruster geschrieben: > Please copy Kevin & Stefan for block patches. Doing that for you. I > also copy Max, who left his fingerprints on commit 4f11aa8. > > Tony Breeds writes: > > > The command > > qemu-img convert -O raw inputimage.qcow2 outputimage.raw

Re: [Qemu-devel] [PATCH v2 0/2] block: Catch simultaneous usage of options and their aliases

2014-09-25 Thread Kevin Wolf
Am 24.09.2014 um 16:46 hat Kevin Wolf geschrieben: > v2: > - Remove QAPI-style use of errp, convert to table to keep things > readable anyway [Markus] > > Kevin Wolf (2): > block: Specify -drive legacy option aliases in array > block: Catch simultaneous usage of options and their aliases Ap

Re: [Qemu-devel] [PATCH v4 12/19] qapi: Add some type check tests

2014-09-25 Thread Markus Armbruster
Eric Blake writes: > Demonstrate that the qapi generator silently parses confusing > types, which may cause other errors later on. Later patches > will update the expected results as the generator is made stricter. > > Signed-off-by: Eric Blake > --- > tests/Makefile

Re: [Qemu-devel] [PATCH v3] docs: add blkdebug block driver documentation

2014-09-25 Thread Kevin Wolf
Am 24.09.2014 um 11:44 hat Stefan Hajnoczi geschrieben: > The blkdebug block driver is undocumented. Documenting it is worthwhile > since it offers powerful error injection features that are used by > qemu-iotests test cases. > > This document will make it easier for people to learn about and use

Re: [Qemu-devel] [PATCH] vpc: fix beX_to_cpu() and cpu_to_beX() confusion

2014-09-25 Thread Kevin Wolf
Am 23.09.2014 um 11:40 hat Stefan Hajnoczi geschrieben: > The beX_to_cpu() and cpu_to_beX() functions perform the same operation - > they do a byteswap if the host CPU endianness is little-endian or a > nothing otherwise. > > The point of two names for the same operation is that it documents which

Re: [Qemu-devel] [PATCH 28/30] usb: convert to hotplug handler API

2014-09-25 Thread Gerd Hoffmann
On Mi, 2014-09-24 at 17:39 +0200, Igor Mammedov wrote: > On Wed, 24 Sep 2014 15:23:41 +0200 > Gerd Hoffmann wrote: > > > Hi, > > > > > > Can't we do this in usb_bus_new instead of duplicating in every host > > > > adapter? > > > > > > So you would make TYPE_USB_BUS the hotplug handler itself,

Re: [Qemu-devel] [PATCH 26/30] usb-storage: make its storage SCSI bus hotpluggable explicitly

2014-09-25 Thread Gerd Hoffmann
On Mi, 2014-09-24 at 17:22 +0200, Igor Mammedov wrote: > On Wed, 24 Sep 2014 14:50:41 +0200 > Gerd Hoffmann wrote: > > > On Mi, 2014-09-24 at 11:48 +, Igor Mammedov wrote: > > > usb-storage uses SCSI bus to provide underling storage > > > (i.e. scsi-disk) and it's hotpluggable. > > > > No.

[Qemu-devel] [PATCH v2] block: Validate node-name

2014-09-25 Thread Kevin Wolf
The device_name of a BlockDriverState is currently checked because it is always used as a QemuOpts ID and qemu_opts_create() checks whether such IDs are wellformed. node-name is supposed to share the same namespace, but it isn't checked currently. This patch adds explicit checks both for device_na

Re: [Qemu-devel] [PATCH 25/30] usb-bot: drop not needed "allow_hotplug = 0"

2014-09-25 Thread Gerd Hoffmann
Hi, > But there is room for improvement here, > it it's possible to error out even earlier if usb-bot would be marked > as not hotpluggable device and add to qdev_device_add() check if > device is hotpluggable even before it's created. usb-bot not being hot-pluggable is a consequence of the fac

Re: [Qemu-devel] [PATCH 25/30] usb-bot: drop not needed "allow_hotplug = 0"

2014-09-25 Thread Gerd Hoffmann
On Mi, 2014-09-24 at 17:21 +0200, Paolo Bonzini wrote: > Il 24/09/2014 17:15, Igor Mammedov ha scritto: > > But there is room for improvement here, > > it it's possible to error out even earlier if usb-bot would be marked > > as not hotpluggable device and add to qdev_device_add() check if > > devi

Re: [Qemu-devel] [PATCH v4] Add machine parameter qemu-kvm-migration for live migrate compatibility with qemu-kvm

2014-09-25 Thread Dr. David Alan Gilbert
* Michael Tokarev (m...@tls.msk.ru) wrote: > 22.09.2014 23:34, Alex Bligh wrote: > > This patch series adds inbound migrate capability from qemu-kvm version > > 1.0. [...] > > Isn't it quite a bit too late already? That's an old version by > now, and supporting migration from it is interesting fo

Re: [Qemu-devel] [PULL 09/11] tcg-aarch64: Use 32-bit loads for qemu_ld_i32

2014-09-25 Thread Claudio Fontana
On 24.09.2014 17:19, Richard Henderson wrote: > On 09/24/2014 01:20 AM, Claudio Fontana wrote: >>> @@ -1118,7 +1119,8 @@ static void tcg_out_qemu_ld_direct(TCGContext *s, >>> TCGMemOp memop, >>> tcg_out_ldst_r(s, I3312_LDRB, data_r, addr_r, off_r); >>> break; >>> case MO_SB:

Re: [Qemu-devel] [PATCH 09/30] access BusState.allow_hotplug using wraper qbus_is_hotpluggable()

2014-09-25 Thread Igor Mammedov
On Thu, 25 Sep 2014 10:00:05 +0800 Tang Chen wrote: > > On 09/24/2014 07:47 PM, Igor Mammedov wrote: > > it would allow transparently switch detection if Bus > > is hotpluggable from allow_hotplug field to hotplug_handler > > link and drop allow_hotplug field once all users are > > converted to

Re: [Qemu-devel] [PATCH v4 12/19] qapi: Add some type check tests

2014-09-25 Thread Markus Armbruster
Markus Armbruster writes: > Eric Blake writes: > >> Demonstrate that the qapi generator silently parses confusing >> types, which may cause other errors later on. Later patches >> will update the expected results as the generator is made stricter. [...] >> diff --git a/tests/qapi-schema/returns-

Re: [Qemu-devel] [PATCH 11/30] qdev: HotplugHandler: provide unplug callback

2014-09-25 Thread Igor Mammedov
On Thu, 25 Sep 2014 09:53:20 +0800 Tang Chen wrote: > > On 09/24/2014 07:48 PM, Igor Mammedov wrote: > > it to be called for actual device removal and > > will allow to separate request and removal handling > > phases of x86-CPU devices and also it's a handler > > to be called for synchronously

Re: [Qemu-devel] [PATCH] ohci: Split long traces to smaller ones

2014-09-25 Thread Gerd Hoffmann
On Do, 2014-09-25 at 10:16 +1000, Alexey Kardashevskiy wrote: > Recent traces rework introduced 2 tracepoints with 13 and 20 > arguments. When dtrace backend is selected > (--enable-trace-backend=dtrace), compile fails as > sys/sdt.h defines DTRACE_PROBE up to DTRACE_PROBE12 only. > > This splits

Re: [Qemu-devel] [PATCH 25/30] usb-bot: drop not needed "allow_hotplug = 0"

2014-09-25 Thread Igor Mammedov
On Thu, 25 Sep 2014 10:01:53 +0200 Gerd Hoffmann wrote: > On Mi, 2014-09-24 at 17:21 +0200, Paolo Bonzini wrote: > > Il 24/09/2014 17:15, Igor Mammedov ha scritto: > > > But there is room for improvement here, > > > it it's possible to error out even earlier if usb-bot would be marked > > > as no

Re: [Qemu-devel] [PATCH v2 7/7] virtio-scsi: Handle TMF request cancellation asynchronously

2014-09-25 Thread Paolo Bonzini
Il 25/09/2014 04:01, Fam Zheng ha scritto: >>> > > -static void virtio_scsi_do_tmf(VirtIOSCSI *s, VirtIOSCSIReq *req) >>> > > +typedef struct { >>> > > +VirtIOSCSIReq *tmf_req; >>> > > +intremaining; >>> > > +} VirtIOSCSICancelTracker; >> > >> > What about putting "remaining"

Re: [Qemu-devel] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-25 Thread Alexey Kardashevskiy
On 09/24/2014 07:48 PM, Kevin Wolf wrote: > Am 23.09.2014 um 10:47 hat Alexey Kardashevskiy geschrieben: >> On 09/19/2014 06:47 PM, Kevin Wolf wrote:> Am 16.09.2014 um 14:59 hat Paolo >> Bonzini geschrieben: Il 16/09/2014 14:52, Kevin Wolf ha scritto: > Yes, that's true. We can't fix this

Re: [Qemu-devel] [PATCH v6 3/3] ivshmem: add check on protocol version in QEMU

2014-09-25 Thread David Marchand
On 09/23/2014 05:58 PM, Stefan Hajnoczi wrote: I'm not sure a full-fledged feature negotiation system is needed. The ivshmem protocol is local to the host and all participants are under control of the administrator. I suggested a protocol version to protect against misconfiguration. For exampl

Re: [Qemu-devel] [PATCH v3 5/7] scsi: Introduce scsi_req_cancel_complete

2014-09-25 Thread Paolo Bonzini
Il 25/09/2014 04:20, Fam Zheng ha scritto: > Let the aio cb do the clean up and notification job after scsi_req_cancel, in > preparation for asynchronous cancellation. > > Signed-off-by: Fam Zheng > --- > hw/scsi/scsi-bus.c | 14 ++ > hw/scsi/scsi-disk.c| 8 > hw/sc

[Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info

2014-09-25 Thread Olaf Hering
During code review for xen I noticed that --enable-debug-info would still strip the binaries because strip_opt= defaults to yes. If --enable-debug-info is passed to configure it has to be assumed that not only the compiled binaries have debugsymbols, also the installed binaries should keep the symb

Re: [Qemu-devel] [PATCH v3 6/7] scsi: Introduce scsi_req_cancel_async

2014-09-25 Thread Paolo Bonzini
Il 25/09/2014 04:20, Fam Zheng ha scritto: > Devices will call this function to start an asynchronous cancellation. The > bus->info->cancel will be called after the request is canceled. > > Devices will probably need to track a separate TMF request that triggers this > cancellation, and wait until

Re: [Qemu-devel] [PATCH] qemu-socket: Eliminate silly QERR_ macros

2014-09-25 Thread Paolo Bonzini
Il 25/09/2014 08:49, Markus Armbruster ha scritto: > The QERR_ macros are leftovers from the days of "rich" error objects. > They're used with error_set() and qerror_report(), and expand into the > first *two* arguments. This trickiness has become pointless. Clean > up. > > Signed-off-by: Markus

Re: [Qemu-devel] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-25 Thread Kevin Wolf
Am 25.09.2014 um 10:41 hat Alexey Kardashevskiy geschrieben: > On 09/24/2014 07:48 PM, Kevin Wolf wrote: > > Am 23.09.2014 um 10:47 hat Alexey Kardashevskiy geschrieben: > >> On 09/19/2014 06:47 PM, Kevin Wolf wrote:> Am 16.09.2014 um 14:59 hat > >> Paolo Bonzini geschrieben: > Il 16/09/2014

Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

2014-09-25 Thread Tony Breeds
On Thu, Sep 25, 2014 at 09:30:30AM +0200, Kevin Wolf wrote: > Does this fix the problem or does it just make it less likely that it > becomes apparent? Sorry for not making this clearer in my commit message. I haven't been able to reproduce the corruption with the fiemap flag change. > If ther

Re: [Qemu-devel] [PATCH] ohci: Split long traces to smaller ones

2014-09-25 Thread Alex Bennée
Alexey Kardashevskiy writes: > Recent traces rework introduced 2 tracepoints with 13 and 20 > arguments. When dtrace backend is selected > (--enable-trace-backend=dtrace), compile fails as > sys/sdt.h defines DTRACE_PROBE up to DTRACE_PROBE12 only. FWIW lltng ust limits TP_ARGS to 10 fields. >

[Qemu-devel] [PATCH] ohci: drop computed flags from trace events

2014-09-25 Thread Alex Bennée
This exceeded the trace argument limit for LTTNG UST and wasn't really needed as the flags value is stored anyway. Dropping this fixes the compile failure for UST. It can probably be merged with the previous trace shortening patch. Signed-off-by: Alex Bennée --- hw/usb/hcd-ohci.c | 3 +-- trace-

[Qemu-devel] [PATCH] scripts/tracetool: don't barf on formats with precision

2014-09-25 Thread Alex Bennée
This only affects lttng user space tracing at the moment. Signed-off-by: Alex Bennée --- scripts/tracetool/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py index 36c789d..5aa2eed 100644 --- a/scripts/tra

Re: [Qemu-devel] [PATCH 2/2] spapr_nvram: Enable migration

2014-09-25 Thread Alexander Graf
On 25.09.14 09:02, Alexey Kardashevskiy wrote: > The only case when sPAPR NVRAM migrates now is if is backed by a file and > copy-storage migration is performed. > > This enables RAM copy of NVRAM even if NVRAM is backed by a file. > > This defines a VMSTATE descriptor for NVRAM device so the m

Re: [Qemu-devel] [PATCH] ohci: Split long traces to smaller ones

2014-09-25 Thread Alexey Kardashevskiy
On 09/25/2014 06:09 PM, Gerd Hoffmann wrote: > On Do, 2014-09-25 at 10:16 +1000, Alexey Kardashevskiy wrote: >> Recent traces rework introduced 2 tracepoints with 13 and 20 >> arguments. When dtrace backend is selected >> (--enable-trace-backend=dtrace), compile fails as >> sys/sdt.h defines DTRACE

[Qemu-devel] [PATCH 4/4] oslib-posix/win32: convert fprintf/perror to error_report

2014-09-25 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- util/oslib-posix.c | 8 util/oslib-win32.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/util/oslib-posix.c b/util/oslib-posix.c index 016a047..00310f6 100644 --- a/util/oslib-posix.c +++ b/util/oslib-posix.c @@ -88,7 +8

[Qemu-devel] [PATCH 0/4] os: convert fprintf/perror to error_report

2014-09-25 Thread arei.gonglei
From: Gonglei Those are trivial patches. Please consider applying to trivial-next. Thanks! Gonglei (4): os-posix/win32: convert fprintf/perror to error_report os-posix: report error message when lock file failed osdep: convert fprintf to error_report oslib-posix/win32: convert fprintf/pe

[Qemu-devel] [PATCH 1/4] os-posix/win32: convert fprintf/perror to error_report

2014-09-25 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- os-posix.c | 34 ++ os-win32.c | 3 ++- 2 files changed, 20 insertions(+), 17 deletions(-) diff --git a/os-posix.c b/os-posix.c index cb2a7f7..9d5ae70 100644 --- a/os-posix.c +++ b/os-posix.c @@ -39,6 +39,7 @@ #include

[Qemu-devel] [PATCH 3/4] osdep: convert fprintf to error_report

2014-09-25 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- util/osdep.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/util/osdep.c b/util/osdep.c index b2bd154..7f6e483 100644 --- a/util/osdep.c +++ b/util/osdep.c @@ -401,9 +401,9 @@ void fips_set_state(bool requested) #endif /* __

[Qemu-devel] [PATCH 2/4] os-posix: report error message when lock file failed

2014-09-25 Thread arei.gonglei
From: Gonglei It will cause that create vm failed When manager tool is killed forcibly (kill -9 libvirtd_pid), the file not was unlink, and unlock. It's better that report the error message for users. Signed-off-by: Huangweidong Signed-off-by: Gonglei --- os-posix.c | 1 + 1 file changed, 1 i

Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

2014-09-25 Thread Kevin Wolf
Am 25.09.2014 um 11:00 hat Tony Breeds geschrieben: > On Thu, Sep 25, 2014 at 09:30:30AM +0200, Kevin Wolf wrote: > > > Does this fix the problem or does it just make it less likely that it > > becomes apparent? > > Sorry for not making this clearer in my commit message. > > I haven't been able

Re: [Qemu-devel] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-25 Thread Alexey Kardashevskiy
On 09/25/2014 06:57 PM, Kevin Wolf wrote: > Am 25.09.2014 um 10:41 hat Alexey Kardashevskiy geschrieben: >> On 09/24/2014 07:48 PM, Kevin Wolf wrote: >>> Am 23.09.2014 um 10:47 hat Alexey Kardashevskiy geschrieben: On 09/19/2014 06:47 PM, Kevin Wolf wrote:> Am 16.09.2014 um 14:59 hat Pao

Re: [Qemu-devel] [PATCH 2/2] spapr_nvram: Enable migration

2014-09-25 Thread Alexey Kardashevskiy
On 09/25/2014 07:43 PM, Alexander Graf wrote: > > > On 25.09.14 09:02, Alexey Kardashevskiy wrote: >> The only case when sPAPR NVRAM migrates now is if is backed by a file and >> copy-storage migration is performed. >> >> This enables RAM copy of NVRAM even if NVRAM is backed by a file. >> >> Thi

Re: [Qemu-devel] [PATCH] qemu-iotests: Fail test if explict test case number is unknown

2014-09-25 Thread Stefan Hajnoczi
On Thu, Sep 25, 2014 at 09:46:24AM +0800, Fam Zheng wrote: > On Wed, 09/24 10:05, Stefan Hajnoczi wrote: > > On Tue, Sep 23, 2014 at 10:26:26AM +0800, Fam Zheng wrote: > > > diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common > > > index 70df659..2403a20 100644 > > > --- a/tests/qemu

Re: [Qemu-devel] [PATCH v2] qemu-iotests: Fail test if explicit test case number is unknown

2014-09-25 Thread Stefan Hajnoczi
On Wed, Sep 24, 2014 at 11:05:57AM +0800, Fam Zheng wrote: > When we expand a number range, we just print "$id - unknown test, > ignored", this is convenient if we want to run a range of tests. > > When we designate a test case number explicitly, we shouldn't just > ignore it if the case script do

Re: [Qemu-devel] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-25 Thread Kevin Wolf
Am 25.09.2014 um 11:55 hat Alexey Kardashevskiy geschrieben: > Right. Cool. So is below what was suggested? I am doublechecking as it does > not solve the original issue - the bottomhalf is called first and then > nbd_trip() crashes in qcow2_co_flush_to_os(). > > diff --git a/block.c b/block.c > i

Re: [Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info

2014-09-25 Thread Peter Maydell
On 25 September 2014 09:06, Olaf Hering wrote: > During code review for xen I noticed that --enable-debug-info would > still strip the binaries because strip_opt= defaults to yes. > If --enable-debug-info is passed to configure it has to be assumed > that not only the compiled binaries have debugs

Re: [Qemu-devel] [PATCH v2] block: Validate node-name

2014-09-25 Thread Stefan Hajnoczi
On Thu, Sep 25, 2014 at 09:54:02AM +0200, Kevin Wolf wrote: > The device_name of a BlockDriverState is currently checked because it is > always used as a QemuOpts ID and qemu_opts_create() checks whether such > IDs are wellformed. > > node-name is supposed to share the same namespace, but it isn't

Re: [Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info

2014-09-25 Thread Olaf Hering
On Thu, Sep 25, Peter Maydell wrote: > On 25 September 2014 09:06, Olaf Hering wrote: > > During code review for xen I noticed that --enable-debug-info would > > still strip the binaries because strip_opt= defaults to yes. > > If --enable-debug-info is passed to configure it has to be assumed > >

Re: [Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info

2014-09-25 Thread Stefan Hajnoczi
On Thu, Sep 25, 2014 at 10:06:35AM +0200, Olaf Hering wrote: > During code review for xen I noticed that --enable-debug-info would > still strip the binaries because strip_opt= defaults to yes. > If --enable-debug-info is passed to configure it has to be assumed > that not only the compiled binarie

Re: [Qemu-devel] [PATCH 28/30] usb: convert to hotplug handler API

2014-09-25 Thread Igor Mammedov
On Thu, 25 Sep 2014 09:50:58 +0200 Gerd Hoffmann wrote: > On Mi, 2014-09-24 at 17:39 +0200, Igor Mammedov wrote: > > On Wed, 24 Sep 2014 15:23:41 +0200 > > Gerd Hoffmann wrote: > > > > > Hi, > > > > > > > > Can't we do this in usb_bus_new instead of duplicating in every host > > > > > adapte

Re: [Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info

2014-09-25 Thread Olaf Hering
On Thu, Sep 25, Stefan Hajnoczi wrote: > If you make this change and packagers are unaware, they could > accidentally ship qemu packages that contain the full debug symbols in > the binaries. rpm will take care of that all by itself. Olaf

Re: [Qemu-devel] [PATCH] ohci: drop computed flags from trace events

2014-09-25 Thread Stefan Hajnoczi
On Thu, Sep 25, 2014 at 10:38:44AM +0100, Alex Bennée wrote: > This exceeded the trace argument limit for LTTNG UST and wasn't really > needed as the flags value is stored anyway. Dropping this fixes the > compile failure for UST. It can probably be merged with the previous > trace shortening patch

Re: [Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info

2014-09-25 Thread Peter Maydell
On 25 September 2014 11:47, Olaf Hering wrote: > On Thu, Sep 25, Peter Maydell wrote: > So will --disable-strip remain for ever? Can I depend on that? We're not planning to remove it, certainly. We don't make strong guarantees about configure commandlines remaining stable across QEMU versions but

Re: [Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info

2014-09-25 Thread Michael Tokarev
25.09.2014 14:49, Stefan Hajnoczi wrote: [] > Perhaps package maintainers rely on installed binaries not having debug > symbols? Package maintainer can and _should_ watch for changes in new releases and update their packages to accomodate changes made upstream. > It's common to split the debug sy

Re: [Qemu-devel] [PATCH 20/30] s390x: convert virtio-ccw to hotplug handler API

2014-09-25 Thread Cornelia Huck
On Wed, 24 Sep 2014 11:48:09 + Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > hw/s390x/virtio-ccw.c | 24 > 1 file changed, 16 insertions(+), 8 deletions(-) Well, I think I now see what's going on here. More below... > @@ -1620,13 +1620,13 @@ static

Re: [Qemu-devel] [PATCH v3 07/23] block: Eliminate bdrv_iterate(), use bdrv_next()

2014-09-25 Thread Kevin Wolf
Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben: > Signed-off-by: Markus Armbruster > Reviewed-by: Benoît Canet Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v3 08/23] block: Eliminate BlockDriverState member device_name[]

2014-09-25 Thread Kevin Wolf
Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben: > device_name[] can become non-empty only in bdrv_new_root() and > bdrv_move_feature_fields(). The latter is used only to undo damage > done by bdrv_swap(). The former is called only by blk_new_with_bs(). > Therefore, when a BlockDriverSta

Re: [Qemu-devel] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-25 Thread Alexey Kardashevskiy
On 09/25/2014 08:20 PM, Kevin Wolf wrote: > Am 25.09.2014 um 11:55 hat Alexey Kardashevskiy geschrieben: >> Right. Cool. So is below what was suggested? I am doublechecking as it does >> not solve the original issue - the bottomhalf is called first and then >> nbd_trip() crashes in qcow2_co_flush_t

Re: [Qemu-devel] [PATCH 1/4] os-posix/win32: convert fprintf/perror to error_report

2014-09-25 Thread Eric Blake
On 09/25/2014 03:46 AM, arei.gong...@huawei.com wrote: > From: Gonglei > > Signed-off-by: Gonglei > --- > os-posix.c | 34 ++ > os-win32.c | 3 ++- > 2 files changed, 20 insertions(+), 17 deletions(-) > > diff --git a/os-posix.c b/os-posix.c > index cb2a7f7..9d

Re: [Qemu-devel] [PATCH 3/4] osdep: convert fprintf to error_report

2014-09-25 Thread Eric Blake
On 09/25/2014 03:46 AM, arei.gong...@huawei.com wrote: > From: Gonglei > > Signed-off-by: Gonglei > --- > util/osdep.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/util/osdep.c b/util/osdep.c > index b2bd154..7f6e483 100644 > --- a/util/osdep.c > +++ b/util/

Re: [Qemu-devel] [PATCH 4/4] oslib-posix/win32: convert fprintf/perror to error_report

2014-09-25 Thread Eric Blake
On 09/25/2014 03:46 AM, arei.gong...@huawei.com wrote: > From: Gonglei > > Signed-off-by: Gonglei > --- > util/oslib-posix.c | 8 > util/oslib-win32.c | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) > > @@ -380,7 +380,7 @@ void os_mem_prealloc(int fd, char *area, size_t me

Re: [Qemu-devel] [PATCH] scripts/tracetool: don't barf on formats with precision

2014-09-25 Thread Stefan Hajnoczi
On Thu, Sep 25, 2014 at 10:40:14AM +0100, Alex Bennée wrote: > This only affects lttng user space tracing at the moment. > > Signed-off-by: Alex Bennée > --- > scripts/tracetool/__init__.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my tracing tree: https://githu

Re: [Qemu-devel] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-25 Thread Kevin Wolf
Am 25.09.2014 um 14:29 hat Alexey Kardashevskiy geschrieben: > On 09/25/2014 08:20 PM, Kevin Wolf wrote: > > Am 25.09.2014 um 11:55 hat Alexey Kardashevskiy geschrieben: > >> Right. Cool. So is below what was suggested? I am doublechecking as it does > >> not solve the original issue - the bottomha

Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

2014-09-25 Thread Eric Blake
On 09/24/2014 11:23 PM, Tony Breeds wrote: > The command > qemu-img convert -O raw inputimage.qcow2 outputimage.raw > > intermittently creates corrupted output images, when the input image is not yet fully synchronized to disk. This patch preferese the use of seek_hole checks to determine if th

Re: [Qemu-devel] [Patch v2 1/8] stm32f205_timer: Add the stm32f205 Timer

2014-09-25 Thread Alistair Francis
On Mon, Sep 22, 2014 at 9:40 PM, Peter Crosthwaite wrote: > On Fri, Sep 19, 2014 at 2:54 PM, Alistair Francis > wrote: >> This patch adds the stm32f205 timers: TIM2, TIM3, TIM4 and TIM5 >> to QEMU. >> >> Signed-off-by: Alistair Francis >> --- >> PUBLIC >> V2: >> - Reorder the Makefile config >

Re: [Qemu-devel] [PATCH 1/4] os-posix/win32: convert fprintf/perror to error_report

2014-09-25 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH 1/4] os-posix/win32: convert fprintf/perror > to > error_report > > On 09/25/2014 03:46 AM, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > Signed-off-by: Gonglei > > --- > > os-posix.c | 34 ++ > > os-win32.c | 3 ++-

[Qemu-devel] [PULL] Update OpenBIOS images

2014-09-25 Thread Mark Cave-Ayland
Hi Peter, The following commit updates the OpenBIOS images to SVN r1320 (with corresponding changes to the TCX FCode ROM in order to enable guests to use the hardware TCX acceleration if required). Please pull. ATB, Mark. The following changes since commit 4f2280b2190e39aa6761cc8188626ed9aad3

Re: [Qemu-devel] [PATCH 3/4] osdep: convert fprintf to error_report

2014-09-25 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH 3/4] osdep: convert fprintf to error_report > > On 09/25/2014 03:46 AM, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > Signed-off-by: Gonglei > > --- > > util/osdep.c | 8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --gi

Re: [Qemu-devel] [PATCH 4/4] oslib-posix/win32: convert fprintf/perror to error_report

2014-09-25 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH 4/4] oslib-posix/win32: convert > fprintf/perror > to error_report > > On 09/25/2014 03:46 AM, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > Signed-off-by: Gonglei > > --- > > util/oslib-posix.c | 8 > > util/oslib-win32.c | 2 +- > > 2 fi

Re: [Qemu-devel] [PATCH v3 09/23] block: Merge BlockBackend and BlockDriverState name spaces

2014-09-25 Thread Kevin Wolf
Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben: > BlockBackend's name space is separate only to keep the initial patches > simple. Time to merge the two. > > Signed-off-by: Markus Armbruster > Reviewed-by: Benoît Canet Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH 28/30] usb: convert to hotplug handler API

2014-09-25 Thread Paolo Bonzini
Il 25/09/2014 12:55, Igor Mammedov ha scritto: > hotplug-handler.[plug|unplug] callbacks are class wide, so if > USB bus might ever need to have different callbacks depending on > host it might not work. > > But since so far it uses the only qdev_simple_device_unplug_cb(), > having BUS as hotplug-

Re: [Qemu-devel] [PATCH v3 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-25 Thread Kevin Wolf
Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben: > The patch is big, but all it really does is replacing > > dinfo->bdrv > > by > > blk_bs(blk_by_legacy_dinfo(dinfo)) > > The replacement is repetitive, but the conversion of device models to > BlockBackend is imminent, and will

Re: [Qemu-devel] [PATCH 20/30] s390x: convert virtio-ccw to hotplug handler API

2014-09-25 Thread Igor Mammedov
On Thu, 25 Sep 2014 13:08:38 +0200 Cornelia Huck wrote: > On Wed, 24 Sep 2014 11:48:09 + > Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov > > --- > > hw/s390x/virtio-ccw.c | 24 > > 1 file changed, 16 insertions(+), 8 deletions(-) > > Well, I think I now

Re: [Qemu-devel] [PATCH v3 11/23] block: Rename BlockDriverAIOCB* to BlockAIOCB*

2014-09-25 Thread Kevin Wolf
Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben: > I'll use BlockDriverAIOCB with block backends shortly, and the name is > going to fit badly there. It's a block layer thing anyway, not just a > block driver thing. > > Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf

[Qemu-devel] [PATCH v4 2/7] sysbus: Make devices spawnable via -device

2014-09-25 Thread Alexander Graf
Now that we can properly map sysbus devices that haven't been connected to something forcefully by C code, we can allow the -device command line option to spawn them. For machines that don't implement dynamic sysbus assignment in their board files we add a new bool "has_dynamic_sysbus" to the mach

Re: [Qemu-devel] [PATCH v3 12/23] virtio-blk: Drop redundant VirtIOBlock member conf

2014-09-25 Thread Kevin Wolf
Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben: > Commit 12c5674 turned it into a pointer to member blk.conf. > > Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH 28/30] usb: convert to hotplug handler API

2014-09-25 Thread Igor Mammedov
On Thu, 25 Sep 2014 14:47:31 +0200 Paolo Bonzini wrote: > Il 25/09/2014 12:55, Igor Mammedov ha scritto: > > hotplug-handler.[plug|unplug] callbacks are class wide, so if > > USB bus might ever need to have different callbacks depending on > > host it might not work. > > > > But since so far it

Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

2014-09-25 Thread Eric Blake
On 09/25/2014 01:30 AM, Kevin Wolf wrote: > Am 25.09.2014 um 08:21 hat Markus Armbruster geschrieben: >> Please copy Kevin & Stefan for block patches. Doing that for you. I >> also copy Max, who left his fingerprints on commit 4f11aa8. >> >> Tony Breeds writes: >> >>> The command >>> qemu-img

Re: [Qemu-devel] [PATCH v2] qemu-iotests: Fail test if explicit test case number is unknown

2014-09-25 Thread Kevin Wolf
Am 24.09.2014 um 05:05 hat Fam Zheng geschrieben: > When we expand a number range, we just print "$id - unknown test, > ignored", this is convenient if we want to run a range of tests. > > When we designate a test case number explicitly, we shouldn't just > ignore it if the case script doesn't exi

Re: [Qemu-devel] [PATCH v2] block: Validate node-name

2014-09-25 Thread Kevin Wolf
Am 25.09.2014 um 09:54 hat Kevin Wolf geschrieben: > The device_name of a BlockDriverState is currently checked because it is > always used as a QemuOpts ID and qemu_opts_create() checks whether such > IDs are wellformed. > > node-name is supposed to share the same namespace, but it isn't checked

Re: [Qemu-devel] [PATCH] -machine vmport=off: Allow disabling of VMWare ioport emulation

2014-09-25 Thread Slutz, Donald Christopher
What is happening with this patch? I would like to use this code. -Don Slutz From: qemu-devel-bounces+don=cloudswitch@nongnu.org [qemu-devel-bounces+don=cloudswitch@nongnu.org] on behalf of Gerd Hoffmann [kra...@redhat.com] Sent: Tuesday, May

Re: [Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info

2014-09-25 Thread Paolo Bonzini
Il 25/09/2014 12:49, Stefan Hajnoczi ha scritto: > On Thu, Sep 25, 2014 at 10:06:35AM +0200, Olaf Hering wrote: >> During code review for xen I noticed that --enable-debug-info >> would still strip the binaries because strip_opt= defaults to >> yes. If --enable-debug-info is passed to configure it

Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

2014-09-25 Thread Pádraig Brady
On 09/25/2014 10:00 AM, Tony Breeds wrote: > On Thu, Sep 25, 2014 at 09:30:30AM +0200, Kevin Wolf wrote: > >> Does this fix the problem or does it just make it less likely that it >> becomes apparent? > > Sorry for not making this clearer in my commit message. > > I haven't been able to reproduc

Re: [Qemu-devel] [PATCH v4 12/19] qapi: Add some type check tests

2014-09-25 Thread Eric Blake
On 09/25/2014 02:06 AM, Markus Armbruster wrote: >> >> The QAPI schema's 'returns' becomes "return" on the wire. We suck. >> >> qmp-spec.txt is *wrong*! We actually use json-array in addition to >> json-object. > > Actually, we use json-int and json-str as well: > query-migrate-cache-size, ring

Re: [Qemu-devel] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-25 Thread Alexey Kardashevskiy
On 09/25/2014 10:39 PM, Kevin Wolf wrote: > Am 25.09.2014 um 14:29 hat Alexey Kardashevskiy geschrieben: >> On 09/25/2014 08:20 PM, Kevin Wolf wrote: >>> Am 25.09.2014 um 11:55 hat Alexey Kardashevskiy geschrieben: Right. Cool. So is below what was suggested? I am doublechecking as it does >>>

Re: [Qemu-devel] [PATCH] ohci: Split long traces to smaller ones

2014-09-25 Thread Gerd Hoffmann
On Do, 2014-09-25 at 19:38 +1000, Alexey Kardashevskiy wrote: > On 09/25/2014 06:09 PM, Gerd Hoffmann wrote: > > On Do, 2014-09-25 at 10:16 +1000, Alexey Kardashevskiy wrote: > >> Recent traces rework introduced 2 tracepoints with 13 and 20 > >> arguments. When dtrace backend is selected > >> (--en

Re: [Qemu-devel] [PATCH 25/30] usb-bot: drop not needed "allow_hotplug = 0"

2014-09-25 Thread Gerd Hoffmann
On Do, 2014-09-25 at 10:12 +0200, Igor Mammedov wrote: > > Basically the same camp as usb-bot. UAS doesn't suffer the LUN > > numeration issue which BOT has, but there likewise is no signaling about > > scsi devices coming and going. > Thet's why a excluded UAS from this series, > Do I need to ma

Re: [Qemu-devel] [PATCH 20/30] s390x: convert virtio-ccw to hotplug handler API

2014-09-25 Thread Cornelia Huck
On Thu, 25 Sep 2014 15:11:10 +0200 Igor Mammedov wrote: > On Thu, 25 Sep 2014 13:08:38 +0200 > Cornelia Huck wrote: > > So, to summarize, what happened before was > > > > bridge device <--- (simple unplug invoked for dev) > simple unplug should not exits for above device Yes. I'm

Re: [Qemu-devel] [PATCH v4 12/19] qapi: Add some type check tests

2014-09-25 Thread Eric Blake
On 09/25/2014 01:34 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Demonstrate that the qapi generator silently parses confusing >> types, which may cause other errors later on. Later patches >> will update the expected results as the generator is made stricter. >> >> Signed-off-by: Eric

Re: [Qemu-devel] [PATCH 1/8] virtio-gpu/2d: add hardware spec include file

2014-09-25 Thread Gerd Hoffmann
Hi Dave, Triggered by the framebuffer endian issues we have with stdvga I've started to check where we stand with virtio-gpu and whenever we have to fix something in the virtio protocol before setting in stone with the upstream merge. Fixed the protocol. Basically s/uint32_t/__le32/g. No chan

Re: [Qemu-devel] [PATCH] -machine vmport=off: Allow disabling of VMWare ioport emulation

2014-09-25 Thread Dr. David Alan Gilbert
* Slutz, Donald Christopher (dsl...@verizon.com) wrote: > What is happening with this patch? I would like to use this code. I need to rework it for the new machine types code; but it was pretty low down my list of priorities; but I can try and get a minute for it again. Dave > >-Don Slutz

Re: [Qemu-devel] [PATCH 20/30] s390x: convert virtio-ccw to hotplug handler API

2014-09-25 Thread Igor Mammedov
On Thu, 25 Sep 2014 16:32:37 +0200 Cornelia Huck wrote: > On Thu, 25 Sep 2014 15:11:10 +0200 > Igor Mammedov wrote: > > > On Thu, 25 Sep 2014 13:08:38 +0200 > > Cornelia Huck wrote: > > > > So, to summarize, what happened before was > > > > > > bridge device <--- (simple unplug

[Qemu-devel] [Bug 1373362] Re: qemu-2.1.1 i386-softmmu compile error: q35_dsdt_applesmc_sta undeclared

2014-09-25 Thread Iggy
Works fine here. Even made sure the resulting binary runs okay (which it does). Maybe try in a clean chroot or something? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1373362 Title: qemu-2.1.1 i38

[Qemu-devel] [PATCH] main-loop.c: Handle SIGINT, SIGHUP and SIGTERM synchronously

2014-09-25 Thread Peter Maydell
Add the termination signals SIGINT, SIGHUP and SIGTERM to the list of signals which we handle synchronously via a signalfd. This avoids a race condition where if we took the SIGTERM in the middle of qemu_shutdown_requested: int r = shutdown_requested; [SIGTERM here...] shutdown_requested =

Re: [Qemu-devel] [PATCH] main-loop.c: Handle SIGINT, SIGHUP and SIGTERM synchronously

2014-09-25 Thread Paolo Bonzini
Il 25/09/2014 17:51, Peter Maydell ha scritto: > Add the termination signals SIGINT, SIGHUP and SIGTERM to the > list of signals which we handle synchronously via a signalfd. > This avoids a race condition where if we took the SIGTERM > in the middle of qemu_shutdown_requested: > int r = shutdo

Re: [Qemu-devel] Microcheckpointing: Memory-VCPU / Disk State consistency

2014-09-25 Thread Walid Nouri
Am 24.09.2014 10:47, schrieb Stefan Hajnoczi: I think the assumption with drive-mirror is that you throw away the destination image if something fails. That's the exact opposite of MC where we want to fail over to the destination :). This was not obivous for me... Here is one example of a me

Re: [Qemu-devel] [PATCH v4 12/19] qapi: Add some type check tests

2014-09-25 Thread Markus Armbruster
Eric Blake writes: > On 09/25/2014 01:34 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Demonstrate that the qapi generator silently parses confusing >>> types, which may cause other errors later on. Later patches >>> will update the expected results as the generator is made stricter

Re: [Qemu-devel] [PATCH v4 12/19] qapi: Add some type check tests

2014-09-25 Thread Markus Armbruster
Eric Blake writes: > On 09/25/2014 02:06 AM, Markus Armbruster wrote: > >>> >>> The QAPI schema's 'returns' becomes "return" on the wire. We suck. >>> >>> qmp-spec.txt is *wrong*! We actually use json-array in addition to >>> json-object. >> >> Actually, we use json-int and json-str as well: >

Re: [Qemu-devel] [PATCH v4 12/19] qapi: Add some type check tests

2014-09-25 Thread Eric Blake
On 09/25/2014 10:12 AM, Markus Armbruster wrote: >>> Do we want to permit anything but a complex type for 'returns'? >> >> Sadly, yes. We have existing commands that do just that. I already >> documented that new commands should avoid it (it's not extensible). > > If we care, we can whitelist t

  1   2   3   >