On Thu, Sep 25, 2014 at 09:54:02AM +0200, Kevin Wolf wrote: > The device_name of a BlockDriverState is currently checked because it is > always used as a QemuOpts ID and qemu_opts_create() checks whether such > IDs are wellformed. > > node-name is supposed to share the same namespace, but it isn't checked > currently. This patch adds explicit checks both for device_name and > node-name so that the same rules will still apply even if QemuOpts won't > be used any more at some point. > > qemu-img used to use names with spaces in them, which isn't allowed any > more. Replace them with underscores. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > v2: > - Fix qemu-img to use valid names internally [Stefan] > > block.c | 16 +++++++++++++--- > include/qemu/option.h | 1 + > qemu-img.c | 6 +++--- > util/qemu-option.c | 4 ++-- > 4 files changed, 19 insertions(+), 8 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
pgpM3CHpsxt_C.pgp
Description: PGP signature
