Re: [Qemu-devel] [PATCH v2 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-15 Thread Fam Zheng
On Sat, 09/13 17:00, Markus Armbruster wrote: > The patch is big, but all it really does is replacing > > dinfo->bdrv > > by > > blk_bs(blk_legacy_dinfo(dinfo)) s/blk_legacy_dinfo/blk_by_legacy_dinfo/ Otherwise looks good, Reviewed-by: Fam Zheng > > The replacement is repetitive, b

Re: [Qemu-devel] [PATCH v2 03/23] block: Connect BlockBackend to BlockDriverState

2014-09-15 Thread Markus Armbruster
Max Reitz writes: > On 13.09.2014 17:00, Markus Armbruster wrote: >> The pointer from BlockBackend to BlockDriverState is a strong >> reference, managed with bdrv_ref() / bdrv_unref(), the back-pointer is >> a weak one. >> >> Convenience function blk_new_with_bs() creates a BlockBackend with its

Re: [Qemu-devel] [PATCH V5 1/6] icount: Add QemuOpts for icount

2014-09-15 Thread TeLeMan
On Fri, Jul 25, 2014 at 5:56 PM, Sebastian Tanase wrote: > Make icount parameter use QemuOpts style options in order > to easily add other suboptions. > > Signed-off-by: Sebastian Tanase > Tested-by: Camille Bégué > Signed-off-by: Paolo Bonzini > --- > cpus.c| 10 +- >

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-15 Thread Gonglei (Arei)
> From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Monday, September 15, 2014 2:41 PM > Subject: Re: [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev > properties > > On Mon, Sep 15, 2014 at 05:49:42AM +, Gonglei (Arei) wrote: > > > From: Michael S. Tsirkin [mailto:m..

Re: [Qemu-devel] [PATCH 1/2] vl: Fix the confused logic for '-m' option

2014-09-15 Thread zhanghailiang
On 2014/9/12 21:52, Igor Mammedov wrote: On Fri, 12 Sep 2014 13:58:55 +0800 zhanghailiang wrote: It should be valid for the follow configure: -m 256,slots=0 -m 256,maxmem=256M Doc comment/help says that slots& maxmem must be in pair so above is not valid CLI " Hmm, yes, you are right;), S

Re: [Qemu-devel] [PATCH v2 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-15 Thread Markus Armbruster
Fam Zheng writes: > On Sat, 09/13 17:00, Markus Armbruster wrote: >> The patch is big, but all it really does is replacing >> >> dinfo->bdrv >> >> by >> >> blk_bs(blk_legacy_dinfo(dinfo)) > > s/blk_legacy_dinfo/blk_by_legacy_dinfo/ > > Otherwise looks good, > > Reviewed-by: Fam Zheng

Re: [Qemu-devel] [PATCH v2 05/23] block: Code motion to get rid of stubs/blockdev.c

2014-09-15 Thread Markus Armbruster
Fam Zheng writes: > On Sat, 09/13 17:00, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> block/block-backend.c | 15 +++ >> blockdev.c| 13 - >> include/sysemu/blockdev.h | 1 - >> stubs/Makefile.objs | 1 - >> stubs/blo

Re: [Qemu-devel] [PATCH v2 05/23] block: Code motion to get rid of stubs/blockdev.c

2014-09-15 Thread Fam Zheng
On Mon, 09/15 09:21, Markus Armbruster wrote: > Fam Zheng writes: > > > On Sat, 09/13 17:00, Markus Armbruster wrote: > >> Signed-off-by: Markus Armbruster > >> --- > >> block/block-backend.c | 15 +++ > >> blockdev.c| 13 - > >> include/sysemu/blockd

[Qemu-devel] [PATCH 0/2 V3] Virtual Machine Generation ID

2014-09-15 Thread Gal Hammer
Hi, A two parts patch to add a QEmu support for Microsoft's Virtual Machine Generation ID device. The first one add a new ACPI directive which allow to use a 16-bytes buffer in an ACPI table. This buffer is for storing the VM's UUID. The second is the ACPI tables changes and the actual device.

[Qemu-devel] [PATCH 1/2] i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive.

2014-09-15 Thread Gal Hammer
Add a 16-bytes buffer to allow storing a 128-bit UUID value in an ACPI table. Signed-off-by: Gal Hammer --- scripts/acpi_extract.py | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/scripts/acpi_extract.py b/scripts/acpi_extract.py index 22ea468..10c1ff

[Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-09-15 Thread Gal Hammer
Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the DSDT ACPI table. The GUID is set using a new "vmgenid" device. Signed-off-by: Gal Hammer --- default-configs/i386-softmmu.mak | 1 + default-confi

Re: [Qemu-devel] [PATCH v2 19/23] blockdev: Drop DriveInfo member enable_auto_del

2014-09-15 Thread Fam Zheng
On Sat, 09/13 17:00, Markus Armbruster wrote: > Commit 2d246f0 introduced DriveInfo member enable_auto_del to > distinguish DriveInfo created via drive_new() from DriveInfo created > via qmp_blockdev_add(). The latter no longer exist. Drop > enable_auto_del. > > Signed-off-by: Markus Armbruster

[Qemu-devel] [RFC] arm/virt: mark timer in fdt as armv8-compatible

2014-09-15 Thread hw . claudio
From: Claudio Fontana Signed-off-by: Claudio Fontana --- hw/arm/virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Is the timer armv8-compatible? I think it is, at least the virtual timer seems to work as expected. When looking up the timer information in the guest btw, where the gu

Re: [Qemu-devel] [PATCH 4/5] pc: add cpu hotplug handler to PC_MACHINE

2014-09-15 Thread Igor Mammedov
On Mon, 15 Sep 2014 11:57:56 +0800 Gu Zheng wrote: > Hi Igor, > > On 09/12/2014 10:28 PM, Igor Mammedov wrote: > > > On Fri, 12 Sep 2014 11:02:09 +0800 > > Gu Zheng wrote: > > > >> Hi Igor, > >> On 09/10/2014 09:55 PM, Igor Mammedov wrote: > >> > >>> On Wed, 3 Sep 2014 17:06:16 +0800 > >>> G

[Qemu-devel] KVM call for agend for 2014-09-16

2014-09-15 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. People have complained on the past that I don't cancel the call until the very last minute. So, what do you think that deadline for submitting topics is 23:00UTC on Monday? Call details: 15:00 CEST 13:00 UTC 09:00 EDT Every

Re: [Qemu-devel] [PATCH V4] dump: let dump_error return error info to caller

2014-09-15 Thread zhanghailiang
On 2014/9/12 23:10, Luiz Capitulino wrote: On Wed, 10 Sep 2014 19:03:50 +0800 zhanghailiang wrote: The second parameter of dump_error is unused, but one purpose of using this function is to report the error info. Use error_set to return the error info to the caller. This is a very good chan

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-15 Thread Michael S. Tsirkin
On Mon, Sep 15, 2014 at 07:12:59AM +, Gonglei (Arei) wrote: > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Monday, September 15, 2014 2:41 PM > > Subject: Re: [PATCH v2 1/9] virtio-net: use aliases instead of duplicate > > qdev > > properties > > > > On Mon, Sep 15, 2014 at 0

Re: [Qemu-devel] [PATCH v2 19/23] blockdev: Drop DriveInfo member enable_auto_del

2014-09-15 Thread Markus Armbruster
Fam Zheng writes: > On Sat, 09/13 17:00, Markus Armbruster wrote: >> Commit 2d246f0 introduced DriveInfo member enable_auto_del to >> distinguish DriveInfo created via drive_new() from DriveInfo created >> via qmp_blockdev_add(). The latter no longer exist. Drop >> enable_auto_del. >> >> Signe

Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-09-15 Thread Igor Mammedov
On Mon, 15 Sep 2014 10:27:08 +0300 Gal Hammer wrote: > Based on Microsoft's sepecifications (paper can be dowloaded from > http://go.microsoft.com/fwlink/?LinkId=260709), add a device > description to the DSDT ACPI table. > > The GUID is set using a new "vmgenid" device. > > Signed-off-by: Gal

Re: [Qemu-devel] BB name vs. BDS name in the QAPI schema

2014-09-15 Thread Kevin Wolf
Am 15.09.2014 um 03:31 hat Fam Zheng geschrieben: > On Sat, 09/13 19:04, Markus Armbruster wrote: > > > > I actually like having separate parameters for separate kinds of names. > > > > However, BlockdevRef appears to tie our hand: it's an anonymous union, > > which means only the value is on t

Re: [Qemu-devel] KVM call for agend for 2014-09-16

2014-09-15 Thread Markus Armbruster
Juan Quintela writes: > Hi > > Please, send any topic that you are interested in covering. > > People have complained on the past that I don't cancel the call until > the very last minute. So, what do you think that deadline for > submitting topics is 23:00UTC on Monday? Yes, please. [...]

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-15 Thread Gonglei (Arei)
> > > > > > > > Sorry, I don't understand your meaning. :( > > > > > > I applied your patch, and looked at the property types. > > > > > Could you tell me your method looked at properties type? > > You can use an HMP command, or you can use > -device virtio-net-pci,? OK. Good method. > changes m

Re: [Qemu-devel] BB name vs. BDS name in the QAPI schema

2014-09-15 Thread Fam Zheng
On Mon, 09/15 10:59, Kevin Wolf wrote: > Am 15.09.2014 um 03:31 hat Fam Zheng geschrieben: > > On Sat, 09/13 19:04, Markus Armbruster wrote: > > > > > > I actually like having separate parameters for separate kinds of names. > > > > > > However, BlockdevRef appears to tie our hand: it's an anon

Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-09-15 Thread Gal Hammer
Got it. I'll start to work on V4 then... Gal. - Original Message - From: "Igor Mammedov" To: "Gal Hammer" Cc: pbonz...@redhat.com, qemu-devel@nongnu.org Sent: Monday, September 15, 2014 11:46:41 AM Subject: Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID devi

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-15 Thread Gonglei (Arei)
> -Original Message- > From: Gonglei (Arei) > Sent: Monday, September 15, 2014 5:06 PM > To: 'Michael S. Tsirkin' > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; stefa...@redhat.com; > Huangweidong (C); ag...@suse.de; Huangpeng (Peter); r...@twiddle.net; > cornelia.h...@de.ibm.com;

Re: [Qemu-devel] [PATCH v2] qcow2: add update refcount table realization for update_refcount

2014-09-15 Thread Stefan Hajnoczi
On Sat, Sep 13, 2014 at 11:53:58PM +0800, Jun Li wrote: > On Fri, 09/05 16:33, Stefan Hajnoczi wrote: > > On Mon, Sep 01, 2014 at 06:52:48PM +0800, Jun Li wrote: > > > > How does this patch handle self-describing refcount blocks? I think > > they will keep the refcount block alive forever because

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-15 Thread Gonglei (Arei)
> > Subject: RE: [PATCH v2 1/9] virtio-net: use aliases instead of duplicate > > qdev > > properties > > > > > > > > > > > > > > Sorry, I don't understand your meaning. :( > > > > > > > > > > I applied your patch, and looked at the property types. > > > > > > > > > Could you tell me your method lo

Re: [Qemu-devel] [PATCH v5] virtio-pci: enable bus master for old guests

2014-09-15 Thread Jason Wang
On 09/12/2014 02:20 AM, Michael S. Tsirkin wrote: > commit cc943c36faa192cd4b32af8fe5edb31894017d35 > pci: Use bus master address space for delivering MSI/MSI-X messages > breaks virtio-net for rhel6.[56] x86 guests because they don't > enable bus mastering for virtio PCI devices. For the same

Re: [Qemu-devel] [PATCH v5] virtio-pci: enable bus master for old guests

2014-09-15 Thread Michael S. Tsirkin
On Mon, Sep 15, 2014 at 05:48:17PM +0800, Jason Wang wrote: > On 09/12/2014 02:20 AM, Michael S. Tsirkin wrote: > > commit cc943c36faa192cd4b32af8fe5edb31894017d35 > > pci: Use bus master address space for delivering MSI/MSI-X messages > > breaks virtio-net for rhel6.[56] x86 guests because the

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-15 Thread Michael S. Tsirkin
On Mon, Sep 15, 2014 at 09:23:26AM +, Gonglei (Arei) wrote: > > > > > > > > > -Original Message- > > From: Gonglei (Arei) > > Sent: Monday, September 15, 2014 5:06 PM > > To: 'Michael S. Tsirkin' > > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; stefa...@redhat.com; > > Huangwe

Re: [Qemu-devel] [PATCH v2 1/3] throttle: Make NANOSECONDS_PER_SECOND an integer

2014-09-15 Thread Markus Armbruster
Benoît Canet writes: > We will want to reuse this define in the future by making it common to > multiples > QEMU modules. > It would be safer that this define be an integer so we avoid stranges float > rounding errors. > Do this conversion. > > Signed-off-by: Benoît Canet > --- > include/qemu/

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-15 Thread Michael S. Tsirkin
On Mon, Sep 15, 2014 at 09:29:26AM +, Gonglei (Arei) wrote: > > > Subject: RE: [PATCH v2 1/9] virtio-net: use aliases instead of duplicate > > > qdev > > > properties > > > > > > > > > > > > > > > > > Sorry, I don't understand your meaning. :( > > > > > > > > > > > > I applied your patch, and

Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects

2014-09-15 Thread Bharata B Rao
On Mon, Sep 15, 2014 at 12:09 PM, Gu Zheng wrote: > Hi Bharata, > On 09/12/2014 09:52 PM, Bharata B Rao wrote: > >> On Fri, Sep 12, 2014 at 4:23 PM, Anshul Makkar >> wrote: >>> During plugging we can see this event: echo 1 > cpu8/online. >>> >>> But during unplugging , we can't see the event echo

Re: [Qemu-devel] [PATCH v5] virtio-pci: enable bus master for old guests

2014-09-15 Thread Amos Kong
On Mon, Sep 15, 2014 at 12:59:44PM +0300, Michael S. Tsirkin wrote: > On Mon, Sep 15, 2014 at 05:48:17PM +0800, Jason Wang wrote: > > On 09/12/2014 02:20 AM, Michael S. Tsirkin wrote: > > > commit cc943c36faa192cd4b32af8fe5edb31894017d35 > > > pci: Use bus master address space for delivering MS

Re: [Qemu-devel] [virtio-dev] [PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.txt

2014-09-15 Thread Gerd Hoffmann
On Sa, 2014-09-13 at 07:14 +1000, Dave Airlie wrote: > >> Can the host refuse due to lack of resources? > > > > Yes. virtgpu_ctrl_hdr.type in the response will be set to > > VIRTGPU_RESP_ERR_* then. Current implementation does that only on > > malloc() failure, there is no accounting (yet) to lim

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2014-09-15 Thread Michael Steffens
It seems the dust settles a bit: Found the relevant difference between my various filesystems, and how to reproduce the failure: Susceptible filesystems don't have the extent feature of ext4 enabled. You can create such a filesystem using mke2fs -t ext4 -O ^extent /dev/... mount /mnt /dev/...

Re: [Qemu-devel] [PATCH v2 1/2] scsi: Optimize scsi_req_alloc

2014-09-15 Thread Paolo Bonzini
Il 15/09/2014 07:23, Fam Zheng ha scritto: > +uint8_t sense[SCSI_SENSE_BUF_SIZE]; > +uint32_t sense_len; > +bool enqueued; > +bool io_canceled; > +bool retry; > +bool dma_started; > SCSICommand

Re: [Qemu-devel] [PATCH v2 2/2] virtio-scsi: Optimize virtio_scsi_init_req

2014-09-15 Thread Paolo Bonzini
Il 15/09/2014 07:23, Fam Zheng ha scritto: > SCSIRequest *sreq; > size_t resp_size; > enum SCSIXferMode mode; > -QEMUIOVector resp_iov; > union { > VirtIOSCSICmdResp cmd; > VirtIOSCSICtrlTMFResp tmf; > @@ -68,23 +75,27 @@ static inline SCSIDevice > *vi

Re: [Qemu-devel] [PATCH v2 3/3] util: Add an utility infrastructure used to compute an average on a time slice

2014-09-15 Thread Markus Armbruster
Benoît Canet writes: > The algorithm used was defined on the list while discussing the new IO > accounting > overhaul. > See http://lists.nongnu.org/archive/html/qemu-devel/2014-08/msg04954.html > > Also the module takes care of computing minimal and maximal values over the > time > slice durat

Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects

2014-09-15 Thread Anshul Makkar
That explains the cause. Please verify you have the iasl compiler installed and are not using the hold .hex (compile .dsl ) files. (Faced this issue in our build setup using sbuil.). I hope you have verified that your .dsl file has the changes as mentioned in the patch. I have also verified with

Re: [Qemu-devel] [PATCH 2/2] Revert "virtio: don't call device on !vm_running"

2014-09-15 Thread Christian Borntraeger
On 09/11/2014 06:18 PM, Michael S. Tsirkin wrote: > This reverts commit a1bc7b827e422e1ff065640d8ec5347c4aadfcd8. > virtio: don't call device on !vm_running > It turns out that virtio net assumes that vm_running > is updated before device status callback in many places, > so this change leads t

Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-15 Thread Gerd Hoffmann
Hi, > >> > >> Why do you think that? We have several header files which > >> use QEMU_BUILD_BUG_ON and I don't see any reason why > >> it would have to be invoked from a .c file. > > > Because Gerd wants to share this with linux uapi, and > > you can't use BUILD_BUG_ON in uapi headers on linux.

Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-15 Thread Gerd Hoffmann
> > > > + > > > > +enum virtgpu_ctrl_type { > > > > +VIRTGPU_UNDEFINED = 0, > > > > + > > > > +/* 2d commands */ > > > > +VIRTGPU_CMD_GET_DISPLAY_INFO = 0x0100, > > > > > > Please consider also adding: > > VIRTIO_GPU_ everywhere to make it consistent with other > virtio he

[Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed

2014-09-15 Thread Alexey Kardashevskiy
Hi! I am hitting an racing issue with migration. I migrate a guest from one machine to another using libvirt: virsh migrate --live --persistent --undefinesource --copy-storage-all --verbose --desturi qemu+ssh://legkvm/system --domain chig1 I.e. it copied the full disk which is qcow2, 20G virtua

[Qemu-devel] [PATCH] softmmu: fixing usage of cpu_st/ld* from helpers

2014-09-15 Thread Pavel Dovgalyuk
MMU helper functions are called from generated code and other helper functions. In both cases they try to get function's return address for using it while restoring virtual CPU state. When MMU helper is called from some other helper function (like helper_maskmov_xmm) through cpu_st* function, the

Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-15 Thread Michael S. Tsirkin
On Mon, Sep 15, 2014 at 12:40:07PM +0200, Gerd Hoffmann wrote: > > > > > + > > > > > +enum virtgpu_ctrl_type { > > > > > +VIRTGPU_UNDEFINED = 0, > > > > > + > > > > > +/* 2d commands */ > > > > > +VIRTGPU_CMD_GET_DISPLAY_INFO = 0x0100, > > > > > > > > Please consider also a

Re: [Qemu-devel] [PATCH 18/23] target-mips: Use cpu_exec_interrupt qom hook

2014-09-15 Thread Leon Alrae
On 13/09/2014 17:45, Richard Henderson wrote: > Cc: Aurelien Jarno > Signed-off-by: Richard Henderson > --- > cpu-exec.c| 9 - > target-mips/cpu-qom.h | 1 + > target-mips/cpu.c | 1 + > target-mips/helper.c | 17 + > 4 files changed, 19 insertions(+),

Re: [Qemu-devel] [PATCH v2 3/3] util: Add an utility infrastructure used to compute an average on a time slice

2014-09-15 Thread Markus Armbruster
Benoît Canet writes: > On Mon, Sep 08, 2014 at 05:09:38PM +0200, Paolo Bonzini wrote: >> Il 08/09/2014 16:49, Benoît Canet ha scritto: >> >> > - create two windows, with twice the suggested expiration period, and >> >> > return min/avg/max from the oldest window. Example >> >> > >> >> >

[Qemu-devel] [PATCH] target-i386: update fp status fix

2014-09-15 Thread Pavel Dovgalyuk
This patch adds calls to update_fp_status() function from several places where FPU state is changed. These calls update status of softfloat library and prevent bugs caused by non-coherent rounding settings of the FPU and softfloat. Signed-off-by: Pavel Dovgalyuk --- target-i386/cpu.c|

Re: [Qemu-devel] [PATCH 1/4] blockdev: Disentangle BlockDriverState and DriveInfo creation

2014-09-15 Thread Benoît Canet
The Friday 12 Sep 2014 à 21:26:21 (+0200), Markus Armbruster wrote : > blockdev_init() mixes up BlockDriverState and DriveInfo initialization > Finish the BlockDriverState job before starting to mess with > DriveInfo. Easier on the eyes. > > Signed-off-by: Markus Armbruster > --- > blockdev.c |

[Qemu-devel] [PATCH v4] Add HMP command "info memory-devices"

2014-09-15 Thread Zhu Guihua
Provides HMP equivalent of QMP query-memory-devices command. Signed-off-by: Zhu Guihua --- Changes since v3: - optimize the time to print memory devices' information. - change output format of di->addr and di->size. Changes since v2: - print address in hex. - change the loop control from while

Re: [Qemu-devel] [PATCH 2/4] block: Keep DriveInfo alive until BlockDriverState dies

2014-09-15 Thread Benoît Canet
The Friday 12 Sep 2014 à 21:26:22 (+0200), Markus Armbruster wrote : > If the BDS's refcnt > 0, drive_del() destroys the DriveInfo, but not > the BDS. This can happen in three places: > > * Device model destruction during unplug: blockdev_auto_del() > > * Xen IDE unplug: pci_piix3_xen_ide_unplug

Re: [Qemu-devel] [PATCH v2 3/3] util: Add an utility infrastructure used to compute an average on a time slice

2014-09-15 Thread Benoît Canet
On Mon, Sep 15, 2014 at 01:13:08PM +0200, Markus Armbruster wrote: > Benoît Canet writes: > > > On Mon, Sep 08, 2014 at 05:09:38PM +0200, Paolo Bonzini wrote: > >> Il 08/09/2014 16:49, Benoît Canet ha scritto: > >> >> > - create two windows, with twice the suggested expiration period, and > >> >>

Re: [Qemu-devel] [PATCH V5 1/6] icount: Add QemuOpts for icount

2014-09-15 Thread Paolo Bonzini
Il 15/09/2014 09:04, TeLeMan ha scritto: >> > -configure_icount(icount_option); > When icount_opts is null, seqlock_init() & vmstate_register() in > configure_icount() cannot be executed. > There's already a pull request sent with a fix. Paolo

Re: [Qemu-devel] [PATCH v2 3/3] util: Add an utility infrastructure used to compute an average on a time slice

2014-09-15 Thread Benoît Canet
On Mon, Sep 15, 2014 at 01:13:08PM +0200, Markus Armbruster wrote: > Benoît Canet writes: > > > On Mon, Sep 08, 2014 at 05:09:38PM +0200, Paolo Bonzini wrote: > >> Il 08/09/2014 16:49, Benoît Canet ha scritto: > >> >> > - create two windows, with twice the suggested expiration period, and > >> >>

Re: [Qemu-devel] [PATCH 1/4] blockdev: Disentangle BlockDriverState and DriveInfo creation

2014-09-15 Thread Markus Armbruster
Benoît Canet writes: > The Friday 12 Sep 2014 à 21:26:21 (+0200), Markus Armbruster wrote : >> blockdev_init() mixes up BlockDriverState and DriveInfo initialization >> Finish the BlockDriverState job before starting to mess with >> DriveInfo. Easier on the eyes. >> >> Signed-off-by: Markus Arm

Re: [Qemu-devel] [PATCH v2 01/23] block: Split bdrv_new_root() off bdrv_new()

2014-09-15 Thread Benoît Canet
On Sat, Sep 13, 2014 at 05:00:05PM +0200, Markus Armbruster wrote: > Creating an anonymous BDS can't fail. Make that obvious. > > Signed-off-by: Markus Armbruster > --- > block.c | 28 +++- > block/iscsi.c | 2 +- > block/vvfat.c | 2 +- >

Re: [Qemu-devel] [PATCH] block/vhdx.c: Mark parent_vhdx_guid variable as unused

2014-09-15 Thread Jeff Cody
On Sun, Sep 14, 2014 at 08:29:59PM +0100, Peter Maydell wrote: > The parent_vhdx_guid variable is defined but never used, which provokes > complaints from newer versions of clang. Since the variable definition > is here acting as documentation of the image format, mark it with the > 'unused' attrib

Re: [Qemu-devel] [PATCH] configure: check for pixman-1 version

2014-09-15 Thread Paolo Bonzini
Il 15/09/2014 05:19, Hu Tao ha scritto: > commit f27b2e1d bumped to pixman-0.28.2, but reverted later by 7b1b5d19 > (mistakenly?) Yes, it was likely a mistake. Paolo

[Qemu-devel] [PATCH] virtio-balloon: Fix ballooning not working correctly when hotplug memory

2014-09-15 Thread zhanghailiang
When do memory balloon, it references the ram_size as the real ram size of VM, But here ram_size is not include the hotplugged memory, and the result will be confused. Steps to reproduce: (1)Start VM: qemu -m size=1024,slots=4,maxmem=8G (2)In VM: #free -m : 1024M (3)qmp balloon 512M (4)In VM: #fre

[Qemu-devel] [PATCH resend v2 1/2] monitor: Reset HMP mon->rs in CHR_EVENT_OPEN

2014-09-15 Thread Stratos Psomadakis
Commit cdaa86a54 ("Add G_IO_HUP handler for socket chardev") exposed a bug in the way the HMP monitor handles its command buffer. When a client closes the connection to the monitor, tcp_chr_read() will detect the G_IO_HUP condition and call tcp_chr_disconnect() to close the server-side connection t

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qemu-char: fix terminal crash when using "-monitor stdio -nographic"

2014-09-15 Thread Michael Tokarev
09.09.2014 15:19, john.liuli wrote: > From: Li Liu > > Eeay to reproduce, just try "qemu -monitor stdio -nographic" > and type "quit", then the terminal will be crashed. > > There are two pathes try to call tcgetattr of stdio in vl.c: This looks reasonable. Except of one thing -- how about ren

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] Fix typos and misspellings in comments

2014-09-15 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

[Qemu-devel] [PATCH] aio-win32: avoid out-of-bounds access to the events array

2014-09-15 Thread Paolo Bonzini
If ret is WAIT_TIMEOUT and there was an event returned by select(), we can write to a location after the end of the array. But in that case we can retry the WaitForMultipleObjects call with the same set of events, so just move the event[ret - WAIT_OBJECT_0] assignment inside the existin conditiona

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qemu-char: fix terminal crash when using "-monitor stdio -nographic"

2014-09-15 Thread Michael Tokarev
15.09.2014 16:50, Michael Tokarev пишет: > 09.09.2014 15:19, john.liuli wrote: >> From: Li Liu >> >> Eeay to reproduce, just try "qemu -monitor stdio -nographic" >> and type "quit", then the terminal will be crashed. >> >> There are two pathes try to call tcgetattr of stdio in vl.c: > > This look

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] rdma: Fix incorrect description in comments

2014-09-15 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2014-09-15 Thread Michael Steffens
The fallback cascade Pádraig mentions is already implemented in qemu-2.1.0, in function raw_co_get_block_status. Just swap ret = try_fiemap( ... ) and ret = try_seek_hole( ... ) to reverse the order. I can confirm that it works just fine on 3.13 kernel (all version since 3.1, according to l

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] xen-hvm.c: Always return -1 when failure occurs in xen_hvm_init()

2014-09-15 Thread Michael Tokarev
Applied to -trivial, after fixing the commit message to be just a bit more english-like. Thank you! /mjt

Re: [Qemu-devel] [PATCH v2 02/23] block: New BlockBackend

2014-09-15 Thread Benoît Canet
> --- a/block.c > +++ b/block.c > @@ -2119,10 +2119,11 @@ static void bdrv_delete(BlockDriverState *bs) > > bdrv_close(bs); > > +drive_info_del(drive_get_by_blockdev(bs)); > + > /* remove from list, if necessary */ > bdrv_make_anon(bs); > > -drive_info_del(drive_get_b

Re: [Qemu-devel] [Qemu-trivial] [PATCH] arch_init: Setting QEMU_ARCH enum straight

2014-09-15 Thread Michael Tokarev
08.09.2014 16:30, Bastian Koppelmann wrote: > Every QEMU_ARCH is now hexadecimal instead of a mixture of decimal and > hexadecimal. I'm not sure it is worth the trouble really. For readability, the best in this case (in my opinion anyway) is to use (1<

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] xen-hvm.c: Always return -1 when failure occurs in xen_hvm_init()

2014-09-15 Thread Chen Gang
On 9/15/14 21:01, Michael Tokarev wrote: > Applied to -trivial, after fixing the commit message to be > just a bit more english-like. Thank you! > OK, thank you for your work. Next, I shall do something related microblaze under Qemu to let it run for microblaze gcc/binutils test, hope I can fin

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] xen-hvm.c: Always return -1 when failure occurs in xen_hvm_init()

2014-09-15 Thread Chen Gang
On 9/15/14 21:01, Michael Tokarev wrote: > Applied to -trivial, after fixing the commit message to be > just a bit more english-like. Thank you! > OK, thank you for your work. Next, I shall do something related microblaze under Qemu to let it run for microblaze gcc/binutils test, hope I can fin

Re: [Qemu-devel] [PATCH v2 01/23] block: Split bdrv_new_root() off bdrv_new()

2014-09-15 Thread Markus Armbruster
Benoît Canet writes: > On Sat, Sep 13, 2014 at 05:00:05PM +0200, Markus Armbruster wrote: >> Creating an anonymous BDS can't fail. Make that obvious. >> >> Signed-off-by: Markus Armbruster >> --- >> block.c | 28 +++- >> block/iscsi.c | 2 +- >>

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qemu-char: fix terminal crash when using "-monitor stdio -nographic"

2014-09-15 Thread Gerd Hoffmann
On Mo, 2014-09-15 at 16:57 +0400, Michael Tokarev wrote: > 15.09.2014 16:50, Michael Tokarev пишет: > > 09.09.2014 15:19, john.liuli wrote: > >> From: Li Liu > >> > >> Eeay to reproduce, just try "qemu -monitor stdio -nographic" > >> and type "quit", then the terminal will be crashed. > >> > >> Th

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qemu-char: fix terminal crash when using "-monitor stdio -nographic"

2014-09-15 Thread Markus Armbruster
Michael Tokarev writes: > 15.09.2014 16:50, Michael Tokarev пишет: >> 09.09.2014 15:19, john.liuli wrote: >>> From: Li Liu >>> >>> Eeay to reproduce, just try "qemu -monitor stdio -nographic" >>> and type "quit", then the terminal will be crashed. >>> >>> There are two pathes try to call tcgetat

Re: [Qemu-devel] [PATCH 12/17] ppc: use movcond for isel

2014-09-15 Thread Paolo Bonzini
Il 03/09/2014 21:41, Tom Musta ha scritto: >> > +tcg_gen_movcond_tl(cpu_gpr[rD(ctx->opcode)], t1, zero, >> > + true_op, cpu_gpr[rB(ctx->opcode)], TCG_COND_NE); > This doesnt compile for me ... the order of the arguments does not match what > is defined in tcg-op.h. > It

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2014-09-15 Thread Pádraig Brady
I see seek hole is supported in the latest qemu-img so I would reorder so that's tried first like: if lseek(SEEK_HOLE) == ENOTSUP use_that if fiemap(FIEMAP_FLAG_SYNC) use_that -- You received this bug notification because you are a member of qemu- devel-ml, which

Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects

2014-09-15 Thread Bharata B Rao
On Mon, Sep 15, 2014 at 4:03 PM, Anshul Makkar wrote: > That explains the cause. > > Please verify you have the iasl compiler installed and are not using the > hold .hex (compile .dsl ) files. (Faced this issue in our build setup using > sbuil.). > > I hope you have verified that your .dsl file ha

Re: [Qemu-devel] [PATCH v2 02/23] block: New BlockBackend

2014-09-15 Thread Markus Armbruster
Benoît Canet writes: >> --- a/block.c >> +++ b/block.c >> @@ -2119,10 +2119,11 @@ static void bdrv_delete(BlockDriverState *bs) >> >> bdrv_close(bs); >> > > >> +drive_info_del(drive_get_by_blockdev(bs)); >> + >> /* remove from list, if necessary */ >> bdrv_make_anon(bs); >>

Re: [Qemu-devel] [PATCH] softmmu: fixing usage of cpu_st/ld* from helpers

2014-09-15 Thread Peter Maydell
CCing RTH who was the last person to do something with this area of the code I think. I thought the correct answer to this problem was "don't use the cpu_st* functions but use something else you can pass GETRA() to" ? On 15 September 2014 03:50, Pavel Dovgalyuk wrote: > MMU helper functions are c

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-15 Thread Gonglei (Arei)
> From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Monday, September 15, 2014 5:59 PM > > > > > > > > > > > > > > > > > > > > Sorry, I don't understand your meaning. :( > > > > > > > > > > > > > > I applied your patch, and looked at the property types. > > > > > > > > > > > > > Could you t

[Qemu-devel] [PATCH 0/2] Handle interferences between multiple children drivers and stream and commit

2014-09-15 Thread Benoît Canet
We do not want to try to stream or commit with a base argument through a multiple children driver. Handle this case. Benoît Canet (2): block: Introduce a BlockDriver field to flag drivers supporting multiple children block: commit and stream return an error when a subtree is found block

[Qemu-devel] [PATCH 2/2] block: commit and stream return an error when a subtree is found

2014-09-15 Thread Benoît Canet
In bdrv_find_backing_image when looking for the base BDS of a backing chain and a BDS having a multiple children block driver is found return NULL and set an error message. This will hopefully remove any unwanted interference between stream, commit and drivers like quorum. CC: Jeff Cody Signed-o

Re: [Qemu-devel] [PATCH resend v2 1/2] monitor: Reset HMP mon->rs in CHR_EVENT_OPEN

2014-09-15 Thread Luiz Capitulino
On Mon, 15 Sep 2014 15:34:57 +0300 Stratos Psomadakis wrote: > Commit cdaa86a54 ("Add G_IO_HUP handler for socket chardev") exposed a bug in > the way the HMP monitor handles its command buffer. When a client closes the > connection to the monitor, tcp_chr_read() will detect the G_IO_HUP conditio

[Qemu-devel] [PATCH 1/2] block: Introduce a BlockDriver field to flag drivers supporting multiple children

2014-09-15 Thread Benoît Canet
The recursive op blocker patch to come will take an optional base argument which will not have any meaning when an intermediary BDS driver of the graph support multiple children. Flag such drivers to be able to handle this case. CC: Jeff Cody Signed-off-by: Benoît Canet --- block/blkverify.c

Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects

2014-09-15 Thread Anshul Makkar
Great !! Anshul Makkar On Mon, Sep 15, 2014 at 3:53 PM, Bharata B Rao wrote: > On Mon, Sep 15, 2014 at 4:03 PM, Anshul Makkar > wrote: > > That explains the cause. > > > > Please verify you have the iasl compiler installed and are not using the > > hold .hex (compile .dsl ) files. (Faced this

[Qemu-devel] [PATCH 1/3] qom: add error handler for object alias property

2014-09-15 Thread arei.gonglei
From: Gonglei object_property_add_alias() is called at some places at present. And its parameter errp may not NULL, such as object_property_add_alias(obj, "iothread", OBJECT(&dev->vdev),"iothread", &error_abort); This patch add error handler for security. Cc: Stefa

[Qemu-devel] [PATCH 2/3] qom: add target object poniter for alias property in ObjectProperty

2014-09-15 Thread arei.gonglei
From: Gonglei In this way, we can use target object and get its qdev property legacy_name etc. Cc: Stefan Hajnoczi Cc: Paolo Bonzini Cc: Michael S. Tsirkin Signed-off-by: Gonglei --- include/qom/object.h | 3 +++ qom/object.c | 2 ++ 2 files changed, 5 insertions(+) diff --git a/in

[Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-15 Thread arei.gonglei
From: Gonglei At present, people have no way to know they should have a specific format for alias properties. Example: before output: virtio-blk-pci.physical_block_size=uint16 virtio-blk-pci.logical_block_size=uint16 virtio-blk-pci.drive=str after output applied this patch series: virtio-bl

[Qemu-devel] [PATCH 3/3] qmp: print real legacy_name for alias property

2014-09-15 Thread arei.gonglei
From: Gonglei In this way, we can get the real legacy_name for alias properties, and avoide confusing people because of property type. People have no way to know they should have a specific format. Example: before output: virtio-blk-pci.physical_block_size=uint16 virtio-blk-pci.logical_block_

Re: [Qemu-devel] OVMF, Q35 and USB keyboard/mouse

2014-09-15 Thread Gabriel L. Somlo
On Fri, Sep 12, 2014 at 03:59:52PM -0400, Gabriel L. Somlo wrote: > On Fri, Sep 12, 2014 at 08:26:01PM +0200, Paolo Bonzini wrote: > > So it could be an OVMF bug related to multifunction devices. > > > > Well, you could try moving devices around in different functions. > > You could try moving ehc

Re: [Qemu-devel] [PATCH v2 02/23] block: New BlockBackend

2014-09-15 Thread Markus Armbruster
Markus Armbruster writes: > Benoît Canet writes: > >>> --- a/block.c >>> +++ b/block.c >>> @@ -2119,10 +2119,11 @@ static void bdrv_delete(BlockDriverState *bs) >>> >>> bdrv_close(bs); >>> >> >> >>> +drive_info_del(drive_get_by_blockdev(bs)); >>> + >>> /* remove from list, if n

Re: [Qemu-devel] [PATCH v2 03/23] block: Connect BlockBackend to BlockDriverState

2014-09-15 Thread Benoît Canet
> index ff95da6..fa8a7d0 100644 > --- a/qemu-nbd.c > +++ b/qemu-nbd.c > @@ -689,7 +689,7 @@ int main(int argc, char **argv) > } > > blk = blk_new("hda", &error_abort); Is a blk_new_with_bs converssion missing here ? > -bs = bdrv_new_root("hda", &error_abort); > +bs = blk_bs(bl

Re: [Qemu-devel] BB name vs. BDS name in the QAPI schema

2014-09-15 Thread Stefan Hajnoczi
On Mon, Sep 15, 2014 at 10:59:01AM +0200, Kevin Wolf wrote: > Am 15.09.2014 um 03:31 hat Fam Zheng geschrieben: > > On Sat, 09/13 19:04, Markus Armbruster wrote: > > I remember at the time of introducing node-name, it was in a separate > > namespace, but now it's not. Then why should the user care

Re: [Qemu-devel] OVMF, Q35 and USB keyboard/mouse

2014-09-15 Thread Laszlo Ersek
On 09/15/14 16:50, Gabriel L. Somlo wrote: > On Fri, Sep 12, 2014 at 03:59:52PM -0400, Gabriel L. Somlo wrote: >> On Fri, Sep 12, 2014 at 08:26:01PM +0200, Paolo Bonzini wrote: >>> So it could be an OVMF bug related to multifunction devices. >>> >>> Well, you could try moving devices around in diff

Re: [Qemu-devel] [Patch v1 1/8] stm32f205_timer: Add the stm32f205 Timer

2014-09-15 Thread Peter Crosthwaite
On Sun, Sep 14, 2014 at 6:18 PM, Alistair Francis wrote: > This patch adds the stm32f205 timers: TIM2, TIM3, TIM4 and TIM5 > to QEMU. > > Signed-off-by: Alistair Francis > --- > Changes from RFC: > - Small changes to functionality and style. Thanks to Peter C > - Rename to make the timer more g

[Qemu-devel] [PATCH v2 00/14] TCG ppc speedups

2014-09-15 Thread Paolo Bonzini
Patches 1-3 speed up softmmu emulation by avoiding TLB flushes on changes to IR/DR. Patches 4-14 speed up emulation in general by rewriting the handling of condition registers. Paolo Bonzini (14): ppc: do not look at the MMU index to detect PR/HV mode softmmu: support up to 12 MMU modes tar

[Qemu-devel] [PATCH 03/14] target-ppc: use separate indices for various translation modes

2014-09-15 Thread Paolo Bonzini
PowerPC TCG flushes the TLB on every IR/DR change, which basically means on every user<->kernel context switch. Encode IR/DR in the MMU index. This brings the number of TLB flushes down from ~90 to ~5 for starting up the Debian installer, which is in line with x86 and gives a ~10% perform

[Qemu-devel] [PATCH 02/14] softmmu: support up to 12 MMU modes

2014-09-15 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- include/exec/cpu_ldst.h | 120 ++-- 1 file changed, 117 insertions(+), 3 deletions(-) diff --git a/include/exec/cpu_ldst.h b/include/exec/cpu_ldst.h index e5550e7..a21ae3e 100644 --- a/include/exec/cpu_ldst.h +++ b/incl

[Qemu-devel] [PATCH 01/14] ppc: do not look at the MMU index to detect PR/HV mode

2014-09-15 Thread Paolo Bonzini
The MMU index is an internal detail that should not be needed by the translator (except to generate loads and stores). Look at the MSR directly. Signed-off-by: Paolo Bonzini --- target-ppc/translate.c | 165 +++-- 1 file changed, 77 insertions(+), 88

  1   2   3   >