[Qemu-devel] [Patch v1 1/8] stm32f205_timer: Add the stm32f205 Timer

2014-09-14 Thread Alistair Francis
This patch adds the stm32f205 timers: TIM2, TIM3, TIM4 and TIM5 to QEMU. Signed-off-by: Alistair Francis --- Changes from RFC: - Small changes to functionality and style. Thanks to Peter C - Rename to make the timer more generic - Split the config settings to device level default-configs/arm

[Qemu-devel] [Patch v1 0/8] Netduino 2 Machine Model

2014-09-14 Thread Alistair Francis
This patch series adds the Netduino 2 Machine to QEMU Information on the board is avalible at: http://www.netduino.com/netduino2/specs.htm The git tree can be found at: https://github.com/alistair23/qemu/tree/netduino2.1 This is based on my original patch series to add the Netduino Plus 2 Machin

[Qemu-devel] [Patch v1 2/8] stm32f205_USART: Add the stm32f205 USART Controller

2014-09-14 Thread Alistair Francis
This patch adds the stm32f205 USART controller (UART also uses the same controller). Signed-off-by: Alistair Francis --- Changes from RFC: - Small changes thanks to Peter C - USART now implements QEMU blocking functions - Split the config settings to device level default-configs/arm-softmmu.

[Qemu-devel] [Patch v1 6/8] target_arm: Change the reset values based on the ELF entry

2014-09-14 Thread Alistair Francis
The Netduino 2 machine won't run unless the reset_pc is based on the ELF entry point. Signed-off-by: Alistair Francis --- hw/arm/armv7m.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c index 5e684a0..816b651 100644

[Qemu-devel] [Patch v1 3/8] stm32f205_SYSCFG: Add the stm32f205 SYSCFG

2014-09-14 Thread Alistair Francis
This patch adds the stm32f205 System Configuration Controller. This is used to configure what memory is mapped at address 0 (although that is not supported) as well as configure how the EXTI interrupts work (also not supported at the moment). This device is not required for basic examples, but mor

[Qemu-devel] [Patch v1 4/8] target_arm: Remove memory region init from armv7m_init

2014-09-14 Thread Alistair Francis
This patch moves the memory region init code from the armv7m_init function to the stellaris_init function Signed-off-by: Alistair Francis --- hw/arm/armv7m.c| 15 +-- hw/arm/stellaris.c | 23 +++ 2 files changed, 20 insertions(+), 18 deletions(-) diff --git a

[Qemu-devel] [Patch v1 5/8] target_arm: Parameterise the irq lines for armv7m_init

2014-09-14 Thread Alistair Francis
This patch allows the board to specifiy the number of NVIC interrupt lines when using armv7m_init. Signed-off-by: Alistair Francis --- hw/arm/armv7m.c | 7 --- hw/arm/stellaris.c | 4 +++- include/hw/arm/arm.h | 2 +- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/a

[Qemu-devel] [Patch v1 7/8] stm32f205: Add the stm32f205 SoC

2014-09-14 Thread Alistair Francis
This patch adds the stm32f205 SoC. This will be used by the Netduino 2 to create a machine. Signed-off-by: Alistair Francis --- Changes from RFC: - Small changes thanks to Peter C - Split the config settings to device level default-configs/arm-softmmu.mak | 1 + hw/arm/Makefile.objs

[Qemu-devel] [Patch v1 8/8] netduino2: Add the Netduino 2 Machine

2014-09-14 Thread Alistair Francis
This patch adds the Netduino 2 Machine. This is a Cortex-M3 based machine. Information can be found at: http://www.netduino.com/netduino2/specs.htm Signed-off-by: Alistair Francis --- Changes from RFC: - Remove CPU passthrough hw/arm/Makefile.objs | 1 + hw/arm/netduino2.c | 54 +++

Re: [Qemu-devel] [PATCH RESEND 0/2 V2] Virtual Machine Generation ID

2014-09-14 Thread Paolo Bonzini
Il 14/09/2014 08:25, Gal Hammer ha scritto: > Hi, > > A two parts patch to add a QEmu support for Microsoft's Virtual Machine > Generation ID device. > > The first one add a new ACPI directive which allow to use a 16-bytes > buffer in an ACPI table. This buffer is for storing the VM's UUID. > >

Re: [Qemu-devel] [PATCH 1/2] i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive.

2014-09-14 Thread Paolo Bonzini
Il 14/09/2014 08:25, Gal Hammer ha scritto: > Add a 16-bytes buffer to allow storing a 128-bit UUID value in an > ACPI table. > > Signed-off-by: Gal Hammer > --- > scripts/acpi_extract.py | 23 ++- > 1 file changed, 14 insertions(+), 9 deletions(-) > > diff --git a/scripts/a

Re: [Qemu-devel] [PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.txt

2014-09-14 Thread Michael S. Tsirkin
On Thu, Sep 11, 2014 at 05:09:33PM +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > docs/specs/virtio-gpu.txt | 165 > ++ > 1 file changed, 165 insertions(+) > create mode 100644 docs/specs/virtio-gpu.txt Please don't put this hardw

[Qemu-devel] [Bug 1307225] Re: Running a virtual machine on a Haswell system produces machine check events

2014-09-14 Thread Tobias-leupold
>From Documentation/x86/x86_64/boot-options.txt: mce=bootlog Enable logging of machine checks left over from booting. Disabled by default on AMD because some BIOS leave bogus ones. If your BIOS doesn't do that it's a good idea to enable though to make sure you lo

[Qemu-devel] [PATCH v1] async: aio_context_new(): Handle event_notifier_init failure

2014-09-14 Thread Chrysostomos Nanakos
If event_notifier_init fails QEMU exits without printing any error information to the user. This commit adds an error message on failure: # qemu [...] qemu: event_notifier_init failed: Too many open files in system qemu: qemu_init_main_loop failed Signed-off-by: Chrysostomos Nanakos --- asyn

[Qemu-devel] [PATCH v1] async: aio_context_new(): Handle event_notifier_init failure

2014-09-14 Thread Chrysostomos Nanakos
Chrysostomos Nanakos (1): async: aio_context_new(): Handle event_notifier_init failure async.c | 19 +-- include/block/aio.h |2 +- include/qemu/main-loop.h |2 +- iothread.c | 12 +++- main-loop.c | 11

Re: [Qemu-devel] [PATCH v5] virtio-pci: enable bus master for old guests

2014-09-14 Thread Michael S. Tsirkin
On Thu, Sep 11, 2014 at 08:42:06PM +0200, Greg Kurz wrote: > On Thu, 11 Sep 2014 21:20:03 +0300 > "Michael S. Tsirkin" wrote: > > > commit cc943c36faa192cd4b32af8fe5edb31894017d35 > > pci: Use bus master address space for delivering MSI/MSI-X messages > > breaks virtio-net for rhel6.[56] x86

Re: [Qemu-devel] [PATCH RESEND 0/2 V2] Virtual Machine Generation ID

2014-09-14 Thread Gal Hammer
On 14/09/2014 11:48, Paolo Bonzini wrote: Il 14/09/2014 08:25, Gal Hammer ha scritto: Hi, A two parts patch to add a QEmu support for Microsoft's Virtual Machine Generation ID device. The first one add a new ACPI directive which allow to use a 16-bytes buffer in an ACPI table. This buffer is f

[Qemu-devel] Enable floating point support in qemu-system-aarch64

2014-09-14 Thread Semion Prihodko
Hi guys, Please explain me how to enable floating point and SIMD support in qemu-system-aarch64 (ver.2.1.0). My code is booting and working correctly before calling variadic function (with empty body), and then crashes. Here is the code of the problematic function: 0: d102c3ff sub sp, sp, #0xb

Re: [Qemu-devel] [virtio-dev] Re: [PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.txt

2014-09-14 Thread Dave Airlie
On 14 September 2014 19:16, Michael S. Tsirkin wrote: > On Thu, Sep 11, 2014 at 05:09:33PM +0200, Gerd Hoffmann wrote: >> Signed-off-by: Gerd Hoffmann >> --- >> docs/specs/virtio-gpu.txt | 165 >> ++ >> 1 file changed, 165 insertions(+) >> create mod

[Qemu-devel] [PATCH V2] image-fuzzer: Trivial readability and formatting improvements

2014-09-14 Thread Maria Kustova
Signed-off-by: Maria Kustova --- v1 -> v2: * Simplified format of test result strings (based on the review of Fam Zheng and Markus Armbruster). * Reverted signature of the 'fuzz.selector()' function (based on the review of Stefan Hajnoczi). tests/image-fuzzer/qcow2/fuzz.py | 11 - tests

Re: [Qemu-devel] [PATCH 0/2] image-fuzzer: Extend test coverage

2014-09-14 Thread M.Kustova
On Thu, Aug 28, 2014 at 9:25 PM, M.Kustova wrote: > ping > ping > http://patchwork.ozlabs.org/patch/381137 > http://patchwork.ozlabs.org/patch/381138 > > On Tue, Aug 19, 2014 at 1:38 AM, Maria Kustova wrote: >> This patch series contains changes improving test coverage. >> >> Maria Kustova (2):

Re: [Qemu-devel] [PATCH RESEND 0/2 V2] Virtual Machine Generation ID

2014-09-14 Thread Paolo Bonzini
Il 14/09/2014 12:51, Gal Hammer ha scritto: >> >> I think because of this, it is a bit simpler to add the device >> optionally to the SSDT, similar to how the TPM is handled. > > Back to SSDT? Didn't you say something about migration issues that > prevent me from using SSDT because the table's dat

Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-14 Thread Michael S. Tsirkin
On Fri, Sep 12, 2014 at 12:44:56PM +0200, Gerd Hoffmann wrote: > Hi, > > > > @@ -0,0 +1,158 @@ > > > +#ifndef VIRTGPU_HW_H > > > +#define VIRTGPU_HW_H > > > > Non-trivial file, deserves a copyright and license notice. > > Added. Pls remember to make it consistent with other virtio headers, wh

Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-14 Thread Peter Maydell
On 14 September 2014 06:46, Michael S. Tsirkin wrote: > BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in QEMU. > You have to stick it in a C file though, so it > won't be visible in this patch. Why do you think that? We have several header files which use QEMU_BUILD_BUG_ON and I don't see any reason w

Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-14 Thread Michael S. Tsirkin
On Sun, Sep 14, 2014 at 07:04:11AM -0700, Peter Maydell wrote: > On 14 September 2014 06:46, Michael S. Tsirkin wrote: > > BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in QEMU. > > You have to stick it in a C file though, so it > > won't be visible in this patch. > > Why do you think that? We have se

Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-14 Thread Peter Maydell
On 14 September 2014 07:11, Michael S. Tsirkin wrote: > On Sun, Sep 14, 2014 at 07:04:11AM -0700, Peter Maydell wrote: >> On 14 September 2014 06:46, Michael S. Tsirkin wrote: >> > BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in QEMU. >> > You have to stick it in a C file though, so it >> > won't be

Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-14 Thread Michael S. Tsirkin
On Sun, Sep 14, 2014 at 07:32:21AM -0700, Peter Maydell wrote: > On 14 September 2014 07:11, Michael S. Tsirkin wrote: > > On Sun, Sep 14, 2014 at 07:04:11AM -0700, Peter Maydell wrote: > >> On 14 September 2014 06:46, Michael S. Tsirkin wrote: > >> > BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in Q

Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-14 Thread Peter Maydell
On 14 September 2014 08:09, Michael S. Tsirkin wrote: > On Sun, Sep 14, 2014 at 07:32:21AM -0700, Peter Maydell wrote: >> Who owns the "master" copy of the header and commits >> to making sure it builds on other things than Linux+gcc >> in that case? > For most of virtio neither linux nor QEMU ar

Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-14 Thread Michael S. Tsirkin
On Sun, Sep 14, 2014 at 09:11:45AM -0700, Peter Maydell wrote: > On 14 September 2014 08:09, Michael S. Tsirkin wrote: > > On Sun, Sep 14, 2014 at 07:32:21AM -0700, Peter Maydell wrote: > >> Who owns the "master" copy of the header and commits > >> to making sure it builds on other things than Lin

Re: [Qemu-devel] [RFC] Use of host vector operations in host helper functions

2014-09-14 Thread Alex Bennée
Richard Henderson writes: > Most of the time, guest vector operations are rare enough that it doesn't > really matter that we implement them with a loop around integer operations. > > But for target-alpha, there's one vector comparison operation that appears in > every guest string operation, and

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-14 Thread Michael S. Tsirkin
On Tue, Sep 09, 2014 at 02:35:02PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > virtio-net-pci, virtio-net-s390, and virtio-net-ccw all duplicate the > qdev properties of their VirtIONet child. This approach does not work > well with string or pointer properties since we must be care

[Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-09-14 Thread Michael S. Tsirkin
Current support for bus master (clearing OK bit) together with the need to support guests which do not enable PCI bus mastering, leads to extra state in VIRTIO_PCI_FLAG_BUS_MASTER_BUG bit, which isn't robust in case of cross-version migration for the case when guests use the device before setting D

Re: [Qemu-devel] [PATCH 20/23] target-lm32: Use cpu_exec_interrupt qom hook

2014-09-14 Thread Michael Walle
Am Samstag, 13. September 2014, 09:45:31 schrieb Richard Henderson: > Cc: Michael Walle > Signed-off-by: Richard Henderson Acked-by: Michael Walle > --- > cpu-exec.c| 7 --- > target-lm32/cpu-qom.h | 1 + > target-lm32/cpu.c | 1 + > target-lm32/helper.c | 13 +

[Qemu-devel] [PULL 00/12] pci, pc, virtio, misc bugfixes

2014-09-14 Thread Michael S. Tsirkin
The following changes since commit 4c24f4004089a308c5de8ed720cf6bd1746aedd8: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20140912' into staging (2014-09-12 15:12:26 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags

[Qemu-devel] [PULL 03/12] test-qdev-global-props: Run tests on subprocess

2014-09-14 Thread Michael S. Tsirkin
From: Eduardo Habkost There are multiple reasons for running the global property tests on a subprocess: * We need the global_props lists to be empty for each test case, so global properties from the previous test won't affect the next one; * We don't want the qdev_prop_check_global() warnings

[Qemu-devel] [PULL 04/12] test-qdev-global-props: Initialize not_used=true for all props

2014-09-14 Thread Michael S. Tsirkin
From: Eduardo Habkost This will ensure we are actually testing the code which sets not_used=false when the property is used. Signed-off-by: Eduardo Habkost Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/test-qdev-global-props.c | 7 +-- 1 file changed, 5 inserti

[Qemu-devel] [PULL 02/12] test-qdev-global-props: Trivial comment fix

2014-09-14 Thread Michael S. Tsirkin
From: Eduardo Habkost Signed-off-by: Eduardo Habkost Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/test-qdev-global-props.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test-qdev-global-props.c b/tests/test-qdev-global-props.c index 2bef

[Qemu-devel] [PULL 01/12] hw/machine: Free old values of string properties

2014-09-14 Thread Michael S. Tsirkin
From: Eduardo Habkost Reviewed-by: Markus Armbruster Reviewed-by: Marcel Apfelbaum Signed-off-by: Eduardo Habkost Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Amos Kong Cc: qemu-sta...@nongnu.org --- hw/core/machine.c | 8 1 file changed, 8 insertion

[Qemu-devel] [PULL 05/12] test-qdev-global-props: Test handling of hotpluggable and non-device types

2014-09-14 Thread Michael S. Tsirkin
From: Eduardo Habkost Ensure no warning will be printed for hotpluggable types, and warnings will be printed for non-device types. Signed-off-by: Eduardo Habkost Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/test-qdev-global-props.c | 55 +++

[Qemu-devel] [PULL 07/12] qdev: Move global validation to a single function

2014-09-14 Thread Michael S. Tsirkin
From: Eduardo Habkost Currently GlobalProperty.not_used=false has multiple meanings: * It may be a property for a hotpluggable device, which may or may not have been used by a device; * It may be a machine-type-provided property, which may or may not have been used by a device. * It may be a

[Qemu-devel] [PULL 09/12] virtio-net: drop assert on vm stop

2014-09-14 Thread Michael S. Tsirkin
On vm stop, vm_running state set to stopped before device is notified, so callbacks can get envoked with vm_running = false; and this is not an error. Cc: qemu-sta...@nongnu.org Acked-by: Jason Wang Signed-off-by: Michael S. Tsirkin --- hw/net/virtio-net.c | 2 -- 1 file changed, 2 deletions(-)

[Qemu-devel] [PULL 06/12] qdev: Rename qdev_prop_check_global() to qdev_prop_check_globals()

2014-09-14 Thread Michael S. Tsirkin
From: Eduardo Habkost Signed-off-by: Eduardo Habkost Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/qdev-properties.h | 2 +- hw/core/qdev-properties.c | 2 +- tests/test-qdev-global-props.c | 2 +- vl.c | 2 +- 4 files changed,

[Qemu-devel] [PULL 12/12] vhost-user: fix VIRTIO_NET_F_MRG_RXBUF negotiation

2014-09-14 Thread Michael S. Tsirkin
From: Damjan Marion Header length check should happen only if backend is kernel. For user backend there is no reason to reset this bit. vhost-user code does not define .has_vnet_hdr_len so VIRTIO_NET_F_MRG_RXBUF cannot be negotiated even if both sides support it. Signed-off-by: Damjan Marion R

[Qemu-devel] [PULL 10/12] Revert "virtio: don't call device on !vm_running"

2014-09-14 Thread Michael S. Tsirkin
This reverts commit a1bc7b827e422e1ff065640d8ec5347c4aadfcd8. virtio: don't call device on !vm_running It turns out that virtio net assumes that vm_running is updated before device status callback in many places, so this change leads to asserts. Previous commit fixes the root issue that motivat

[Qemu-devel] [PULL 08/12] Revert "rng-egd: remove redundant free"

2014-09-14 Thread Michael S. Tsirkin
From: Eduardo Habkost This reverts commit 5e490b6a504912225dff0e520e1c6af68295d238. Cc: qemu-sta...@nongnu.org Reviewed-by: Markus Armbruster Signed-off-by: Eduardo Habkost Signed-off-by: Michael S. Tsirkin --- backends/rng-egd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/backends/r

[Qemu-devel] [PULL 11/12] virtio-pci: enable bus master for old guests

2014-09-14 Thread Michael S. Tsirkin
commit cc943c36faa192cd4b32af8fe5edb31894017d35 pci: Use bus master address space for delivering MSI/MSI-X messages breaks virtio-net for rhel6.[56] x86 guests because they don't enable bus mastering for virtio PCI devices. For the same reason, rhel6.[56] ppc64 guests cannot boot on a virtio-bl

[Qemu-devel] Big Endian qemu_pixelformat_from_pixman and qemu_default_pixman_format

2014-09-14 Thread Valentin Manea
Hi Gerd, I'm working on improving the OpenRISC support for QEMU and recently I got in one problem with qemu_pixelformat_from_pixman(). It seems quite recently the ui/console.c code has started using it for big endian as well but the new change breaks my existing framebuffer patches. The proble

[Qemu-devel] [PATCH] block/vhdx.c: Mark parent_vhdx_guid variable as unused

2014-09-14 Thread Peter Maydell
The parent_vhdx_guid variable is defined but never used, which provokes complaints from newer versions of clang. Since the variable definition is here acting as documentation of the image format, mark it with the 'unused' attribute to keep the compiler happy rather than simply deleting it. Signed-

[Qemu-devel] [PATCH 0/4] ARM: delete unused functions/variables from misc devices

2014-09-14 Thread Peter Maydell
This patch series is another in my sporadic efforts to get us down to zero warnings with clang 3.4. It deletes a collection of unused functions and variables which clang complains about (it's a bit pickier than gcc, especially about "static inline" functions in .c files). Peter Maydell (4): hw/d

Re: [Qemu-devel] [PATCH 01/23] qom: Add cpu_exec_enter and cpu_exec_exit hooks

2014-09-14 Thread Alex Bennée
Richard Henderson writes: > In preparation for removing a bunch of ifdefs from cpu_exec. > > Cc: Andreas Färber > Signed-off-by: Richard Henderson > --- > cpu-exec.c| 9 ++--- > include/qom/cpu.h | 5 + > qom/cpu.c | 6 -- > 3 files changed, 11 insertions(+), 9 dele

[Qemu-devel] [PATCH] target-xtensa: mark XtensaConfig structs as unused

2014-09-14 Thread Peter Maydell
The XtensaConfig structs will be defined but not used if they are for the opposite endianness from that of the binary being built; keep the compiler from complaining about this by marking them with the 'unused' attribute. Signed-off-by: Peter Maydell --- This works, although it's a tad ugly. If a

Re: [Qemu-devel] [PATCH 02/23] cpu-exec: Remove do-nothing ifdef chains

2014-09-14 Thread Alex Bennée
Richard Henderson writes: > Around the cpu_exec_enter/exit hooks contain many empty > ifdef blocks. Delete all of these to highlight those > targets for which we actually need to do work. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > cpu-exec.c | 32 -

[Qemu-devel] [PATCH 2/4] hw/intc/imx_avic.c: Remove unused function imx_avic_set_prio()

2014-09-14 Thread Peter Maydell
The function imx_avic_set_prio() is unused; delete it. Signed-off-by: Peter Maydell --- hw/intc/imx_avic.c | 9 - 1 file changed, 9 deletions(-) diff --git a/hw/intc/imx_avic.c b/hw/intc/imx_avic.c index ec5f9ad..e48f66c 100644 --- a/hw/intc/imx_avic.c +++ b/hw/intc/imx_avic.c @@ -97,15

[Qemu-devel] [PATCH 1/4] hw/display/blizzard.c: Delete unused function blizzard_rgb2yuv

2014-09-14 Thread Peter Maydell
The function blizzard_rgb2yuv() is unused; delete it. Signed-off-by: Peter Maydell --- hw/display/blizzard.c | 8 1 file changed, 8 deletions(-) diff --git a/hw/display/blizzard.c b/hw/display/blizzard.c index 55c0ddf..92b1fac 100644 --- a/hw/display/blizzard.c +++ b/hw/display/blizzar

[Qemu-devel] [PATCH] hw/pci/ppc4xx_pci.c: Remove unused pci4xx_cfgaddr_read/write/ops

2014-09-14 Thread Peter Maydell
The MemoryRegionOps struct pci4xx_cfgaddr_ops and the read and write functions it references are all unused; remove them. Signed-off-by: Peter Maydell --- This is rather applying a blunt instrument to the code -- maybe the ops should be used for something instead? (cf the comment about splitting

[Qemu-devel] [PATCH 3/4] hw/display/pxa2xx_lcd.c: Remove unused function pxa2xx_dma_rdst_set

2014-09-14 Thread Peter Maydell
The function pxa2xx_dma_rdst_set() is unused; delete it. Signed-off-by: Peter Maydell --- hw/display/pxa2xx_lcd.c | 8 1 file changed, 8 deletions(-) diff --git a/hw/display/pxa2xx_lcd.c b/hw/display/pxa2xx_lcd.c index 611fb17..ac3c018 100644 --- a/hw/display/pxa2xx_lcd.c +++ b/hw/disp

Re: [Qemu-devel] [PATCH 03/23] target-i386: Use cpu_exec_enter/exit qom hooks

2014-09-14 Thread Alex Bennée
Richard Henderson writes: > Note that the code that was within the "exit" ifdef block > was identical to the cpu_compute_eflags inline, so make that > simplification at the same time. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > cpu-exec.c| 14 ++-

Re: [Qemu-devel] [PATCH 04/23] target-m68k: Use cpu_exec_enter/exit qom hooks

2014-09-14 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson > --- > +void m68k_cpu_exec_enter(CPUState *cs) > +{ > +M68kCPU *cpu = M68K_CPU(cs); > +CPUM68KState *env = &cpu->env; > + > +env->cc_op = CC_OP_FLAGS; > +env->cc_dest = env->sr & 0xf; > +env->cc_x = (env->sr >> 4)

Re: [Qemu-devel] [PATCH 05/23] target-ppc: Use cpu_exec_enter qom hook

2014-09-14 Thread Alex Bennée
Richard Henderson writes: > Cc: qemu-...@nongnu.org > Signed-off-by: Richard Henderson > +static void ppc_cpu_exec_enter(CPUState *cs) > +{ > +PowerPCCPU *cpu = POWERPC_CPU(cs); > +CPUPPCState *env = &cpu->env; > + Ok the naming of those structures and the order to traverse them gets c

[Qemu-devel] [PATCH 4/5] target-mips/dsp_helper.c: Remove unused function get_DSPControl_24()

2014-09-14 Thread Peter Maydell
The function get_DSPControl_24() is unused; remove it. Signed-off-by: Peter Maydell --- target-mips/dsp_helper.c | 9 - 1 file changed, 9 deletions(-) diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c index 09fb470..349f2a0 100644 --- a/target-mips/dsp_helper.c +++ b/targ

[Qemu-devel] [PATCH 5/5] target-mips/op_helper.c: Remove unused do_lbu() function

2014-09-14 Thread Peter Maydell
The do_lbu() function defined by the expansion of HELPER_LD() is never used, so don't define it. Signed-off-by: Peter Maydell --- target-mips/op_helper.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c index df97b35..66aedc1 100644 --- a/targe

[Qemu-devel] [PATCH 0/5] target-mips: Fix unused-function warnings

2014-09-14 Thread Peter Maydell
These patches fix a number of warnings in target-mips code that clang produces; notably, clang will complain about unused 'static inline' functions in .c files where gcc does not. Some are genuinely totally unused; a few are unused only in some configs and so we add ifdef guards. (I've actually ha

[Qemu-devel] [PATCH 2/5] target-mips/translate.c: Add ifdef guard around check_mips64()

2014-09-14 Thread Peter Maydell
The function check_mips64() is only used if TARGET_MIPS64 is defined; add an ifdef guard to its definition to avoid warnings about it being unused in other configurations. Signed-off-by: Peter Maydell --- target-mips/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target-mips/t

[Qemu-devel] [PATCH 3/5] target-mips/dsp_helper.c: Add ifdef guards around various functions

2014-09-14 Thread Peter Maydell
Add ifdef TARGET_MIPS64 guards around various functions that are only called from helpers for TARGET_MIPS64 CPUs; this avoids compiler warnings when building other configs. Signed-off-by: Peter Maydell --- target-mips/dsp_helper.c | 17 - 1 file changed, 16 insertions(+), 1 delet

[Qemu-devel] [PATCH 4/4] hw/input/tsc210x.c: Delete unused array tsc2101_rates

2014-09-14 Thread Peter Maydell
The array tsc2101_rates[] is unused (and we don't implement the TSC2101 anyway, only the 2102); delete it. Signed-off-by: Peter Maydell --- hw/input/tsc210x.c | 30 -- 1 file changed, 30 deletions(-) diff --git a/hw/input/tsc210x.c b/hw/input/tsc210x.c index aa5b688.

[Qemu-devel] [PATCH 1/5] target-mips: Remove unused gen_load_ACX, gen_store_ACX and cpu_ACX

2014-09-14 Thread Peter Maydell
Remove the functions gen_load_ACX and gen_store_ACX, which appear to have been unused since they were first introduced many years ago. These functions were the only places using the cpu_ACX[] array of TCG globals, so remove that and its accompanying regnames_ACX[] as well. Signed-off-by: Peter May

Re: [Qemu-devel] [PATCH] target-xtensa: mark XtensaConfig structs as unused

2014-09-14 Thread Max Filippov
On Sun, Sep 14, 2014 at 12:36 PM, Peter Maydell wrote: > The XtensaConfig structs will be defined but not used if they are > for the opposite endianness from that of the binary being built; > keep the compiler from complaining about this by marking them > with the 'unused' attribute. > > Signed-of

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2014-09-14 Thread Michael Steffens
The affected code was introduced with version 1.2.0. However, due to https://bugs.launchpad.net/qemu/+bug/1193628 I can't build these old releases to verify whether they actually expose the same behaviour. -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-14 Thread Gonglei (Arei)
> On Tue, Sep 09, 2014 at 02:35:02PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > virtio-net-pci, virtio-net-s390, and virtio-net-ccw all duplicate the > > qdev properties of their VirtIONet child. This approach does not work > > well with string or pointer properties since we m

Re: [Qemu-devel] [PATCH 05/23] target-ppc: Use cpu_exec_enter qom hook

2014-09-14 Thread Peter Maydell
On 14 September 2014 12:43, Alex Bennée wrote: > > Richard Henderson writes: > >> Cc: qemu-...@nongnu.org >> Signed-off-by: Richard Henderson > >> +static void ppc_cpu_exec_enter(CPUState *cs) >> +{ >> +PowerPCCPU *cpu = POWERPC_CPU(cs); >> +CPUPPCState *env = &cpu->env; >> + > > Ok the

Re: [Qemu-devel] [PATCH 10/10] aio-win32: add support for sockets

2014-09-14 Thread TeLeMan
On Sat, Sep 13, 2014 at 6:33 PM, Paolo Bonzini wrote: > Il 13/09/2014 04:22, TeLeMan ha scritto: >> On Fri, Sep 12, 2014 at 6:05 PM, Paolo Bonzini wrote: >>> Il 12/09/2014 03:39, TeLeMan ha scritto: On Wed, Jul 9, 2014 at 5:53 PM, Paolo Bonzini wrote: > diff --git a/aio-win32.c b/aio-wi

[Qemu-devel] [Bug 1369347] [NEW] Mac OS X cannot passthrough USB device to guest

2014-09-14 Thread Aaron
Public bug reported: I'm using Mac OS 10.9.4 with qemu-system-arm installed from brew (version 1.7.1) and verified with qemu-system-x86_64. I'm trying to pass a Ralink 5370 WiFi USB dongle to my guest system, it appears in my system profiler as: 802.11 n WLAN: Product ID: 0x5370 Vendor ID:

Re: [Qemu-devel] BB name vs. BDS name in the QAPI schema

2014-09-14 Thread Fam Zheng
On Sat, 09/13 19:04, Markus Armbruster wrote: > > I actually like having separate parameters for separate kinds of names. > > However, BlockdevRef appears to tie our hand: it's an anonymous union, > which means only the value is on the wire, and the receiving end uses > its type to determine wh

Re: [Qemu-devel] [PATCH] block/vhdx.c: Mark parent_vhdx_guid variable as unused

2014-09-14 Thread Fam Zheng
On Sun, 09/14 20:29, Peter Maydell wrote: > The parent_vhdx_guid variable is defined but never used, which provokes > complaints from newer versions of clang. Since the variable definition > is here acting as documentation of the image format, mark it with the > 'unused' attribute to keep the compi

[Qemu-devel] [PATCH] configure: check for pixman-1 version

2014-09-14 Thread Hu Tao
commit a93a3af9 introduces use of PIXMAN_TYPE_RGBA, but it's only available in pixman >= 0.21.8. If pixman doesn't meet the version requirement, qemu will fail to build with following message: /home/hutao/qemu/ui/qemu-pixman.c: In function ‘qemu_pixelformat_from_pixman’: /home/hutao/qemu/ui/qemu-p

Re: [Qemu-devel] [Bug 1368791] [NEW] qemu build fails on Ubuntu 10.04 LTS since recent pixman changes

2014-09-14 Thread Hu Tao
On Fri, Sep 12, 2014 at 02:19:44PM +, Andreas Gustafsson wrote: > Public bug reported: > > Since commit 0dfa7e30126364c434a48cb37a1a41119e536c2a, the qemu git > mainline no longer builds on Ubuntu 10.04 LTS. The build fails with: > > CCui/input.o > ui/qemu-pixman.c: In function 'qemu_p

Re: [Qemu-devel] [PATCH] configure: check for pixman-1 version

2014-09-14 Thread Peter Maydell
On 14 September 2014 18:53, Hu Tao wrote: > commit a93a3af9 introduces use of PIXMAN_TYPE_RGBA, but it's only available > in pixman >= 0.21.8. If pixman doesn't meet the version requirement, qemu > will fail to build with following message: > > /home/hutao/qemu/ui/qemu-pixman.c: In function ‘qemu_

Re: [Qemu-devel] [PATCH] vmdk: Fix integer overflow in offset calculation

2014-09-14 Thread Fam Zheng
On Sat, 09/13 20:01, Max Reitz wrote: > On 12.09.2014 11:51, Fam Zheng wrote: > >This fixes the bug introduced by commit c6ac36e (vmdk: Optimize cluster > >allocation). > > > >$ ~/build/master/qemu-io /stor/vm/arch.vmdk -c 'write 2G 1k' > >write failed: Invalid argument > > > >Reported-by: Mark Cav

Re: [Qemu-devel] [Bug 1369347] [NEW] Mac OS X cannot passthrough USB device to guest

2014-09-14 Thread Peter Maydell
On 14 September 2014 15:23, Aaron wrote: > Public bug reported: > > I'm using Mac OS 10.9.4 with qemu-system-arm installed from brew > (version 1.7.1) and verified with qemu-system-x86_64. I'm trying to pass > a Ralink 5370 WiFi USB dongle to my guest system, it appears in my > system profiler as:

[Qemu-devel] [PATCH v2] vmdk: Fix integer overflow in offset calculation

2014-09-14 Thread Fam Zheng
This fixes the bug introduced by commit c6ac36e (vmdk: Optimize cluster allocation). $ ~/build/master/qemu-io /stor/vm/arch.vmdk -c 'write 2G 1k' write failed: Invalid argument Reported-by: Mark Cave-Ayland Signed-off-by: Fam Zheng --- block/vmdk.c | 2 +- tests/qemu-iotests/005

Re: [Qemu-devel] [PATCH] aio-win32: fix uninitialized use of have_select_revents

2014-09-14 Thread Fam Zheng
On Fri, 09/12 12:08, Paolo Bonzini wrote: > Always initialize it with the return value of aio_prepare. > > Reported-by: TeLeMan > Signed-off-by: Paolo Bonzini > --- > aio-win32.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/aio-win32.c b/aio-win32.c > index 61e3

Re: [Qemu-devel] [PATCH] configure: check for pixman-1 version

2014-09-14 Thread Hu Tao
On Sun, Sep 14, 2014 at 07:23:20PM -0700, Peter Maydell wrote: > On 14 September 2014 18:53, Hu Tao wrote: > > commit a93a3af9 introduces use of PIXMAN_TYPE_RGBA, but it's only available > > in pixman >= 0.21.8. If pixman doesn't meet the version requirement, qemu > > will fail to build with follo

Re: [Qemu-devel] [PATCH] configure: check for pixman-1 version

2014-09-14 Thread Hu Tao
CCed Paolo On Mon, Sep 15, 2014 at 10:41:09AM +0800, Hu Tao wrote: > On Sun, Sep 14, 2014 at 07:23:20PM -0700, Peter Maydell wrote: > > On 14 September 2014 18:53, Hu Tao wrote: > > > commit a93a3af9 introduces use of PIXMAN_TYPE_RGBA, but it's only > > > available > > > in pixman >= 0.21.8. If

[Qemu-devel] [PATCH v2 1/2] pixman: update internal copy to pixman-0.32.6

2014-09-14 Thread Hu Tao
commit a93a3af9 introduces use of PIXMAN_TYPE_RGBA, but it's only available in pixman >= 0.21.8. Although commit f27b2e1d bumped pixman to pixman-0.28.2, but the change was reverted later by 7b1b5d19. This patch updates internal copy of pixman to pixman-0.32.6 to fix the problem. Signed-off-by: H

[Qemu-devel] [PATCH v2 0/2] fix building failure with pixman

2014-09-14 Thread Hu Tao
commit a93a3af9 introduces use of PIXMAN_TYPE_RGBA, but it's only available in pixman >= 0.21.8. If pixman doesn't meet the version requirement, qemu will fail to build with following message: qemu/ui/qemu-pixman.c: In function ‘qemu_pixelformat_from_pixman’: qemu/ui/qemu-pixman.c:42: error: ‘PIXM

[Qemu-devel] [PATCH v2 2/2] configure: check for pixman-1 version

2014-09-14 Thread Hu Tao
commit a93a3af9 introduces use of PIXMAN_TYPE_RGBA, but it's only available in pixman >= 0.21.8. If pixman doesn't meet the version requirement, qemu will fail to build with following message: qemu/ui/qemu-pixman.c: In function ‘qemu_pixelformat_from_pixman’: qemu/ui/qemu-pixman.c:42: error: ‘PIXM

[Qemu-devel] [PATCH v2 RESEND] Add skip_dump flag to ignore memory region during dump

2014-09-14 Thread Nikunj A Dadhania
The PCI MMIO might be disabled or the device in the reset state. Make sure we do not dump these memory regions. Signed-off-by: Nikunj A Dadhania Acked-by: Alex Williamson CC: Paolo Bonzini --- Resending, missed to CC Paolo V1: * Make the flag generic in place of using vfio_mmap (Alex) h

Re: [Qemu-devel] [PATCH 4/5] pc: add cpu hotplug handler to PC_MACHINE

2014-09-14 Thread Gu Zheng
Hi Igor, On 09/12/2014 10:28 PM, Igor Mammedov wrote: > On Fri, 12 Sep 2014 11:02:09 +0800 > Gu Zheng wrote: > >> Hi Igor, >> On 09/10/2014 09:55 PM, Igor Mammedov wrote: >> >>> On Wed, 3 Sep 2014 17:06:16 +0800 >>> Gu Zheng wrote: >>> Add cpu hotplug handler to PC_MACHINE, which will pe

Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects

2014-09-14 Thread Gu Zheng
Hi Igor, On 09/12/2014 10:15 PM, Igor Mammedov wrote: > On Thu, 28 Aug 2014 11:36:42 +0800 > Gu Zheng wrote: > >> After ACPI get a signal to eject a vCPU, the vCPU must be >> removed from CPU list,before the vCPU really removed, then >> release the all related vCPU objects. >> But we do not clo

[Qemu-devel] [PATCH v2 1/2] scsi: Optimize scsi_req_alloc

2014-09-14 Thread Fam Zheng
Zeroing sense buffer for each scsi request is not efficient, we can just leave it uninitialized because sense_len is set to 0. Move the implicitly zeroed fields to the end of the structure and use a partial memset. The explicitly initialized fields (by scsi_req_alloc or scsi_req_new) are moved to

[Qemu-devel] [PATCH v2 0/2] virtio-scsi: Optimizing request allocation

2014-09-14 Thread Fam Zheng
v2: Slight improvements according to Paolo's comments. 4k -> 48k. Zeroing is relatively expensive since we have big request structures. VirtQueueElement (>48k!) and sense_buf (256 bytes) are two points to look at. This visibly reduces overhead of request handling when testing with the unmerge

[Qemu-devel] [PATCH v2 2/2] virtio-scsi: Optimize virtio_scsi_init_req

2014-09-14 Thread Fam Zheng
The VirtQueueElement is a very big structure (>48k!), since it will be initialzed by virtqueue_pop, we can save the expensive zeroing here. This saves a few microseconds per request in my test: [fio-test] rw bs iodepthjobs bw iops latency

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-14 Thread Michael S. Tsirkin
On Mon, Sep 15, 2014 at 01:03:24AM +, Gonglei (Arei) wrote: > > > diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c > > > index ddb5da1..6722156 100644 > > > --- a/hw/virtio/virtio-pci.c > > > +++ b/hw/virtio/virtio-pci.c > > > @@ -1414,8 +1414,6 @@ static Property virtio_net_propert

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-14 Thread Gonglei (Arei)
> From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Monday, September 15, 2014 1:36 PM > Subject: Re: [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev > properties > > On Mon, Sep 15, 2014 at 01:03:24AM +, Gonglei (Arei) wrote: > > > > diff --git a/hw/virtio/virtio-pci.

Re: [Qemu-devel] ui causes latest master build failure on rhel6

2014-09-14 Thread Gerd Hoffmann
On Fr, 2014-09-12 at 15:58 +0100, Peter Maydell wrote: > On 11 September 2014 16:21, Gerd Hoffmann wrote: > > pixman-0.21.8 is the oldest release which has PIXMAN_TYPE_RGBA. > > We don't check for a minimum version. > > RHEL-6 is probably older. > > Ubuntu LTS hits this too. > > > Try 'configure

Re: [Qemu-devel] [PATCH v2 1/2] pixman: update internal copy to pixman-0.32.6

2014-09-14 Thread Gerd Hoffmann
On Mo, 2014-09-15 at 11:41 +0800, Hu Tao wrote: > commit a93a3af9 introduces use of PIXMAN_TYPE_RGBA, but it's only available > in pixman >= 0.21.8. Although commit f27b2e1d bumped pixman to pixman-0.28.2, > but the change was reverted later by 7b1b5d19. Ah, so my memory wasn't totally wrong, the

[Qemu-devel] [PULL 1/2] pixman: update internal copy to pixman-0.32.6

2014-09-14 Thread Gerd Hoffmann
From: Hu Tao commit a93a3af9 introduces use of PIXMAN_TYPE_RGBA, but it's only available in pixman >= 0.21.8. Although commit f27b2e1d bumped pixman to pixman-0.28.2, but the change was reverted later by 7b1b5d19. This patch updates internal copy of pixman to pixman-0.32.6 to fix the problem. S

Re: [Qemu-devel] [PATCH 2/4] block: Keep DriveInfo alive until BlockDriverState dies

2014-09-14 Thread Markus Armbruster
Markus Armbruster writes: > If the BDS's refcnt > 0, drive_del() destroys the DriveInfo, but not > the BDS. This can happen in three places: > > * Device model destruction during unplug: blockdev_auto_del() > > * Xen IDE unplug: pci_piix3_xen_ide_unplug() > > * drive_del command when no device m

[Qemu-devel] [PULL 0/2] Fix pixman build failure.

2014-09-14 Thread Gerd Hoffmann
Hi, Here comes the pixman upgrade to fix the recent build failures. please pull, Gerd The following changes since commit 0dfa7e30126364c434a48cb37a1a41119e536c2a: Merge remote-tracking branch 'remotes/kraxel/tags/pull-console-20140905-2' into staging (2014-09-11 11:44:17 +0100) are avai

[Qemu-devel] [PULL 2/2] configure: check for pixman-1 version

2014-09-14 Thread Gerd Hoffmann
From: Hu Tao commit a93a3af9 introduces use of PIXMAN_TYPE_RGBA, but it's only available in pixman >= 0.21.8. If pixman doesn't meet the version requirement, qemu will fail to build with following message: qemu/ui/qemu-pixman.c: In function ‘qemu_pixelformat_from_pixman’: qemu/ui/qemu-pixman.c:4

  1   2   >