Scubbing our ppc64 bugs. Thanks for the update Ken, I'll close this.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/965327
Title:
virtio-pci: can't reserve io 0x-0x001f
Status in QEMU:
New
B
On 08/22/2014 10:30 AM, Zhang Haoyu wrote:
> Hi, Krishna, Shirley
>
> How got get the latest patch of M:N Implementation of mulitiqueue,
>
> I am going to test the the combination of "M:N Implementation of mulitiqueue"
> and "vhost: add polling mode".
>
> Thanks,
> Zhang Haoyu
>
>
Just FYI. You
John Snow writes:
> I was running a series of tests on 32 and 64 bit hosts to test for
> endianness and variable width issues when I noticed that I couldn't
> properly perform a build of "make check" against a 32bit target from a
> 64bit host:
>
> ../../configure --cpu=i386 && make -j4 && make ch
On 08/21/2014 08:39 PM, zhanghailiang wrote:
> For all NICs(except virtio-net) emulated by qemu,
> Such as e1000, rtl8139, pcnet and ne2k_pci,
> Qemu can still receive packets when VM is not running.
> If this happened in *migration's* last PAUSE VM stage,
> The new dirty RAM related to the packets
Am 22.08.2014 um 09:35 schrieb Peter Lieven:
> Some code in the block layer makes potentially huge allocations. Failure
> is not completely unexpected there, so avoid aborting qemu and handle
> out-of-memory situations gracefully.
>
> This patch addresses the allocations in the iscsi block driver.
On 22 August 2014 01:10, John Snow wrote:
> I was running a series of tests on 32 and 64 bit hosts to test for
> endianness and variable width issues when I noticed that I couldn't properly
> perform a build of "make check" against a 32bit target from a 64bit host:
>
> ../../configure --cpu=i386 &
On 21 August 2014 19:48, Markus Armbruster wrote:
>
> Doesn't this break migration to/from unfixed versions?
>
It might. It is not something we've tried here, and I'm certainly not
familiar enough with QEMU internals myself to say one way or another. We
encountered this issue in what I can best d
bs->total_sectors is not yet updated at this point. resulting
in memory corruption if the volume has grown and data is written
to the newly availble areas.
CC: qemu-sta...@nongnu.org
Signed-off-by: Peter Lieven
---
block/iscsi.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --
Il 22/08/2014 03:23, Fam Zheng ha scritto:
> What about we save cb and opaque locally, and set acb->cb to a nop. When
> cancel
> is done we can call the original cb?
That might work but needs some auditing. Right now the AIOCB is still
valid when the callback is called, and this would be changed
From: ChenLiang
Mirror buffer is split into two pieces to improve io performance.
In this way, one piece of buffer can read data from source disk
when another one is writing data to dest disk.
previous:
io bandwidth: 41MB/s
migration time: 8min15s
now:
io bandwidth: 67MB/s
migration time: 5min3
On Thu, Aug 21, 2014 at 08:10:54PM -0400, John Snow wrote:
> I was running a series of tests on 32 and 64 bit hosts to test for
> endianness and variable width issues when I noticed that I couldn't properly
> perform a build of "make check" against a 32bit target from a 64bit host:
>
> ../../confi
Handle variable "fd_orig" going out of scope leaks the handle.
Signed-off-by: zhanghailiang
---
linux-user/syscall.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index a50229d..11a48c2 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
Hi,
I'm trying to understand how to add a parameter in tap option.
I currently have a working config for a vm; i.e several interfaces using
multiqueues.
I had a try with:
--- a/qapi-schema.json
+++ b/qapi-schema.json
-2006,6 +2008,7 @@
##
{ 'type': 'NetdevTapOptions',
'data': {
+ '*foo'
On 22 August 2014 09:20, Daniel P. Berrange wrote:
> Distros will install pkg-config .pc files for non-native architectures
> in a different location normally. The supported / recommended way to
> tell pkg-config to look in these alternative dirs is to set the env
> variable PKG_CONFIG_LIBDIR. Th
On Fri, Aug 22, 2014 at 09:28:05AM +0100, Peter Maydell wrote:
> On 22 August 2014 09:20, Daniel P. Berrange wrote:
> > Distros will install pkg-config .pc files for non-native architectures
> > in a different location normally. The supported / recommended way to
> > tell pkg-config to look in the
On 19 Aug 2014, at 16:03, Peter Maydell wrote:
> On 17 August 2014 15:24, Fabian Aggeler wrote:
>> This adds a device model for the PrimeXsys System Controller (SP810)
>> which is present in the Versatile Express motherboards. It is
>> so far read-only but allows to read the SCCTRL register.
>>
Am 22.08.2014 um 09:40 hat Peter Lieven geschrieben:
> Am 22.08.2014 um 09:35 schrieb Peter Lieven:
> > Some code in the block layer makes potentially huge allocations. Failure
> > is not completely unexpected there, so avoid aborting qemu and handle
> > out-of-memory situations gracefully.
> >
> >
> -Original Message-
> From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org
> [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On
> Behalf Of zhanghailiang
> Sent: Friday, August 22, 2014 4:24 PM
> To: qemu-devel@nongnu.org
> Cc: qemu-triv...@nongnu.org; riku.voi...@iki
On 22 August 2014 09:34, Daniel P. Berrange wrote:
> On Fri, Aug 22, 2014 at 09:28:05AM +0100, Peter Maydell wrote:
>> Yes, but this should be done by the i686-w64-mingw32-pkg-config
>> wrapper IMHO. (That's how I have my mingw setup configured,
>> anyway.)
>
> Sure if your distro wants to rebuild
> From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com]
> Sent: Thursday, August 21, 2014 6:31 AM
> To: Fabio Fantoni
> Cc: Ross Philipson; Ian Campbell; Paul Durrant; ke...@koconnor.net;
> Huangweidong (C); Hanweidong (Randy); m...@redhat.com;
> qemu-devel@nongnu.org; xen-de...@lists.xen.org
On 22 August 2014 09:38, Aggeler Fabian wrote:
>
> On 19 Aug 2014, at 16:03, Peter Maydell wrote:
>> Which input signals in the hardware do these properties
>> correspond to? I can't figure out what the mapping is.
>> As far as I can tell from the documentation the bits
>> in SCCTRL are just alw
Il 22/08/2014 04:01, arei.gong...@huawei.com ha scritto:
> From: Gonglei
>
> variables lun and tag had been eliminated, break compiling
> when enable debug switch. Meanwhile traces provide the same
> information with this DPRINTF, so remove it.
>
> Signed-off-by: Gonglei
> ---
> v2:
> - as Pa
Am 22.08.2014 um 10:08 hat Peter Lieven geschrieben:
> bs->total_sectors is not yet updated at this point. resulting
> in memory corruption if the volume has grown and data is written
> to the newly availble areas.
>
> CC: qemu-sta...@nongnu.org
> Signed-off-by: Peter Lieven
Thanks, applied to t
Am 22.08.2014 um 10:42 schrieb Kevin Wolf:
> Am 22.08.2014 um 09:40 hat Peter Lieven geschrieben:
>> Am 22.08.2014 um 09:35 schrieb Peter Lieven:
>>> Some code in the block layer makes potentially huge allocations. Failure
>>> is not completely unexpected there, so avoid aborting qemu and handle
>>
Am 21.08.2014 um 14:44 hat Stefan Hajnoczi geschrieben:
> This series fixes qemu-iotests ./check -nocache -vmdk 059. It also adds a
> dedicated test case for O_DIRECT short reads.
>
> Stefan Hajnoczi (2):
> raw-posix: fix O_DIRECT short reads
> qemu-iotests: add test case 101 for short file I
On Fri, Aug 22, 2014 at 9:20 AM, Daniel P. Berrange wrote:
> On Thu, Aug 21, 2014 at 08:10:54PM -0400, John Snow wrote:
>> I was running a series of tests on 32 and 64 bit hosts to test for
>> endianness and variable width issues when I noticed that I couldn't properly
>> perform a build of "make
Am 22.08.2014 um 06:45 hat Fam Zheng geschrieben:
> Otherwise error_callback_bh will access the already released acb.
>
> Signed-off-by: Fam Zheng
Cc: qemu-sta...@nongnu.org
Thanks, applied to the block branch.
Kevin
Am 21.08.2014 um 14:36 hat Markus Armbruster geschrieben:
> Instead of bdrv_getlength().
>
> Commit 57322b7 did this all over block, but one more bdrv_getlength()
> has crept in since.
>
> Signed-off-by: Markus Armbruster
> ---
> v2: Actually use bdrv_nb_sectors() as advertized [Fam]
> Passes ./
Johny Mattsson writes:
> On 21 August 2014 19:48, Markus Armbruster wrote:
>>
>> Doesn't this break migration to/from unfixed versions?
>>
>
> It might. It is not something we've tried here, and I'm certainly not
> familiar enough with QEMU internals myself to say one way or another. We
> encoun
On 2014/8/22 15:40, Jason Wang wrote:
On 08/21/2014 08:39 PM, zhanghailiang wrote:
For all NICs(except virtio-net) emulated by qemu,
Such as e1000, rtl8139, pcnet and ne2k_pci,
Qemu can still receive packets when VM is not running.
If this happened in *migration's* last PAUSE VM stage,
The new d
From: Bastian Blank
When using mapped mode in 9pfs, readdir implementation
should not return file type in d_type from the host
readdir, instead, it should use the type stored in
the extended attributes. Since d_type is optional
and reading ext attrs for every readdir is expensive,
it should be s
You forgot to cc qemu-devel...
On 22 August 2014 09:52, Valentin Manea wrote:
> Set the IDE MMIO memory type to little endian. The ATA specs identify
> words part of the control commands encoded as little endian.
> While this has no impact on little endian systems, it's required for big
> endian
Signed-off-by: Peter Lieven
---
block/iscsi.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index ed883c3..131357c 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -325,6 +325,19 @@ static bool is_request_lun_aligned(i
regular bitmap_new simply aborts if the memory allocation fails.
bitmap_try_new returns NULL on failure and allows for proper
error handling.
Signed-off-by: Peter Lieven
---
include/qemu/bitmap.h |6 ++
1 file changed, 6 insertions(+)
diff --git a/include/qemu/bitmap.h b/include/qemu/bi
this adds a new helper to handle errors when allocation a bitmap and
also introduces its first user.
Peter Lieven (2):
util: introduce bitmap_try_new
block/iscsi: handle failure on malloc of the allocationmap
block/iscsi.c | 22 +++---
include/qemu/bitmap.h |6 +
On 08/22/2014 05:21 PM, zhanghailiang wrote:
> On 2014/8/22 15:40, Jason Wang wrote:
>> On 08/21/2014 08:39 PM, zhanghailiang wrote:
>>> For all NICs(except virtio-net) emulated by qemu,
>>> Such as e1000, rtl8139, pcnet and ne2k_pci,
>>> Qemu can still receive packets when VM is not running.
>>> I
On Fri, 08/22 10:14, Paolo Bonzini wrote:
> Il 22/08/2014 03:23, Fam Zheng ha scritto:
> > What about we save cb and opaque locally, and set acb->cb to a nop. When
> > cancel
> > is done we can call the original cb?
>
> That might work but needs some auditing. Right now the AIOCB is still
> vali
On Thu, Aug 21, 2014 at 08:14:48AM -0400, Stefan Berger wrote:
> On 08/11/2014 04:33 PM, Stefan Berger wrote:
> >From: Stefan Berger
> >
> >Add an SSDT ACPI table for the TPM device.
> >Add a TCPA table for BIOS logging area when a TPM is being used.
> >
> >The latter follows this spec here:
> >
>
On Wed, Aug 20, 2014 at 11:17:56AM +0800, Jason Wang wrote:
> On 08/19/2014 08:29 PM, Stefan Hajnoczi wrote:
> > On Mon, Aug 18, 2014 at 04:32:42PM +0800, zhanghailiang wrote:
> >> On 2014/8/18 14:55, Jason Wang wrote:
> >>> On 08/18/2014 12:46 PM, zhanghailiang wrote:
> diff --git a/net/net.c
Il 22/08/2014 11:37, Fam Zheng ha scritto:
> Exactly. I'd rather not change the contract then.
>
> Alternatively, we may add a refcnt field to BlockDriverAioCB and grab one
> before
> calling .cancel, so the qemu_aio_release will not free it.
Yes, and I don't exclude that sooner or later we'll h
On Tue, Aug 19, 2014 at 01:50:27PM +0400, M.Kustova wrote:
> On Tue, Aug 19, 2014 at 1:38 PM, Stefan Hajnoczi wrote:
> > On Tue, Aug 19, 2014 at 02:00:24AM +0400, Maria Kustova wrote:
> >> diff --git a/tests/image-fuzzer/qcow2/fuzz.py
> >> b/tests/image-fuzzer/qcow2/fuzz.py
> >> index 6e272c6..c6
Interestingly this does not appear to affect Windows guests on the same
host/bridge as the ESXi guest, as
Windows pads the frames before sending them out. However it does affect
Linux guests on the same host/bridge
from communicating with the ESXi guest itself and the guests ESXi hosts.
--
*View
Grouping (GICv2) and Security Extensions change the behaviour of reads
of the highest priority pending interrupt register (ICCHPIR/GICC_HPPIR).
Signed-off-by: Fabian Aggeler
---
hw/intc/arm_gic.c | 29 -
hw/intc/gic_internal.h | 1 +
2 files changed, 29 insertio
Connect FIQ output of the GIC CPU interfaces to the CPUs.
Signed-off-by: Fabian Aggeler
---
hw/arm/vexpress.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/vexpress.c b/hw/arm/vexpress.c
index a88732c..bafe8d2 100644
--- a/hw/arm/vexpress.c
+++ b/hw/arm/vexpress.c
@@ -229,6 +229,8
GICs with grouping (GICv2 or GICv1 with Security Extensions) have a
different exception generation model which is more complicated than
without interrupt grouping. We add a new function to handle this model.
Signed-off-by: Fabian Aggeler
---
hw/intc/arm_gic.c | 87 ++
Hi,
this series adds GICv1 Security Extensions (secure/non-secure interrupts)
and interrupt grouping of the GICv2 specification. The patches use the
terminology introduced by GICv2 (Group0 instead of secure).
The series first adds FIQ lines from the GIC to the CPUs and then adds
the Security Ex
This register is banked in GICs with Security Extensions. Storing the
non-secure copy of BPR in the abpr, which is an alias to the non-secure
copy for secure access. ABPR itself is only accessible from secure state
if the GIC implements Security Extensions.
Signed-off-by: Fabian Aggeler
---
hw/i
For GICs with Security Extensions Non-secure reads have a restricted
view on the current running priority.
Signed-off-by: Fabian Aggeler
---
hw/intc/arm_gic.c | 17 -
hw/intc/gic_internal.h | 1 +
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/hw/intc/arm_gi
Security Extensions for GICv1 and GICv2 use register banking
to provide transparent access to seperate Secure and Non-secure
copies of GIC configuration registers. This function will later
be replaced by code determining the security state of a read/write
access to a register.
Signed-off-by: Fabia
Interrupt Group Registers (previously called Interrupt Security
Registers) as defined in GICv1 with Security Extensions or GICv2 allow
to configure interrupts as Secure (Group0) or Non-secure (Group1).
In GICv2 these registers are implemented independent of the existence of
Security Extensions.
Si
ICDDCR/GICD_CTLR is banked in GICv1 implementations with Security
Extensions or in GICv2 in independent from Security Extensions.
This makes it possible to enable forwarding of interrupts from
Distributor to the CPU interfaces for Group0 and Group1.
EnableGroup0 (Bit [1]) in GICv1 is IMPDEF. Since
Grouping (GICv2) and Security Extensions change the behavior of IAR
reads. Acknowledging Group0 interrupts is only allowed from Secure
state and acknowledging Group1 interrupts from Secure state is only
allowed if AckCtl bit is set.
Signed-off-by: Fabian Aggeler
---
hw/intc/arm_gic.c | 24 ++
Grouping (GICv2) and Security Extensions change the behavior of EOIR
writes. Completing Group0 interrupts is only allowed from Secure state
and completing Group1 interrupts from Secure state is only allowed if
AckCtl bit is set.
Signed-off-by: Fabian Aggeler
---
hw/intc/arm_gic.c | 15 ++
GICs with Security Extensions restrict the non-secure view of the
interrupt priority and priority mask registers.
Signed-off-by: Fabian Aggeler
---
hw/intc/arm_gic.c | 66 +-
hw/intc/gic_internal.h | 3 +++
2 files changed, 63 insertions(+),
ICCICR/GICC_CTLR is banked in GICv1 implementations with Security
Extensions or in GICv2 in independent from Security Extensions.
This makes it possible to enable forwarding of interrupts from
the CPU interfaces to the connected processors for Group0 and Group1.
We also allow to set additional bit
Preparing for FIQ lines from GIC to CPUs, which is needed for GIC
Security Extensions.
Signed-off-by: Fabian Aggeler
---
hw/intc/arm_gic.c| 3 +++
include/hw/intc/arm_gic_common.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c
index 15
The existing implementation does not support Security Extensions mentioned
in the GICv1 and GICv2 architecture specification. Security Extensions are
not available on all GICs. This property makes it possible to enable Security
Extensions.
It also makes GICD_TYPER/ICDICTR.SecurityExtn RAO for GIC
Prepare to split gic_update() in two functions, one for GICs with
interrupt grouping and one without grouping (existing).
Signed-off-by: Fabian Aggeler
---
hw/intc/arm_gic.c | 11 ---
hw/intc/gic_internal.h | 1 +
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/hw/in
On Fri, 08/22 12:10, Paolo Bonzini wrote:
> Il 22/08/2014 11:37, Fam Zheng ha scritto:
> > Exactly. I'd rather not change the contract then.
> >
> > Alternatively, we may add a refcnt field to BlockDriverAioCB and grab one
> > before
> > calling .cancel, so the qemu_aio_release will not free it.
Add stub function "qemu_set_fd_handler" which is used by
util/event_notifier-posix.c.
Signed-off-by: Fam Zheng
---
stubs/Makefile.objs | 1 +
stubs/iohandler.c | 20
2 files changed, 21 insertions(+)
create mode 100644 stubs/iohandler.c
diff --git a/stubs/Makefile.objs
Since it has a dependency on vmstate and is only used by device
emulation, moving out from util will make the archive more independent.
Signed-off-by: Fam Zheng
---
hw/misc/Makefile.objs | 1 +
{util => hw/misc}/fifo8.c | 0
util/Makefile.objs| 1 -
3 files changed, 1 insertion(+), 1
Since we will soon need to resolve openpty (3) when linking.
Signed-off-by: Fam Zheng
---
configure | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure b/configure
index 283c71c..5c35ecf 100755
--- a/configure
+++ b/configure
@@ -3546,6 +3546,7 @@ fi
if test "$darwin" != "yes" -a "$mi
It is only used by block code and has dependency on timers, so move it
out to allow util to be linked unconditionally.
Signed-off-by: Fam Zheng
---
Makefile.objs | 2 +-
util/throttle.c => throttle.c | 0
util/Makefile.objs| 1 -
3 files changed, 1 insertion(+), 2 del
Signed-off-by: Fam Zheng
---
stubs/Makefile.objs| 1 -
stubs/iohandler.c | 9 +
stubs/set-fd-handler.c | 11 ---
3 files changed, 9 insertions(+), 12 deletions(-)
delete mode 100644 stubs/set-fd-handler.c
diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs
index d9
When an executable is being generated, unused functions from
libqemuutil.a are not linked. This is the linker's convention on
archives (libqemuutil.a).
Now that we have dynamically loaded modules, which may reference
function from libqemuutil.a but not linked in the executable, because
the executa
Am 11.07.2014 um 08:10 hat Hu Tao geschrieben:
> This patch prepares for the subsequent patches.
>
> Reviewed-by: Fam Zheng
> Reviewed-by: Eric Blake
> Reviewed-by: Max Reitz
> Signed-off-by: Hu Tao
Strictly speaking, qcow2 should error out if it is given full or falloc
after this patch. Two
Am 28.07.2014 um 10:48 hat Hu Tao geschrieben:
> ping...
>
> All the 6 patches have reviewed-by now.
Looks mostly good to me, I have only a few minor comments that wouldn't
block inclusion but could be addressed in follow-up patches.
However, you have a dependency on a patch series from Max (you
Function qmp_query_uuid, even with a version in libqemustub.a, is not
linked in qemu-img, unless we use it in somewhere that is linked into
qemu-img. For example util-obj-y - since iqn generation a general
function, not iscsi specific, moving it to util makes some sense, and
more importantly this w
Am 11.07.2014 um 08:09 hat Hu Tao geschrieben:
> Reviewed-by: Max Reitz
> Reviewed-by: Eric Blake
> Signed-off-by: Hu Tao
If we make this change, shouldn't we do it consistently across all image
formats? With this patch we have some formats that round up, and many
others that round down.
Kevin
Am 11.07.2014 um 08:10 hat Hu Tao geschrieben:
> This patch adds a new option preallocation for raw format, and implements
> falloc and full preallocation.
>
> Reviewed-by: Max Reitz
> Signed-off-by: Hu Tao
raw-posix needs to error out if called with preallocation=metadata, it
doesn't implement
Am 11.07.2014 um 08:10 hat Hu Tao geschrieben:
> This adds preallocation=falloc and preallocation=full mode to qcow2
> image creation.
>
> preallocation=full allocates disk space by writing zeros to disk to
> ensure disk space in any cases.
>
> preallocation=falloc likes preallocation=full, but a
The blkpg ioctl can take different payloads depending on the opcode in
its payload structure. Create a new special ioctl handler that can only
deal with partition style ones for now.
This patch fixes running parted for me.
Signed-off-by: Alexander Graf
---
linux-user/ioctls.h| 3 ++-
l
We check whether the passed in counter value is negative on all calls
that involve g_posix_timers. However, we AND the value down to 16 bits
right before the check, so they can never be negative.
Simplify all the checks and remove the useless negativity check.
Signed-off-by: Alexander Graf
---
Hi Jakub,
Thanks for the test case. I've just done a git bisect using your test
image above and it seems as if the offending commit is this:
commit 2c7ffc414d8591018248b5487757e45f7bb6bd3c
Author: Peter Maydell
Date: Tue Apr 15 19:18:40 2014 +0100
target-arm: Fix VFP enables for AArch32
ping
Anybody? There hasn't been any feedback on this patchset for almost 2
months now...
On 12/08/2014 12:36, Leon Alrae wrote:
> ping
>
> On 05/08/2014 10:26, Leon Alrae wrote:
>> ping
>>
>> http://patchwork.ozlabs.org/patch/365066/
>> http://patchwork.ozlabs.org/patch/365042/
>> http://patchwo
Before this patch you could not run multiple tests concurrently as they
might clobber each other test files. This patch solves that by using
random temporary directory instead of `/tmp` (for writing output in the
individual tests and valgrind logs).
Furthermore, this patch stops removing everythin
On 22 August 2014 12:19, Alexander Graf wrote:
> We check whether the passed in counter value is negative on all calls
> that involve g_posix_timers. However, we AND the value down to 16 bits
> right before the check, so they can never be negative.
...but why exactly are we doing that AND with 0x
Am 22.08.2014 13:33, schrieb Peter Maydell:
> On 22 August 2014 12:19, Alexander Graf wrote:
>> We check whether the passed in counter value is negative on all calls
>> that involve g_posix_timers. However, we AND the value down to 16 bits
>> right before the check, so they can never be negative.
** Summary changed:
- [ARMv5] Integrator/CP regression when reading FPSID instruction
+ [ARMv5] Integrator/CP regression when reading FPSID register
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1359
On 22.08.14 13:33, Peter Maydell wrote:
> On 22 August 2014 12:19, Alexander Graf wrote:
>> We check whether the passed in counter value is negative on all calls
>> that involve g_posix_timers. However, we AND the value down to 16 bits
>> right before the check, so they can never be negative.
>
On 22 August 2014 12:17, Mark Cave-Ayland wrote:
> Hi Jakub,
>
> Thanks for the test case. I've just done a git bisect using your test
> image above and it seems as if the offending commit is this:
>
>
> commit 2c7ffc414d8591018248b5487757e45f7bb6bd3c
> Author: Peter Maydell
> Date: Tue Apr 15
On 22 August 2014 12:42, Alexander Graf wrote:
> On 22.08.14 13:33, Peter Maydell wrote:
>> On 22 August 2014 12:19, Alexander Graf wrote:
>>> We check whether the passed in counter value is negative on all calls
>>> that involve g_posix_timers. However, we AND the value down to 16 bits
>>> right
On 22 August 2014 12:36, Andreas Färber wrote:
> Am 22.08.2014 13:33, schrieb Peter Maydell:
>> On 22 August 2014 12:19, Alexander Graf wrote:
>>> We check whether the passed in counter value is negative on all calls
>>> that involve g_posix_timers. However, we AND the value down to 16 bits
>>> r
On 22.08.14 13:44, Peter Maydell wrote:
> On 22 August 2014 12:42, Alexander Graf wrote:
>> On 22.08.14 13:33, Peter Maydell wrote:
>>> On 22 August 2014 12:19, Alexander Graf wrote:
We check whether the passed in counter value is negative on all calls
that involve g_posix_timers. How
On 22 August 2014 12:45, Alexander Graf wrote:
> On 22.08.14 13:44, Peter Maydell wrote:
>> On 22 August 2014 12:42, Alexander Graf wrote:
>>> Or we drop the AND and and the <0 check and treat arg1 as unsigned ;).
>>
>> That probably just requires equally many changes to
>> code that is currently
On 22.08.14 13:49, Peter Maydell wrote:
> On 22 August 2014 12:45, Alexander Graf wrote:
>> On 22.08.14 13:44, Peter Maydell wrote:
>>> On 22 August 2014 12:42, Alexander Graf wrote:
Or we drop the AND and and the <0 check and treat arg1 as unsigned ;).
>>>
>>> That probably just requires
We check whether the passed in timer id is negative on all calls
that involve g_posix_timers.
However, these checks are bogus. First off we limit the timer_id to
16 bits which is not what Linux does. Then we check whether it's negative
which it can't be because we masked it.
We can safely remove
Else stdout is not closed correctly.
Signed-off-by: Dietmar Maurer
Index: new/block/gluster.c
===
--- new.orig/block/gluster.c2014-08-22 13:21:39.0 +0200
+++ new/block/gluster.c 2014-08-22 13:25:18.0 +0200
@@ -19
On 22 August 2014 12:56, Alexander Graf wrote:
> We check whether the passed in timer id is negative on all calls
> that involve g_posix_timers.
>
> However, these checks are bogus. First off we limit the timer_id to
> 16 bits which is not what Linux does. Then we check whether it's negative
> whi
Hi,
as in the kernel timer_t is an "int" (as said PMM), you should cast to "int" to
remove garbage on 64bit hosts and check sign ...
Regards,
Laurent
> Le 22 août 2014 à 13:56, Alexander Graf a écrit :
>
>
> We check whether the passed in timer id is negative on all calls
> that involve g_posix
On 22.08.14 14:07, Peter Maydell wrote:
> On 22 August 2014 12:56, Alexander Graf wrote:
>> We check whether the passed in timer id is negative on all calls
>> that involve g_posix_timers.
>>
>> However, these checks are bogus. First off we limit the timer_id to
>> 16 bits which is not what Linu
On Fri, Aug 22, 2014 at 8:54 PM, Fam Zheng wrote:
> Since it has a dependency on vmstate and is only used by device
> emulation, moving out from util will make the archive more independent.
>
> Signed-off-by: Fam Zheng
We probably also want to move the corresponding header at some stage too.
bu
On 22 August 2014 13:12, Alexander Graf wrote:
> In Linux, the timer id is a "key" into a hash table that the kernel
> searches to find its timer. In QEMU it's an offset into an array.
>
> In both cases the syscall user receives it as a token from a create
> function and should treat it as opaque.
On Mon, Jul 28, 2014 at 04:48:46PM +0800, Hu Tao wrote:
> ping...
>
> All the 6 patches have reviewed-by now.
>
> On Fri, Jul 11, 2014 at 02:09:57PM +0800, Hu Tao wrote:
> > This series adds two preallocation mode to qcow2 and raw:
> >
> > Option preallocation=full preallocates disk space for i
On 22.08.14 14:25, Peter Maydell wrote:
> On 22 August 2014 13:12, Alexander Graf wrote:
>> In Linux, the timer id is a "key" into a hash table that the kernel
>> searches to find its timer. In QEMU it's an offset into an array.
>>
>> In both cases the syscall user receives it as a token from a
On Fri, Aug 22, 2014 at 6:53 PM, Peter Maydell wrote:
> On 22 August 2014 09:38, Aggeler Fabian wrote:
>>
>> On 19 Aug 2014, at 16:03, Peter Maydell wrote:
>>> Which input signals in the hardware do these properties
>>> correspond to? I can't figure out what the mapping is.
>>> As far as I can
On Fri, Aug 22, 2014 at 1:38 PM, wrote:
> From: Gonglei
>
> Steps:
>
> 1.enable qemu debug print, using simply scprit as below:
> grep "//#define DEBUG" * -rl | xargs sed -i "s/\/\/#define DEBUG/#define
> DEBUG/g"
> 2. make -j
> 3. get some warning:
> hw/i2c/pm_smbus.c: In function 'smb_ioport
On Fri, Aug 22, 2014 at 01:25:56PM +0100, Richard W.M. Jones wrote:
>
> On Mon, Jul 28, 2014 at 04:48:46PM +0800, Hu Tao wrote:
> > ping...
> >
> > All the 6 patches have reviewed-by now.
> >
> > On Fri, Jul 11, 2014 at 02:09:57PM +0800, Hu Tao wrote:
> > > This series adds two preallocation mod
Hi Dominique,
On 08/22/2014 02:27 AM, Dominique Martinet wrote:
> Hi,
>
> Christopher Covington wrote on Thu, Aug 21, 2014 at 03:50:58PM -0400:
>> With my 3.15.0+ kernel, qemu-system-x86_64 substituted for qemu-kvm, and the
>> path changed from your arguments I get:
>>
>> 9pnet_virtio: no channel
Am 22.07.2014 um 22:58 hat Max Reitz geschrieben:
> Currently, qemu-img does not allow setting the cache mode for source
> images. However, it reads images generally only once, therefore a full
> writeback cache unnecessarily clutters the host cache. In case the user
> finds this undesirable, there
1 - 100 of 281 matches
Mail list logo
