Re: [Qemu-devel] [RFC 0/4] Adding -cdrom, -hd[abcd] and -drive file=... to Q35

2014-08-20 Thread Markus Armbruster
John Snow writes: > On 08/19/2014 02:08 PM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 08/19/2014 04:05 AM, Markus Armbruster wrote: John Snow writes: > Currently, the drive definitions created by drive_new() when using > the -drive file=...[,if=ide] or -cdrom or

Re: [Qemu-devel] [RFC PATCH v1 07/11] memory.c: Add address_space_init_shareable()

2014-08-20 Thread Peter Crosthwaite
On Wed, Jun 4, 2014 at 1:30 AM, Peter Maydell wrote: > On 3 June 2014 03:10, Peter Crosthwaite wrote: >> This will either create a new AS or return a pointer to an >> already existing equivalent one. Both name and root mr must >> match. >> >> The motivation is to reuse address spaces as much as p

[Qemu-devel] [Bug] QEMU crashed with latest qemu master tree code

2014-08-20 Thread Gonglei (Arei)
Hi, Command line: #./qemu-system-x86_64 -enable-kvm -m 2048 -machine q35 -device ide-drive,bus=ide.2,drive=MacHDD \ -drive id=MacHDD,if=none,file=/mnt/sdb/gonglei/image/redhat_q35.img -monitor stdio -vnc :10 -readconfig ../docs/q35-chipset.cfg (qemu) Segmentation fault (core dumped) Some clews

Re: [Qemu-devel] [RFC PATCH v1 09/11] exec: use per-cpu address-spaces for cpuisms

2014-08-20 Thread Peter Crosthwaite
On Wed, Jun 4, 2014 at 1:28 AM, Peter Maydell wrote: > On 3 June 2014 03:11, Peter Crosthwaite wrote: >> Rather than address_space_memory. >> >> Needs a few random callsites with hardcoded address_space_memory to be >> patched. Use first_cpu->as in these cases. >> >> Signed-off-by: Peter Crosthwa

Re: [Qemu-devel] [RFC PATCH v2 10/13] linux headers update for DDW

2014-08-20 Thread Alexey Kardashevskiy
On 08/19/2014 03:42 AM, Alex Williamson wrote: > On Fri, 2014-08-15 at 20:12 +1000, Alexey Kardashevskiy wrote: >> Since the changes are not in upstream yet, no tag or branch is specified >> here. >> >> Signed-off-by: Alexey Kardashevskiy >> --- >> linux-headers/linux/vfio.h | 37 +++

Re: [Qemu-devel] [PULL 19/20] memory: Use canonical path component as the name

2014-08-20 Thread Peter Maydell
On 20 August 2014 06:04, Peter Crosthwaite wrote: > On Wed, Aug 20, 2014 at 5:01 AM, Peter Maydell > wrote: >> I think we need to revert this (commit b0225c2c0d8) until >> both the Xen callsites are fixed and the leak issue is >> dealt with. >> > > Have half a plan on the leak issue. With > obje

Re: [Qemu-devel] [PATCH 0/3] q35: Minor fixes/enhancements to improve usability of root ports

2014-08-20 Thread Markus Armbruster
Please make sure the parts of your series are threaded together properly with In-Reply-To and References headers, because that helps e-mail readers to keep the parts together. Lack of threading is annoying, and annoying reviewers intentionally would be rude :) Suggested workflow: git-format-

Re: [Qemu-devel] QEMU block layer todo list

2014-08-20 Thread Christian Borntraeger
On 19/08/14 16:20, Stefan Hajnoczi wrote: > The following wiki page contains a list of proposed tasks for the QEMU > block layer: > > http://qemu-project.org/Features/Block/Todo > > Benoit requested that we make the todo list viewable/editable. This > is a good idea as it helps us focus and see

Re: [Qemu-devel] [RFC PATCH v2 02/13] spapr_iommu: Disable in-kernel IOMMU tables for >4GB windows

2014-08-20 Thread Alexey Kardashevskiy
On 08/19/2014 10:43 AM, David Gibson wrote: > On Fri, Aug 15, 2014 at 08:12:24PM +1000, Alexey Kardashevskiy wrote: >> The existing KVM_CREATE_SPAPR_TCE ioctl only support 4G windows max. >> We are going to add huge DMA windows support so this will create small >> window and unexpectedly fail later

Re: [Qemu-devel] [libvirt] [PATCHv2 libvirt] qemu: Issue rtc-reset-reinjection command after guest-set-time

2014-08-20 Thread Michal Privoznik
On 19.08.2014 19:23, Marcelo Tosatti wrote: On Tue, Aug 19, 2014 at 11:00:26AM -0600, Eric Blake wrote: On 08/19/2014 10:57 AM, Marcelo Tosatti wrote: rtc-reset-reinjection has been introduced because certain Windows versions will advance the guest system time (via rtc interrupt reinjection).

Re: [Qemu-devel] [PULL 19/20] memory: Use canonical path component as the name

2014-08-20 Thread Paolo Bonzini
Il 20/08/2014 09:50, Peter Maydell ha scritto: > On 20 August 2014 06:04, Peter Crosthwaite > wrote: >> On Wed, Aug 20, 2014 at 5:01 AM, Peter Maydell >> wrote: >>> I think we need to revert this (commit b0225c2c0d8) until >>> both the Xen callsites are fixed and the leak issue is >>> dealt wit

Re: [Qemu-devel] [PATCH 0/3] q35: Minor fixes/enhancements to improve usability of root ports

2014-08-20 Thread Knut Omang
On Wed, 2014-08-20 at 09:54 +0200, Markus Armbruster wrote: > Please make sure the parts of your series are threaded together properly > with In-Reply-To and References headers, because that helps e-mail > readers to keep the parts together. Lack of threading is annoying, and > annoying reviewers

Re: [Qemu-devel] [PATCH 1/4] hd-geometry.c: Integrate HDIO_GETGEO in guessing for target-s390x

2014-08-20 Thread Paolo Bonzini
Il 29/07/2014 14:27, Ekaterina Tumanova ha scritto: > The new HDIO_GETGEO logic is required for two use cases: > a) Support for geometries of Direct Attached Storage Disks (DASD) > on s390x configured as backing of virtio block devices. Is this still relevant now that QEMU can emulate 512-byte sec

Re: [Qemu-devel] [PATCH 3/3] ioh3420: Support ARI forwarding

2014-08-20 Thread Gonglei (Arei)
Hi, > Subject: [PATCH 3/3] ioh3420: Support ARI forwarding > > > Enable the PCIe capability bit that indicates that this port is able to > support > and forward requests to > 8 functions for ARI capable devices. > > Signed-off-by: Knut Omang > --- > hw/pci-bridge/ioh3420.c | 7 +++ > 1 f

[Qemu-devel] [Bug 1354279] Re: The guest will be destroyed after hot remove the VF from the guest.

2014-08-20 Thread chao zhou
test on Ivytown_EP kvm.git + qemu.git: c77dcacb_0e4a7737 kernel version: 3.16.0 after hot remove the VF from the guest, the guest works fine. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscri

Re: [Qemu-devel] [PATCH 3/3] ioh3420: Support ARI forwarding

2014-08-20 Thread Knut Omang
On Wed, 2014-08-20 at 08:34 +, Gonglei (Arei) wrote: > Hi, > > > Subject: [PATCH 3/3] ioh3420: Support ARI forwarding > > > > > > Enable the PCIe capability bit that indicates that this port is able to > > support > > and forward requests to > 8 functions for ARI capable devices. > > > > S

Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function

2014-08-20 Thread Paolo Bonzini
Il 20/08/2014 08:53, Knut Omang ha scritto: > A unique bus name is necessary to be able to refer to each instance > from the command line and monitors. Is it needed? Can't you just add id= to the -device option? Paolo

Re: [Qemu-devel] [PATCH bugfix v1 1/3] xen: hvm: Abstract away memory region name ref (fix broken build)

2014-08-20 Thread Stefan Weil
Am 20.08.2014 um 07:07 schrieb Peter Crosthwaite: > The mr->name field is removed. This slipped through compile testing. > Fix. > > Signed-off-by: Peter Crosthwaite > --- > > xen-hvm.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/xen-hvm.c b/xen-hvm.c > ind

Re: [Qemu-devel] [PATCH bugfix v1 1/3] xen: hvm: Abstract away memory region name ref (fix broken build)

2014-08-20 Thread Peter Maydell
On 20 August 2014 09:53, Stefan Weil wrote: > Am 20.08.2014 um 07:07 schrieb Peter Crosthwaite: >> The mr->name field is removed. This slipped through compile testing. >> Fix. >> >> Signed-off-by: Peter Crosthwaite >> --- >> >> xen-hvm.c | 9 ++--- >> 1 file changed, 6 insertions(+), 3 delet

Re: [Qemu-devel] [PATCH 2/2] pci: add check for pcie root ports and downstream ports

2014-08-20 Thread Marcel Apfelbaum
On Wed, 2014-08-20 at 03:20 +, Gonglei (Arei) wrote: > Hi, > > > > Right now, ARI Forwarding dose not support in QEMU. > > I would replace the above sentence with "ARI Forwarding is not supported". > > > OK. > > > By the way, there is some support for ARI, I don't know if > > is enabled yet.

Re: [Qemu-devel] [PATCH 3/3] ioh3420: Support ARI forwarding

2014-08-20 Thread Marcel Apfelbaum
On Wed, 2014-08-20 at 08:53 +0200, Knut Omang wrote: > Enable the PCIe capability bit that indicates that this port is able to > support > and forward requests to > 8 functions for ARI capable devices. > > Signed-off-by: Knut Omang > --- > hw/pci-bridge/ioh3420.c | 7 +++ > 1 file changed,

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-20 Thread William Dauchy
On Aug19 12:56, Jason Wang wrote: > commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue > support changed the order of stopping the device. Previously > vhost_dev_stop would disable backend and only afterwards, unset guest > notifiers. We now unset guest notifiers while vhost is still

[Qemu-devel] [PATCH] libdecnumber: Fix warnings from smatch (missing static, boolean operations)

2014-08-20 Thread Stefan Weil
Signed-off-by: Stefan Weil --- libdecnumber/decNumber.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/libdecnumber/decNumber.c b/libdecnumber/decNumber.c index a30632f..58211e7 100644 --- a/libdecnumber/decNumber.c +++ b/libdecnumber/decNumber.c @@

Re: [Qemu-devel] [PATCH 3/3] ioh3420: Support ARI forwarding

2014-08-20 Thread Gonglei (Arei)
> > static int ioh3420_initfn(PCIDevice *d) > > { > > +PCIBridge* br = PCI_BRIDGE(d); > > PCIEPort *p = PCIE_PORT(d); > > PCIESlot *s = PCIE_SLOT(d); > > +uint8_t *exp_cap; > > int rc; > > char tmp[100]; > > sprintf(tmp, "pcie_port.%d", s->slot); > > @@ -121,6 +12

Re: [Qemu-devel] [PATCH 1/3] pcie: Fix next function setting

2014-08-20 Thread Marcel Apfelbaum
On Wed, 2014-08-20 at 08:52 +0200, Knut Omang wrote: > PCI_ARI_CAP_NFN is for reading next function not writing it The commit message is not so clear, maybe something like "Fix incorrect write to ari capability or similar? Other than that the patch looks OK to me. Thanks, Marcel > > Signed-

Re: [Qemu-devel] [PATCH 2/2] pci: add check for pcie root ports and downstream ports

2014-08-20 Thread Gonglei (Arei)
> From: Marcel Apfelbaum [mailto:marce...@redhat.com] > Subject: Re: [PATCH 2/2] pci: add check for pcie root ports and downstream > ports > > On Wed, 2014-08-20 at 03:20 +, Gonglei (Arei) wrote: > > Hi, > > > > > > Right now, ARI Forwarding dose not support in QEMU. > > > I would replace the

Re: [Qemu-devel] [PATCH bugfix v1 3/3] qom: object.h: Update object_get_canon_path* doc

2014-08-20 Thread Peter Maydell
On 20 August 2014 06:08, Peter Crosthwaite wrote: > With information about return value ownership. > > Signed-off-by: Peter Crosthwaite > --- > > include/qom/object.h | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/include/qom/object.h b/include/qom/object.h > inde

Re: [Qemu-devel] [PATCH 3/3] ioh3420: Support ARI forwarding

2014-08-20 Thread Knut Omang
On Wed, 2014-08-20 at 11:57 +0300, Marcel Apfelbaum wrote: > On Wed, 2014-08-20 at 08:53 +0200, Knut Omang wrote: > > Enable the PCIe capability bit that indicates that this port is able to > > support > > and forward requests to > 8 functions for ARI capable devices. > > > > Signed-off-by: Knut

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-20 Thread Zhangjie (HZ)
On 2014/8/19 12:56, Jason Wang wrote: > commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue call it before setting > Zhang Jie, please test this patch to see if it fixes the issue. > +static void vhost_net_set_vq_index(struct vhost_net *net, int vq_index) > +{ > +net->dev.vq_ind

Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function

2014-08-20 Thread Knut Omang
On Wed, 2014-08-20 at 10:52 +0200, Paolo Bonzini wrote: > Il 20/08/2014 08:53, Knut Omang ha scritto: > > A unique bus name is necessary to be able to refer to each instance > > from the command line and monitors. > > Is it needed? Can't you just add id= to the -device option? Yes, as far as I u

Re: [Qemu-devel] [PATCH 1/4] hd-geometry.c: Integrate HDIO_GETGEO in guessing for target-s390x

2014-08-20 Thread Christian Borntraeger
On 20/08/14 10:19, Paolo Bonzini wrote: > Il 29/07/2014 14:27, Ekaterina Tumanova ha scritto: >> The new HDIO_GETGEO logic is required for two use cases: >> a) Support for geometries of Direct Attached Storage Disks (DASD) >> on s390x configured as backing of virtio block devices. > > Is this stil

Re: [Qemu-devel] [PULL 00/19] target-arm queue

2014-08-20 Thread Peter Maydell
On 19 August 2014 19:09, Peter Maydell wrote: > Flushing my queue of reviewed ARM patches: single step, > plus a collection of straightforward patches from other > people. > > thanks > -- PMM > > > The following changes since commit 0e4a77370594c91dd126f9872893ed473374cc72: > > Merge remote-trac

[Qemu-devel] [RFC PATCH 1/2] VFIO: Drop vfio_container_do_ioctl()

2014-08-20 Thread Gavin Shan
The patch drops vfio_container_do_ioctl() and merges its logic to parent function call vfio_container_ioctl() so that the subsequent patches can reused the found VFIO group in vfio_container_ioctl(). Signed-off-by: Gavin Shan --- hw/misc/vfio.c | 33 +++-- 1 file chan

[Qemu-devel] [RFC PATCH 2/2] VFIO: Clear stale MSIx table during EEH reset

2014-08-20 Thread Gavin Shan
The PCI device MSIx table is cleaned out in hardware after EEH PE reset. However, we still hold the stale MSIx entries in QEMU, which should be cleared accordingly. Otherwise, we will run into another (recursive) EEH error and the PCI devices contained in the PE have to be offlined exceptionally.

[Qemu-devel] [RFC PATCH 0/2] Fix MSIx lost after PE reset

2014-08-20 Thread Gavin Shan
The 2 patches fix MSIx lost after PE reset. Otherwise, the MSIx entries can't be restored successfully after PE reset and the EEH recovery fails on broadcom tg3 adapter (as tested) in guest. Note: The patchset "EEH support for guest" isn't merged yet, those 2 patches are based on Alex Graf's

Re: [Qemu-devel] [PATCH 0/2] block: support block_resize with dataplane

2014-08-20 Thread Kevin Wolf
Am 18.08.2014 um 15:52 hat Stefan Hajnoczi geschrieben: > We have the op blocker and AioContext acquire/release infrastructure to safely > allow block monitor commands on dataplane commands. It is now easy to make > block_resize safe. > > Stefan Hajnoczi (2): > block: acquire AioContext in qmp_

Re: [Qemu-devel] [PATCH v7] virtio-blk: fix reference a pointer which might be freed

2014-08-20 Thread Kevin Wolf
Am 18.08.2014 um 10:08 hat Paolo Bonzini geschrieben: > Il 18/08/2014 09:42, zhanghailiang ha scritto: > > In function virtio_blk_handle_request, it may freed memory pointed by req, > > So do not access member of req after calling this function. > > > > Reviewed-by: Michael S. Tsirkin > > Reviewe

[Qemu-devel] [PATCH 6/6] iscsi: Move iqn generation code to util

2014-08-20 Thread Fam Zheng
Function qmp_query_uuid, even with a version in libqemustub.a, is not present in qemu-img, unless we move it to something that is linked with block-obj-y. Since it's a helper function, move it to util makes sense. Signed-off-by: Fam Zheng --- block/iscsi.c | 15 +-- include/q

Re: [Qemu-devel] [PATCH 1/4] qcow2: Add qcow2_signal_corruption()

2014-08-20 Thread Kevin Wolf
Am 16.08.2014 um 23:16 hat Max Reitz geschrieben: > Add a helper function for easily marking an image corrupt while > outputting an informative message to stderr and via QAPI. > > Signed-off-by: Max Reitz > --- > block/qcow2.c | 28 > block/qcow2.h | 4 > 2 fil

Re: [Qemu-devel] [PATCH 3/4] iotests: Fix output of 060

2014-08-20 Thread Kevin Wolf
Am 16.08.2014 um 23:16 hat Max Reitz geschrieben: > With qcow2_pre_write_overlap_check() relying on > qcow2_signal_corruption(), the output in case of a corruption changes. > Therefore, 060's output has to be adapted accordingly. > > Signed-off-by: Max Reitz Squash this into patch 2 so that the

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-20 Thread Michael S. Tsirkin
On Wed, Aug 20, 2014 at 05:23:21PM +0800, Zhangjie (HZ) wrote: > On 2014/8/19 12:56, Jason Wang wrote: > > commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue > call it before setting > > Zhang Jie, please test this patch to see if it fixes the issue. > > > +static void vhost_net_se

Re: [Qemu-devel] [PATCH 3/3] ioh3420: Support ARI forwarding

2014-08-20 Thread Knut Omang
On Wed, 2014-08-20 at 09:02 +, Gonglei (Arei) wrote: > > > static int ioh3420_initfn(PCIDevice *d) > > > { > > > +PCIBridge* br = PCI_BRIDGE(d); > > > PCIEPort *p = PCIE_PORT(d); > > > PCIESlot *s = PCIE_SLOT(d); > > > +uint8_t *exp_cap; > > > int rc; > > > char tm

Re: [Qemu-devel] [PATCH v7 3/4] s390x: Migrate to new NMI interface

2014-08-20 Thread Alexey Kardashevskiy
On 07/17/2014 04:30 PM, Alexey Kardashevskiy wrote: > On 07/15/2014 06:29 AM, Paolo Bonzini wrote: >> Il 14/07/2014 05:17, Alexey Kardashevskiy ha scritto: > No, you should politely bother them again. >>> >>> That does not seem helping though :-/ >> >> Sorry. :) >> >> Well, patch 1 is the same

[Qemu-devel] Recent SeaBIOS too big for QEMU -initrd

2014-08-20 Thread Stefan Hajnoczi
The QEMU -initrd option loads the initrd at the top of RAM. There is a 64 KB safety region for ACPI tables in hw/i386/pc.c:load_linux(): initrd_max = max_ram_size-ACPI_DATA_SIZE-1; QEMU's bios-256k.bin SeaBIOS build reserves 128 KB at the top of memory so the 64 KB ACPI data size has become to

[Qemu-devel] [PATCH 5/6] build-sys: Change libqemuutil.a to qemuutil.o and link whole object

2014-08-20 Thread Fam Zheng
When an executable is being generated, unused functions from libqemuutil.a are not linked. This is the linker's convention on archives (libqemuutil.a). Now that we have dynamically loaded modules, which may reference function from libqemuutil.a but not linked in the executable, because the executa

[Qemu-devel] [PATCH 1/6] build-sys: Move fifio8 to hw/

2014-08-20 Thread Fam Zheng
Since it has a dependency on vmstate and is only used by device emulation, moving out from util will make the archive more independent. Signed-off-by: Fam Zheng --- hw/Makefile.objs | 1 + hw/fifo8.c | 125 + util/Makefile.objs |

[Qemu-devel] [PATCH 4/6] stubs: Add timer.c

2014-08-20 Thread Fam Zheng
Add timer functions that are used in util/throttle.c. Signed-off-by: Fam Zheng --- stubs/Makefile.objs | 1 + stubs/timer.c | 44 2 files changed, 45 insertions(+) create mode 100644 stubs/timer.c diff --git a/stubs/Makefile.objs b/stubs/Make

[Qemu-devel] [PATCH 3/6] stubs: Add openpty.c

2014-08-20 Thread Fam Zheng
Add function "openpty" which is used by util/qemu-openpty.c. Signed-off-by: Fam Zheng --- stubs/Makefile.objs | 1 + stubs/openpty.c | 21 + 2 files changed, 22 insertions(+) create mode 100644 stubs/openpty.c diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs inde

Re: [Qemu-devel] qemu 9p mapped-xattr model does not translate d_type in readdir

2014-08-20 Thread Aneesh Kumar K.V
Michael Tokarev writes: > There's another bugreport filed against debian qemu package, > http://bugs.debian.org/755738 . It talks about security_model=mapped-xattr > case, where file type is stored elsewhere, and all files are turned into > regular files. http://bugs.debian.org/755738#10 is the

[Qemu-devel] [PATCH 2/6] stubs: Add iohandler.c

2014-08-20 Thread Fam Zheng
Add stub function "qemu_set_fd_handler" which is used by util/event_notifier-posix.c. Signed-off-by: Fam Zheng --- stubs/Makefile.objs | 1 + stubs/iohandler.c | 20 2 files changed, 21 insertions(+) create mode 100644 stubs/iohandler.c diff --git a/stubs/Makefile.objs

Re: [Qemu-devel] [PATCH 4/4] qcow2: Check L1/L2/reftable entries for alignment

2014-08-20 Thread Kevin Wolf
Am 16.08.2014 um 23:16 hat Max Reitz geschrieben: > Offsets taken from the L1, L2 and refcount tables are generally assumed > to be correctly aligned. However, this cannot be guaranteed if the image > has been written to by something different than qemu, thus check all > offsets taken from these ta

Re: [Qemu-devel] [PATCH v7 3/4] s390x: Migrate to new NMI interface

2014-08-20 Thread Alexander Graf
On 20.08.14 12:20, Alexey Kardashevskiy wrote: > On 07/17/2014 04:30 PM, Alexey Kardashevskiy wrote: >> On 07/15/2014 06:29 AM, Paolo Bonzini wrote: >>> Il 14/07/2014 05:17, Alexey Kardashevskiy ha scritto: >> No, you should politely bother them again. That does not seem helping tho

Re: [Qemu-devel] [PATCH] virt/kvm/assigned-dev.c: Set 'dev->irq_source_id' to '-1' after free it

2014-08-20 Thread Chen Gang
On 08/20/2014 08:01 AM, Chen Gang wrote: > > By the way, at present, I use Qemu as user mode program, is there common > test with both Qemu and KVM/Xen? And is a PC enough for the common test? > Oh, I find Qemu have "make check" just like gcc/binutils, so for each of my patch, next, shall run "./

Re: [Qemu-devel] Recent SeaBIOS too big for QEMU -initrd

2014-08-20 Thread Michael S. Tsirkin
On Wed, Aug 20, 2014 at 11:27:41AM +0100, Stefan Hajnoczi wrote: > The QEMU -initrd option loads the initrd at the top of RAM. There is > a 64 KB safety region for ACPI tables in hw/i386/pc.c:load_linux(): > > initrd_max = max_ram_size-ACPI_DATA_SIZE-1; > > QEMU's bios-256k.bin SeaBIOS build r

Re: [Qemu-devel] vhost-net issue with multiples interfaces using MQ

2014-08-20 Thread William Dauchy
On Aug19 15:02, William Dauchy wrote: > I'm using readconfig option to read the three vif interfaces. > thanks for testing I will re-triple test to see what's wrong so indeed sorry for the noise, I was wrong in my tests. -- William signature.asc Description: Digital signature

Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function

2014-08-20 Thread Michael S. Tsirkin
On Wed, Aug 20, 2014 at 11:30:55AM +0200, Knut Omang wrote: > On Wed, 2014-08-20 at 10:52 +0200, Paolo Bonzini wrote: > > Il 20/08/2014 08:53, Knut Omang ha scritto: > > > A unique bus name is necessary to be able to refer to each instance > > > from the command line and monitors. > > > > Is it ne

Re: [Qemu-devel] [PATCH v7 3/4] s390x: Migrate to new NMI interface

2014-08-20 Thread Alexey Kardashevskiy
On 08/20/2014 09:20 PM, Alexander Graf wrote: > > > On 20.08.14 12:20, Alexey Kardashevskiy wrote: >> On 07/17/2014 04:30 PM, Alexey Kardashevskiy wrote: >>> On 07/15/2014 06:29 AM, Paolo Bonzini wrote: Il 14/07/2014 05:17, Alexey Kardashevskiy ha scritto: >>> No, you should politely bot

Re: [Qemu-devel] [PATCH 1/4] block: Correct bs->growable

2014-08-20 Thread Kevin Wolf
Am 12.07.2014 um 00:23 hat Max Reitz geschrieben: > Currently, the field "growable" in a BDS is set iff the BDS is opened in > protocol mode (with O_BDRV_PROTOCOL). However, not every protocol block > driver allows growing: NBD, for instance, does not. On the other hand, > a non-protocol block driv

Re: [Qemu-devel] [PATCH v10 00/14] qemu-img: Implement commit like QMP

2014-08-20 Thread Kevin Wolf
Am 15.08.2014 um 17:22 hat Max Reitz geschrieben: > On 22.07.2014 23:29, Max Reitz wrote: > >qemu-img should use QMP commands whenever possible in order to ensure > >feature completeness of both online and offline image operations. For > >the "commit" command, this is relatively easy, so implement

Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function

2014-08-20 Thread Andreas Färber
Hi Knut, Am 20.08.2014 08:53, schrieb Knut Omang: > > A unique bus name is necessary to be able to refer to each instance > from the command line and monitors. > > Signed-off-by: Knut Omang > --- > hw/pci-bridge/ioh3420.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/hw/pci-bri

Re: [Qemu-devel] [PATCH v7 3/4] s390x: Migrate to new NMI interface

2014-08-20 Thread Alexander Graf
On 20.08.14 13:38, Alexey Kardashevskiy wrote: > On 08/20/2014 09:20 PM, Alexander Graf wrote: >> >> >> On 20.08.14 12:20, Alexey Kardashevskiy wrote: >>> On 07/17/2014 04:30 PM, Alexey Kardashevskiy wrote: On 07/15/2014 06:29 AM, Paolo Bonzini wrote: > Il 14/07/2014 05:17, Alexey Kardas

Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function

2014-08-20 Thread Markus Armbruster
Knut Omang writes: > On Wed, 2014-08-20 at 10:52 +0200, Paolo Bonzini wrote: >> Il 20/08/2014 08:53, Knut Omang ha scritto: >> > A unique bus name is necessary to be able to refer to each instance >> > from the command line and monitors. >> >> Is it needed? Can't you just add id= to the -device

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-08-20 Thread Fabio Fantoni
Il 12/05/2014 16:32, Ross Philipson ha scritto: On 05/12/2014 05:05 AM, Ian Campbell wrote: On Fri, 2014-05-09 at 13:32 -0400, Ross Philipson wrote: On 05/09/2014 12:34 PM, Paul Durrant wrote: -Original Message- From: Ian Campbell Sent: 09 May 2014 17:12 To: Konrad Rzeszutek Wilk Cc: R

Re: [Qemu-devel] [PATCH v7 3/4] s390x: Migrate to new NMI interface

2014-08-20 Thread Alexander Graf
On 20.08.14 14:11, Alexey Kardashevskiy wrote: > On 08/20/2014 10:05 PM, Alexander Graf wrote: >> >> >> On 20.08.14 13:38, Alexey Kardashevskiy wrote: >>> On 08/20/2014 09:20 PM, Alexander Graf wrote: On 20.08.14 12:20, Alexey Kardashevskiy wrote: > On 07/17/2014 04:30 PM, Alex

[Qemu-devel] [PATCH v8 2/5] s390x: Convert QEMUMachine to MachineClass

2014-08-20 Thread Alexey Kardashevskiy
This converts s390-virtio and s390-ccw-virtio machines to QOM MachineClass. This brings ability to add interfaces to the machine classes. The first interface for addition will be NMI. The patch is mechanical so no change in behavior is expected. Signed-off-by: Alexey Kardashevskiy Reviewed-by: C

[Qemu-devel] [PATCH v8 5/5] pc_piix: Migrate to new NMI interface

2014-08-20 Thread Alexey Kardashevskiy
This implements an NMI interface for i386 PC machines. This removes #ifdef I386 branch in qmp_inject_nmi so new i386's nmi() callback is going to be used for NMI. This changes code to inject NMI on the current CPU instead of injecting it on every CPU. However that does not seem to be an issue. S

[Qemu-devel] [PATCH v8 3/5] s390x: Migrate to new NMI interface

2014-08-20 Thread Alexey Kardashevskiy
This implements an NMI interface for s390 and s390-ccw machines. This removes #ifdef s390 branch in qmp_inject_nmi so new s390's nmi_monitor_handler() callback is going to be used for NMI. Since nmi_monitor_handler()-calling code is platform independent, CPUState::cpu_index is used instead of S39

Re: [Qemu-devel] QEMU block layer todo list

2014-08-20 Thread Benoît Canet
The Wednesday 20 Aug 2014 à 09:57:39 (+0200), Christian Borntraeger wrote : > On 19/08/14 16:20, Stefan Hajnoczi wrote: > > The following wiki page contains a list of proposed tasks for the QEMU > > block layer: > > > > http://qemu-project.org/Features/Block/Todo > > > > Benoit requested that we

Re: [Qemu-devel] [PATCH v7 3/4] s390x: Migrate to new NMI interface

2014-08-20 Thread Alexey Kardashevskiy
On 08/20/2014 10:05 PM, Alexander Graf wrote: > > > On 20.08.14 13:38, Alexey Kardashevskiy wrote: >> On 08/20/2014 09:20 PM, Alexander Graf wrote: >>> >>> >>> On 20.08.14 12:20, Alexey Kardashevskiy wrote: On 07/17/2014 04:30 PM, Alexey Kardashevskiy wrote: > On 07/15/2014 06:29 AM, Pao

[Qemu-devel] [PATCH v8 4/5] spapr: Add support for new NMI interface

2014-08-20 Thread Alexey Kardashevskiy
This implements an NMI interface POWERPC SPAPR machine. This enables an "nmi" HMP/QMP command supported on SPAPR. This calls POWERPC_EXCP_RESET (vector 0x100) in the guest to deliver NMI to every CPU. The expected result is XMON (in-kernel debugger) invocation. Signed-off-by: Alexey Kardashevskiy

[Qemu-devel] [PATCH v8 1/5] cpus: Define callback for QEMU "nmi" command

2014-08-20 Thread Alexey Kardashevskiy
This introduces an NMI (Non Maskable Interrupt) interface with a single nmi_monitor_handler() method. A machine or a device can implement it. This searches for an QOM object with this interface and if it is implemented, calls it. The callback implements an action required to cause debug crash dump

[Qemu-devel] [PATCH v8 0/5] cpus: Add generic "nmi" monitor command support

2014-08-20 Thread Alexey Kardashevskiy
This adds an "nmi" monitor command handler per CPUs. x86, s390 and ppc CPUS are supported. Please comment. Thanks. Changes: v8: * adjusted commit log for s390 patch * fixed missing "static" in 1/4 v7: * fixed typenames, function names, copyrights * s390x QOM'ed for later addition of the NMI int

Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function

2014-08-20 Thread Michael S. Tsirkin
On Wed, Aug 20, 2014 at 02:06:38PM +0200, Markus Armbruster wrote: > Knut Omang writes: > > > On Wed, 2014-08-20 at 10:52 +0200, Paolo Bonzini wrote: > >> Il 20/08/2014 08:53, Knut Omang ha scritto: > >> > A unique bus name is necessary to be able to refer to each instance > >> > from the command

[Qemu-devel] [PATCH] kvm: run cpu state synchronization on target vcpu thread

2014-08-20 Thread David Hildenbrand
As already done for kvm_cpu_synchronize_state(), let's trigger kvm_arch_put_registers() via run_on_cpu() for kvm_cpu_synchronize_post_reset() and kvm_cpu_synchronize_post_init(). This way, we make sure that the register synchronizing ioctls are called from the proper vcpu thread; this avoids calls

Re: [Qemu-devel] [Bug] QEMU crashed with latest qemu master tree code

2014-08-20 Thread Gonglei
Hi, Anyone encounter the same issue with me? Thanks. Best regards, -Gonglei > -Original Message- > Subject: [Qemu-devel] [Bug] QEMU crashed with latest qemu master tree code > > Hi, > > Command line: > > #./qemu-system-x86_64 -enable-kvm -m 2048 -machine q35 -device > ide-drive,bus=i

Re: [Qemu-devel] Recent SeaBIOS too big for QEMU -initrd

2014-08-20 Thread Stefan Hajnoczi
On Wed, Aug 20, 2014 at 12:27 PM, Michael S. Tsirkin wrote: > On Wed, Aug 20, 2014 at 11:27:41AM +0100, Stefan Hajnoczi wrote: >> The QEMU -initrd option loads the initrd at the top of RAM. There is >> a 64 KB safety region for ACPI tables in hw/i386/pc.c:load_linux(): >> >> initrd_max = max_ra

Re: [Qemu-devel] [PATCH v5 00/15] TriCore architecture guest implementation

2014-08-20 Thread Bastian Koppelmann
ping, anyone? Patchwork links: 01: https://patchwork.ozlabs.org/patch/379594/ 02: https://patchwork.ozlabs.org/patch/379598/ 03: https://patchwork.ozlabs.org/patch/379600/ 04: https://patchwork.ozlabs.org/patch/379588/ 05: https://patchwork.ozlabs.org/patch/379589/ 06: ht

Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function

2014-08-20 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Wed, Aug 20, 2014 at 02:06:38PM +0200, Markus Armbruster wrote: >> Knut Omang writes: >> >> > On Wed, 2014-08-20 at 10:52 +0200, Paolo Bonzini wrote: >> >> Il 20/08/2014 08:53, Knut Omang ha scritto: >> >> > A unique bus name is necessary to be able to refer to

Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function

2014-08-20 Thread Knut Omang
On Wed, 2014-08-20 at 13:36 +0200, Michael S. Tsirkin wrote: > On Wed, Aug 20, 2014 at 11:30:55AM +0200, Knut Omang wrote: > > On Wed, 2014-08-20 at 10:52 +0200, Paolo Bonzini wrote: > > > Il 20/08/2014 08:53, Knut Omang ha scritto: > > > > A unique bus name is necessary to be able to refer to each

Re: [Qemu-devel] [PATCH 1/4] hd-geometry.c: Integrate HDIO_GETGEO in guessing for target-s390x

2014-08-20 Thread Paolo Bonzini
Il 20/08/2014 11:35, Christian Borntraeger ha scritto: > On 20/08/14 10:19, Paolo Bonzini wrote: >> Il 29/07/2014 14:27, Ekaterina Tumanova ha scritto: >>> The new HDIO_GETGEO logic is required for two use cases: >>> a) Support for geometries of Direct Attached Storage Disks (DASD) >>> on s390x con

Re: [Qemu-devel] [PATCH v7 3/4] s390x: Migrate to new NMI interface

2014-08-20 Thread Paolo Bonzini
Il 20/08/2014 14:12, Alexander Graf ha scritto: > > > On 20.08.14 14:11, Alexey Kardashevskiy wrote: >> On 08/20/2014 10:05 PM, Alexander Graf wrote: >>> >>> >>> On 20.08.14 13:38, Alexey Kardashevskiy wrote: On 08/20/2014 09:20 PM, Alexander Graf wrote: > > > On 20.08.14 12:20,

Re: [Qemu-devel] [PATCH v5 00/15] TriCore architecture guest implementation

2014-08-20 Thread Andreas Färber
Hi, Am 13.08.2014 14:07, schrieb Bastian Koppelmann: > arch_init.c |2 + > configure |5 + > cpu-exec.c | 11 +- > cpus.c |6 + > default-configs/tricore-softmmu.mak |3 + > h

Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function

2014-08-20 Thread Paolo Bonzini
Il 20/08/2014 15:03, Markus Armbruster ha scritto: >> > >> > This is for the root bus, I think it won't help Knut who's trying to >> > add devices behind root ports. > Read again, more slowly :) > > Yes, I null the name of the root bus. That makes the qdev machinery > derive the very same "pcie.0

Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function

2014-08-20 Thread Paolo Bonzini
Il 20/08/2014 13:36, Michael S. Tsirkin ha scritto: > > For pci bridges, unless you set bus_name, bus name will > match device itself. See this code: > > * If we don't specify the name, the bus will be addressed as > * .0, where id is the device id. > * Since PCI Bridge devices hav

Re: [Qemu-devel] [PATCH v8] slirp/misc: Use the GLib memory allocation APIs

2014-08-20 Thread Benoît Canet
The Tuesday 19 Aug 2014 à 16:30:17 (+0800), zhanghailiang wrote : > Here we don't check the return value of malloc() which may fail. > Use the g_new() instead, which will abort the program when > there is not enough memory. > > Also, use g_strdup instead of strdup and remove the unnecessary > strd

Re: [Qemu-devel] [PATCH 2/6] stubs: Add iohandler.c

2014-08-20 Thread Paolo Bonzini
Il 20/08/2014 12:01, Fam Zheng ha scritto: > Add stub function "qemu_set_fd_handler" which is used by > util/event_notifier-posix.c. > > Signed-off-by: Fam Zheng > --- > stubs/Makefile.objs | 1 + > stubs/iohandler.c | 20 > 2 files changed, 21 insertions(+) > create mod

Re: [Qemu-devel] [PATCH 3/6] stubs: Add openpty.c

2014-08-20 Thread Paolo Bonzini
Il 20/08/2014 12:01, Fam Zheng ha scritto: > Add function "openpty" which is used by util/qemu-openpty.c. > > Signed-off-by: Fam Zheng > --- > stubs/Makefile.objs | 1 + > stubs/openpty.c | 21 + > 2 files changed, 22 insertions(+) > create mode 100644 stubs/openpty.c >

Re: [Qemu-devel] [PATCH 4/6] stubs: Add timer.c

2014-08-20 Thread Paolo Bonzini
Il 20/08/2014 12:01, Fam Zheng ha scritto: > Add timer functions that are used in util/throttle.c. > > Signed-off-by: Fam Zheng > --- > stubs/Makefile.objs | 1 + > stubs/timer.c | 44 > 2 files changed, 45 insertions(+) > create mode 100644 s

Re: [Qemu-devel] [PATCH 5/6] build-sys: Change libqemuutil.a to qemuutil.o and link whole object

2014-08-20 Thread Paolo Bonzini
Il 20/08/2014 12:01, Fam Zheng ha scritto: > + > +qemuutil.o: CC_REL_FLAGS := -Wl,-r Why the target-specific rule? > +qemuutil.o: $(util-obj-y) > + $(call quiet-command,$(CC) -nostdlib $(CC_REL_FLAGS) -o $@ $^," LD -r > $(TARGET_DIR)$@") > I think either you have LD_REL := $(CC) -nost

Re: [Qemu-devel] [PATCH 6/6] iscsi: Move iqn generation code to util

2014-08-20 Thread Paolo Bonzini
Il 20/08/2014 12:01, Fam Zheng ha scritto: > Function qmp_query_uuid, even with a version in libqemustub.a, is not > present in qemu-img, unless we move it to something that is linked with > block-obj-y. Since it's a helper function, move it to util makes sense. > > Signed-off-by: Fam Zheng > ---

Re: [Qemu-devel] [PATCH 1/6] build-sys: Move fifio8 to hw/

2014-08-20 Thread Paolo Bonzini
Typo in the subject, and please set up git to do rename detection correctly. I still could review the patch by checking the hashes in the "index" lines, so: Reviewed-by: Paolo Bonzini Il 20/08/2014 12:01, Fam Zheng ha scritto: > Since it has a dependency on vmstate and is only used by device >

Re: [Qemu-devel] [PATCH v5 00/15] TriCore architecture guest implementation

2014-08-20 Thread Bastian Koppelmann
Hi Andreas, On 08/20/2014 02:17 PM, Andreas Färber wrote: Hi, Am 13.08.2014 14:07, schrieb Bastian Koppelmann: arch_init.c |2 + configure |5 + cpu-exec.c | 11 +- cpus.c |

[Qemu-devel] [PATCH] vmxnet3: Pad short frames to minimum size (60 bytes)

2014-08-20 Thread Ben Draper
When running VMware ESXi under qemu-kvm the guest discards frames that are too short. Short ARP Requests will be dropped, this prevents guests on the same bridge as VMware ESXi from communicating. This patch simply adds the padding on the network device itself. Signed-off-by: Ben Draper --- hw/n

[Qemu-devel] qemu-kvm process soft lockup cpu, results in server crush

2014-08-20 Thread yue
hi, i encounter several times my server crushs because qemu-kvm process locks cpu. thanks --log--- Aug 18 22:07:05 localhost kernel: [4625821.185649] nf_conntrack: table full, dropping packet. Aug 18 22:07:05 localhost kernel: [4625821.192085] nf_conntrack: table full, dropp

Re: [Qemu-devel] QEMU, self-modifying code, and Windows 7 64-bit (no KVM)

2014-08-20 Thread Hulin, Patrick - 0559 - MITLL
On Aug 19, 2014, at 2:16 AM, Paolo Bonzini wrote: > Il 18/08/2014 22:50, Hulin, Patrick - 0559 - MITLL ha scritto: Correct. Doesn¹t work. Haven¹t fully diagnosed why, but it doesn¹t seem to ever hit the current_tb_modified passage if you invalidate beforehand. >> Yeah - mem_io_pc doesn¹

[Qemu-devel] Commit d8d95814609e89e5438a3318a647ec322fc4ff16 seems to break ioh3420

2014-08-20 Thread Knut Omang
I am struggling with the latest master and -device ioh3420,slot=0,id=pcie_port.0 as argument. I bisected it down to: d8d95814609e89e5438a3318a647ec322fc4ff16 is the first bad commit commit d8d95814609e89e5438a3318a647ec322fc4ff16 Author: Paolo Bonzini Date: Wed Jun 11 12:42:01 2014 +0200

Re: [Qemu-devel] [PATCH v5 01/15] target-tricore: Add target stubs and qom-cpu

2014-08-20 Thread Richard Henderson
On 08/13/2014 05:07 AM, Bastian Koppelmann wrote: > Add TriCore target stubs, and QOM cpu. > > Signed-off-by: Bastian Koppelmann > --- > v4 -> v5: > - Change documentation of S, SV bits to use bit 31. > - psw_read/_write now uses only bit 31 of S, SV bits. Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH v5 03/15] target-tricore: Add softmmu support

2014-08-20 Thread Richard Henderson
On 08/13/2014 05:07 AM, Bastian Koppelmann wrote: > +*prot = PAGE_READ | PAGE_WRITE; No execute permission? r~

Re: [Qemu-devel] [PATCH 1/6] build-sys: Move fifio8 to hw/

2014-08-20 Thread Peter Crosthwaite
On Wed, Aug 20, 2014 at 8:01 PM, Fam Zheng wrote: > Since it has a dependency on vmstate and is only used by device > emulation, moving out from util will make the archive more independent. > > Signed-off-by: Fam Zheng > --- > hw/Makefile.objs | 1 + > hw/fifo8.c | 125 > +++

Re: [Qemu-devel] Commit d8d95814609e89e5438a3318a647ec322fc4ff16 seems to break ioh3420

2014-08-20 Thread Knut Omang
Seems very similar to what Gonglei just reported... Knut On Wed, 2014-08-20 at 16:10 +0200, Knut Omang wrote: > I am struggling with the latest master and > > -device ioh3420,slot=0,id=pcie_port.0 > > as argument. I bisected it down to: > > d8d95814609e89e5438a3318a647ec322fc4ff16 is the firs

  1   2   3   >