Re: [Qemu-devel] [Intel-gfx] ResettRe: [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-29 Thread Chen, Tiejun
On 2014/7/26 1:01, Konrad Rzeszutek Wilk wrote: On Thu, Jul 24, 2014 at 09:44:41AM +0800, Chen, Tiejun wrote: On 2014/7/24 4:54, Konrad Rzeszutek Wilk wrote: On Sat, Jul 19, 2014 at 12:27:21AM +, Kay, Allen M wrote: For the MCH PCI registers that do need to be read - can you tell us which

Re: [Qemu-devel] [PATCH for-2.2 v2 0/5] scsi: enable passthrough of vendor-specific commands

2014-07-29 Thread Fam Zheng
On Mon, 07/28 17:08, Paolo Bonzini wrote: > Right now scsi-generic is parsing the CDB, in order to compute > the expected number of bytes to be transferred. This is necessary > if DMA is done by the HBA via scsi_req_data, but it prevents executing > vendor-specific commands via scsi-generic becaus

[Qemu-devel] [RESEND PATCH V3] qemu-img info: show nocow info

2014-07-29 Thread Chunyan Liu
Add nocow info in 'qemu-img info' output to show whether the file currently has NOCOW flag set or not. Signed-off-by: Chunyan Liu Acked-by: Eric Blake --- Resend for QEMU 2.2. Change json version comment. block/qapi.c | 25 + qapi/block-core.json | 5 - 2 f

Re: [Qemu-devel] [PATCH] [RFC] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-07-29 Thread Alex Bligh
Serge, > I don't think that is in any way a problem. Is migrating to older > versions ever actually expected to work? In either case I don't > think for this particular case it's a problem. Good; no; and good - respectively. > (The "how to handle this in libvirt" question is more interesting)

Re: [Qemu-devel] [PATCH 3/5] scsi-block: extract scsi_block_is_passthrough

2014-07-29 Thread Paolo Bonzini
Il 29/07/2014 08:28, Fam Zheng ha scritto: >> > + >> > +default: >> > +break; > Out of curiosity, why add this default branch? No particular reason, I guess I've changed my style since I wrote this code! Paolo

Re: [Qemu-devel] Dynamic QEMU platform device instantiation in machine files: phone call on Wed July 30

2014-07-29 Thread Eric Auger
Hi Markus, Thank you for the proposal. Actually quite a lot of people are now OK with this time slot. This phone call was organized in non std way since Alex was not available next week. If you don't mind I would now prefer to keep this slot. Do you wish to join by the way? Best Regards Eric On

Re: [Qemu-devel] [PATCH 1/3] loader: add support for resizeable blobs

2014-07-29 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Mon, Jul 28, 2014 at 05:52:27PM +0100, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > Support resizeable blobs: we allocate more memory than currently > > > available in the blob, which can later be filled in.

[Qemu-devel] [Bug 1349722] [NEW] qemu-io: Exit code is always zero

2014-07-29 Thread Maria Kustova
Public bug reported: The qemu-io always returns zero on exit independently on errors occurred during the command execution. Example, $ qemu-io -c 'write 128 234' /tmp/run1/test-1/test.img offset 128 is not sector aligned $ echo $? 0 qemu.git HEAD: 41a1a9c42c4e ** Affects: qemu Importan

Re: [Qemu-devel] [PATCH] piix: set legacy table size for 1.7

2014-07-29 Thread Paolo Bonzini
Il 28/07/2014 23:01, Michael S. Tsirkin ha scritto: > Signed-off-by: Michael S. Tsirkin > --- > > Paolo, so the following is needed on top of your patch? > > hw/i386/pc_piix.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index 4524e6b..9694f8

Re: [Qemu-devel] [PATCH] acpi-build: tweak acpi migration limits

2014-07-29 Thread Paolo Bonzini
Il 28/07/2014 23:15, Michael S. Tsirkin ha scritto: > - Tweak error message for legacy machine type: > Basically if table size exceeds the limits we set all > bets are off for migration: e.g. it can start failing even > within given qemu minor version simply because of a bugfix. > - Increase

Re: [Qemu-devel] [Intel-gfx] ResettRe: [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-29 Thread Paolo Bonzini
Il 29/07/2014 08:59, Chen, Tiejun ha scritto: >> >> (see https://lkml.org/lkml/2014/6/19/121) >>> "gpu:drm:i915:intel_detect_pch: back to check devfn instead of check >>> class >>> type". Because Windows always use this way, so I think this point >>> should be >>> same between Linux and Windows. >>

Re: [Qemu-devel] [PATCH for-2.2 1/2] rename parse_enum_option to qapi_enum_parse and make it public

2014-07-29 Thread Paolo Bonzini
Il 28/07/2014 22:06, Peter Lieven ha scritto: >> > ...but you have relaxed the license to LGPLv2+ in your code motion. >> > Then again, Peter is the original author of this code in commit >> > 82a402e9, so you have the legal right to relax things. > Actually, I was not aware. I just took Hu Taos or

Re: [Qemu-devel] [PATCH] target-mips: Ignore unassigned accesses with KVM

2014-07-29 Thread Paolo Bonzini
Il 28/07/2014 23:36, Aurelien Jarno ha scritto: > On Mon, Jul 28, 2014 at 12:37:50PM +0100, James Hogan wrote: >> MIPS registers an unassigned access handler which raises a guest bus >> error exception. However this causes QEMU to crash when KVM is enabled >> as it isn't called from the main execut

Re: [Qemu-devel] Dynamic QEMU platform device instantiation in machine files: phone call on Wed July 30

2014-07-29 Thread Markus Armbruster
Eric Auger writes: > Hi Markus, > > Thank you for the proposal. Actually quite a lot of people are now OK > with this time slot. This phone call was organized in non std way since > Alex was not available next week. If you don't mind I would now prefer > to keep this slot. Let's keep it. Don't

Re: [Qemu-devel] [Intel-gfx] ResettRe: [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-29 Thread Chen, Tiejun
On 2014/7/29 16:32, Paolo Bonzini wrote: Il 29/07/2014 08:59, Chen, Tiejun ha scritto: (see https://lkml.org/lkml/2014/6/19/121) "gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type". Because Windows always use this way, so I think this point should be same between L

Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function

2014-07-29 Thread Gonglei (Arei)
Hi, Gerd > > > > > > > I think it is ok to allow only *changing* the bootindex. > > > > > > > > > > > > > Yes, that's no problem. > > > > > > > > > > But then yoy always will have a old entry where you can take the > > > > > suffix > > > > > from, and you don't need the suffix as parameter for t

Re: [Qemu-devel] [PATCH 4/5] bios-tables-test: fix ASL normalization false positive

2014-07-29 Thread Laszlo Ersek
On 07/28/14 17:34, Paolo Bonzini wrote: > My version of IASL (from RHEL7) puts two newlines between the head comment > and the DefinitionBlock property. Kill all newlines after the comment, > so that normalize_asl works properly. > > Signed-off-by: Paolo Bonzini > --- > tests/bios-tables-test.c

Re: [Qemu-devel] Dynamic QEMU platform device instantiation in machine files: phone call on Wed July 30

2014-07-29 Thread Eric Auger
On 07/29/2014 11:07 AM, Markus Armbruster wrote: > Eric Auger writes: > >> Hi Markus, >> >> Thank you for the proposal. Actually quite a lot of people are now OK >> with this time slot. This phone call was organized in non std way since >> Alex was not available next week. If you don't mind I wou

Re: [Qemu-devel] [PATCH v4 0/5] ACPI fixes for QEMU 2.1

2014-07-29 Thread Laszlo Ersek
On 07/28/14 23:27, Michael S. Tsirkin wrote: > On Mon, Jul 28, 2014 at 05:34:13PM +0200, Paolo Bonzini wrote: >> v3->v4: >> drop all pretense of supporting bridges [me] >> >> v2->v3: >> fix tests/acpi-test-data/pc/DSDT [Peter] >> track down "make check" failure, fix it [patch 4, me]

[Qemu-devel] [PATCH] acpi-build: minor code cleanup

2014-07-29 Thread Michael S. Tsirkin
Fix up and add comments to clarify code, plus a trivial code change for clarity. Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-build.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 779160f..ec86f1b

Re: [Qemu-devel] [PATCH v4 0/5] ACPI fixes for QEMU 2.1

2014-07-29 Thread Michael S. Tsirkin
On Tue, Jul 29, 2014 at 12:25:56PM +0200, Laszlo Ersek wrote: > On 07/28/14 23:27, Michael S. Tsirkin wrote: > > On Mon, Jul 28, 2014 at 05:34:13PM +0200, Paolo Bonzini wrote: > >> v3->v4: > >>drop all pretense of supporting bridges [me] > >> > >> v2->v3: > >>fix tests/acpi-test-data/pc/DSD

Re: [Qemu-devel] [PATCH v4 0/5] ACPI fixes for QEMU 2.1

2014-07-29 Thread Paolo Bonzini
Il 29/07/2014 12:31, Michael S. Tsirkin ha scritto: > > For patch "piix: set legacy table size for 1.7": didn't Igor say > > something that such a migration wouldn't work anyway? I could be > > remembering wrong. > > I don't recall this, but if there are more bug we could just > fix them too. You

[Qemu-devel] [PULL 0/8] pc migration fixes

2014-07-29 Thread Michael S. Tsirkin
The following changes since commit c60a57ff497667780132a3fcdc1500c83af5d5c0: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2014-07-25 16:58:41 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream

[Qemu-devel] [PULL 2/8] pc: hack for migration compatibility from QEMU 2.0

2014-07-29 Thread Michael S. Tsirkin
From: Paolo Bonzini Changing the ACPI table size causes migration to break, and the memory hotplug work opened our eyes on how horribly we were breaking things in 2.0 already. The ACPI table size is rounded to the next 4k, which one would think gives some headroom. In practice this is not the c

[Qemu-devel] [PULL 7/8] acpi-build: tweak acpi migration limits

2014-07-29 Thread Michael S. Tsirkin
- Tweak error message for legacy machine type: Basically if table size exceeds the limits we set all bets are off for migration: e.g. it can start failing even within given qemu minor version simply because of a bugfix. - Increase table size to 128k. - Make sure we notice it long before we st

[Qemu-devel] [PULL 8/8] piix: set legacy table size for 1.7

2014-07-29 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- hw/i386/pc_piix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 4524e6b..9694f88 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -326,6 +326,7 @@ static void pc_compat_1_7(MachineState *machine)

[Qemu-devel] [PULL 5/8] acpi-build: minor code cleanup

2014-07-29 Thread Michael S. Tsirkin
Fix up and add comments to clarify code, plus a trivial code change for clarity. Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-build.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 779160f..ec86f1b

[Qemu-devel] [PULL 1/8] acpi-dsdt: procedurally generate _PRT

2014-07-29 Thread Michael S. Tsirkin
From: Paolo Bonzini This replaces the _PRT constant with a method that computes it. The problem is that the DSDT+SSDT have grown from 2.0 to 2.1, enough to cross the 8k barrier (we align the ACPI tables to 4k before putting them in fw_cfg). This causes problems with migration and the pc-i440fx-

[Qemu-devel] [PULL 3/8] bios-tables-test: fix ASL normalization false positive

2014-07-29 Thread Michael S. Tsirkin
From: Paolo Bonzini My version of IASL (from RHEL7) puts two newlines between the head comment and the DefinitionBlock property. Kill all newlines after the comment, so that normalize_asl works properly. Signed-off-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Ts

[Qemu-devel] [PULL 4/8] pc: acpi: generate AML only for PCI0 devices if PCI bridge hotplug is disabled

2014-07-29 Thread Michael S. Tsirkin
From: Igor Mammedov Fixes migration regression from QEMU-1.7 to a newer QEMUs. SSDT table size in QEMU-1.7 doesn't change regardless of a number of PCI bridge devices present at startup. However in QEMU-2.0 since addition of hotplug on PCI bridges, each PCI bridge adds ~1875 bytes to SSDT table,

[Qemu-devel] [PULL 6/8] pc: future-proof migration-compatibility of ACPI tables

2014-07-29 Thread Michael S. Tsirkin
From: Paolo Bonzini This patch avoids that similar changes break QEMU again in the future. QEMU will now hard-code 64k as the maximum ACPI table size, which (despite being an order of magnitude smaller than 640k) should be enough for everyone. Reviewed-by: Laszlo Ersek Tested-by: Igor Mammedov

[Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-29 Thread Stefan Berger
From: Stefan Berger Add an SSDT ACPI table for the TPM device. Add a TCPA table for BIOS logging area when a TPM is being used. The latter follows this spec here: http://www.trustedcomputinggroup.org/files/static_page_files/DCD4188E-1A4B-B294-D050A155FB6F7385/TCG_ACPIGeneralSpecification_Public

[Qemu-devel] [Bug 1343827] Re: block.c: multiwrite_merge() truncates overlapping requests

2014-07-29 Thread Stefan Hajnoczi
Thanks for reporting this bug. I'm writing a test case and fix, will CC you on the patches. Please keep in mind that no ordering is guaranteed between requests that are in-flight at the same time. Therefore it is unusual to submit overlapping requests and could indicate a bug in the application.

Re: [Qemu-devel] [PATCH v4 0/5] ACPI fixes for QEMU 2.1

2014-07-29 Thread Laszlo Ersek
On 07/29/14 12:39, Paolo Bonzini wrote: > Il 29/07/2014 12:31, Michael S. Tsirkin ha scritto: >>> For patch "piix: set legacy table size for 1.7": didn't Igor say >>> something that such a migration wouldn't work anyway? I could be >>> remembering wrong. >> >> I don't recall this, but if there are

Re: [Qemu-devel] [PATCH 2/4] xen:hw:pci-host:piix: create host bridge to passthrough

2014-07-29 Thread Michael S. Tsirkin
On Thu, Jul 24, 2014 at 07:30:27PM +0800, Tiejun Chen wrote: > Implement that pci s/that/a/ > host bridge to specific s/to specific/specific/ > to passthrough. Actually > this just inherit s/inherit/inherits/ > the standard one. > > This is based on http://patchwork.ozlabs.org/patch/363810/.

Re: [Qemu-devel] [PATCH 3/4] xen:hw:pci-host:piix: introduce xen_igd_i440fx_init

2014-07-29 Thread Michael S. Tsirkin
On Thu, Jul 24, 2014 at 07:30:28PM +0800, Tiejun Chen wrote: > This is almost same as an original i440fx_init but just > work with that xen igd host bridge to passthrough. > > Signed-off-by: Tiejun Chen > --- > hw/pci-host/piix.c | 79 > >

Re: [Qemu-devel] [PATCH 1/4] hw:i386:pc_piix: split pc_init1()

2014-07-29 Thread Michael S. Tsirkin
On Thu, Jul 24, 2014 at 07:30:26PM +0800, Tiejun Chen wrote: > We'd like to split pc_init1 and then we can share something > with other stuff. > > Signed-off-by: Tiejun Chen Did you test this patch? It does not look like it can work. > --- > hw/i386/pc_piix.c | 93 > ++

[Qemu-devel] [PATCH] fix vcpu long time io blocking on tap, when too many packets was delivered to the guest os via tap interface.

2014-07-29 Thread Wangkai
Signed-off-by: Wangkai --- net/tap.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/net/tap.c b/net/tap.c index a40f7f0..9a59934 100644 --- a/net/tap.c +++ b/net/tap.c @@ -189,6 +189,7 @@ static void tap_send(void *opaque) { TAPState *s = opaque;

Re: [Qemu-devel] [PATCH 4/4] xen:hw:i386:pc_piix: introduce new machine for IGD passthrough

2014-07-29 Thread Michael S. Tsirkin
On Thu, Jul 24, 2014 at 07:30:29PM +0800, Tiejun Chen wrote: > Now we can introduce a new machine, xenigd, specific to IGD > passthrough. This can avoid involving other common codes. > > Signed-off-by: Tiejun Chen > --- > hw/i386/pc_piix.c | 87 >

Re: [Qemu-devel] [PATCH/RFC 4/5] s390x/kvm: test whether a cpu is STOPPED when checking "has_work"

2014-07-29 Thread Christian Borntraeger
On 28/07/14 16:22, Alexander Graf wrote: > > On 28.07.2014, at 16:16, David Hildenbrand wrote: > >>> >>> On 10.07.14 15:10, Christian Borntraeger wrote: From: David Hildenbrand If a cpu is stopped, it must never be allowed to run and no interrupt may wake it up. A cpu

[Qemu-devel] [Bug 1224444] Re: virtio-serial loses writes when used over virtio-mmio

2014-07-29 Thread Richard Jones
FWIW I am able to reproduce this quite easily on aarch64 too. My test program is: https://github.com/libguestfs/libguestfs/blob/master/tests/qemu/qemu-speed-test.c and you use it like this: qemu-speed-test --virtio-serial-upload (You can also test virtio-serial downloads and a few other things,

Re: [Qemu-devel] [PATCH/RFC 4/5] s390x/kvm: test whether a cpu is STOPPED when checking "has_work"

2014-07-29 Thread Alexander Graf
On 29.07.14 13:44, Christian Borntraeger wrote: On 28/07/14 16:22, Alexander Graf wrote: On 28.07.2014, at 16:16, David Hildenbrand wrote: On 10.07.14 15:10, Christian Borntraeger wrote: From: David Hildenbrand If a cpu is stopped, it must never be allowed to run and no interrupt may wake

[Qemu-devel] Live migration debugging

2014-07-29 Thread Paul Boven
Hi folks, Recently there's been several patches to fix kvmclock issues during migrations, which were subsequently reverted. I hope the observations below can be helpful in pinning down the actual issues to make live migration work again in the future. Live migration has been broken since at

Re: [Qemu-devel] [PATCH v2] Tap: fix vcpu long time io blocking on tap

2014-07-29 Thread Wangkai (Kevin,C)
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Monday, July 28, 2014 11:53 PM > To: Wangkai (Kevin,C) > Cc: qemu-devel@nongnu.org; Lee yang; aligu...@amazon.com; Stefan > Hajnoczi > Subject: Re: [Qemu-devel] [PATCH v2] Tap: fix vcpu long time io > blockin

Re: [Qemu-devel] [RFC PATCH v2 07/49] kvmapic: fixing loading vmstate

2014-07-29 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Il 17/07/2014 13:02, Pavel Dovgalyuk ha scritto: > > diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c > > index ce3d903..9d75ee0 100644 > > --- a/hw/intc/apic_common.c > > +++ b/hw/intc/apic_common.c >

Re: [Qemu-devel] [RFC PATCH v2 07/49] kvmapic: fixing loading vmstate

2014-07-29 Thread Paolo Bonzini
Il 29/07/2014 14:03, Pavel Dovgaluk ha scritto: >> > >> > This could be a subsection. sipi_vector is only used (needed) if >> > wait_for_sipi != 0. > Right, sipi_vector is used when wait_for_sipi != 0. But we can set > sipi_vector to non-zero, > save the snapshot, and then set wait_for_sipi.

Re: [Qemu-devel] [PATCH v6 3/3] sclp-s390: Add memory hotplug SCLPs

2014-07-29 Thread Christian Borntraeger
On 30/06/14 16:00, Matthew Rosato wrote: > Add memory information to read SCP info and add handlers for > Read Storage Element Information, Attach Storage Element, > Assign Storage and Unassign > > Signed-off-by: Matthew Rosato > --- > hw/s390x/sclp.c| 259 > +++

Re: [Qemu-devel] [PULL 0/8] pc migration fixes

2014-07-29 Thread Peter Maydell
On 29 July 2014 11:48, Michael S. Tsirkin wrote: > The following changes since commit c60a57ff497667780132a3fcdc1500c83af5d5c0: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2014-07-25 16:58:41 +0100) > > are available in the git repository at: > > git:/

[Qemu-devel] [PATCH 0/4] Geometry and blocksize support for backing devices

2014-07-29 Thread Ekaterina Tumanova
This patch set is based on a patch suggested by Einar Lueck on Feb 08, 2013. This patch set introduces: 1. s390x specific geometry detection: Add s390 specific version of hd_geometry_guess function, which uses HDIO_GETGEO ioctl. 2. A set of blocksize patches for autodetection of logical and physi

[Qemu-devel] [PATCH 3/4] blocksize: Add driver method to get the blocksizes

2014-07-29 Thread Ekaterina Tumanova
This patch introduces a new method of defining the physical and logical blocksizes for "raw" and "host_device" drivers. It uses various ioctls to determine the logical and physical blocksizes. For detecting the logical size it uses ioctl calls, that were previously coded in raw_probe_alignment (no

[Qemu-devel] [PATCH 2/4] blocksize: support auto-sensing of blocksizes

2014-07-29 Thread Ekaterina Tumanova
The block device model does not impose fixed block sizes for access to backing devices. This patch introduces support for auto lookup of the block sizes of the backing block device. To achieve this, a new function blkconf_blocksizes is implemented. This function tries to get values from the block

[Qemu-devel] [PATCH 1/4] hd-geometry.c: Integrate HDIO_GETGEO in guessing for target-s390x

2014-07-29 Thread Ekaterina Tumanova
This patch extends the function hd_geometry_guess. It introduces a target specific hook. The default implementation for this target specific hook is empty, has therefore no effect and the existing logic works as before. For target-s390x, the behaviour is chosen as follows: If no geo could be guess

[Qemu-devel] [PATCH 4/4] blocksize: add blkconf_blocksize call to all block devices

2014-07-29 Thread Ekaterina Tumanova
This patch add the blkconf_blocksize call to all devices, which use DEFINE_BLOCK_PROPERTIES. If the underlying driver function fails, blkconf_blocksizes will set blocksizes to default (512) value. Signed-off-by: Ekaterina Tumanova Reviewed-by: David Hildenbrand Acked-by: Cornelia Huck --- hw/b

Re: [Qemu-devel] [PATCH 0/4] Geometry and blocksize support for backing devices

2014-07-29 Thread Christian Borntraeger
On 29/07/14 14:27, Ekaterina Tumanova wrote: > This patch set is based on a patch suggested by Einar Lueck > on Feb 08, 2013. > > This patch set introduces: > 1. s390x specific geometry detection: > Add s390 specific version of hd_geometry_guess function, > which uses HDIO_GETGEO ioctl. > > 2. A

Re: [Qemu-devel] [PATCH for-2.1] po: Update French translation

2014-07-29 Thread Peter Maydell
On 28 July 2014 22:44, Aurelien Jarno wrote: > Add new translations for recently added messages. > > Signed-off-by: Aurelien Jarno > --- > po/fr_FR.po | 54 +++--- Applied, thanks. -- PMM

Re: [Qemu-devel] [PATCH for-2.1] po: update Italian translation

2014-07-29 Thread Peter Maydell
On 29 July 2014 07:15, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > po/it.po | 63 --- > 1 file changed, 40 insertions(+), 23 deletions(-) Applied, thanks. -- PMM

Re: [Qemu-devel] [Bug 1343827] [NEW] block.c: multiwrite_merge() truncates overlapping requests

2014-07-29 Thread Stefan Hajnoczi
On Mon, Jul 28, 2014 at 2:12 PM, Andrey Korolyov wrote: > bug is still here in the master and can be easily reproduced (and, of > course, looks like blocker since data corruption takes place). Does > anyone have an idea on when the fix (at least suggested one) will be > merged? I just sent the pa

Re: [Qemu-devel] [PATCH 2/2] target-mips/translate.c: Add judgement for msb and lsb

2014-07-29 Thread Elta
On 07/29/2014 06:52 AM, Aurelien Jarno wrote: On Mon, Jul 28, 2014 at 11:34:30PM +0100, Peter Maydell wrote: On 28 July 2014 23:32, Aurelien Jarno wrote: On Mon, Jul 28, 2014 at 11:01:02PM +0100, Peter Maydell wrote: This may be true, but the TCG README doesn't define negative lengths as bein

[Qemu-devel] [PATCH 0/2] block: fix multiwrite_merge() overlapping requests

2014-07-29 Thread Stefan Hajnoczi
This is a fix for https://bugs.launchpad.net/qemu/+bug/1343827. Patch 1 fixes the bug. Patch 2 adds a qemu-iotests test case to prevent regressions. Stefan Hajnoczi (2): block: fix overlapping multiwrite requests qemu-iotests: add multiwrite test cases block.c| 6 +++

[Qemu-devel] [PATCH 1/2] block: fix overlapping multiwrite requests

2014-07-29 Thread Stefan Hajnoczi
When request A is a strict subset of request B: multiwrite_merge() merges them as follows: AA The tail of request A should have been included: AAAA This patch fixes data loss but this code path is probably rare. Since guests cannot assume ordering between in-f

[Qemu-devel] [PATCH 2/2] qemu-iotests: add multiwrite test cases

2014-07-29 Thread Stefan Hajnoczi
This test case covers the basic bdrv_aio_multiwrite() scenarios: 1. Single request 2. Sequential requests 3. Overlapping requests 4. Disjoint requests Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/100 | 97 ++ tests/qemu-iotests/100.out | 5

Re: [Qemu-devel] [PATCH v2] Tap: fix vcpu long time io blocking on tap

2014-07-29 Thread Stefan Hajnoczi
On Tue, Jul 29, 2014 at 1:02 PM, Wangkai (Kevin,C) wrote: > > >> -Original Message- >> From: Stefan Hajnoczi [mailto:stefa...@gmail.com] >> Sent: Monday, July 28, 2014 11:53 PM >> To: Wangkai (Kevin,C) >> Cc: qemu-devel@nongnu.org; Lee yang; aligu...@amazon.com; Stefan >> Hajnoczi >> Subje

Re: [Qemu-devel] [PATCH RFC v2 02/12] reset handler for qdevified devices

2014-07-29 Thread Juan Quintela
Sanidhya Kashyap wrote: > I have added a structure containing the list of qdevified devices which have > been added to the SaveVMHandlers. Since, I was unable to find any particular > struct containing the information about all the qdevified devices. So, I have > created my own version, which is v

Re: [Qemu-devel] [RESEND PATCH V3] qemu-img info: show nocow info

2014-07-29 Thread Eric Blake
On 07/29/2014 01:18 AM, Chunyan Liu wrote: > Add nocow info in 'qemu-img info' output to show whether the file > currently has NOCOW flag set or not. > > Signed-off-by: Chunyan Liu > Acked-by: Eric Blake Actually, this should be Reviewed-by, not Acked-by. My understanding is that "Reviewed-by"

Re: [Qemu-devel] [PATCH RFC v2 03/12] VMState test: query command to extract the qdevified device names

2014-07-29 Thread Juan Quintela
Sanidhya Kashyap wrote: > I have provided a qmp interface for getting the list of qdevified devices > that have been registered with SaveVMHandlers. > > Signed-off-by: Sanidhya Kashyap > --- > qapi-schema.json | 22 ++ > qmp-commands.hx | 25 + > save

Re: [Qemu-devel] [PATCH 1/2] block: fix overlapping multiwrite requests

2014-07-29 Thread Fam Zheng
On Tue, 07/29 13:41, Stefan Hajnoczi wrote: > When request A is a strict subset of request B: > > > s/subset/superset/ ? Fam

Re: [Qemu-devel] [PATCH 2/2] target-mips/translate.c: Add judgement for msb and lsb

2014-07-29 Thread Peter Maydell
On 28 July 2014 23:52, Aurelien Jarno wrote: > On Mon, Jul 28, 2014 at 11:34:30PM +0100, Peter Maydell wrote: >> On 28 July 2014 23:32, Aurelien Jarno wrote: >> > On Mon, Jul 28, 2014 at 11:01:02PM +0100, Peter Maydell wrote: >> >> This may be true, but the TCG README doesn't define negative >> >

Re: [Qemu-devel] [PATCH v5 2/2] vmdk: Optimize cluster allocation

2014-07-29 Thread Stefan Hajnoczi
On Tue, Jul 29, 2014 at 09:00:43AM +0800, Fam Zheng wrote: > On Mon, 07/28 16:11, Stefan Hajnoczi wrote: > > On Tue, May 27, 2014 at 04:49:22PM +0800, Fam Zheng wrote: > > > +if (!bs->backing_hd) { > > > +memset(whole_grain, 0, skip_start_sector << BDRV_SECTOR_BITS); > > > +mem

Re: [Qemu-devel] [PATCH 1/2] block: fix overlapping multiwrite requests

2014-07-29 Thread Stefan Hajnoczi
On Tue, Jul 29, 2014 at 1:46 PM, Fam Zheng wrote: > On Tue, 07/29 13:41, Stefan Hajnoczi wrote: >> When request A is a strict subset of request B: >> >> >> > > s/subset/superset/ ? Yes :)

Re: [Qemu-devel] [PATCH 2/3] qemu-char: add -chardev exit-on-eof option

2014-07-29 Thread Eric Blake
On 07/29/2014 12:12 AM, Markus Armbruster wrote: >> Libvirt probably won't use it for normal guests (we don't want to kill >> qemu just because the monitor disconnects), but does have the notion of >> an autodestroy guest where it might be useful (we WANT the guest to go >> away if libvirtd dies e

Re: [Qemu-devel] [PATCH] [RFC] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-07-29 Thread Serge E. Hallyn
Quoting Alex Bligh (a...@alex.org.uk): > Serge, > > > I don't think that is in any way a problem. Is migrating to older > > versions ever actually expected to work? In either case I don't > > think for this particular case it's a problem. > > Good; no; and good - respectively. > > > (The "how

Re: [Qemu-devel] [PATCH] [RFC] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-07-29 Thread Alex Bligh
On 29 Jul 2014, at 14:03, Serge E. Hallyn wrote: > That sounds good. > > And from there I think the thing to do will be to introduce a transient > alternate package that has the pc-1.0 alias pointing ot pc-1.0-qemu-kvm and > depends on the legacy pxe rom. And maybe users can then choose that p

Re: [Qemu-devel] [PATCH] [RFC] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-07-29 Thread Paolo Bonzini
Il 29/07/2014 15:03, Serge E. Hallyn ha scritto: > > And from there I think the thing to do will be to introduce a transient > alternate package that has the pc-1.0 alias pointing ot pc-1.0-qemu-kvm This should be done in the main package, too. > and depends on the legacy pxe rom. If you can ma

Re: [Qemu-devel] [PATCH] [RFC] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-07-29 Thread Serge Hallyn
Quoting Paolo Bonzini (pbonz...@redhat.com): > Il 29/07/2014 15:03, Serge E. Hallyn ha scritto: > > > > And from there I think the thing to do will be to introduce a transient > > alternate package that has the pc-1.0 alias pointing ot pc-1.0-qemu-kvm > > This should be done in the main package,

Re: [Qemu-devel] [PATCH v5 2/2] vmdk: Optimize cluster allocation

2014-07-29 Thread Fam Zheng
On Tue, 07/29 13:51, Stefan Hajnoczi wrote: > On Tue, Jul 29, 2014 at 09:00:43AM +0800, Fam Zheng wrote: > > On Mon, 07/28 16:11, Stefan Hajnoczi wrote: > > > On Tue, May 27, 2014 at 04:49:22PM +0800, Fam Zheng wrote: > > > > +if (!bs->backing_hd) { > > > > +memset(whole_grain, 0, skip

Re: [Qemu-devel] [PATCH for-2.1 0/2] qdev-monitor: include QOM device properties in -device FOO, help output

2014-07-29 Thread Stefan Hajnoczi
On Wed, Jul 09, 2014 at 02:01:30PM +0200, Stefan Hajnoczi wrote: > These two patches fix the -device FOO,help output regression that Cole spotted > in QEMU 2.0-rc0. The problem is that virtio-blk-pci qdev properties have been > converted to QOM alias properties but -device FOO,help shows only qdev

Re: [Qemu-devel] [PATCH] [RFC] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-07-29 Thread Paolo Bonzini
Il 29/07/2014 15:27, Serge Hallyn ha scritto: > Quoting Paolo Bonzini (pbonz...@redhat.com): >> Il 29/07/2014 15:03, Serge E. Hallyn ha scritto: >>> >>> And from there I think the thing to do will be to introduce a transient >>> alternate package that has the pc-1.0 alias pointing ot pc-1.0-qemu-kv

Re: [Qemu-devel] [PATCH] vmdk: improve streamOptimized vmdk support

2014-07-29 Thread Stefan Hajnoczi
On Mon, Jul 07, 2014 at 10:54:27AM -0400, Milos Vyletel wrote: > VMDK's streamOptimized format is different that regular sparse format. > L1(GD) and L2(GT) tables are not predefined but rather generated and > written during image creation mainly because there is no way to tell > how much space data

Re: [Qemu-devel] [PATCH] [RFC] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-07-29 Thread Alex Bligh
On 29 Jul 2014, at 14:21, Paolo Bonzini wrote: > If you can make the pxe-virtio.rom file 64k or less, then that would be > a good idea for 14.04 in general. Newer machine types use > efi-virtio.rom, so you won't break "-M pc" migration. Without further, won't that break migration from 14.04 *w

Re: [Qemu-devel] [PATCH] [RFC] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-07-29 Thread Alex Bligh
On 29 Jul 2014, at 14:35, Paolo Bonzini wrote: > I'm not sure either. You could simply package the 12.04 ipxe ROMs into > 14.04, and add a note about getting the sources for GPL friendliness. This would be my preference (or in Ubuntu's case, add it to the ipxe-qemu package) but I think it shou

Re: [Qemu-devel] [PATCH RFC v2 05/12] VMstate test: basic VMState testing mechanism

2014-07-29 Thread Juan Quintela
Sanidhya Kashyap wrote: > In this patch, I have made the following changes: > > * changed the DPRINT statement. > * renamed the variables. > * added noqdev variable which decides which option to use for resetting. > * added devices option which can help in resetting one or many devices > (only qde

Re: [Qemu-devel] [PATCH] [RFC] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-07-29 Thread Serge Hallyn
Quoting Paolo Bonzini (pbonz...@redhat.com): > Il 29/07/2014 15:27, Serge Hallyn ha scritto: > > Quoting Paolo Bonzini (pbonz...@redhat.com): > >> Il 29/07/2014 15:03, Serge E. Hallyn ha scritto: > >>> > >>> And from there I think the thing to do will be to introduce a transient > >>> alternate pac

Re: [Qemu-devel] [PATCH] [RFC] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-07-29 Thread Paolo Bonzini
Il 29/07/2014 15:39, Alex Bligh ha scritto: >> > I'm not sure either. You could simply package the 12.04 ipxe ROMs into >> > 14.04, and add a note about getting the sources for GPL friendliness. > This would be my preference (or in Ubuntu's case, add it to the ipxe-qemu > package) but I think it s

Re: [Qemu-devel] [PATCH for 2.1 V3] qemu-img info: show nocow info

2014-07-29 Thread Stefan Hajnoczi
On Mon, Jul 28, 2014 at 12:58:33PM -0600, Eric Blake wrote: > On 07/28/2014 09:19 AM, Stefan Hajnoczi wrote: > > On Wed, Jul 09, 2014 at 10:43:13AM +0800, Chunyan Liu wrote: > >> Add nocow info in 'qemu-img info' output to show whether the file > >> currently has NOCOW flag set or not. > >> > >> Si

Re: [Qemu-devel] [PATCH] [RFC] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-07-29 Thread Serge Hallyn
Quoting Alex Bligh (a...@alex.org.uk): > > On 29 Jul 2014, at 14:21, Paolo Bonzini wrote: > > > If you can make the pxe-virtio.rom file 64k or less, then that would be > > a good idea for 14.04 in general. Newer machine types use > > efi-virtio.rom, so you won't break "-M pc" migration. > > Wi

Re: [Qemu-devel] [PATCH] vmdk: improve streamOptimized vmdk support

2014-07-29 Thread Milos Vyletel
On Tue, Jul 29, 2014 at 9:37 AM, Stefan Hajnoczi wrote: > On Mon, Jul 07, 2014 at 10:54:27AM -0400, Milos Vyletel wrote: >> VMDK's streamOptimized format is different that regular sparse format. >> L1(GD) and L2(GT) tables are not predefined but rather generated and >> written during image creatio

[Qemu-devel] [PATCH 1/2] target-mips: Add synci instruction test

2014-07-29 Thread Dongxue Zhang
Save code with sw and raise synci. The saved code should be raise. If the code raised, log 'test passed'. If the code not raised, log 'test failed, the copied instruction not run'. Other cases, log 'unhandled'. The test should log 'test passed'. Signed-off-by: Dongxue Zhang --- tests/tcg/mips/

[Qemu-devel] [PATCH 2/2] target-mips/translate.c: Update OPC_SYNCI

2014-07-29 Thread Dongxue Zhang
Update OPC_SYNCI with BS_STOP, in order to handle the instructions which saved in the same TB of the store instruction. Signed-off-by: Dongxue Zhang --- target-mips/translate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target-mips/translate.c b/target-mips/translate.

Re: [Qemu-devel] [PATCH/RFC 4/5] s390x/kvm: test whether a cpu is STOPPED when checking "has_work"

2014-07-29 Thread Paolo Bonzini
Il 28/07/2014 17:03, David Hildenbrand ha scritto: > Well the difference is, that a STOPPED vcpu can be woken up by non-interrupt > like things (SIGP START) AND a special interrupt (SIGP RESTART - which is like > a "SIPI"++ as it performs a psw exchange - "NMI"). So we basically have two > paths th

Re: [Qemu-devel] [PATCH] [RFC] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-07-29 Thread Alex Bligh
On 29 Jul 2014, at 14:42, Paolo Bonzini wrote: > Il 29/07/2014 15:39, Alex Bligh ha scritto: I'm not sure either. You could simply package the 12.04 ipxe ROMs into 14.04, and add a note about getting the sources for GPL friendliness. >> This would be my preference (or in Ubuntu's case

Re: [Qemu-devel] [PATCH] [RFC] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-07-29 Thread Paolo Bonzini
Il 29/07/2014 15:56, Alex Bligh ha scritto: > > On 29 Jul 2014, at 14:42, Paolo Bonzini wrote: > >> Il 29/07/2014 15:39, Alex Bligh ha scritto: > I'm not sure either. You could simply package the 12.04 ipxe ROMs into > 14.04, and add a note about getting the sources for GPL friendliness

Re: [Qemu-devel] [PATCH 2/2] target-mips/translate.c: Add judgement for msb and lsb

2014-07-29 Thread Aurelien Jarno
On Tue, Jul 29, 2014 at 08:41:08PM +0800, Elta wrote: > I think, debug mode shouldn't crash the qemu with an unpredictable > operation, > so i want to fix it. And you say there shouldn't raise RI, i agree with you. Agreed. > Or when lsb > msb, just leave the code and do nothing. What do you > thi

Re: [Qemu-devel] [PATCH] vmdk: improve streamOptimized vmdk support

2014-07-29 Thread Stefan Hajnoczi
On Tue, Jul 29, 2014 at 2:46 PM, Milos Vyletel wrote: > On Tue, Jul 29, 2014 at 9:37 AM, Stefan Hajnoczi wrote: >> On Mon, Jul 07, 2014 at 10:54:27AM -0400, Milos Vyletel wrote: >>> VMDK's streamOptimized format is different that regular sparse format. >>> L1(GD) and L2(GT) tables are not predefi

Re: [Qemu-devel] [PATCH 2/3] qemu-char: add -chardev exit-on-eof option

2014-07-29 Thread Markus Armbruster
Eric Blake writes: > On 07/29/2014 12:12 AM, Markus Armbruster wrote: > >>> Libvirt probably won't use it for normal guests (we don't want to kill >>> qemu just because the monitor disconnects), but does have the notion of >>> an autodestroy guest where it might be useful (we WANT the guest to go

Re: [Qemu-devel] [PATCH] vmdk: improve streamOptimized vmdk support

2014-07-29 Thread Milos Vyletel
On Tue, Jul 29, 2014 at 10:37 AM, Stefan Hajnoczi wrote: > On Tue, Jul 29, 2014 at 2:46 PM, Milos Vyletel > wrote: >> On Tue, Jul 29, 2014 at 9:37 AM, Stefan Hajnoczi wrote: >>> On Mon, Jul 07, 2014 at 10:54:27AM -0400, Milos Vyletel wrote: VMDK's streamOptimized format is different that r

Re: [Qemu-devel] [PATCH v6 3/3] sclp-s390: Add memory hotplug SCLPs

2014-07-29 Thread Matthew Rosato
On 07/29/2014 08:17 AM, Christian Borntraeger wrote: > On 30/06/14 16:00, Matthew Rosato wrote: >> Add memory information to read SCP info and add handlers for >> Read Storage Element Information, Attach Storage Element, >> Assign Storage and Unassign >> >> Signed-off-by: Matthew Rosato >> --- >>

Re: [Qemu-devel] [PATCH] [RFC] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-07-29 Thread Alex Bligh
On 29 Jul 2014, at 15:00, Paolo Bonzini wrote: > efi-virtio.rom contains both BIOS and UEFI ROMs. You learn a new thing every day. > You're right, but in Serge's shoes I wouldn't bother about anything > except LTS. Certainly this would be the most convenient path for me (with my 'LTS user' ha

Re: [Qemu-devel] [PATCH/RFC 4/5] s390x/kvm: test whether a cpu is STOPPED when checking "has_work"

2014-07-29 Thread David Hildenbrand
> Il 28/07/2014 17:03, David Hildenbrand ha scritto: > > Well the difference is, that a STOPPED vcpu can be woken up by non-interrupt > > like things (SIGP START) AND a special interrupt (SIGP RESTART - which is > > like > > a "SIPI"++ as it performs a psw exchange - "NMI"). So we basically have t

Re: [Qemu-devel] [PATCH 2/2] target-mips/translate.c: Add judgement for msb and lsb

2014-07-29 Thread Dongxue Zhang
Ok, I got you. I will re-build a new patch for all the bitops. 2014-07-29 22:08 GMT+08:00 Aurelien Jarno : > On Tue, Jul 29, 2014 at 08:41:08PM +0800, Elta wrote: > > I think, debug mode shouldn't crash the qemu with an unpredictable > > operation, > > so i want to fix it. And you say there shou

Re: [Qemu-devel] [PATCH] hw/arm/virt: fix pl031 addr typo

2014-07-29 Thread Peter Maydell
On 29 July 2014 16:44, Andrew Jones wrote: > pl031's base address should be 0x9001000, 0x9001. While in there > also add some spacing and zeros to make it easier to read the map. > > Signed-off-by: Andrew Jones > -[VIRT_RTC] = { 0x9001, 0x1000 }, > +[VIRT_RTC] ={ 0x0900100

  1   2   >