On Wed, Jul 09, 2014 at 02:01:30PM +0200, Stefan Hajnoczi wrote: > These two patches fix the -device FOO,help output regression that Cole spotted > in QEMU 2.0-rc0. The problem is that virtio-blk-pci qdev properties have been > converted to QOM alias properties but -device FOO,help shows only qdev > properties. > > We simply need to update -device FOO,help code to use both qdev and QOM > properties. Note that types change because a 'drive' qdev type is actually a > 'str' QOM type. We're moving more and more to QOM properties where the final > type for this property would be 'link<Drive>' or similar. > > Cole: please confirm that this fixes the issue > > Stefan Hajnoczi (2): > qmp: hide "hotplugged" device property from device-list-properties > qdev-monitor: include QOM properties in -device FOO,help output > > qdev-monitor.c | 40 +++++++++++++++++----------------------- > qmp.c | 1 + > 2 files changed, 18 insertions(+), 23 deletions(-)
CCed qemu-stable since we ought to fix -device FOO,?. This patch was missed for QEMU 2.1 but not critical (see Cole's response). Applied to my block-next tree: https://github.com/stefanha/qemu/commits/block-next Stefan
pgpHm5HOZydZ6.pgp
Description: PGP signature
