[Qemu-devel] [PATCH] qemu-char: Fixed the bug lead to dead lock

2014-07-11 Thread Liliang
From: Li Liang This bug was introduced in the commit 9005b2a7589540a3733b3abdcfbccfe7746cd1a1, it will cause deadlock when create a vm with the parameter "-monitor pty" and then try to read from /dev/pts/x. Signed-off-by: Li Liang --- qemu-char.c | 4 +++- 1 file changed, 3 insertions(+), 1 de

[Qemu-devel] [RFC PATCH 0/8] Add Generic PCI host device update

2014-07-11 Thread Alvise Rigo
This patch series is based on the previous work [1] and [2] by Rob Herring and it tries to enhance this work on these points: - Some of the hardcoded values have been moved to an header file. This header file is also used to share some device structures with the mach-virt machine. - The inter

[Qemu-devel] [RFC PATCH 2/8] mach-virt: improve PCI memory topology definition

2014-07-11 Thread Alvise Rigo
Some of the unnecessary redundancy here will be decreased later in this series. Signed-off-by: Alvise Rigo --- hw/arm/virt.c | 37 + 1 file changed, 25 insertions(+), 12 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index ed9fc7a..c93152f 100644 ---

[Qemu-devel] [RFC PATCH 1/8] mach-virt: move GIC inside mach-virt structure

2014-07-11 Thread Alvise Rigo
Signed-off-by: Alvise Rigo --- hw/arm/virt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 7122e99..ed9fc7a 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -83,6 +83,7 @@ typedef struct VirtBoardInfo { void *fdt; int fdt_size

[Qemu-devel] [RFC PATCH 6/8] generic_pci: generate dt node after devices init

2014-07-11 Thread Alvise Rigo
Keeping advantage of the finalize_dt QEMUMachine function, the mach-virt machine now completes the device tree creation after that all the generic devices have been instantiated. This allows to generate the interrupt-map node according to the devices attached to the PCI bus. These devices can be sp

[Qemu-devel] [RFC PATCH 8/8] generic_pci: add interrupt map structures

2014-07-11 Thread Alvise Rigo
Create a generic_pci_host state to include the IRQ map to be used when resolving the PCI interrupts. These structures can be useful to support more complicated scenarios, like with multi functions PCI devices. Signed-off-by: Alvise Rigo --- hw/pci-host/generic-pci.c | 37

[Qemu-devel] [RFC PATCH 3/8] QEMUMachine: finalize_dt function

2014-07-11 Thread Alvise Rigo
Add a new function to be called after that the init of the generic devices is concluded. This will allow some platforms, like mach-virt, to conclude its device tree generation disposing of all the information about attached devices. Note: This idea accomplishes what is also done by the recent "[PA

[Qemu-devel] [RFC PATCH 7/8] generic_pci: realize device with machine data

2014-07-11 Thread Alvise Rigo
Realize the device according to the offsets specified by the machine memory map. Signed-off-by: Alvise Rigo --- hw/pci-host/generic-pci.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/generic-pci.c b/hw/pci-host/generic-pci.c index 2068079..1bde69c 10

[Qemu-devel] [RFC PATCH 5/8] generic_pci: create own map irq function

2014-07-11 Thread Alvise Rigo
Allocate MAX_PCI_DEVICES IRQs for the pci_generic device. For now we assume that at every PCI slot corresponds an interrupt line: this also seems what the kernel code does when parsing the interrupt mapping from the device tree. At the moment there isn't a structure that keeps track of the IRQ ma

[Qemu-devel] [RFC PATCH 4/8] generic_pci: create header file

2014-07-11 Thread Alvise Rigo
As a matter of fact, the mach-virt platform needs some definitions of the generic_pci device. Note: Including the device header file in the mach-virt platform can be avoided extending properly the idea present in "[PATCH 4/7] hw/arm/virt: Support dynamically spawned sysbus devices". Signed-off-by

[Qemu-devel] [PATCH] block/quorum: make quorum_getlength error message user friendly

2014-07-11 Thread Liu Yuan
When start quorum driver with 2 different sized images, we get: qemu-system-x86_64: -drive if=virtio,driver=quorum...: Could not refresh total \ sector count: Input/output error EIO would confuse users. With this patch, the error message goes like Children images are not in the same size qemu-sy

[Qemu-devel] [PATCH] backends: Introduce chr-testdev

2014-07-11 Thread Andrew Jones
From: Paolo Bonzini From: Paolo Bonzini chr-testdev enables a virtio serial channel to be used for guest initiated qemu exits. hw/misc/debugexit already enables guest initiated qemu exits, but only for PC targets. chr-testdev supports any virtio-capable target. kvm-unit-tests/arm is already mak

Re: [Qemu-devel] [PATCH V3 for 2.1 1/2] memory: add memory_region_init_ram_may_fail() and memory_region_init_ram_ptr_may_fail()

2014-07-11 Thread Hu Tao
On Mon, Jul 07, 2014 at 03:27:35PM +0300, Michael S. Tsirkin wrote: > On Mon, Jul 07, 2014 at 06:55:27PM +0800, Hu Tao wrote: > > These two are almost the same as memory_region_init_ram() and > > memory_region_init_ram_ptr() except that they have an extra errp > > parameter to let callers handle er

[Qemu-devel] block device fd consuption

2014-07-11 Thread Christian Borntraeger
Stefan, I traced the creation of eventfds with gdb in the case of virtio-blk. With the following setup qemu-system-s390x -enable-kvm -m 1000 -nographic -kernel /boot/vmlinux-3.15.0+ -initrd ramdisk -smp 2 -append "root=/dev/ram0" -M s390-ccw -drive file=/dev/sdc,if=none,id=d0,format=raw,serial

Re: [Qemu-devel] [PATCH v3 00/16] target-arm: Parts of the AArch64 EL2/3 exception model

2014-07-11 Thread Peter Maydell
On 11 July 2014 00:17, Edgar E. Iglesias wrote: > Ping! > > PMM, are you expecting me to change something with this series that I've > missed or is it just busy times for review? It's on my review list but since it's not for 2.1 it's a lower priority right now... thanks -- PMM

Re: [Qemu-devel] [PATCH] scsi-bus: fix to allow some special SCSI commands

2014-07-11 Thread Paolo Bonzini
Il 11/07/2014 10:53, TAMUKI Shoichi ha scritto: @@ -563,7 +565,8 @@ SCSIRequest *scsi_req_new(SCSIDevice *d, uint32_t tag, uint32_t lun, SCSIRequest *req; SCSICommand cmd; -if (scsi_req_parse(&cmd, d, buf) != 0) { +if (scsi_req_parse(&cmd, d, buf, +((VirtIOSCSIReq

Re: [Qemu-devel] Which method executes the translated blocks (TBs)?

2014-07-11 Thread Peter Maydell
On 11 July 2014 03:31, Anderson Sartor wrote: > So, the only test I need to make to be sure that a given TB was completely > executed is to check the two lowest bits of next_tb (after > tcg_qemu_tb_exec() call), and, if they are not equal to 2 or 3, then the TB > finished its execution (if it has

Re: [Qemu-devel] [PATCH] qemu-char: Fixed the bug lead to dead lock

2014-07-11 Thread Markus Armbruster
Cc'ing folks involved in the flawed commit. Liliang writes: > From: Li Liang > > This bug was introduced in the commit > 9005b2a7589540a3733b3abdcfbccfe7746cd1a1, > it will cause deadlock when create a vm with the parameter "-monitor pty" and > then try to read from /dev/pts/x. > > Signed-off-

Re: [Qemu-devel] [PATCH] qemu-char: Fixed the bug lead to dead lock

2014-07-11 Thread Peter Maydell
On 11 July 2014 05:58, Liliang wrote: > From: Li Liang > > This bug was introduced in the commit > 9005b2a7589540a3733b3abdcfbccfe7746cd1a1, > it will cause deadlock when create a vm with the parameter "-monitor pty" and > then try to read from /dev/pts/x. > > Signed-off-by: Li Liang > --- > q

Re: [Qemu-devel] [RFC PATCH 0/8] Add Generic PCI host device update

2014-07-11 Thread Peter Maydell
On 11 July 2014 08:21, Alvise Rigo wrote: > This work has been tested attaching several PCI devices to the mach-virt > platform. The tested devices are: virtio-blk-pci, virtio-net-pci, > lsi53c895a and pci-ohci (all attached at the same time). > Even if the original work was not changed in its co

[Qemu-devel] [PULL 1/1] ui/gtk: Restore keyboard focus after Page change

2014-07-11 Thread Gerd Hoffmann
From: John Snow (Resending for correct email addresses via MAINTAINERS ...) In the GTK UI, after changing focus to the qemu monitor Notebook Page, when restoring focus to the virtual machine page, the keyboard focus is lost to a hidden GTK widget. Focus can only be restored to the virtual machin

[Qemu-devel] [PULL 0/1] ui/gtk: Restore keyboard focus after Page change

2014-07-11 Thread Gerd Hoffmann
/qemu tags/pull-gtk-20140711-1 for you to fetch changes up to e72b59fa93b68635f42cdb1b1134f60dd4040d7b: ui/gtk: Restore keyboard focus after Page change (2014-07-11 10:44:00 +0200) ui/gtk: Restore keyboard focus after Page change

Re: [Qemu-devel] block device fd consuption

2014-07-11 Thread Stefan Hajnoczi
On Fri, Jul 11, 2014 at 10:56:12AM +0200, Christian Borntraeger wrote: > Stefan, > > I traced the creation of eventfds with gdb in the case of virtio-blk. Great, thanks for posting this! Most of these eventfds are "justified". They are actively used and are not leaked. Avoiding them might be p

Re: [Qemu-devel] [RFC PATCH 0/8] Add Generic PCI host device update

2014-07-11 Thread Alvise Rigo
The kernel version is a very recent one: v3.16.0-rc1. Maybe you are right. I will test some older version to see if I'm able to reproduce the issue. Thank you, alvise Il 11/07/2014 11:09, Peter Maydell ha scritto: > On 11 July 2014 08:21, Alvise Rigo wrote: >> This work has been tested attachin

Re: [Qemu-devel] [PATCH] qemu-char: Fixed the bug lead to dead lock

2014-07-11 Thread Li, LiangX Z
Yes, my patch will break the thread safe implementation, just avoid the deadlock. This is the call trace when the dead lock happened. #0 0x727dbf79 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1 0x727df388 in __GI_abort () at abort.c:89 #2 0x0

[Qemu-devel] [PULL 1/1] spice: auth fixes

2014-07-11 Thread Gerd Hoffmann
Set auth to sasl when sasl is enabled, this makes "info spice" correctly display sasl auth. Also throw an error in case someone tries to set a spice password via monitor without auth mode being "spice". Signed-off-by: Gerd Hoffmann --- ui/spice-core.c | 5 + 1 file changed, 5 insertions(+)

[Qemu-devel] [PULL 0/1] spice: auth fixes

2014-07-11 Thread Gerd Hoffmann
://anongit.freedesktop.org/spice/qemu tags/pull-spice-20140711-1 for you to fetch changes up to b1ea7b79e1675355ea7abe2548ad71dcf7d64b60: spice: auth fixes (2014-07-11 10:12:47 +0200) spice: auth fixes

[Qemu-devel] [PATCH for-2.1] serial: change retry logic to avoid concurrency

2014-07-11 Thread Kirill Batuzov
Whenever serial_xmit fails to transmit a byte it adds a watch that would call it again when the "line" becomes ready. This results in a retry chain: serial_xmit -> add_watch -> serial_xmit Each chain is able to transmit one character, and for every character passed to serial by the guest driver a

[Qemu-devel] [PATCH] scsi-bus: fix to allow some special SCSI commands

2014-07-11 Thread TAMUKI Shoichi
Currently, some special SCSI commands sent from the initiator in a guest do not reach the target device. To avoid this, extended (0x7e,) variable length (0x7f,) and vendor specific (0xc0..0xff) opcodes are now treated as valid CDBs. Originally, the most significant 3 bits of a SCSI opcode specifi

Re: [Qemu-devel] [PATCH 01/15] target-tricore: Add target stubs and qom-cpu

2014-07-11 Thread Bastian Koppelmann
Hi Peter, On 07/07/2014 08:24 PM, Peter Maydell wrote: I think you probably want the configure and default-configs changes to be at the end of the patch series (or at least part way through it), not at the start. The general approach is: * some patches which implement the basic absolute minimu

Re: [Qemu-devel] block device fd consuption

2014-07-11 Thread Christian Borntraeger
On 11/07/14 11:23, Stefan Hajnoczi wrote: > On Fri, Jul 11, 2014 at 10:56:12AM +0200, Christian Borntraeger wrote: >> Stefan, >> >> I traced the creation of eventfds with gdb in the case of virtio-blk. > > Great, thanks for posting this! > > Most of these eventfds are "justified". They are activ

[Qemu-devel] [PATCH] qemu-char: fix deadlock with "-monitor pty"

2014-07-11 Thread Paolo Bonzini
qemu_chr_be_generic_open cannot be called with the write lock taken, because it calls client code that may call qemu_chr_fe_write. This actually happens for the monitor: 0x727dbf79 in __GI_raise (sig=sig@entry=6) 0x727df388 in __GI_abort () 0x555ef489 in error_

Re: [Qemu-devel] live migration + licensing issue.

2014-07-11 Thread Anshul Makkar
Yeah, but I think if we have to take advantage of live vertical scaling (memory hotplug, memory hotunplug, cpu hotplug) then we need to upgrade to pc model 1.2. pc model 1.0 will be incompatible with qemu 2.0 wrt. LVS feature as the bus architecture and the way how dimms are handled has changed fr

Re: [Qemu-devel] live migration + licensing issue.

2014-07-11 Thread Anshul Makkar
Hi Andreas, "the point is that the machine version on the destination side needs to match the source side". I hope this is just to avoid the licensing issue. Else, in all other circumstance, we can specify different pc models while migrating from source to destination. Anshul Makkar On Wed, Jul

[Qemu-devel] [PATCH] slirp: goto bad in udp_input if sosendto fails

2014-07-11 Thread Samuel Thibault
Before this patch, if sosendto fails, udp_input is executed as if the packet was sent, recording the packet for icmp errors, which does not makes sense since the packet was not actually sent, errors would be related to a previous packet. This patch adds a goto bad to cut the execution of this func

Re: [Qemu-devel] [PATCH] block/quorum: make quorum_getlength error message user friendly

2014-07-11 Thread Kevin Wolf
Am 11.07.2014 um 09:34 hat Liu Yuan geschrieben: > When start quorum driver with 2 different sized images, we get: > > qemu-system-x86_64: -drive if=virtio,driver=quorum...: Could not refresh > total \ > sector count: Input/output error > > EIO would confuse users. With this patch, the error mes

[Qemu-devel] [Bug 1335444] Re: qemu loses serial console data on EAGAIN

2014-07-11 Thread Kirill Batuzov
I see. There is an issue with retry logic of serial port emulation. I've send a patch to the mailing list that should help. http://lists.nongnu.org/archive/html/qemu-devel/2014-07/msg01976.html With it both methods pass the test for me. Note that in the first method you'll need to disable network

[Qemu-devel] [RFC PATCH 6/7] cpu hotplug: implement function cpu_status_write() for vcpu ejection

2014-07-11 Thread Gu Zheng
From: Chen Fan When OS ejected a vcpu (like: echo 1 > /sys/bus/acpi/devices/LNXCPUXX/eject), it would call acpi EJ0 method, the firmware need to write the new cpumap, QEMU would know which vcpu need to be ejected. TODO: -confirm the hotplug result via OST if guest support it. Signed-off-by: Che

[Qemu-devel] [RFC PATCH 1/7] x86: add x86_cpu_unrealizefn() for cpu apic remove

2014-07-11 Thread Gu Zheng
From: Chen Fan From: Chen Fan Implement x86_cpu_unrealizefn() for corresponding x86_cpu_realizefn(), which is mostly used to clean the apic related allocation and vmstates at here. Signed-off-by: Chen Fan Signed-off-by: Gu Zheng --- hw/i386/kvm/apic.c |8 +++ hw/intc/ap

[Qemu-devel] [RFC PATCH 5/7] i386: implement pc interface cpu_common_unrealizefn() in qom/cpu.c

2014-07-11 Thread Gu Zheng
From: Chen Fan add interface cpu_common_unrealizefn() for emiting vcpu unplug notifier to ACPI, then ACPI could send sci interrupt to OS for hot-remove vcpu. Signed-off-by: Chen Fan Signed-off-by: Gu Zheng --- qom/cpu.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) d

[Qemu-devel] [PATCH for-2.1 0/1] s390x/kvm: bugfix

2014-07-11 Thread Cornelia Huck
Hi, another s390x bugfix for 2.1: We didn't synchronize the guest's floating point registers, which we didn't realize until we tried to migrate a guest with applications that actually used them. Turns out that Jason had already done a patch for this some time ago that somehow fell through the cra

[Qemu-devel] [RFC PATCH 2/7] i386: add cpu device_del support

2014-07-11 Thread Gu Zheng
In order to add cpu(i386) device_del support, introduce the cpu hot unplug hanlde(x86_cpu_unplug) which will trigger the unrealize routine, and just register it to the cpu class unplug handle. Signed-off-by: Chen Fan Signed-off-by: Gu Zheng --- target-i386/cpu.c | 22 ++ 1

[Qemu-devel] [RFC PATCH 0/7] i386: add cpu hot remove support

2014-07-11 Thread Gu Zheng
Via implementing ACPI standard methods _EJ0 in ACPI table, after Guest OS remove one vCPU online, the fireware will store removed bitmap to QEMU, then QEMU could know to notify the assigned vCPU of exiting. meanwhile, intruduce the QOM command 'device_del' to remove vCPU from QEMU itself. This jo

[Qemu-devel] [PATCH for-2.1 1/1] s390x/kvm: synchronize guest floating point registers

2014-07-11 Thread Cornelia Huck
From: "Jason J. Herne" Add code to kvm_arch_get_registers and kvm_arch_put_registers to save/restore floating point registers. This missing sync was unnoticed until migration of userspace that uses fprs. Signed-off-by: Jason J. Herne Signed-off-by: Christian Borntraeger [Update patch to latest

[Qemu-devel] [RFC PATCH 3/7] qom cpu: rename variable 'cpu_added_notifier' to 'cpu_hotplug_notifier'

2014-07-11 Thread Gu Zheng
From: Chen Fan Rename variable 'cpu_added_notifier' to 'cpu_hotplug_notifier' for adding remove vcpu notifier support. Signed-off-by: Chen Fan Signed-off-by: Gu Zheng --- hw/acpi/ich9.c |8 hw/acpi/piix4.c | 10 +- hw/i386/pc.c|2 +- inc

[Qemu-devel] [PULL 0/3] vga: some cirrus fixes.

2014-07-11 Thread Gerd Hoffmann
://git.kraxel.org/qemu tags/pull-vga-20140711-1 for you to fetch changes up to d16136d22af0fcf0d651de04c9e3cbc7137cc6f9: cirrus: Fix host CPU blits (2014-07-11 10:17:02 +0200) vga: some cirrus fixes

[Qemu-devel] [RFC PATCH 4/7] qom cpu: add UNPLUG cpu notify support

2014-07-11 Thread Gu Zheng
Introduce a common cpu hotplug notifier(CPUNotifier) to support UNPLUG cpu notify. Signed-off-by: Gu Zheng Signed-off-by: Chen Fan --- hw/acpi/cpu_hotplug.c | 15 +++ hw/acpi/ich9.c|5 - hw/acpi/piix4.c | 11 +++ include/hw/a

[Qemu-devel] [RFC PATCH 7/7] cpus: reclaim allocated vCPU objects

2014-07-11 Thread Gu Zheng
After ACPI get a signal to eject a vCPU, the vCPU must be removed from CPU list,before the vCPU really removed, then release the all related vCPU objects. But we do not close KVM vcpu fd, just record it into a list, in order to reuse it. Signed-off-by: Chen Fan Signed-off-by: Gu Zheng --- cpus

[Qemu-devel] [PULL 2/3] cirrus: Fix build of debug code

2014-07-11 Thread Gerd Hoffmann
From: Benjamin Herrenschmidt Use PRIu64 to print uint64_t Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Gerd Hoffmann --- hw/display/cirrus_vga.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index 52d039e.

[Qemu-devel] [PULL 1/3] cirrus_vga: adding sanity check for vram size

2014-07-11 Thread Gerd Hoffmann
From: Gonglei when configure a invalid vram size for cirrus card, such as less 2 MB, which will crash qemu. Follow the real hardware, the cirrus card has 4 MB video memory. Also for backward compatibility, accept 8 MB and 16 MB vram size. Signed-off-by: Gonglei Reviewed-by: Andreas Färber Sign

[Qemu-devel] [PULL 3/3] cirrus: Fix host CPU blits

2014-07-11 Thread Gerd Hoffmann
From: Benjamin Herrenschmidt Commit b2eb849d4b1fdb6f35d5c46958c7f703cf64cfef "CVE-2007-1320 - Cirrus LGD-54XX "bitblt" heap overflow" broke cpu to video blits. When the ROP function is called from cirrus_bitblt_cputovideo_next(), we pass 0 for the pitch but only operate on one line at a time. Th

[Qemu-devel] [PULL 0/1] mtp: linux guest detection fix

2014-07-11 Thread Gerd Hoffmann
://git.kraxel.org/qemu tags/pull-usb-20140711-1 for you to fetch changes up to 13d54125a3482a5837682499d25f6be10aa824be: mtp: linux guest detection fix. (2014-07-11 12:31:41 +0200) mtp: linux guest detection fix

Re: [Qemu-devel] [PATCH] block/quorum: add simple read pattern support

2014-07-11 Thread Benoît Canet
The Friday 11 Jul 2014 à 11:01:22 (+0800), Liu Yuan wrote : > This patch adds single read pattern to quorum driver and quorum vote is > default > pattern. > > For now we do a quorum vote on all the reads, it is designed for unreliable > underlying storage such as non-redundant NFS to make sure da

[Qemu-devel] [PULL 1/1] mtp: linux guest detection fix.

2014-07-11 Thread Gerd Hoffmann
Attach a name to the MTP interface (android phones have this too). With this patch recent linux guests such as fedora 20 happily detect and use the device. It shows up in nautilus file manager automatically, and simple-mtpfs can mount it. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-mtp.c | 4 +

Re: [Qemu-devel] [PATCH for-2.1 1/1] s390x/kvm: synchronize guest floating point registers

2014-07-11 Thread Alexander Graf
On 11.07.14 12:38, Cornelia Huck wrote: From: "Jason J. Herne" Add code to kvm_arch_get_registers and kvm_arch_put_registers to save/restore floating point registers. This missing sync was unnoticed until migration of userspace that uses fprs. Signed-off-by: Jason J. Herne Signed-off-by: Chr

Re: [Qemu-devel] live migration + licensing issue.

2014-07-11 Thread Paolo Bonzini
Il 11/07/2014 12:14, Anshul Makkar ha scritto: Hi Andreas, "the point is that the machine version on the destination side needs to match the source side". I hope this is just to avoid the licensing issue. Else, in all other circumstance, we can specify different pc models while migrating from so

Re: [Qemu-devel] [PATCH 01/15] target-tricore: Add target stubs and qom-cpu

2014-07-11 Thread Peter Maydell
On 11 July 2014 12:05, Bastian Koppelmann wrote: > On 07/07/2014 08:24 PM, Peter Maydell wrote: >> I think you probably want the configure and default-configs changes to be >> at the end of the patch series (or at least part way through it), not at the >> start. The general approach is: * some pat

Re: [Qemu-devel] live migration + licensing issue.

2014-07-11 Thread Markus Armbruster
[Top-quote moved to its rightful place; please do not top quote on technical lists] Anshul Makkar writes: > On Wed, Jul 9, 2014 at 6:25 PM, Andreas Färber wrote: >> Am 09.07.2014 13:09, schrieb Anshul Makkar: >>> Thanks. I got the point. >> >> And for the record, the point is that the machine v

Re: [Qemu-devel] [PULL v3 00/10] KVM changes (+ misc small fixes) for 2.1

2014-07-11 Thread Peter Maydell
On 10 July 2014 17:04, Paolo Bonzini wrote: > The following changes since commit 9d9de254c2b81b68cd48f2324cc753a570a4cdd8: > > MAINTAINERS: seccomp: change email contact for Eduardo Otubo (2014-07-03 > 12:36:15 +0100) > > are available in the git repository at: > > git://git.kernel.org/pub/sc

Re: [Qemu-devel] [PULL v3 00/10] KVM changes (+ misc small fixes) for 2.1

2014-07-11 Thread Paolo Bonzini
Il 11/07/2014 13:13, Peter Maydell ha scritto: On 10 July 2014 17:04, Paolo Bonzini wrote: > The following changes since commit 9d9de254c2b81b68cd48f2324cc753a570a4cdd8: > > MAINTAINERS: seccomp: change email contact for Eduardo Otubo (2014-07-03 12:36:15 +0100) > > are available in the git

Re: [Qemu-devel] [PATCH v2] libxl: change default QEMU machine to pc-i440fx-1.6

2014-07-11 Thread Stefano Stabellini
On Thu, 10 Jul 2014, Ian Jackson wrote: > Stefano Stabellini writes ("Re: [PATCH v2] libxl: change default QEMU machine > to pc-i440fx-1.6"): > > ping? > > > > On Thu, 12 Jun 2014, Stefano Stabellini wrote: > ... > > > This patch does not change the emulated environment in the guest, unless > > >

Re: [Qemu-devel] [PULL 1/1] spice: auth fixes

2014-07-11 Thread Markus Armbruster
Gerd Hoffmann writes: > Set auth to sasl when sasl is enabled, this makes "info spice" correctly > display sasl auth. Fixes SPICE_CHANNEL_EVENT_CONNECTED similarly, doesn't it? If yes, I'd recommend to note this in the commit message. > Also throw an error in case someone t

Re: [Qemu-devel] [PULL v3 00/10] KVM changes (+ misc small fixes) for 2.1

2014-07-11 Thread Peter Maydell
On 11 July 2014 12:14, Paolo Bonzini wrote: > Il 11/07/2014 13:13, Peter Maydell ha scritto: >> Applied, thanks. Incidentally, any plans to switch to submitting >> signed tags for pullreqs? > > > Sure, do you want to exchange keys or am I close enough to you in the web of > trust? I think as an i

[Qemu-devel] [PATCH for-2.1? 0/2] thread-pool: avoid fd usage and fix nested aio_poll() deadlock

2014-07-11 Thread Stefan Hajnoczi
These patches convert thread-pool.c from EventNotifier to QEMUBH. They then solve the deadlock when nested aio_poll() calls are made. Please speak out whether you want this in QEMU 2.1 or not. I'm not aware of the nested aio_poll() deadlock ever having been reported, so maybe we can defer to QEM

[Qemu-devel] [PATCH for-2.1? 2/2] thread-pool: avoid deadlock in nested aio_poll() calls

2014-07-11 Thread Stefan Hajnoczi
The thread pool has a race condition if two elements complete before thread_pool_completion_bh() runs: If element A's callback waits for element B using aio_poll() it will deadlock since pool->completion_bh is not marked scheduled when the nested aio_poll() runs. Fix this by marking the BH

Re: [Qemu-devel] [PATCH RESEND] ui/gtk: Restore keyboard focus after Page change

2014-07-11 Thread Markus Armbruster
John Snow writes: > (Resending for correct email addresses via MAINTAINERS ...) The note above... > In the GTK UI, after changing focus to the qemu monitor Notebook Page, > when restoring focus to the virtual machine page, the keyboard focus is lost > to a hidden GTK widget. Focus can only be r

Re: [Qemu-devel] [PULL 1/1] spice: auth fixes

2014-07-11 Thread Peter Maydell
On 11 July 2014 12:18, Markus Armbruster wrote: > Gerd Hoffmann writes: > >> Set auth to sasl when sasl is enabled, this makes "info spice" correctly >> display sasl auth. > > Fixes SPICE_CHANNEL_EVENT_CONNECTED similarly, doesn't it? > > If yes, I'd recommend to note this in the commit message.

[Qemu-devel] [PATCH v2 for-2.1 1/1] s390x/kvm: synchronize guest floating point registers

2014-07-11 Thread Cornelia Huck
From: "Jason J. Herne" Add code to kvm_arch_get_registers and kvm_arch_put_registers to save/restore floating point registers. This missing sync was unnoticed until migration of userspace that uses fprs. Signed-off-by: Jason J. Herne Signed-off-by: Christian Borntraeger [Update patch to latest

[Qemu-devel] [PATCH v2 for-2.1 0/1] s390x/kvm: bugfix

2014-07-11 Thread Cornelia Huck
Hi, another s390x bugfix for 2.1: We didn't synchronize the guest's floating point registers, which we didn't realize until we tried to migrate a guest with applications that actually used them. Turns out that Jason had already done a patch for this some time ago that somehow fell through the cra

[Qemu-devel] [PATCH for-2.1? 1/2] thread-pool: avoid per-thread-pool EventNotifier

2014-07-11 Thread Stefan Hajnoczi
EventNotifier is implemented using an eventfd or pipe. It therefore consumes file descriptors, which can be limited by rlimits and should therefore be used sparingly. Switch from EventNotifier to QEMUBH in thread-pool.c. Originally EventNotifier was used because qemu_bh_schedule() was not thread

Re: [Qemu-devel] [PATCH v2 for-2.1 1/1] s390x/kvm: synchronize guest floating point registers

2014-07-11 Thread Alexander Graf
On 11.07.14 13:21, Cornelia Huck wrote: From: "Jason J. Herne" Add code to kvm_arch_get_registers and kvm_arch_put_registers to save/restore floating point registers. This missing sync was unnoticed until migration of userspace that uses fprs. Signed-off-by: Jason J. Herne Signed-off-by: Chr

Re: [Qemu-devel] [PULL 1/1] mtp: linux guest detection fix.

2014-07-11 Thread Markus Armbruster
Gerd Hoffmann writes: > Attach a name to the MTP interface (android phones have this too). > > With this patch recent linux guests such as fedora 20 happily detect and > use the device. It shows up in nautilus file manager automatically, and > simple-mtpfs can mount it. > > Signed-off-by: Gerd H

Re: [Qemu-devel] [PULL 1/1] spice: auth fixes

2014-07-11 Thread Markus Armbruster
Peter Maydell writes: > On 11 July 2014 12:18, Markus Armbruster wrote: >> Gerd Hoffmann writes: >> >>> Set auth to sasl when sasl is enabled, this makes "info spice" correctly >>> display sasl auth. >> >> Fixes SPICE_CHANNEL_EVENT_CONNECTED similarly, doesn't it? >> >> If yes, I'd recommend to

Re: [Qemu-devel] [PATCH for-2.1? 0/2] thread-pool: avoid fd usage and fix nested aio_poll() deadlock

2014-07-11 Thread Christian Borntraeger
On 11/07/14 13:20, Stefan Hajnoczi wrote: > These patches convert thread-pool.c from EventNotifier to QEMUBH. They then > solve the deadlock when nested aio_poll() calls are made. > > Please speak out whether you want this in QEMU 2.1 or not. I'm not aware of > the nested aio_poll() deadlock eve

Re: [Qemu-devel] [PULL 1/1] mtp: linux guest detection fix.

2014-07-11 Thread Gerd Hoffmann
On Fr, 2014-07-11 at 13:33 +0200, Markus Armbruster wrote: > Gerd Hoffmann writes: > > > Attach a name to the MTP interface (android phones have this too). > > > > With this patch recent linux guests such as fedora 20 happily detect and > > use the device. It shows up in nautilus file manager au

Re: [Qemu-devel] live migration + licensing issue.

2014-07-11 Thread Eduardo Otubo
On Fri, Jul 11, 2014 at 1:12 PM, Markus Armbruster wrote: > [Top-quote moved to its rightful place; please do not top quote on > technical lists] > > Anshul Makkar writes: > >> On Wed, Jul 9, 2014 at 6:25 PM, Andreas Färber wrote: >>> Am 09.07.2014 13:09, schrieb Anshul Makkar: Thanks. I go

Re: [Qemu-devel] live migration + licensing issue.

2014-07-11 Thread Anshul Makkar
On Fri, Jul 11, 2014 at 1:12 PM, Markus Armbruster wrote: > ly, leaving your machine running on the source. Hmm. Got the point. But as I mentioned above if we have to use live vertical scaling on qemu 2.0, then pc-model 1.0 won't help (as the dimm handling and bus handling has changed in pc-mod

Re: [Qemu-devel] live migration + licensing issue.

2014-07-11 Thread Markus Armbruster
Eduardo Otubo writes: > On Fri, Jul 11, 2014 at 1:12 PM, Markus Armbruster wrote: >> [Top-quote moved to its rightful place; please do not top quote on >> technical lists] >> >> Anshul Makkar writes: >> >>> On Wed, Jul 9, 2014 at 6:25 PM, Andreas Färber wrote: Am 09.07.2014 13:09, schrieb

Re: [Qemu-devel] live migration + licensing issue.

2014-07-11 Thread Markus Armbruster
Anshul Makkar writes: > On Fri, Jul 11, 2014 at 1:12 PM, Markus Armbruster wrote: >> ly, leaving your machine running on the source. > > > Hmm. Got the point. > > But as I mentioned above if we have to use live vertical scaling on > qemu 2.0, then pc-model 1.0 won't help (as the dimm handling an

Re: [Qemu-devel] live migration + licensing issue.

2014-07-11 Thread Eduardo Otubo
On Fri, Jul 11, 2014 at 2:19 PM, Markus Armbruster wrote: > Eduardo Otubo writes: > >> On Fri, Jul 11, 2014 at 1:12 PM, Markus Armbruster wrote: >>> [Top-quote moved to its rightful place; please do not top quote on >>> technical lists] >>> >>> Anshul Makkar writes: >>> On Wed, Jul 9, 2014

Re: [Qemu-devel] live migration + licensing issue.

2014-07-11 Thread Markus Armbruster
Eduardo Otubo writes: > On Fri, Jul 11, 2014 at 2:19 PM, Markus Armbruster wrote: >> Eduardo Otubo writes: >> >>> On Fri, Jul 11, 2014 at 1:12 PM, Markus Armbruster >>> wrote: [Top-quote moved to its rightful place; please do not top quote on technical lists] Anshul Makkar

Re: [Qemu-devel] [PULL for-2.1 00/22] Block patches for 2.1.0-rc2

2014-07-11 Thread Peter Maydell
On 10 July 2014 13:35, Kevin Wolf wrote: > The following changes since commit 675879f6f3c9463e103735a4e41e9deb0bee9b39: > > Update version for v2.1.0-rc1 release (2014-07-08 16:53:59 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for-upstream > > fo

[Qemu-devel] [PATCH for 2.1 1/1] vmstate static checker: detect section renames

2014-07-11 Thread Amit Shah
Commit 292b1634 changed the section name of "ICH9 LPC" to "ICH9-LPC", and that causes the static checker to flag this: Section "ICH9 LPC" does not exist in dest This patch introduces a function that checks for section renames and also a dictionary that maps those renames. Reported-by: "Dr. David

Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load

2014-07-11 Thread Amit Shah
On (Wed) 09 Jul 2014 [12:00:13], Peter Maydell wrote: > On 9 July 2014 11:56, Amit Shah wrote: > > On (Wed) 09 Jul 2014 [11:50:18], Peter Maydell wrote: > >> OK; we're treating those as bugs so yes, I think this is 2.1 > >> material. Has somebody other than the original author tested > >> it? (Tha

Re: [Qemu-devel] [PATCH] Tap: fix vcpu long time io blocking on tap

2014-07-11 Thread Stefan Hajnoczi
On Fri, Jul 11, 2014 at 01:05:30AM +, Wangkai (Kevin,C) wrote: > When used a tap as net driver for vm, if too many packets was delivered to > the > guest os via tap interface, the guest os will be blocked on io events for a > long > time, while tap driver was busying process packets. > > kv

Re: [Qemu-devel] [PULL 0/1] ui/gtk: Restore keyboard focus after Page change

2014-07-11 Thread Peter Maydell
(2014-07-10 > 11:53:14 +0100) > > are available in the git repository at: > > git://git.kraxel.org/qemu tags/pull-gtk-20140711-1 > > for you to fetch changes up to e72b59fa93b68635f42cdb1b1134f60dd4040d7b: > > ui/gtk: Restore ke

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2014-07-11 Thread vitaly.v.ch
It's just excellent illustration why I hate pipes. So CMake guys can remove this crap from their code and use socketpair() or like instead. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/955379 Title

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2014-07-11 Thread vitaly.v.ch
https://lists.tizen.org/pipermail/dev/2014-July/003424.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/955379 Title: cmake hangs with qemu-arm-static Status in QEMU: Confirmed Status in Linar

Re: [Qemu-devel] [PATCH] block/quorum: add simple read pattern support

2014-07-11 Thread Eric Blake
On 07/10/2014 09:01 PM, Liu Yuan wrote: > This patch adds single read pattern to quorum driver and quorum vote is > default > pattern. > > For now we do a quorum vote on all the reads, it is designed for unreliable > underlying storage such as non-redundant NFS to make sure data integrity at > t

Re: [Qemu-devel] [PATCH v2] libxl: change default QEMU machine to pc-i440fx-1.6

2014-07-11 Thread Ian Campbell
On Fri, 2014-07-11 at 12:14 +0100, Stefano Stabellini wrote: > On Thu, 10 Jul 2014, Ian Jackson wrote: > > Stefano Stabellini writes ("Re: [PATCH v2] libxl: change default QEMU > > machine to pc-i440fx-1.6"): > > > ping? > > > > > > On Thu, 12 Jun 2014, Stefano Stabellini wrote: > > ... > > > > T

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2014-07-11 Thread Peter Maydell
What cmake is doing is an entirely legitimate and well-recognized Unix idiom for converting signals into effects on filedescriptors for select(), and there's no reason for them to change it. This is absolutely a bug in QEMU, it's just one that's not easy for us to fix. (Using socketpair would not h

Re: [Qemu-devel] [PATCH] scripts: qapi-event.py: support vendor extension

2014-07-11 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 10 Jul 2014 16:31:38 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > The event code generator barfs when it sees a dot in an event >> > argument, this makes it impossible to support vendor extensions >> > in event arguments as they always

Re: [Qemu-devel] [PULL 0/1] spice: auth fixes

2014-07-11 Thread Peter Maydell
string (2014-07-10 > 11:53:14 +0100) > > are available in the git repository at: > > git://anongit.freedesktop.org/spice/qemu tags/pull-spice-20140711-1 > > for you to fetch changes up to b1ea7b79e1675355ea7abe2548ad71dcf7d64b60:

Re: [Qemu-devel] [Xen-devel] [PATCH v2] libxl: change default QEMU machine to pc-i440fx-1.6

2014-07-11 Thread Stefano Stabellini
On Fri, 11 Jul 2014, Ian Campbell wrote: > On Fri, 2014-07-11 at 12:14 +0100, Stefano Stabellini wrote: > > On Thu, 10 Jul 2014, Ian Jackson wrote: > > > Stefano Stabellini writes ("Re: [PATCH v2] libxl: change default QEMU > > > machine to pc-i440fx-1.6"): > > > > ping? > > > > > > > > On Thu, 1

Re: [Qemu-devel] [Xen-devel] [PATCH v2] libxl: change default QEMU machine to pc-i440fx-1.6

2014-07-11 Thread Ian Campbell
On Fri, 2014-07-11 at 15:54 +0100, Stefano Stabellini wrote: > On Fri, 11 Jul 2014, Ian Campbell wrote: > > On Fri, 2014-07-11 at 12:14 +0100, Stefano Stabellini wrote: > > > On Thu, 10 Jul 2014, Ian Jackson wrote: > > > > Stefano Stabellini writes ("Re: [PATCH v2] libxl: change default QEMU > > >

[Qemu-devel] [PATCH 0/4] make busybox udhcpc happy

2014-07-11 Thread Joakim Tjernlund
Fix a endian/socket bugs so that busybox udhcpc for qemu-user(host amd64, target ppc) works. Note, the "[PATCH] SIOCGIFINDEX: fix typo" patch sent yesterday is also needed for udhcpc to work. BTW, busybox still generates a Unsupported setsockopt level=263 optname=8 (AUXDATA) but that seems harml

[Qemu-devel] [PATCH 2/4] linux-user: impl. sockaddr_ll

2014-07-11 Thread Joakim Tjernlund
Used by AF_PACKET sockets Signed-off-by: Joakim Tjernlund --- linux-user/syscall.c | 8 linux-user/syscall_defs.h | 10 ++ 2 files changed, 18 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 1380f4e..a0e1ccc 100644 --- a/linux-user/syscall.c +

[Qemu-devel] [PATCH 4/4] ppc: remove excessive logging

2014-07-11 Thread Joakim Tjernlund
ppc logs every type of Invalid instruction. This generates a lot of garbage on console when sshd/ssh_keygen executes as they try various insn to optimize its performance. The invalid operation log is still there so an unknown insn will still be logged. Signed-off-by: Joakim Tjernlund --- linux-u

[Qemu-devel] [PATCH 3/4] alloca one extra byte sockets

2014-07-11 Thread Joakim Tjernlund
target_to_host_sockaddr() may increase the lenth with 1 byte for AF_UNIX sockets so allocate 1 extra byte. Signed-off-by: Joakim Tjernlund --- linux-user/syscall.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index a0e1ccc.

[Qemu-devel] [PATCH 1/4] qemu-user: Impl. setsockopt(SO_BINDTODEVICE)

2014-07-11 Thread Joakim Tjernlund
Signed-off-by: Joakim Tjernlund --- linux-user/syscall.c | 12 1 file changed, 12 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 5a272d3..1380f4e 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -1497,6 +1497,18 @@ set_timeout:

  1   2   >