On 11 July 2014 12:18, Markus Armbruster <arm...@redhat.com> wrote: > Gerd Hoffmann <kra...@redhat.com> writes: > >> Set auth to sasl when sasl is enabled, this makes "info spice" correctly >> display sasl auth. > > Fixes SPICE_CHANNEL_EVENT_CONNECTED similarly, doesn't it? > > If yes, I'd recommend to note this in the commit message. > >> Also throw an error in case someone tries to set >> a spice password via monitor without auth mode being "spice". >> >> Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > > Since the patch looks fine to me: > > Reviewed-by: Markus Armbruster <arm...@redhat.com>
Bit late now, given this is the pullreq; original patch was on list for review 2 July. thanks -- PMM
