Re: [Qemu-devel] [PULL 3/3] configure: Fix -lm test, so that tools can be compiled on hosts that require -lm

2014-07-02 Thread Markus Armbruster
Peter Maydell writes: > On 1 July 2014 09:22, Paolo Bonzini wrote: >> From: Alexey Kardashevskiy >> >> The existing test whether "-lm" needs to be included or not is >> insufficient as it reports false negative on Fedora20/ppc64. >> This happens because sin(0.0) is a constant value which compil

Re: [Qemu-devel] [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-02 Thread Michael S. Tsirkin
On Wed, Jul 02, 2014 at 09:37:44AM +0800, Chen, Tiejun wrote: > On 2014/7/2 2:20, Stefano Stabellini wrote: > >On Tue, 1 Jul 2014, Michael S. Tsirkin wrote: > >>On Tue, Jul 01, 2014 at 05:47:39PM +0100, Stefano Stabellini wrote: > >>>On Tue, 1 Jul 2014, Michael S. Tsirkin wrote: > On Mon, Jun 3

Re: [Qemu-devel] [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-02 Thread Michael S. Tsirkin
On Tue, Jul 01, 2014 at 03:29:03PM -0400, Ross Philipson wrote: > On 07/01/2014 02:06 PM, Michael S. Tsirkin wrote: > >On Tue, Jul 01, 2014 at 01:39:04PM -0400, Ross Philipson wrote: > > [snip] > > > > >What class does your ISA bridge device have? > > #define PCI_CLASS_BRIDGE_ISA 0x0

[Qemu-devel] [PATCH] memory: introduce memory_region_init_ram_nofail() and memory_region_init_ram_ptr_nofail()

2014-07-02 Thread Hu Tao
Introduce memory_region_init_ram_nofail() and memory_region_init_ram_ptr_nofail(), which are the same as memory_region_init_ram() and memory_region_init_ram_ptr() respectively. They will exit qemu if there is an error, this is the behaviour of old memory_region_init_ram() and memory_region_init_ram

[Qemu-devel] Not able to run "virsh qemu-agent-command" when socat is working

2014-07-02 Thread Puneet Bakshi
Hi, I am running qemu guest agent in Windows 2k8. I am able to execute "qemu-agent-commands" using socat but not through "virsh qemu-agent-command". *Guest VM xml* *Guest win2k8 is running following command* C:\qemu-ga> qemu-

Re: [Qemu-devel] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type

2014-07-02 Thread Michael S. Tsirkin
On Thu, Jun 19, 2014 at 05:53:51PM +0800, Tiejun Chen wrote: > Originally the reason to probe ISA bridge instead of Dev31:Fun0 > is to make graphics device passthrough work easy for VMM, that > only need to expose ISA bridge to let driver know the real > hardware underneath. This is a requirement f

Re: [Qemu-devel] [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-02 Thread Michael S. Tsirkin
On Wed, Jul 02, 2014 at 08:59:38AM +0800, Chen, Tiejun wrote: > On 2014/7/1 20:33, Michael S. Tsirkin wrote: > >On Tue, Jul 01, 2014 at 05:46:58PM +0800, Chen, Tiejun wrote: > >>On 2014/7/1 17:12, Michael S. Tsirkin wrote: > >>>On Tue, Jul 01, 2014 at 10:40:42AM +0800, Chen, Tiejun wrote: > On

Re: [Qemu-devel] [PATCH] pci: assign devfn to pci_dev before calling pci_device_iommu_address_space()

2014-07-02 Thread Michael S. Tsirkin
On Wed, Jul 02, 2014 at 08:06:35AM +0800, Le Tan wrote: > In function do_pci_register_device() in file hw/pci/pci.c, move the assignment > of pci_dev->devfn to the position before the call to > pci_device_iommu_address_space(pci_dev) which will use the value of > pci_dev->devfn. Thanks, applied F

Re: [Qemu-devel] [question] Will qemu-2.0.0 be a longterm stablebranch?

2014-07-02 Thread Michael S. Tsirkin
On Tue, Jun 24, 2014 at 02:45:44PM +0800, Zhang Haoyu wrote: > >> Hi, all > >> > >> Which version is best for commercial product, qemu-2.0.0 or other versions? > >> Any advices? > >> > >> Thanks, > >> Zhang Haoyu > > > >Use one of the downstreams: Red Hat, Fedora, Debian all ship QEMU and > >have

Re: [Qemu-devel] [PATCH] Fix nocow typos in manpage

2014-07-02 Thread Stefan Hajnoczi
On Wed, Jul 02, 2014 at 12:27:29PM +0800, Chunyan Liu wrote: > Signed-off-by: Chunyan Liu > --- > qemu-doc.texi | 4 ++-- > qemu-img.texi | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan pgpTmD

Re: [Qemu-devel] [PATCH 1/6] qom: macroify integer property helpers

2014-07-02 Thread Alexander Graf
On 02.07.14 05:29, Peter Crosthwaite wrote: On Wed, Jul 2, 2014 at 7:49 AM, Alexander Graf wrote: We have a bunch of nice helpers that allow us to easily register an integer field as QOM property. However, we have those duplicated for every integer size available. This is very cumbersome (and

Re: [Qemu-devel] [PATCH 2/6] qom: Allow to make integer qom properties writeable

2014-07-02 Thread Alexander Graf
On 02.07.14 05:48, Peter Crosthwaite wrote: On Wed, Jul 2, 2014 at 7:49 AM, Alexander Graf wrote: We have helper functions to easily expose integers as QOM object properties. However, these are read only. I think this is a good idea, and _ptr properties should have some write-ability. Let's

Re: [Qemu-devel] [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-02 Thread Chen, Tiejun
On 2014/7/2 14:09, Michael S. Tsirkin wrote: On Wed, Jul 02, 2014 at 09:37:44AM +0800, Chen, Tiejun wrote: On 2014/7/2 2:20, Stefano Stabellini wrote: On Tue, 1 Jul 2014, Michael S. Tsirkin wrote: On Tue, Jul 01, 2014 at 05:47:39PM +0100, Stefano Stabellini wrote: On Tue, 1 Jul 2014, Michael

Re: [Qemu-devel] [PATCH v2 2.1 3/3] docs/qmp: Fix documentation of BLOCK_JOB_READY to match code

2014-07-02 Thread Paolo Bonzini
Il 01/07/2014 19:12, Eric Blake ha scritto: On 06/27/2014 11:24 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- docs/qmp/qmp-events.txt | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt index 22

Re: [Qemu-devel] [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-02 Thread Chen, Tiejun
On 2014/7/2 14:11, Michael S. Tsirkin wrote: On Tue, Jul 01, 2014 at 03:29:03PM -0400, Ross Philipson wrote: On 07/01/2014 02:06 PM, Michael S. Tsirkin wrote: On Tue, Jul 01, 2014 at 01:39:04PM -0400, Ross Philipson wrote: [snip] What class does your ISA bridge device have? #define PCI_C

Re: [Qemu-devel] [PATCH] cleanup of ROUND_UP-like lines

2014-07-02 Thread Hu Tao
On Tue, Jul 01, 2014 at 02:42:43PM -0600, Eric Blake wrote: > On 06/26/2014 09:50 PM, Hu Tao wrote: > > On Thu, Jun 26, 2014 at 10:55:33AM -0600, Eric Blake wrote: > >> On 06/26/2014 12:13 AM, Hu Tao wrote: > >>> We already have ROUND_UP but there are similar macros and ROUND_UP-like > >>> lines al

[Qemu-devel] [PULL 1/1] add input-send-event command

2014-07-02 Thread Gerd Hoffmann
From: Marcelo Tosatti Which allows specification of absolute/relative, up/down and console parameters. Suggested by Gerd Hoffman. Signed-off-by: Marcelo Tosatti Reviewed-by: Eric Blake Signed-off-by: Gerd Hoffmann --- qapi-schema.json | 17 +++ qmp-commands.hx | 63

[Qemu-devel] [PULL 0/1] add input-send-event command

2014-07-02 Thread Gerd Hoffmann
-input-20140702-1 for you to fetch changes up to 7ca90a7b731ac1fdab93b6816790d0d836a6fd7b: add input-send-event command (2014-07-02 08:40:57 +0200) add input-send-event command

[Qemu-devel] [PATCH] Enforce stack protector usage

2014-07-02 Thread mrezanin
From: Miroslav Rezanina If --enable-stack-protector is used is used, configure script try to use --fstack-protector-strong. In case it's not supported, --fstack-protector-all is enabled. If both protectors are not supported, configure does not use any protector at all without any notification. T

Re: [Qemu-devel] [PATCH for-2.1 1/2] mirror: Fix qiov size for short requests

2014-07-02 Thread Stefan Hajnoczi
On Tue, Jul 01, 2014 at 04:52:21PM +0200, Kevin Wolf wrote: > When mirroring an image of a size that is not a multiple of the > mirror job granularity, the last request would have the right nb_sectors > argument, but a qiov that is rounded up to the next multiple of the > granularity. Don't do this

Re: [Qemu-devel] [PATCH] MAINTAINERS: add Stefan Hajnoczi to IDE maintainers

2014-07-02 Thread Stefan Hajnoczi
On Tue, Jul 01, 2014 at 02:04:31PM +0200, Stefan Hajnoczi wrote: > Make Stefan officially co-maintain hw/ide/ with Kevin. > > Signed-off-by: Stefan Hajnoczi > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) Applied to my block tree: https://github.com/stefanha/qemu/commits/block Stef

Re: [Qemu-devel] [PATCH_v2] ahci.c: mask unused flags when reading size PRDT DBC

2014-07-02 Thread Stefan Hajnoczi
On Tue, Jul 01, 2014 at 01:13:27PM +0200, reza.jel...@tuhh.de wrote: > From: Reza Jelveh > > The data byte count(DBC) read from the description information is defined for > bits 21:00. Bits 30:22 are reserved and bit 31 is the Interrupt on Completion > (I) flag. > > Completion interrupts are tri

Re: [Qemu-devel] [PATCH v2 1/3] block: block: introduce bdrv_io_plug() and bdrv_io_unplug()

2014-07-02 Thread Paolo Bonzini
Il 02/07/2014 02:46, Ming Lei ha scritto: On Wed, Jul 2, 2014 at 12:56 AM, Paolo Bonzini wrote: Il 01/07/2014 17:21, Kevin Wolf ha scritto: Does this bs->file forwarding work for more than the raw driver? For example, if drv is an image format driver that needs to read some metadata from the i

[Qemu-devel] [PATCH RFC v11 1/6] block: round up file size to nearest sector

2014-07-02 Thread Hu Tao
Reviewed-by: Max Reitz Signed-off-by: Hu Tao --- block/qcow2.c | 3 ++- block/raw-posix.c | 4 +-- block/raw-win32.c | 4 +-- tests/qemu-iotests/096 | 64 ++ tests/qemu-iotests/096.out | 14 ++ tests/qemu-i

[Qemu-devel] [PATCH RFC v11 4/6] qapi: introduce PreallocMode and a new PreallocMode full.

2014-07-02 Thread Hu Tao
This patch prepares for the subsequent patches. Reviewed-by: Fam Zheng Reviewed-by: Eric Blake Signed-off-by: Hu Tao --- block/qcow2.c| 16 qapi/block-core.json | 17 + 2 files changed, 25 insertions(+), 8 deletions(-) diff --git a/block/qcow2.c b/bloc

[Qemu-devel] [PATCH RFC v11 0/6] qcow2, raw: add preallocation=full and preallocation=falloc

2014-07-02 Thread Hu Tao
Kevin, This is v11 series for you to check how the series depends on Max's minimal_blob_size(). I'm aware that you rejected the calculation of metadata size, but posting this series so that you can comment on it. This series depends on patches 1-3 of Max's series 'qemu-img: Implement commit like

[Qemu-devel] [PATCH RFC v11 6/6] qcow2: Add falloc and full preallocation option

2014-07-02 Thread Hu Tao
This adds preallocation=falloc and preallocation=full mode to qcow2 image creation. preallocation=full allocates disk space by writing zeros to disk to ensure disk space in any cases. preallocation=falloc likes preallocation=full, but allocates disk space by posix_fallocate(). Signed-off-by: Hu

[Qemu-devel] [PATCH RFC v11 2/6] raw, qcow2: don't convert file size to sector size

2014-07-02 Thread Hu Tao
and avoid converting it back later. Reviewed-by: Max Reitz Signed-off-by: Hu Tao --- block/qcow2.c | 10 +- block/raw-posix.c | 6 +++--- block/raw-win32.c | 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 0dfbb9a..05d

[Qemu-devel] [PATCH RFC v11 5/6] raw-posix: Add falloc and full preallocation option

2014-07-02 Thread Hu Tao
This patch adds a new option preallocation for raw format, and implements falloc and full preallocation. Signed-off-by: Hu Tao --- block/raw-posix.c | 62 --- 1 file changed, 55 insertions(+), 7 deletions(-) diff --git a/block/raw-posix.c b/bl

Re: [Qemu-devel] [PATCH 3/6] sysbus: Add user map hints

2014-07-02 Thread Alexander Graf
On 02.07.14 06:12, Peter Crosthwaite wrote: On Wed, Jul 2, 2014 at 7:49 AM, Alexander Graf wrote: We want to give the user the ability to tell our machine file where he wants to have devices mapped to. This patch adds code to create these hints dynamically and expose them as object properties

Re: [Qemu-devel] [PATCH v2] qemu-iotests: Disable Quorum testing in 041 when Quorum is not builtin

2014-07-02 Thread Stefan Hajnoczi
On Tue, Jul 01, 2014 at 01:34:12PM +0200, BenoƮt Canet wrote: > This avoid breaking tests on RHEL6 where gnutls is too old for quorum to be > built by default. > > Signed-off-by: Benoit Canet > --- > tests/qemu-iotests/041 | 41 +++-- > 1 file changed, 39 inse

[Qemu-devel] [Question] suse11sp3 32bit guest os panic on kvm

2014-07-02 Thread Gonglei (Arei)
Hi, all Recently I encounter a confused issue that described by the title. I get the dump core according "virsh dump", and this below is the core Information. It seem as that the vcpu deadlock between irqbalance process(_raw_spin_lock_irqsave) and an interrupt handle (_raw_spin_lock), I'm so confu

Re: [Qemu-devel] [PATCH v2 0/4] virtio-blk: fix issues with unified virtio-blk request handling

2014-07-02 Thread Christian Borntraeger
On 01/07/14 17:25, Stefan Hajnoczi wrote: > This series fixes issues recently introduced when unifying virtio-blk > dataplane's request handling with non-dataplane virtio-blk. > > The problems include broken memory allocation for dataplane requests and a > performance regression for non-dataplane.

Re: [Qemu-devel] [PATCH 3/6] sysbus: Add user map hints

2014-07-02 Thread Paolo Bonzini
Il 02/07/2014 10:24, Alexander Graf ha scritto: So this suggests your reasoning for side effected _ptr write is just for validity checking. So another approach could be to add a "check" function to the _ptr variants (rather than an open coded) setter. This has the advantage of being consistent

Re: [Qemu-devel] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type

2014-07-02 Thread Chen, Tiejun
On 2014/7/2 14:21, Michael S. Tsirkin wrote: On Thu, Jun 19, 2014 at 05:53:51PM +0800, Tiejun Chen wrote: Originally the reason to probe ISA bridge instead of Dev31:Fun0 is to make graphics device passthrough work easy for VMM, that only need to expose ISA bridge to let driver know the real hard

Re: [Qemu-devel] [PATCH]Fix a error in mc146818rtc.c

2014-07-02 Thread Stefan Hajnoczi
On Tue, Jul 01, 2014 at 03:53:08AM +0800, Lb peace wrote: > If you use hwclock in guest os ,you will find the result of hwclock isn't > changed after changing host os's clock. > I find this issue is generated in this patch: > > http://lists.gnu.org/archive/html/qemu-devel/2013-08/msg03353.html > B

Re: [Qemu-devel] [PATCH v2 1/3] block: block: introduce bdrv_io_plug() and bdrv_io_unplug()

2014-07-02 Thread Kevin Wolf
Am 02.07.2014 um 10:18 hat Paolo Bonzini geschrieben: > Il 02/07/2014 02:46, Ming Lei ha scritto: > >On Wed, Jul 2, 2014 at 12:56 AM, Paolo Bonzini wrote: > >>Il 01/07/2014 17:21, Kevin Wolf ha scritto: > >>Does this bs->file forwarding work for more than the raw driver? For > >>example, i

Re: [Qemu-devel] [PATCH v2 1/3] block: block: introduce bdrv_io_plug() and bdrv_io_unplug()

2014-07-02 Thread Ming Lei
On Wed, Jul 2, 2014 at 4:18 PM, Paolo Bonzini wrote: > Il 02/07/2014 02:46, Ming Lei ha scritto: > >> On Wed, Jul 2, 2014 at 12:56 AM, Paolo Bonzini >> wrote: >>> >>> Il 01/07/2014 17:21, Kevin Wolf ha scritto: >>> >>> Does this bs->file forwarding work for more than the raw driver? For >

Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression

2014-07-02 Thread Paolo Bonzini
Il 02/07/2014 08:55, Markus Armbruster ha scritto: > I think this fixes itself automatically if you use > rerror=stop/werror=stop on block jobs. At least that was part of the > design, whether the implementation gets it right I cannot say without > looking at the code more carefully. What if an

[Qemu-devel] [PATCH RFC v11 3/6] rename parse_enum_option to qapi_enum_parse and make it public

2014-07-02 Thread Hu Tao
Suggested-by: Markus Armbruster Reviewed-by: Max Reitz Signed-off-by: Hu Tao --- blockdev.c | 30 ++ include/qapi/util.h | 17 + qapi/Makefile.objs | 1 + qapi/qapi-util.c| 32 4 files changed, 56 insert

Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression

2014-07-02 Thread Kevin Wolf
Am 02.07.2014 um 10:23 hat Paolo Bonzini geschrieben: > Il 02/07/2014 08:55, Markus Armbruster ha scritto: > >>> I think this fixes itself automatically if you use > >>> rerror=stop/werror=stop on block jobs. At least that was part of the > >>> design, whether the implementation gets it right I ca

Re: [Qemu-devel] [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-02 Thread Chen, Tiejun
On 2014/7/2 14:22, Michael S. Tsirkin wrote: On Wed, Jul 02, 2014 at 08:59:38AM +0800, Chen, Tiejun wrote: On 2014/7/1 20:33, Michael S. Tsirkin wrote: On Tue, Jul 01, 2014 at 05:46:58PM +0800, Chen, Tiejun wrote: On 2014/7/1 17:12, Michael S. Tsirkin wrote: On Tue, Jul 01, 2014 at 10:40:42AM

Re: [Qemu-devel] [PATCH v2 2.1 3/3] docs/qmp: Fix documentation of BLOCK_JOB_READY to match code

2014-07-02 Thread Kevin Wolf
Am 02.07.2014 um 08:49 hat Markus Armbruster geschrieben: > Eric Blake writes: > > > On 06/27/2014 11:24 AM, Markus Armbruster wrote: > >> Signed-off-by: Markus Armbruster > >> --- > >> docs/qmp/qmp-events.txt | 12 ++-- > >> 1 file changed, 10 insertions(+), 2 deletions(-) > >> > >> d

Re: [Qemu-devel] [PATCH v2 1/3] block: block: introduce bdrv_io_plug() and bdrv_io_unplug()

2014-07-02 Thread Paolo Bonzini
Il 02/07/2014 10:38, Kevin Wolf ha scritto: > On top of this, there _could_ be reasons for formats to implement > plug/unplug themselves. They could coalesce metadata reads or > copy-on-write operations, for example. This however is independent > from the default behavior, which IMO is "pluggin

Re: [Qemu-devel] [PATCH for-2.1 1/2] mirror: Fix qiov size for short requests

2014-07-02 Thread Kevin Wolf
Am 01.07.2014 um 18:52 hat Eric Blake geschrieben: > On 07/01/2014 08:52 AM, Kevin Wolf wrote: > > When mirroring an image of a size that is not a multiple of the > > mirror job granularity, the last request would have the right nb_sectors > > argument, but a qiov that is rounded up to the next mul

[Qemu-devel] [PATCH] ide: fix double free

2014-07-02 Thread arei.gonglei
From: Chenliang Qemu may double free when excutes command "reboot -f" in vm. One path is bdrv_aio_cancel(), the other is dma_bdrv_cb() callback prcocess. Signed-off-by: Chenliang Signed-off-by: Gonglei --- Qemu crash bt: Program received signal SIGABRT, Aborted. 0x7f3cb2c76b55 in raise ()

Re: [Qemu-devel] [regression] dataplane: throughout -40% by commit 580b6b2aa2

2014-07-02 Thread Stefan Hajnoczi
On Tue, Jul 01, 2014 at 06:49:30PM +0200, Paolo Bonzini wrote: > Il 01/07/2014 16:49, Ming Lei ha scritto: > >Let me provide some data when running randread(bs 4k, libaio) > >from VM for 10sec: > > > >1), qemu.git/master > >- write(): 731K > >- rt_sigprocmask(): 417K > >- read(): 21K > >- ppoll():

Re: [Qemu-devel] [PATCH v2 1/3] block: block: introduce bdrv_io_plug() and bdrv_io_unplug()

2014-07-02 Thread Paolo Bonzini
Il 02/07/2014 10:39, Ming Lei ha scritto: Then start to read payload in original path, but no plug/unplug any more. Also another request may follows, and another plug&unplug comes too, which makes thing more complicated, so I suggest to enable plug&unplug only for raw driver now. That's just a

Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression

2014-07-02 Thread Paolo Bonzini
Il 02/07/2014 10:44, Kevin Wolf ha scritto: > Then the "fix" is to add support to the underlying device. IDE, > SCSI and virtio-blk (plus virtio-scsi via SCSI of course) are > covered; the main one that's left out is SD. Isn't block job rerror/werror completely independent from the guest device

Re: [Qemu-devel] [PATCH v2 2.1 2/3] blockjob: Fix recent BLOCK_JOB_ERROR regression

2014-07-02 Thread Paolo Bonzini
Il 02/07/2014 08:46, Markus Armbruster ha scritto: > I think consistency between BLOCK_IO_ERROR and BLOCK_JOB_ERROR is > better. Moreover, BlockdevOnError's enospc is meaningless here. > Let's fix the BlockErrorAction documentation instead. I didn't quite understand what's wrong with

Re: [Qemu-devel] [RFC PATCH v1 2/2] e1000: adjust initial autoneg timing (for piix/osx)

2014-07-02 Thread Gabriel L. Somlo
On Mon, Jun 30, 2014 at 08:21:43PM +0200, Alexander Graf wrote: > > > > Am 30.06.2014 um 19:55 schrieb "Michael S. Tsirkin" : > > > >> On Mon, Jun 30, 2014 at 12:55:50PM -0400, Gabriel L. Somlo wrote: > >> When running on PIIX (as opposed to q35), the stock OS X e1000 > >> driver (AppleIntel8254

Re: [Qemu-devel] [PATCH 3/6] sysbus: Add user map hints

2014-07-02 Thread Peter Crosthwaite
On Wed, Jul 2, 2014 at 6:24 PM, Alexander Graf wrote: > > On 02.07.14 06:12, Peter Crosthwaite wrote: >> >> On Wed, Jul 2, 2014 at 7:49 AM, Alexander Graf wrote: >>> >>> We want to give the user the ability to tell our machine file where he >>> wants >>> to have devices mapped to. This patch adds

Re: [Qemu-devel] [PATCH] ide: fix double free

2014-07-02 Thread Paolo Bonzini
Il 02/07/2014 10:50, arei.gong...@huawei.com ha scritto: > if (bus->dma->aiocb) { > -#ifdef DEBUG_AIO > -printf("aio_cancel\n"); > -#endif > -bdrv_aio_cancel(bus->dma->aiocb); > -bus->dma->aiocb = NULL; > +bdrv_drain_all(); > +bdrv_flush_all(); > +

Re: [Qemu-devel] [PATCH 3/6] sysbus: Add user map hints

2014-07-02 Thread Alexander Graf
On 02.07.14 11:03, Peter Crosthwaite wrote: On Wed, Jul 2, 2014 at 6:24 PM, Alexander Graf wrote: On 02.07.14 06:12, Peter Crosthwaite wrote: On Wed, Jul 2, 2014 at 7:49 AM, Alexander Graf wrote: We want to give the user the ability to tell our machine file where he wants to have devices ma

Re: [Qemu-devel] [PATCH v2 1/3] block: block: introduce bdrv_io_plug() and bdrv_io_unplug()

2014-07-02 Thread Kevin Wolf
Am 02.07.2014 um 10:56 hat Paolo Bonzini geschrieben: > Il 02/07/2014 10:39, Ming Lei ha scritto: > >Then start to read payload in original path, but no plug/unplug any > >more. Also another request may follows, and another plug&unplug > >comes too, which makes thing more complicated, so I suggest

Re: [Qemu-devel] [regression] dataplane: throughout -40% by commit 580b6b2aa2

2014-07-02 Thread Paolo Bonzini
Il 02/07/2014 10:54, Stefan Hajnoczi ha scritto: Both can be eliminated by introducing a fast path in bdrv_aio_{read,write}v, that bypasses coroutines in the common case of no I/O throttling, no copy-on-write, etc. I tried that in 2012 and couldn't measure an improvement above the noise thresho

[Qemu-devel] [PATCH for-2.1] acpi: fix typo in memory hotplug MMIO region name

2014-07-02 Thread Igor Mammedov
Reported-by: Sergey Fionov Signed-off-by: Igor Mammedov --- hw/acpi/memory_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c index 38ca415..ed39241 100644 --- a/hw/acpi/memory_hotplug.c +++ b/hw/acpi/memory_hotplug.c

Re: [Qemu-devel] [RFC PATCH v1 2/2] e1000: adjust initial autoneg timing (for piix/osx)

2014-07-02 Thread Alexander Graf
On 02.07.14 11:02, Gabriel L. Somlo wrote: On Mon, Jun 30, 2014 at 08:21:43PM +0200, Alexander Graf wrote: Am 30.06.2014 um 19:55 schrieb "Michael S. Tsirkin" : On Mon, Jun 30, 2014 at 12:55:50PM -0400, Gabriel L. Somlo wrote: When running on PIIX (as opposed to q35), the stock OS X e1000 d

Re: [Qemu-devel] [PATCH 3/6] sysbus: Add user map hints

2014-07-02 Thread Paolo Bonzini
Il 02/07/2014 11:07, Alexander Graf ha scritto: So the way this is handled for links is its an open coded check function added by the property adder. Check qdev_prop_allow_set_link_before_realize() for a precedent. However, unlike Alex's case the link setter is complicated and a simple tail ca

Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing changes

2014-07-02 Thread Benjamin Herrenschmidt
On Tue, 2014-07-01 at 21:23 +1000, Benjamin Herrenschmidt wrote: > On Tue, 2014-07-01 at 13:15 +0200, Gerd Hoffmann wrote: > > TCG works. Any workaround to make it fly with kvm too? > > > > And win98 actually uses the hardware cursor. > > Ah ok. I was trying to install NT4 here but was having pr

Re: [Qemu-devel] [PATCH 3/6] sysbus: Add user map hints

2014-07-02 Thread Alexander Graf
On 02.07.14 11:17, Paolo Bonzini wrote: Il 02/07/2014 11:07, Alexander Graf ha scritto: So the way this is handled for links is its an open coded check function added by the property adder. Check qdev_prop_allow_set_link_before_realize() for a precedent. However, unlike Alex's case the link s

Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing changes

2014-07-02 Thread Benjamin Herrenschmidt
On Wed, 2014-07-02 at 19:19 +1000, Benjamin Herrenschmidt wrote: > NT4 works a lot better without -enable-kvm :-) (file corruption, general > bad behaviour...). > > I can confirm the cursor is missing in 16bpp with cirrus on NT4 as well, > I'll play with it later this week or week-end, unless you

Re: [Qemu-devel] [PATCH] ide: fix double free

2014-07-02 Thread ChenLiang
On 2014/7/2 17:04, Paolo Bonzini wrote: > This is definitely a heavyweight solution, and in fact the bug should > not be there in the first place. See dma_complete: > > static void dma_complete(DMAAIOCB *dbs, int ret) > { > trace_dma_complete(dbs, ret, dbs->common.cb); > > dma_bdrv_unm

Re: [Qemu-devel] [question] Will qemu-2.0.0 be a longterm stablebranch?

2014-07-02 Thread Paolo Bonzini
Il 02/07/2014 08:32, Michael S. Tsirkin ha scritto: On Tue, Jun 24, 2014 at 02:45:44PM +0800, Zhang Haoyu wrote: > >> Hi, all > >> > >> Which version is best for commercial product, qemu-2.0.0 or other versions? > >> Any advices? > >> > >> Thanks, > >> Zhang Haoyu > > > >Use one of the downstre

Re: [Qemu-devel] [PATCH] ide: fix double free

2014-07-02 Thread Paolo Bonzini
Il 02/07/2014 11:24, ChenLiang ha scritto: On 2014/7/2 17:04, Paolo Bonzini wrote: This is definitely a heavyweight solution, and in fact the bug should not be there in the first place. See dma_complete: static void dma_complete(DMAAIOCB *dbs, int ret) { trace_dma_complete(dbs, ret, dbs->

Re: [Qemu-devel] [PATCH 3/6] sysbus: Add user map hints

2014-07-02 Thread Paolo Bonzini
Il 02/07/2014 11:19, Alexander Graf ha scritto: On 02.07.14 11:17, Paolo Bonzini wrote: Il 02/07/2014 11:07, Alexander Graf ha scritto: So the way this is handled for links is its an open coded check function added by the property adder. Check qdev_prop_allow_set_link_before_realize() for a pr

Re: [Qemu-devel] [PATCH v2 1/3] block: block: introduce bdrv_io_plug() and bdrv_io_unplug()

2014-07-02 Thread Ming Lei
On Wed, Jul 2, 2014 at 4:56 PM, Paolo Bonzini wrote: > Il 02/07/2014 10:39, Ming Lei ha scritto: > >> Then start to read payload in original path, but no plug/unplug any >> more. Also another request may follows, and another plug&unplug >> comes too, which makes thing more complicated, so I sugges

Re: [Qemu-devel] [PATCH v2 1/3] block: block: introduce bdrv_io_plug() and bdrv_io_unplug()

2014-07-02 Thread Ming Lei
On Wed, Jul 2, 2014 at 5:12 PM, Kevin Wolf wrote: > Am 02.07.2014 um 10:56 hat Paolo Bonzini geschrieben: >> Il 02/07/2014 10:39, Ming Lei ha scritto: >> >Then start to read payload in original path, but no plug/unplug any >> >more. Also another request may follows, and another plug&unplug >> >com

Re: [Qemu-devel] [PATCH] Enforce stack protector usage

2014-07-02 Thread Markus Armbruster
mreza...@redhat.com writes: > From: Miroslav Rezanina > > If --enable-stack-protector is used is used, configure script try to use > --fstack-protector-strong. In case it's not supported, --fstack-protector-all > is enabled. If both protectors are not supported, configure does not use > any prote

Re: [Qemu-devel] [PATCH] Enforce stack protector usage

2014-07-02 Thread Paolo Bonzini
Il 02/07/2014 10:05, mreza...@redhat.com ha scritto: From: Miroslav Rezanina If --enable-stack-protector is used is used, configure script try to use --fstack-protector-strong. In case it's not supported, --fstack-protector-all is enabled. If both protectors are not supported, configure does no

Re: [Qemu-devel] [regression] dataplane: throughout -40% by commit 580b6b2aa2

2014-07-02 Thread Kevin Wolf
Am 02.07.2014 um 11:13 hat Paolo Bonzini geschrieben: > Il 02/07/2014 10:54, Stefan Hajnoczi ha scritto: > >>Both can be eliminated by introducing a fast path in bdrv_aio_{read,write}v, > >>that bypasses coroutines in the common case of no I/O throttling, no > >>copy-on-write, etc. > > > >I tried t

[Qemu-devel] [Bug 1327800] Re: USB mouse is jumpy on y-axis (patch attached)

2014-07-02 Thread Christian Burger
** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1327800 Title: USB mouse is jumpy on y-axis (patch attached) Status in QEMU: Fix Committed

Re: [Qemu-devel] [PATCH v4 00/33] target-arm: add Security Extensions for CPUs

2014-07-02 Thread Aggeler Fabian
Hey Greg Great to see this version. I will try to go through it in the next days. Best, Fabian On 01 Jul 2014, at 01:09, greg.bell...@linaro.org wrote: > From: Greg Bellows > > Updated Fabian's v3 patchset for review comments. This patchset includes > changes in support of the security exten

Re: [Qemu-devel] [PULL 3/3] configure: Fix -lm test, so that tools can be compiled on hosts that require -lm

2014-07-02 Thread Peter Maydell
On 2 July 2014 08:02, Markus Armbruster wrote: >> This looks to me like we're leaving ourselves open for >> a smarter compiler with linktime optimisation to complain >> that x is used uninitialized. > > x *is* initialized, to zero. A sufficiently smart compiler(TM) could > figure out that x is st

Re: [Qemu-devel] [PATCH]Fix a error in mc146818rtc.c

2014-07-02 Thread Paolo Bonzini
Il 30/06/2014 21:53, Lb peace ha scritto: If you use hwclock in guest os ,you will find the result of hwclock isn't changed after changing host os's clock. I find this issue is generated in this patch: http://lists.gnu.org/archive/html/qemu-devel/2013-08/msg03353.html Before this patch,the resul

Re: [Qemu-devel] [PATCH] ide: fix double free

2014-07-02 Thread Gonglei (Arei)
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Wednesday, July 02, 2014 5:26 PM > To: chenliang (T) > Cc: Gonglei (Arei); qemu-devel@nongnu.org; kw...@redhat.com; > stefa...@redhat.com; Huangweidong (C) > Subject: Re: [PATCH] ide: fix double free > > Il 02/

Re: [Qemu-devel] [regression] dataplane: throughout -40% by commit 580b6b2aa2

2014-07-02 Thread Paolo Bonzini
Il 02/07/2014 11:39, Kevin Wolf ha scritto: Am 02.07.2014 um 11:13 hat Paolo Bonzini geschrieben: I don't think starting with that fast path as _the_ solution is a good idea. It would essentially restrict dataplane to the scenarios that used to work well in 2.0 - just look at what the block.c rea

Re: [Qemu-devel] [PATCH v2 1/3] block: block: introduce bdrv_io_plug() and bdrv_io_unplug()

2014-07-02 Thread Kevin Wolf
Am 02.07.2014 um 11:29 hat Ming Lei geschrieben: > On Wed, Jul 2, 2014 at 5:12 PM, Kevin Wolf wrote: > > Am 02.07.2014 um 10:56 hat Paolo Bonzini geschrieben: > >> Il 02/07/2014 10:39, Ming Lei ha scritto: > >> >Then start to read payload in original path, but no plug/unplug any > >> >more. Also a

[Qemu-devel] [PATCH] qemu-img info: show nocow info

2014-07-02 Thread Chunyan Liu
Add nocow info in 'qemu-img info' output to show whether the file currently has NOCOW flag set or not. Signed-off-by: Chunyan Liu --- block/qapi.c | 25 + qapi/block-core.json | 3 ++- 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/block/qapi.c b/

Re: [Qemu-devel] [regression] dataplane: throughout -40% by commit 580b6b2aa2

2014-07-02 Thread Kevin Wolf
Am 02.07.2014 um 11:48 hat Paolo Bonzini geschrieben: > Il 02/07/2014 11:39, Kevin Wolf ha scritto: > >Am 02.07.2014 um 11:13 hat Paolo Bonzini geschrieben: > >I don't think starting with that fast path as _the_ solution is a good > >idea. It would essentially restrict dataplane to the scenarios th

Re: [Qemu-devel] [PATCH v2 1/3] block: block: introduce bdrv_io_plug() and bdrv_io_unplug()

2014-07-02 Thread Ming Lei
On Wed, Jul 2, 2014 at 5:49 PM, Kevin Wolf wrote: > Am 02.07.2014 um 11:29 hat Ming Lei geschrieben: >> On Wed, Jul 2, 2014 at 5:12 PM, Kevin Wolf wrote: >> > Am 02.07.2014 um 10:56 hat Paolo Bonzini geschrieben: >> >> Il 02/07/2014 10:39, Ming Lei ha scritto: >> >> >Then start to read payload in

Re: [Qemu-devel] [PATCH v3] e1000: clean up phyreg_writeops/set_phy_ctrl

2014-07-02 Thread Michael S. Tsirkin
On Tue, Jul 01, 2014 at 03:03:48PM -0400, Gabriel L. Somlo wrote: > Make phyreg_writeops responsible for actually writing their > respective phy registers. The only current instance of > phyreg_writeops is set_phy_ctrl(), which we modify to actually > write the register, while also correctly handli

Re: [Qemu-devel] [PATCH for-2.1] acpi: fix typo in memory hotplug MMIO region name

2014-07-02 Thread Peter Crosthwaite
On Wed, Jul 2, 2014 at 7:16 PM, Igor Mammedov wrote: > Reported-by: Sergey Fionov > Signed-off-by: Igor Mammedov Reviewed-by: Peter Crosthwaite > --- > hw/acpi/memory_hotplug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_

Re: [Qemu-devel] [PATCH] ide: fix double free

2014-07-02 Thread Paolo Bonzini
Il 02/07/2014 11:46, Gonglei (Arei) ha scritto: Hi, Paolo. We have tested your above patch, and it works well for us. I'm still not sure where the fix is. I jotted the patch quickly, but I'd rather understand it better before submitting it. Here is it again: --- a/dma-helpers.c +++ b/dma-h

Re: [Qemu-devel] [PATCH v3] e1000: clean up phyreg_writeops/set_phy_ctrl

2014-07-02 Thread Michael S. Tsirkin
On Wed, Jul 02, 2014 at 12:12:30PM +0300, Michael S. Tsirkin wrote: > On Tue, Jul 01, 2014 at 03:03:48PM -0400, Gabriel L. Somlo wrote: > > Make phyreg_writeops responsible for actually writing their > > respective phy registers. The only current instance of > > phyreg_writeops is set_phy_ctrl(), w

Re: [Qemu-devel] [regression] dataplane: throughout -40% by commit 580b6b2aa2

2014-07-02 Thread Paolo Bonzini
Il 02/07/2014 12:01, Kevin Wolf ha scritto: Am 02.07.2014 um 11:48 hat Paolo Bonzini geschrieben: Il 02/07/2014 11:39, Kevin Wolf ha scritto: Am 02.07.2014 um 11:13 hat Paolo Bonzini geschrieben: I don't think starting with that fast path as _the_ solution is a good idea. It would essentially r

Re: [Qemu-devel] [PATCH v2 1/3] block: block: introduce bdrv_io_plug() and bdrv_io_unplug()

2014-07-02 Thread Paolo Bonzini
Il 02/07/2014 12:02, Ming Lei ha scritto: Actually linux-aio can support to submit read/write to multi files, and virtio-scsi does have the use case, so in future io queue should be per aio-context as I posted 1st time. And I am wondering if multiwrite-like APIs can fit in this situation. Thou

Re: [Qemu-devel] [PATCH v2 1/3] block: block: introduce bdrv_io_plug() and bdrv_io_unplug()

2014-07-02 Thread Ming Lei
On Wed, Jul 2, 2014 at 6:24 PM, Paolo Bonzini wrote: > Il 02/07/2014 12:02, Ming Lei ha scritto: > Actually linux-aio can support to submit read/write to multi files, and virtio-scsi does have the use case, so in future io queue should be per aio-context as I posted 1st time. And I

Re: [Qemu-devel] [RFC PATCH v1 2/2] e1000: adjust initial autoneg timing (for piix/osx)

2014-07-02 Thread Michael S. Tsirkin
On Wed, Jul 02, 2014 at 05:02:07AM -0400, Gabriel L. Somlo wrote: > On Mon, Jun 30, 2014 at 08:21:43PM +0200, Alexander Graf wrote: > > > > > > > Am 30.06.2014 um 19:55 schrieb "Michael S. Tsirkin" : > > > > > >> On Mon, Jun 30, 2014 at 12:55:50PM -0400, Gabriel L. Somlo wrote: > > >> When runni

Re: [Qemu-devel] [RFC PATCH 18/22] Network packets record/replay

2014-07-02 Thread Pavel Dovgaluk
> > --- /dev/null > > +++ b/net/net-replay.c > > @@ -0,0 +1,56 @@ > > +#include "net/net.h" > > Missing a copyright statement and declaration of license. (We prefer > GPLv2+ for new files, unless you have a strong reason otherwise, but > whatever you pick must be compatible with GPLv2-only) > >

Re: [Qemu-devel] [RFC PATCH 08/22] Monitor commands

2014-07-02 Thread Pavel Dovgaluk
> -Original Message- > From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Tuesday, July 01, 2014 9:33 PM > To: Pavel Dovgaluk; 'QEMU Developers' > Subject: Re: [Qemu-devel] [RFC PATCH 08/22] Monitor commands > > On 07/01/2014 05:23 AM, Pavel Dovgaluk wrote: > > This patch adds commands to

Re: [Qemu-devel] [RFC PATCH 01/22] Makefiles

2014-07-02 Thread Kirill Batuzov
On Tue, 1 Jul 2014, Pavel Dovgaluk wrote: > Changes in main makefiles. > > Signed-off-by: Pavel Dovgalyuk > --- > > diff --git a/Makefile.target b/Makefile.target > index 6089d29..357ab4d > --- a/Makefile.target > +++ b/Makefile.target > @@ -76,6 +76,7 @@ all: $(PROGS) stap > #

Re: [Qemu-devel] [RFC PATCH 19/22] Deterministic replay core functions

2014-07-02 Thread Kirill Batuzov
On Tue, 1 Jul 2014, Pavel Dovgaluk wrote: > Functions for writing and reading replay log. These functions are used to > record the following events: > * Output of the time() function > * Sound in and sound out events in winaudio > * Hardware interrupts and exceptions > * Special replay debug

Re: [Qemu-devel] [RFC PATCH 08/22] Monitor commands

2014-07-02 Thread Kirill Batuzov
On Wed, 2 Jul 2014, Pavel Dovgaluk wrote: > > -Original Message- > > From: Eric Blake [mailto:ebl...@redhat.com] > > Sent: Tuesday, July 01, 2014 9:33 PM > > To: Pavel Dovgaluk; 'QEMU Developers' > > Subject: Re: [Qemu-devel] [RFC PATCH 08/22] Monitor commands > > > > On 07/01/2014 05:2

Re: [Qemu-devel] [PATCH v1] virtio: move common virtio properties to bus class device

2014-07-02 Thread Michael S. Tsirkin
On Tue, Jul 01, 2014 at 12:01:58AM +0800, Ming Lei wrote: > The two common virtio features can be defined per bus, so move all > into bus class device to make code more clean. > > As discussed with cornelia, s390-virtio-blk doesn't support > the two features at all, so keep s390-virtio as it. > >

[Qemu-devel] [PULL 01/01] [seccomp] changing email contact for Eduardo Otubo

2014-07-02 Thread Eduardo Otubo
--- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 9b93edd..e7dc907 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -853,7 +853,7 @@ S: Odd Fixes F: scripts/checkpatch.pl Seccomp -M: Eduardo Otubo +M: Eduardo Otubo S: Supported

[Qemu-devel] [PULL 00/01] [seccomp] changing email contact for Eduardo Otubo

2014-07-02 Thread Eduardo Otubo
Eduardo Otubo (1): [seccomp] changing email contact for Eduardo Otubo MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.9.1

Re: [Qemu-devel] [PULL 00/01] [seccomp] changing email contact for Eduardo Otubo

2014-07-02 Thread Peter Maydell
On 2 July 2014 12:01, Eduardo Otubo wrote: > Eduardo Otubo (1): > [seccomp] changing email contact for Eduardo Otubo > > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This claims to be a pull request but it is missing the actual git url you're asking me to pull... thanks

Re: [Qemu-devel] [PATCH] ide: fix double free

2014-07-02 Thread ChenLiang
On 2014/7/2 18:16, Paolo Bonzini wrote: > Il 02/07/2014 11:46, Gonglei (Arei) ha scritto: >> Hi, Paolo. We have tested your above patch, and it works well for us. > > I'm still not sure where the fix is. I jotted the patch quickly, but I'd > rather understand it better before submitting it. He

[Qemu-devel] [PATCH] spice: auth fixes

2014-07-02 Thread Gerd Hoffmann
Set auth to sasl when sasl is enabled, this makes "info spice" correctly display sasl auth. Also throw an error in case someone tries to set a spice password via monitor without auth mode being "spice". Signed-off-by: Gerd Hoffmann --- ui/spice-core.c | 5 + 1 file changed, 5 insertions(+)

  1   2   3   >