On Wed, 2 Jul 2014, Pavel Dovgaluk wrote:
> > -----Original Message----- > > From: Eric Blake [mailto:ebl...@redhat.com] > > Sent: Tuesday, July 01, 2014 9:33 PM > > To: Pavel Dovgaluk; 'QEMU Developers' > > Subject: Re: [Qemu-devel] [RFC PATCH 08/22] Monitor commands > > > > On 07/01/2014 05:23 AM, Pavel Dovgaluk wrote: > > > This patch adds commands to control replay from the monitor. > > > > > > Signed-off-by: Pavel Dovgalyuk <pavel.dovga...@gmail.com> > > > --- > > > > What are the counterpart QMP commands? It is seldom right to add an HMP > > command unless the same thing can be done via QMP. > > We haven't controlled qemu through QMP yet, thus haven't implemented QMP > support > for replay commands. > > Today I started adding this support and noticed, that QMP in current master > branch is > broken - it does not reply anything except information at start. > On Windows hosts only. I've sent a fix for this problem yesterday: https://lists.gnu.org/archive/html/qemu-devel/2014-07/msg00169.html > > > @@ -2596,6 +2734,7 @@ int monitor_handle_fd_param2(Monitor *mon, const > > > char *fdname, Error > > **errp) > > > return fd; > > > } > > > > > > + > > > /* Please update hmp-commands.hx when adding or changing commands */ > > > static mon_cmd_t info_cmds[] = { > > > > Spurious newline addition? > > Thanks, forgot to undo this. > > Pavel Dovgaluk > > > -- Kirill
