From: Gonglei
Spotted by Coverity:
(1) Event assignment: Assigning: "pixels" = "0".
(2) Event cond_true: Condition "y < h", taking true branch
(3) Event cond_false: Condition "x < w", taking false branch
(4) Event loop_end: Reached end of loop
(5) Event divide_by_zero: In expression "(stats
[quoted lines by Dave Mielke on 2014/05/26 at 08:59 -0400]
I'm sorry for quoting myself, but I'm doing it for context since I have a
question:
>This patch, attached as qemu-kbddelay-1.patch, is a rework of the former curses
>UI patch so that the delay applies to key events in general. A new optio
From: Gonglei
Spotted by Coverity:
(8) Event freed_arg: "fclose(FILE *)" frees "wav->f".
(9) Event cond_true: Condition "fclose(wav->f)", taking true branch
Also see events: [pass_freed_arg]
212 if (fclose (wav->f)) {
(10) Event pass_freed_arg: Passing freed pointer "wav->f" as an
From: Gonglei
Spotted by Coverity:
(3) Event alloc_fn: Storage is returned from allocation function
"qemu_blockalign(BlockDriverState *, size_t)". [details]
(4) Event var_assign: Assigning: "iov.iov_base" = storage returned from
"qemu_blockalign(bs, iov.iov_len)".
Also see events: [leaked_s
On 05/27/2014 09:40 AM, arei.gong...@huawei.com wrote:
From: Gonglei
Spotted by Coverity:
(7) Event closed_arg: "write_dump_pages(DumpState *)" closes "s->fd". [details]
Also see events: [pass_closed_arg]
1490ret = write_dump_pages(s);
(8) Event cond_false: Condition "ret< 0", taki
On Tue, May 20, 2014 at 07:19:49PM -0500, Michael Roth wrote:
> Quoting Marcel Apfelbaum (2014-05-20 10:07:59)
> > Checks the output visitor behaviour for NULL values.
> >
> > Signed-off-by: Marcel Apfelbaum
> > ---
> > Notes:
> > - I didn't add Michael's Sob because I tweaked the test a little
From: Gonglei
Signed-off-by: Gonglei
---
qemu-bridge-helper.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/qemu-bridge-helper.c b/qemu-bridge-helper.c
index 6a0974e..dce5abc 100644
--- a/qemu-bridge-helper.c
+++ b/qemu-bridge-helper.c
@@ -436,7 +436,12 @@ int main(i
> -Original Message-
> From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org
> [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On
> Behalf Of Gerd Hoffmann
> Sent: Monday, May 26, 2014 4:58 PM
> To: qemu-devel@nongnu.org
> Cc: hdego...@redhat.com; Gerd Hoffmann
> Subjec
> -Original Message-
> From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org
> [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On
> Behalf Of Gerd Hoffmann
> Sent: Monday, May 26, 2014 5:26 PM
> To: qemu-devel@nongnu.org
> Cc: Gerd Hoffmann; Anthony Liguori
> Subject:
> -Original Message-
> From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org
> [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On
> Behalf Of Gerd Hoffmann
> Sent: Monday, May 26, 2014 5:26 PM
> To: qemu-devel@nongnu.org
> Cc: Gerd Hoffmann
> Subject: [Qemu-devel] [PATC
From: Richard Henderson [rth7...@gmail.com] on behalf of Richard Henderson
[r...@twiddle.net]
Sent: Tuesday, May 27, 2014 3:35 AM
To: Petar Jovanovic; Petar Jovanovic; qemu-devel@nongnu.org
Cc: aurel...@aurel32.net; James Hogan
Subject: Re: [v2 PATCH] targ
> -Original Message-
> From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org
> [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On
> Behalf Of Gerd Hoffmann
> Sent: Monday, May 26, 2014 4:57 PM
> To: qemu-devel@nongnu.org
> Cc: Gerd Hoffmann
> Subject: [Qemu-devel] [PAT
> -Original Message-
> From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org
> [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On
> Behalf Of Gerd Hoffmann
> Sent: Monday, May 26, 2014 4:57 PM
> To: qemu-devel@nongnu.org
> Cc: Gerd Hoffmann
> Subject: [Qemu-devel] [PATC
> -Original Message-
> From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org
> [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On
> Behalf Of Gerd Hoffmann
> Sent: Monday, May 26, 2014 4:57 PM
> To: qemu-devel@nongnu.org
> Cc: Gerd Hoffmann
> Subject: [Qemu-devel] [PATC
On 05/26/2014 07:32 PM, Petar Jovanovic wrote:
>
>
> From: Richard Henderson [rth7...@gmail.com] on behalf of Richard Henderson
> [r...@twiddle.net]
> Sent: Tuesday, May 27, 2014 3:35 AM
> To: Petar Jovanovic; Petar Jovanovic; qemu-devel@nongnu.org
> Cc: a
> -Original Message-
> From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org
> [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On
> Behalf Of Gerd Hoffmann
> Sent: Monday, May 26, 2014 4:57 PM
> To: qemu-devel@nongnu.org
> Cc: Gerd Hoffmann
> Subject: [Qemu-devel] [PATC
Use the qemu/bswap.h interface for user-only memory accesses.
Otherwise the conversion is straight-forward, and takes care
of the last backend.
Signed-off-by: Richard Henderson
---
tcg/tci/tcg-target.c | 76 +---
tcg/tci/tcg-target.h | 2 +-
tci.c| 322
On Fri, May 16, 2014 at 11:53 AM, Peter Crosthwaite
wrote:
> Expose the already existing .parent and .addr fields as QOM properties.
> Setting the address will cause the memory subregion adding to happen if
> it has not already. If the memory region is already contained, then
> change it's address
Hi,
Also CCing Gerd.
On (Fri) 23 May 2014 [13:55:40], Stefan Hajnoczi wrote:
> On Thu, May 15, 2014 at 11:23:54AM -0600, Chris Friesen wrote:
> > I've run into a situation that seems like a bug. I'm using qemu 1.4.2 (with
> > additional patches) from within openstack.
> >
> > I'm using virtio-s
On 05/23/2014 12:25 AM, Alexey Kardashevskiy wrote:
> On 05/22/2014 08:57 PM, Alexander Graf wrote:
>>
>> On 22.05.14 12:53, Alexey Kardashevskiy wrote:
>>> On 05/22/2014 05:16 PM, Alexander Graf wrote:>
> Am 22.05.2014 um 08:53 schrieb Alexey Kardashevskiy :
>
>> On 05/21/2014 10:42 PM
At the moment sPAPRPHBState contains a @tcet pointer to the only
TCE table. However sPAPR spec allows having more than one DMA window.
Since the TCE object is already a child of SPAPR PHB object, there is
no need to keep an additional pointer to it in sPAPRPHBState so remove it.
This changes the
The spapr-pci PHB initializes IOMMU for emulated devices only.
The upcoming VFIO support will do it different. However both emulated
and VFIO PHB types share most of the initialization code.
For the type specific things a new finish_realize() callback is
introduced.
This introduces sPAPRPHBClass d
Currently only single TCE entry per request is supported (H_PUT_TCE).
However PAPR+ specification allows multiple entry requests such as
H_PUT_TCE_INDIRECT and H_STUFF_TCE. Having less transitions to the host
kernel via ioctls, support of these calls can accelerate IOMMU operations.
This implement
This removes window_size as it is basically a copy of nb_table
shifted by SPAPR_TCE_PAGE_SHIFT. As new dynamic DMA windows are
going to support windows as big as the entire RAM and this number
will be bigger that 32 capacity, we will have to do something
about @window_size anyway and removal seems
This adds @bus_offset into sPAPRTCETable to tell where TCE table starts
from. It is set to 0 for emulated devices. Dynamic DMA windows will use
other offset.
Signed-off-by: Alexey Kardashevskiy
---
hw/ppc/spapr_iommu.c | 13 +
hw/ppc/spapr_pci.c | 5 +++--
hw/ppc/spapr_vio.c
At the moment the "ibm,hypertas-functions" list is fixed. However some
calls should be listed there if they are supported by QEMU or the host
kernel.
This enables hyperrtas_prop to grow on stack by adding
a SPAPR_HYPERRTAS_ADD macro. "qemu,hypertas-functions" is converted as well.
The first user
At the moment only 4K pages are supported by sPAPRTCETable. Since sPAPR
spec allows other page sizes and we are going to implement them, we need
page size to be configrable.
This adds @page_shift into sPAPRTCETable and replaces SPAPR_TCE_PAGE_SHIFT
with it where it is possible.
Signed-off-by: Ale
This patchset prepares QEMU for VFIO support on SPAPR. It also does
preparations for Dynamic DMA window feature which allows to
create DMA windows with 16MB IOMMU pages which will allow to map
the entire guest RAM for DMA at almost no cost.
The only change is in "spapr_iommu: Introduce page_shift
Currently the default DMA window is represented by a single MemoryRegion.
However there can be more than just one window so we need
a "root" memory region to be separated from the actual DMA window(s).
This introduces a "root" IOMMU memory region and adds a subregion for
the default DMA 32bit wind
qdev_init_nofail() was replaced by object_property_set_bool("realized")
all over the QEMU so do we.
Signed-off-by: Alexey Kardashevskiy
---
hw/ppc/spapr_iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c
index 5b7c141..677f985
On Mo, 2014-05-26 at 11:19 -0400, Dave Mielke wrote:
> [quoted lines by Gerd Hoffmann on 2014/05/26 at 15:38 +0200]
>
> >Tried to make the curses ui a bit more clever? You could try caching
> >the modifier state, then send only the changes. That gets the number of
> >events down to 6 max (4 to u
On 05/21/2014 06:16 PM, Alexey Kardashevskiy wrote:
> At the moment QEMU exits if trace point is not defined which makes
> a developer life harder if he has to switch between branches with
> different traces implemented.
>
> This replaces error+exit wit WARNING if the tracepoint does not exist or
Copying Stefan. scripts/get_maintainer.pl would've told you so :)
Alexey Kardashevskiy writes:
> At the moment QEMU exits if trace point is not defined which makes
> a developer life harder if he has to switch between branches with
> different traces implemented.
>
> This replaces error+exit wi
Dave Mielke writes:
> [quoted lines by Dave Mielke on 2014/05/26 at 08:59 -0400]
>
> I'm sorry for quoting myself, but I'm doing it for context since I have a
> question:
>
>>This patch, attached as qemu-kbddelay-1.patch, is a rework of the former
>>curses
>>UI patch so that the delay applies to
201 - 234 of 234 matches
Mail list logo
