> -----Original Message----- > From: qemu-devel-bounces+arei.gonglei=huawei....@nongnu.org > [mailto:qemu-devel-bounces+arei.gonglei=huawei....@nongnu.org] On > Behalf Of Gerd Hoffmann > Sent: Monday, May 26, 2014 5:26 PM > To: qemu-devel@nongnu.org > Cc: Gerd Hoffmann; Anthony Liguori > Subject: [Qemu-devel] [PATCH] console: kill MAX_CONSOLES, alloc consoles > dynamically > > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > --- > ui/console.c | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) >
Reviewed-by: Gonglei <arei.gong...@huawei.com> Good, BTW Maybe we can change the logic of do_key_event() [ui/vnc.c], selecting console dynamically too, instead of hardcode: case 0x02 ... 0x0a: /* '1' to '9' keys */ It will very useful for the keymap's confliction. Best regards, -Gonglei