On Fri, 23 May 2014 01:18:33 +
"Chen, Tiejun" wrote:
> > -Original Message-
> > From: Igor Mammedov [mailto:imamm...@redhat.com]
> > Sent: Thursday, May 22, 2014 10:20 PM
> > To: Michael S. Tsirkin
> > Cc: Chen, Tiejun; peter.mayd...@linaro.org; xen-de...@lists.xensource.com;
> > Dani
Il 22/05/2014 23:05, Marcin Gibuła ha scritto:
Some more info.
VM was doing lot of write IO during this test.
QEMU is waiting for librados to complete I/O. Can you reproduce it with
a different driver?
Paolo
ppoll() is listening for these descriptors (from strace):
ppoll([{fd=25, events=
On 23.05.2014 10:19, Paolo Bonzini wrote:
Il 22/05/2014 23:05, Marcin Gibuła ha scritto:
Some more info.
VM was doing lot of write IO during this test.
QEMU is waiting for librados to complete I/O. Can you reproduce it with
a different driver?
I'll try.
However RBD is used only as read-on
Il 23/05/2014 05:02, Fam Zheng ha scritto:
Don't include individual objects, just link to archives.
Signed-off-by: Fam Zheng
---
libcacard/Makefile | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/libcacard/Makefile b/libcacard/Makefile
index 881b222..abb6eea 100644
Il 23/05/2014 05:44, Jules Wang ha scritto:
Calling dma_bdrv_unmap() twice is not necessary and may cause
potential problems if some code changes.
Signed-off-by: Jules Wang
---
dma-helpers.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/dma-helpers.c b/dma-helpers.c
23.05.2014 12:22, Paolo Bonzini wrote:
> Il 23/05/2014 05:02, Fam Zheng ha scritto:
[]
>> -vscclient$(EXESUF): libcacard/vscclient.o libcacard.la
>> +vscclient$(EXESUF): libcacard/vscclient.o libcacard.la libqemuutil.a
>> libqemustub.a
>> $(call LINK,$^)
>>
>> ###
On 05/11/2014 07:13 PM, Alvise Rigo wrote:
> The flag is mandatory for the ARM SMMU so we always add it if the MMIO
> handles it.
Hi Alvise,
Refering to the root problem explanation found in
https://lkml.org/lkml/2014/2/8/176, I understand the problem is specific
to devices that fetch instruction
On Thu, May 22, 2014 at 09:27:11PM -0400, Gabriel L. Somlo wrote:
> Michael,
>
> On Mon, May 19, 2014 at 10:44:48PM +0300, Michael S. Tsirkin wrote:
> > One question: we don't seem to have unit-test for this
> > interface in qemu, do we?
> > I would like to see at least a basic test along the line
On 23.05.2014 10:19, Paolo Bonzini wrote:
Il 22/05/2014 23:05, Marcin Gibuła ha scritto:
Some more info.
VM was doing lot of write IO during this test.
QEMU is waiting for librados to complete I/O. Can you reproduce it with
a different driver?
Hi,
I've reproduced it without RBD. Backtrace
22.05.2014 18:57, Markus Armbruster wrote:
> diff --git a/libcacard/vcard_emul_nss.c b/libcacard/vcard_emul_nss.c
> index 692534c..f98541f 100644
> --- a/libcacard/vcard_emul_nss.c
> +++ b/libcacard/vcard_emul_nss.c
> @@ -1178,11 +1178,7 @@ vcard_emul_options(const char *args)
>
> i
Il 23/05/2014 10:26, Michael Tokarev ha scritto:
23.05.2014 12:22, Paolo Bonzini wrote:
Il 23/05/2014 05:02, Fam Zheng ha scritto:
[]
-vscclient$(EXESUF): libcacard/vscclient.o libcacard.la
+vscclient$(EXESUF): libcacard/vscclient.o libcacard.la libqemuutil.a
libqemustub.a
$(call LINK,$^
23.05.2014 13:25, Paolo Bonzini wrote:
> Il 23/05/2014 10:26, Michael Tokarev ha scritto:
>> 23.05.2014 12:22, Paolo Bonzini wrote:
>>> Il 23/05/2014 05:02, Fam Zheng ha scritto:
>> []
-vscclient$(EXESUF): libcacard/vscclient.o libcacard.la
+vscclient$(EXESUF): libcacard/vscclient.o libca
On Thu, May 15, 2014 at 03:53:07PM +0200, Pavel Pisa wrote:
> The decisions for further development
>
> Should be minimal working solution included in the QEMU
> mainline in short term?
> (months .. or rather wait for agreement on final
> infrastructure, may be years because of our other load
> an
Michael Tokarev writes:
> 22.05.2014 18:57, Markus Armbruster wrote:
>
>> diff --git a/libcacard/vcard_emul_nss.c b/libcacard/vcard_emul_nss.c
>> index 692534c..f98541f 100644
>> --- a/libcacard/vcard_emul_nss.c
>> +++ b/libcacard/vcard_emul_nss.c
>> @@ -1178,11 +1178,7 @@ vcard_emul_options(cons
23.05.2014 07:02, Fam Zheng wrote:
> We get:
>
> $ qemu-img
> Failed to open module: /home/fam/build/master/block-iscsi.so: undefined
> symbol: bitmap_set
> qemu-img: Not enough arguments
> Try 'qemu-img --help' for more information
>
> Because since commit b03c38 (block/iscsi: s
> -Original Message-
> From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com]
> Sent: 22 May 2014 14:57
> To: Gerd Hoffmann
> Cc: Paolo Bonzini; Stefano Stabellini; Paul Durrant; qemu-devel@nongnu.org;
> Anthony Liguori; m...@redhat.com
> Subject: Re: [PATCH] xen: make xen-platf
On Fri, 23 May 2014, Paul Durrant wrote:
> > -Original Message-
> > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com]
> > Sent: 22 May 2014 14:57
> > To: Gerd Hoffmann
> > Cc: Paolo Bonzini; Stefano Stabellini; Paul Durrant; qemu-devel@nongnu.org;
> > Anthony Liguori; m...@
> -Original Message-
> From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com]
> Sent: 23 May 2014 11:11
> To: Paul Durrant
> Cc: Stefano Stabellini; Gerd Hoffmann; Paolo Bonzini; qemu-
> de...@nongnu.org; Anthony Liguori; m...@redhat.com
> Subject: RE: [PATCH] xen: make xen-plat
On 22 May 2014 14:53, Luiz Capitulino wrote:
> The following changes since commit c5fa6c86d0765f837515d1c10654c621724a77e0:
>
> Merge remote-tracking branch 'remotes/qmp-unstable/queue/qmp' into staging
> (2014-05-19 14:10:01 +0100)
>
> are available in the git repository at:
>
>
> git://repo
On 17 May 2014 09:34, Stefan Weil wrote:
> Commit 5a007547df76446ab891df93ebc55749716609bf tried to fix a
> performance degradation caused by bad handling of small timeouts
> in the original implementation of g_poll.
>
> Since that commit, hard disk I/O no longer works.
>
> Instead of rewriting th
On Fri, May 23, 2014 at 09:38:15AM +0200, Igor Mammedov wrote:
> On Fri, 23 May 2014 01:18:33 +
> "Chen, Tiejun" wrote:
> > With your patch and the following configurations,
> >
> > gfx_passthru=1
> > pci=["00:02.0@2", "00:1a.0"]
> > xen_platform_pci=0
> > device_model_args_hvm = ['-device',
On 22 May 2014 12:17, Pranavkumar Sawargaonkar wrote:
> We will be using linux/psci.h for KVM ARM/ARM64 hence add it to
> linux header sync-up script.
>
> Signed-off-by: Pranavkumar Sawargaonkar
> Signed-off-by: Anup Patel
> ---
> scripts/update-linux-headers.sh |3 ++-
> 1 file changed, 2
On 22 May 2014 12:18, Pranavkumar Sawargaonkar wrote:
> Syncup KVM related linux headers from linux-next tree using
> scripts/update-linux-headers.sh.
We can't apply syncs against linux-next; have to wait for
these to at least get into kvm-next. Christoffer said he'd
be sending out the pull reque
On 22 May 2014 12:18, Pranavkumar Sawargaonkar wrote:
> Introduce a common kvm_arm_vcpu_init() for doing KVM_ARM_VCPU_INIT
> ioctl in KVM ARM and KVM ARM64. This also helps us factor-out few
> common code lines from kvm_arch_init_vcpu() for KVM ARM/ARM64.
>
> Signed-off-by: Pranavkumar Sawargaonka
On 22 May 2014 12:18, Pranavkumar Sawargaonkar wrote:
> Latest linux kernel supports in-kernel emulation of PSCI v0.2 but
> to enable it we need to select KVM_ARM_VCPU_PSCI_0_2 feature using
> KVM_ARM_VCPU_INIT ioctl.
>
> Also, we can use KVM_ARM_VCPU_PSCI_0_2 feature for VCPU only when
> linux ke
On 22 May 2014 12:18, Pranavkumar Sawargaonkar wrote:
> We require to know the PSCI version available to given CPU at
> potentially many places. Currently, we need to know PSCI version
> when generating DTB for virt machine.
>
> This patch introduce per-CPU 32bit field representing the PSCI
> vers
On 05/23/2014 06:50 AM, Marcelo Tosatti wrote:
> On Thu, May 22, 2014 at 01:33:14PM -0600, Eric Blake wrote:
>> [Adding qemu]
>>
>> On 05/22/2014 05:07 AM, Laine Stump wrote:
>>> commit e31b5cf393857 attempted to fix libvirt's
>>> VIR_DOMAIN_EVENT_ID_RTC_CHANGE, which is documentated to always
>> s
On 05/23/2014 12:17 PM, Laine Stump wrote:
> *However*, this discussion forced me to investigate some of the basic
> assumptions that I'd been making when coming in to fix this bug. In
> particular, my assumption was that the value of "adjustment" that was
> set in the status would be preserved acr
Hi, all
I just read this e-mail today. didn't check the e-mail for a long time, because
a little busy on the graduation stuffs. I still want to do something on this
project. So, i would like to working on anything i can help.
Thanks,
Jin Yang
jinyang@gmail.com
From: Pavel Pisa
Date: 201
On 15 May 2014 02:09, Rob Herring wrote:
> From: Rob Herring
>
> Signed-off-by: Rob Herring
Three different email addresses in from, signoff and the
actual maintainers entry :-)
Applied to target-arm.next, thanks.
-- PMM
On 9 May 2014 16:56, Peter Maydell wrote:
> This patch series provides infrastructure and documentation
> for marking QOM struct fields as private to the class implementation.
>
> Patch 1 is the implementation (which is a trivial five lines!) and
> documentation of the code pattern that it's inten
Am 22.05.2014 um 11:42 hat Stefan Hajnoczi geschrieben:
> Normally one would expect that qcow2 image file lengths are multiples of
> the cluster size. This is not true in all cases and the spec should
> document this so implementers remember to accept such files.
>
> $ qemu-img create -f qcow2 fo
On 23.05.14 04:26, Alexey Kardashevskiy wrote:
This enables a ibm,client-architecture-support RTAS call.
This allows older distros (such as SLES11 or RHEL6) to work on modern
POWERPC hardware (such as POWER8) in "architected" mode.
Changelog for v3 is in "spapr: Implement processor compatibili
Am 23.05.2014 13:13, schrieb Peter Maydell:
> On 9 May 2014 16:56, Peter Maydell wrote:
>> This patch series provides infrastructure and documentation
>> for marking QOM struct fields as private to the class implementation.
>>
>> Patch 1 is the implementation (which is a trivial five lines!) and
>
Makes Coverity happy with libcacard/ (for now).
v2:
- Fix g_new() vs. g_renew() mistake in PATCH 5 [Michael Tokarev]
- Trivially rebased
Markus Armbruster (7):
libcacard/vscclient: Bury some dead code
libcacard: Plug memory leaks around vreader_get_reader_list()
libcacard/vreader: Drop brok
Bailing out when PK11_FindGenericObjects() returns null ensures the
loop that follows it executes at least once. The "loop did not
execute" test right after it is useless. Drop it.
Spotted by Coverity.
Signed-off-by: Markus Armbruster
Reviewed-by: Alon Levy
---
libcacard/vcard_emul_nss.c | 5
Signed-off-by: Markus Armbruster
Reviewed-by: Alon Levy
---
libcacard/cac.c| 13 ++---
libcacard/vcard_emul_nss.c | 7 ++-
2 files changed, 4 insertions(+), 16 deletions(-)
diff --git a/libcacard/cac.c b/libcacard/cac.c
index 74ef3e3..05ce8a2 100644
--- a/libcacard/cac.
Spotted by Coverity.
Signed-off-by: Markus Armbruster
Reviewed-by: Alon Levy
---
libcacard/vcard_emul_nss.c | 4
libcacard/vscclient.c | 1 +
2 files changed, 5 insertions(+)
diff --git a/libcacard/vcard_emul_nss.c b/libcacard/vcard_emul_nss.c
index e2b196d..692534c 100644
--- a/libc
It's not locally obvious, and Coverity can't see it either.
Signed-off-by: Markus Armbruster
Reviewed-by: Alon Levy
---
libcacard/vcard_emul_nss.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libcacard/vcard_emul_nss.c b/libcacard/vcard_emul_nss.c
index 2048917..4f55e44 100644
--- a/libc
Bonus: hushes up Coverity.
Signed-off-by: Markus Armbruster
Reviewed-by: Alon Levy
---
libcacard/vreader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libcacard/vreader.c b/libcacard/vreader.c
index c966bb3..3a8f81a 100644
--- a/libcacard/vreader.c
+++ b/libcacard/vreade
We suppress some code when we got unexpected status and assertion
checking is off:
assert(card_status == VCARD_DONE);
if (card_status == VCARD_DONE) {
int size = MIN(*receive_buf_len, response->b_total_len);
memcpy(receive_buf, response->b_data, size);
*receive
On 23.05.14 06:59, Alexey Kardashevskiy wrote:
From: David Gibson
The only model so far supported for VFIO passthrough devices is the model
usually used on x86, where all of the guest's RAM is mapped into the
(host) IOMMU and there is no IOMMU visible in the guest.
This patch begins to relax
Spotted by Coverity.
Signed-off-by: Markus Armbruster
Reviewed-by: Alon Levy
---
libcacard/vscclient.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c
index 3477ab3..29f4958 100644
--- a/libcacard/vscclient.c
+++ b/libcacar
Il 23/05/2014 11:36, Michael Tokarev ha scritto:
Here's the last incarnation:
http://comments.gmane.org/gmane.comp.emulators.qemu/271372
The prob was re-defining GCond to GCond* in the _thin_ compat
layer I wanted to add for _old_ glib (so that all the code uses
new glib api, because that's wh
Il 23/05/2014 11:59, Michael Tokarev ha scritto:
23.05.2014 07:02, Fam Zheng wrote:
We get:
$ qemu-img
Failed to open module: /home/fam/build/master/block-iscsi.so: undefined
symbol: bitmap_set
qemu-img: Not enough arguments
Try 'qemu-img --help' for more information
Because s
Il 23/05/2014 05:02, Fam Zheng ha scritto:
We get:
$ qemu-img
Failed to open module: /home/fam/build/master/block-iscsi.so: undefined
symbol: bitmap_set
qemu-img: Not enough arguments
Try 'qemu-img --help' for more information
Because since commit b03c38 (block/iscsi: speed up
On Fri, 23 May 2014, Paul Durrant wrote:
> > -Original Message-
> > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com]
> > Sent: 23 May 2014 11:11
> > To: Paul Durrant
> > Cc: Stefano Stabellini; Gerd Hoffmann; Paolo Bonzini; qemu-
> > de...@nongnu.org; Anthony Liguori; m...
On Fri, 23 May 2014, Anthony PERARD wrote:
> On Fri, May 23, 2014 at 09:38:15AM +0200, Igor Mammedov wrote:
> > On Fri, 23 May 2014 01:18:33 +
> > "Chen, Tiejun" wrote:
> > > With your patch and the following configurations,
> > >
> > > gfx_passthru=1
> > > pci=["00:02.0@2", "00:1a.0"]
> > >
From: Michael Tokarev
Use glib-provided thread primitives in vscclient instead of
qemu ones, and do not use qemu sockets in there (open-code
call to WSAStartup() for windows to initialize things).
This way, vscclient becomes more stand-alone, independent on
qemu internals.
Signed-off-by: Michae
> -Original Message-
> From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com]
> Sent: 23 May 2014 12:37
> To: Paul Durrant
> Cc: Stefano Stabellini; Gerd Hoffmann; Paolo Bonzini; qemu-
> de...@nongnu.org; Anthony Liguori; m...@redhat.com; Anthony Perard
> Subject: RE: [PATCH] xe
On Thu, May 15, 2014 at 03:02:48PM +0800, Fam Zheng wrote:
> @@ -397,6 +397,7 @@ static int vmdk_add_extent(BlockDriverState *bs,
> {
> VmdkExtent *extent;
> BDRVVmdkState *s = bs->opaque;
> +int64_t ret;
>
> if (cluster_sectors > 0x20) {
> /* 0x20 * 512Bytes
On 23 May 2014 12:23, Andreas Färber wrote:
> Am 23.05.2014 13:13, schrieb Peter Maydell:
>> Ping?
>
> I believe I remarked that in the example
> typedef struct Foo {
> would be more in line with our Coding Style and majority of users.
>
> Other than that, I have no objections and assumed you'll t
Hi,
> Is there a way to specify acpi-pci-hotplug-with-bridge-support=off via
> QMP or command line?
-global PIIX4_PM.acpi-pci-hotplug-with-bridge-support=off
cheers,
Gerd
On Thu, May 15, 2014 at 11:23:54AM -0600, Chris Friesen wrote:
> I've run into a situation that seems like a bug. I'm using qemu 1.4.2 (with
> additional patches) from within openstack.
>
> I'm using virtio-serial-pci to provide a channel between the guest and host.
>
> On occasion when doing su
if user starts QEMU with "-machine pc,accel=xen", then
compat property in xenfv won't work and it would
cause error:
"Unsupported bus. Bus doesn't have property 'acpi-pcihp-bsel' set"
when PCI device is added with -device on QEMU CLI.
In case of Xen instead of using compat property,
just use the f
On 05/23/2014 09:28 PM, Alexander Graf wrote:
>
> On 23.05.14 06:59, Alexey Kardashevskiy wrote:
>> From: David Gibson
>>
>> The only model so far supported for VFIO passthrough devices is the model
>> usually used on x86, where all of the guest's RAM is mapped into the
>> (host) IOMMU and there
From: Michael Tokarev
libtool has an argument for .syms file, which is -export-symbols.
There's no argument `-export-syms', and it looks like at least on
linux, -export-syms is just ignored. Use the correct argument,
-export-symbols, to actually get the right export list.
Signed-off-by: Michael
On Tue, May 20, 2014 at 12:03:17AM +0100, Hani Benhabiles wrote:
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 919af6e..6aaec1b 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1209,9 +1209,10 @@ ETEXI
> {
> .name = "host_net_add",
> .args_type =
On 23.05.14 14:03, Alexey Kardashevskiy wrote:
On 05/23/2014 09:28 PM, Alexander Graf wrote:
On 23.05.14 06:59, Alexey Kardashevskiy wrote:
From: David Gibson
The only model so far supported for VFIO passthrough devices is the model
usually used on x86, where all of the guest's RAM is mapped
From: Michael Tokarev
Replace QemuMutex with GMutex and QemuCond with GCond
(with corresponding function changes), to make libcacard
independent of qemu internal functions.
After this step, none of libcacard internals use any
qemu-provided symbols. Maybe it's a good idea to
stop including qemu-
On Fri, 23 May 2014 11:52:19 +0100
Anthony PERARD wrote:
> On Fri, May 23, 2014 at 09:38:15AM +0200, Igor Mammedov wrote:
> > On Fri, 23 May 2014 01:18:33 +
> > "Chen, Tiejun" wrote:
> > > With your patch and the following configurations,
> > >
> > > gfx_passthru=1
> > > pci=["00:02.0@2", "
From: Michael Tokarev
Thread API changed in glib-2.31 significantly. Before that version,
conditionals and mutexes were only allocated dynamically, using
_new()/_free() interface. in 2.31 and up, they're allocated statically
as regular variables, and old interface is deprecated.
(Note: glib do
This series picks up Michael Tokarev's patches, avoiding the
nasty type redefinition for GMutex/GCond and also sticking to
the same API as glib 2.32+ (apart from the type name).
Keeping the same function names makes usage simpler, and is
type safe.
We could in principle drop QemuThread now that t
On Fri, 23 May 2014 11:52:19 +0100
Anthony PERARD wrote:
> On Fri, May 23, 2014 at 09:38:15AM +0200, Igor Mammedov wrote:
> > On Fri, 23 May 2014 01:18:33 +
> > "Chen, Tiejun" wrote:
> > > With your patch and the following configurations,
> > >
> > > gfx_passthru=1
> > > pci=["00:02.0@2", "
On Tue, May 20, 2014 at 11:24:29AM +0500, Ayaz Akram wrote:
> Can e1000 driver in linux be used without DMA involvement? Actually I am
> trying to use e1000 network driver on octeon linux( to be run on QEMU), and
> I have not emulated any DMA controller, so I was wondering if I can be able
> to run
On Tue, May 20, 2014 at 12:03:19AM +0100, Hani Benhabiles wrote:
> Relies on readline unique completion strings patch to make the added vlan/hub
> completion values unique, instead of using something like a hash table.
>
> Signed-off-by: Hani Benhabiles
> ---
> hmp-commands.hx | 1 +
> hmp.h
On Tue, May 20, 2014 at 11:39:32AM +0200, Marc Marí wrote:
> Hello everyone
>
> I'm Marc Marí (markmb in IRC), and I'm funded to work on virtio and I2C
> libqos device drivers for 12 weeks as a Google Summer of Code Student
> [1]. In particular, I'll create drivers for both PIIX4 (i440fx) and ICH9
On 05/23/2014 12:10 AM, Fam Zheng wrote:
> On Thu, 05/22 23:30, Max Reitz wrote:
>> Add a default common.env in case the one supposed to be emitted by
>> configure cannot be found.
>>
>> Signed-off-by: Max Reitz
>
> Now we can run both from in-tree build and out-of-tree build without this,
> whic
Am 23.05.2014 um 11:25 hat Marcin Gibuła geschrieben:
> On 23.05.2014 10:19, Paolo Bonzini wrote:
> >Il 22/05/2014 23:05, Marcin Gibuła ha scritto:
> >>Some more info.
> >>VM was doing lot of write IO during this test.
> >
> >QEMU is waiting for librados to complete I/O. Can you reproduce it with
On 23.05.14 04:26, Alexey Kardashevskiy wrote:
The host kernel implements a KVM_REG_PPC_ARCH_COMPAT register which
this uses to enable a compatibility mode if any chosen.
This sets the KVM_REG_PPC_ARCH_COMPAT register in KVM. ppc_set_compat()
signals the caller if the mode cannot be enabled by
I see that you have a mix of aio=native and aio=threads. I can't say
much about the aio=native disks (perhaps try to reproduce without
them?), but there are definitely no worker threads for the other disks
that bdrv_drain_all() would have to wait for.
True. But I/O was being done only qcow2 disk
On Fri, 23 May 2014 00:50:38 -0300
Marcelo Tosatti wrote:
> > Then the guest triggers an RTC update, so qemu sends an event, but the
> > event is lost. Then libvirtd starts again, and doesn't realize the
> > event is lost.
>
> Yes, but that case is also true for any other QMP asynchronous event,
On Fri, May 23, 2014 at 11:23:22AM +0800, Fam Zheng wrote:
> We need to handle the coming backing_blocker properly, so don't open
> code the assignment, instead, call bdrv_set_backing_hd to change
> backing_hd.
>
> Signed-off-by: Fam Zheng
> ---
> block.c| 4 ++--
> block/stream.c | 4 ++
On Fri, May 23, 2014 at 11:23:22AM +0800, Fam Zheng wrote:
> We need to handle the coming backing_blocker properly, so don't open
> code the assignment, instead, call bdrv_set_backing_hd to change
> backing_hd.
>
> Signed-off-by: Fam Zheng
> ---
> block.c| 4 ++--
> block/stream.c | 4 ++
On Fri, May 23, 2014 at 11:23:23AM +0800, Fam Zheng wrote:
> This makes use of op_blocker and blocks all the operations except for
> commit target, on each BlockDriverState->backing_hd.
>
> The asserts for op_blocker in bdrv_swap are removed because with this
> change, the target of block commit h
On Tue, May 20, 2014 at 11:21:05PM -, Max Reitz wrote:
> I can only speak for qcow2 and qcow, but for those places, I don't think
> it is worth fixing. First of all, both are image formats, so the
> bottleneck is generally the disk on which the images are stored and not
> main memory, so an ove
On 23 May 2014 01:41, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Hi,
>
> I've been doing some work on modeling parts of EL2 and 3 + some of
> the system-wide virtualization features for ARMv8. A lot is missing
> but I've got a series with enough to for example run KVM A64 guests
> o
One issue is that -M pc didn't always work with Xen. Now it does and we
are already relying on it in libxl since
2bc047635b51abd41c917aa2b813211ee0de2c38. It is safe because all QEMU
releases from 1.6 onward work well with Xen and -M pc. Older QEMU
releases are considered ancient and unmaintained.
bdrv_requests_pending(), called by bdrv_requests_pending_all(), is the
function that determines for each of the disks in your VM if it still
has requests in flight that need to be completed. This function must
have returned true even though there is nothing to wait for.
Can you check which of its
On 19 May 2014 21:56, Fabian Aggeler wrote:
> In ARMv7 the CPACR register allows to control access rights to
> coprocessor 0-13 interfaces. Bits corresponding to unimplemented
> coprocessors should be RAZ/WI. Bits ASEDIS, D32DIS, TRCDIS are
> UNK/SBZP if VFP is not implemented and RAO/WI in some c
The condition that is true is:
if (!QLIST_EMPTY(&bs->tracked_requests))
and it's returned for intermediate qcow2 which is being commited.
Btw - it's also disk that is being pounded with writes during commit.
--
mg
Just one question:
+# fix-paths
+# Usage: $(call fix-paths, obj_path, src_path, vars)
+# Add prefix @obj_path to all objects in @vars, and add prefix @src_path to all
+# directories in @vars.
+define fix-paths
+$(foreach v,$3,
+$(foreach o,$($v),
+$(if $($o-libs),
+
This drops BlockDriverState.in_use with op_blockers:
- Call bdrv_op_block_all in place of bdrv_set_in_use(bs, 1).
- Call bdrv_op_unblock_all in place of bdrv_set_in_use(bs, 0).
- Check bdrv_op_is_blocked() in place of bdrv_in_use(bs).
The specific types are used, e.g. in place of star
It makes no sense to check for "any" blocker on bs, we are here only
because of the mechanical conversion from in_use to op_blockers. Remove
it now, and let the callers check specific operation types. Backup and
mirror already have it, add checker to stream and commit.
Signed-off-by: Fam Zheng
Re
This is split from series "[Qemu-devel] [PATCH v20 00/15] Drop in_use from
BlockDriverState and enable point-in-time snapshot exporting over NBD", with a
new patch 06 to avoid backing_blocker assertion violation.
v2: Address Stefan's comments on last two patches from v1, and add a patch 8 to
d
This adds the enum of all the operations that can be taken on a block
device.
Signed-off-by: Fam Zheng
Reviewed-by: Benoit Canet
Reviewed-by: Jeff Cody
Reviewed-by: Stefan Hajnoczi
---
include/block/block.h | 19 +++
1 file changed, 19 insertions(+)
diff --git a/include/block
We need to handle the coming backing_blocker properly, so don't open
code the assignment, instead, call bdrv_set_backing_hd to change
backing_hd.
Signed-off-by: Fam Zheng
---
block.c| 6 ++
block/stream.c | 4 ++--
block/vvfat.c | 2 +-
3 files changed, 5 insertions(+), 7 deletions(
BlockDriverState.op_blockers is an array of lists with BLOCK_OP_TYPE_MAX
elements. Each list is a list of blockers of an operation type
(BlockOpType), that marks this BDS as currently blocked for a certain
type of operation with reason errors stored in the list. The rule of
usage is:
* BDS user w
The above bdrv_set_backing_hd already does this.
Signed-off-by: Fam Zheng
---
block.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block.c b/block.c
index aa9b5ab..a517d72 100644
--- a/block.c
+++ b/block.c
@@ -1182,9 +1182,6 @@ int bdrv_open_backing_file(BlockDriverState *bs, QDict
*o
This makes use of op_blocker and blocks all the operations except for
commit target, on each BlockDriverState->backing_hd.
The asserts for op_blocker in bdrv_swap are removed because with this
change, the target of block commit has at least the backing blocker of
its child, so the assertion is not
On Fri, 05/23 15:22, Paolo Bonzini wrote:
> Just one question:
>
> >+# fix-paths
> >+# Usage: $(call fix-paths, obj_path, src_path, vars)
> >+# Add prefix @obj_path to all objects in @vars, and add prefix @src_path to
> >all
> >+# directories in @vars.
> >+define fix-paths
> >+$(foreach v,$3,
Eric Blake writes:
> On 05/23/2014 12:10 AM, Fam Zheng wrote:
>> On Thu, 05/22 23:30, Max Reitz wrote:
>>> Add a default common.env in case the one supposed to be emitted by
>>> configure cannot be found.
>>>
>>> Signed-off-by: Max Reitz
>>
>> Now we can run both from in-tree build and out-of-t
On 22.05.14 13:19, Alexey Kardashevskiy wrote:
At the moment only 4K pages are supported by sPAPRTCETable. Since sPAPR
spec allows other page sizes and we are going to implement them, we need
page size to be configrable.
This adds @page_shift into sPAPRTCETable and replaces SPAPR_TCE_PAGE_SHIFT
Luiz Capitulino writes:
> On Fri, 23 May 2014 00:50:38 -0300
> Marcelo Tosatti wrote:
>
>> > Then the guest triggers an RTC update, so qemu sends an event, but the
>> > event is lost. Then libvirtd starts again, and doesn't realize the
>> > event is lost.
>>
>> Yes, but that case is also true f
The 'refcount_bits' term used in the description of refcount block entry is
not defined in the specification. The definition is added in the
'refcount_order' section where refcount_bits was used as 'width in bits'.
Signed-off-by: Maria Kustova
---
docs/specs/qcow2.txt | 5 +++--
1 file changed,
On 05/23/2014 07:41 AM, Maria Kustova wrote:
> The 'refcount_bits' term used in the description of refcount block entry is
> not defined in the specification. The definition is added in the
> 'refcount_order' section where refcount_bits was used as 'width in bits'.
>
> Signed-off-by: Maria Kustova
On 12.05.14 10:46, Alexey Kardashevskiy wrote:
SPAPR IOMMU is a bus-less device and therefore its only ID in
migration stream is an instance id which is not reliable ID
as it depends on the command line parameters order. Since
libvirt may change the order, we need something better than that.
Th
On Fri, May 23, 2014 at 03:35:19PM +0200, Markus Armbruster wrote:
> Luiz Capitulino writes:
>
> > On Fri, 23 May 2014 00:50:38 -0300
> > Marcelo Tosatti wrote:
> >
> >> > Then the guest triggers an RTC update, so qemu sends an event, but the
> >> > event is lost. Then libvirtd starts again, and
On Fri, 23 May 2014 10:48:18 -0300
Marcelo Tosatti wrote:
> On Fri, May 23, 2014 at 03:35:19PM +0200, Markus Armbruster wrote:
> > Luiz Capitulino writes:
> >
> > > On Fri, 23 May 2014 00:50:38 -0300
> > > Marcelo Tosatti wrote:
> > >
> > >> > Then the guest triggers an RTC update, so qemu sen
On Fri, May 23, 2014 at 10:48:18AM -0300, Marcelo Tosatti wrote:
> On Fri, May 23, 2014 at 03:35:19PM +0200, Markus Armbruster wrote:
> > Luiz Capitulino writes:
> >
> > > On Fri, 23 May 2014 00:50:38 -0300
> > > Marcelo Tosatti wrote:
> > >
> > >> > Then the guest triggers an RTC update, so qem
1 - 100 of 242 matches
Mail list logo
