Re: [Qemu-devel] [PATCH 6/6] docs: add multiseat.txt

2014-05-21 Thread Gerd Hoffmann
Hi, > > If there is anything to configure then it most likely will be ui > > specific, i.e. we could possibly allow something like this ... > > > >-display gtk,display=video.1 \ > >-vnc :0,display=video.2 > > > > ... to have one head show up on gtk and the other on vnc (needs '-vga > > n

Re: [Qemu-devel] [PATCH v2 8/8] spapr_pci: Use XICS interrupt allocator and do not cache interrupts in PHB

2014-05-21 Thread Alexander Graf
On 21.05.14 11:33, Alexey Kardashevskiy wrote: On 05/21/2014 07:13 PM, Alexander Graf wrote: On 21.05.14 11:11, Michael S. Tsirkin wrote: On Wed, May 21, 2014 at 11:06:09AM +0200, Alexander Graf wrote: On 21.05.14 10:52, Alexey Kardashevskiy wrote: On 05/21/2014 06:40 PM, Alexander Graf wrot

Re: [Qemu-devel] fpu/softfloat.c licensing

2014-05-21 Thread Andreas Färber
Am 21.05.2014 11:47, schrieb Peter Maydell: > On 21 May 2014 10:43, Markus Armbruster wrote: >> Alexander Graf writes: >>> How many % of the overall commits does that make? IIRC you can >>> relicense source code if the "majority of authors" agrees and nobody >>> actively disagrees - or so. But IA

Re: [Qemu-devel] [PATCH v2 05/31] vl.c: extend -m option to support options for memory hotplug

2014-05-21 Thread Igor Mammedov
On Wed, 21 May 2014 13:12:13 +0400 Andrey Korolyov wrote: > On Wed, May 21, 2014 at 12:55 PM, Igor Mammedov wrote: > > On Wed, 21 May 2014 12:27:05 +0400 > > Andrey Korolyov wrote: > > > >> On Wed, May 21, 2014 at 12:10 PM, Michael S. Tsirkin > >> wrote: > >> > On Tue, May 20, 2014 at 05:15:0

Re: [Qemu-devel] [PATCH v2 3/4] console: Abort on property access errors

2014-05-21 Thread Gerd Hoffmann
On Do, 2014-04-24 at 18:15 +0400, Kirill Batuzov wrote: > All defined properties of QemuConsole are mandatory and no access to them > should fail. Nevertheless not checking returned errors is bad because in case > of unexpected failure it will hide the bug and cause a memory leak. > > Abort in cas

[Qemu-devel] [PATCH] console: nicer initial screen

2014-05-21 Thread Gerd Hoffmann
Now that we have a function to create a fancy DisplaySurface with a message for the user, to handle non-existing graphics hardware, we can make it more generic and use it for other things too. This patch adds a text line to the in initial DisplaySurface, notifying the user that the display isn't i

Re: [Qemu-devel] [PATCH v2 8/9] spapr: Implement processor compatibility in ibm, client-architecture-support

2014-05-21 Thread Alexander Graf
On 21.05.14 11:36, Alexey Kardashevskiy wrote: On 05/21/2014 07:21 PM, Alexander Graf wrote: On 21.05.14 10:27, Alexey Kardashevskiy wrote: Modern Linux kernels support last POWERPC CPUs so when a kernel boots, in most cases it can find a matching cpu_spec in the kernel's cpu_specs list. Howev

Re: [Qemu-devel] [call for testers] qemu gtk ui overhaul

2014-05-21 Thread Gerd Hoffmann
Hi, > Did some light testing, seems to work fine here. I'll review individual > patches when they hit the list. Series sent now. cheers, Gerd

[Qemu-devel] [Bug 1321684] [NEW] block_stream command stalls

2014-05-21 Thread mcpacino
Public bug reported: block_stream command stalls near finishing. I tried 1.7.1, 2.0.0 and the master versions. All of them stalled. But the 1.1.2 could finish the job. Here is how to reproduce it: $ sudo $QEMU \ -enable-kvm -cpu qemu64 -m 1024 \ -monitor stdio \ -drive file=./i1,if=none,id=dr

Re: [Qemu-devel] [PATCH 01/18] migration: dump vmstate info as a json file for static analysis

2014-05-21 Thread Dr. David Alan Gilbert
* Amit Shah (amit.s...@redhat.com) wrote: > On (Wed) 21 May 2014 [10:44:07], Dr. David Alan Gilbert wrote: > > * Amit Shah (amit.s...@redhat.com) wrote: > > > This commit adds a new command, '-dump-vmstate', that takes a filename > > > as a parameter. When executed, QEMU will dump the vmstate info

Re: [Qemu-devel] [PATCH v2] kvmclock: Ensure time in migration never goes backward

2014-05-21 Thread Alexander Graf
On 19.05.14 13:31, Paolo Bonzini wrote: Il 18/05/2014 15:20, Marcelo Tosatti ha scritto: Reviewed-by: Marcelo Tosatti Thanks Marcelo, applying to uq/master. Same here, please also CC to stable :). Alex

Re: [Qemu-devel] [PATCH v2 8/8] spapr_pci: Use XICS interrupt allocator and do not cache interrupts in PHB

2014-05-21 Thread Alexey Kardashevskiy
On 05/21/2014 07:38 PM, Michael S. Tsirkin wrote: > On Wed, May 21, 2014 at 07:33:36PM +1000, Alexey Kardashevskiy wrote: >> On 05/21/2014 07:13 PM, Alexander Graf wrote: >>> >>> On 21.05.14 11:11, Michael S. Tsirkin wrote: On Wed, May 21, 2014 at 11:06:09AM +0200, Alexander Graf wrote: >

Re: [Qemu-devel] [PATCH v2 05/31] vl.c: extend -m option to support options for memory hotplug

2014-05-21 Thread Andrey Korolyov
On Wed, May 21, 2014 at 1:52 PM, Igor Mammedov wrote: > On Wed, 21 May 2014 13:12:13 +0400 > Andrey Korolyov wrote: > >> On Wed, May 21, 2014 at 12:55 PM, Igor Mammedov wrote: >> > On Wed, 21 May 2014 12:27:05 +0400 >> > Andrey Korolyov wrote: >> > >> >> On Wed, May 21, 2014 at 12:10 PM, Michae

Re: [Qemu-devel] [PATCH 01/18] migration: dump vmstate info as a json file for static analysis

2014-05-21 Thread Amit Shah
On (Wed) 21 May 2014 [11:03:04], Dr. David Alan Gilbert wrote: > * Amit Shah (amit.s...@redhat.com) wrote: > > The idea is to be able to take a qemu binary and compare with another > > binary; if only fields that are instantiated are used, various > > invocations will have to be tried to find devi

Re: [Qemu-devel] [PATCH] qga: Fix handle fd leak in acquire_privilege()

2014-05-21 Thread Wangrui (K)
> -Original Message- > From: Yan Vugenfirer [mailto:yvuge...@redhat.com] > Sent: Wednesday, May 21, 2014 5:01 PM > To: Michael Roth > Cc: Luiz Capitulino; Wangrui (K); Gonglei (Arei); qemu-devel@nongnu.org; > arm...@redhat.com > Subject: Re: [Qemu-devel] [PATCH] qga: Fix handle fd leak in

Re: [Qemu-devel] [PATCH v2 8/8] spapr_pci: Use XICS interrupt allocator and do not cache interrupts in PHB

2014-05-21 Thread Alexey Kardashevskiy
On 05/21/2014 07:50 PM, Alexander Graf wrote: > > On 21.05.14 11:33, Alexey Kardashevskiy wrote: >> On 05/21/2014 07:13 PM, Alexander Graf wrote: >>> On 21.05.14 11:11, Michael S. Tsirkin wrote: On Wed, May 21, 2014 at 11:06:09AM +0200, Alexander Graf wrote: > On 21.05.14 10:52, Alexey Ka

Re: [Qemu-devel] [PATCH 01/18] migration: dump vmstate info as a json file for static analysis

2014-05-21 Thread Amit Shah
On (Wed) 21 May 2014 [10:44:07], Dr. David Alan Gilbert wrote: > * Amit Shah (amit.s...@redhat.com) wrote: > > This commit adds a new command, '-dump-vmstate', that takes a filename > > as a parameter. When executed, QEMU will dump the vmstate information > > for the machine type it's invoked with

Re: [Qemu-devel] [PATCH] e1000: allow command-line selection of card model

2014-05-21 Thread Michael S. Tsirkin
On Wed, May 21, 2014 at 11:48:48AM +0200, Andreas Färber wrote: > Am 21.05.2014 11:25, schrieb Michael S. Tsirkin: > > On Wed, May 21, 2014 at 11:12:42AM +0200, Andreas Färber wrote: > >> Am 21.05.2014 11:04, schrieb Michael S. Tsirkin: > >>> On Wed, May 21, 2014 at 10:40:54AM +0200, Andreas Färber

Re: [Qemu-devel] [PATCH v2 8/8] spapr_pci: Use XICS interrupt allocator and do not cache interrupts in PHB

2014-05-21 Thread Alexander Graf
On 21.05.14 12:13, Alexey Kardashevskiy wrote: On 05/21/2014 07:50 PM, Alexander Graf wrote: On 21.05.14 11:33, Alexey Kardashevskiy wrote: On 05/21/2014 07:13 PM, Alexander Graf wrote: On 21.05.14 11:11, Michael S. Tsirkin wrote: On Wed, May 21, 2014 at 11:06:09AM +0200, Alexander Graf wrot

[Qemu-devel] [PATCH] jazz_led: Add missing break in switch case

2014-05-21 Thread Saravanakumar
Signed-off-by: Saravanakumar --- hw/display/jazz_led.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/display/jazz_led.c b/hw/display/jazz_led.c index e9bb005..12b1707 100644 --- a/hw/display/jazz_led.c +++ b/hw/display/jazz_led.c @@ -173,6 +173,7 @@ static void jazz

Re: [Qemu-devel] [PATCH] e1000: allow command-line selection of card model

2014-05-21 Thread Andreas Färber
Am 21.05.2014 12:22, schrieb Michael S. Tsirkin: > On Wed, May 21, 2014 at 11:48:48AM +0200, Andreas Färber wrote: >> Am 21.05.2014 11:25, schrieb Michael S. Tsirkin: >>> On Wed, May 21, 2014 at 11:12:42AM +0200, Andreas Färber wrote: Am 21.05.2014 11:04, schrieb Michael S. Tsirkin: > On W

Re: [Qemu-devel] [PATCH 2/9] target-ppc: Refactor init_proc_POWER7

2014-05-21 Thread Alexander Graf
On 21.05.14 08:20, Alexey Kardashevskiy wrote: This moves SPR initialization to helper functions. Signed-off-by: Alexey Kardashevskiy I like the idea, but please refactor all book3s CPUs, not just POWER7. I also think we can cover a lot of the SPR registration by matching on feature fields

[Qemu-devel] [PULL 0/5] purge error_is_set()

2014-05-21 Thread Gerd Hoffmann
Hi, $subject says all. Final chardev pieces (and one socket). please pull, Gerd The following changes since commit c5fa6c86d0765f837515d1c10654c621724a77e0: Merge remote-tracking branch 'remotes/qmp-unstable/queue/qmp' into staging (2014-05-19 14:10:01 +0100) are available in the git r

[Qemu-devel] [PULL 5/5] error: error_is_set() is finally unused; remove

2014-05-21 Thread Gerd Hoffmann
From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Gerd Hoffmann --- include/qapi/error.h | 6 -- util/error.c | 5 - 2 files changed, 11 deletions(-) diff --git a/include/qapi/error.h b/include/qapi/error.h index 7995801..d712089 100644 --- a/include/qapi

[Qemu-devel] [PULL 2/5] char: Use return values instead of error_is_set(errp)

2014-05-21 Thread Gerd Hoffmann
From: Markus Armbruster Using error_is_set(errp) to check whether a function call failed is fragile: it breaks when errp is null. Check perfectly suitable return values instead when possible. As far as I can tell, errp can't be null there, but this is more robust and more obviously correct Sig

[Qemu-devel] [PULL 1/5] qemu-socket: Clean up inet_connect_opts()

2014-05-21 Thread Gerd Hoffmann
From: Markus Armbruster Separate the search for a working addrinfo from the code that does something with it. Makes for a clearer search loop. Use a local Error * to simplify resetting the error in the search loop. Signed-off-by: Markus Armbruster Reviewed-by: Paolo Bonzini Signed-off-by: Ge

[Qemu-devel] [PULL 4/5] char: Explain qmp_chardev_add()'s unusual error handling

2014-05-21 Thread Gerd Hoffmann
From: Markus Armbruster Character backend open hasn't been fully converted to the Error API. Some opens fail without setting an error. qmp_chardev_add() needs to detect when that happens, and set a generic error. Explain that in a comment, and inline error_is_set() for clarity. Signed-off-by:

[Qemu-devel] [PULL 3/5] char: Clean up fragile use of error_is_set()

2014-05-21 Thread Gerd Hoffmann
From: Markus Armbruster Using error_is_set(ERRP) to find out whether a function failed is either wrong, fragile, or unnecessarily opaque. It's wrong when ERRP may be null, because errors go undetected when it is. It's fragile when proving ERRP non-null involves a non-local argument. Else, it's

Re: [Qemu-devel] [PATCH 5/9] target-ppc: Add POWER8 SPRs

2014-05-21 Thread Alexander Graf
On 21.05.14 08:20, Alexey Kardashevskiy wrote: This adds helper which adds TAR/BESCRS/BESCRSU/BESCRR/BESCRRU/ EBBHR/EBBRR/BESCR/TFHAR/TFIAR/TEXASR/TEXASRU SPRs. This adds MMCR2/FSCR/MMCRS SPRs. Signed-off-by: Alexey Kardashevskiy --- target-ppc/cpu.h| 15 ++ target-ppc/tra

Re: [Qemu-devel] [PATCH 6/9] target-ppc: Enable PPR and VRSAVE SPRs migration

2014-05-21 Thread Alexander Graf
On 21.05.14 08:20, Alexey Kardashevskiy wrote: Signed-off-by: Alexey Kardashevskiy Patch description missing. Alex --- target-ppc/translate_init.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_ini

[Qemu-devel] [PATCH] inet_listen_opts: add error checking

2014-05-21 Thread Gerd Hoffmann
Don't use atoi() function which doesn't detect errors, switch to strtol and error out on failures. Also add a range check while being at it. Signed-off-by: Gerd Hoffmann --- util/qemu-sockets.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/util/qemu-socket

[Qemu-devel] [PATCH] vnc: refuse to set a password with VNC_AUTH_NONE

2014-05-21 Thread Gerd Hoffmann
Current code silently changes the authentication settings in case you try to set a password without password authentication turned on. This is bad. Return an error instead. If we want allow changing auth settings at runtime this should be done explicitly using a separate monitor command, not as

Re: [Qemu-devel] question about feature block_stream and driver_mirror in qemu-xen

2014-05-21 Thread Stefano Stabellini
On Tue, 20 May 2014, Xiaoding (B) wrote: > Hi all, > >   > > I tried to test the features about block_stream/drive_mirror in the qemu-xen. > > (Xen version is 4.4.1, qemu version is 1.62) > > And I found the vm crashed after the hmp commands are sent. > >   > > Whether xen has supported the t

Re: [Qemu-devel] [PATCH 3/3] target-i386: get CPL from SS.DPL

2014-05-21 Thread Paolo Bonzini
Il 20/05/2014 23:54, Kevin O'Connor ha scritto: On Fri, May 16, 2014 at 09:59:25PM +0200, Paolo Bonzini wrote: CS.RPL is not equal to the CPL in the few instructions between setting CR0.PE and reloading CS. We get this right in the common case, because writes to CR0 do not modify the CPL, but i

Re: [Qemu-devel] [PATCH] jazz_led: Add missing break in switch case

2014-05-21 Thread Paolo Bonzini
Il 21/05/2014 12:41, Saravanakumar ha scritto: Signed-off-by: Saravanakumar --- hw/display/jazz_led.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/display/jazz_led.c b/hw/display/jazz_led.c index e9bb005..12b1707 100644 --- a/hw/display/jazz_led.c +++ b/hw/display

Re: [Qemu-devel] [PATCH v2 30/31] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole

2014-05-21 Thread Igor Mammedov
On Wed, 21 May 2014 11:05:58 +0300 "Michael S. Tsirkin" wrote: > On Tue, May 20, 2014 at 05:15:33PM +0200, Igor Mammedov wrote: > > Needed for Windows to use hotplugged memory device, otherwise > > it complains that server is not configured for memory hotplug. > > Tests shows that aftewards it us

Re: [Qemu-devel] [PATCH v2] virtio-balloon: return empty data when no stats are available

2014-05-21 Thread Eric Blake
On 05/21/2014 03:03 AM, Ján Tomko wrote: > If the guest hasn't updated the stats yet, instead of returning > an error, return '-1' for the stats and '0' as 'last-update'. > > This lets applications ignore this without parsing the error message. > > Related libvirt patch and discussion: > https://

[Qemu-devel] [PATCH v2 22/31] acpi:piix4: allow plug/unlug callbacks handle not only PCI devices

2014-05-21 Thread Igor Mammedov
... and report error if plugged in device is not supported. Later these callbacks will be used by memory hotplug. Signed-off-by: Igor Mammedov --- hw/acpi/piix4.c | 31 ++- 1 files changed, 22 insertions(+), 9 deletions(-) diff --git a/hw/acpi/piix4.c b/hw/acpi/pii

[Qemu-devel] [PATCH v2 26/31] pc: migrate piix4 & ich9 MemHotplugState

2014-05-21 Thread Igor Mammedov
Adds an optional subsection that allows to migrate current state of acpi_memory_hotplug of ACPI PM device. Signed-off-by: Igor Mammedov --- v2: * use subsection, requested by pbonzini --- hw/acpi/ich9.c | 24 hw/acpi/memory_hotplug.c | 27

Re: [Qemu-devel] [RFC PATCH v2 0/7] qapi: Specify default value for optional argument in schema json

2014-05-21 Thread Eric Blake
On 05/21/2014 02:42 AM, Fam Zheng wrote: > Adding three ugly sigils and making everybody include one when they add > a nested struct feels much better to me than ugly sigils all over the > place. Well, I could use some background here. Why did we introduce nested struct

[Qemu-devel] [PATCH v2 25/31] acpi:ich9: add memory hotplug handling

2014-05-21 Thread Igor Mammedov
Add memory hotplug initialization/handling to ICH9 LPC device and enable it by default for post 2.0 machine types Signed-off-by: Igor Mammedov --- hw/acpi/ich9.c | 38 ++ hw/isa/lpc_ich9.c | 20 include/hw/acpi/ich9.h |

[Qemu-devel] [PATCH v2 23/31] acpi:piix4: add memory hotplug handling

2014-05-21 Thread Igor Mammedov
Add memory hotplug initialization/handling to PIIX4_PM device and enable it by default for post 2.0 machine types Signed-off-by: Igor Mammedov --- hw/acpi/piix4.c | 15 ++- include/hw/acpi/memory_hotplug.h |1 + include/hw/i386/pc.h |5 + 3

[Qemu-devel] [PATCH v2 28/31] pc: propagate memory hotplug event to ACPI device

2014-05-21 Thread Igor Mammedov
Notify PIIX4_PM/ICH9LPC device about hotplug event, so that it would send SCI to guest notifying about newly added memory. Signed-off-by: Igor Mammedov --- v2: * fix memory leak, reported by pbonzini * use link to ACPI device instead of looking it up in QOM tree --- hw/i386/pc.c | 10 +

[Qemu-devel] [PATCH v2 27/31] pc: add acpi-device link to PCMachineState

2014-05-21 Thread Igor Mammedov
the link will used later to access device implementing ACPI functions instead of adhoc lookup in QOM tree. Signed-off-by: Igor Mammedov --- hw/acpi/piix4.c |6 +- hw/i386/pc_piix.c| 12 +++- hw/i386/pc_q35.c | 10 ++ hw/mips/mips_malta.c |2 +- includ

Re: [Qemu-devel] [PATCH] scripts/qapi.py: Avoid syntax not supported by Python 2.4

2014-05-21 Thread Andreas Färber
Am 20.05.2014 20:29, schrieb Luiz Capitulino: > The Python "except Foo as x" syntax was only introduced in > Python 2.6, but we aim to support Python 2.4 and later. > Use the old-style "except Foo, x" syntax instead, thus > fixing configure/compile on systems with older Python. > > Reported-by: Pe

Re: [Qemu-devel] [PATCH 9/9] spapr_hcall: Add address-translation-mode-on-interrupt resource in H_SET_MODE

2014-05-21 Thread Alexander Graf
On 21.05.14 08:20, Alexey Kardashevskiy wrote: This adds handling of the RESOURCE_ADDR_TRANS_MODE resource from the H_SET_MODE, for POWER8 (PowerISA 2.07) only. This defines AIL flags for LPCR special register. This changes @excp_prefix according to the mode, takes effect in TCG. This turns s

Re: [Qemu-devel] [PATCH 01/18] migration: dump vmstate info as a json file for static analysis

2014-05-21 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Amit Shah (amit.s...@redhat.com) wrote: >> This commit adds a new command, '-dump-vmstate', that takes a filename >> as a parameter. When executed, QEMU will dump the vmstate information >> for the machine type it's invoked with to the file, and quit. >> >>

Re: [Qemu-devel] [PATCH 01/18] migration: dump vmstate info as a json file for static analysis

2014-05-21 Thread Eric Blake
On 05/12/2014 10:12 PM, Amit Shah wrote: > Hi, > > On (Mon) 12 May 2014 [06:51:54], Eric Blake wrote: >> On 05/12/2014 05:16 AM, Amit Shah wrote: >>> This commit adds a new command, '-dump-vmstate', that takes a filename >>> as a parameter. When executed, QEMU will dump the vmstate information >>

Re: [Qemu-devel] [PATCH 01/18] migration: dump vmstate info as a json file for static analysis

2014-05-21 Thread Markus Armbruster
Amit Shah writes: > On (Wed) 21 May 2014 [11:03:04], Dr. David Alan Gilbert wrote: >> * Amit Shah (amit.s...@redhat.com) wrote: > >> > The idea is to be able to take a qemu binary and compare with another >> > binary; if only fields that are instantiated are used, various >> > invocations will ha

Re: [Qemu-devel] [PATCH] inet_listen_opts: add error checking

2014-05-21 Thread Markus Armbruster
Gerd Hoffmann writes: > Don't use atoi() function which doesn't detect errors, switch to > strtol and error out on failures. Also add a range check while > being at it. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Markus Armbruster

[Qemu-devel] [PATCH 2/3] input: add name to input_event_key_number

2014-05-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- trace-events | 2 +- ui/input.c | 6 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/trace-events b/trace-events index b6d289d..0870204 100644 --- a/trace-events +++ b/trace-events @@ -1050,7 +1050,7 @@ gd_update(int x, int y, int w, int h)

Re: [Qemu-devel] [PATCH] e1000: allow command-line selection of card model

2014-05-21 Thread Michael S. Tsirkin
On Wed, May 21, 2014 at 12:42:13PM +0200, Andreas Färber wrote: > Am 21.05.2014 12:22, schrieb Michael S. Tsirkin: > > On Wed, May 21, 2014 at 11:48:48AM +0200, Andreas Färber wrote: > >> Am 21.05.2014 11:25, schrieb Michael S. Tsirkin: > >>> On Wed, May 21, 2014 at 11:12:42AM +0200, Andreas Färber

[Qemu-devel] [PATCH 3/3] input: keymap: add meta keys

2014-05-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/input-keymap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/input-keymap.c b/ui/input-keymap.c index 4c4f0d0..5d29935 100644 --- a/ui/input-keymap.c +++ b/ui/input-keymap.c @@ -13,6 +13,8 @@ static const int qcode_to_number[] = { [Q_KEY_CODE_CT

Re: [Qemu-devel] [PATCH 9/9] spapr_hcall: Add address-translation-mode-on-interrupt resource in H_SET_MODE

2014-05-21 Thread Alexey Kardashevskiy
On 05/21/2014 09:44 PM, Alexander Graf wrote: > > On 21.05.14 08:20, Alexey Kardashevskiy wrote: >> This adds handling of the RESOURCE_ADDR_TRANS_MODE resource from >> the H_SET_MODE, for POWER8 (PowerISA 2.07) only. >> >> This defines AIL flags for LPCR special register. >> >> This changes @excp_

Re: [Qemu-devel] [PATCH 9/9] spapr_hcall: Add address-translation-mode-on-interrupt resource in H_SET_MODE

2014-05-21 Thread Alexander Graf
On 21.05.14 14:24, Alexey Kardashevskiy wrote: On 05/21/2014 09:44 PM, Alexander Graf wrote: On 21.05.14 08:20, Alexey Kardashevskiy wrote: This adds handling of the RESOURCE_ADDR_TRANS_MODE resource from the H_SET_MODE, for POWER8 (PowerISA 2.07) only. This defines AIL flags for LPCR special

Re: [Qemu-devel] [RFC] How to deal with the conflict between DE keymap and qemu console ?

2014-05-21 Thread Gerd Hoffmann
On Mi, 2014-05-21 at 07:33 +, Gonglei (Arei) wrote: > Hi, Gerd > > The issues has been reported a few months ago. The previous mail: > https://lists.gnu.org/archive/html/qemu-devel/2014-01/msg01600.html > > Any ideas? Works perfectly fine for me. What vnc client is this? cheers, Gerd

Re: [Qemu-devel] [Qemu-ppc] [PATCH 9/9] spapr_hcall: Add address-translation-mode-on-interrupt resource in H_SET_MODE

2014-05-21 Thread Greg Kurz
On Wed, 21 May 2014 16:20:28 +1000 Alexey Kardashevskiy wrote: > This adds handling of the RESOURCE_ADDR_TRANS_MODE resource from > the H_SET_MODE, for POWER8 (PowerISA 2.07) only. > > This defines AIL flags for LPCR special register. > > This changes @excp_prefix according to the mode, takes e

Re: [Qemu-devel] [PATCH v20 01/15] block: Add BlockOpType enum

2014-05-21 Thread Stefan Hajnoczi
On Tue, May 20, 2014 at 02:04:26PM +0800, Fam Zheng wrote: > This adds the enum of all the operations that can be taken on a block > device. > > Signed-off-by: Fam Zheng > Reviewed-by: Benoit Canet > Reviewed-by: Jeff Cody > --- > include/block/block.h | 19 +++ > 1 file change

Re: [Qemu-devel] [PATCH v20 02/15] block: Introduce op_blockers to BlockDriverState

2014-05-21 Thread Stefan Hajnoczi
On Tue, May 20, 2014 at 02:04:27PM +0800, Fam Zheng wrote: > BlockDriverState.op_blockers is an array of lists with BLOCK_OP_TYPE_MAX > elements. Each list is a list of blockers of an operation type > (BlockOpType), that marks this BDS as currently blocked for a certain > type of operation with rea

Re: [Qemu-devel] [PATCH 2/9] target-ppc: Refactor init_proc_POWER7

2014-05-21 Thread Alexey Kardashevskiy
On 05/21/2014 08:44 PM, Alexander Graf wrote: > > On 21.05.14 08:20, Alexey Kardashevskiy wrote: >> This moves SPR initialization to helper functions. >> >> Signed-off-by: Alexey Kardashevskiy > > I like the idea, but please refactor all book3s CPUs, not just POWER7. > > I also think we can cove

Re: [Qemu-devel] [PATCH v2 8/8] spapr_pci: Use XICS interrupt allocator and do not cache interrupts in PHB

2014-05-21 Thread Alexey Kardashevskiy
On 05/21/2014 08:35 PM, Alexander Graf wrote: > > On 21.05.14 12:13, Alexey Kardashevskiy wrote: >> On 05/21/2014 07:50 PM, Alexander Graf wrote: >>> On 21.05.14 11:33, Alexey Kardashevskiy wrote: On 05/21/2014 07:13 PM, Alexander Graf wrote: > On 21.05.14 11:11, Michael S. Tsirkin wrote:

Re: [Qemu-devel] [PATCH v2 30/31] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole

2014-05-21 Thread Michael S. Tsirkin
On Wed, May 21, 2014 at 01:22:23PM +0200, Igor Mammedov wrote: > On Wed, 21 May 2014 11:05:58 +0300 > "Michael S. Tsirkin" wrote: > > > On Tue, May 20, 2014 at 05:15:33PM +0200, Igor Mammedov wrote: > > > Needed for Windows to use hotplugged memory device, otherwise > > > it complains that server

Re: [Qemu-devel] [PATCH v20 03/15] block: Replace in_use with operation blocker

2014-05-21 Thread Stefan Hajnoczi
On Tue, May 20, 2014 at 02:04:28PM +0800, Fam Zheng wrote: > This drops BlockDriverState.in_use with op_blockers: > > - Call bdrv_op_block_all in place of bdrv_set_in_use(bs, 1). > > - Call bdrv_op_unblock_all in place of bdrv_set_in_use(bs, 0). > > - Check bdrv_op_is_blocked() in place of

[Qemu-devel] [PATCH 1/3] input: add qemu_input_key_number_to_qcode

2014-05-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/input.h | 1 + ui/input-keymap.c | 11 --- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/include/ui/input.h b/include/ui/input.h index 3d3d487..d84ed8b 100644 --- a/include/ui/input.h +++ b/include/ui/input.h @@ -36,6 +36,7 @@

Re: [Qemu-devel] [PATCH v2] virtio-balloon: return empty data when no stats are available

2014-05-21 Thread Michael S. Tsirkin
On Wed, May 21, 2014 at 11:03:47AM +0200, Ján Tomko wrote: > If the guest hasn't updated the stats yet, instead of returning > an error, return '-1' for the stats and '0' as 'last-update'. > > This lets applications ignore this without parsing the error message. > > Related libvirt patch and disc

Re: [Qemu-devel] [PATCH v1 RFC 6/6] KVM: s390: add cpu model support

2014-05-21 Thread Michael Mueller
On Tue, 20 May 2014 12:10:23 +0200 Alexander Graf wrote: > > On 20.05.14 12:02, Michael Mueller wrote: > > On Mon, 19 May 2014 22:14:00 +0200 > > Alexander Graf wrote: > > > >> On 19.05.14 19:03, Michael Mueller wrote: > >>> On Mon, 19 May 2014 16:49:28 +0200 > >>> Alexander Graf wrote: > >>>

[Qemu-devel] x86 emulation on ARM host (Samsung Chromebook)

2014-05-21 Thread Violaine V.
Hi everyone, I’m trying to use QEMU (qemu-system-x86_64) to emulate an x86 virtual machine on an ARM host : a Samsung Chromebook with Cortex-A15 CPU. My Chromebook boots a Linux (kernel version 3.13) from an SD card. I have tried to create a new Debian virtual machine, by using a netinst iso fil

Re: [Qemu-devel] [PATCH v20 04/15] block: Move op_blocker check from block_job_create to its caller

2014-05-21 Thread Stefan Hajnoczi
On Wed, May 21, 2014 at 02:08:46PM +0800, Fam Zheng wrote: > On Wed, 05/21 00:34, Jeff Cody wrote: > > On Wed, May 21, 2014 at 09:36:08AM +0800, Fam Zheng wrote: > > > On Tue, 05/20 07:43, Jeff Cody wrote: > > > > On Tue, May 20, 2014 at 02:04:29PM +0800, Fam Zheng wrote: > > > > > It makes no sens

Re: [Qemu-devel] [PATCH v20 04/15] block: Move op_blocker check from block_job_create to its caller

2014-05-21 Thread Jeff Cody
On Wed, May 21, 2014 at 03:13:15PM +0200, Stefan Hajnoczi wrote: > On Wed, May 21, 2014 at 02:08:46PM +0800, Fam Zheng wrote: > > On Wed, 05/21 00:34, Jeff Cody wrote: > > > On Wed, May 21, 2014 at 09:36:08AM +0800, Fam Zheng wrote: > > > > On Tue, 05/20 07:43, Jeff Cody wrote: > > > > > On Tue, Ma

Re: [Qemu-devel] [PATCH v20 04/15] block: Move op_blocker check from block_job_create to its caller

2014-05-21 Thread Stefan Hajnoczi
On Tue, May 20, 2014 at 02:04:29PM +0800, Fam Zheng wrote: > It makes no sense to check for "any" blocker on bs, we are here only > because of the mechanical conversion from in_use to op_blockers. Remove > it now, and let the callers check specific operation types. Backup and > mirror already have

[Qemu-devel] Common header file for error codes

2014-05-21 Thread Anshul Makkar
Hi, Doesn't there exist a common header file for all the return codes. In the code I can see return values as 0, -1 etc. Am I missing something or is this some work in progress. Thanks Anshul Makkar www.justkernel.com

Re: [Qemu-devel] [PATCH v1 RFC 6/6] KVM: s390: add cpu model support

2014-05-21 Thread Alexander Graf
On 21.05.14 14:56, Michael Mueller wrote: On Tue, 20 May 2014 12:10:23 +0200 Alexander Graf wrote: On 20.05.14 12:02, Michael Mueller wrote: On Mon, 19 May 2014 22:14:00 +0200 Alexander Graf wrote: On 19.05.14 19:03, Michael Mueller wrote: On Mon, 19 May 2014 16:49:28 +0200 Alexander Gra

Re: [Qemu-devel] [PATCH 2/9] target-ppc: Refactor init_proc_POWER7

2014-05-21 Thread Alexander Graf
On 21.05.14 14:30, Alexey Kardashevskiy wrote: On 05/21/2014 08:44 PM, Alexander Graf wrote: On 21.05.14 08:20, Alexey Kardashevskiy wrote: This moves SPR initialization to helper functions. Signed-off-by: Alexey Kardashevskiy I like the idea, but please refactor all book3s CPUs, not just P

Re: [Qemu-devel] [PATCH] qapi: zero-initialize all QMP command parameters

2014-05-21 Thread Luiz Capitulino
On Tue, 20 May 2014 12:20:39 -0500 Michael Roth wrote: > In general QMP command parameter values are specified by consumers of the > QMP/HMP interface, but in the case of optional parameters these values may > be left uninitialized. > > It is considered a bug for code to make use of optional par

Re: [Qemu-devel] [PATCH v2 00/23] target-arm: add Security Extensions for CPUs

2014-05-21 Thread Peter Maydell
On 16 May 2014 21:56, Greg Bellows wrote: > Overview: > The approach delicately hashes all the SP registers just as Fabian's > approach does. The primary difference is that all the existing ARMCPRegInfo > entries are left as-is and are blindly registered for both NS-bit settings > (encoded in the

Re: [Qemu-devel] [PATCH v2 30/31] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole

2014-05-21 Thread Igor Mammedov
On Wed, 21 May 2014 15:44:07 +0300 "Michael S. Tsirkin" wrote: > On Wed, May 21, 2014 at 01:22:23PM +0200, Igor Mammedov wrote: > > On Wed, 21 May 2014 11:05:58 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, May 20, 2014 at 05:15:33PM +0200, Igor Mammedov wrote: > > > > Needed for Wind

Re: [Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDriverState

2014-05-21 Thread Stefan Hajnoczi
On Tue, May 20, 2014 at 02:04:31PM +0800, Fam Zheng wrote: > diff --git a/block/mirror.c b/block/mirror.c > index 1c38aa8..6a53d79 100644 > --- a/block/mirror.c > +++ b/block/mirror.c > @@ -499,6 +499,7 @@ immediate_exit: > * trigger the unref from the top one */ > BlockD

Re: [Qemu-devel] [PATCH v20 05/15] block: Add bdrv_set_backing_hd()

2014-05-21 Thread Stefan Hajnoczi
On Tue, May 20, 2014 at 02:04:30PM +0800, Fam Zheng wrote: > This is the common but non-trivial steps to assign or change the > backing_hd of BDS. > > Signed-off-by: Fam Zheng > --- > block.c | 36 +++- > include/block/block.h | 1 + > 2 files chang

Re: [Qemu-devel] [PATCH v20 04/15] block: Move op_blocker check from block_job_create to its caller

2014-05-21 Thread Jeff Cody
On Wed, May 21, 2014 at 02:08:46PM +0800, Fam Zheng wrote: > On Wed, 05/21 00:34, Jeff Cody wrote: > > On Wed, May 21, 2014 at 09:36:08AM +0800, Fam Zheng wrote: > > > On Tue, 05/20 07:43, Jeff Cody wrote: > > > > On Tue, May 20, 2014 at 02:04:29PM +0800, Fam Zheng wrote: > > > > > It makes no sens

Re: [Qemu-devel] [PATCH 3/3] target-i386: get CPL from SS.DPL

2014-05-21 Thread Kevin O'Connor
On Wed, May 21, 2014 at 01:13:21PM +0200, Paolo Bonzini wrote: > Il 20/05/2014 23:54, Kevin O'Connor ha scritto: > >On Fri, May 16, 2014 at 09:59:25PM +0200, Paolo Bonzini wrote: > >>CS.RPL is not equal to the CPL in the few instructions between > >>setting CR0.PE and reloading CS. We get this rig

Re: [Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDriverState

2014-05-21 Thread Stefan Hajnoczi
On Tue, May 20, 2014 at 02:04:31PM +0800, Fam Zheng wrote: > This makes use of op_blocker and blocks all the operations except for > commit target, on each BlockDriverState->backing_hd. > > The asserts for op_blocker in bdrv_swap are removed because with this > change, the target of block commit h

Re: [Qemu-devel] [PATCH v2 00/23] target-arm: add Security Extensions for CPUs

2014-05-21 Thread Peter Maydell
On 20 May 2014 16:43, Greg Bellows wrote: > My focus within Linaro is to add support for the security extension to qemu > for ARMv7. Given that we both started from Samsung's original patches our > code is fairly similar. However, it appears that your changes have also > incorporated some ARMv8

Re: [Qemu-devel] [PATCH v20 05/15] block: Add bdrv_set_backing_hd()

2014-05-21 Thread Jeff Cody
On Tue, May 20, 2014 at 02:04:30PM +0800, Fam Zheng wrote: > This is the common but non-trivial steps to assign or change the > backing_hd of BDS. > > Signed-off-by: Fam Zheng > --- > block.c | 36 +++- > include/block/block.h | 1 + > 2 files chang

Re: [Qemu-devel] [PATCH 3/3] target-i386: get CPL from SS.DPL

2014-05-21 Thread Paolo Bonzini
Il 21/05/2014 16:05, Kevin O'Connor ha scritto: On Wed, May 21, 2014 at 01:13:21PM +0200, Paolo Bonzini wrote: Il 20/05/2014 23:54, Kevin O'Connor ha scritto: On Fri, May 16, 2014 at 09:59:25PM +0200, Paolo Bonzini wrote: CS.RPL is not equal to the CPL in the few instructions between setting C

Re: [Qemu-devel] [PATCH v3] aio: Fix use-after-free in cancellation path

2014-05-21 Thread Stefan Hajnoczi
On Wed, May 21, 2014 at 10:42:13AM +0800, Fam Zheng wrote: > The current flow of canceling a thread from THREAD_ACTIVE state is: > > 1) Caller wants to cancel a request, so it calls thread_pool_cancel. > > 2) thread_pool_cancel waits on the conditional variable > elem->check_cancel. > >

Re: [Qemu-devel] Common header file for error codes

2014-05-21 Thread Eric Blake
On 05/21/2014 07:24 AM, Anshul Makkar wrote: > Hi, > > Doesn't there exist a common header file for all the return codes. In the > code I can see return values as 0, -1 etc. Most functions that flag failure via the return value do so by returning merely 0 or -1. There's a few that return 0 or -e

[Qemu-devel] [PATCH 3/9] spapr_pci: Introduce a finish_realize() callback

2014-05-21 Thread Alexey Kardashevskiy
The spapr-pci PHB initializes IOMMU for emulated devices only. The upcoming VFIO support will do it different. However both emulated and VFIO PHB types share most of the initialization code. For the type specific things a new finish_realize() callback is introduced. This introduces sPAPRPHBClass d

[Qemu-devel] [PATCH 2/9] spapr_iommu: Enable multiple TCE requests

2014-05-21 Thread Alexey Kardashevskiy
Currently only single TCE entry per request is supported (H_PUT_TCE). However PAPR+ specification allows multiple entry requests such as H_PUT_TCE_INDIRECT and H_STUFF_TCE. Having less transitions to the host kernel via ioctls, support of these calls can accelerate IOMMU operations. This implement

[Qemu-devel] [PATCH 0/9] spapr_pci: Prepare for VFIO

2014-05-21 Thread Alexey Kardashevskiy
This patchset prepares QEMU for VFIO support on SPAPR. It also does preparations for Dynamic DMA window feature which allows to create DMA windows with 16MB IOMMU pages which will allow to map the entire guest RAM for DMA at almost no cost. Alexey Kardashevskiy (9): spapr: Enable dynamic chang

[Qemu-devel] [PATCH 7/9] spapr_iommu: Get rid of window_size in sPAPRTCETable

2014-05-21 Thread Alexey Kardashevskiy
This removes window_size as it is basically a copy of nb_table shifted by SPAPR_TCE_PAGE_SHIFT. As new dynamic DMA windows are going to support windows as big as the entire RAM and this number will be bigger that 32 capacity, we will have to do something about @window_size anyway and removal seems

[Qemu-devel] [PATCH 4/9] spapr_pci: spapr_iommu: Make DMA window a subregion

2014-05-21 Thread Alexey Kardashevskiy
Currently the default DMA window is represented by a single MemoryRegion. However there can be more than just one window so we need a "root" memory region to be separated from the actual DMA window(s). This introduces a "root" IOMMU memory region and adds a subregion for the default DMA 32bit wind

[Qemu-devel] [PATCH 1/9] spapr: Enable dynamic change of the supported hypercalls list

2014-05-21 Thread Alexey Kardashevskiy
At the moment the "ibm,hypertas-functions" list is fixed. However some calls should be listed there if they are supported by QEMU or the host kernel. This enables hyperrtas_prop to grow on stack by adding a SPAPR_HYPERRTAS_ADD macro. The first user of this is going to be a "multi-tce" property.

[Qemu-devel] [PATCH 5/9] spapr_pci: Allow multiple TCE tables per PHB

2014-05-21 Thread Alexey Kardashevskiy
At the moment sPAPRPHBState contains a @tcet pointer to the only TCE table. However sPAPR spec allows having more than one DMA window. Since the TCE object is already a child of SPAPR PHB object, there is no need to keep an additional pointer to it in sPAPRPHBState so remove it. This changes the

[Qemu-devel] [PATCH 8/9] spapr_iommu: Introduce page_shift in sPAPRTCETable

2014-05-21 Thread Alexey Kardashevskiy
At the moment only 4K pages are supported by sPAPRTCETable. Since sPAPR spec allows other page sizes and we are going to implement them, we need page size to be configrable. This adds @page_shift into sPAPRTCETable and replaces SPAPR_TCE_PAGE_SHIFT with it whereever it is possible. This removes S

[Qemu-devel] [PATCH 9/9] spapr_iommu: Introduce bus_offset in sPAPRTCETable

2014-05-21 Thread Alexey Kardashevskiy
This adds @bus_offset into sPAPRTCETable to tell where TCE table starts from. It is set to 0 for emulated devices. Dynamic DMA windows will use other offset. Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_iommu.c | 13 + hw/ppc/spapr_pci.c | 5 +++-- hw/ppc/spapr_vio.c

Re: [Qemu-devel] [PATCH 1/9] spapr: Enable dynamic change of the supported hypercalls list

2014-05-21 Thread Alexander Graf
On 21.05.14 16:21, Alexey Kardashevskiy wrote: At the moment the "ibm,hypertas-functions" list is fixed. However some calls should be listed there if they are supported by QEMU or the host kernel. This enables hyperrtas_prop to grow on stack by adding a SPAPR_HYPERRTAS_ADD macro. The first use

[Qemu-devel] [PATCH 6/9] spapr_iommu: Convert old qdev_init_nofail() to object_property_set_bool

2014-05-21 Thread Alexey Kardashevskiy
qdev_init_nofail() was replaced by object_property_set_bool("realized") all over the QEMU so do we. Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c index 241ceeb..0dd6509

Re: [Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDriverState

2014-05-21 Thread Jeff Cody
On Wed, May 21, 2014 at 04:03:03PM +0200, Stefan Hajnoczi wrote: > On Tue, May 20, 2014 at 02:04:31PM +0800, Fam Zheng wrote: > > diff --git a/block/mirror.c b/block/mirror.c > > index 1c38aa8..6a53d79 100644 > > --- a/block/mirror.c > > +++ b/block/mirror.c > > @@ -499,6 +499,7 @@ immediate_exit:

Re: [Qemu-devel] [PATCH 3/3] target-i386: get CPL from SS.DPL

2014-05-21 Thread Kevin O'Connor
On Wed, May 21, 2014 at 04:18:22PM +0200, Paolo Bonzini wrote: > Il 21/05/2014 16:05, Kevin O'Connor ha scritto: > >On Wed, May 21, 2014 at 01:13:21PM +0200, Paolo Bonzini wrote: > >>I cannot reproduce this. I can see the breakage with current master, and I > >>can see your patch fixing it. It ke

Re: [Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDriverState

2014-05-21 Thread Fam Zheng
On Wed, 05/21 10:24, Jeff Cody wrote: > On Wed, May 21, 2014 at 04:03:03PM +0200, Stefan Hajnoczi wrote: > > On Tue, May 20, 2014 at 02:04:31PM +0800, Fam Zheng wrote: > > > diff --git a/block/mirror.c b/block/mirror.c > > > index 1c38aa8..6a53d79 100644 > > > --- a/block/mirror.c > > > +++ b/block

<    1   2   3   4   >