Re: [Qemu-devel] [PATCH] -machine vmport=off: Allow disabling of VMWare ioport emulation

2014-05-20 Thread Gerd Hoffmann
> /* init basic PC hardware */ > -pc_basic_device_init(isa_bus, gsi, &rtc_state, &floppy, xen_enabled(), > -0x4); > +pc_basic_device_init(isa_bus, gsi, &rtc_state, &floppy, > + !qemu_opt_get_bool(qemu_get_machine_opts(), > "vmport", > +

Re: [Qemu-devel] [PATCH] block: iscsi build fix if LIBISCSI_FEATURE_IOVECTOR is not defined

2014-05-20 Thread Paolo Bonzini
Il 19/05/2014 23:13, Jeff Cody ha scritto: Commit b03c380 introduced the function iscsi_allocationmap_is_allocated(), however it is only used within a code block that is conditionally compiled. This produces a warning (error with -werror) of "defined but not used" for the the function, if LIBISC

Re: [Qemu-devel] [PATCH] -machine vmport=off: Allow disabling of VMWare ioport emulation

2014-05-20 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > > /* init basic PC hardware */ > > -pc_basic_device_init(isa_bus, gsi, &rtc_state, &floppy, xen_enabled(), > > -0x4); > > +pc_basic_device_init(isa_bus, gsi, &rtc_state, &floppy, > > + !qemu_opt_get_bool(qemu_

Re: [Qemu-devel] [PATCH] block: Fix compiler warning (unused local function)

2014-05-20 Thread Kevin Wolf
Am 20.05.2014 um 07:08 hat Stefan Weil geschrieben: > Warning from gcc: > > block/iscsi.c:384:13: error: > ‘iscsi_allocationmap_is_allocated’ defined but not used > [-Werror=unused-function] > > The function is only used if LIBISCSI_FEATURE_IOVECTOR is defined. > > Signed-off-by: Stefan Weil

Re: [Qemu-devel] [PATCH] qemu-iotests: Honor ${CACHEMODE} in 091

2014-05-20 Thread Kevin Wolf
Am 20.05.2014 um 03:03 hat Fam Zheng geschrieben: > On Mon, 05/19 16:40, Kevin Wolf wrote: > > Am 19.05.2014 um 14:24 hat Fam Zheng geschrieben: > > > We should allow testing this on tmpfs. Any cache setting in iotests > > > should try to obey $CACHEMODE. > > > > > > Signed-off-by: Fam Zheng > >

Re: [Qemu-devel] [PATCH v3 19/22] target-arm: A64: Register VBAR_EL2

2014-05-20 Thread Peter Crosthwaite
On Mon, May 19, 2014 at 7:23 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/cpu.h| 2 +- > target-arm/helper.c | 20 > 2 files changed, 21 insertions(+), 1 deletion(-) > > diff --git a/target-arm/cpu.h b

[Qemu-devel] [RFC PATCH v2 0/7] qapi: Specify default value for optional argument in schema json

2014-05-20 Thread Fam Zheng
Please first take a look at patch 7 to see what is supported by this series. Patch 1 ~ 3 allows some useful basic types in schema. Patch 4 ~ 6 implements the new syntax. Note: The introduced '@arg' sigil, just like the preexisting '*arg', is reducing the cleanness of the syntax. We should get ri

[Qemu-devel] [RFC PATCH v2 1/7] qapi: Allow decimal values

2014-05-20 Thread Fam Zheng
This allows giving decimal constants in the schema as expr. Signed-off-by: Fam Zheng --- scripts/qapi.py | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 0265b40..4c945ad 100644 --- a/scripts/qapi.py +++ b/scripts

[Qemu-devel] [RFC PATCH v2 6/7] qapi: Initialize argument value in generated code if has 'default'

2014-05-20 Thread Fam Zheng
Input marshalling code generation is modified. If an argument has default, initialize its value in generated code to that default. If this argument is specified by user input, visit argument with deallocate visitor, before input visitor, so that the initial value is deallocated. This moves initia

Re: [Qemu-devel] [PATCH v3 22/22] RFC: target-arm: Use a 1:1 mapping between EL and MMU index

2014-05-20 Thread Peter Crosthwaite
On Mon, May 19, 2014 at 7:23 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/cpu.h | 26 -- > target-arm/translate.h | 2 +- > 2 files changed, 5 insertions(+), 23 deletions(-) > > diff --git a/targe

[Qemu-devel] [RFC PATCH v2 2/7] qapi: Allow true, false and null in schema json

2014-05-20 Thread Fam Zheng
Signed-off-by: Fam Zheng --- scripts/qapi.py | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 4c945ad..0f275f3 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -171,7 +171,20 @@ class QAPISchema:

[Qemu-devel] [RFC PATCH v2 3/7] tests: Add decimal test cases for qapi-schema

2014-05-20 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/Makefile | 3 ++- tests/qapi-schema/integers-leading-zero.err | 1 + tests/qapi-schema/integers-leading-zero.exit | 1 + tests/qapi-schema/integers-leading-zero.json | 1 + tests/qapi-schema/integers-leading-zero.out | 0 tes

[Qemu-devel] [RFC PATCH v2 5/7] qapi: Add @arg property dictionary syntax

2014-05-20 Thread Fam Zheng
parse_args now yields one more item in an iteration - default. It is the default value for the argument, that is parsed from 'data': { '@ARG_NAME': { PROP_NAME : PROP_VALUE } } syntax added into qapi schema. ARG_NAME is the name of argument. PROP_NAME is the property name of argument, curren

[Qemu-devel] [RFC PATCH v2 4/7] qapi: Add c_val(t, val) for int

2014-05-20 Thread Fam Zheng
c_val should generate the C value for a value in a given type. Only handle int for now. Signed-off-by: Fam Zheng --- scripts/qapi.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/scripts/qapi.py b/scripts/qapi.py index 0f275f3..ca2f1cc 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.

Re: [Qemu-devel] [PATCH v3 00/22] target-arm: Preparations for A64 EL2 and 3

2014-05-20 Thread Peter Crosthwaite
On Mon, May 19, 2014 at 7:22 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Hi, > > I've been doing some work on modeling parts of EL2 and 3 + some of > the system-wide virtualization features for ARMv8. A lot is missing > but I've got a series with enough to for example run KVM A64

[Qemu-devel] [RFC PATCH v2 7/7] qmp: Convert block-commit speed to arg property dict

2014-05-20 Thread Fam Zheng
Moving the default value logic from qmp handler to generated code. Signed-off-by: Fam Zheng --- blockdev.c | 6 +- qapi-schema.json | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/blockdev.c b/blockdev.c index 7810e9f..de06218 100644 --- a/blockdev.c +++ b/blockd

Re: [Qemu-devel] [RFC PATCH v2 0/7] qapi: Specify default value for optional argument in schema json

2014-05-20 Thread Fam Zheng
My script failed to generate a good Cc list, manual fix. Sorry for the noise. Fam On Tue, 05/20 17:07, Fam Zheng wrote: > Please first take a look at patch 7 to see what is supported by this series. > > Patch 1 ~ 3 allows some useful basic types in schema. > > Patch 4 ~ 6 implements the new syn

Re: [Qemu-devel] [PATCH] -machine vmport=off: Allow disabling of VMWare ioport emulation

2014-05-20 Thread Richard W.M. Jones
On Tue, May 20, 2014 at 09:47:26AM +0100, Dr. David Alan Gilbert wrote: > * Gerd Hoffmann (kra...@redhat.com) wrote: > > > /* init basic PC hardware */ > > > -pc_basic_device_init(isa_bus, gsi, &rtc_state, &floppy, > > > xen_enabled(), > > > -0x4); > > > +pc_basic_device_init

Re: [Qemu-devel] [v2][PATCH 8/8] xen, gfx passthrough: add opregion mapping

2014-05-20 Thread Chen, Tiejun
> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: Monday, May 19, 2014 7:54 PM > To: Chen, Tiejun > Cc: anthony.per...@citrix.com; stefano.stabell...@eu.citrix.com; > m...@redhat.com; kelly.zyta...@amd.com; qemu-devel@nongnu.org; > xen-de...@l

Re: [Qemu-devel] [Xen-devel] [v2][PATCH 3/8] xen, gfx passthrough: basic graphics passthrough support

2014-05-20 Thread Chen, Tiejun
Just resend since looks this delivery is delayed to these recipients or groups. Sorry for any inconveniences. Thanks Tiejun > -Original Message- > From: Chen, Tiejun > Sent: Tuesday, May 20, 2014 9:30 AM > To: 'Konrad Rzeszutek Wilk' > Cc: anthony.per...@citrix.com; stefano.stabell...@eu

Re: [Qemu-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD

2014-05-20 Thread Chen, Tiejun
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Monday, May 19, 2014 6:13 PM > To: Chen, Tiejun > Cc: Gerd Hoffmann; anthony.per...@citrix.com; > stefano.stabell...@eu.citrix.com; kelly.zyta...@amd.com; > peter.mayd...@linaro.org; xen-de...@lists.xensource

[Qemu-devel] [GSoC] Presentation

2014-05-20 Thread Marc Marí
Hello everyone I'm Marc Marí (markmb in IRC), and I'm funded to work on virtio and I2C libqos device drivers for 12 weeks as a Google Summer of Code Student [1]. In particular, I'll create drivers for both PIIX4 (i440fx) and ICH9 (q35) SMBus, and the libqos virtio device interface, with the specif

Re: [Qemu-devel] [PATCH v3 22/22] RFC: target-arm: Use a 1:1 mapping between EL and MMU index

2014-05-20 Thread Aggeler Fabian
I guess this makes sense. Shouldn’t we implement two more MMUs to separate S-EL0/EL0 and S-EL1/EL1 at least for ARMv8 with EL3 running in Aarch64 state? For ARMv7 and ARMv8 with EL3 in Aarch32 S-PL1 is mapped to PL3, so we only need one additional MMU for S-PL0. If you agree I could add this ch

Re: [Qemu-devel] [PATCH qom v5 0/2] Named GPIOs

2014-05-20 Thread Andreas Färber
Am 20.05.2014 08:30, schrieb Peter Crosthwaite: > This series implements Named GPIOs on the qdev level. Patch 1 is the > feature presentation. > > Second patch I give a useful example of the feature's use (an SSI > cleanup). > > This kinda falls through the cracks between the active maintainershi

Re: [Qemu-devel] [PATCH qom v5 2/2] ssi: Name the CS GPIO.

2014-05-20 Thread Andreas Färber
Am 20.05.2014 08:31, schrieb Peter Crosthwaite: > To get it out of the default GPIO list. This allows child devices to > use the un-named GPIO namespace without having to be SSI aware. That > is, there is no more need for machines to know about the obscure > policy where GPIO 0 is the SSI chip-sele

Re: [Qemu-devel] [PATCH v2 00/23] target-arm: add Security Extensions for CPUs

2014-05-20 Thread Aggeler Fabian
Hi Greg Thanks for sharing your approach. I like your idea of keeping the hashtable small when Security Extensions are not present as well as isolating Sec-Ext specific registers in their own group. How do you want to proceed in this matter? Are you going to continue working on the banking and

Re: [Qemu-devel] [PATCH v1 RFC 6/6] KVM: s390: add cpu model support

2014-05-20 Thread Michael Mueller
On Mon, 19 May 2014 22:14:00 +0200 Alexander Graf wrote: > > On 19.05.14 19:03, Michael Mueller wrote: > > On Mon, 19 May 2014 16:49:28 +0200 > > Alexander Graf wrote: > > > >> On 19.05.14 16:18, Michael Mueller wrote: > >>> On Mon, 19 May 2014 13:48:08 +0200 > >>> Alexander Graf wrote: > >>>

Re: [Qemu-devel] [PATCH v1 RFC 6/6] KVM: s390: add cpu model support

2014-05-20 Thread Alexander Graf
On 20.05.14 12:02, Michael Mueller wrote: On Mon, 19 May 2014 22:14:00 +0200 Alexander Graf wrote: On 19.05.14 19:03, Michael Mueller wrote: On Mon, 19 May 2014 16:49:28 +0200 Alexander Graf wrote: [...] What user and thus also user space wants depends on other factors: 1. reliability

Re: [Qemu-devel] [PATCH] -machine vmport=off: Allow disabling of VMWare ioport emulation

2014-05-20 Thread Gerd Hoffmann
Hi, > It was disabled in this patch. The commit message is saying that > vmport cannot work in Xen, but I'm not exactly clear why. > > commit 1611977c3d8fdbdac6090cbd1fcee4aed6d9 > Author: Anthony PERARD > Date: Tue May 3 17:06:54 2011 +0100 > > pc, Disable vmport initialisat

Re: [Qemu-devel] usb: usb tablet freeze when save/restore guest os

2014-05-20 Thread Gerd Hoffmann
Hi, > As for Xen, It's too later. After suspend vm, the qemu process can response > the event > of usb tablet event. Because guest os's vcpus are paused, guest os cannot > response > interrupt injected by qemu. Then the interrupt will be lost. When the guest can't handle the interrupt (due t

Re: [Qemu-devel] [patch qemu] vmxnet3: fix msix vectors unuse

2014-05-20 Thread Dmitry Fleytman
ACK Thanks for fixing. On May 19, 2014, at 16:47 PM, Jiri Pirko wrote: > In vmxnet3_cleanup_msix(), there is called msix_vector_unuse() with > VMXNET3_MAX_INTRS. That is not correct since vector of > value VMXNET3_MAX_INTRS was never used. Also all the used vectors > are not un-used. So call vm

Re: [Qemu-devel] [v2][PATCH 8/8] xen, gfx passthrough: add opregion mapping

2014-05-20 Thread Stefano Stabellini
On Tue, 20 May 2014, Chen, Tiejun wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: Monday, May 19, 2014 7:54 PM > > To: Chen, Tiejun > > Cc: anthony.per...@citrix.com; stefano.stabell...@eu.citrix.com; > > m...@redhat.com; kelly.

Re: [Qemu-devel] [PATCH v2] kvm: Fix enable_cap helpers on older gcc

2014-05-20 Thread Cornelia Huck
On Mon, 12 May 2014 11:51:37 +0200 Alexander Graf wrote: > Commit 40f1ee27aa1 introduced handy helpers for enable_cap calls on > vcpu and vm level. Unfortunately some older gcc versions (4.7.1, 4.6) > seem to choke on signedness detection in inline created variables: > > target-ppc/kvm.c: In fun

Re: [Qemu-devel] [PATCH v2] kvm: Fix enable_cap helpers on older gcc

2014-05-20 Thread Alexander Graf
On 20.05.14 12:53, Cornelia Huck wrote: On Mon, 12 May 2014 11:51:37 +0200 Alexander Graf wrote: Commit 40f1ee27aa1 introduced handy helpers for enable_cap calls on vcpu and vm level. Unfortunately some older gcc versions (4.7.1, 4.6) seem to choke on signedness detection in inline created va

Re: [Qemu-devel] iPXE timeout missing

2014-05-20 Thread Gerd Hoffmann
On So, 2014-04-13 at 02:05 +0200, Sebastian wrote: > By removing the timeout, access to the iPXE command line is now > impossible (pressing Ctrl+B in the timeout breaks the script). fyi: ipxe update in qemu git master brought it back. cheers, Gerd

[Qemu-devel] [PATCH] target-xtensa: fix cross-page jumps/calls at the end of TB

2014-05-20 Thread Max Filippov
Move cross-page jump check to gen_jump_slot and use tb->pc instead of dc->pc to check for cross-page jumps. When TB ends at the page boundary dc->pc points to the next page allowing chaining to TBs in it. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Filippov --- target-xtensa/translate.c | 8 +-

Re: [Qemu-devel] [PATCH v9 00/20] Vhost and vhost-net support for userspace based backends

2014-05-20 Thread Nikolay Nikolaev
Hello Paolo, On Tue, Mar 4, 2014 at 8:29 PM, Paolo Bonzini wrote: > Il 04/03/2014 19:22, Antonios Motakis ha scritto: > > In this patch series we would like to introduce our approach for putting a >> virtio-net backend in an external userspace process. Our eventual target >> is to >> run the n

[Qemu-devel] [PATCH 1/3] usb-mtp: use bool to track MTPObject init status

2014-05-20 Thread Gerd Hoffmann
Stop setting nchildren to -1. Use separate bool variable to track whenever we've already fetched the child objects instead. Also make nchildren unsigned. Cc: Dr. David Alan Gilbert Signed-off-by: Gerd Hoffmann --- hw/usb/dev-mtp.c | 14 -- 1 file changed, 8 insertions(+), 6 deleti

[Qemu-devel] [PATCH 3/3] usb-mtp: handle usb_mtp_get_object failure

2014-05-20 Thread Gerd Hoffmann
Cc: Dr. David Alan Gilbert Signed-off-by: Gerd Hoffmann --- hw/usb/dev-mtp.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index a95298b..380b465 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -46,6 +46,7 @@ enum mtp_cod

[Qemu-devel] [PATCH 2/3] usb-mtp: handle lseek failure

2014-05-20 Thread Gerd Hoffmann
Cc: Dr. David Alan Gilbert Signed-off-by: Gerd Hoffmann --- hw/usb/dev-mtp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index c2750e4..a95298b 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -702,7 +702,10 @@ static MTPData

Re: [Qemu-devel] [PATCH] target-xtensa: fix cross-page jumps/calls at the end of TB

2014-05-20 Thread Max Filippov
On Tue, May 20, 2014 at 3:17 PM, Max Filippov wrote: > Move cross-page jump check to gen_jump_slot and use tb->pc instead of > dc->pc to check for cross-page jumps. > When TB ends at the page boundary dc->pc points to the next page > allowing chaining to TBs in it. > > Cc: qemu-sta...@nongnu.org >

Re: [Qemu-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD

2014-05-20 Thread Michael S. Tsirkin
On Tue, May 20, 2014 at 09:34:23AM +, Chen, Tiejun wrote: > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Monday, May 19, 2014 6:13 PM > > To: Chen, Tiejun > > Cc: Gerd Hoffmann; anthony.per...@citrix.com; > > stefano.stabell...@eu.citrix.com; kel

[Qemu-devel] [PATCH 3/7] dump: eliminate DumpState.page_shift ("guest's page shift")

2014-05-20 Thread Laszlo Ersek
Just use TARGET_PAGE_BITS. "DumpState.page_shift" used to have type "uint32_t", while the replacement TARGET_PAGE_BITS has type "int". Since "DumpState.page_shift" was only used as bit shift counts in the paddr_to_pfn() and pfn_to_paddr() macros, this is safe. Suggested-by: Paolo Bonzini Signed-

[Qemu-devel] [PATCH 6/7] dump: hoist lzo_init() from get_len_buf_out() to dump_init()

2014-05-20 Thread Laszlo Ersek
qmp_dump_guest_memory() dump_init() lzo_init() <-+ create_kdump_vmcore() | write_dump_pages() | get_len_buf_out() | lzo_init() --+ This patch doesn't change the fact that lzo_init() is called for every LZO-compressed dump, but it makes get_len_buf_out() mo

[Qemu-devel] [PATCH 7/7] dump: simplify get_len_buf_out()

2014-05-20 Thread Laszlo Ersek
We can (and should) rely on the fact that s->flag_compress is exactly one of DUMP_DH_COMPRESSED_ZLIB, DUMP_DH_COMPRESSED_LZO, and DUMP_DH_COMPRESSED_SNAPPY. This is ensured by the QMP schema and dump_init() in combination. Suggested-by: Paolo Bonzini Signed-off-by: Laszlo Ersek --- dump.c | 44

Re: [Qemu-devel] [PATCH v20 04/15] block: Move op_blocker check from block_job_create to its caller

2014-05-20 Thread Jeff Cody
On Tue, May 20, 2014 at 02:04:29PM +0800, Fam Zheng wrote: > It makes no sense to check for "any" blocker on bs, we are here only > because of the mechanical conversion from in_use to op_blockers. Remove > it now, and let the callers check specific operation types. Backup and > mirror already have

Re: [Qemu-devel] [PATCH v19 03/16] block: Introduce op_blockers to BlockDriverState

2014-05-20 Thread Markus Armbruster
Jeff Cody writes: > On Mon, May 19, 2014 at 04:37:52PM +0200, Kevin Wolf wrote: >> Am 19.05.2014 um 16:10 hat Markus Armbruster geschrieben: >> > Fam Zheng writes: [...] >> > > diff --git a/block.c b/block.c >> > > index b749d31..32338ca 100644 >> > > --- a/block.c >> > > +++ b/block.c [...] >>

[Qemu-devel] [PULL 1/9] kvm: Fix enable_cap helpers on older gcc

2014-05-20 Thread Cornelia Huck
From: Alexander Graf Commit 40f1ee27aa1 introduced handy helpers for enable_cap calls on vcpu and vm level. Unfortunately some older gcc versions (4.7.1, 4.6) seem to choke on signedness detection in inline created variables: target-ppc/kvm.c: In function 'kvmppc_booke_watchdog_enable': target-p

[Qemu-devel] [PULL 3/9] s390x: add I/O adapter registration

2014-05-20 Thread Cornelia Huck
Register an I/O adapter interrupt source for when virtio-ccw devices start using adapter interrupts. Reviewed-by: Thomas Huth Reviewed-by: Christian Borntraeger Signed-off-by: Cornelia Huck --- hw/intc/s390_flic.c | 16 ++ hw/intc/s390_flic_kvm.c | 29

[Qemu-devel] [PULL 0/9] s390 patches for 2014/05/20

2014-05-20 Thread Cornelia Huck
-tracking branch 'remotes/qmp-unstable/queue/qmp' into staging (2014-05-19 14:10:01 +0100) are available in the git repository at: git://github.com/cohuck/qemu.git tags/s390x-20140520 for you to fetch changes up to 770a63792b2c9a3f9565b68b0a7ef0be6883f551: s390x/kvm: hw debug

[Qemu-devel] [PULL 2/9] s390x: split flic into kvm and non-kvm parts

2014-05-20 Thread Cornelia Huck
Introduce a common parent class for both cases, where kvm and non-kvm can hook up callbacks. This will be used by follow-on patches for adapter registration and mapping. We now always have a flic, regardless of whether we use kvm; the non-kvm implementation just doesn't do anything. Reviewed-by:

[Qemu-devel] [PULL 7/9] s390x: remove duplicate definitions of DIAG 501

2014-05-20 Thread Cornelia Huck
From: David Hildenbrand When restoring the previously saved instruction in kvm_arch_remove_sw_breakpoint(), we only restored one byte. Let's use the sizeof() operator to make sure we restore the entire instruction. While we are at it, let's remove the duplicate definitions of DIAG 501 and replac

[Qemu-devel] [PULL 4/9] s390x/virtio-ccw: reference-counted indicators

2014-05-20 Thread Cornelia Huck
Make code using the same indicators point to a single allocated structure that is freed when the last user goes away. This will be used by the irqfd code to unmap addresses after the last user is gone. Reviewed-by: Thomas Huth Reviewed-by: Christian Borntraeger Signed-off-by: Cornelia Huck ---

[Qemu-devel] [PULL 8/9] s390x/kvm: software breakpoint support

2014-05-20 Thread Cornelia Huck
From: David Hildenbrand This patch allows to insert and remove sw breakpoints using the QEMU gdbserver on s390 as well as to interrupt execution on a breakpoint hit when running with KVM enabled. Whenever a software breakpoint is inserted, common code calls kvm ioctl KVM_UPDATE_GUEST_DEBUG. As t

[Qemu-devel] [PULL 9/9] s390x/kvm: hw debugging support via guest PER facility

2014-05-20 Thread Cornelia Huck
From: David Hildenbrand This patch makes use of the hw debugging support in kvm (provided by the guest's PER facility) on s390. It enables the following features, available using the gdbserver: - single-stepping - hw breakpoints - hw watchpoints Signed-off-by: David Hildenbrand Signed-off-by: J

[Qemu-devel] [PULL 6/9] linux-headers: update

2014-05-20 Thread Cornelia Huck
From: Jens Freimann Sync linux-headers with kvm/next (87c00572ba05aa8c9db118da75c608f47eb10b9e) Signed-off-by: Jens Freimann Signed-off-by: Cornelia Huck --- linux-headers/asm-s390/kvm.h | 28 linux-headers/linux/kvm.h|7 ++- 2 files changed, 34 inse

[Qemu-devel] [PULL 5/9] s390x/virtio-ccw: wire up irq routing and irqfds

2014-05-20 Thread Cornelia Huck
Make use of the new s390 adapter irq routing support to enable real in-kernel irqfds for virtio-ccw with adapter interrupts. Note that s390 doesn't provide the common KVM_CAP_IRQCHIP capability, but rather needs KVM_CAP_S390_IRQCHIP to be enabled. This is to ensure backward compatibility. Reviewe

Re: [Qemu-devel] qapi-commands.py generates code that uses uninitialized variables

2014-05-20 Thread Peter Maydell
On 20 March 2014 19:21, Michael Roth wrote: > Quoting Markus Armbruster (2014-03-18 04:32:08) >> Peter Maydell writes: >> >> > This is something clang's -fsanitize=undefined spotted. The >> > code generated by qapi-commands.py in qmp-marshal.c for >> > qmp_marshal_* functions where there are some

[Qemu-devel] [PATCH 0/7] cleanups for compressed dumps (kdumps)

2014-05-20 Thread Laszlo Ersek
In March Paolo and Luiz had some comments for upstream qemu while they were reviewing my downstream port of Qiao Nuohan's compressed (kdump-format) dump feature. I've finally got around addressing them. Laszlo Ersek (7): dump: fill in the flat header signature more pleasingly to the eye dump:

[Qemu-devel] [PATCH 5/7] dump: select header bitness based on ELF class, not ELF architecture

2014-05-20 Thread Laszlo Ersek
The specific ELF architecture (d_machine) carries Too Much Information (TM) for deciding between create_header32() and create_header64(), use "d_class" instead (ELFCLASS32 vs. ELFCLASS64). This change adapts write_dump_header() to write_elf_loads(), dump_begin() etc. that also rely on the ELF clas

[Qemu-devel] [PATCH 4/7] dump: eliminate DumpState.page_size ("guest's page size")

2014-05-20 Thread Laszlo Ersek
Use TARGET_PAGE_SIZE and ~TARGET_PAGE_MASK instead. "DumpState.page_size" has type "size_t", whereas TARGET_PAGE_SIZE has type "int". TARGET_PAGE_MASK is of type "int" and has negative value. The patch affects the implicit type conversions as follows: - create_header32() and create_header64(): as

Re: [Qemu-devel] [PATCH] qga: Fix handle fd leak in acquire_privilege()

2014-05-20 Thread Yan Vugenfirer
On May 19, 2014, at 10:26 AM, arei.gong...@huawei.com wrote: > From: Gonglei > > token should be closed in all conditions. > So move CloseHandle(token) to "out" branch. > > Signed-off-by: Wang Rui > Signed-off-by: Gonglei > --- > qga/commands-win32.c | 6 -- > 1 file changed, 4 insertions(

[Qemu-devel] [PATCH] qmp: show QOM properties in device-list-properties

2014-05-20 Thread Stefan Hajnoczi
Devices can use a mix of qdev and QOM properties. Currently only the qdev properties are displayed by device-list-properties. This patch extends the property enumeration algorithm to also display QOM properties (excluding the implicit "type", "realized", "hotpluggable", and "parent_bus" propertie

Re: [Qemu-devel] [Bug 1320968] [NEW] qemu-system-ppc -cpu G2leGP3 crashes

2014-05-20 Thread Tom Musta
On 5/19/2014 1:16 PM, Brandon Williams wrote: > Public bug reported: > > qemu crashes when running qemu-system-ppc -cpu G2leGP3 : > > qemu-system-ppc -cpu G2leGP3 > Error: Trying to register SPR 1013 (3f5) twice ! > > qemu-system-ppc -version > QEMU emulator version 2.0.50, Copyright (c) 2003-20

Re: [Qemu-devel] [RFC PATCH v2 3/7] tests: Add decimal test cases for qapi-schema

2014-05-20 Thread Eric Blake
On 05/20/2014 03:07 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > +++ b/tests/qapi-schema/integers-leading-zero.err > @@ -0,0 +1 @@ > +tests/qapi-schema/integers-leading-zero.json:1:12: Invalid number "00": > Leading zero for non-zero integer You are correct that this is not valid JSO

Re: [Qemu-devel] [PATCH v9 00/20] Vhost and vhost-net support for userspace based backends

2014-05-20 Thread Paolo Bonzini
Il 20/05/2014 13:22, Nikolay Nikolaev ha scritto: I am preparing a new version of this patch series and would like to test (or even rebase?) it on top of your patch series. What is its current status? Is there a tree that I can track and use for rebases? Hu Tao has been posting updates lately.

Re: [Qemu-devel] [PATCH 0/7] cleanups for compressed dumps (kdumps)

2014-05-20 Thread Paolo Bonzini
Il 20/05/2014 13:39, Laszlo Ersek ha scritto: In March Paolo and Luiz had some comments for upstream qemu while they were reviewing my downstream port of Qiao Nuohan's compressed (kdump-format) dump feature. I've finally got around addressing them. Laszlo Ersek (7): dump: fill in the flat head

Re: [Qemu-devel] [PATCH 0/7] cleanups for compressed dumps (kdumps)

2014-05-20 Thread Laszlo Ersek
On 05/20/14 14:56, Paolo Bonzini wrote: > Il 20/05/2014 13:39, Laszlo Ersek ha scritto: >> In March Paolo and Luiz had some comments for upstream qemu while they >> were reviewing my downstream port of Qiao Nuohan's compressed >> (kdump-format) dump feature. I've finally got around addressing them.

Re: [Qemu-devel] [PATCH v2] aio: Fix use-after-free in cancellation path

2014-05-20 Thread Stefan Hajnoczi
On Tue, May 20, 2014 at 10:00:47AM +0800, Fam Zheng wrote: > diff --git a/thread-pool.c b/thread-pool.c > index fbdd3ff..d4984ba 100644 > --- a/thread-pool.c > +++ b/thread-pool.c > @@ -223,6 +223,7 @@ static void thread_pool_cancel(BlockDriverAIOCB *acb) > } > pool->pending_cance

Re: [Qemu-devel] [PATCH v2] qemu-iotests: Handle cache mode option in 091

2014-05-20 Thread Stefan Hajnoczi
On Tue, May 20, 2014 at 09:10:32AM +0800, Fam Zheng wrote: > We should allow testing this on tmpfs. Any cache setting in iotests > should try to obey $CACHEMODE. > > The cache mode is still "none" by default but overridable > > Signed-off-by: Fam Zheng > > --- > v2: Add _default_cache_mode and

[Qemu-devel] [Bug 1308341] Re: Multiple CPUs causes blue screen on Windows guest (14.04 regression)

2014-05-20 Thread Hein Gustavsen
After adding "hyperv" feature, the guest freezes regularly. This happens on both and Windows 7 64-bit and Windows 2012 R2 guests. When removing the "hyperv" feature the guest acts normally, but fails with a blue screen as before. This may be a completely different issue, but this renders the workar

Re: [Qemu-devel] [PATCH v4] QemuOpt: add unit tests

2014-05-20 Thread Stefan Hajnoczi
On Mon, May 19, 2014 at 06:53:55PM -0300, Leandro Dorileo wrote: > Cover basic aspects and API usage for QemuOpt. The current implementation > covers the API's planned to be changed by Chunyan Liu in his > QEMUOptionParameter > replacement/cleanup job. > > Other APIs should be covered in future i

Re: [Qemu-devel] [patch qemu] vmxnet3: fix msix vectors unuse

2014-05-20 Thread Stefan Hajnoczi
On Mon, May 19, 2014 at 03:47:16PM +0200, Jiri Pirko wrote: > In vmxnet3_cleanup_msix(), there is called msix_vector_unuse() with > VMXNET3_MAX_INTRS. That is not correct since vector of > value VMXNET3_MAX_INTRS was never used. Also all the used vectors > are not un-used. So call vmxnet3_unuse_msi

Re: [Qemu-devel] [PATCH v3 22/22] RFC: target-arm: Use a 1:1 mapping between EL and MMU index

2014-05-20 Thread Edgar E. Iglesias
On Tue, May 20, 2014 at 09:47:47AM +, Aggeler Fabian wrote: > I guess this makes sense. Shouldn’t we implement two more MMUs to separate > S-EL0/EL0 and S-EL1/EL1 > at least for ARMv8 with EL3 running in Aarch64 state? Maybe with future patches. My understanding is that on aarch64 the world

Re: [Qemu-devel] [PATCH] qcow2: Fix memory leak in COW error path

2014-05-20 Thread Stefan Hajnoczi
On Mon, May 19, 2014 at 05:56:01PM +0200, Kevin Wolf wrote: > This triggers if bs->drv becomes NULL in a concurrent request. This is > currently only the case when corruption prevention kicks in (i.e. at > most once per image, and after that it produces I/O errors). > > Signed-off-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v3 22/22] RFC: target-arm: Use a 1:1 mapping between EL and MMU index

2014-05-20 Thread Peter Maydell
On 20 May 2014 14:28, Edgar E. Iglesias wrote: > On Tue, May 20, 2014 at 09:47:47AM +, Aggeler Fabian wrote: >> I guess this makes sense. Shouldn’t we implement two more MMUs to separate >> S-EL0/EL0 and S-EL1/EL1 >> at least for ARMv8 with EL3 running in Aarch64 state? > > Maybe with future

Re: [Qemu-devel] [PATCH v3 22/22] RFC: target-arm: Use a 1:1 mapping between EL and MMU index

2014-05-20 Thread Alexander Graf
On 20.05.14 15:47, Peter Maydell wrote: On 20 May 2014 14:28, Edgar E. Iglesias wrote: On Tue, May 20, 2014 at 09:47:47AM +, Aggeler Fabian wrote: I guess this makes sense. Shouldn’t we implement two more MMUs to separate S-EL0/EL0 and S-EL1/EL1 at least for ARMv8 with EL3 running in Aa

Re: [Qemu-devel] [PATCH v3 22/22] RFC: target-arm: Use a 1:1 mapping between EL and MMU index

2014-05-20 Thread Edgar E. Iglesias
On Tue, May 20, 2014 at 02:47:49PM +0100, Peter Maydell wrote: > On 20 May 2014 14:28, Edgar E. Iglesias wrote: > > On Tue, May 20, 2014 at 09:47:47AM +, Aggeler Fabian wrote: > >> I guess this makes sense. Shouldn’t we implement two more MMUs to separate > >> S-EL0/EL0 and S-EL1/EL1 > >> at

Re: [Qemu-devel] [PATCH v2] aio: Fix use-after-free in cancellation path

2014-05-20 Thread Paolo Bonzini
Il 20/05/2014 15:16, Stefan Hajnoczi ha scritto: On Tue, May 20, 2014 at 10:00:47AM +0800, Fam Zheng wrote: diff --git a/thread-pool.c b/thread-pool.c index fbdd3ff..d4984ba 100644 --- a/thread-pool.c +++ b/thread-pool.c @@ -223,6 +223,7 @@ static void thread_pool_cancel(BlockDriverAIOCB *acb)

[Qemu-devel] [PATCH 5/6] usb: add input routing support for tablet and keyboard

2014-05-20 Thread Gerd Hoffmann
Add display property to the keyboard. Add display and head properties to the tablet. If properties are set bind device to the display specified to setup input routing. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-hid.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/usb/dev

Re: [Qemu-devel] [call for testers] qemu gtk ui overhaul

2014-05-20 Thread Cole Robinson
On 05/16/2014 10:02 AM, Gerd Hoffmann wrote: > Hi folks, > > I'm trying to hammer the qemu gtk ui into shape. Fixing a bunch of > issues we have, and also try to make it ready for multihead support. > > Git tree is here: > git://git.kraxel.org/qemu rebase/ui-gtk-next > > cgit: > https:/

[Qemu-devel] question about feature block_stream and driver_mirror in qemu-xen

2014-05-20 Thread Xiaoding (B)
Hi all, I tried to test the features about block_stream/drive_mirror in the qemu-xen. (Xen version is 4.4.1, qemu version is 1.62) And I found the vm crashed after the hmp commands are sent. Whether xen has supported the two features in qemu-xen? My xl configuration file: name = "test1" memory =

[Qemu-devel] [PATCH 4/6] sdl: pass key event source to input layer

2014-05-20 Thread Gerd Hoffmann
So the input layer knows where the input is coming from and input routing works correctly. Signed-off-by: Gerd Hoffmann --- ui/sdl2.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index 361de61..0e884f9 100644 --- a/ui/sdl2.c +++

Re: [Qemu-devel] [Xen-devel] [v2][PATCH 6/8] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2014-05-20 Thread Konrad Rzeszutek Wilk
On Tue, May 20, 2014 at 05:13:45AM +, Chen, Tiejun wrote: > > -Original Message- > > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > > Sent: Monday, May 19, 2014 9:34 PM > > To: Zhang, Yang Z > > Cc: Chen, Tiejun; anthony.per...@citrix.com; > > stefano.stabell...@eu.citri

[Qemu-devel] [PATCH 0/6] add input routing and multiseat support

2014-05-20 Thread Gerd Hoffmann
Hi, $subject says all. Last patch has detailed usage docs, so I'm not repeating it here. cheers, Gerd Gerd Hoffmann (6): input: switch hid keyboard to new input layer api. input: switch hid mouse and tablet to the new input layer api. input: bind devices and input routing sdl: pass

[Qemu-devel] [PATCH 6/6] docs: add multiseat.txt

2014-05-20 Thread Gerd Hoffmann
Howto on setting up multiseat for guests. Signed-off-by: Gerd Hoffmann --- docs/multiseat.txt | 76 ++ 1 file changed, 76 insertions(+) create mode 100644 docs/multiseat.txt diff --git a/docs/multiseat.txt b/docs/multiseat.txt new file mode 1

[Qemu-devel] [PATCH 1/6] input: switch hid keyboard to new input layer api.

2014-05-20 Thread Gerd Hoffmann
Minimal patch to get the switchover done. We continue processing ps/2 scancodes for now as they are part of the live migration stream. Fixing that, then mapping directly from QKeyValue to HID keycodes is left as excercise for another day. Signed-off-by: Gerd Hoffmann --- hw/input/hid.c

[Qemu-devel] [PATCH 2/6] input: switch hid mouse and tablet to the new input layer api.

2014-05-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/input/hid.c | 193 +++-- include/hw/input/hid.h | 1 - 2 files changed, 123 insertions(+), 71 deletions(-) diff --git a/hw/input/hid.c b/hw/input/hid.c index ff75e41..295bdab 100644 --- a/hw/input/hid.c +++

Re: [Qemu-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD

2014-05-20 Thread Anthony PERARD
On Mon, May 19, 2014 at 12:04:14PM +, Chen, Tiejun wrote: > > -Original Message- > > From: Gerd Hoffmann [mailto:kra...@redhat.com] > > Sent: Monday, May 19, 2014 7:23 PM > > To: Chen, Tiejun > > Cc: anthony.per...@citrix.com; stefano.stabell...@eu.citrix.com; > > m...@redhat.com; kelly

[Qemu-devel] [PATCH 3/6] input: bind devices and input routing

2014-05-20 Thread Gerd Hoffmann
Add function to bind input devices to display devices. Implementing input routing on top of this: Events coming from the display device in question are routed to the input device bound to it (if there is one). Signed-off-by: Gerd Hoffmann --- include/ui/input.h | 3 +++ ui/input.c | 4

Re: [Qemu-devel] [PATCH v2] qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command

2014-05-20 Thread Tomoki Sekiyama
Any comments for this patch? Thanks, Tomoki Sekiyama On 4/28/14 11:25 , "Tomoki Sekiyama" wrote: >Hi, > >This is v2 patch for qemu-ga to add argument to specify which filesystems >to be frozen by guest-fsfreeze-freeze command. > >Changes to v1: > added documentation of the new field > (v1: htt

[Qemu-devel] [PATCH] e1000: allow command-line selection of card model

2014-05-20 Thread Gabriel L. Somlo
Allow selection of different card models from the qemu command line, to better accomodate a wider range of guests. Based-on-patch-by: Romain Dolbeau Signed-off-by: Gabriel Somlo --- Based on the conversation in [2,3,4], and given that I would still like OS X to work as close to "out of the box"

[Qemu-devel] [PATCH] tests: check empty qmp output visitor

2014-05-20 Thread Marcel Apfelbaum
Checks the output visitor behaviour for NULL values. Signed-off-by: Marcel Apfelbaum --- Notes: - I didn't add Michael's Sob because I tweaked the test a little. - To be added on top of "qapi: output visitor crashes qemu if it encounters a NULL value", otherwise the test will fail. test

Re: [Qemu-devel] [RFC PATCH v2 1/7] qapi: Allow decimal values

2014-05-20 Thread Eric Blake
On 05/20/2014 03:07 AM, Fam Zheng wrote: > This allows giving decimal constants in the schema as expr. > > Signed-off-by: Fam Zheng > --- > scripts/qapi.py | 22 -- > 1 file changed, 20 insertions(+), 2 deletions(-) > > diff --git a/scripts/qapi.py b/scripts/qapi.py > index

[Qemu-devel] [PATCH v2 01/31] pc: ACPI BIOS: use enum for defining memory affinity flags

2014-05-20 Thread Igor Mammedov
replace magic numbers with enum describing Flags field of memory affinity in SRAT table. MemoryAffinityFlags enum will define flags decribed by: ACPI spec 5.0, "5.2.16.2 Memory Affinity Structure", "Table 5-69 Flags - Memory Affinity Structure" Signed-off-by: Igor Mammedov --- hw/i386/acpi-bu

[Qemu-devel] [PATCH v2 04/31] add memdev backend infrastructure

2014-05-20 Thread Igor Mammedov
Provides framework for splitting host RAM allocation/ policies into a separate backend that could be used by devices. Initially only legacy RAM backend is provided, which uses memory_region_init_ram() allocator and compatible with every CLI option that affects memory_region_init_ram(). Signed-off

[Qemu-devel] [PATCH v2 07/31] qdev: hotplug for buss-less devices

2014-05-20 Thread Igor Mammedov
Adds get_hotplug_handler() method to machine, and makes bus-less device to use it during hotplug as a means to discover hotplug handler controller. Returned controller is used to permorm a hotplug action. Signed-off-by: Igor Mammedov --- hw/core/qdev.c | 13 + include/hw/board

[Qemu-devel] [PATCH v2 02/31] object_add: allow completion handler to get canonical path

2014-05-20 Thread Igor Mammedov
Add object to /objects before calling user_creatable_complete() handler, so that object might be able to call object_get_canonical_path() in its completion handler. Signed-off-by: Igor Mammedov --- qmp.c | 11 --- vl.c |9 + 2 files changed, 13 insertions(+), 7 deletions(-

[Qemu-devel] [PATCH v2 00/31] pc: ACPI memory hotplug

2014-05-20 Thread Igor Mammedov
What's new since v8: * rebased on top of Marcel's QOMyfing machine work depends on patch from qom-next: "machine: Conversion of QEMUMachineInitArgs to MachineState" * fixed QEMU abort if it's running in daemonized mode * fixed leak in memdev backend * introduced custom PCMachine * DI

[Qemu-devel] [PATCH v2 03/31] vl.c: daemonize before guest memory allocation

2014-05-20 Thread Igor Mammedov
memory allocated for guest before QEMU is daemonized and then mapped later in guest's address space after it is daemonized, leads to EPT violation and QEMU aborts. To avoid this and similar issues switch to daemonized mode early before processing applying/processing other options. Signed-off-by:

  1   2   3   >