Am 20.05.2014 um 03:03 hat Fam Zheng geschrieben: > On Mon, 05/19 16:40, Kevin Wolf wrote: > > Am 19.05.2014 um 14:24 hat Fam Zheng geschrieben: > > > We should allow testing this on tmpfs. Any cache setting in iotests > > > should try to obey $CACHEMODE. > > > > > > Signed-off-by: Fam Zheng <f...@redhat.com> > > > > Should we set _default_cache_mode=none then at least? > > Yes we should set a default. We use _default_cache_mode=writethrough > elsewhere, > why use none over writethrough here?
I think the test case set cache=none originally because it's a migration test and this is the recommended setting for migration. As long as we're on localhost, writethrough should be fine, though, so it's probably not strictly necessary. > > We should probably > > also refuse to run with unsafe. > > OK, I'll add _supported_cache_modes. Thanks. Kevin
