Re: [Qemu-devel] [PATCH 1/4] machine: conversion of QEMUMachineInitArgs to MachineState

2014-05-18 Thread Marcel Apfelbaum
On Thu, 2014-05-15 at 17:04 +0200, Markus Armbruster wrote: > Marcel Apfelbaum writes: > > > Total removal of QEMUMachineInitArgs struct. QEMUMachineInitArgs's fields > > are copied into MachineState. Removed duplicated fields from MachineState. > > > > All the other changes are only mechanical r

Re: [Qemu-devel] [PATCH 2/4] qapi: output visitor crashes qemu if it encounters a NULL value

2014-05-18 Thread Marcel Apfelbaum
On Wed, 2014-05-14 at 15:38 -0500, Michael Roth wrote: > Quoting Luiz Capitulino (2014-05-14 13:25:16) > > On Wed, 14 May 2014 20:29:37 +0300 > > Marcel Apfelbaum wrote: > > > > > On Wed, 2014-05-14 at 19:00 +0200, Andreas Färber wrote: > > > > Am 13.05.2014 21:08, schrieb Eric Blake: > > > > > O

Re: [Qemu-devel] [PATCH 1/4] machine: conversion of QEMUMachineInitArgs to MachineState

2014-05-18 Thread Marcel Apfelbaum
On Fri, 2014-05-16 at 20:38 +0200, Andreas Färber wrote: > Am 16.05.2014 18:20, schrieb Igor Mammedov: > > On Wed, 7 May 2014 17:42:57 +0300 > > Marcel Apfelbaum wrote: > > > >> Total removal of QEMUMachineInitArgs struct. QEMUMachineInitArgs's fields > >> are copied into MachineState. Removed d

Re: [Qemu-devel] OS X compile fix

2014-05-18 Thread Andreas Färber
Hi, Am 18.05.2014 01:14, schrieb Peter Bartoli: > > At the recommendation of Mark Cave-Ayland, I'm sending this patch in to > remedy a long-time Mac OS X compile issue. Define "long-time"? 2.0 compiled just fine for me on v10.5.8 with gcc-4.2. I see a number of deprecation and possibly-used-unin

Re: [Qemu-devel] [PATCH 1/4] machine: conversion of QEMUMachineInitArgs to MachineState

2014-05-18 Thread Marcel Apfelbaum
On Fri, 2014-05-16 at 20:33 +0200, Andreas Färber wrote: > Am 16.05.2014 16:39, schrieb Igor Mammedov: > > On Wed, 7 May 2014 17:42:57 +0300 > > Marcel Apfelbaum wrote: > > > >> Total removal of QEMUMachineInitArgs struct. QEMUMachineInitArgs's fields > >> are copied into MachineState. Removed d

[Qemu-devel] [PATCH v4] snapshot: fixed bdrv_get_full_backing_filename can not get correct full_backing_filename

2014-05-18 Thread Jun Li
This patch fixed bdrv_get_full_backing_filename can not calculate the correct full path name for backing_file via path_combine. Such as: create a snapshot chain: $BASE_IMG<-sn1<-sn2 backing file is : /home/wookpecker/img.qcow2 sn1 : /home/woodpecker/tmp/sn1 sn2 : /home/woodpecker/tmp/sn2 when cre

Re: [Qemu-devel] [PATCH] virtio-net: announce self by guest

2014-05-18 Thread Michael S. Tsirkin
On Fri, May 16, 2014 at 01:02:51PM +0800, Jason Wang wrote: > On 05/15/2014 05:45 PM, Michael S. Tsirkin wrote: > > On Thu, May 15, 2014 at 05:22:28PM +0800, Jason Wang wrote: > >> On 05/15/2014 04:28 PM, Michael S. Tsirkin wrote: > >>> Thanks, looks good. > >>> Some minor comments below, > >>> > >

Re: [Qemu-devel] [PATCH v4] snapshot: fixed bdrv_get_full_backing_filename can not get correct full_backing_filename

2014-05-18 Thread Jun Li
please ignore this one. On 05/18/2014 05:01 PM, Jun Li wrote: This patch fixed bdrv_get_full_backing_filename can not calculate the correct full path name for backing_file via path_combine. Such as: create a snapshot chain: $BASE_IMG<-sn1<-sn2 backing file is : /home/wookpecker/img.qcow2 sn1 :

[Qemu-devel] [PATCH v4] snapshot: fixed bdrv_get_full_backing_filename can not get correct full_backing_filename

2014-05-18 Thread Jun Li
This patch fixed bdrv_get_full_backing_filename can not calculate the correct full path name for backing_file via path_combine. Such as: create a snapshot chain: $BASE_IMG<-sn1<-sn2 backing file is : ./img.qcow2 sn1 : ./tmp/sn1 sn2 : ./tmp/sn2 when create sn2, path_combine can not got a correct p

Re: [Qemu-devel] [PATCH v3 03/16] s390: Convert debug printfs to QEMU_DPRINTF

2014-05-18 Thread Peter Crosthwaite
On Sun, May 18, 2014 at 9:03 AM, Marc Marí wrote: > Modify debug macros to have the same format through the codebase and use > regular > ifs instead of ifdef. > > Signed-off-by: Marc Marí > --- > hw/s390x/s390-virtio-bus.c |9 + > hw/s390x/s390-virtio.c |9 + > targe

Re: [Qemu-devel] [PATCH v1 2/3] memory: Add sysbus memory device

2014-05-18 Thread Peter Crosthwaite
On Wed, Apr 16, 2014 at 10:24 PM, Alexander Graf wrote: > > On 15.04.14 04:21, Peter Crosthwaite wrote: >> >> Add a sysbus device consisting of a single ram. This allows for >> instantiation of RAM just like any other device. There are a number >> of good reasons to want to do this this: >> >> 1:

Re: [Qemu-devel] [PATCH v3] snapshot: fixed bdrv_get_full_backing_filename can not get correct full_backing_filename

2014-05-18 Thread Jun Li
On 05/12/2014 11:15 PM, Eric Blake wrote: On 05/10/2014 10:35 AM, Jun Li wrote: From: Jun Li I see three different "[PATCH v3]" mails with this subject. To make sure we are reviewing the right version, it might help to bump to version 4. Yes, I have send v4 of this patch and changed the com

[Qemu-devel] [PATCH 1/2] nbd: Don't export a block device with no medium.

2014-05-18 Thread Hani Benhabiles
The device is exported with erroneous values and can't be read. Before the patch: $ sudo nbd-client localhost -p 10809 /dev/nbd0 -name floppy0 Negotiation: ..size = 17592186044415MB bs=1024, sz=18446744073709547520 bytes $ sudo mount /dev/nbd0 /mnt/tmp/ mount: block device /dev/nbd0 is write-prot

[Qemu-devel] [PATCH 2/2] nbd: Don't validate from and len in NBD_CMD_DISC.

2014-05-18 Thread Hani Benhabiles
These values aren't used in this case. Currently, the from field in the request sent by the nbd kernel module leading to a false error message when ending the connection with the client. $ qemu-nbd some.img -v // After nbd-client -d /dev/nbd0 nbd.c:nbd_trip():L1031: From: 18446744073709551104, Le

Re: [Qemu-devel] [Qemu-trivial] [PATCH] arch_init: Simplify code for load_xbzrle()

2014-05-18 Thread Chen Gang
On 05/17/2014 03:54 PM, Michael Tokarev wrote: > 10.05.2014 16:51, Chen Gang wrote: >> For xbzrle_decode_buffer(), when decoding contents will exceed writing >> buffer, it will return -1, so need not check the return value whether >> large than writing buffer. >> >> And when failure occurs within l

Re: [Qemu-devel] OS X compile fix

2014-05-18 Thread Peter Maydell
On 18 May 2014 09:50, Andreas Färber wrote: > Am 18.05.2014 01:14, schrieb Peter Bartoli: >> At the recommendation of Mark Cave-Ayland, I'm sending this patch in to >> remedy a long-time Mac OS X compile issue. > > Define "long-time"? 2.0 compiled just fine for me on v10.5.8 with > gcc-4.2. I see

Re: [Qemu-devel] [PATCH v12 4/4] qapi: Add a primitive to include other files from a QAPI schema file

2014-05-18 Thread Peter Maydell
On 7 May 2014 19:46, Lluís Vilanova wrote: > The primitive uses JSON syntax, and include paths are relative to the file > using the directive: > > { 'include': 'path/to/file.json' } > > Signed-off-by: Lluís Vilanova > Reviewed-by: Eric Blake > Reviewed-by: Markus Armbruster > @@ -74,10 +91,

[Qemu-devel] [PATCH] macio: handle non-block ATAPI DMA transfers

2014-05-18 Thread Mark Cave-Ayland
Currently the macio DMA routines assume that all DMA requests are for read/write block transfers. This is not always the case for ATAPI, for example when requesting a TOC where the response is generated directly in the IDE buffer. Detect these non-block ATAPI DMA transfers (where no lba is specifi

[Qemu-devel] target-sparc has inverse cwp logic for SAVE/RESTORE?

2014-05-18 Thread Mark Cave-Ayland
Hi all, I've been working on debugging a window-related OpenBIOS issue and noticed that the cwp register logic in QEMU appears to be backwards according to the SPARCv9 specification. From sections 6.3.6.1 and 6.3.6.2: "The SAVE instruction allocates a new register window and saves the caller

Re: [Qemu-devel] [PATCH v2] kvmclock: Ensure time in migration never goes backward

2014-05-18 Thread Marcelo Tosatti
On Fri, May 16, 2014 at 05:15:21PM +0200, Alexander Graf wrote: > When we migrate we ask the kernel about its current belief on what the guest > time would be. However, I've seen cases where the kvmclock guest structure > indicates a time more recent than the kvm returned time. > > To make sure we

Re: [Qemu-devel] target-sparc has inverse cwp logic for SAVE/RESTORE?

2014-05-18 Thread Olivier Danet
On 18/05/2014 14:48, Mark Cave-Ayland wrote: > Hi all, > > I've been working on debugging a window-related OpenBIOS issue and noticed > that the cwp register logic in QEMU appears to be backwards according to the > SPARCv9 specification. From sections 6.3.6.1 and 6.3.6.2: > > "The SAVE instruct

Re: [Qemu-devel] [PULL 00/10] input layer rework continued

2014-05-18 Thread Olivier Danet
On 16/05/2014 08:47, Gerd Hoffmann wrote: > Hi, > > Update for the input layer. Add keycode mapping helpers, > start switching over devices to the new input api, fixes. > > please pull, > Gerd > > The following changes since commit 1a381811b495651ddfc2b50d7c8cfaaf375816b0: > > Merge remo

Re: [Qemu-devel] [Bug 1320360] [NEW] usb passthrough not working anymore

2014-05-18 Thread Martin Röh
Hi, as far as I can see from the rpm specs of the opensuse rpm package the --enable-libusb is set . Regards Martin Am 18.05.2014 06:52, schrieb Gonglei (Arei): Hi, From qemu-1.7 release version, the old usb-host(host-linux.c) had been removed, re-implemented by libusbx. So you should buil

Re: [Qemu-devel] [Bug 1320360] [NEW] usb passthrough not working anymore

2014-05-18 Thread Martin Röh
Hi, if I try to start the vm by virt-manager I get this detailed error log: Fehler beim Starten der Domain: internal error: early end of file from monitor: possible problem: qemu-system-x86_64: -device usb-host,hostbus=1,hostaddr=3,id=hostdev0: 'usb-host' is not a valid device model name Tr

Re: [Qemu-devel] [Bug 1320360] Re: usb passthrough not working anymore

2014-05-18 Thread Martin Röh
The command line is /usr/bin/qemu-system-x86_64 -machine accel=kvm -name win8 -S -machine pc-i440fx-2.0,accel=kvm,usb=off -cpu Nehalem -m 2048 -realtime mlock=off -smp 2,sockets=2,cores=1,threads=1 -uuid 424ca5ec-2fb4-4d1c-84c4-25b92d468b8e -no-user-config -nodefaults -chardev socket,id=charm

Re: [Qemu-devel] OS X compile fix

2014-05-18 Thread Peter Bartoli
On May 18, 2014, at 4:40 AM, Peter Maydell wrote: > On 18 May 2014 09:50, Andreas Färber wrote: >> Am 18.05.2014 01:14, schrieb Peter Bartoli: >>> At the recommendation of Mark Cave-Ayland, I'm sending this patch in to >>> remedy a long-time Mac OS X compile issue. >> >> Define "long-time"? 2.0

Re: [Qemu-devel] OS X compile fix

2014-05-18 Thread Peter Maydell
On 18 May 2014 23:45, Peter Bartoli wrote: > So, just to add, in case it's helpful, "long time" means since 2012-ish, when > QEMU first came to my attention. I'm almost always running the current > version of Mac OS X on the only system I'm running QEMU on, and have always > had to use that pa

Re: [Qemu-devel] OS X compile fix

2014-05-18 Thread Peter Bartoli
On May 18, 2014, at 4:09 PM, Peter Maydell wrote: > and looking at the preprocessor output it's defined in > /usr/lib/clang/5.0/include/limits.h Thanks, Peter ... I don't have a /usr/lib/clang ... where are you getting it from? -peter

Re: [Qemu-devel] [Xen-devel] [v2][PATCH 6/8] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2014-05-18 Thread Zhang, Yang Z
Konrad Rzeszutek Wilk wrote on 2014-05-16: > On Fri, May 16, 2014 at 06:53:42PM +0800, Tiejun Chen wrote: > > Some registers of Intel IGD are mapped in host bridge, so it needs to > > passthrough these registers of physical host bridge to guest because > > emulated host bridge in guest doesn't have

Re: [Qemu-devel] [Bug 1320360] [NEW] usb passthrough not working anymore

2014-05-18 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Martin Röh [mailto:mar...@roeh.org] > Sent: Monday, May 19, 2014 4:40 AM > To: Gonglei (Arei); Bug 1320360; qemu-devel@nongnu.org > Cc: Gerd Hoffmann > Subject: Re: [Qemu-devel] [Bug 1320360] [NEW] usb passthrough not working > anymore > > Hi, > > if I tr

Re: [Qemu-devel] [RFC v1 11/25] irq: Slim conversion of qemu_irq to QOM [WIP]

2014-05-18 Thread Peter Crosthwaite
On Fri, May 16, 2014 at 11:56 AM, Peter Crosthwaite wrote: > From: Andreas Färber > > As a prequel to any big Pin refactoring plans, do an in-place conversion > of qemu_irq to an Object, so that we can reference it in link<> properties. > > Signed-off-by: Andreas Färber > --- > > hw/core/irq.c

Re: [Qemu-devel] [RFC v1 17/25] sysbus: Use TYPE_DEVICE GPIO functionality

2014-05-18 Thread Peter Crosthwaite
On Fri, May 16, 2014 at 11:59 AM, Peter Crosthwaite wrote: > Re-implement the Sysbus GPIOs to use the existing TYPE_DEVICE > GPIO named framework. A constant string name is chosen to avoid > conflicts with existing unnamed GPIOs. > > This unifies GPIOs are IRQs for sysbus devices and allows remova

Re: [Qemu-devel] [PATCH V26 00/32] replace QEMUOptionParameter with QemuOpts

2014-05-18 Thread Chun Yan Liu
>>> On 5/6/2014 at 09:26 PM, in message <20140506132615.gv15...@stefanha-thinkpad.redhat.com>, Stefan Hajnoczi wrote: > On Tue, Apr 29, 2014 at 05:10:24PM +0800, Chunyan Liu wrote: > > This patch series is to replace QEMUOptionParameter with QemuOpts, so that > only > > one Qemu Option stru

Re: [Qemu-devel] [PATCH 8/9] spapr: Implement processor compatibility in ibm, client-architecture-support

2014-05-18 Thread Alexey Kardashevskiy
On 05/17/2014 11:45 AM, Alexey Kardashevskiy wrote: > On 05/17/2014 06:46 AM, Alexander Graf wrote: >> >> On 16.05.14 17:57, Alexey Kardashevskiy wrote: >>> On 05/17/2014 12:16 AM, Alexander Graf wrote: On 15.05.14 13:28, Alexey Kardashevskiy wrote: > Modern Linux kernels support last POWE

Re: [Qemu-devel] [Qemu-ppc] [PATCH 6/9] spapr: Add ibm, client-architecture-support call

2014-05-18 Thread Nikunj A Dadhania
Alexey Kardashevskiy writes: > The PAPR+ specification defines a ibm,client-architecture-support (CAS) > RTAS call which purpose is to provide a negotiation mechanism for > the guest and the hypervisor to work out the best compatibility parameters. > During the negotiation process, the guest prov

Re: [Qemu-devel] [Bug 1320360] [NEW] usb passthrough not working anymore

2014-05-18 Thread Gerd Hoffmann
On So, 2014-05-18 at 22:36 +0200, Martin Röh wrote: > Hi, > > as far as I can see from the rpm specs of the opensuse rpm package the > --enable-libusb is set . > > BTW, Gerd, should we enable libusb by default now? Thanks. By default libusb will be used when found on the system. When it isn't t

Re: [Qemu-devel] [PATCH] configure: Automatically select GTK+ 3.0 if GTK+ 2.0 is unavailable

2014-05-18 Thread Gerd Hoffmann
Hi, > +if test "$gtkabi" = ""; then > +# The GTK ABI was not specified explicitly, so try whether 2.0 is > available. > +# Use 3.0 as a fallback if that is available. > +if $pkg_config --exists "gtk+-2.0 >= 2.18.0"; then > +gtkabi=2.0 > +elif $pkg_config --exists "gtk+-3

[Qemu-devel] [PATCH] virtio-balloon: return empty data when no stats are available

2014-05-18 Thread Ján Tomko
If the guest hasn't updated the stats yet, instead of returning an error, return '-1' for the stats and '0' as 'last-update'. This lets applications ignore this without parsing the error message. Related libvirt patch and discussion: https://www.redhat.com/archives/libvir-list/2014-May/msg00460.h

Re: [Qemu-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD

2014-05-18 Thread Gerd Hoffmann
Hi, > +/* > + * Some video bioses and gfx drivers will assume the bdf of IGD is > 00:02.0. > + * So user need to set it to 00:02.0 in Xen configure file explicitly, > + * otherwise IGD will fail to work. > + */ > +pci_reserve_pci_devfn(b, PCI_DEVFN(2, 0)); That is askin

Re: [Qemu-devel] [libvirt] [PATCHv2] Don't log an internal error when the guest hasn't updated balloon stats

2014-05-18 Thread Ján Tomko
On 05/16/2014 03:13 PM, Luiz Capitulino wrote: > On Fri, 16 May 2014 00:11:24 -0600 > Eric Blake wrote: > >>> Is "no stats yet" really an error? > > This is a special case where the guest hasn't ever filled QEMU with balloon > stats. There are two possible cases. Either the guest hasn't done it