On Fri, 2014-05-16 at 20:38 +0200, Andreas Färber wrote: > Am 16.05.2014 18:20, schrieb Igor Mammedov: > > On Wed, 7 May 2014 17:42:57 +0300 > > Marcel Apfelbaum <marce...@redhat.com> wrote: > > > >> Total removal of QEMUMachineInitArgs struct. QEMUMachineInitArgs's fields > >> are copied into MachineState. Removed duplicated fields from MachineState. > >> > >> All the other changes are only mechanical refactoring, no semantic changes. > >> > >> Signed-off-by: Marcel Apfelbaum <marce...@redhat.com> > >> --- > >> - I am perfectly aware that patches touching a lot of files > >> are not desirable, but this one is a very simple replacement > >> patch: > >> QEMUMachineInitArgs -> MachineState > >> args -> ms > >> - This is the simplest way to get rid of QEMUMachineInitArgs fast. > >> > > One more thing: > > pc_q35_init() and pc_init1() both use qdev_get_machine() for adding > > properties. Please replace it with passed in machine. > > For the previous series we had clarified that qdev_get_machine() can > safely be used. The benefit of passing "machine" would be efficiency of > machine init only, so let's just do that as a follow-up cleanup please.
Fine by me. Thanks, Marcel > > Regards, > Andreas >
