Re: [Qemu-devel] [Bug] cirrus_vga: qemu abort at booting when configure vgamem_mb <= 2

2014-05-09 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Friday, May 09, 2014 2:49 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org > Subject: Re: [Bug] cirrus_vga: qemu abort at booting when configure > vgamem_mb <= 2 > > On Fr, 2014-05-09 at 03:47 +, Gong

Re: [Qemu-devel] [PATCH] spapr: pci: clean msi info when releasing it

2014-05-09 Thread liu ping fan
On Wed, May 7, 2014 at 3:20 PM, Alexey Kardashevskiy wrote: > On 05/07/2014 04:51 PM, Liu Ping Fan wrote: >> In current code, we use phb->msi_table[ndev].nvec to indicate whether >> this msi entries are used by a device or not. So when unplug a pci >> device, we should reset nvec to zero. >> >> Si

Re: [Qemu-devel] [PATCH 1/5] xen, gfx passthrough: basic graphics passthrough support

2014-05-09 Thread Zhang, Yang Z
Anthony PERARD wrote on 2014-03-22: > On Fri, Feb 21, 2014 at 02:44:09PM +0800, Yang Zhang wrote: >> From: Yang Zhang >> >> basic gfx passthrough support: >> - add a vga type for gfx passthrough >> - retrieve VGA bios from host 0xC, then load it to guest 0xC >> - register/unregister legac

Re: [Qemu-devel] [PATCH v2] block/raw-posix: Try both FIEMAP and SEEK_HOLE

2014-05-09 Thread Paolo Bonzini
Il 06/05/2014 21:00, Max Reitz ha scritto: The current version of raw-posix always uses ioctl(FS_IOC_FIEMAP) if FIEMAP is available; lseek with SEEK_HOLE/SEEK_DATA are not even compiled in in this case. However, there may be implementations which support the latter but not the former (e.g., NFSv4

[Qemu-devel] [PATCH] kvm: make one_reg helpers available for everyone

2014-05-09 Thread Cornelia Huck
s390x introduced helper functions for getting/setting one_regs with commit 860643bc. However, nothing about these is s390-specific. Alexey Kardashevskiy had already posted a general version, so let's merge the two patches and massage the code a bit. CC: Alexey Kardashevskiy Signed-off-by: Cornel

Re: [Qemu-devel] [Bug 1317090] Re: qemu fails on ELF files with no section headers

2014-05-09 Thread Riku Voipio
Hi Craig, On Wed, May 07, 2014 at 03:53:38PM +0100, Peter Maydell wrote: > On 7 May 2014 15:48, Peter Maydell wrote: > > On 7 May 2014 15:34, Paul Jimenez <1317...@bugs.launchpad.net> wrote: > >> Bug description: > >> Using the latest version of qemu-user-static from trusty, 2.0.0+dfsg- > >>

Re: [Qemu-devel] [PATCH] block: Fix open flags with BDRV_O_SNAPSHOT

2014-05-09 Thread Stefan Hajnoczi
On Wed, May 07, 2014 at 10:24:21AM +0200, Kevin Wolf wrote: > Perhaps the monitor should be changed to avoid printing so many useless > control characters, then we'd hit the limit less often... > > Stefan, didn't you plan to do something like this? Or was it unrelated? I encountered this when wor

Re: [Qemu-devel] [RFC] vhost: Can we change synchronize_rcu to call_rcu in vhost_set_memory() in vhost kernel module?

2014-05-09 Thread Paolo Bonzini
Il 09/05/2014 03:57, Gonglei (Arei) ha scritto: Hi, Vhost devices need to do VHOST_SET_MEM_TABLE ioctl in vhost_dev_start() to tell vhost kernel modules GPA to HVA memory mappings, which consume is expensively. The reason is same as KVM_SET_GSI_ROUTING ioctl. That is, in ioctl processing, kmod

Re: [Qemu-devel] [PATCH v3 18/25] rbd: use BlockDriverState's AioContext

2014-05-09 Thread Paolo Bonzini
Il 09/05/2014 02:04, Josh Durgin ha scritto: On 05/08/2014 07:34 AM, Stefan Hajnoczi wrote: Drop the assumption that we're using the main AioContext. Convert qemu_bh_new() to aio_bh_new() and qemu_aio_wait() to aio_poll(). The .bdrv_detach_aio_context() and .bdrv_attach_aio_context() interface

Re: [Qemu-devel] [PATCH] linux-user: Return correct errno for unsupported netlink socket

2014-05-09 Thread Riku Voipio
Hi, On Mon, May 05, 2014 at 08:04:45PM -0700, Ed Swierk wrote: > This fixes "Cannot open audit interface - aborting." when the > EAFNOSUPPORT errno differs between the target and host > architectures (e.g. mips target and x86_64 host). Thanks, looks good - applied to linux-user tree. > Signed-of

Re: [Qemu-devel] virtio-serial-pci very expensive during live migration

2014-05-09 Thread Paolo Bonzini
Il 09/05/2014 02:53, Chris Friesen ha scritto: Turns out I spoke too soon. With the patch applied, it boots, but if I try to do a live migration both the source and destination crash. This happens for both the master branch as well as the stable-1.4 branch. The destination doesn't crash, it

Re: [Qemu-devel] [RFC] dataplane: IOThreads and writing dataplane-capable code

2014-05-09 Thread Stefan Hajnoczi
On Thu, May 08, 2014 at 07:58:11PM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@gmail.com) wrote: > > On Thu, May 8, 2014 at 3:44 PM, Dr. David Alan Gilbert > > wrote: > > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > > > > > > > > > >> How to synchronize with an IO

Re: [Qemu-devel] [PATCH v3 18/25] rbd: use BlockDriverState's AioContext

2014-05-09 Thread Stefan Hajnoczi
On Thu, May 08, 2014 at 05:04:16PM -0700, Josh Durgin wrote: > On 05/08/2014 07:34 AM, Stefan Hajnoczi wrote: > >Drop the assumption that we're using the main AioContext. Convert > >qemu_bh_new() to aio_bh_new() and qemu_aio_wait() to aio_poll(). > > > >The .bdrv_detach_aio_context() and .bdrv_att

Re: [Qemu-devel] [Bug 1317090] Re: qemu fails on ELF files with no section headers

2014-05-09 Thread Peter Maydell
On 9 May 2014 09:14, Riku Voipio wrote: > Hi Craig, > > On Wed, May 07, 2014 at 03:53:38PM +0100, Peter Maydell wrote: >> Original 2011 patch: >> http://lists.gnu.org/archive/html/qemu-trivial/2011-12/msg00025.html > >> (hitting the 'reply' button gets us back the original email >> address to fix

Re: [Qemu-devel] [PATCH v3.1 00/31] NUMA series, and hostmem improvements

2014-05-09 Thread Hu Tao
On Thu, May 08, 2014 at 04:51:56PM +0200, Paolo Bonzini wrote: > Il 06/05/2014 11:27, Hu Tao ha scritto: > > This series includes work on QOMifying the memory backends. > > the idea is to delegate all properties of the memory backend to > > a new QOM class hierarchy, in which the concrete classes >

Re: [Qemu-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Ian Campbell [mailto:ian.campb...@citrix.com] > Sent: Thursday, May 08, 2014 7:22 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; jbeul...@suse.com; > stefano.stabell...@eu.citrix.com; fabio.fant...@m2r.biz; > anthony.per...@ci

Re: [Qemu-devel] [PATCH] spapr: pci: clean msi info when releasing it

2014-05-09 Thread Alexey Kardashevskiy
On 05/09/2014 05:04 PM, liu ping fan wrote: > On Wed, May 7, 2014 at 3:20 PM, Alexey Kardashevskiy wrote: >> On 05/07/2014 04:51 PM, Liu Ping Fan wrote: >>> In current code, we use phb->msi_table[ndev].nvec to indicate whether >>> this msi entries are used by a device or not. So when unplug a pci

[Qemu-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread arei.gonglei
From: Gonglei In Xen platform, after using upstream qemu, the all of pci devices will show hotplug in the windows guest, no matter whether they can be hotpluged. It is unfriendly. The PCI devices that can not be hotpluged are hidden by modifing the DSDT entries of PCI slots when runtime. This is

Re: [Qemu-devel] QEMU build broken

2014-05-09 Thread Riku Voipio
Hi, On 8 May 2014 17:54, Peter Maydell wrote: > On 8 May 2014 15:47, Brad Smith wrote: > > The following commit broke the build of QEMU.. > > > > linux-user: remove configure option for setting uname release > > > > > http://git.qemu.org/?p=qemu.git;a=commit;h=e586822a58b6609edb5ea929e8a4aa394d

[Qemu-devel] [BUG] 50MB/min logspam: dma: unregistered DMA channel used nchan=0 dma_pos=0 dma_len=1

2014-05-09 Thread Philipp Hahn
Hello, a Xen-4.1-3 host system filled its log file with the message dma: unregistered DMA channel used nchan=0 dma_pos=0 dma_len=1 The happened two times was a Windows Server 2003 with GPLPV 0.11.0.372: one VM was migrated to that host and one was directly started there. After a restart of the V

Re: [Qemu-devel] [Bug 1317090] Re: qemu fails on ELF files with no section headers

2014-05-09 Thread Riku Voipio
On Fri, May 09, 2014 at 09:20:54AM +0100, Peter Maydell wrote: > On 9 May 2014 09:14, Riku Voipio wrote: > > Hi Craig, > > > > On Wed, May 07, 2014 at 03:53:38PM +0100, Peter Maydell wrote: > >> Original 2011 patch: > >> http://lists.gnu.org/archive/html/qemu-trivial/2011-12/msg00025.html > > > >>

Re: [Qemu-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Ian Campbell
On Fri, 2014-05-09 at 08:38 +, Gonglei (Arei) wrote: > > > This is done by runtime patching: > > > > Which appears to involve an awful lot of jumping through hoops... Please > > can you explain why it is necessary, as opposed to e.g. using a dynamic > > set of SSDTs? > > > Ok, we will delete

Re: [Qemu-devel] [RFC] vhost: Can we change synchronize_rcu to call_rcu in vhost_set_memory() in vhost kernel module?

2014-05-09 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Friday, May 09, 2014 4:15 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: m...@redhat.com; Herongguang (Stephen); Huangweidong (C) > Subject: Re: [RFC] vhost: Can we change synchronize_rcu to call_rcu

Re: [Qemu-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Gonglei (Arei)
Hi, Ian > -Original Message- > From: Ian Campbell [mailto:ian.campb...@citrix.com] > Sent: Friday, May 09, 2014 5:05 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; jbeul...@suse.com; > stefano.stabell...@eu.citrix.com; fabio.fant...@m2r.biz; > anthony.per...@

Re: [Qemu-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Jan Beulich
>>> On 09.05.14 at 10:47, wrote: > From: Gonglei > > In Xen platform, after using upstream qemu, the all of pci devices > will show hotplug in the windows guest, no matter whether they can > be hotpluged. It is unfriendly. The PCI devices that can not be > hotpluged are hidden by modifing the DS

Re: [Qemu-devel] Question about RAM migration flags

2014-05-09 Thread Dr. David Alan Gilbert
* Peter Lieven (p...@kamp.de) wrote: > Hi, > > while working on ram migration and reading through the code I realized that > qemu does not stop loading a saved VM or rejecting an incoming migration > if there is a flag in the stream that it does not understand. An unknown flag > is simply ignored.

Re: [Qemu-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Gonglei (Arei)
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Friday, May 09, 2014 5:36 PM > To: Gonglei (Arei) > Cc: anthony.per...@citrix.com; ian.campb...@citrix.com; > stefano.stabell...@eu.citrix.com; johannes.kra...@googlemail.com; Gaowei > (UVP); Hanweidong (Randy); Hu

[Qemu-devel] [PATCH 2/5] block: New bdrv_nb_sectors()

2014-05-09 Thread Markus Armbruster
A call to retrieve the image size converts between bytes and sectors several times: * BlockDriver method bdrv_getlength() returns bytes. * refresh_total_sectors() converts to sectors, rounding up, and stores in total_sectors. * bdrv_getlength() converts total_sectors back to bytes (now rounded

[Qemu-devel] [PATCH 0/5] Clean up around bdrv_getlength()

2014-05-09 Thread Markus Armbruster
Issues addressed in this series: * BlockDriver method bdrv_getlength() generally returns -errno, but some implementations return -1 instead. Fix them [PATCH 1]. * Frequent conversions between sectors and bytes complicate the code needlessly. Clean up some [PATCH 2+3]. * bdrv_getlength() al

[Qemu-devel] [PATCH 5/5] block: Avoid bdrv_get_geometry() where errors should be detected

2014-05-09 Thread Markus Armbruster
bdrv_get_geometry() hides errors. Use bdrv_nb_sectors() or bdrv_getlength() instead where that's obviously inappropriate. Signed-off-by: Markus Armbruster --- block.c | 11 +--- block/qapi.c | 14 +++--- qemu-img.c | 85 +---

[Qemu-devel] [PATCH 1/5] raw-posix: Fix raw_getlength() to always return -errno on error

2014-05-09 Thread Markus Armbruster
We got a merry mix of -1 and -errno here. Signed-off-by: Markus Armbruster --- block/raw-posix.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 3ce026d..9bf06e5 100644 --- a/block/raw-posix.c +++ b/blo

[Qemu-devel] [PATCH 4/5] block: Drop superfluous aligning of bdrv_getlength()'s value

2014-05-09 Thread Markus Armbruster
It returns a multiple of the sector size. Signed-off-by: Markus Armbruster --- block.c | 1 - block/qcow2.c | 1 - 2 files changed, 2 deletions(-) diff --git a/block.c b/block.c index 1b99cb1..89cab7c 100644 --- a/block.c +++ b/block.c @@ -1228,7 +1228,6 @@ void bdrv_append_temp_snapshot(

Re: [Qemu-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Jan Beulich
>>> On 09.05.14 at 11:45, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> And it also seem pretty pointless to send a v4 without addressing >> all comments you got on v3. >> > I don't think so. I have absorbed Ian's all suggestion on v3. And for other > questions have been answered too

[Qemu-devel] [PATCH 3/5] block: Use bdrv_nb_sectors() when sectors, not bytes are wanted

2014-05-09 Thread Markus Armbruster
Instead of bdrv_nb_sectors(). Aside: a few of these callers don't handle errors. I didn't investigate whether they should. Signed-off-by: Markus Armbruster --- block-migration.c | 9 - block.c | 40 ++-- block/qcow2.c | 2 +- block/vm

Re: [Qemu-devel] [RFC] vhost: Can we change synchronize_rcu to call_rcu in vhost_set_memory() in vhost kernel module?

2014-05-09 Thread Paolo Bonzini
Il 09/05/2014 11:04, Gonglei (Arei) ha scritto: > Yes, for example enabling/disabling PCI BARs would have that effect. > Yes, but PCI BARs are mapped in PCI hole, and they are not overlapped with ram memory regions, so disable or enable PCI BARs would not change ram MRs' mapping. PCI BARs can

Re: [Qemu-devel] QEMU build broken

2014-05-09 Thread Peter Maydell
On 9 May 2014 09:57, Riku Voipio wrote: > On 8 May 2014 17:54, Peter Maydell wrote: >> Ah, bsd-user. Do you actually use it, or is it just >> in the default compile that you're running? > One year since last bsd-user specific patch, I take we need a new > maintainer for bsd-user? Perhaps so. S

Re: [Qemu-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Ian Campbell
On Fri, 2014-05-09 at 09:45 +, Gonglei (Arei) wrote: > > And it also seem pretty pointless to send a v4 without addressing > > all comments you got on v3. > > > I don't think so. I have absorbed Ian's all suggestion on v3. And for other > questions have been answered too, in despite of is me

[Qemu-devel] [PATCH] gluster: Correctly propagate errors when volume isn't accessible

2014-05-09 Thread Peter Krempa
The docs for glfs_init suggest that the function sets errno on every failure. In fact it doesn't. As other functions such as qemu_gluster_open() in the gluster block code report their errors based on this fact we need to make sure that errno is set on each failure. This fixes a crash of qemu-img/q

Re: [Qemu-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Gonglei (Arei)
Hi, First, please forgive me for my bad English. It's so sad. > -Original Message- > From: Ian Campbell [mailto:ian.campb...@citrix.com] > Sent: Friday, May 09, 2014 5:57 PM > To: Gonglei (Arei) > Cc: Jan Beulich; xen-de...@lists.xen.org; anthony.per...@citrix.com; > stefano.stabell...@e

[Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread arei.gonglei
From: Gonglei when configure a invalid vram size for cirrus card, such as less 2 MB, which will crash qemu. Follow the real hardware, the cirrus card has 4 MB video memory. Also for backward compatibility, accept 8 MB and 16 MB vram size. Signed-off-by: Gonglei --- For isa cirrus vga device, it

Re: [Qemu-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Ian Campbell
On Fri, 2014-05-09 at 10:15 +, Gonglei (Arei) wrote: > Hi, > > First, please forgive me for my bad English. > It's so sad. > > > -Original Message- > > From: Ian Campbell [mailto:ian.campb...@citrix.com] > > Sent: Friday, May 09, 2014 5:57 PM > > To: Gonglei (Arei) > > Cc: Jan Beulic

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size [checkpatch false positive?]

2014-05-09 Thread Gerd Hoffmann
On Fr, 2014-05-09 at 18:21 +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > when configure a invalid vram size for cirrus card, such as less > 2 MB, which will crash qemu. Follow the real hardware, the cirrus > card has 4 MB video memory. Also for backward compatibility, accept > 8 MB an

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size [checkpatch false positive?]

2014-05-09 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Friday, May 09, 2014 6:31 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; afaer...@suse.de; m...@redhat.com; > pbonz...@redhat.com; Huangweidong (C); Blue Swirl > Subject: Re: [PATCH] cirrus_vga: adding

[Qemu-devel] [PATCH] Split ram_save_block

2014-05-09 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" ram_save_block is getting a bit too complicated, and does two separate things: 1) Finds a page to send 2) Sends the page (dealing with compression etc) Split into 'ram_save_page' to send the page and deal with compression (2) Rename remaining function to 'ram

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size [checkpatch false positive?]

2014-05-09 Thread Gerd Hoffmann
Hi, > BTW, what's your opinion about isa cirrus vga device, Gerd? I'd do the same check there. cheers, Gerd

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size [checkpatch false positive?]

2014-05-09 Thread Gonglei (Arei)
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Friday, May 09, 2014 6:55 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; afaer...@suse.de; m...@redhat.com; > pbonz...@redhat.com; Huangweidong (C); Blue Swirl > Subject: Re: [PATCH] cirrus_vga: adding sani

[Qemu-devel] [PATCH v2] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread arei.gonglei
From: Gonglei when configure a invalid vram size for cirrus card, such as less 2 MB, which will crash qemu. Follow the real hardware, the cirrus card has 4 MB video memory. Also for backward compatibility, accept 8 MB and 16 MB vram size. Signed-off-by: Gonglei --- v2: fix checkpatch fails. "

Re: [Qemu-devel] [PATCH v2] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread Michael Tokarev
09.05.2014 15:04, arei.gong...@huawei.com wrote: > From: Gonglei > > when configure a invalid vram size for cirrus card, such as less > 2 MB, which will crash qemu. Follow the real hardware, the cirrus > card has 4 MB video memory. Also for backward compatibility, accept > 8 MB and 16 MB vram siz

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread Dr. David Alan Gilbert
* arei.gong...@huawei.com (arei.gong...@huawei.com) wrote: > From: Gonglei > > when configure a invalid vram size for cirrus card, such as less > 2 MB, which will crash qemu. Follow the real hardware, the cirrus > card has 4 MB video memory. Also for backward compatibility, accept > 8 MB and 16 M

Re: [Qemu-devel] [PULL 0/9] Tracing patches

2014-05-09 Thread Peter Maydell
On 7 May 2014 18:16, Stefan Hajnoczi wrote: > I forgot to open the QEMU 2.1 tracing queue. Let's get started! > > The following changes since commit 9898370497da3f18e0c9555b65c858eabc78ab50: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-smbios-2' into > staging (2014-05-06 12:23:0

Re: [Qemu-devel] [PATCH] gluster: Correctly propagate errors when volume isn't accessible

2014-05-09 Thread Stefan Hajnoczi
On Fri, May 09, 2014 at 12:08:10PM +0200, Peter Krempa wrote: > The docs for glfs_init suggest that the function sets errno on every > failure. In fact it doesn't. As other functions such as > qemu_gluster_open() in the gluster block code report their errors based > on this fact we need to make sur

Re: [Qemu-devel] [PATCH v2] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread Andreas Färber
Am 09.05.2014 13:04, schrieb arei.gong...@huawei.com: > From: Gonglei > > when configure a invalid vram size for cirrus card, such as less > 2 MB, which will crash qemu. Follow the real hardware, the cirrus > card has 4 MB video memory. Also for backward compatibility, accept > 8 MB and 16 MB vra

Re: [Qemu-devel] QEMU 2.1 release schedule?

2014-05-09 Thread Peter Maydell
On 9 May 2014 02:07, Michael Roth wrote: > Quoting Peter Maydell (2014-05-08 08:48:01) >> Paolo suggested on IRC: >> >> > soft freeze mid june, hard freeze beginning of july, >> > release end of july or beginning of august? >> >> Which works for me. Some concrete dates: >> * 17 June: softfreeze a

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread Andreas Färber
Am 09.05.2014 12:59, schrieb Gonglei (Arei): >> -Original Message- >> From: Gerd Hoffmann [mailto:kra...@redhat.com] >> Sent: Friday, May 09, 2014 6:55 PM >> To: Gonglei (Arei) >> Cc: qemu-devel@nongnu.org; afaer...@suse.de; m...@redhat.com; >> pbonz...@redhat.com; Huangweidong (C); Blue Sw

Re: [Qemu-devel] [PATCH] kvmclock: Ensure time in migration never goes backward

2014-05-09 Thread Paolo Bonzini
Il 09/05/2014 04:28, Marcelo Tosatti ha scritto: Alex, Unability to upgrade systems is not an excuse to fix the bug in the wrong place. It may be an excuse to fix the bug in both places though. Paolo

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread Gerd Hoffmann
Hi, > virt-manager/libvirt seems to default to 9 MByte of Vram for cirrus, > so this would break a lot of setups. It wouldn't. libvirt sticks that into the xml, but it doesn't set any qemu parameters. The libvirt parameter actually predates the qemu property for setting the size. > Looking a

Re: [Qemu-devel] [PULL 00/38] QMP queue

2014-05-09 Thread Peter Maydell
On 8 May 2014 19:52, Luiz Capitulino wrote: > The following changes since commit 6b342cc9c872e82620fdd32730cd92affa8a19b3: > > Merge remote-tracking branch 'remotes/spice/tags/pull-spice-7' into staging > (2014-05-08 10:57:25 +0100) > > are available in the git repository at: > > > git://repo

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > Hi, > > > virt-manager/libvirt seems to default to 9 MByte of Vram for cirrus, > > so this would break a lot of setups. > > It wouldn't. libvirt sticks that into the xml, but it doesn't set any > qemu parameters. The libvirt parameter actually pred

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread Paolo Bonzini
Il 09/05/2014 13:18, Dr. David Alan Gilbert ha scritto: * arei.gong...@huawei.com (arei.gong...@huawei.com) wrote: From: Gonglei when configure a invalid vram size for cirrus card, such as less 2 MB, which will crash qemu. Follow the real hardware, the cirrus card has 4 MB video memory. Also f

Re: [Qemu-devel] [PATCH 1/6] xics: add flags for interrupts

2014-05-09 Thread Mike Day
On Thu, May 8, 2014 at 11:12 PM, Alexey Kardashevskiy wrote: >> There are >> a couple ways to mitigate this type of situation by using alternative >> data structures to inform the loop traversal. I don't know if it is >> worth the effort, though. > > Here I lost you :) If I read the code correctl

Re: [Qemu-devel] [PATCH 0/5] Clean up around bdrv_getlength()

2014-05-09 Thread Stefan Hajnoczi
On Fri, May 09, 2014 at 11:48:13AM +0200, Markus Armbruster wrote: > Issues addressed in this series: > > * BlockDriver method bdrv_getlength() generally returns -errno, but > some implementations return -1 instead. Fix them [PATCH 1]. > > * Frequent conversions between sectors and bytes compl

Re: [Qemu-devel] [PATCH v3 1/4] vl.c: extend -m option to support options for memory hotplug

2014-05-09 Thread Christian Borntraeger
On 07/05/14 20:05, Matthew Rosato wrote: > From: Igor Mammedov > > From: Igor Mammedov > > Add following parameters: > "slots" - total number of hotplug memory slots > "maxmem" - maximum possible memory > > "slots" and "maxmem" should go in pair and "maxmem" should be greater > than "mem"

Re: [Qemu-devel] Question about RAM migration flags

2014-05-09 Thread Peter Lieven
> Am 09.05.2014 um 11:43 schrieb "Dr. David Alan Gilbert" : > > * Peter Lieven (p...@kamp.de) wrote: >> Hi, >> >> while working on ram migration and reading through the code I realized that >> qemu does not stop loading a saved VM or rejecting an incoming migration >> if there is a flag in the

Re: [Qemu-devel] [PATCH] gluster: Correctly propagate errors when volume isn't accessible

2014-05-09 Thread Peter Krempa
On 05/09/14 13:39, Stefan Hajnoczi wrote: > On Fri, May 09, 2014 at 12:08:10PM +0200, Peter Krempa wrote: ... > > Please use scripts/checkpatch.pl to check coding style in the future. I > added {} around the if statement body. QEMU always uses curlies even > for 1-statement bodies. Ah, right,

Re: [Qemu-devel] [PULL 00/38] QMP queue

2014-05-09 Thread Markus Armbruster
Peter Maydell writes: > On 8 May 2014 19:52, Luiz Capitulino wrote: >> The following changes since commit 6b342cc9c872e82620fdd32730cd92affa8a19b3: >> >> Merge remote-tracking branch 'remotes/spice/tags/pull-spice-7' >> into staging (2014-05-08 10:57:25 +0100) >> >> are available in the git re

Re: [Qemu-devel] [PATCH] hw/arm/spitz: Avoid clash with Windows header symbol MOD_SHIFT

2014-05-09 Thread Peter Maydell
On 20 February 2014 19:45, Peter Maydell wrote: > The Windows headers provided by MinGW define MOD_SHIFT. Avoid > it by using SPITZ_MOD_* for our constants here. > > Signed-off-by: Peter Maydell > --- > The other approach would be just to #undef MOD_SHIFT, (and > looking back through the archives

Re: [Qemu-devel] [PULL 00/38] QMP queue

2014-05-09 Thread Luiz Capitulino
On Fri, 09 May 2014 14:54:45 +0200 Markus Armbruster wrote: > Peter Maydell writes: > > > On 8 May 2014 19:52, Luiz Capitulino wrote: > >> The following changes since commit > >> 6b342cc9c872e82620fdd32730cd92affa8a19b3: > >> > >> Merge remote-tracking branch 'remotes/spice/tags/pull-spice-

Re: [Qemu-devel] [PATCH v18 00/15] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2014-05-09 Thread Markus Armbruster
No longer applies. It's been four weeks :( Fam Zheng writes: > v18: Address reviewing comments from Jeff and Eric. Rebased to current master. > Side by side diff from v17: http://bit.ly/1oO2Fvt > > [01/15] block: Add BlockOpType enum > Add Jeff's reviewed-by. >

[Qemu-devel] Migration from older Qemu to Qemu 2.0.0 does not work

2014-05-09 Thread Stefan Priebe - Profihost AG
Hello list, i was trying to migrate older Qemu (1.5 and 1.7.2) to a machine running Qemu 2.0. I started the target machine with: -machine type=pc-i440fx-1.5 / -machine type=pc-i440fx-1.7 But the migration simply fails. Migrating Qemu 2.0 to Qemu 2.0 succeeds. I see no output at the monitor of

[Qemu-devel] [PATCH] hw/audio/intel-hda: Avoid shift into sign bit

2014-05-09 Thread Peter Maydell
Add a U suffix to avoid shifting into the sign bit (which is undefined behaviour in C). Signed-off-by: Peter Maydell --- Another one from clang's sanitizer... hw/audio/intel-hda.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Konrad Rzeszutek Wilk
On Fri, May 09, 2014 at 11:26:35AM +0100, Ian Campbell wrote: > On Fri, 2014-05-09 at 10:15 +, Gonglei (Arei) wrote: > > Hi, > > > > First, please forgive me for my bad English. > > It's so sad. > > > > > -Original Message- > > > From: Ian Campbell [mailto:ian.campb...@citrix.com] >

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Ian Campbell
On Fri, 2014-05-09 at 09:25 -0400, Konrad Rzeszutek Wilk wrote: > On Fri, May 09, 2014 at 11:26:35AM +0100, Ian Campbell wrote: > > On Fri, 2014-05-09 at 10:15 +, Gonglei (Arei) wrote: > > > Hi, > > > > > > First, please forgive me for my bad English. > > > It's so sad. > > > > > > > -Or

Re: [Qemu-devel] [PATCH v3 12/16] tcg-s390: Define TCG_TARGET_INSN_UNIT_SIZE

2014-05-09 Thread Peter Maydell
On 28 April 2014 20:28, Richard Henderson wrote: > And use tcg pointer differencing functions as appropriate. > > Signed-off-by: Richard Henderson > --- > tcg/s390/tcg-target.c | 91 > --- > tcg/s390/tcg-target.h | 2 ++ > 2 files changed, 45 ins

Re: [Qemu-devel] [PATCH v18 00/15] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2014-05-09 Thread Fam Zheng
On Fri, 05/09 15:08, Markus Armbruster wrote: > No longer applies. It's been four weeks :( Hi Markus, Thanks for noticing this, I'll rebase and send another revision now. Fam > > Fam Zheng writes: > > > v18: Address reviewing comments from Jeff and Eric. Rebased to current > > master. > >

Re: [Qemu-devel] [PATCH v3 14/16] tcg-mips: Define TCG_TARGET_INSN_UNIT_SIZE

2014-05-09 Thread Peter Maydell
On 28 April 2014 20:28, Richard Henderson wrote: > And use tcg pointer differencing functions as appropriate. > > Cc: Aurelien Jarno > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] Migration from older Qemu to Qemu 2.0.0 does not work

2014-05-09 Thread Dr. David Alan Gilbert
* Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote: > Hello list, > > i was trying to migrate older Qemu (1.5 and 1.7.2) to a machine running > Qemu 2.0. > > I started the target machine with: > > -machine type=pc-i440fx-1.5 / -machine type=pc-i440fx-1.7 I'd expect you to have to run

Re: [Qemu-devel] [PATCH v3 15/16] tci: Define TCG_TARGET_INSN_UNIT_SIZE

2014-05-09 Thread Peter Maydell
On 28 April 2014 20:28, Richard Henderson wrote: > And use tcg pointer differencing functions as appropriate. > > Cc: Stefan Weil > Signed-off-by: Richard Henderson > --- > tcg/tci/tcg-target.c | 19 +-- > tcg/tci/tcg-target.h | 1 + > 2 files changed, 14 insertions(+), 6 delet

Re: [Qemu-devel] [PATCH] hw/audio/intel-hda: Avoid shift into sign bit

2014-05-09 Thread Gerd Hoffmann
On Fr, 2014-05-09 at 14:22 +0100, Peter Maydell wrote: > Add a U suffix to avoid shifting into the sign bit (which is > undefined behaviour in C). Added to audio patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v3 10/16] tcg-arm: Define TCG_TARGET_INSN_UNIT_SIZE

2014-05-09 Thread Peter Maydell
On 2 May 2014 16:24, Richard Henderson wrote: > On 05/02/2014 08:19 AM, Peter Maydell wrote: >> This change also confused me but we're again relying on movi32 >> generating correct-but-inefficient code now, right? > > Yes. IMO if we want to do a constant pool, let's do a proper one, > not just in

Re: [Qemu-devel] [PATCH v3 11/16] tcg-aarch64: Define TCG_TARGET_INSN_UNIT_SIZE

2014-05-09 Thread Peter Maydell
On 28 April 2014 20:28, Richard Henderson wrote: > And use tcg pointer differencing functions as appropriate. > > Cc: Claudio Fontana > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [SeaBIOS] seabios release?

2014-05-09 Thread Gerd Hoffmann
Hi, > > ... so it's time kick freeze + release candidate I guess ;) > > > > Are there any pending patches for the next release which should better > > make it into the release candidate? > > I just sent a few fixes to the mailing list (xhci msleep, romlayout.o > rebuild, int 1589 fix). I thin

Re: [Qemu-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Fabio Fantoni
Il 08/05/2014 13:23, Gonglei (Arei) ha scritto: Hi, -Original Message- From: Fabio Fantoni [mailto:fabio.fant...@m2r.biz] Sent: Thursday, May 08, 2014 4:17 PM To: Gonglei (Arei); qemu-devel@nongnu.org; xen-de...@lists.xen.org Cc: ian.campb...@citrix.com; jbeul...@suse.com; stefano.stabe

[Qemu-devel] [PATCH v3 ] trace: Multi-backend tracing

2014-05-09 Thread Lluís Vilanova
Adds support to compile QEMU with multiple tracing backends at the same time. For example, you can compile QEMU with: $ ./configure --enable-trace-backends=ftrace,dtrace Where 'ftrace' can be handy for having an in-flight record of events, and 'dtrace' can be later used to extract more inform

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Ian Campbell
On Fri, 2014-05-09 at 10:38 -0400, Ross Philipson wrote: > >> Can it be used to patch the DSDT? Or were you (Ian) thinking that the bulk > >> of the ACPI PCI stuff can be moved there ? > > > > I think it can "shadow" or extend existing DSDT stuff, I don't think it > > can patch as sych. But here we

Re: [Qemu-devel] [PULL 00/38] QMP queue

2014-05-09 Thread Luiz Capitulino
On Fri, 9 May 2014 12:57:43 +0100 Peter Maydell wrote: > On 8 May 2014 19:52, Luiz Capitulino wrote: > > The following changes since commit 6b342cc9c872e82620fdd32730cd92affa8a19b3: > > > > Merge remote-tracking branch 'remotes/spice/tags/pull-spice-7' into > > staging (2014-05-08 10:57:25 +0

Re: [Qemu-devel] [PULL 0/4] libcacard-standalone (glib compat & libcacard) series for 2014-05-08

2014-05-09 Thread Peter Maydell
On 8 May 2014 09:30, Michael Tokarev wrote: > Here's a pull request for glib pre-2.31 compatibility layer and libcacard > cleanups on top of it. It has been submitted for review previously: > > v1: http://thread.gmane.org/gmane.comp.emulators.qemu/269432 > v2: http://thread.gmane.org/gmane.comp.e

Re: [Qemu-devel] [PATCH] qapi: Make the include directive idempotent.

2014-05-09 Thread Benoît Canet
The Friday 09 May 2014 à 07:36:31 (+0200), Markus Armbruster wrote : > Benoît Canet writes: > > > The Thursday 08 May 2014 à 20:30:33 (+0200), Markus Armbruster wrote : > [...] > >> There are two reasons to detect cycles. The technical one is preventing > >> infinite expansion. No longer applie

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Fabio Fantoni
Il 09/05/2014 16:46, Ian Campbell ha scritto: On Fri, 2014-05-09 at 10:38 -0400, Ross Philipson wrote: Can it be used to patch the DSDT? Or were you (Ian) thinking that the bulk of the ACPI PCI stuff can be moved there ? I think it can "shadow" or extend existing DSDT stuff, I don't think it ca

Re: [Qemu-devel] [PATCH v3 ] trace: Multi-backend tracing

2014-05-09 Thread Lluís Vilanova
Lluís Vilanova writes: > Adds support to compile QEMU with multiple tracing backends at the same time. > For example, you can compile QEMU with: > $ ./configure --enable-trace-backends=ftrace,dtrace > Where 'ftrace' can be handy for having an in-flight record of events, and > 'dtrace' can be

Re: [Qemu-devel] [PATCH] qapi: Make the include directive idempotent.

2014-05-09 Thread Lluís Vilanova
Markus Armbruster writes: > Benoît Canet writes: >> The Thursday 08 May 2014 à 20:30:33 (+0200), Markus Armbruster wrote : > [...] >>> There are two reasons to detect cycles. The technical one is preventing >>> infinite expansion. No longer applies with idempotent include. The >>> other, more

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Ian Campbell
On Fri, 2014-05-09 at 16:56 +0200, Fabio Fantoni wrote: > Il 09/05/2014 16:46, Ian Campbell ha scritto: > > On Fri, 2014-05-09 at 10:38 -0400, Ross Philipson wrote: > Can it be used to patch the DSDT? Or were you (Ian) thinking that the > bulk > of the ACPI PCI stuff can be moved th

[Qemu-devel] [PATCH] qemu-img fails to delete last snapshot

2014-05-09 Thread Mike Day
When deleting the last snapshot, copying the resulting snapshot table currently fails, causing the delete operation to also fail. Fix the failure by skipping the copy and just writing the snapshot header and freeing the extra clusters. Signed-off-by: Mike Day --- There are two specific problems

[Qemu-devel] uvesafb doesn't work with seabios

2014-05-09 Thread Bernhard Walle
Hello, I'm using QEmu 2.0.0 on a Linux host (x86-64) with a quite special target system that uses uvesafb ('video=uvesafb:1024x768-32'). I get following errors in the target system: uvesafb: Getting mode info block for mode 0x2 failed (eax=0x4f01, err=1) uvesafb: Getting mode info block f

[Qemu-devel] [PATCH] bsd-user: Remove reference to CONFIG_UNAME_RELEASE

2014-05-09 Thread Peter Maydell
Commit e586822a5 broke the bsd-user build when it removed the CONFIG_UNAME_RELEASE define but forgot to remove the use of it in bsd-user. Fix this in the simplest possible way (bsd-user doesn't make any use at all of the qemu_uname_release variable except to allow it to be pointlessly set by the us

[Qemu-devel] [PATCH v2] qcow2: Patch for shrinking qcow2 disk image

2014-05-09 Thread Jun Li
As the realization of raw shrinking, so when do qcow2 shrinking, do not check l1 entries. When resize to size1(size1 < "disk size"), the custemer knows this will destory the data. So no need to check the l1 entries which is used or not. This is v2 of the original patch. thx. Signed-off-by: Jun Li

Re: [Qemu-devel] [PATCH 4] block/raw-posix: Try both FIEMAP and SEEK_HOLE

2014-05-09 Thread Stefan Hajnoczi
On Thu, May 08, 2014 at 08:57:55PM +0200, Max Reitz wrote: > The current version of raw-posix always uses ioctl(FS_IOC_FIEMAP) if > FIEMAP is available; lseek with SEEK_HOLE/SEEK_DATA are not even > compiled in in this case. However, there may be implementations which > support the latter but not t

Re: [Qemu-devel] [PATCH 0/5] Clean up around bdrv_getlength()

2014-05-09 Thread Stefan Hajnoczi
On Fri, May 09, 2014 at 11:48:13AM +0200, Markus Armbruster wrote: > Issues addressed in this series: > > * BlockDriver method bdrv_getlength() generally returns -errno, but > some implementations return -1 instead. Fix them [PATCH 1]. > > * Frequent conversions between sectors and bytes compl

[Qemu-devel] [PATCH V2] Let the C generated bits of QAPI be generated only once when identical includes are done

2014-05-09 Thread Benoît Canet
in V2: Keep the cycle detection [Markus] Don't talk about idempottent [Markus] Benoît Canet (1): qapi: Let redundant includes be skipped excepted the first occurrence. scripts/qapi.py | 14 +++--- tests/Makefile

[Qemu-devel] [PATCH V2] qapi: Let redundant includes be skipped excepted the first occurrence.

2014-05-09 Thread Benoît Canet
The purpose of this change is to help create a json file containing common definitions; each bit of generated C code must be spitted only one time. A second history global to all QAPISchema instances has been added to detect when a file is included more than one time and skip these includes. It do

Re: [Qemu-devel] [PULL 00/38] QMP queue

2014-05-09 Thread Peter Maydell
On 9 May 2014 14:50, Luiz Capitulino wrote: > On Fri, 9 May 2014 12:57:43 +0100 > Peter Maydell wrote: > >> On 8 May 2014 19:52, Luiz Capitulino wrote: >> > The following changes since commit >> > 6b342cc9c872e82620fdd32730cd92affa8a19b3: >> > >> > Merge remote-tracking branch 'remotes/spice/

  1   2   >