Re: [Qemu-devel] [PATCH, DoS] slirp (arp): do not special-case bogus IP addresses

On Thu, May 08, 2014 at 08:50:33AM +0200, Samuel Thibault wrote: > Edgar E. Iglesias, le Thu 08 May 2014 06:10:18 +, a écrit : > > The search part looks OK to me but when adding to the arp table, don't > > you at least want to avoid adding mappings for 0.0.0.0/32? > > I don't see the gain, act

[Qemu-devel] [PATCH v3 0/2] Named GPIOs

This series implements Named GPIOs on the qdev level. Patch 1 is the feature presentation. Second patch I give a useful example of the features use (an SSI cleanup). Changed sinve v2: Re-ordered function args (PMM review) Changed since v1: use QLIST (AF review) Dropped former P1 (too far out of s

[Qemu-devel] [PATCH v3 1/2] qdev: Implement named GPIOs

Implement named GPIOs on the Device layer. Listifies the existing GPIOs stuff using string keys. Legacy un-named GPIOs are preserved by using a NULL name string - they are just a single matchable element in the name list. Signed-off-by: Peter Crosthwaite --- Changed since v2: Reordered fn args to

[Qemu-devel] [PATCH v3 2/2] ssi: Name the CS GPIO.

To get it out of the default GPIO list. This allows child devices to use the un-named GPIO namespace without having to be SSI aware. That is, there is no more need for machines to know about the obscure policy where GPIO 0 is the SSI chip-select and GPIO 1..N are the concrete class GPIOs (defined l

Re: [Qemu-devel] [PATCH] kvmclock: Ensure time in migration never goes backward

On 08.05.14 03:33, Marcelo Tosatti wrote: On Mon, May 05, 2014 at 03:51:22PM +0200, Alexander Graf wrote: When we migrate we ask the kernel about its current belief on what the guest time would be. However, I've seen cases where the kvmclock guest structure indicates a time more recent than the

Re: [Qemu-devel] Configure virtio-scsi options via libvirt

On 10:08 Wed 07 May , Stefan Hajnoczi wrote: > On Tue, May 06, 2014 at 04:13:50PM -0700, Mike Perez wrote: > > I would like be able to configure virtio-scsi options num_queues, > > max_sectors, > > and cmd_per_lun via libvirt. Are there any plans to have this support? > > Hi Mike, > I'm not s

Re: [Qemu-devel] [Xen-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

Hi, all > -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Thursday, May 08, 2014 4:15 AM > To: Konrad Rzeszutek Wilk > Cc: Gonglei (Arei); qemu-devel@nongnu.org; xen-de...@lists.xen.org; > Huangweidong (C); ian.campb...@citrix.com; stefano.stabell...@eu.citri

Re: [Qemu-devel] [PATCHv3] block: optimize zero writes with bdrv_write_zeroes

Am 07.05.2014 um 18:02 hat Peter Lieven geschrieben: > On 07.05.2014 17:45, Peter Lieven wrote: > >On 07.05.2014 17:38, Kevin Wolf wrote: > >>Am 07.05.2014 um 17:26 hat Peter Lieven geschrieben: > >>>On 07.05.2014 17:19, Kevin Wolf wrote: > Am 07.05.2014 um 16:26 hat Peter Lieven geschrieben: >

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 2/4] ppc64-dump: Support dump for little endian ppc64

On Wed, 07 May 2014 15:54:10 -0500 Tom Musta wrote: > On 5/7/2014 2:02 PM, Tom Musta wrote: > > > It feels like there is an endianness issue here but I have not yet been able > > to put my finger on it. > > OK ... after more thought and scribbling ... here is what I mean > > Suppose I hav

Re: [Qemu-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

Il 08/05/2014 06:12, Gonglei (Arei) ha scritto: Hi, In Xen platform, after using upstream qemu, the all of pci devices will show hotplug in the windows guest. In this situation, the windows guest may occur blue screen when VM' user click the icon of VGA card for trying unplug VGA card. Howeve

Re: [Qemu-devel] [PATCH 0/6] Miscellaneous command completion patches

On Mi, 2014-05-07 at 23:41 +0100, Hani Benhabiles wrote: > Compared to v1: > * Dropped patch 02/07 for help completion conversion. > * Nothing else changed. 04,05 and 06 are R-b by Stefan. > > Hani Benhabiles (6): > monitor: Convert sendkey to use command_completion. > monitor: Add chardev-rem

Re: [Qemu-devel] [PATCH v4] glib: fix g_poll early timeout on windows

07.05.2014 16:36, Stanislav Vorobiov wrote: > Hi, > > IMHO it's not a problem, automerge will resolve this Now the trivial queue pull request has been processed, some of this patch is in the tree. I don't know what is this magic "automerge" which you're talking about. The thing is that your cod

Re: [Qemu-devel] [PATCH] vl.c: Check max_cpus limit instead of smp_cpus

On 7 May 2014 23:20, Andreas Färber wrote: > Am 07.05.2014 23:48, schrieb Peter Maydell: >> This is confusing. What is max_cpus > > Specified via -smp, defaults to actual CPUs. I thought that was smp_cpus ... >> and why do we not >> just set max_cpus = machine->max_cpus ? > > For the PC, machine

[Qemu-devel] My OS hangup in KVM for some reasons, how can I debug?

Hi, I have an weird OS that I am trying to boot in KVM. however, it just hang in the middle, without a good reason. The same OS boots fine in physical machine, and this OS comes with no source code. There must be a bug somewhere in KVM, so I am wondering how people debug deal with such a case to

[Qemu-devel] [PULL 2/4] vscclient: use glib thread primitives not qemu

Use glib-provided thread primitives in vscclient instead of qemu ones, and do not use qemu sockets in there (open-code call to WSAStartup() for windows to initialize things). This way, vscclient becomes more stand-alone, independent on qemu internals. Signed-off-by: Michael Tokarev Reviewed-by:

[Qemu-devel] [PULL 4/4] libcacard: actually use symbols file

libtool has an argument for .syms file, which is -export-symbols. There's no argument `-export-syms', and it looks like at least on linux, -export-syms is just ignored. Use the correct argument, -export-symbols, to actually get the right export list. Signed-off-by: Michael Tokarev Reviewed-by: A

[Qemu-devel] [PULL 0/4] libcacard-standalone (glib compat & libcacard) series for 2014-05-08

Here's a pull request for glib pre-2.31 compatibility layer and libcacard cleanups on top of it. It has been submitted for review previously: v1: http://thread.gmane.org/gmane.comp.emulators.qemu/269432 v2: http://thread.gmane.org/gmane.comp.emulators.qemu/270259 Previous attempt of adding glib

Re: [Qemu-devel] [Xen-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

On Thu, May 08, 2014 at 07:29:15AM +, Gonglei (Arei) wrote: > Hi, all > > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Thursday, May 08, 2014 4:15 AM > > To: Konrad Rzeszutek Wilk > > Cc: Gonglei (Arei); qemu-devel@nongnu.org; xen-de...@lists.xen

Re: [Qemu-devel] [PATCH 1/3] linux-user: Handle ELFv2 PPC64 binaries in user mode.

On 05/08/2014 10:26 AM, Doug Kwan wrote: Look at ELF header to determin ABI version on PPC64. This is required for executing the first instruction correctly. Signed-off-by: Doug Kwan --- include/elf.h| 5 + linux-user/elfload.c | 17 +++-- 2 files changed, 20 inser

Re: [Qemu-devel] [PATCH v3.1 24/31] configure: add Linux libnuma detection

On Wed, May 07, 2014 at 05:57:13PM +0300, Michael S. Tsirkin wrote: > On Tue, May 06, 2014 at 05:27:45PM +0800, Hu Tao wrote: > > From: Wanlong Gao > > > > Add detection of libnuma (mostly contained in the numactl package) > > to the configure script. Can be enabled or disabled on the command > >

Re: [Qemu-devel] [PATCH 2/3] PPC: Allow little-endian user mode.

On 05/08/2014 10:26 AM, Doug Kwan wrote: This all running PPC64 little-endian in user mode if target is configured that way. In PPC64 LE user mode we set MSR.LE during initialization. Byteswapping logic is reversed also when QEMU is running in that mode. Signed-off-by: Doug Kwan I can't say

Re: [Qemu-devel] [PATCH 3/3] configure: Add new target ppc64el-linux-user

On 05/08/2014 10:26 AM, Doug Kwan wrote: Add a new user mode target for little-endian PPC64. Signed-off-by: Doug Kwan --- configure | 6 ++ default-configs/ppc64el-linux-user.mak | 1 + 2 files changed, 7 insertions(+) create mode 100644 default-configs/pp

[Qemu-devel] Curl updates

[PATCH 1/4] curl: Fix parsing of readahead option from filename [PATCH 2/4] curl: Add sslverify option [PATCH 3/4] curl: Add usage documentation The first 3 patches are reposted with updates following discussion of the option syntax. With this patch I've decided to break entirely with the previous

[Qemu-devel] [PATCH 1/4] curl: Fix parsing of readahead option from filename

curl_parse_filename wasn't removing the option string from the url, resulting in a 404. This change is a rewrite of the previous parsing behaviour, and also changes the option syntax. The new syntax is: http://example.com/path?query[sslverify=off:readahead=64k] The new syntax is well defined a

[Qemu-devel] [PATCH 3/4] curl: Add usage documentation

Signed-off-by: Matthew Booth --- qemu-options.hx | 72 + 1 file changed, 72 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 781af14..4cc36bf 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2191,6 +2191,78 @@ qemu-s

[Qemu-devel] [PATCH 2/4] curl: Add sslverify option

This allows qemu to use images over https with a self-signed certificate. It defaults to verifying the certificate. Signed-off-by: Matthew Booth --- block/curl.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/block/curl.c b/block/curl.c index e31b6f3..8cf0a3

[Qemu-devel] [PATCH 4/4] curl: Fix build when curl_multi_socket_action isn't available

Signed-off-by: Matthew Booth --- block/curl.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/block/curl.c b/block/curl.c index 8cf0a3e..e5581f5 100644 --- a/block/curl.c +++ b/block/curl.c @@ -38,6 +38,21 @@ #if LIBCURL_VERSION_NUM >= 0x071000 /* The multi interface timer

Re: [Qemu-devel] [PATCH 1/3] linux-user: Handle ELFv2 PPC64 binaries in user mode.

On 05/08/2014 10:43 AM, Doug Kwan (關振德) wrote: Hi On Thu, May 8, 2014 at 1:36 AM, Alexander Graf > wrote: 3 Please write bitmasks in hex. Will fix. + /* PowerPC relocations defined by the ABIs */ #define R_PPC_NONE0

Re: [Qemu-devel] [PATCH v3 1/4] vl.c: extend -m option to support options for memory hotplug

On 05/07/2014 09:00 PM, Matthew Rosato wrote: On 05/07/2014 02:50 PM, Alexander Graf wrote: On 05/07/2014 08:05 PM, Matthew Rosato wrote: From: Igor Mammedov From: Igor Mammedov Add following parameters: "slots" - total number of hotplug memory slots "maxmem" - maximum possible memo

[Qemu-devel] [PULL 1/4] glib-compat.h: add new thread API emulation on top of pre-2.31 API

Thread API changed in glib-2.31 significantly. Before that version, conditionals and mutexes were only allocated dynamically, using _new()/_free() interface. in 2.31 and up, they're allocated statically as regular variables, and old interface is deprecated. (Note: glib docs says the new interfac

Re: [Qemu-devel] Configure virtio-scsi options via libvirt

Il 08/05/2014 09:24, Mike Perez ha scritto: On 10:08 Wed 07 May , Stefan Hajnoczi wrote: On Tue, May 06, 2014 at 04:13:50PM -0700, Mike Perez wrote: I would like be able to configure virtio-scsi options num_queues, max_sectors, and cmd_per_lun via libvirt. Are there any plans to have this s

[Qemu-devel] [PULL 3/4] libcacard: replace qemu thread primitives with glib ones

Replace QemuMutex with GMutex and QemuCond with GCond (with corresponding function changes), to make libcacard independent of qemu internal functions. After this step, none of libcacard internals use any qemu-provided symbols. Maybe it's a good idea to stop including qemu-common.h internally too.

[Qemu-devel] [PULL 2/2] spice: fix libvirt snapshots

Only notify spice-server about migration events in case we got target host information beforehand. So we kick the seamless spice client migration only in case a actual live migration happens, not when libvirt uses live-migration-to-file for snapshotting. Signed-off-by: Gerd Hoffmann --- ui/spic

[Qemu-devel] [PULL 0/2] spice patch queue

Hi, Here comes the spice patch queue with two little bugfixes. please pull, Gerd The following changes since commit ff788b6fe67f694666781f821c1af812e8c7999b: Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-2014-05-07' into staging (2014-05-07 18:38:39 +0100) are available

[Qemu-devel] [PULL 1/2] spice: fix "info spice"

In case no listening address was specified, "info spice" reports "0.0.0.0" as address. Which is incorrect in case spice is listening on ipv6. Replace it by a wildcard "*" to indicate it is not limited to a specific address. Note: Being more specific is not possible without extending the spice-s

Re: [Qemu-devel] [PATCH 2/3] PPC: Allow little-endian user mode.

On 05/08/2014 10:49 AM, Doug Kwan (關振德) wrote: If we leave the target mode as big-endian, we need to teach the elfloader to handle binary of reversed endianness. I have looked into that possibility as well but find the current approach easier. Please don't top post. Ok, so if we really want

[Qemu-devel] [PATCH v5] glib: fix g_poll early timeout on windows

From: Sangho Park g_poll has a problem on Windows when using timeouts < 10ms, in glib/gpoll.c: /* If not, and we have a significant timeout, poll again with * timeout then. Note that this will return indication for only * one event, or only for messages. We ignore timeouts less than * ten mil

Re: [Qemu-devel] [PATCH 3/3] configure: Add new target ppc64el-linux-user

On 05/08/2014 10:46 AM, Doug Kwan (關振德) wrote: All the magic happens in the patch 2/3. Please don't top post. I still fail to see where you tell the build system that ppc64le-linux-user should not have TARGET_WORDS_BIGENDIAN set. Alex

Re: [Qemu-devel] [libvirt] Configure virtio-scsi options via libvirt

On Wed, May 07, 2014 at 10:24:54AM +0200, Ján Tomko wrote: > On 05/07/2014 01:13 AM, Mike Perez wrote: > > Hi everyone, > > > > I would like be able to configure virtio-scsi options num_queues, > > max_sectors, > > and cmd_per_lun via libvirt. Are there any plans to have this support? > > > > n

Re: [Qemu-devel] [PATCH v2] mac99: Added FW_CFG_PPC_BUSFREQ to match CLOCKFREQ and TBFREQ already there

On 04/17/2014 07:04 PM, BALATON Zoltan wrote: While there, also moved the hard coded value for CLOCKFREQ to a #define. Signed-off-by: BALATON Zoltan Thanks, applied to ppc-next. Alex

Re: [Qemu-devel] [PATCH 2/3] PPC: Allow little-endian user mode.

On 05/08/2014 11:05 AM, Doug Kwan (關振德) wrote: There are a few places where we do 128-bit loads/store. We need to swap the high/low halves and also do byteswap for each half. Byteswap of each half is handled differently depending on TARGET_WORDS_BIGENDIAN but the swapping of high/low halves i

Re: [Qemu-devel] [Qemu-ppc] [V2 PATCH 00/37] target-ppc: Decimal Floating Point

On 04/21/2014 10:54 PM, Tom Musta wrote: This patch series adds emulation of the PowerPC Decimal Floating Point (DFP) instructions. The complete set of DFP instructions defined by the Power ISA is introduced. The foundation of the emulation code is libdecnumber, a software library that models

Re: [Qemu-devel] [PATCH] spapr_pci: fix MSI limit

On 05/04/2014 04:09 PM, Alexey Kardashevskiy wrote: At the moment XICS does not support interrupts reuse so sPAPR PHB implements this. sPAPRPHBState holds array of 32 spapr_pci_msi to describe PCI config address, first MSI and number of MSIs. Once allocated for a device, QEMU tries reusing this c

Re: [Qemu-devel] [Qemu-ppc] [V2 PATCH 0/6] Refactor AES Instructions

On 05/06/2014 02:53 PM, Tom Musta wrote: On 4/11/2014 5:53 PM, Alexander Graf wrote: Am 11.04.2014 um 19:05 schrieb Richard Henderson : On 04/11/2014 09:26 AM, Alexander Graf wrote: V2: updated patch 05/06 per Richard Henderson's review (const pointer to const) Looks good to me. Which queue

[Qemu-devel] [PULL 6/9] trace: [tracetool] Change format docs to point to the generated file

From: Lluís Vilanova Signed-off-by: Lluís Vilanova Signed-off-by: Stefan Hajnoczi --- scripts/tracetool/format/c.py| 4 ++-- scripts/tracetool/format/d.py| 4 ++-- scripts/tracetool/format/events_c.py | 4 ++-- scripts/tracetool/format/events_h.py | 4 ++-- scri

[Qemu-devel] [RFC] dataplane: IOThreads and writing dataplane-capable code

Here is background on the latest dataplane work in my "[PATCH v2 00/25] dataplane: use QEMU block layer" series. It's necessary for anyone who wants to build on top of it. Please leave feedback or questions and I'll submit a docs/ patch with the final version of this document. This document exp

[Qemu-devel] [PULL 0/9] Tracing patches

I forgot to open the QEMU 2.1 tracing queue. Let's get started! The following changes since commit 9898370497da3f18e0c9555b65c858eabc78ab50: Merge remote-tracking branch 'remotes/kraxel/tags/pull-smbios-2' into staging (2014-05-06 12:23:05 +0100) are available in the git repository at: g

[Qemu-devel] [PULL 2/9] trace: [tracetool] Add methods 'Event.copy' and 'Arguments.copy'

From: Lluís Vilanova Signed-off-by: Lluís Vilanova Signed-off-by: Stefan Hajnoczi --- scripts/tracetool/__init__.py | 9 + 1 file changed, 9 insertions(+) diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py index 305b99e..bfe44bd 100644 --- a/scripts/tracetool/_

[Qemu-devel] [PULL 5/9] trace: [tracetool] Show list of frontends and backends sorted by name

From: Lluís Vilanova Signed-off-by: Lluís Vilanova Signed-off-by: Stefan Hajnoczi --- scripts/tracetool/backend/__init__.py | 2 +- scripts/tracetool/format/__init__.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/tracetool/backend/__init__.py b/scripts/tr

[Qemu-devel] [PULL 1/9] trace: [tracetool] Add method 'Event.api' to build event names

From: Lluís Vilanova Makes it easier to ensure proper naming across the different frontends and backends. Signed-off-by: Lluís Vilanova Signed-off-by: Stefan Hajnoczi --- scripts/tracetool/__init__.py | 10 +- scripts/tracetool/backend/dtrace.py | 6 +++--- scripts/tracetool/b

[Qemu-devel] [PULL 8/9] trace: [tracetool] Minimize the amount of per-backend code

From: Lluís Vilanova Backends now only contain the essential backend-specific code, and most of the work is moved to frontend code. Signed-off-by: Lluís Vilanova Signed-off-by: Stefan Hajnoczi --- scripts/simpletrace.py | 6 +- scripts/tracetool/__init__.py|

[Qemu-devel] [PATCH 2/2] simpletrace: add support for trace record pid field

Extract the pid field from the trace record and print it. Change the trace record tuple from: (event_num, timestamp, arg1, ..., arg6) to: (event_num, timestamp, pid, arg1, ..., arg6) Trace event methods now support 3 prototypes: 1. (arg1, arg2, arg3) 2. (timestamp, arg1, arg2, arg3) 3. (times

[Qemu-devel] [PULL 4/9] trace: [tracetool] Cosmetic changes

From: Lluís Vilanova Signed-off-by: Lluís Vilanova Signed-off-by: Stefan Hajnoczi --- scripts/tracetool/__init__.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py index 3cf7a4e..7abffb6 100644 ---

[Qemu-devel] [PULL 7/9] trace: [simple] Bump up log version number

From: Lluís Vilanova The following tracetool cleanup changes the event numbering policy. Signed-off-by: Lluís Vilanova Signed-off-by: Stefan Hajnoczi --- scripts/simpletrace.py | 10 +- trace/simple.c | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/scri

[Qemu-devel] [PATCH 0/2] simpletrace: add pid field to simpletrace record

This series adds a pid field to the simpletrace record. This allows aggregation of simpletrace files as well as host-wide tracing since records can now be associated with a particular QEMU process. Stefan Hajnoczi (2): trace: add pid field to simpletrace record simpletrace: add support for tr

[Qemu-devel] [PULL 3/9] trace: [tracetool] Spacing changes

From: Lluís Vilanova Signed-off-by: Lluís Vilanova Signed-off-by: Stefan Hajnoczi --- scripts/tracetool/__init__.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py index bfe44bd..3cf7a4e 100644 --- a/scrip

[Qemu-devel] [PULL 9/9] configure: Show trace output file conditionally

From: Stefan Weil It is only used with the simple trace backend. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- configure | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b/configure index 8c50d78..1c6e64b 100755 --- a/configure +++ b/configure @@ -4145,7 +4145,9

[Qemu-devel] [PATCH 1/2] trace: add pid field to simpletrace record

It is useful to know the QEMU process ID when working with traces from multiple VMs. Although the trace filename may contain the pid, tools that aggregate traces or even trace globally need somewhere to record the pid. There is a reserved field in the trace event header struct that we can use. I

[Qemu-devel] [PATCH] Makefile: strip tools and modules too

Commit 52ba784d3 replaced $(STRIP_OPT) with $(STRIP) in some places (for example, Makefile.target), but not all of them. There are a few places remain in main Makefile which still uses $(STRIP_OPT). Replace these places with $(STRIP) too. While at it, simplify variable pattern substitution of the

[Qemu-devel] [PATCH] Makefile.target: use $(INSTALL_PROG) for installing, not $(INSTALL)

$(INSTALL_PROG) is evaluated to libtool if using libtool, while $(INSTALL) is not. Use $(INSTALL_PROG) so that libtool is used with target too when necessary. This allows, for example, to link qemu with shared libcacard. Signed-off-by: Michael Tokarev Cc: Fam Zheng Cc: Paolo Bonzini Cc: Alon

[Qemu-devel] [PATCH] Makefile: use $(INSTALL_LIB) for modules not $(INSTALL_PROG)

We have $(INSTALL_LIB) which is the same as $(INSTALL_PROG) but uses correct permissions. Loadable objects (modules) are like shared libraries, not like programs. Signed-off-by: Michael Tokarev Cc: Fam Zheng Cc: Paolo Bonzini --- Again, this is done on top of $(STRIP) patch, but can be done by

Re: [Qemu-devel] [PULL 0/2] spice patch queue

On 8 May 2014 09:51, Gerd Hoffmann wrote: > Hi, > > Here comes the spice patch queue with two little bugfixes. > > please pull, > Gerd > > The following changes since commit ff788b6fe67f694666781f821c1af812e8c7999b: > > Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-2014-05-0

Re: [Qemu-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

0On Sun, 2014-05-04 at 17:25 +0800, arei.gong...@huawei.com wrote: > From: Gaowei > > In Xen platform, after using upstream qemu, the all of pci devices will show > hotplug in the windows guest. In this situation, the windows guest may occur > blue screen when VM' user click the icon of VGA card

Re: [Qemu-devel] [PATCH v2 3/4] console: Abort on property access errors

On Thu, 24 Apr 2014, Kirill Batuzov wrote: > All defined properties of QemuConsole are mandatory and no access to them > should fail. Nevertheless not checking returned errors is bad because in case > of unexpected failure it will hide the bug and cause a memory leak. > > Abort in case of unexpec

Re: [Qemu-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

Hi, > -Original Message- > From: Fabio Fantoni [mailto:fabio.fant...@m2r.biz] > Sent: Thursday, May 08, 2014 4:17 PM > To: Gonglei (Arei); qemu-devel@nongnu.org; xen-de...@lists.xen.org > Cc: ian.campb...@citrix.com; jbeul...@suse.com; > stefano.stabell...@eu.citrix.com; anthony.per...@cit

Re: [Qemu-devel] [PATCH v2 13/25] quorum: implement .bdrv_detach/attach_aio_context()

On Wed, May 07, 2014 at 01:24:00PM +0200, Benoît Canet wrote: > The Wednesday 07 May 2014 à 12:27:29 (+0200), Stefan Hajnoczi wrote : > > Implement .bdrv_detach/attach_aio_context() interfaces to propagate > > detach/attach to BDRVQuorumState->bs[] children. The block layer takes > > care of ->fil

Re: [Qemu-devel] [PATCH v2 17/25] block/raw-win32: implement .bdrv_detach/attach_aio_context()

On Wed, May 07, 2014 at 12:35:40PM +0200, Paolo Bonzini wrote: > >@@ -207,7 +217,6 @@ out_free_state: > > > > void win32_aio_cleanup(QEMUWin32AIOState *aio) > > { > >-qemu_aio_set_event_notifier(&aio->e, NULL); > > Perhaps it would be safer not to leave a dangling pointer in the > AioContext,

Re: [Qemu-devel] [Xen-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

On Thu, 2014-05-08 at 07:29 +, Gonglei (Arei) wrote: > > +rmvc_pcrm = inl(PCI_RMV_BASE); > > > > > > > > > So .. what is at this special 0xae0c address? > > > > > > Is there some code in QEMU that needs this treatment as well? > > > > Yep, the 0xae0c is defined in upstream QEMU, which

Re: [Qemu-devel] [Xen-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

On Thu, 2014-05-08 at 11:32 +0300, Michael S. Tsirkin wrote: > Also I wonder: would it be possible for you to load the acpi > tables from qemu instead of generating your own? There is stuff in the tables for which the definition is Xen and not Qemu. The interrupt routing table is the one which I c

Re: [Qemu-devel] [PATCH 08/22] iscsi: implement .bdrv_detach/attach_aio_context()

On Wed, May 07, 2014 at 04:09:27PM +0200, Peter Lieven wrote: > On 07.05.2014 12:29, Paolo Bonzini wrote: > >Il 07/05/2014 12:07, Stefan Hajnoczi ha scritto: > >>On Fri, May 02, 2014 at 12:39:06AM +0200, Peter Lieven wrote: > +static void iscsi_attach_aio_context(BlockDriverState *bs, > +

Re: [Qemu-devel] [RFC] dataplane: IOThreads and writing dataplane-capable code

Great document, thanks for writing this! I have a few questions below. On Thu, 05/08 12:16, Stefan Hajnoczi wrote: > Here is background on the latest dataplane work in my "[PATCH v2 00/25] > dataplane: use QEMU block layer" series. It's necessary for anyone who wants > to build on top of it. Ple

Re: [Qemu-devel] [Xen-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

On Thu, May 08, 2014 at 12:26:21PM +0100, Ian Campbell wrote: > On Thu, 2014-05-08 at 07:29 +, Gonglei (Arei) wrote: > > > +rmvc_pcrm = inl(PCI_RMV_BASE); > > > > > > > > > > > > So .. what is at this special 0xae0c address? > > > > > > > > Is there some code in QEMU that needs this tr

[Qemu-devel] [PATCH v4 5/7] hw/net/stellaris_enet: Fix debug format strings

Fix various debug format strings which were incorrect for the data type, so that building with debug enabled is possible. Signed-off-by: Peter Maydell Reviewed-by: Dr. David Alan Gilbert --- hw/net/stellaris_enet.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/net

[Qemu-devel] [PATCH v4 7/7] hw/net/stellaris_enet: Convert to vmstate

Convert this device to use vmstate for its save/load, including providing a post_load function that sanitizes inbound data to avoid possible buffer overflows if it is malicious. The sanitizing fixes CVE-2013-4532 (though nobody should be relying on the security properties of most of the unmaintain

Re: [Qemu-devel] [PATCH 1/6] xics: add flags for interrupts

On 05/07/2014 08:01 AM, Alexey Kardashevskiy wrote: The existing interrupt allocation scheme in SPAPR assumes that interrupts are allocated at the start time, continously and the config will not change. However, there are cases when this is not going to work such as: 1. migration - we will have

[Qemu-devel] [PATCH v4 1/7] hw/net/stellaris_enet: Restructure tx_fifo code to avoid buffer overrun

The current tx_fifo code has a corner case where the guest can overrun the fifo buffer: if automatic CRCs are disabled we allow the guest to write the CRC word even if there isn't actually space for it in the FIFO. The datasheet is unclear about exactly how the hardware deals with this situation; t

[Qemu-devel] [PATCH v4 2/7] hw/net/stellaris_enet: Correct handling of packet padding

The PADEN bit in the transmit control register enables padding of short data packets out to the required minimum length. However a typo here meant we were adjusting tx_fifo_len rather than tx_frame_len, so the padding didn't actually happen. Fix this bug. Signed-off-by: Peter Maydell Reviewed-by:

[Qemu-devel] [PATCH v4 4/7] hw/net/stellaris_enet: Correctly implement the TR and THR registers

Packet transmission for the stellaris ethernet controller can be triggered in one of two ways: * by setting a threshold value in the THR register; when the FIFO fill level reaches the threshold, the h/w starts transmitting. Software has to finish filling the FIFO before the transmit proce

[Qemu-devel] [PATCH v4 0/7] stellaris_enet: overhaul tx/rx, convert to vmstate

This patchset overhauls the stellaris_enet TX and RX handling code, and converts it to use vmstate. The principal motivation is to fix the buffer overrun noted in the first patch, and to reimplement things using simpler state fields which are easier to migrate and to validate in post_load. I also

[Qemu-devel] [PATCH v4 6/7] hw/net/stellaris_enet: Get rid of rx_fifo pointer

The rx_fifo pointer is awkward to migrate, and is actually redundant since it is always possible to determine it from the current rx[].len/.data and rx_fifo_len. Remove both rx_fifo and rx_fifo_len from the state, replacing them with a simple rx_fifo_offset which points at the current location in t

[Qemu-devel] [PATCH v4 3/7] hw/net/stellaris_enet: Rewrite tx fifo handling code

The datasheet is clear that the frame length written to the DATA register is actually stored in the TX FIFO; this means we don't need to keep both tx_frame_len and tx_fifo_len state separately. Signed-off-by: Peter Maydell Reviewed-by: Dr. David Alan Gilbert --- hw/net/stellaris_enet.c | 119 ++

Re: [Qemu-devel] [RFC] dataplane: IOThreads and writing dataplane-capable code

On Thu, May 8, 2014 at 1:33 PM, Fam Zheng wrote: > On Thu, 05/08 12:16, Stefan Hajnoczi wrote: >> Here is background on the latest dataplane work in my "[PATCH v2 00/25] >> dataplane: use QEMU block layer" series. It's necessary for anyone who wants >> to build on top of it. Please leave feedbac

Re: [Qemu-devel] [PATCH 3/6] xics: disable flags reset on xics reset

On 05/07/2014 08:01 AM, Alexey Kardashevskiy wrote: Since islsi[] array has been merged into the ICSState struct, we must not reset flags as they tell if the interrupt is in use. Signed-off-by: Alexey Kardashevskiy --- hw/intc/xics.c | 4 +++- hw/intc/xics_kvm.c | 4 +++- 2 files change

Re: [Qemu-devel] [PATCH 004/124] savevm: Remove all the unneded version_minimum_id_old (arm)

On 21 April 2014 17:18, Peter Maydell wrote: > On 21 April 2014 15:39, Juan Quintela wrote: >> After previous Peter patch, they are redundant. This way we don't asign them >> except when needed. Once there, there were lots of case where the ".fields" >> indentation was wrong: >> >> .fields

Re: [Qemu-devel] [PATCH 6/6] xics: implement xics_ics_free()

On 05/07/2014 08:01 AM, Alexey Kardashevskiy wrote: Signed-off-by: Alexey Kardashevskiy --- hw/intc/xics.c| 24 include/hw/ppc/xics.h | 1 + trace-events | 2 ++ 3 files changed, 27 insertions(+) diff --git a/hw/intc/xics.c b/hw/intc/xics.c index

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/6] xics: add flags for interrupts

On 05/08/2014 01:52 PM, Alexander Graf wrote: On 05/07/2014 08:01 AM, Alexey Kardashevskiy wrote: The existing interrupt allocation scheme in SPAPR assumes that interrupts are allocated at the start time, continously and the config will not change. However, there are cases when this is not going

Re: [Qemu-devel] [RFC] dataplane: IOThreads and writing dataplane-capable code

Il 08/05/2014 13:56, Stefan Hajnoczi ha scritto: > Is dataplane the only user for this now? Yes, and neither dataplane (x-data-plane=on) nor IOThread (-object iothread,id=) are finalized. There was a discussion about -object and QOM on the mailing list a while back. We reached the conclusion t

Re: [Qemu-devel] [PATCH 3/3] configure: Add new target ppc64el-linux-user

Am 08.05.2014 10:26, schrieb Doug Kwan: > Add a new user mode target for little-endian PPC64. > > Signed-off-by: Doug Kwan > --- > configure | 6 ++ > default-configs/ppc64el-linux-user.mak | 1 + > 2 files changed, 7 insertions(+) > create mode 100644 default-c

Re: [Qemu-devel] [PATCH 1/4] kvm: Add set_one_reg/get_one_reg helpers

On 04/03/2014 03:14 PM, Alexey Kardashevskiy wrote: This adds QEMU wrappers for KVM_SET_ONE_REG/KVM_GET_ONE_REG ioctls. Signed-off-by: Alexey Kardashevskiy Please merge with the s390 variant of this. Alex

Re: [Qemu-devel] [PATCH v7] spapr: Add support for time base offset migration

On 05/06/2014 04:50 PM, Alexey Kardashevskiy wrote: On 05/01/2014 08:37 PM, Alexey Kardashevskiy wrote: This allows guests to have a different timebase origin from the host. This is needed for migration, where a guest can migrate from one host to another and the two hosts might have a different

Re: [Qemu-devel] [PATCH 3/3] configure: Add new target ppc64el-linux-user

On 8 May 2014 13:18, Andreas Färber wrote: > Am 08.05.2014 10:26, schrieb Doug Kwan: >> Add a new user mode target for little-endian PPC64. >> >> Signed-off-by: Doug Kwan >> --- >> configure | 6 ++ >> default-configs/ppc64el-linux-user.mak | 1 + >> 2 files chan

Re: [Qemu-devel] [PATCH] Makefile: strip tools and modules too

On Thu, 05/08 14:56, Michael Tokarev wrote: > Commit 52ba784d3 replaced $(STRIP_OPT) with $(STRIP) in some > places (for example, Makefile.target), but not all of them. > There are a few places remain in main Makefile which still > uses $(STRIP_OPT). Replace these places with $(STRIP) too. > > Wh

Re: [Qemu-devel] [PATCH 2/3] PPC: Allow little-endian user mode.

On 8 May 2014 09:39, Alexander Graf wrote: > On 05/08/2014 10:26 AM, Doug Kwan wrote: >> >> This all running PPC64 little-endian in user mode if target is configured >> that way. In PPC64 LE user mode we set MSR.LE during initialization. >> Byteswapping logic is reversed also when QEMU is running

Re: [Qemu-devel] [PATCH] Makefile.target: use $(INSTALL_PROG) for installing, not $(INSTALL)

On Thu, 05/08 15:02, Michael Tokarev wrote: > $(INSTALL_PROG) is evaluated to libtool if using libtool, while > $(INSTALL) is not. Use $(INSTALL_PROG) so that libtool is used > with target too when necessary. This allows, for example, to > link qemu with shared libcacard. > > Signed-off-by: Mich

Re: [Qemu-devel] [PATCH] Makefile: use $(INSTALL_LIB) for modules not $(INSTALL_PROG)

On Thu, 05/08 15:06, Michael Tokarev wrote: > We have $(INSTALL_LIB) which is the same as $(INSTALL_PROG) but > uses correct permissions. Loadable objects (modules) are like > shared libraries, not like programs. > > Signed-off-by: Michael Tokarev > Cc: Fam Zheng > Cc: Paolo Bonzini Reviewed-

Re: [Qemu-devel] [PATCH] Update QEMU checkpatch.pl to current linux version

On 05/06/14 14:16, Mike Day wrote: This updates scripts/checkpatch.pl to version 0.32. Also, forward-ported the QEMU checks for no tabs and correct capitalization of "QEMU." Finally, make --no-tree the default option since this will be used with Qemu. Signed-off-by: Mike Day --- Notes: This is

Re: [Qemu-devel] [PATCH 2/3] PPC: Allow little-endian user mode.

On 05/08/2014 02:39 PM, Peter Maydell wrote: On 8 May 2014 09:39, Alexander Graf wrote: On 05/08/2014 10:26 AM, Doug Kwan wrote: This all running PPC64 little-endian in user mode if target is configured that way. In PPC64 LE user mode we set MSR.LE during initialization. Byteswapping logic is

Re: [Qemu-devel] [PATCH 3/3] configure: Add new target ppc64el-linux-user

On 05/08/2014 02:28 PM, Peter Maydell wrote: On 8 May 2014 13:18, Andreas Färber wrote: Am 08.05.2014 10:26, schrieb Doug Kwan: Add a new user mode target for little-endian PPC64. Signed-off-by: Doug Kwan --- configure | 6 ++ default-configs/ppc64el-linux

[Qemu-devel] [PATCH] build: add support for $@-cflags to all compiler rules

This is needed in order to use per-object flags variables. Signed-off-by: Paolo Bonzini --- rules.mak | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/rules.mak b/rules.mak index 7038576..c0c3d86 100644 --- a/rules.mak +++ b/rules.mak @@ -45,7 +45,7 @@ LINK = $(call qu

[Qemu-devel] [PATCH] libcacard: remove libcacard-specific CFLAGS and LIBS from global vars

Currently all what's needed for single file libcacard/vcard_emul_nss.c (libnss cflags) and hw/usb/ccid-card-emulated.c (libcacard includes) together with the libs is added to global QEMU_CFLAGS and libs_softmmu. Use the cflags only where really used (for two mentioned files), and libs only where n

  1   2   3   4   >