Re: [Qemu-devel] [PATCH 0/3] virtio: Eliminate "exit(1)" upon invalid request in virtio-blk and virtio-scsi

2014-04-24 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Wed, Apr 23, 2014 at 11:22:51AM +0800, Fam Zheng wrote: >> On Tue, 04/22 22:12, Michael S. Tsirkin wrote: >> > On Tue, Apr 22, 2014 at 04:55:14PM +0800, Fam Zheng wrote: >> > > Today, buggy or malicous guests that submit invalid requests can >> > > cause QEMU's >

Re: [Qemu-devel] [PATCH] ps2: set ps/2 output buffer size as the same as kernel

2014-04-24 Thread Gonglei (Arei)
> Subject: Re: [PATCH] ps2: set ps/2 output buffer size as the same as kernel > > > @@ -137,7 +139,7 @@ void ps2_queue(void *opaque, int b) > > PS2State *s = (PS2State *)opaque; > > PS2Queue *q = &s->queue; > > > > -if (q->count >= PS2_QUEUE_SIZE) > > +if (q->count >= PS2_QUEUE_S

Re: [Qemu-devel] [PATCH] block: Expose host_* drivers in blockdev-add

2014-04-24 Thread Markus Armbruster
Kevin Wolf writes: > Am 23.04.2014 um 17:34 hat Eric Blake geschrieben: >> On 04/23/2014 09:12 AM, Kevin Wolf wrote: >> > All the functionality to use the host_device, host_cdrom and host_floppy >> > drivers is already there, they just need to be added to the schema. >> > >> > Signed-off-by: Kev

Re: [Qemu-devel] Monitor Readline - no terminal echo after exit

2014-04-24 Thread Markus Armbruster
Mike Day writes: > I believe someone on the list mentioned they are seeing a couple > problems entering and exiting the Monitor. I'd like to look at this more > closely, starting with my most pending issue: losing the terminal echo > after exiting the Monitor. Reproducer? > Does anyone have a q

Re: [Qemu-devel] [RFC PATCH v2 00/16] visitor+BER migration format

2014-04-24 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Eric Blake (ebl...@redhat.com) wrote: >> On 04/23/2014 10:37 AM, Dr. David Alan Gilbert (git) wrote: >> > From: "Dr. David Alan Gilbert" >> > >> >> >4) At the moment you select BER output format by setting an environment >> > variable ( export QEM

Re: [Qemu-devel] [PATCH v8] net: L2TPv3 transport

2014-04-24 Thread Stefan Hajnoczi
On Sun, Apr 06, 2014 at 03:22:16PM +0100, anton.iva...@kot-begemot.co.uk wrote: > +int net_init_l2tpv3(const NetClientOptions *opts, > +const char *name, > +NetClientState *peer) > +{ > + > + > +const NetdevL2TPv3Options *l2tpv3; > +NetL2TPV3State *s;

Re: [Qemu-devel] [Bug 1288620] Re: memory leak with default NIC model

2014-04-24 Thread Markus Armbruster
Aidan Gauland writes: > On Wed, 23 Apr 2014 13:10:39 -, Stefan Hajnoczi wrote: >> So this is a problem that only happens under Valgrind? Perhaps this >> is >> a valgrind bug. > > No, it happens outside of Valgrind as well. It only happens when QEMU > is told to read a config file (with -r

Re: [Qemu-devel] [patch 2/2] target-i386: block migration and savevm if invariant tsc is exposed

2014-04-24 Thread Eduardo Habkost
On Thu, Apr 24, 2014 at 04:42:33PM -0400, Paolo Bonzini wrote: > Il 22/04/2014 21:14, Eduardo Habkost ha scritto: > >Not for "-cpu host". If somebody needs migration to work, they shouldn't > >be using "-cpu host" anyway (I don't know if you have seen the other > >comments in my message?). > > I'm

[Qemu-devel] [PATCH 2/3] disas/libvixl: Add missing ULL suffixes

2014-04-24 Thread Peter Maydell
Upstream libvixl 1.3 fixes a number of the places which needed ULL suffixes, but not all of them; reapply those ones from commit 37fd5b53b which are still relevant. Signed-off-by: Peter Maydell --- disas/libvixl/a64/instructions-a64.h | 24 disas/libvixl/utils.h

[Qemu-devel] [PULL 00/40] target-alpha queue

2014-04-24 Thread Richard Henderson
ince commit a9e8aeb3755bccb7b51174adcf4a3fc427e0d147: Update version for v2.0.0 release (2014-04-17 13:41:45 +0100) are available in the git repository at: git://github.com/rth7680/qemu.git tags/tgt-axp-pull-20140424 for you to fetch changes up to 06ef8604e92964cbf30084b7d31091aa7cbbb62f: t

Re: [Qemu-devel] [patch 2/2] target-i386: block migration and savevm if invariant tsc is exposed

2014-04-24 Thread Paolo Bonzini
Il 22/04/2014 21:14, Eduardo Habkost ha scritto: Not for "-cpu host". If somebody needs migration to work, they shouldn't be using "-cpu host" anyway (I don't know if you have seen the other comments in my message?). I'm not entirely sure. If you have hosts with exactly identical chipsets, "-

[Qemu-devel] [PATCH 3/3] hw/arm/virt: Add support for Cortex-A57

2014-04-24 Thread Peter Maydell
Support the Cortex-A57 in the virt machine model. Signed-off-by: Peter Maydell --- hw/arm/virt.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 9c4d337..ea4f02d 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -119,6 +119,11 @@ static VirtBoardInfo

[Qemu-devel] [PATCH 2/3] hw/arm/virt: Put GIC register banks on 64K boundaries

2014-04-24 Thread Peter Maydell
For an AArch64 CPU which supports 64K pages, having the GIC register banks at 4K offsets is potentially awkward. Move them out to being at 64K offsets. (This is harmless for AArch32 CPUs and for AArch64 CPUs with 4K pages, so it is simpler to use the same offsets everywhere than to try to use 64K o

[Qemu-devel] [PATCH v3] configure: Enable TPM by default, add --disable-tpm

2014-04-24 Thread Cole Robinson
I don't see why tpm is disabled by default: it doesn't have any external dependencies, or change default behavior. Leaving it disabled is just going to cause it to bit rot. Enable it by default, and add a --disable-tpm option. Signed-off-by: Cole Robinson --- v2: Don't drop --enable-tpm v3

[Qemu-devel] [PATCH 0/5] gtk: Misc fixes

2014-04-24 Thread Cole Robinson
A collection of fixes related to the gtk UI. See individual patches for details. Cole Robinson (5): configure: Re-run make if gtkabi/sdlabi is changed gtk: Fix monitor greeting gtk: Fix -serial vc gtk: Fix zoom in accelerator gtk: Fix accelerators being triggered twice with gtk3 config

[Qemu-devel] [PATCH v2 12/13] tcg-sparc: Fix small 32-bit movi

2014-04-24 Thread Richard Henderson
We tested imm13 before discarding garbage high bits. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index a977c57..1526f2c 100644 --- a/tcg/sparc/tcg-target.c +++ b/tcg/sparc/tcg

[Qemu-devel] [PATCH v2] configure: Change --enable-tpm to --disable-tpm

2014-04-24 Thread Cole Robinson
I don't see why tpm is disabled by default: it doesn't have any external dependencies, or change default behavior. Leaving it disabled is just going to cause it to bit rot. Enable it by default, and change --enable-tpm to --disable-tpm if people still want an option to compile it out. Signed-off-

Re: [Qemu-devel] Monitor Readline - no terminal echo after exit

2014-04-24 Thread Mike Day
On Thu, Apr 24, 2014 at 3:31 AM, Markus Armbruster wrote: >> I believe someone on the list mentioned they are seeing a couple >> problems entering and exiting the Monitor. I'd like to look at this more >> closely, starting with my most pending issue: losing the terminal echo >> after exiting the M

[Qemu-devel] [PATCH v2 09/13] tcg-sparc: Don't handle mov/movi in tcg_out_op

2014-04-24 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index af9673f..d5d1761 100644 --- a/tcg/sparc/tcg-target.c +++ b/tcg/sparc/tcg-target.c @@ -1187,9 +1187,6

Re: [Qemu-devel] [RFC PATCH v2 00/16] visitor+BER migration format

2014-04-24 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Eric Blake (ebl...@redhat.com) wrote: > >> On 04/23/2014 10:37 AM, Dr. David Alan Gilbert (git) wrote: > >> > From: "Dr. David Alan Gilbert" > >> > > >> > >> >4) At the moment you select BER output fo

[Qemu-devel] [PATCH 10/10] tests: Add EHCI qtest

2014-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- MAINTAINERS | 1 + tests/Makefile| 4 tests/usb-hcd-ehci-test.c | 40 3 files changed, 45 insertions(+) create mode 100644 tests/usb-hcd-ehci-test.c diff --git a/MAINTAINERS b/MAINTAINERS

Re: [Qemu-devel] QEMU 2.0 RC with Spice

2014-04-24 Thread Rick Vernam
On Wednesday 16 April 2014 10:44:36 Rick Vernam wrote: > On Wednesday 16 April 2014 07:12:16 Richard Vernam wrote: > > On Apr 16, 2014 3:07 AM, "Dr. David Alan Gilbert" > > > > wrote: > > > * Rick Vernam (rtver...@hobi.com) wrote: > > > > On Tuesday 15 April 2014 19:25:22 Rick Vernam wrote: > > >

Re: [Qemu-devel] [PATCH] qemu-iotests: Improve and make use of QMPTestCase.wait_until_completed()

2014-04-24 Thread Stefan Hajnoczi
On Wed, Apr 02, 2014 at 01:54:07PM +0800, Fam Zheng wrote: > This eliminates code duplication. > > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/030| 50 > +-- > tests/qemu-iotests/056| 9 +--- > tests/qemu-iotests/iotests.py |

[Qemu-devel] [PATCH 5/5] iscsi: Don't use error_is_set() to suppress additional errors

2014-04-24 Thread Markus Armbruster
Using error_is_set(errp) that way can sweep programming errors under the carpet when we get called incorrectly with an error set. Commit 24d3bd6 added a broken error path to iscsi_do_inquiry(): it first calls error_setg(), then jumps to the preexisting error label, where error_setg() gets called a

Re: [Qemu-devel] [PATCH v5 07/12] qemu-img: Empty images after commit

2014-04-24 Thread Kevin Wolf
Am 24.04.2014 um 16:54 hat Max Reitz geschrieben: > On 23.04.2014 11:32, Kevin Wolf wrote: > >Am 22.04.2014 um 18:22 hat Max Reitz geschrieben: > >>On 22.04.2014 17:19, Eric Blake wrote: > >>>On 04/17/2014 03:59 PM, Max Reitz wrote: > After the top image has been committed into an image in its

[Qemu-devel] [PATCH v2 04/13] tcg-sparc: Support trunc_shr_i32

2014-04-24 Thread Richard Henderson
Unlike a 64-bit shift op, allows the output to be in %l or %i registers for sparcv8plus. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 8 tcg/sparc/tcg-target.h | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-t

Re: [Qemu-devel] memory allocation of migration changed?

2014-04-24 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@gmail.com) wrote: > On Tue, Feb 11, 2014 at 07:30:54PM +0100, Stefan Priebe wrote: > > Am 11.02.2014 16:44, schrieb Stefan Hajnoczi: > > >On Tue, Feb 11, 2014 at 3:54 PM, Stefan Priebe - Profihost AG > > > wrote: > > >>in the past (Qemu 1.5) a migration failed if there w

Re: [Qemu-devel] [PATCH v2 1/4] acpi/pcihp.c: Rewrite acpi_pcihp_get_bsel using object_property_get_int

2014-04-24 Thread Michael S. Tsirkin
On Thu, Apr 24, 2014 at 06:15:56PM +0400, Kirill Batuzov wrote: > acpi_pcihp_get_bsel implements functionality of object_property_get_int for > specific property named ACPI_PCIHP_PROP_BSEL, but fails to decrement object's > reference counter properly. Rewriting it using generic object_property_get_

[Qemu-devel] [PATCH v2 13/13] tcg-sparc: Accept stores of zero

2014-04-24 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 1526f2c..5468ff5 100644 --- a/tcg/sparc/tcg-target.c +++ b/tcg/sparc/tcg-target.c @@ -1470,8 +1470,8 @@ static

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-24 Thread Michael S. Tsirkin
On Thu, Apr 24, 2014 at 11:19:14AM +0800, Fam Zheng wrote: > On Wed, 04/23 10:17, Michael S. Tsirkin wrote: > > On Tue, Apr 22, 2014 at 04:55:15PM +0800, Fam Zheng wrote: > > > If guest driver behaves abnormally, emulation code could mark the device > > > as "broken". > > > > > > Once "broken" is

[Qemu-devel] [PATCH 0/3] hw/arm/virt: Support Cortex-A57

2014-04-24 Thread Peter Maydell
This patchset wires up our new Cortex-A57 emulation into the "virt" machine model. Rather than the somewhat hacky approach in the previous system emulation patchsets, I've decided that our best approach is to have the board model create the GIC itself. This essentially corresponds to modelling a bo

[Qemu-devel] [PATCH v2 00/13] tcg/sparc v8plus code generation

2014-04-24 Thread Richard Henderson
Our 32-bit build for sparc has been requiring a 64-bit capable chip for about 2 years now, by way of requiring move-conditional and LE memory instructions. But we've mostly been generating 32-bit code otherwise. This patch set changes things so that we make full use of the cpu. The sparcv8plus

[Qemu-devel] [PATCH v2 11/13] tcg-sparc: Fixup function argument types

2014-04-24 Thread Richard Henderson
Use TCGReg everywhere appropriate. Use int32_t for all arguments that may be registers or immediate constants. Merge tcg_out_addi into its only caller. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 117 + 1 file changed, 51 insert

[Qemu-devel] [PATCH 3/3] libvixl: fix 64bit constants usage

2014-04-24 Thread Peter Maydell
From: Michael Tokarev Cherry-pick QEMU commit 0dbcf95a1, because it is still needed for libvixl 1.3: disas/libvixl/ contains functions which uses 64bit constants without using appropriate suffixes, which fails on 32bits. Fix this by using ULL suffix. Signed-off-by: Michael Tokarev Reviewed-by

Re: [Qemu-devel] [PATCH] block: prefer protocol_name over format_name in bdrv_iterate_format

2014-04-24 Thread Stefan Hajnoczi
On Tue, Apr 15, 2014 at 04:00:54PM +0200, Kevin Wolf wrote: > Am 15.04.2014 um 15:28 hat Jeff Cody geschrieben: > > Some block drivers have multiple BlockDriver instances with identical > > format_name fields (e.g. gluster, nbd). In those cases, the > > protocol_name is usually the more unique ide

[Qemu-devel] [PATCH v2 02/13] tcg: Add INDEX_op_trunc_shr_i32

2014-04-24 Thread Richard Henderson
Let the backend do something special for truncation. Cc: Stuart Brady Signed-off-by: Richard Henderson --- tcg/README | 5 + tcg/aarch64/tcg-target.h | 1 + tcg/i386/tcg-target.h| 1 + tcg/ia64/tcg-target.h| 1 + tcg/optimize.c | 16 tcg/

Re: [Qemu-devel] [PATCH 3/3] s390x/helper: Added format control bit to MMU translation

2014-04-24 Thread Alexander Graf
On 24.04.14 10:51, Jens Freimann wrote: From: Thomas Huth With the EDAT-1 facility, the MMU translation can stop at the segment table already, pointing to a 1 MB block. Signed-off-by: Thomas Huth Signed-off-by: Jens Freimann Reviewed-by: David Hildenbrand --- target-s390x/helper.c | 4 ++

Re: [Qemu-devel] [PATCH 3/3] s390x/helper: Added format control bit to MMU translation

2014-04-24 Thread Jens Freimann
On 04/24/2014 03:40 PM, Alexander Graf wrote: On 24.04.14 10:51, Jens Freimann wrote: From: Thomas Huth With the EDAT-1 facility, the MMU translation can stop at the segment table already, pointing to a 1 MB block. Signed-off-by: Thomas Huth Signed-off-by: Jens Freimann Reviewed-by: David

[Qemu-devel] [PATCH v2 1/4] acpi/pcihp.c: Rewrite acpi_pcihp_get_bsel using object_property_get_int

2014-04-24 Thread Kirill Batuzov
acpi_pcihp_get_bsel implements functionality of object_property_get_int for specific property named ACPI_PCIHP_PROP_BSEL, but fails to decrement object's reference counter properly. Rewriting it using generic object_property_get_int serves two purposes: reducing code duplication and fixing memory l

[Qemu-devel] [PATCH 2/2] net: Don't use error_is_set() to suppress additional errors

2014-04-24 Thread Markus Armbruster
Using error_is_set(errp) that way can sweep programming errors under the carpet when we get called incorrectly with an error set. qmp_query_rx_filter() breaks its loop when it detects an error. It needs to set another error when the loop completes normally. Return right away instead of merely br

[Qemu-devel] [PATCH v2 03/13] tcg-sparc: Remove most uses of TCG_TARGET_REG_BITS

2014-04-24 Thread Richard Henderson
Replace with SPARC64 define. Soon even sparcv8plus will use 64-bit register as far as TCG is concerned. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 70 ++ 1 file changed, 37 insertions(+), 33 deletions(-) diff --git a/tcg/sparc/

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] configure: Improve help behavior

2014-04-24 Thread Michael Tokarev
18.04.2014 10:55, Fam Zheng wrote: > Old: > There are two paths to show help and exit 1, one is with "-h" or > "--help", one is with invalid options. > > New: > Show help and exit 0 for --help. > On invalid option, don't show the long help and bury the early "ERROR:" > line, just give a message po

[Qemu-devel] [PATCH v2] block: Expose host_* drivers in blockdev-add

2014-04-24 Thread Kevin Wolf
All the functionality to use the host_device, host_cdrom and host_floppy drivers is already there, they just need to be added to the schema. The block driver names containing underscores are preexisting and cannot be changed without breaking command line compatibility. Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH 0/2] net: Purge error_is_set()

2014-04-24 Thread Markus Armbruster
I got a private branch getting rid of it entirely. This is the second part, covering network backends. Markus Armbruster (2): net: Make qmp_query_rx_filter() with name argument more obvious net: Don't use error_is_set() to suppress additional errors net/net.c | 8 ++-- 1 file changed, 6

[Qemu-devel] [PATCH v2 4/4] PortioList: Store PortioList in device state

2014-04-24 Thread Kirill Batuzov
PortioList is an abstraction used for construction of MemoryRegionPortioList from MemoryRegionPortio. It can be used later to unmap created memory regions. It also requires proper cleanup because some of the memory inside is allocated dynamically. By moving PortioList to device state we make it po

Re: [Qemu-devel] [PATCH] Re: snapshot: fixed bdrv_get_full_backing_filename can not get correct full_backing_filename

2014-04-24 Thread Stefan Hajnoczi
On Thu, Apr 10, 2014 at 01:03:51AM +0800, Jun Li wrote: > Thanks Eric's analysis and review firstly. As not so clear to the application > context, so the first patch can not cover symlink scenarios. > In this patch, will check the backing_filename is a symlink or not firstly, > then return the fu

Re: [Qemu-devel] target-i386: block migration and savevm if invariant tsc is exposed (v3)

2014-04-24 Thread Eduardo Habkost
On Wed, Apr 23, 2014 at 06:04:45PM -0300, Marcelo Tosatti wrote: > > Invariant TSC documentation mentions that "invariant TSC will run at a > constant rate in all ACPI P-, C-. and T-states". > > This is not the case if migration to a host with different TSC frequency > is allowed, or if savevm i

Re: [Qemu-devel] [GSoC] Wanted: small warmup tasks

2014-04-24 Thread Andreas Färber
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 24.04.2014 08:19, schrieb Jan Kiszka: > On 2014-04-23 11:25, Stefan Hajnoczi wrote: >> Dear QEMU, Libvirt, and KVM communities, We are participating in >> Google Summer of Code 2014 (http://google-melange.com/) and >> Outreach Program for Women (htt

[Qemu-devel] [PATCH v2 0/4] Fix memory leaks in QEMU

2014-04-24 Thread Kirill Batuzov
This patch series addresses several cases of memory leaks I've found in QEMU using Valgrind's Memcheck tool. I only checked "definitely lost" reports. I ignored reports related to SDL/GTK because it is hard to tell if memory leak occurred in QEMU or in the library. List of addressed problems. -

[Qemu-devel] [PATCH 5/5] gtk: Fix accelerators being triggered twice with gtk3

2014-04-24 Thread Cole Robinson
When keyboard focus is grabbed, current qemu wants to pass every keypress to the VM, unless the user is pressing a UI accelerator. That's exactly how things work without any of the fancy handling. Drop the special handling, which seems to trigger accelerators twice on gtk3. Signed-off-by: Cole Ro

Re: [Qemu-devel] [Bug 1310714] Re: User mode networking SLIRP rapid memory leak

2014-04-24 Thread Stefan Hajnoczi
On Mon, Apr 21, 2014 at 08:53:43PM -, Likai Liu wrote: > I also noticed that the command I ran is causing this bug to happen. I > had accidentally repeated -net nic twice, so there are two -net user > network interfaces. Removing one of them makes the problem go away. This is still a bug, the

Re: [Qemu-devel] [PATCH 0/3] virtio: Eliminate "exit(1)" upon invalid request in virtio-blk and virtio-scsi

2014-04-24 Thread Kevin Wolf
Am 24.04.2014 um 09:55 hat Michael S. Tsirkin geschrieben: > On Thu, Apr 24, 2014 at 09:15:25AM +0200, Markus Armbruster wrote: > > "Michael S. Tsirkin" writes: > > > > > On Wed, Apr 23, 2014 at 11:22:51AM +0800, Fam Zheng wrote: > > >> This series is a step towards getting rid of such code, > >

[Qemu-devel] [PATCH qom-next] MAINTAINERS: Document QOM

2014-04-24 Thread Andreas Färber
Invented by Anthony. Maintained through my qom-next tree lately. Cc: Anthony Liguori Cc: Paolo Bonzini Signed-off-by: Andreas Färber --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c66946f..87a56b7 100644 --- a/MAINTAINERS +++ b/M

Re: [Qemu-devel] [SeaBIOS] seabios release?

2014-04-24 Thread Kevin O'Connor
On Wed, Apr 23, 2014 at 04:41:32PM +0200, Gerd Hoffmann wrote: > Hi, > > I think it's time to start planning the next seabios release. First, > because a bunch of changes have piled up in master. And second, because > of the smbios changes. They are a step forward in making seabios less > dep

[Qemu-devel] [PATCH] MAINTAINERS: Add qemu-img/io to block subsystem

2014-04-24 Thread Kevin Wolf
qemu-img and qemu-io were not covered by any MAINTAINERS entry so far. Reported-by: Markus Armbruster Signed-off-by: Kevin Wolf --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c66946f..b287ef8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6

[Qemu-devel] [PATCH 1/5] Use error_is_set() only when necessary (again)

2014-04-24 Thread Markus Armbruster
error_is_set(&var) is the same as var != NULL, but it takes whole-program analysis to figure that out. Unnecessarily hard for optimizers, static checkers, and human readers. Commit 84d18f0 dumbed it down to obvious, but a few more have crept in since, and documentation was overlooked. Dumb these

Re: [Qemu-devel] [Qemu-trivial] [PATCH trivial v2] vl: avoid closing stdout with 'writeconfig'

2014-04-24 Thread Michael Tokarev
22.04.2014 05:12, Chen Gang wrotr: > 'writeconfig' supports output to stdout (with '-'); when that happens, > we must not close stdout, or further command line options that also use > stdout will be impacted. (Although 'writeconfig' was copied from > 'readconfig', the latter does not have the probl

[Qemu-devel] [PATCH 0/5] block: Purge error_is_set()

2014-04-24 Thread Markus Armbruster
I got a private branch getting rid of it entirely. This is the first part, covering the block subsystem. Markus Armbruster (5): Use error_is_set() only when necessary (again) qemu-img: Consistently name Error * objects err, and not errp nbd: Use return values instead of error_is_set(errp)

Re: [Qemu-devel] [PATCH 01/10] MAINTAINERS: Take maintainership for QTest

2014-04-24 Thread Stefan Hajnoczi
On Thu, Apr 24, 2014 at 02:49:14PM +0200, Andreas Färber wrote: > Invented by Anthony. Maintenance has been handled by me lately. > > Note that the tests themselves are intentionally not part of this entry; > they are considered part of the device or subsystem they are covering. > > Cc: Anthony L

Re: [Qemu-devel] [PULL 00/14] tcg generic queue

2014-04-24 Thread Peter Maydell
On 22 April 2014 22:05, Richard Henderson wrote: > Minmal reviewage, but they've all been posted more than once. > Please pull. > > > r~ > > > The following changes since commit 2d03b49c3f225994c4b0b46146437d8c887d6774: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-2

[Qemu-devel] [PATCH 07/10] tests: Add es1370 qtest

2014-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- MAINTAINERS | 1 + tests/Makefile | 3 +++ tests/es1370-test.c | 33 + 3 files changed, 37 insertions(+) create mode 100644 tests/es1370-test.c diff --git a/MAINTAINERS b/MAINTAINERS index 5d5f9e2..204089f 100644 -

Re: [Qemu-devel] [patch 2/2] target-i386: block migration and savevm if invariant tsc is exposed

2014-04-24 Thread Eduardo Habkost
On Fri, Apr 25, 2014 at 12:57:48AM +0200, Paolo Bonzini wrote: > Il 24/04/2014 22:57, Eduardo Habkost ha scritto: > >On Thu, Apr 24, 2014 at 04:42:33PM -0400, Paolo Bonzini wrote: > >>Il 22/04/2014 21:14, Eduardo Habkost ha scritto: > >>>Not for "-cpu host". If somebody needs migration to work, the

[Qemu-devel] [PATCH v2] configure: add more detailed hint of old libfdt-dev missing, libfdt_env.h

2014-04-24 Thread john.liuli
libfdt_env.h is missing in some stable installs (<1.3.0-3), some released linux distributions(e.g. Ubuntu 12.04) depending on it still complain missing libfdt even if already installed. So give more detailed hint for such OS users. Signed-off-by: Liu Li --- configure |5 +++-- 1 file change

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qmp: Remove unused variable.

2014-04-24 Thread Michael Tokarev
Thanks, applied to -trivial. /mjt

Re: [Qemu-devel] [PATCH 4/5] blockdev: Clean up fragile use of error_is_set()

2014-04-24 Thread Kevin Wolf
Am 24.04.2014 um 11:15 hat Markus Armbruster geschrieben: > Using error_is_set(ERRP) to find out whether a function failed is > either wrong, fragile, or unnecessarily opaque. It's wrong when ERRP > may be null, because errors go undetected when it is. It's fragile > when proving ERRP non-null in

[Qemu-devel] [PATCH] pcie_host: Turn pcie_host_init() into an instance_init

2014-04-24 Thread Andreas Färber
This assures the trivial field initialization is applied for any derived type - currently only Q35PCIHost. Signed-off-by: Andreas Färber --- Michael, I've had this preparation lying around for a while but didn't get further yet. Can you take this through the PCI queue already? hw/pci-host/q3

Re: [Qemu-devel] [PATCH 2/5] qemu-img: Consistently name Error * objects err, and not errp

2014-04-24 Thread Kevin Wolf
Am 24.04.2014 um 11:15 hat Markus Armbruster geschrieben: > > Signed-off-by: Markus Armbruster > --- > qemu-img.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/qemu-img.c b/qemu-img.c > index 8455994..88124bf 100644 > --- a/qemu-img.c > +++ b/qemu-img.c >

[Qemu-devel] [PATCH 00/10] qtest: Cleanups, more PCI tests

2014-04-24 Thread Andreas Färber
Hello, This series starts with some libqtest cleanups and improvements that I came across debugging occasional make check failures on our Open Build Service. It continues with some more test cases for optional PCI devices. Regards, Andreas Cc: Bruce Rogers Cc: Stefan Hajnoczi Cc: Michael S. T

[Qemu-devel] High dom0 cpu usage using spice

2014-04-24 Thread Fabio Fantoni
After endless troubles I'm finally approaching to use spice on xen in production in place of vnc+rdp. I have noticed an high dom0 cpu usage by guest's qemu process when spice is used (in particular using video streaming). This is my test system: Dom0: Dell Poweredge T310 with cpu xeon X3450 an

Re: [Qemu-devel] [PATCH for-2.0 v2] tests: Don't run qom-test twice

2014-04-24 Thread Peter Maydell
On 24 April 2014 15:29, Stefan Hajnoczi wrote: > On Mon, Apr 07, 2014 at 04:13:00PM +0200, Andreas Färber wrote: >> Commit 3687d5325 accidentally resulted in running qom-test twice >> for x86_64, once directly via the wildcard, and once because x86_64 >> includes all the i386 qtests (which include

Re: [Qemu-devel] [PATCH for-2.0 v2] tests: Don't run qom-test twice

2014-04-24 Thread Andreas Färber
Am 24.04.2014 16:34, schrieb Peter Maydell: > On 24 April 2014 15:29, Stefan Hajnoczi wrote: >> On Mon, Apr 07, 2014 at 04:13:00PM +0200, Andreas Färber wrote: >>> Commit 3687d5325 accidentally resulted in running qom-test twice >>> for x86_64, once directly via the wildcard, and once because x86_

[Qemu-devel] [PATCH 08/10] tests: Add intel-hda qtests

2014-04-24 Thread Andreas Färber
Test both the ich6 and the ich9 version (cf. q35 config) and all the codecs. Cc: Gerd Hoffmann Signed-off-by: Andreas Färber --- MAINTAINERS| 1 + tests/Makefile | 3 +++ tests/intel-hda-test.c | 45 + 3 files changed, 49 inserti

Re: [Qemu-devel] [PATCH v25 00/31] replace QEMUOptionParameter with QemuOpts

2014-04-24 Thread Stefan Hajnoczi
On Mon, Apr 21, 2014 at 02:44:36PM +0800, Chunyan Liu wrote: > Hi, Eric, Stefan, Leandro, > > Could you have a look at the new version? > https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg01759.html > > This work lasts for a very long time, hope it could be ended soon :) Yes, I will look

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add qemu-img/io to block subsystem

2014-04-24 Thread Stefan Hajnoczi
On Thu, Apr 24, 2014 at 11:53:39AM +0200, Kevin Wolf wrote: > qemu-img and qemu-io were not covered by any MAINTAINERS entry so far. > > Reported-by: Markus Armbruster > Signed-off-by: Kevin Wolf > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) Thanks, applied to my block tree: ht

Re: [Qemu-devel] [PULL v2 2/2] usb: mtp filesharing

2014-04-24 Thread Peter Wu
Hi, For this review, I grabbed the MTP 1.1 spec from USB.org. There are some issues which are noted below. On Wednesday 23 April 2014 10:31:01 Gerd Hoffmann wrote: > Implementation of a USB Media Transfer Device device for easy > filesharing. Read-only. No access control inside qemu, it will >

Re: [Qemu-devel] [PATCH] ps2: set ps/2 output buffer size as the same as kernel

2014-04-24 Thread Gonglei (Arei)
> Hi, > > > Move the check into ps2_mouse_send_packet() is not a good idea. > > In that case, we cannot break the for loop except we change the return value > > of ps2_mouse_send_packet(). > > Changing the return value is fine IMO. > OK. Change it in v3. Could you review the v2 about other cod

[Qemu-devel] [PATCH 3/5] nbd: Use return values instead of error_is_set(errp)

2014-04-24 Thread Markus Armbruster
Using error_is_set(errp) to check whether a function call failed is fragile: it breaks when errp is null. Check perfectly suitable return values instead when possible. errp can't be null there now, but this is more robust and more obviously correct Signed-off-by: Markus Armbruster --- block/nb

[Qemu-devel] [PATCH v2 07/13] tcg-sparc: Implement muls2_i32

2014-04-24 Thread Richard Henderson
Using the 32-bit SMUL is a tad more efficient than resorting to extending and using the 64-bit MULX. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 18 +++--- tcg/sparc/tcg-target.h | 2 +- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/tcg/sparc/tcg-

Re: [Qemu-devel] [PATCH 1/3] s390x: empty function stubs in preparation for __KVM_HAVE_GUEST_DEBUG

2014-04-24 Thread Cornelia Huck
On Thu, 24 Apr 2014 16:56:02 +0200 Christian Borntraeger wrote: > On 24/04/14 10:51, Jens Freimann wrote: > > From: David Hildenbrand > > > > This patch creates empty function stubs (used by the gdbserver) in > > preparation > > for the hw debugging support by kvm on s390, which will enable th

[Qemu-devel] [PATCH 2/3] s390x/helper: Fixed real-to-absolute address translation

2014-04-24 Thread Jens Freimann
From: Thomas Huth The real-to-absolute address translation in mmu_translate() was missing the second part for translating the page at the prefix address back to the 0 page. And while we're at it, also moved the code into a separate helper function since this might come in handy for other parts of

[Qemu-devel] [PULL 0/2] vga: add secondary stdvga variant

2014-04-24 Thread Gerd Hoffmann
Hi, This series adds a standard vga variant which doesn't occupy any legacy ressources and thus can easily be used as secondary (or legacy-free) graphics adapter. Programming must be done using the MMIO bar. bochsdrm (linux 3.14+) can drive the card. You can use loginctl to attach the second

Re: [Qemu-devel] [PATCH v2 1/4] acpi/pcihp.c: Rewrite acpi_pcihp_get_bsel using object_property_get_int

2014-04-24 Thread Michael S. Tsirkin
On Thu, Apr 24, 2014 at 06:15:56PM +0400, Kirill Batuzov wrote: > acpi_pcihp_get_bsel implements functionality of object_property_get_int for > specific property named ACPI_PCIHP_PROP_BSEL, but fails to decrement object's > reference counter properly. Rewriting it using generic object_property_get_

[Qemu-devel] [PATCH 2/5] gtk: Fix monitor greeting

2014-04-24 Thread Cole Robinson
The monitor greeting is line wrapped like: QEMU 1.6.1 m onitor - typ e 'help' for more inform ation (qemu) Apparently requesting the vte terminal size isn't sufficient, we need to force a size_request so text doesn't line wrap. We use slightly different APIs for gtk3, since on 3.10 the size_requ

[Qemu-devel] [PATCH 4/5] blockdev: Clean up fragile use of error_is_set()

2014-04-24 Thread Markus Armbruster
Using error_is_set(ERRP) to find out whether a function failed is either wrong, fragile, or unnecessarily opaque. It's wrong when ERRP may be null, because errors go undetected when it is. It's fragile when proving ERRP non-null involves a non-local argument. Else, it's unnecessarily opaque (see

[Qemu-devel] [PATCH] monitor: fix qmp_getfd() fd leak in error case

2014-04-24 Thread Stefan Hajnoczi
qemu_chr_fe_get_msgfd() transfers ownership of the file descriptor to the caller. Therefore all code paths in qmp_getfd() should either register the file descriptor somewhere or close it. Signed-off-by: Stefan Hajnoczi --- monitor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/monitor.c

Re: [Qemu-devel] Cannot boot my VM image after switching to ahci.

2014-04-24 Thread John Baboval
I assume Windows 7 or newer? In order to speed boot time, Windows will remove the AHCI driver from the critical driver database when you boot with no AHCI controller on the bus. If you later want to switch to AHCI mode, you have to boot with IDE again, and re-add the AHCI driver, reboot, and t

[Qemu-devel] [PATCH 1/3] s390x: empty function stubs in preparation for __KVM_HAVE_GUEST_DEBUG

2014-04-24 Thread Jens Freimann
From: David Hildenbrand This patch creates empty function stubs (used by the gdbserver) in preparation for the hw debugging support by kvm on s390, which will enable the __KVM_HAVE_GUEST_DEBUG define in the linux headers and require these methods on the qemu side. Signed-off-by: David Hildenbran

Re: [Qemu-devel] [PATCH] ivshmem: fix potential OOB r/w access (#2)

2014-04-24 Thread Stefan Hajnoczi
On Wed, Apr 23, 2014 at 03:31:36PM +0200, Sebastian Krahmer wrote: Please put the patch revision number in the tags section of the commit message. This way git-am(1) automatically strips it when applying the patch. So: [PATCH] ivshmem: fix potential OOB r/w access (#2) should be: [PATCH v2] ivsh

Re: [Qemu-devel] [PATCH v2] block: Expose host_* drivers in blockdev-add

2014-04-24 Thread Stefan Hajnoczi
On Thu, Apr 24, 2014 at 03:02:39PM +0200, Kevin Wolf wrote: > All the functionality to use the host_device, host_cdrom and host_floppy > drivers is already there, they just need to be added to the schema. > > The block driver names containing underscores are preexisting and cannot > be changed wit

[Qemu-devel] [PATCH 4/5] gtk: Fix zoom in accelerator

2014-04-24 Thread Cole Robinson
The accelerator was ctrl+shift+'+', but '+' required a shift key already, so the accelerator didn't trigger. Switch it to ctrl+shift+'=' Signed-off-by: Cole Robinson --- ui/gtk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 117b0eb..45a61da 10

Re: [Qemu-devel] [PATCH microblaze v1 1/1] net: xilinx_axienet.c: Add phy soft reset bit clearing

2014-04-24 Thread Stefan Hajnoczi
On Tue, Apr 08, 2014 at 06:52:39PM -0700, Peter Crosthwaite wrote: > From: Nathan Rossi > > Clear the BMCR Reset when writing to registers. > > Signed-off-by: Nathan Rossi > [ PC: > * Trivial style fixes to commit message > ] > Signed-off-by: Peter Crosthwaite > --- > > hw/net/xilinx_axiene

Re: [Qemu-devel] [PATCH for-2.0 v2] tests: Don't run qom-test twice

2014-04-24 Thread Stefan Hajnoczi
On Mon, Apr 07, 2014 at 04:13:00PM +0200, Andreas Färber wrote: > Commit 3687d5325 accidentally resulted in running qom-test twice > for x86_64, once directly via the wildcard, and once because x86_64 > includes all the i386 qtests (which includes qom-test). > > Filter out x86_64 as well as microb

Re: [Qemu-devel] [PATCH 5/5] iscsi: Don't use error_is_set() to suppress additional errors

2014-04-24 Thread Kevin Wolf
Am 24.04.2014 um 11:15 hat Markus Armbruster geschrieben: > Using error_is_set(errp) that way can sweep programming errors under > the carpet when we get called incorrectly with an error set. > > Commit 24d3bd6 added a broken error path to iscsi_do_inquiry(): it > first calls error_setg(), then ju

[Qemu-devel] [PATCH 1/5] configure: Re-run make if gtkabi/sdlabi is changed

2014-04-24 Thread Cole Robinson
Reconfiguring with a different --with-gtkabi or --with-sdlabi doesn't trigger a remake. Generate an (unused) CONFIG_GTKABI/CONFIG_SDLABI so config-host.h will actually give 'make' something to trigger on. Signed-off-by: Cole Robinson --- configure | 2 ++ 1 file changed, 2 insertions(+) diff --

Re: [Qemu-devel] [ceph-users] qemu + rbd block driver with cache=writeback, is live migration safe ?

2014-04-24 Thread Alexandre DERUMIER
>>My recommendation would be to add that bdrv_invalidate() implementation, >>then we can be sure for raw, and get the rest fixed as well. They are a bug tracker about bdrv_invalidate(), closed 2 years ago http://tracker.ceph.com/issues/2467 Can we reopened it ? - Mail original - De:

Re: [Qemu-devel] [PATCH 3/3] s390x/helper: Added format control bit to MMU translation

2014-04-24 Thread Alexander Graf
On 24.04.14 17:34, Jens Freimann wrote: From: Thomas Huth With the EDAT-1 facility, the MMU translation can stop at the segment table already, pointing to a 1 MB block. Signed-off-by: Thomas Huth Signed-off-by: Jens Freimann Reviewed-by: David Hildenbrand --- target-s390x/cpu.h| 4 ++

[Qemu-devel] [PATCH v2 08/13] tcg-sparc: Tidy check_fit_* tests

2014-04-24 Thread Richard Henderson
Use sextract instead of raw bit shifting for the tests. Introduce a new check_fit_ptr macro to make it clear we're looking at pointers. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 35 --- 1 file changed, 20 insertions(+), 15 deletions(-) diff -

Re: [Qemu-devel] [PATCH 05/10] qtest: Be paranoid about accept() addrlen argument

2014-04-24 Thread Eric Blake
On 04/24/2014 06:55 AM, Eric Blake wrote: > On 04/24/2014 06:49 AM, Andreas Färber wrote: >> POSIX specifies that address_len shall on output specify the length of >> the stored address; it does not however specify whether it may get >> updated on failure as well to, e.g., zero. > > Your reading o

Re: [Qemu-devel] [Qemu-trivial] [PATCH v4 0/2] convert -m to QemuOpts

2014-04-24 Thread Michael Tokarev
Thanks, applied to trivial patches. Finally. /mjt

[Qemu-devel] [Bug 1288620] Re: memory leak with config file

2014-04-24 Thread Aidan Gauland
It does seem to be related to the guest, because with a dummy (non- bootable, garbage data) disk image, the rapid memory leak does not occur. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1288620 Tit

  1   2   >