On 24 April 2014 15:29, Stefan Hajnoczi <stefa...@redhat.com> wrote: > On Mon, Apr 07, 2014 at 04:13:00PM +0200, Andreas Färber wrote: >> Commit 3687d5325 accidentally resulted in running qom-test twice >> for x86_64, once directly via the wildcard, and once because x86_64 >> includes all the i386 qtests (which includes qom-test). >> >> Filter out x86_64 as well as microblazeel and xtensaeb to fix this. >> >> Cc: Peter Maydell <peter.mayd...@linaro.org> >> Signed-off-by: Andreas Färber <afaer...@suse.de> >> --- >> v1 (PMM) -> v2: >> * Instead of sorting all qtests, leave the order intact and just filter >> the three affected architectures out. >> >> tests/Makefile | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) > > Didn't make it into 2.0 but... > > Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
Personally I prefer the "just sort-and-uniquify" approach. This patch introduces an explicit list of architectures which need to be special case, which means that if we ever add a future arch variant which also needs this special casing we need to update the list. The sort patch doesn't have this requirement -- it will just work for both this and for any other reason why we might end up with a test in the list multiple times. thanks -- PMM
