Re: [Qemu-devel] E820 (Re: [v4 PATCH 00/12] SMBIOS: build full tables in QEMU)

2014-04-07 Thread Gerd Hoffmann
On Do, 2014-04-03 at 09:32 -0400, Gabriel L. Somlo wrote: > For that, ideally, I'd like to clone a git repo (and pull once > every few days to stay on top of things). Looks like the top-level > upstream one doesn't have your smbios code, so would there be a > "mid-stream" (for the lack of a better

Re: [Qemu-devel] [PATCH 30/35] pc: ACPI BIOS: name CPU hotplug ACPI0004 device

2014-04-07 Thread Igor Mammedov
On Sun, 6 Apr 2014 12:18:50 +0300 "Michael S. Tsirkin" wrote: > On Fri, Apr 04, 2014 at 03:36:55PM +0200, Igor Mammedov wrote: > > Following patches will add another ACPI0004 device > > to the same scope, and that will make Windows BSOD > > because it thinks that the second ACPI0004 device > > is

Re: [Qemu-devel] [PATCH v5 23/24] usb: sanity check setup_index+setup_len in post_load

2014-04-07 Thread Gerd Hoffmann
On Do, 2014-04-03 at 19:52 +0300, Michael S. Tsirkin wrote: > -if (dev->setup_index >= sizeof(dev->data_buf) || > +if (dev->setup_index < 0 || > +dev->setup_len < 0 || > +dev->setup_index >= sizeof(dev->data_buf) || > dev->setup_len >= sizeof(dev->data_buf)) { >

Re: [Qemu-devel] [PATCH 31/35] pc: ACPI BIOS: implement memory hotplug interface

2014-04-07 Thread Igor Mammedov
On Sun, 6 Apr 2014 12:13:36 +0300 "Michael S. Tsirkin" wrote: > On Fri, Apr 04, 2014 at 03:36:56PM +0200, Igor Mammedov wrote: > > - provides static SSDT object for memory hotplug > > - SSDT template for memory devices and runtime generator > > of them in SSDT table. > > > > Signed-off-by: Vas

Re: [Qemu-devel] [PATCH 00/35] pc: ACPI memory hotplug

2014-04-07 Thread Igor Mammedov
On Fri, 4 Apr 2014 17:57:28 +0100 "Dr. David Alan Gilbert" wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > > > > This series allows to hotplug 'arbitrary' DIMM devices specifying size, > > NUMA node mapping (guest side), slot and address where to map it, at > > runtime. > > Some hi

Re: [Qemu-devel] [PATCH for-2.0] dsdt: tweak ACPI ID for hotplug resource device

2014-04-07 Thread Igor Mammedov
On Sun, 6 Apr 2014 12:47:37 +0300 "Michael S. Tsirkin" wrote: > ACPI0004 seems too new: > Windows XP complains about an unrecognized device. > This is a regression since 1.7. > Use PNP0A06 instead - Generic Container Device. > > Signed-off-by: Michael S. Tsirkin > --- > > Note: Igor has RFC pa

Re: [Qemu-devel] E820 (Re: [v4 PATCH 00/12] SMBIOS: build full tables in QEMU)

2014-04-07 Thread Gerd Hoffmann
Hi, > > The only fly in this ointment may be that type 0 doesn't have a fixed > > length that could be edited in place, if you consider the various > > strings that get tacked on to the end of it. So you'd still have to > > slide the rest of the smbios payload left or right to shrink or > > enla

Re: [Qemu-devel] [PATCH v3 01/26] tcg-aarch64: Properly detect SIGSEGV writes

2014-04-07 Thread Claudio Fontana
On 03.04.2014 21:56, Richard Henderson wrote: > Since the kernel doesn't pass any info on the reason for the fault, > disassemble the instruction to detect a store. > > Signed-off-by: Richard Henderson > --- > user-exec.c | 29 +++-- > 1 file changed, 23 insertions(+), 6

Re: [Qemu-devel] [PATCH v2 1/2] usb-hid: Add high speed mouse configuration

2014-04-07 Thread Gerd Hoffmann
On Do, 2014-04-03 at 01:27 -0400, Ján Veselý wrote: > ping2 > > is there anything I can do to help these patches get merged? Well, v2 is a step into the right direction but not complete yet. The usb_ver property hasn't any effect for mouse and keyboard. Also we'll need a compat property so olde

Re: [Qemu-devel] [PATCH v3 11/26] tcg-aarch64: Reuse LR in translated code

2014-04-07 Thread Claudio Fontana
On 03.04.2014 21:56, Richard Henderson wrote: > It's obviously call-clobbered, but is otherwise unused. > Repurpose it as the TCG temporary. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 34 -- > tcg/aarch64/tcg-target.h | 32

Re: [Qemu-devel] [PATCH v3 4/4] gtk: Add "Grab On Click" option

2014-04-07 Thread Gerd Hoffmann
On Fr, 2014-04-04 at 12:41 +0200, Takashi Iwai wrote: > I simply like it better, you don't? :) I still think we should make this simply depend on absolute/relative pointer mode instead of asking the user to switch it manually. I'll quickly go put patches 1-3 into a 2.0 pull request, so debating p

Re: [Qemu-devel] [Qemu-trivial] [PATCH v4] scripts: add sample model file for Coverity Scan

2014-04-07 Thread Dr. David Alan Gilbert
* Michael Tokarev (m...@tls.msk.ru) wrote: > 26.03.2014 15:45, Paolo Bonzini wrote: > > This is the model file that is being used for the QEMU project's scans > > on scan.coverity.com. It fixed about 30 false positives (10% of the > > total) and exposed about 60 new memory leaks. > > > > The file

Re: [Qemu-devel] [PATCH 03/97] vmstate: return error in case of error

2014-04-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > If there is an error while loading a field, we should stop reading and > not continue with the rest of fields. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > vmstate.c | 3 +++ > 1 file changed, 3 insertions(+) > >

Re: [Qemu-devel] [PATCH v3 4/4] gtk: Add "Grab On Click" option

2014-04-07 Thread Takashi Iwai
At Mon, 07 Apr 2014 10:07:43 +0200, Gerd Hoffmann wrote: > > On Fr, 2014-04-04 at 12:41 +0200, Takashi Iwai wrote: > > I simply like it better, you don't? :) > > I still think we should make this simply depend on absolute/relative > pointer mode instead of asking the user to switch it manually.

Re: [Qemu-devel] [PATCH 80/97] vmstate: Create VMSTATE_SYNTHETIC

2014-04-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > It is used for fields that don't exist on the State. They are > generated on the fly for migration. While it's nicer than what's there before, I don't think this is the right fix for these fields, and I'd rather not encourage new uses like this. It

Re: [Qemu-devel] [Xen-devel] [PATCH 0/5] xen: add Intel IGD passthrough support

2014-04-07 Thread Ian Campbell
On Fri, 2014-04-04 at 18:46 -0400, Kevin O'Connor wrote: > On Fri, Feb 21, 2014 at 02:44:08PM +0800, Yang Zhang wrote: > > From: Yang Zhang > > > > The following patches are ported from Xen Qemu-traditional branch which are > > adding Intel IGD passthrough supporting to Qemu upstream. > > > > To

Re: [Qemu-devel] [PATCH for-2.0] dsdt: tweak ACPI ID for hotplug resource device

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 09:46:34AM +0200, Igor Mammedov wrote: > On Sun, 6 Apr 2014 12:47:37 +0300 > "Michael S. Tsirkin" wrote: > > > ACPI0004 seems too new: > > Windows XP complains about an unrecognized device. > > This is a regression since 1.7. > > Use PNP0A06 instead - Generic Container Dev

Re: [Qemu-devel] [PATCH 96/97] vmstate: Rename VMS_VBUFFER to VMST_VBUFFER_INT32 for consintency

2014-04-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > --- > include/migration/vmstate.h | 6 +++--- > vmstate.c | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h > index

[Qemu-devel] [PULL for-2.0 0/4] gtk: pointer fixes

2014-04-07 Thread Gerd Hoffmann
Hi, Last minute pointer fixes for gtk. And a MAINTAINERS update to help ui patches being picked up more timely in the future. please pull, Gerd The following changes since commit 466e6e9d13d56bbb6da1d2396d7d6347df483af0: target-i386: reorder fields in cpu/msr_hyperv_hypercall subsection

[Qemu-devel] [PULL 4/4] ui: Update MAINTAINERS entry.

2014-04-07 Thread Gerd Hoffmann
With Amazon eating Anthonys time status "Maintained" certainly isn't true any more. Update entry accordingly. Also add myself, so scripts/get_maintainer.pl will Cc: me, to reduce the chance ui patches fall through the cracks on our pretty loaded qemu-devel mailing list. Signed-off-by: Gerd Hoffm

[Qemu-devel] [PULL 1/4] gtk: Use gtk generic event signal instead of motion-notify-event

2014-04-07 Thread Gerd Hoffmann
From: Takashi Iwai The GDK motion-notify-event isn't generated when the pointer goes out of the target window even if the pointer is grabbed, which essentially means to lose the pointer tracking in gtk-ui. Meanwhile the generic "event" signal is sent when the pointer is grabbed, so we can use th

[Qemu-devel] [PULL 2/4] gtk: Fix the relative pointer tracking mode

2014-04-07 Thread Gerd Hoffmann
From: Takashi Iwai The relative pointer tracking mode was still buggy even after the previous fix of the motion-notify-event since the events are filtered out when the pointer moves outside the drawing window due to the boundary check for the absolute mode. This patch fixes the issue by moving t

Re: [Qemu-devel] [PATCH for-2.0] dsdt: tweak ACPI ID for hotplug resource device

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 10:57:02AM +0200, Igor Mammedov wrote: > On Sun, 6 Apr 2014 12:47:37 +0300 > "Michael S. Tsirkin" wrote: > > > ACPI0004 seems too new: > > Windows XP complains about an unrecognized device. > > This is a regression since 1.7. > > Use PNP0A06 instead - Generic Container Dev

[Qemu-devel] [PULL 3/4] gtk: Remember the last grabbed pointer position

2014-04-07 Thread Gerd Hoffmann
From: Takashi Iwai It's pretty annoying that the pointer reappears at a random place once after grabbing and ungrabbing the input. Better to restore to the original position where the pointer was grabbed. Reference: https://bugzilla.novell.com/show_bug.cgi?id=849587 Tested-by: Cole Robinson Re

Re: [Qemu-devel] [PATCH for-2.0] dsdt: tweak ACPI ID for hotplug resource device

2014-04-07 Thread Igor Mammedov
On Sun, 6 Apr 2014 12:47:37 +0300 "Michael S. Tsirkin" wrote: > ACPI0004 seems too new: > Windows XP complains about an unrecognized device. > This is a regression since 1.7. > Use PNP0A06 instead - Generic Container Device. > > Signed-off-by: Michael S. Tsirkin > --- > > Note: Igor has RFC pa

Re: [Qemu-devel] [Qemu-trivial] [PATCH v4] scripts: add sample model file for Coverity Scan

2014-04-07 Thread Michael Tokarev
26.03.2014 15:45, Paolo Bonzini wrote: > This is the model file that is being used for the QEMU project's scans > on scan.coverity.com. It fixed about 30 false positives (10% of the > total) and exposed about 60 new memory leaks. > > The file is not automatically used; changes to it must be propa

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Remove redundant message for -Werror

2014-04-07 Thread Michael Tokarev
15.03.2014 00:11, Stefan Weil wrote: > The compiler flag -Werror is printed (or not printed) as any other > compiler flag which is part of QEMU_CFLAGS. > > Therefore an extra output line for -Werror is redundant and can be removed. Applied - finally - to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH for 2.1 00/97] VMState simplification (massive)

2014-04-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Hi > > Look at the diffstat. Almost all the additions are at > test-vmstate.c. That is the reason why it is called a simplification. > > What this series does: > - peter removal of version_minimum_id_old field when not needed (Peter) > - cleanup:

[Qemu-devel] [PATCH] doc: grammify "allows to"

2014-04-07 Thread Michael Tokarev
English language grammar does not allow usage of the word "allows" directly followed by an infinitive, declaring constructs like "something allows to do somestuff" un-grammatical. Often it is possible to just insert "one" between "allows" and "to" to make the construct grammatical, but usually it

Re: [Qemu-devel] [PATCH v3 11/26] tcg-aarch64: Reuse LR in translated code

2014-04-07 Thread Peter Maydell
On 7 April 2014 09:03, Claudio Fontana wrote: > On 03.04.2014 21:56, Richard Henderson wrote: >> It's obviously call-clobbered, but is otherwise unused. >> Repurpose it as the TCG temporary. > Giving one last chance to the ARM guys to speak up about repurposing LR. Can you clarify what you think

Re: [Qemu-devel] [PATCH 96/97] vmstate: Rename VMS_VBUFFER to VMST_VBUFFER_INT32 for consintency

2014-04-07 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Signed-off-by: Juan Quintela >> --- >> include/migration/vmstate.h | 6 +++--- >> vmstate.c | 2 +- >> 2 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/include/migration/vmstat

Re: [Qemu-devel] [PATCH 80/97] vmstate: Create VMSTATE_SYNTHETIC

2014-04-07 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> It is used for fields that don't exist on the State. They are >> generated on the fly for migration. > > While it's nicer than what's there before, I don't think this is the > right fix for these fields, and I'd rat

Re: [Qemu-devel] [Qemu-trivial] [PATCH v4] scripts: add sample model file for Coverity Scan

2014-04-07 Thread Markus Armbruster
Michael Tokarev writes: > 26.03.2014 15:45, Paolo Bonzini wrote: >> This is the model file that is being used for the QEMU project's scans >> on scan.coverity.com. It fixed about 30 false positives (10% of the >> total) and exposed about 60 new memory leaks. >> >> The file is not automatically

Re: [Qemu-devel] [Xen-devel] Qemu 2.0 regression with xen: qemu crash on any domUs S.O. start

2014-04-07 Thread Fabio Fantoni
Il 03/04/2014 12:13, Fabio Fantoni ha scritto: Il 03/04/2014 10:45, Ian Campbell ha scritto: On Thu, 2014-04-03 at 10:15 +0200, Fabio Fantoni wrote: Seems that do segfault when I connect to vnc or spice, in the test of this backtrace after connect to vnc, spice and other things of my patches ar

[Qemu-devel] [PATCH trivial v2] doc: grammify "allows to"

2014-04-07 Thread Michael Tokarev
English language grammar does not allow usage of the word "allows" directly followed by an infinitive, declaring constructs like "something allows to do somestuff" un-grammatical. Often it is possible to just insert "one" between "allows" and "to" to make the construct grammatical, but usually it

Re: [Qemu-devel] [PATCH for 2.1 00/97] VMState simplification (massive)

2014-04-07 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Hi >> >> Look at the diffstat. Almost all the additions are at >> test-vmstate.c. That is the reason why it is called a simplification. >> >> What this series does: >> - peter removal of version_minimum_id_old f

Re: [Qemu-devel] Bug#728876: qemu: smbd forked by qemu uses global directory /var/run/samba/ncalrpc

2014-04-07 Thread Michael Tokarev
05.02.2014 13:49, Michael Tokarev wrote: > Ping? Again, more than 2 months passed since initial submission. Ping#2 ? Should it go to -trivial maybe? Thanks, /mjt > > 29.11.2013 00:15, Michael Tokarev wrote: >> Jan, there's one more samba-related fix for slirp, also from Michael Büsch. >> >> Ad

Re: [Qemu-devel] [Spice-devel] [Xen-devel] Qemu 2.0 regression with xen: qemu crash on any domUs S.O. start

2014-04-07 Thread Christophe Fergeau
On Mon, Apr 07, 2014 at 11:59:06AM +0200, Fabio Fantoni wrote: > > Today I did some tests also with hvm and spice and I found another > segfault with different backtrace to solve: > >(gdb) c > >Continuing. > > > >*Program received signal SIGSEGV, Segmentation fault.** > >**0x55855d30 in in

[Qemu-devel] [PULL 1/1] spice: monitors_config: check pointer before dereferencing

2014-04-07 Thread Gerd Hoffmann
Reported-by: Fabio Fantoni Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 4 1 file changed, 4 insertions(+) diff --git a/ui/spice-display.c b/ui/spice-display.c index e28698c..ce6b220 100644 --- a/ui/spice-display.c +++ b/ui/spice-display.c @@ -549,6 +549,10 @@ static int interface

[Qemu-devel] [PULL for-2.0 0/1] spice: monitors_config: check pointer before dereferencing

2014-04-07 Thread Gerd Hoffmann
Hi, Simple spice bugfix for 2.0. please pull, Gerd The following changes since commit 466e6e9d13d56bbb6da1d2396d7d6347df483af0: target-i386: reorder fields in cpu/msr_hyperv_hypercall subsection (2014-04-05 10:49:05 +0100) are available in the git repository at: git://anongit.freedes

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-07 Thread Michael S. Tsirkin
On Fri, Apr 04, 2014 at 03:36:53PM +0200, Igor Mammedov wrote: > Notify PIIX4_PM/ICH9LPC device about hotplug event, > so that it would send SCI to guest notifying about > newly added memory. > > Signed-off-by: Igor Mammedov > --- > hw/i386/pc.c | 13 + > 1 file changed, 13 insertion

[Qemu-devel] [PATCH] pass an inclusive address range to xc_domain_pin_memory_cacheattr

2014-04-07 Thread Stefano Stabellini
xc_domain_pin_memory_cacheattr expects an inclusive address range: adjust the parameters. Signed-off-by: Stefano Stabellini diff --git a/xen-all.c b/xen-all.c index ba34739..027e7a8 100644 --- a/xen-all.c +++ b/xen-all.c @@ -323,7 +323,7 @@ go_physmap: xc_domain_pin_memory_cacheattr(xen_x

[Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Marcel Apfelbaum
If a pci-2-pci bridge supports hot-plug functionality but there are no devices connected to it, reserve IO/mem in order to be able to attach devices later. Do not waste space, use minimum allowed. Signed-off-by: Marcel Apfelbaum --- src/fw/pciinit.c | 3 +++ src/hw/pci.c | 17 ++

Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive)

2014-04-07 Thread Peter Maydell
On 7 April 2014 04:20, Juan Quintela wrote: > After previous Peter patch, they are redundant. This way we don't asign them > except when needed. Once there, there were lots of case where the ".fields" > indentation was wrong: > > .fields = (VMStateField []) { > and > .fields = (VM

Re: [Qemu-devel] [PATCH v3 11/26] tcg-aarch64: Reuse LR in translated code

2014-04-07 Thread Claudio Fontana
On 07.04.2014 11:49, Peter Maydell wrote: > On 7 April 2014 09:03, Claudio Fontana wrote: >> On 03.04.2014 21:56, Richard Henderson wrote: >>> It's obviously call-clobbered, but is otherwise unused. >>> Repurpose it as the TCG temporary. > >> Giving one last chance to the ARM guys to speak up abo

Re: [Qemu-devel] [PATCH v3 11/26] tcg-aarch64: Reuse LR in translated code

2014-04-07 Thread Peter Maydell
On 7 April 2014 12:11, Claudio Fontana wrote: [your mail client is generating very long lines] > My doubt was about the AAPCS64 (Procedure Call standard for the > ARM 64-bit Architecture), and what the platforms in our case dictate > regarding FP and LR use. > > I think that LR should be ok to use

Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic

2014-04-07 Thread Michael S. Tsirkin
On Fri, Apr 04, 2014 at 03:36:48PM +0200, Igor Mammedov wrote: > ... and report error if plugged in device is not supported. > Later generic callbacks will be used by memory hotplug. > > Signed-off-by: Igor Mammedov OK in that case, how about teaching all hotplug callbacks about this? There ar

[Qemu-devel] LAST CALL for 2.0 patches/pulls

2014-04-07 Thread Peter Maydell
Hi; the release schedule for 2.0 is currently that we will tag an rc2 on Tuesday, and (assuming no critical issues found in testing it) that will then be tagged as the final 2.0 on Wednesday. So if you have any further pull requests for 2.0 please get them onto the list by the end of today (Monday

Re: [Qemu-devel] [PATCH v3 24/26] tcg-aarch64: Replace aarch64_ldst_op_data with AArch64LdstType

2014-04-07 Thread Claudio Fontana
On 03.04.2014 21:56, Richard Henderson wrote: > The definition of op_type wasn't encoded for the proper shift for > the field, making the implementations confusing. > > Signed-off-by: Richard Henderson At the end of the day the magic values remain in the load/store instructions though. Can we f

Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive)

2014-04-07 Thread Juan Quintela
Peter Maydell wrote: > On 7 April 2014 04:20, Juan Quintela wrote: >> After previous Peter patch, they are redundant. This way we don't asign them >> except when needed. Once there, there were lots of case where the ".fields" >> indentation was wrong: >> >> .fields = (VMStateField []) { >>

Re: [Qemu-devel] [PULL for-2.0 0/4] gtk: pointer fixes

2014-04-07 Thread Peter Maydell
On 7 April 2014 09:56, Gerd Hoffmann wrote: > Hi, > > Last minute pointer fixes for gtk. And a MAINTAINERS update > to help ui patches being picked up more timely in the future. > > please pull, > Gerd > > The following changes since commit 466e6e9d13d56bbb6da1d2396d7d6347df483af0: > > targ

Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive)

2014-04-07 Thread Peter Maydell
On 7 April 2014 12:47, Juan Quintela wrote: > Peter Maydell wrote: >> I'm really not a fan of this kind of single patch that >> touches a huge number of files at once. They're basically >> impossible to review and they introduce the possibility >> of conflicts between submaintainer tree changes a

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Gerd Hoffmann
On Mo, 2014-04-07 at 13:59 +0300, Marcel Apfelbaum wrote: > If a pci-2-pci bridge supports hot-plug functionality but there are no devices > connected to it, reserve IO/mem in order to be able to attach devices > later. Do not waste space, use minimum allowed. Makes sense. > +u8 shpc_cap

Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic

2014-04-07 Thread Igor Mammedov
On Mon, 7 Apr 2014 14:32:41 +0300 "Michael S. Tsirkin" wrote: > On Fri, Apr 04, 2014 at 03:36:48PM +0200, Igor Mammedov wrote: > > ... and report error if plugged in device is not supported. > > Later generic callbacks will be used by memory hotplug. > > > > Signed-off-by: Igor Mammedov > > >

Re: [Qemu-devel] [PULL for-2.0 0/1] spice: monitors_config: check pointer before dereferencing

2014-04-07 Thread Peter Maydell
On 7 April 2014 11:21, Gerd Hoffmann wrote: > Hi, > > Simple spice bugfix for 2.0. > > please pull, > Gerd > > The following changes since commit 466e6e9d13d56bbb6da1d2396d7d6347df483af0: > > target-i386: reorder fields in cpu/msr_hyperv_hypercall subsection > (2014-04-05 10:49:05 +0100) >

Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 02:00:37PM +0200, Igor Mammedov wrote: > On Mon, 7 Apr 2014 14:32:41 +0300 > "Michael S. Tsirkin" wrote: > > > On Fri, Apr 04, 2014 at 03:36:48PM +0200, Igor Mammedov wrote: > > > ... and report error if plugged in device is not supported. > > > Later generic callbacks wil

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 02:01:41PM +0200, Gerd Hoffmann wrote: > On Mo, 2014-04-07 at 13:59 +0300, Marcel Apfelbaum wrote: > > If a pci-2-pci bridge supports hot-plug functionality but there are no > > devices > > connected to it, reserve IO/mem in order to be able to attach devices > > later. Do

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 01:59:02PM +0300, Marcel Apfelbaum wrote: > If a pci-2-pci bridge supports hot-plug functionality but there are no devices > connected to it, reserve IO/mem in order to be able to attach devices > later. Do not waste space, use minimum allowed. > > Signed-off-by: Marcel Apf

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Marcel Apfelbaum
On Mon, 2014-04-07 at 15:11 +0300, Michael S. Tsirkin wrote: > On Mon, Apr 07, 2014 at 02:01:41PM +0200, Gerd Hoffmann wrote: > > On Mo, 2014-04-07 at 13:59 +0300, Marcel Apfelbaum wrote: > > > If a pci-2-pci bridge supports hot-plug functionality but there are no > > > devices > > > connected to

Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive)

2014-04-07 Thread Markus Armbruster
Peter Maydell writes: > On 7 April 2014 12:47, Juan Quintela wrote: >> Peter Maydell wrote: >>> I'm really not a fan of this kind of single patch that >>> touches a huge number of files at once. They're basically >>> impossible to review and they introduce the possibility >>> of conflicts betwe

Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive)

2014-04-07 Thread Peter Maydell
On 7 April 2014 13:21, Markus Armbruster wrote: > Peter Maydell writes: > >> On 7 April 2014 12:47, Juan Quintela wrote: >>> Peter Maydell wrote: >> Like I said, one patch per maintained subsystem, >> one patch for the leftovers. > > Easier said than done. MAINTAINERS has more than 100 section

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Gerd Hoffmann
Hi, > > +u8 shpc_cap = pci_find_capability(s->bus_dev, PCI_CAP_ID_SHPC); > One thing I'd do is maybe check that the relevant memory type is > enabled in the bridge (probably just by writing fff to base and reading > it back). > This will give hypervisors an option to avoid wasting reso

Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive)

2014-04-07 Thread Juan Quintela
Markus Armbruster wrote: > Peter Maydell writes: > >> On 7 April 2014 12:47, Juan Quintela wrote: >>> Peter Maydell wrote: I'm really not a fan of this kind of single patch that touches a huge number of files at once. They're basically impossible to review and they introduce the

Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive)

2014-04-07 Thread Juan Quintela
Peter Maydell wrote: > On 7 April 2014 13:21, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 7 April 2014 12:47, Juan Quintela wrote: Peter Maydell wrote: >>> Like I said, one patch per maintained subsystem, >>> one patch for the leftovers. >> >> Easier said than done. MAINT

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Marcel Apfelbaum
On Mon, 2014-04-07 at 14:44 +0200, Gerd Hoffmann wrote: > Hi, > > > > +u8 shpc_cap = pci_find_capability(s->bus_dev, PCI_CAP_ID_SHPC); > > > One thing I'd do is maybe check that the relevant memory type is > > enabled in the bridge (probably just by writing fff to base and reading > > i

[Qemu-devel] [PATCH] spapr_pci: Fix number of returned vectors in ibm, change-msi

2014-04-07 Thread Alexey Kardashevskiy
Current guest kernels try allocating as many vectors as the quota is. For example, in the case of virtio-net (which has just 3 vectors) the guest requests 4 vectors (that is the quota in the test) and the existing ibm,change-msi handler returns 4. But before it returns, it calls msix_set_message()

[Qemu-devel] [SeaBIOS] [PATCH V2] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Marcel Apfelbaum
If a pci-2-pci bridge supports hot-plug functionality but there are no devices connected to it, reserve IO/mem in order to be able to attach devices later. Do not waste space, use minimum allowed. Signed-off-by: Marcel Apfelbaum --- - Thanks Gerd Hoffmann for the review. v1 -> v2: - Addressed M

Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic

2014-04-07 Thread Igor Mammedov
On Mon, 7 Apr 2014 15:07:15 +0300 "Michael S. Tsirkin" wrote: > On Mon, Apr 07, 2014 at 02:00:37PM +0200, Igor Mammedov wrote: > > On Mon, 7 Apr 2014 14:32:41 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Fri, Apr 04, 2014 at 03:36:48PM +0200, Igor Mammedov wrote: > > > > ... and report er

Re: [Qemu-devel] [PATCH for 2.1 00/97] VMState simplification (massive)

2014-04-07 Thread Marcel Apfelbaum
On Mon, 2014-04-07 at 05:20 +0200, Juan Quintela wrote: > Hi > > Look at the diffstat. Almost all the additions are at > test-vmstate.c. That is the reason why it is called a simplification. > > What this series does: > - peter removal of version_minimum_id_old field when not needed (Peter) >

Re: [Qemu-devel] [Spice-devel] [Xen-devel] Qemu 2.0 regression with xen: qemu crash on any domUs S.O. start

2014-04-07 Thread Fabio Fantoni
Il 07/04/2014 12:20, Christophe Fergeau ha scritto: On Mon, Apr 07, 2014 at 11:59:06AM +0200, Fabio Fantoni wrote: Today I did some tests also with hvm and spice and I found another segfault with different backtrace to solve: (gdb) c Continuing. *Program received signal SIGSEGV, Segmentation f

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-07 Thread Igor Mammedov
On Mon, 7 Apr 2014 13:23:54 +0300 "Michael S. Tsirkin" wrote: > On Fri, Apr 04, 2014 at 03:36:53PM +0200, Igor Mammedov wrote: > > Notify PIIX4_PM/ICH9LPC device about hotplug event, > > so that it would send SCI to guest notifying about > > newly added memory. > > > > Signed-off-by: Igor Mammed

Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 03:12:11PM +0200, Igor Mammedov wrote: > On Mon, 7 Apr 2014 15:07:15 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, Apr 07, 2014 at 02:00:37PM +0200, Igor Mammedov wrote: > > > On Mon, 7 Apr 2014 14:32:41 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Fri, A

Re: [Qemu-devel] [PATCH for-2.0] Makefile: remove bashism

2014-04-07 Thread Peter Maydell
On 5 April 2014 15:25, Michael Tokarev wrote: > When installing modules (when --enable-modules is specified for > ./configure), Makefile uses the following construct to replace all > slashes with dashes in module name: > > ${s//\//-} > > This is a bash-specific substitution mechanism. POSIX does

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 02:44:06PM +0200, Gerd Hoffmann wrote: > Hi, > > > > +u8 shpc_cap = pci_find_capability(s->bus_dev, PCI_CAP_ID_SHPC); > > > One thing I'd do is maybe check that the relevant memory type is > > enabled in the bridge (probably just by writing fff to base and readin

Re: [Qemu-devel] [PATCH for-2.0 v2] fw-path-provider: Change GPL version to 2+

2014-04-07 Thread Andreas Färber
Am 26.03.2014 15:19, schrieb Alexey Kardashevskiy: > On 03/27/2014 01:13 AM, Alexey Kardashevskiy wrote: >> Cc: Andreas Färber >> Signed-off-by: Alexey Kardashevskiy > > Ah, this one is missing "suggested-by". And Paolo's "sob". Posting patches > is tough :) > > >> --- >> >> Changes: >> v2: >>

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Marcel Apfelbaum
On Mon, 2014-04-07 at 16:34 +0300, Michael S. Tsirkin wrote: > On Mon, Apr 07, 2014 at 02:44:06PM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > > +u8 shpc_cap = pci_find_capability(s->bus_dev, PCI_CAP_ID_SHPC); > > > > > One thing I'd do is maybe check that the relevant memory type is >

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Marcel Apfelbaum
On Mon, 2014-04-07 at 16:51 +0300, Marcel Apfelbaum wrote: > On Mon, 2014-04-07 at 16:34 +0300, Michael S. Tsirkin wrote: > > On Mon, Apr 07, 2014 at 02:44:06PM +0200, Gerd Hoffmann wrote: > > > Hi, > > > > > > > > +u8 shpc_cap = pci_find_capability(s->bus_dev, > > > > > PCI_CAP_ID_SHPC

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 04:51:54PM +0300, Marcel Apfelbaum wrote: > On Mon, 2014-04-07 at 16:34 +0300, Michael S. Tsirkin wrote: > > On Mon, Apr 07, 2014 at 02:44:06PM +0200, Gerd Hoffmann wrote: > > > Hi, > > > > > > > > +u8 shpc_cap = pci_find_capability(s->bus_dev, > > > > > PCI_CAP_

[Qemu-devel] [PATCH for-2.0 v2] tests: Don't run qom-test twice

2014-04-07 Thread Andreas Färber
Commit 3687d5325 accidentally resulted in running qom-test twice for x86_64, once directly via the wildcard, and once because x86_64 includes all the i386 qtests (which includes qom-test). Filter out x86_64 as well as microblazeel and xtensaeb to fix this. Cc: Peter Maydell Signed-off-by: Andrea

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-07 Thread Eduardo Habkost
On Mon, Apr 07, 2014 at 01:07:53PM +1000, Alexey Kardashevskiy wrote: > On 04/05/2014 12:36 AM, Igor Mammedov wrote: > > Notify PIIX4_PM/ICH9LPC device about hotplug event, > > so that it would send SCI to guest notifying about > > newly added memory. > > > > Signed-off-by: Igor Mammedov > > ---

Re: [Qemu-devel] E820 (Re: [v4 PATCH 00/12] SMBIOS: build full tables in QEMU)

2014-04-07 Thread Kevin O'Connor
On Mon, Apr 07, 2014 at 09:09:56AM +0200, Gerd Hoffmann wrote: > > > The only fly in this ointment may be that type 0 doesn't have a fixed > > > length that could be edited in place, if you consider the various > > > strings that get tacked on to the end of it. So you'd still have to > > > slide th

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Marcel Apfelbaum
On Mon, 2014-04-07 at 17:09 +0300, Michael S. Tsirkin wrote: > On Mon, Apr 07, 2014 at 04:51:54PM +0300, Marcel Apfelbaum wrote: [...] > > > > I don't think we'll need that for the SHPC bridge. > > > > > > Why not? > > Because "has shpc" => not an PCIe port. (as far as I know) > > Anyway, why have

Re: [Qemu-devel] [PATCH v3 1/1] char/serial: Fix emptyness handling

2014-04-07 Thread Peter Maydell
On 4 April 2014 13:13, Peter Crosthwaite wrote: > On Fri, Mar 28, 2014 at 10:10 PM, Paolo Bonzini wrote: >> Il 28/03/2014 12:43, Don Slutz ha scritto: >> >>> Ping. (Since this is a bug fix, I think it can go into 2.0) >>> -Don Slutz >> >> >> I think the problem is that not many people unders

Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic

2014-04-07 Thread Igor Mammedov
On Mon, 7 Apr 2014 16:25:30 +0300 "Michael S. Tsirkin" wrote: > On Mon, Apr 07, 2014 at 03:12:11PM +0200, Igor Mammedov wrote: > > On Mon, 7 Apr 2014 15:07:15 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Apr 07, 2014 at 02:00:37PM +0200, Igor Mammedov wrote: > > > > On Mon, 7 Apr 201

Re: [Qemu-devel] [Spice-devel] [Xen-devel] Qemu 2.0 regression with xen: qemu crash on any domUs S.O. start

2014-04-07 Thread Fabio Fantoni
Il 07/04/2014 15:19, Fabio Fantoni ha scritto: Il 07/04/2014 12:20, Christophe Fergeau ha scritto: On Mon, Apr 07, 2014 at 11:59:06AM +0200, Fabio Fantoni wrote: Today I did some tests also with hvm and spice and I found another segfault with different backtrace to solve: (gdb) c Continuing.

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/3] int128.h: Avoid undefined behaviours involving signed arithmetic

2014-04-07 Thread Richard Henderson
On 04/06/2014 08:27 AM, Peter Maydell wrote: > (if C compilers had a "behave > like a sane 2s complement system for signed arithmetic" > option I'd be advocating for us using it...) -fwrapv. r~

Re: [Qemu-devel] [PATCH v3 24/26] tcg-aarch64: Replace aarch64_ldst_op_data with AArch64LdstType

2014-04-07 Thread Richard Henderson
On 04/07/2014 04:45 AM, Claudio Fontana wrote: > On 03.04.2014 21:56, Richard Henderson wrote: >> The definition of op_type wasn't encoded for the proper shift for >> the field, making the implementations confusing. >> >> Signed-off-by: Richard Henderson > > At the end of the day the magic values

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-07 Thread Igor Mammedov
On Mon, 7 Apr 2014 13:23:54 +0300 "Michael S. Tsirkin" wrote: > On Fri, Apr 04, 2014 at 03:36:53PM +0200, Igor Mammedov wrote: > > Notify PIIX4_PM/ICH9LPC device about hotplug event, > > so that it would send SCI to guest notifying about > > newly added memory. > > > > Signed-off-by: Igor Mammed

Re: [Qemu-devel] E820 (Re: [v4 PATCH 00/12] SMBIOS: build full tables in QEMU)

2014-04-07 Thread Laszlo Ersek
On 04/07/14 16:14, Kevin O'Connor wrote: > On Mon, Apr 07, 2014 at 09:09:56AM +0200, Gerd Hoffmann wrote: The only fly in this ointment may be that type 0 doesn't have a fixed length that could be edited in place, if you consider the various strings that get tacked on to the end of i

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-07 Thread Igor Mammedov
On Mon, 7 Apr 2014 11:13:01 -0300 Eduardo Habkost wrote: > On Mon, Apr 07, 2014 at 01:07:53PM +1000, Alexey Kardashevskiy wrote: > > On 04/05/2014 12:36 AM, Igor Mammedov wrote: > > > Notify PIIX4_PM/ICH9LPC device about hotplug event, > > > so that it would send SCI to guest notifying about > >

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/3] int128.h: Avoid undefined behaviours involving signed arithmetic

2014-04-07 Thread Peter Maydell
On 7 April 2014 15:25, Richard Henderson wrote: > On 04/06/2014 08:27 AM, Peter Maydell wrote: >> (if C compilers had a "behave >> like a sane 2s complement system for signed arithmetic" >> option I'd be advocating for us using it...) > > -fwrapv. Well, we should use that then :-) thanks -- PMM

[Qemu-devel] [PATCH 2.0] ppce500_spin: Initialize struct properly

2014-04-07 Thread Alexander Graf
The spinning struct is in guest endianness, so we need to initialize its variables in guest endianness too. This fixes booting e500 guests with SMP on x86 for me. Signed-off-by: Alexander Graf --- hw/ppc/ppce500_spin.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw

Re: [Qemu-devel] E820 (Re: [v4 PATCH 00/12] SMBIOS: build full tables in QEMU)

2014-04-07 Thread Gabriel L. Somlo
On Mon, Apr 07, 2014 at 10:14:36AM -0400, Kevin O'Connor wrote: > How about having QEMU produce the smbios table with a dummy type0 > table and then both seabios and ovmf can replace the type0 table if > desired. After all, if OVMF is splitting the blob into tables, it can > just as easily replace

[Qemu-devel] [PATCH] monitor: QEMU Monitor Instruction Disassembly Incorrect for PowerPC LE Mode

2014-04-07 Thread Tom Musta
The monitor support for disassembling instructions does not honor the MSR[LE] bit for PowerPC processors. This change enhances the monitor_disas() routine by supporting a flag bit for Little Endian mode. Bit 16 is used since that bit was used in the analagous guest disassembly routine target_disa

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/3] int128.h: Avoid undefined behaviours involving signed arithmetic

2014-04-07 Thread Avi Kivity
On 04/06/2014 01:18 PM, Peter Maydell wrote: On 6 April 2014 08:09, Michael Tokarev wrote: 28.03.2014 19:12, Peter Maydell wrote: Add casts when we're performing arithmetic on the .hi parts of an Int128, to avoid undefined behaviour. [] static inline Int128 int128_sub(Int128 a, Int128 b)

Re: [Qemu-devel] [PATCH] monitor: QEMU Monitor Instruction Disassembly Incorrect for PowerPC LE Mode

2014-04-07 Thread Peter Maydell
On 7 April 2014 15:50, Tom Musta wrote: > The monitor support for disassembling instructions does not honor the MSR[LE] > bit for PowerPC processors. > > This change enhances the monitor_disas() routine by supporting a flag bit > for Little Endian mode. Bit 16 is used since that bit was used in t

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 04:32:16PM +0200, Igor Mammedov wrote: > On Mon, 7 Apr 2014 13:23:54 +0300 > "Michael S. Tsirkin" wrote: > > > On Fri, Apr 04, 2014 at 03:36:53PM +0200, Igor Mammedov wrote: > > > Notify PIIX4_PM/ICH9LPC device about hotplug event, > > > so that it would send SCI to guest

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/3] int128.h: Avoid undefined behaviours involving signed arithmetic

2014-04-07 Thread Peter Maydell
On 7 April 2014 15:56, Avi Kivity wrote: > On 04/06/2014 01:18 PM, Peter Maydell wrote: >> The alternative would be to say that Int128 should have >> undefined behaviour on underflow/overflow and the test >> code is wrong, but that doesn't seem very useful to me. > Isn't the test broken here? It

Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 04:25:30PM +0300, Michael S. Tsirkin wrote: > On Mon, Apr 07, 2014 at 03:12:11PM +0200, Igor Mammedov wrote: > > On Mon, 7 Apr 2014 15:07:15 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Apr 07, 2014 at 02:00:37PM +0200, Igor Mammedov wrote: > > > > On Mon, 7 Apr

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/3] int128.h: Avoid undefined behaviours involving signed arithmetic

2014-04-07 Thread Avi Kivity
On 04/07/2014 06:17 PM, Peter Maydell wrote: On 7 April 2014 15:56, Avi Kivity wrote: On 04/06/2014 01:18 PM, Peter Maydell wrote: The alternative would be to say that Int128 should have undefined behaviour on underflow/overflow and the test code is wrong, but that doesn't seem very useful to

  1   2   >