[Qemu-devel] Bus in Malta Mips

2014-03-24 Thread Ayaz Akram
Does malta mips use both pci and isa bus for its emulation? In hw/mips_malta.c file I have seen most devices connected to pci bus but there are some ISA devices like i8259. Can someone with deeper understanding explain what is happening in this particular file?

[Qemu-devel] [PULL for-2, 0 0/1] spice: input: Fix absolute mouse y coordinates

2014-03-24 Thread Gerd Hoffmann
Hi, Very short spice patch queue, with a single line bugfix for 2.0. please pull, Gerd The following changes since commit 3a87f8b6859e6221b827ab4737779dddb37553ec: Merge remote-tracking branch 'remotes/afaerber/tags/ppc-for-2.0' into staging (2014-03-20 11:45:38 +) are available in

[Qemu-devel] [PULL 1/1] spice: input: Fix absolute mouse y coordinates

2014-03-24 Thread Gerd Hoffmann
From: Cole Robinson Current tablet + spice is unusable. Regressed with the UI input rework. Signed-off-by: Cole Robinson Signed-off-by: Gerd Hoffmann --- ui/spice-input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/spice-input.c b/ui/spice-input.c index 6dab23b..c34

Re: [Qemu-devel] multihead & multiseat in qemu

2014-03-24 Thread Gerd Hoffmann
Hi, > > I'd like to have some way to assign tags such as seat=foo or head=1 to > > devices. Preferably in some way which can easily picked up with udev > > rules, so it is easily usable by system-logind and Xorg server. > > The only current example of seat autoconfiguration is for the usb hubs

[Qemu-devel] [PATCH] Fixed various typos

2014-03-24 Thread Deepak Kathayat
Signed-off-by: Deepak Kathayat --- block/gluster.c |2 +- block/qcow.c |2 +- block/sheepdog.c |8 block/vdi.c |2 +- block/vhdx-log.c |2 +- slirp/tftp.c |2 +- 6 files changed, 9 insertions(+), 9 deletions(-) diff --git a/block/gluster.c b/block/

Re: [Qemu-devel] multihead & multiseat in qemu

2014-03-24 Thread Gerd Hoffmann
Hi, > > I'd like to have some way to assign tags such as seat=foo or head=1 to > > devices. Preferably in some way which can easily picked up with udev > > rules, so it is easily usable by system-logind and Xorg server. > > Can't you just do this in the serial number strings for both monitor E

[Qemu-devel] [Bug 1293975] Re: Guest is destroyed after live migration

2014-03-24 Thread Robert Hu
kvm.git + qemu.git: 94b3ffcd_f71e769d after live migration, the guest works fine. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1293975 Title:

Re: [Qemu-devel] [PATCH v3 0/4] KVM: irqfds for s390

2014-03-24 Thread Christian Borntraeger
On 21/03/14 13:52, Cornelia Huck wrote: > Hi, > > here's the next iteration of my patchset introducing irqfds for s390. > > Changes from v2: > - rebased against current kvm/queue > - kvm common code lock fix is already in queue > - move some changes that belonged in patch 2 from patch 3 > - add a

Re: [Qemu-devel] [PATCH 5/6] linux-user: remove duplicate statement

2014-03-24 Thread Riku Voipio
On Sun, Mar 23, 2014 at 02:58:42PM +0530, Prasad Joshi wrote: > Signed-off-by: Prasad Joshi a Acked-by: Riku Voipio > --- > linux-user/signal.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/linux-user/signal.c b/linux-user/signal.c > index e5fb933..7d6246f 100644 > --- a/linux-user

Re: [Qemu-devel] [RFC 4/8] qdev: link based hotplug

2014-03-24 Thread Igor Mammedov
On Fri, 21 Mar 2014 12:45:01 +0100 Paolo Bonzini wrote: > Il 21/03/2014 11:35, Igor Mammedov ha scritto: > > On Thu, 20 Mar 2014 19:03:57 +0100 > > Paolo Bonzini wrote: > > > >> Il 20/03/2014 17:20, Igor Mammedov ha scritto: > > > > What about just looking up on the QOM tree until you f

Re: [Qemu-devel] [PATCHv2] block: introduce BDRV_O_SEQUENTIAL

2014-03-24 Thread Fam Zheng
On Fri, 03/21 12:49, Peter Lieven wrote: > this patch introduces a new flag to indicate that we are going to sequentially > read from a file and do not plan to reread/reuse the data after it has been > read. > > The current use of this flag is to open the source(s) of a qemu-img convert > process

Re: [Qemu-devel] [PATCH] Fixed various typos

2014-03-24 Thread Andreas Färber
Hi, Am 24.03.2014 09:30, schrieb Deepak Kathayat: > Signed-off-by: Deepak Kathayat > --- > block/gluster.c |2 +- > block/qcow.c |2 +- > block/sheepdog.c |8 > block/vdi.c |2 +- > block/vhdx-log.c |2 +- > slirp/tftp.c |2 +- > 6 files changed, 9

Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-03-24 Thread Peter Maydell
On 24 March 2014 05:53, Alexey Kardashevskiy wrote: > On 03/23/2014 08:23 AM, Peter Maydell wrote: >> Oops, I hadn't noticed that; this patch is incorrect, then, because >> vmstate_ohci needs to include a line for the OHCIState, and we >> need a second vmstate struct for the OHCIState. > Sorry bu

Re: [Qemu-devel] multihead & multiseat in qemu

2014-03-24 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > Hi, > > > > I'd like to have some way to assign tags such as seat=foo or head=1 to > > > devices. Preferably in some way which can easily picked up with udev > > > rules, so it is easily usable by system-logind and Xorg server. > > > > Can't you jus

[Qemu-devel] [PATCH] display/qxl: don't abort on reset with non empty rings

2014-03-24 Thread Alon Levy
The command ring and cursor rings are pushed to by the guest, and cleared asynchronously by qemu's spice thread. It is easy to have them non empty by bad guest behaviour, and we must never abort on bad guest behaviour. Signed-off-by: Alon Levy --- hw/display/qxl.c | 8 ++-- 1 file changed, 6

Re: [Qemu-devel] [PATCH v2 1/1] Make qemu_peek_buffer loop until it gets it's data

2014-03-24 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 03/21/2014 01:30 PM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Make qemu_peek_buffer repatedly call fill_buffer until it gets > > all the data it requires, or until there is an error. > > > > At the moment, qemu_

[Qemu-devel] Aarch64 MLS bug

2014-03-24 Thread Laurent Desnogues
Hello, the code that implements Aarch64 AdvSIMD MLS instruction looks like this: if (opcode == 0xf || opcode == 0x12) { /* SABA, UABA, MLA, MLS: accumulating ops */ static NeonGenTwoOpFn * const fns[3][2] = { { gen_helper_neon_add_u8

[Qemu-devel] [PATCH v3] scripts: add sample model file for Coverity Scan

2014-03-24 Thread Paolo Bonzini
This is the model file that is being used for the QEMU project's scans on scan.coverity.com. It fixed about 30 false positives (10% of the total) and exposed about 60 new memory leaks. The file is not automatically used; changes to it must be propagated to the website manually by an admin (right

[Qemu-devel] [PATCH for-2.0 V4] tests/acpi-test: do not fail if iasl is broken

2014-03-24 Thread Marcel Apfelbaum
There is an issue with iasl on big endian machines: It cannot disassemble acpi tables taken from little endian machines, so we cannot check the expected tables. The acpi test will check if the expected aml files can be disassembled, and will issue an warning not failing the test on those machines

Re: [Qemu-devel] [PATCH] tmp105: read temperature in milli-celsius

2014-03-24 Thread Paolo Bonzini
Il 17/02/2014 13:08, Andreas Färber ha scritto: Am 17.02.2014 11:57, schrieb Paolo Bonzini: Right now, the temperature property must be written in milli-celsius, but it reads back the value in 8.8 fixed point. Fix this by letting the property read back the original value (possibly rounded). Al

Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-03-24 Thread Gerd Hoffmann
Hi, > It looks like you don't need to save USBPacket or USBPort > fields, since the other USB controllers don't (though I'm not > sure why not -- Gerd, do you know why this is OK?). Most state info is in guest memory. Any unfinished usb transfers are simply restarted on the target host. This

Re: [Qemu-devel] [PATCH for-2.0 V4] tests/acpi-test: do not fail if iasl is broken

2014-03-24 Thread Andreas Färber
Am 24.03.2014 11:02, schrieb Marcel Apfelbaum: > There is an issue with iasl on big endian machines: It > cannot disassemble acpi tables taken from little endian > machines, so we cannot check the expected tables. > > The acpi test will check if the expected aml files > can be disassembled, and wi

Re: [Qemu-devel] [RFC 3/8] pc: prepare PC for custom machine state

2014-03-24 Thread Igor Mammedov
On Sun, 23 Mar 2014 17:13:37 +0200 Marcel Apfelbaum wrote: > On Thu, 2014-03-20 at 16:01 +0100, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > hw/i386/pc.c | 26 ++ > > hw/i386/pc_piix.c| 34 +- > > hw/i3

Re: [Qemu-devel] [PATCH v3 0/4] KVM: irqfds for s390

2014-03-24 Thread Paolo Bonzini
Il 24/03/2014 09:46, Christian Borntraeger ha scritto: > here's the next iteration of my patchset introducing irqfds for s390. > > Changes from v2: > - rebased against current kvm/queue > - kvm common code lock fix is already in queue > - move some changes that belonged in patch 2 from patch 3 >

Re: [Qemu-devel] [PATCH for-2.0 V4] tests/acpi-test: do not fail if iasl is broken

2014-03-24 Thread Michael S. Tsirkin
On Mon, Mar 24, 2014 at 12:02:33PM +0200, Marcel Apfelbaum wrote: > There is an issue with iasl on big endian machines: It > cannot disassemble acpi tables taken from little endian > machines, so we cannot check the expected tables. > > The acpi test will check if the expected aml files > can be d

Re: [Qemu-devel] [RFC 3/8] pc: prepare PC for custom machine state

2014-03-24 Thread Andreas Färber
Am 23.03.2014 16:13, schrieb Marcel Apfelbaum: > On Thu, 2014-03-20 at 16:01 +0100, Igor Mammedov wrote: >> Signed-off-by: Igor Mammedov >> --- >> hw/i386/pc.c | 26 ++ >> hw/i386/pc_piix.c| 34 +- >> hw/i386/pc_q35.c |

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

2014-03-24 Thread Andreas Färber
Am 23.03.2014 10:49, schrieb Michael S. Tsirkin: > On Fri, Mar 21, 2014 at 12:16:53AM +0100, Paolo Bonzini wrote: >> Il 20/03/2014 23:33, Marcel Apfelbaum ha scritto: >>> I've seen something like that somewhere, but I didn't quite like it. >>> I was looking for something more elegant as I was *almo

[Qemu-devel] Qemu custom chardev

2014-03-24 Thread Tanase Sebastian
Hello everybody, I am working on a project that aims to measure how a gui guest application performs (and by performs I mean whether the virtual time is advancing more rapidly than the host time) with different icounts (aka. different guest cpu frequencies). I would like to know if I

Re: [Qemu-devel] multihead & multiseat in qemu

2014-03-24 Thread Gerd Hoffmann
On Mo, 2014-03-24 at 09:36 +, Dr. David Alan Gilbert wrote: > * Gerd Hoffmann (kra...@redhat.com) wrote: > > Hi, > > > > > > I'd like to have some way to assign tags such as seat=foo or head=1 to > > > > devices. Preferably in some way which can easily picked up with udev > > > > rules, so

Re: [Qemu-devel] [RFC 3/8] pc: prepare PC for custom machine state

2014-03-24 Thread Michael S. Tsirkin
On Mon, Mar 24, 2014 at 11:52:45AM +0100, Andreas Färber wrote: > Am 23.03.2014 16:13, schrieb Marcel Apfelbaum: > > On Thu, 2014-03-20 at 16:01 +0100, Igor Mammedov wrote: > >> Signed-off-by: Igor Mammedov > >> --- > >> hw/i386/pc.c | 26 ++ > >> hw/i386/pc_piix

Re: [Qemu-devel] multihead & multiseat in qemu

2014-03-24 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > On Mo, 2014-03-24 at 09:36 +, Dr. David Alan Gilbert wrote: > > * Gerd Hoffmann (kra...@redhat.com) wrote: > > > Hi, > > > > > > > > I'd like to have some way to assign tags such as seat=foo or head=1 to > > > > > devices. Preferably in some way

[Qemu-devel] [PULL 00/15] acpi,pc,test bug fixes

2014-03-24 Thread Michael S. Tsirkin
The following changes since commit 13f65b2e1073cf7e2c8fb3880c77d8a53fa2f95e: acpi-test: update expected SSDT files (2014-03-11 13:27:27 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to dac23a6c

[Qemu-devel] [PULL 03/15] acpi: Add ACPI_CPU_HOTPLUG_ID_LIMIT macro

2014-03-24 Thread Michael S. Tsirkin
From: Eduardo Habkost The new macro will be helpful to allow us to detect too large SMP limits before it is too late. Signed-off-by: Eduardo Habkost Reviewed-by: Laszlo Ersek Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/cpu_hotplug_defs.h | 8 +++

[Qemu-devel] [PULL 04/15] pc: Refuse CPU hotplug if the resulting APIC ID is too large

2014-03-24 Thread Michael S. Tsirkin
From: Eduardo Habkost The ACPI CPU hotplug code requires APIC IDs to be smaller than ACPI_CPU_HOTPLUG_ID_LIMIT, so enforce the limit before trying to hotplug a new vCPU, returning an error instead of crashing. Signed-off-by: Eduardo Habkost Reviewed-by: Laszlo Ersek Reviewed-by: Michael S. Tsi

[Qemu-devel] [PULL 08/15] i386/acpi-build: allow more than 255 elements in CPON

2014-03-24 Thread Michael S. Tsirkin
From: Laszlo Ersek The build_ssdt() function builds a number of AML objects that are related to CPU hotplug, and whose IDs form a contiguous sequence of APIC IDs. (APIC IDs are in fact discontiguous, but this is the traditional interface: build a contiguous sequence from zero up that covers all p

[Qemu-devel] [PULL 07/15] pc: Refuse max_cpus if it results in too large APIC ID

2014-03-24 Thread Michael S. Tsirkin
From: Eduardo Habkost This changes the PC initialization code to reject max_cpus if it results in an APIC ID that's too large, instead of aborting or erroring out when it is already too late. Signed-off-by: Eduardo Habkost Reviewed-by: Laszlo Ersek Reviewed-by: Michael S. Tsirkin Signed-off-b

[Qemu-devel] [PULL 09/15] acpi-test: rebuild SSDT

2014-03-24 Thread Michael S. Tsirkin
commit 9bcc80cd71892df42605e0c097d85c0237ff45d1 i386/acpi-build: allow more than 255 elements in CPON Replaces 0x1 with a smaller One constant. rebuild expected SSDT. Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/pc/SSDT | Bin 2261 -> 2261 bytes tests/acpi-test-data/q35/SSDT

[Qemu-devel] [PULL 06/15] acpi: Don't use MAX_CPUMASK_BITS for APIC ID bitmap

2014-03-24 Thread Michael S. Tsirkin
From: Eduardo Habkost MAX_CPUMASK_BITS is a limit for max_cpus and CPU indexes, not for APIC IDs. ACPI_CPU_HOTPLUG_ID_LIMIT is the right macro for the limit on APIC IDs on the ACPI and CPU hotplug code. There are no functional changes introduced by this patch, as MAX_CPUMASK_BITS + 1 == 255 + 1

[Qemu-devel] [PULL 02/15] acpi-test: update expected SSDT files

2014-03-24 Thread Michael S. Tsirkin
commit 13f65b2e1073cf7e2c8fb3880c77d8a53fa2f95e acpi-test: update expected SSDT files set an incorrect SSDT. rebuild it. Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/pc/SSDT | Bin 2363 -> 2261 bytes tests/acpi-test-data/q35/SSDT | Bin 652 -> 550 bytes 2 files changed, 0 ins

[Qemu-devel] [PULL 14/15] vl.c: Use MAX_CPUMASK_BITS macro instead of hardcoded constant

2014-03-24 Thread Michael S. Tsirkin
From: Eduardo Habkost Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index c8a5bfa..23e1dbd 100644 --- a/vl.c +++ b/vl.c @@ -1413,7 +1413,7 @@ static void

[Qemu-devel] [PULL 05/15] acpi: Assert sts array limit on AcpiCpuHotplug_add()

2014-03-24 Thread Michael S. Tsirkin
From: Eduardo Habkost AcpiCpuHotplug_add() can't handle vCPU arch IDs larger than ACPI_CPU_HOTPLUG_ID_LIMIT. Instead of corrupting memory in case the vCPU ID is too large, use g_assert() to ensure we are not over the limit. Signed-off-by: Eduardo Habkost Reviewed-by: Laszlo Ersek Reviewed-by:

[Qemu-devel] [PULL 10/15] i386/acpi-build: support hotplug of VCPU with APIC ID 0xFF

2014-03-24 Thread Michael S. Tsirkin
From: Laszlo Ersek Building on the previous patch, raise the maximal count of processor objects / NTFY branches / CPON elements from 255 to 256. This allows the VCPU with APIC ID 0xFF to be hotplugged. Signed-off-by: Laszlo Ersek Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirki

[Qemu-devel] [PULL 15/15] tests/acpi-test: do not fail if iasl is broken

2014-03-24 Thread Michael S. Tsirkin
From: Marcel Apfelbaum There is an issue with iasl on big endian machines: It cannot disassemble acpi tables taken from little endian machines, so we cannot check the expected tables. The acpi test will check if the expected aml files can be disassembled, and will issue an warning not failing th

[Qemu-devel] [PULL 11/15] acpi-test: signature endian-ness fixes

2014-03-24 Thread Michael S. Tsirkin
acpi table signature is really an ASCII string. Treat it as such in tests. Signed-off-by: Michael S. Tsirkin --- tests/acpi-test.c | 48 +--- 1 file changed, 33 insertions(+), 15 deletions(-) diff --git a/tests/acpi-test.c b/tests/acpi-test.c index 18

[Qemu-devel] [PULL 12/15] acpi: fix endian-ness for table ids

2014-03-24 Thread Michael S. Tsirkin
when using signature for table ID, we forgot to byte-swap it. signatures are really ASCII strings, let's treat them as such. While at it, get rid of most of _SIGNATURE macros. Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-defs.h | 14 -- hw/i386/acpi-build.c | 31 ++

Re: [Qemu-devel] multihead & multiseat in qemu

2014-03-24 Thread Gerd Hoffmann
> > > > Indeed. Patch sent to systemd-devel to get that fixed. > > Yes, what are the logistics of when QEMU could change without breaking things. There aren't any explicit rules. Also depends on the use case. We better should not change the default serial number for a number of years, to not

[Qemu-devel] [PULL 13/15] sysemu.h: Document what MAX_CPUMASK_BITS really limits

2014-03-24 Thread Michael S. Tsirkin
From: Eduardo Habkost Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/sysemu/sysemu.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index b90df9a..90f192a 100644 --- a/i

[Qemu-devel] [PULL 01/15] acpi-build: fix misaligned access

2014-03-24 Thread Michael S. Tsirkin
clang build reported a misaligned access: runtime error: store to misaligned address 0x2b5aa47dfb19 for type 'uint16_t' (aka 'unsigned short'), which requires 2 byte alignment 0x2b5aa47dfb19: note: pointer points here 45 53 54 0b ff ff 5b 80 50 45 4f 52 01 50 45 53 54 01 5b 81 0

[Qemu-devel] [PATCH v5] net: L2TPv3 transport

2014-03-24 Thread anton . ivanov
From: Anton Ivanov This transport allows to connect a QEMU nic to a static Ethernet over L2TPv3 tunnel. The transport supports all options present in the Linux kernel implementation. It allows QEMU to connect to any Linux host running kernel 3.3+, most routers and network devices as well as other

Re: [Qemu-devel] [RFC 3/8] pc: prepare PC for custom machine state

2014-03-24 Thread Andreas Färber
Am 24.03.2014 12:20, schrieb Michael S. Tsirkin: > On Mon, Mar 24, 2014 at 11:52:45AM +0100, Andreas Färber wrote: >> Am 23.03.2014 16:13, schrieb Marcel Apfelbaum: >>> On Thu, 2014-03-20 at 16:01 +0100, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/i386/pc.c |

Re: [Qemu-devel] [PATCH 01/26] tcg-aarch64: Properly detect SIGSEGV writes

2014-03-24 Thread Claudio Fontana
On 15.03.2014 03:48, Richard Henderson wrote: > Since the kernel doesn't pass any info on the reason for the fault, > disassemble the instruction to detect a store. > > Signed-off-by: Richard Henderson > --- > user-exec.c | 29 +++-- > 1 file changed, 23 insertions(+), 6

Re: [Qemu-devel] [PATCH 01/26] tcg-aarch64: Properly detect SIGSEGV writes

2014-03-24 Thread Claudio Fontana
On 15.03.2014 03:48, Richard Henderson wrote: > Since the kernel doesn't pass any info on the reason for the fault, > disassemble the instruction to detect a store. > > Signed-off-by: Richard Henderson > --- > user-exec.c | 29 +++-- > 1 file changed, 23 insertions(+), 6

Re: [Qemu-devel] [PATCH 02/26] tcg-aarch64: Use intptr_t apropriately

2014-03-24 Thread Claudio Fontana
On 15.03.2014 03:48, Richard Henderson wrote: > As opposed to tcg_target_long. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c > index 66

Re: [Qemu-devel] [RFC 3/8] pc: prepare PC for custom machine state

2014-03-24 Thread Marcel Apfelbaum
On Mon, 2014-03-24 at 11:52 +0100, Andreas Färber wrote: > Am 23.03.2014 16:13, schrieb Marcel Apfelbaum: > > On Thu, 2014-03-20 at 16:01 +0100, Igor Mammedov wrote: > >> Signed-off-by: Igor Mammedov > >> --- > >> hw/i386/pc.c | 26 ++ > >> hw/i386/pc_piix.c|

Re: [Qemu-devel] [PATCH for-2.0 V4] tests/acpi-test: do not fail if iasl is broken

2014-03-24 Thread Marcel Apfelbaum
On Mon, 2014-03-24 at 11:33 +0100, Andreas Färber wrote: > Am 24.03.2014 11:02, schrieb Marcel Apfelbaum: > > There is an issue with iasl on big endian machines: It > > cannot disassemble acpi tables taken from little endian > > machines, so we cannot check the expected tables. > > > > The acpi te

Re: [Qemu-devel] [PATCH 01/26] tcg-aarch64: Properly detect SIGSEGV writes

2014-03-24 Thread Peter Maydell
On 15 March 2014 02:48, Richard Henderson wrote: > Since the kernel doesn't pass any info on the reason for the fault, > disassemble the instruction to detect a store. I've been trying to prod the kernel people to add that but the patches got stuck in review :-( thanks -- PMM

Re: [Qemu-devel] [RFC 4/8] qdev: link based hotplug

2014-03-24 Thread Andreas Färber
Am 21.03.2014 11:35, schrieb Igor Mammedov: > BTW not related to hotplug but why I used link<>s: > > I've added link<>s as an attempt to visualize Andreas' idea to use them for Anthony's :) > hotplug and mgmt. It has it's own benefits if we try to provide more or > less uniform QOM interface vie

Re: [Qemu-devel] [RFC 3/8] pc: prepare PC for custom machine state

2014-03-24 Thread Marcel Apfelbaum
On Mon, 2014-03-24 at 11:34 +0100, Igor Mammedov wrote: > On Sun, 23 Mar 2014 17:13:37 +0200 > Marcel Apfelbaum wrote: > > > On Thu, 2014-03-20 at 16:01 +0100, Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov > > > --- > > > hw/i386/pc.c | 26 ++ > > > h

Re: [Qemu-devel] [PATCH 01/26] tcg-aarch64: Properly detect SIGSEGV writes

2014-03-24 Thread Peter Maydell
On 15 March 2014 02:48, Richard Henderson wrote: > Since the kernel doesn't pass any info on the reason for the fault, > disassemble the instruction to detect a store. Incidentally, I've been wondering if we could improve handle_cpu_signal so that at least the "check if this fault was because we

Re: [Qemu-devel] [PATCH 03/26] tcg-aarch64: Use TCGType and TCGMemOp constants

2014-03-24 Thread Claudio Fontana
On 15.03.2014 03:48, Richard Henderson wrote: > Rather than raw constants that could mean anything. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 71 > +--- > 1 file changed, 37 insertions(+), 34 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH for-2.0 V4] tests/acpi-test: do not fail if iasl is broken

2014-03-24 Thread Andreas Färber
Am 24.03.2014 11:42, schrieb Michael S. Tsirkin: > On Mon, Mar 24, 2014 at 12:02:33PM +0200, Marcel Apfelbaum wrote: >> There is an issue with iasl on big endian machines: It >> cannot disassemble acpi tables taken from little endian >> machines, so we cannot check the expected tables. >> >> The ac

Re: [Qemu-devel] [PATCH for-2.0 v2] configure: add workaround for SystemTap PR13296

2014-03-24 Thread Stefan Hajnoczi
On Fri, Mar 21, 2014 at 12:39:54PM -0400, Frank Ch. Eigler wrote: > Hi - > > On Fri, Mar 21, 2014 at 04:28:24PM +0100, Stefan Hajnoczi wrote: > > SystemTap sdt.h sometimes results in compiled probes without sufficient > > information to extract arguments. See code comment for details on this > >

Re: [Qemu-devel] [PATCH v2 1/1] Make qemu_peek_buffer loop until it gets it's data

2014-03-24 Thread Eric Blake
On 03/24/2014 03:52 AM, Dr. David Alan Gilbert wrote: >> s/-ve/negative/ - it is not an obvious abbreviation, and I only knew >> what it meant because you have been told to fix it in other patches. > > If I need to recut it for another reason I'll change it. > However, it's a perfectly common abb

Re: [Qemu-devel] [PATCH 4/6] monitor: Remove unused monitor_print_filename

2014-03-24 Thread Luiz Capitulino
On Sat, 22 Mar 2014 21:06:41 +0100 Andreas Färber wrote: > Am 12.03.2014 00:15, schrieb Cole Robinson: > > Cc: Luiz Capitulino > > Cc: Markus Armbruster > > Signed-off-by: Cole Robinson > > Given that it even had its own stub file, the commit message should > please explain why it is no longe

Re: [Qemu-devel] [RFC 4/8] qdev: link based hotplug

2014-03-24 Thread Michael S. Tsirkin
On Mon, Mar 24, 2014 at 01:20:46PM +0100, Andreas Färber wrote: > Am 21.03.2014 11:35, schrieb Igor Mammedov: > > BTW not related to hotplug but why I used link<>s: > > > > I've added link<>s as an attempt to visualize Andreas' idea to use them for > > Anthony's :) > > > hotplug and mgmt. It has

Re: [Qemu-devel] [RFC PATCH V3 2/5] qapi: add event helper functions

2014-03-24 Thread Eric Blake
On 03/23/2014 06:53 PM, Wenchao Xia wrote: > 于 2014/3/21 6:53, Eric Blake 写道: >> On 03/18/2014 11:16 PM, Wenchao Xia wrote: >>> This file hold some functions that do not need to be generated. >> s/hold/holds/ >> >>> + >>> +typedef struct QMPEventFunctions { >>> +QMPEventFuncEmit emit; >>> +} Q

Re: [Qemu-devel] [PATCH 3/6] pcnet: remove duplicate assignment

2014-03-24 Thread Stefan Hajnoczi
On Sun, Mar 23, 2014 at 02:58:40PM +0530, Prasad Joshi wrote: > Signed-off-by: Prasad Joshi > --- > hw/net/pcnet.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH 6/6] net: netmap_poll must update both read/write poll state

2014-03-24 Thread Stefan Hajnoczi
On Sun, Mar 23, 2014 at 02:58:43PM +0530, Prasad Joshi wrote: > Signed-off-by: Prasad Joshi > --- > net/netmap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH for-2.0 V4] tests/acpi-test: do not fail if iasl is broken

2014-03-24 Thread Stefan Hajnoczi
On Mon, Mar 24, 2014 at 02:17:10PM +0200, Marcel Apfelbaum wrote: > On Mon, 2014-03-24 at 11:33 +0100, Andreas Färber wrote: > > Am 24.03.2014 11:02, schrieb Marcel Apfelbaum: > > > There is an issue with iasl on big endian machines: It > > > cannot disassemble acpi tables taken from little endian

Re: [Qemu-devel] [PATCH for-2.0 V4] tests/acpi-test: do not fail if iasl is broken

2014-03-24 Thread Peter Maydell
On 24 March 2014 13:23, Stefan Hajnoczi wrote: > Did you try running gtester without -q or even with -v? (You can edit > tests/Makefile to do that.) ...or use make V=1. thanks -- PMM

Re: [Qemu-devel] [PATCH for-2.0 V4] tests/acpi-test: do not fail if iasl is broken

2014-03-24 Thread Marcel Apfelbaum
On Mon, 2014-03-24 at 13:24 +, Peter Maydell wrote: > On 24 March 2014 13:23, Stefan Hajnoczi wrote: > > Did you try running gtester without -q or even with -v? (You can edit > > tests/Makefile to do that.) > > ...or use make V=1. I'll try both, but do we really want to run make check with e

Re: [Qemu-devel] [PATCH 4/6] monitor: Remove unused monitor_print_filename

2014-03-24 Thread Andreas Färber
Am 24.03.2014 14:09, schrieb Luiz Capitulino: > On Sat, 22 Mar 2014 21:06:41 +0100 > Andreas Färber wrote: > >> Am 12.03.2014 00:15, schrieb Cole Robinson: >>> Cc: Luiz Capitulino >>> Cc: Markus Armbruster >>> Signed-off-by: Cole Robinson >> >> Given that it even had its own stub file, the com

Re: [Qemu-devel] [PATCH for-2.0 V4] tests/acpi-test: do not fail if iasl is broken

2014-03-24 Thread Marcel Apfelbaum
On Mon, 2014-03-24 at 13:24 +, Peter Maydell wrote: > On 24 March 2014 13:23, Stefan Hajnoczi wrote: > > Did you try running gtester without -q or even with -v? (You can edit > > tests/Makefile to do that.) > > ...or use make V=1. I tried the verbose mode, no g_test_message output. Thanks,

[Qemu-devel] [PATCH] migration: Fix possible bug for migrate cancel

2014-03-24 Thread arei.gonglei
From: zengjunliang Return error for migrate cancel, when migration status is not MIG_STATE_SETUP or MIG_STATE_ACTIVE. Thus, libvirt can can perceive the operation fails. Signed-off-by: zengjunliang Signed-off-by: Gonglei --- include/qapi/qmp/qerror.h | 3 +++ migration.c | 5 +++

Re: [Qemu-devel] [PATCH 1/6] audio: set top level latch for each slot

2014-03-24 Thread Peter Maydell
On 24 March 2014 13:19, Stefan Hajnoczi wrote: > On Sun, Mar 23, 2014 at 02:58:38PM +0530, Prasad Joshi wrote: >> CSMKeyControll function is supposed to set the top level latch for each >> slot. However, at the moment, it incorrectly updates only the first >> slot. Patch fixes the problem. >> >> S

Re: [Qemu-devel] [PATCH 1/6] audio: set top level latch for each slot

2014-03-24 Thread Stefan Hajnoczi
On Sun, Mar 23, 2014 at 02:58:38PM +0530, Prasad Joshi wrote: > CSMKeyControll function is supposed to set the top level latch for each > slot. However, at the moment, it incorrectly updates only the first > slot. Patch fixes the problem. > > Signed-off-by: Prasad Joshi > --- > hw/audio/fmopl.c

[Qemu-devel] QEMU working

2014-03-24 Thread Mohammed Umar Shaikh Habib Ali
Hi, I am interested in finding out steps taken by QEMU when it emulates a Sparc V8 processor architecture and boots an OS. I was following the source-code directly and was directly tracing it, but this seems to be the tougher job and i have no result till now. So can you please tell me what are

Re: [Qemu-devel] [PATCHv2] block: introduce BDRV_O_SEQUENTIAL

2014-03-24 Thread Peter Lieven
Am 24.03.2014 10:18, schrieb Fam Zheng: > On Fri, 03/21 12:49, Peter Lieven wrote: >> this patch introduces a new flag to indicate that we are going to >> sequentially >> read from a file and do not plan to reread/reuse the data after it has been >> read. >> >> The current use of this flag is to

Re: [Qemu-devel] [PATCH 06/26] tcg-aarch64: Special case small constants in tcg_out_movi

2014-03-24 Thread Claudio Fontana
On 15.03.2014 03:48, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c > index 0f23e43..417f51a 100644 > --- a/tcg/aarch64/tcg-targe

Re: [Qemu-devel] [PATCH] migration: Fix possible bug for migrate cancel

2014-03-24 Thread Eric Blake
On 03/24/2014 07:04 AM, arei.gong...@huawei.com wrote: > From: zengjunliang > > Return error for migrate cancel, when migration status is not > MIG_STATE_SETUP or MIG_STATE_ACTIVE. Thus, libvirt can can > perceive the operation fails. > > Signed-off-by: zengjunliang > Signed-off-by: Gonglei >

Re: [Qemu-devel] [PATCH v2 07/12] block/json: Add bdrv_co_get_block_status()

2014-03-24 Thread Benoît Canet
The Friday 07 Mar 2014 à 23:55:51 (+0100), Max Reitz wrote : > Implement this function in the same way as raw_bsd does: Acknowledge > that this is a passthrough driver (always return BDRV_BLOCK_OFFSET_VALID > and BDRV_BLOCK_DATA and derive the offset directly from the sector > index) and add BDRV_B

Re: [Qemu-devel] [PATCH 1/6] audio: set top level latch for each slot

2014-03-24 Thread Andreas Färber
Am 24.03.2014 14:22, schrieb Peter Maydell: > On 24 March 2014 13:19, Stefan Hajnoczi wrote: >> On Sun, Mar 23, 2014 at 02:58:38PM +0530, Prasad Joshi wrote: >>> CSMKeyControll function is supposed to set the top level latch for each >>> slot. However, at the moment, it incorrectly updates only th

Re: [Qemu-devel] [PATCH 04/26] tcg-aarch64: Use MOVN in tcg_out_movi

2014-03-24 Thread Claudio Fontana
On 15.03.2014 03:48, Richard Henderson wrote: > When profitable, initialize the register with MOVN instead of MOVZ, > before setting the remaining lanes with MOVK. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 62 > ++-- > 1

Re: [Qemu-devel] [PATCH v2 12/12] iotests: Add test for the JSON protocol

2014-03-24 Thread Benoît Canet
The Friday 07 Mar 2014 à 23:55:56 (+0100), Max Reitz wrote : > Add a test for the JSON protocol driver. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/084 | 123 > + > tests/qemu-iotests/084.out | 39 ++ > tests/qemu-iotests/

Re: [Qemu-devel] [PATCH 2/6] intc/openpic_kvm: fix MemListener delete regiion callback function

2014-03-24 Thread Andreas Färber
Am 23.03.2014 10:28, schrieb Prasad Joshi: > Signed-off-by: Prasad Joshi > --- > hw/intc/openpic_kvm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for spotting this, applied to ppc-next (w/ typo fix in subject): https://github.com/afaerber/qemu-cpu/commits/ppc-next Andreas -

Re: [Qemu-devel] [PATCH for-2.0 V4] tests/acpi-test: do not fail if iasl is broken

2014-03-24 Thread Andreas Färber
Am 24.03.2014 14:24, schrieb Peter Maydell: > On 24 March 2014 13:23, Stefan Hajnoczi wrote: >> Did you try running gtester without -q or even with -v? (You can edit >> tests/Makefile to do that.) > > ...or use make V=1. V=1 I already tried. (And I also suggested to use that for Travis since ot

Re: [Qemu-devel] [PATCH for-2.0 V4] tests/acpi-test: do not fail if iasl is broken

2014-03-24 Thread Marcel Apfelbaum
On Mon, 2014-03-24 at 15:43 +0200, Marcel Apfelbaum wrote: > On Mon, 2014-03-24 at 13:24 +, Peter Maydell wrote: > > On 24 March 2014 13:23, Stefan Hajnoczi wrote: > > > Did you try running gtester without -q or even with -v? (You can edit > > > tests/Makefile to do that.) > > > > ...or use

Re: [Qemu-devel] [PATCH 07/26] tcg-aarch64: Use adrp in tcg_out_movi

2014-03-24 Thread Claudio Fontana
On 15.03.2014 03:48, Richard Henderson wrote: > Loading an qemu pointer as an immediate happens often. E.g. > > - exit_tb $0x7fa8140013 > + exit_tb $0x7f81ee0013 > ... > - : d2800260mov x0, #0x13 > - : f2b50280movkx0, #0xa814, lsl #16 > - : f2c00fe0movkx0, #

Re: [Qemu-devel] [PATCH 05/26] tcg-aarch64: Use ORRI in tcg_out_movi

2014-03-24 Thread Claudio Fontana
On 15.03.2014 03:48, Richard Henderson wrote: > The subset of logical immediates that we support is quite quick to test, > and such constants are quite common to want to load. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 70 > +++---

[Qemu-devel] [RFC v2 0/5] state loading security issues

2014-03-24 Thread Michael S. Tsirkin
In an attempt to provide a generic solution for this set of issues, this adds a way to add validators in the middle of the structure. On failure, we assert on output (should never happen) and fail migration on input. The last patch in the series shows how the new infrastructure is used. I'll wait

[Qemu-devel] [RFC v2 1/5] vmstate: reduce code duplication

2014-03-24 Thread Michael S. Tsirkin
move size offset and number of elements math out to functions, to reduce code duplication. Signed-off-by: Michael S. Tsirkin --- vmstate.c | 97 ++- 1 file changed, 52 insertions(+), 45 deletions(-) diff --git a/vmstate.c b/vmstate.c i

[Qemu-devel] [RFC v2 4/5] vmstate: add VMSTATE_TEST

2014-03-24 Thread Michael S. Tsirkin
Can validate state using VMS_NONE and VMS_MUST_EXIST Signed-off-by: Michael S. Tsirkin --- include/migration/vmstate.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index eb90cef..e220f09 100644 --- a/include/migration/vmstate

[Qemu-devel] [RFC v2 2/5] vmstate: add VMS_NONE

2014-03-24 Thread Michael S. Tsirkin
The element with this flags value is skipped. Signed-off-by: Michael S. Tsirkin --- include/migration/vmstate.h | 1 + vmstate.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index e7e1705..3a15

[Qemu-devel] [RFC v2 3/5] vmstate: add VMS_MUST_EXIST

2014-03-24 Thread Michael S. Tsirkin
Can be used to verify a required field exists or validate state in some other way. Signed-off-by: Michael S. Tsirkin --- include/migration/vmstate.h | 1 + vmstate.c | 10 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/include/migration/vmstate.h b/i

[Qemu-devel] [RFC v2 5/5] hpet: fix buffer overrun on invalid state load

2014-03-24 Thread Michael S. Tsirkin
CVE-2013-4527 hw/timer/hpet.c buffer overrun hpet is a VARRAY with a uint8 size but static array of 32 To fix, make sure num_timers is valid using VMSTATE_TEST hook. Reported-by: Anthony Liguori Signed-off-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/timer/hpet.c | 17 +++

Re: [Qemu-devel] [PATCH v3] scripts: add sample model file for Coverity Scan

2014-03-24 Thread Eric Blake
On 03/24/2014 04:01 AM, Paolo Bonzini wrote: > This is the model file that is being used for the QEMU project's scans > on scan.coverity.com. It fixed about 30 false positives (10% of the > total) and exposed about 60 new memory leaks. > > The file is not automatically used; changes to it must be

Re: [Qemu-devel] [RFC PATCH 02/12] migration: migrate icount fields.

2014-03-24 Thread Frederic Konrad
On 22/03/2014 09:57, Paolo Bonzini wrote: Il 21/03/2014 20:17, fred.kon...@greensocs.com ha scritto: From: KONRAD Frederic This fixes a bug where qemu_icount and qemu_icount_bias are not migrated. Signed-off-by: KONRAD Frederic --- cpus.c | 23 ++- 1 file changed, 22 i

Re: [Qemu-devel] n ways block filters

2014-03-24 Thread Benoît Canet
The Thursday 20 Mar 2014 à 17:06:26 (+0100), Benoît Canet wrote : > The Thursday 20 Mar 2014 à 16:12:34 (+0100), Kevin Wolf wrote : > > Am 20.03.2014 um 15:05 hat Benoît Canet geschrieben: > > > The Tuesday 18 Mar 2014 à 14:27:47 (+0100), Kevin Wolf wrote : > > > > Am 17.03.2014 um 17:02 hat Stefan

Re: [Qemu-devel] [PATCH v22 00/25] replace QEMUOptionParameter with QemuOpts

2014-03-24 Thread Leandro Dorileo
Hi Chunyan, On Mon, Mar 24, 2014 at 11:02:14AM +0800, Chunyan Liu wrote: > 2014-03-21 20:31 GMT+08:00 Leandro Dorileo : > > > On Fri, Mar 21, 2014 at 06:09:22PM +0800, Chunyan Liu wrote: > > > 2014-03-21 8:07 GMT+08:00 Leandro Dorileo : > > > > > > > Hi Chunyan, > > > > > > > > On Mon, Mar 10, 20

Re: [Qemu-devel] [PATCH] qcow2: Remove FIXME comment, already fixed

2014-03-24 Thread Leandro Dorileo
On Mon, Mar 24, 2014 at 02:06:15PM +0800, Deepak Kathayat wrote: > > Signed-off-by: Deepak Kathayat Reviewed-by: Leandro Dorileo > --- > block/qcow2.h |1 - > 1 file changed, 1 deletion(-) > > diff --git a/block/qcow2.h b/block/qcow2.h > index 0b0eac8..25663d4 100644 > --- a/block/qcow2.

  1   2   >