Am 24.03.2014 14:09, schrieb Luiz Capitulino: > On Sat, 22 Mar 2014 21:06:41 +0100 > Andreas Färber <afaer...@suse.de> wrote: > >> Am 12.03.2014 00:15, schrieb Cole Robinson: >>> Cc: Luiz Capitulino <lcapitul...@redhat.com> >>> Cc: Markus Armbruster <arm...@redhat.com> >>> Signed-off-by: Cole Robinson <crobi...@redhat.com> >> >> Given that it even had its own stub file, the commit message should >> please explain why it is no longer needed and thus okay to drop. > > Because it's unused?
That's no real answer. Why did it need to be escaped before the commit Cole pointed to and now no longer is? My point was that someone went throught the hassle of creating a stub file just for this functionality, so it's not some random unused function in some file. (But I'm not particularly attached to it, just cautioning about removing too much in this non-verbose way, making it hard to follow for outsiders.) Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
