Ping.
QEMU crash at reboot is due to not resetting PAM registers at i440fx
reset, but a patch has already been rejected on ML:
http://lists.gnu.org/archive/html/qemu-devel/2013-02/msg02928.html
Hervé
Hervé Poussineau a écrit :
With those two patches, I'm able to run a real BIOS in QEMU (Iwi
** Branch linked: lp:ubuntu/cloud-init
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1243287
Title:
[KVM/QEMU][ARM][SAUCY] fails to boot cloud-image due to host kvm fail
Status in QEMU:
Fix Comm
On Mon, Mar 03, 2014 at 09:56:07PM +1000, Peter Crosthwaite wrote:
> On Mon, Mar 3, 2014 at 12:06 AM, Beniamino Galvani
> wrote:
> > The value of pending register was updated only when an irq was raised
> > from a device; it should also be updated when an interrupt is cleared.
>
> So the reason
On Mon, Mar 03, 2014 at 09:16:13PM +1000, Peter Crosthwaite wrote:
> On Mon, Mar 3, 2014 at 12:06 AM, Beniamino Galvani
> wrote:
> > This patch implements proper updating of the vector register which
> > should hold, according to the A10 user manual, the vector address for
> > the interrupt curre
On Mon, Mar 03, 2014 at 09:08:27PM +1000, Peter Crosthwaite wrote:
> On Mon, Mar 3, 2014 at 12:06 AM, Beniamino Galvani
> wrote:
> > The model was generating interrupts for all enabled timers after the
> > expiration of one of them. Avoid this by passing to the timer callback
> > function a struc
On Mon, Mar 03, 2014 at 08:57:33PM +1000, Peter Crosthwaite wrote:
> On Mon, Mar 3, 2014 at 12:06 AM, Beniamino Galvani
> wrote:
> > This implements the prescaler and source fields of the timer control
> > register as described in the A10 user manual.
> >
> > Signed-off-by: Beniamino Galvani
> >
On 03/04/2014 06:57 AM, Mike Day wrote:
> On Sat, Feb 1, 2014 at 9:45 AM, Alexey Kardashevskiy wrote:
>> This makes use of @cpu_dt_id and related API in:
>> 1. emulated XICS hypercall handlers as they receive fixed CPU indexes;
>> 2. XICS-KVM to enable in-kernel XICS on right CPU;
>> 3. device-tre
On 03/04/2014 08:33 AM, Don Slutz wrote:
> On 03/03/14 05:47, Alexey Kardashevskiy wrote:
>> On 03/03/2014 07:33 PM, Paolo Bonzini wrote:
>>> Il 03/03/2014 02:58, Alexey Kardashevskiy ha scritto:
On 03/02/2014 08:31 AM, Paolo Bonzini wrote:
> Il 01/03/2014 13:30, Alexey Kardashevskiy ha sc
Quoting Aneesh Kumar K.V (aneesh.ku...@linux.vnet.ibm.com):
> Paolo Bonzini writes:
>
> > Il 03/03/2014 20:08, Aneesh Kumar K.V ha scritto:
> >> From: "Aneesh Kumar K.V"
> >>
> >> After commit ba1183da9a10b94611cad88c44a5c6df005f9b55 we are including
> >> hw/Makefile.objs directly from Makefile.
On 12/02/2013 02:19 AM, Lei Li wrote:
> Introduce x_unix_page_flipping to MigrationCapability for
> localhost migration.
>
> Signed-off-by: Paolo Bonzini
> Signed-off-by: Lei Li
> ---
> qapi-schema.json | 12 +++-
> 1 files changed, 11 insertions(+), 1 deletions(-)
I don't see this i
On 3 March 2014 20:32, Aneesh Kumar K.V wrote:
> BTW where do i find docs for land/lnot etc ?
Best we have is the comments in rules.mak where they're defined...
thanks
-- PMM
On 27 February 2014 22:17, Peter Maydell wrote:
> Can you either post that to the list as a proper patch or alternatively
> just add a reviewed-by tag to the patch Stefan sent earlier, depending
> which you think is the better fix? Then I'll apply it...
Do we have a definite version of this fix
On 02/21/2014 03:35 AM, Chunyan Liu wrote:
> Change qapi interfaces to output the newly added def_value_str when querying
> command line options.
>
> Signed-off-by: Dong Xu Wang
> Signed-off-by: Chunyan Liu
> ---
> qapi-schema.json |8 ++--
> qmp-commands.hx|2 ++
> util/qemu-
On 02/19/2014 12:54 AM, Hu Tao wrote:
> From: Paolo Bonzini
>
> This option provides the infrastructure for binding guest NUMA nodes
> to host NUMA nodes. For example:
>
> -object memory-ram,size=1024M,policy=membind,host-nodes=0,id=ram-node0 \
> -numa node,nodeid=0,cpus=0,memdev=ram-node0 \
> Am 04.03.2014 um 03:58 schrieb Jeff Cody :
>
>> On Fri, Feb 21, 2014 at 01:06:43PM +0100, Alexander Graf wrote:
>>
>>> On 08.11.2013, at 11:12, Stefan Hajnoczi wrote:
>>>
>>> From: Jeff Cody
>>>
>>> This adds support for VHDX image creation, for images of type "Fixed"
>>> and "Dynamic".
On 03/03/2014 11:29 PM, Aneesh Kumar K.V wrote:
> Chen Gang writes:
>
>> When "goto err_out", 'v9fs_string' already was allocated, so still need
>> free 'v9fs_string' before return.
>>
>> Signed-off-by: Chen Gang
>
> Reviewed-by: Aneesh Kumar K.V
>
Thanks.
--
Chen Gang
Open, share, and a
On 03/03/2014 10:41 AM, Amos Kong wrote:
> Signed-off-by: Amos Kong
> ---
> util/qemu-config.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
Purely mechanical.
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http:/
On 03/04/2014 03:29 AM, Aneesh Kumar K.V wrote:
> "Aneesh Kumar K.V" writes:
>
>> Chen Gang writes:
>> Can we keep this as
>> v9fs_co_run_in_worker(
>> {
>>
>>buf->data = __readlink(&s->ctx, path);
>>
>> }
>>
>> I can do that change f
Alexey Kardashevskiy wrote:
> This is some cleanup. Please, comment. Thanks!
>
Thanks, applied to ppc-next. Please bear in mind that your target CPU
finding loop doesn't scale. So make sure you don't call your new dt
index helper in any code path where you care about performance. Or when
you do
On 03/03/2014 10:41 AM, Amos Kong wrote:
s/PCTCH/PATCH/ in the subject, although it doesn't affect patch application.
> vm_config_groups[] only contains part of the options which have
> argument, and all options which have no argument isn't added to
s/isn't/aren't/
> vm_config_groups[]. Current
On 03/03/2014 10:42 PM, Markus Armbruster wrote:
> Chen Gang writes:
>
>> On 03/03/2014 04:34 PM, Markus Armbruster wrote:
>>> Turns a buffer overrun bug into a truncation bug. The next commit fixes
>>> truncation bugs including this one. Would be nice to spell this out in
>>> the commit messag
On 03/04/2014 01:43 AM, Eric Blake wrote:
> On 03/01/2014 10:33 AM, Chen Gang wrote:
>> Patch 1/3: move v9fs_string_free() to below "err_out:"
>>
>> Patch 2/3: use snprintf() instead of sprintf()
>>(which will be replaced of by Path 3/3)
>>
>> Patch 3/3: use g_strdup_printf() instead of
> Yes, this is the tricky part. To be honest, I think this is the reason no
> one has
> submitted patches - it's a hard task and the win isn't that great (you can
> already migrate to file).
>
Yes, lots of places have to be considered. Though scenarios are limited, users
like
library experimen
> > > Here I have another proposal, based on the live-migration scheme,
> > > add consistent memory state tracking and saving.
> > > The idea is simple:
> > > 1.First round use live-migration to save all memory to a snapshot file.
> > > 2.intercept the action of memory-modify, save old pages to a
On 03/04/2014 11:29 AM, Alexander Graf wrote:
> Alexey Kardashevskiy wrote:
>> This is some cleanup. Please, comment. Thanks!
>>
>
> Thanks, applied to ppc-next. Please bear in mind that your target CPU
> finding loop doesn't scale. So make sure you don't call your new dt
> index helper in any
> > I think this is different in the same way that block-backup and
> > block-mirror are different. Huangpeng's proposal would let you make a
> > consistent snapshot of disks and RAM.
>
> Right. Though the point isn't about consistency (doing the disk snapshot when
> memory has converged would be
> Hi Paolo,
>
> On Mon, Mar 03, 2014 at 02:47:31PM +0100, Paolo Bonzini wrote:
> > I'm not sure what's the status of the kernel infrastructure for
> > post-copy. Andrea?
>
> sys_userfaultfd is still work in progress but it shouldn't be much work left
> to
> completion. madvise(MADV_USERFAUL
2014-03-04 8:02 GMT+08:00 Eric Blake :
> On 02/21/2014 03:35 AM, Chunyan Liu wrote:
> > Change qapi interfaces to output the newly added def_value_str when
> querying
> > command line options.
> >
> > Signed-off-by: Dong Xu Wang
> > Signed-off-by: Chunyan Liu
> > ---
> > qapi-schema.json |
On Mon, Mar 03, 2014 at 05:10:20PM -0700, Eric Blake wrote:
> On 02/19/2014 12:54 AM, Hu Tao wrote:
> > From: Paolo Bonzini
> >
> > This option provides the infrastructure for binding guest NUMA nodes
> > to host NUMA nodes. For example:
> >
> > -object memory-ram,size=1024M,policy=membind,hos
Signed-off-by: Xuebing Wang
---
docs/api-hierarchy.txt | 93
1 file changed, 93 insertions(+)
create mode 100644 docs/api-hierarchy.txt
diff --git a/docs/api-hierarchy.txt b/docs/api-hierarchy.txt
new file mode 100644
index 000..9982f51
---
Hi Community,
Q1) Is it helpful for the document docs/api_hierarchy.txt I wrote? Would you
please help review/correct it?
Q2) Does it make sense to remove NEED_CPU_H from qemu-common.h?
Q3) In include/sysemu/kvm.h, CONFIG_KVM is used thus considering dependency
we should include "config-
Note: there is a FIXME to be addressed in this patch.
This patch handles NEED_CPU_H (thus "target-xxx/cpu.h") only. The changes are:
- Remove inclusion of "cpu.h" from qemu-common.h
- CPU_SAVE_VERSION is defined in target-xxx/cpu.h as well, thus move it
out of qemu-common.h, and move it in
Enforce the strict associativity between NEED_CPU_H and "inclusion of cpu.h",
for every appearance of '#include "cpu.h"', there must have the check of
NEED_CPU_H, and conversely.
This patch only checks file in qemu root directory by:
grep -nw "cpu.h" *.[ch] .
Note: remove unnecessary inclusion of
Remove '#include "exec/address-spaces.h"' is done by:
git grep -w "exec\/address-spaces.h" | cut -d: -f1 |
xargs sed -i '/exec\/address-spaces.h/d'
Signed-off-by: Xuebing Wang
---
arch_init.c |1 -
cputlb.c |1 -
exec.c
In preparation for removing include/exec/address-spaces.h
Signed-off-by: Xuebing Wang
---
include/exec/address-spaces.h | 29 -
include/exec/memory.h | 19 +++
include/hw/sh4/sh_intc.h |1 +
3 files changed, 16 insertions(+), 33 de
Signed-off-by: Xuebing Wang
---
include/exec/exec-all.h | 302 +
include/exec/translate.h | 306 ++
2 files changed, 307 insertions(+), 301 deletions(-)
create mode 100644 include/exec/translate.h
diff --
Hello,
Prompted by Alexey's desire for tweakable PowerPCCPU properties but also by
Peter's wish for ARMCPU properties, this series sets out to align cpu_model
parsing across targets.
QemuOpts would've been nice to use, but on the one hand x86 and sparc use
QemuOpts-incompatible +foo and -foo synt
CPUs who do not provide their own implementation of feature parsing
will treat each option as a QOM property and set it to the supplied
value.
Signed-off-by: Andreas Färber
---
qom/cpu.c | 31 ++-
1 file changed, 30 insertions(+), 1 deletion(-)
diff --git a/qom/cpu.c
Adapt the X86CPU implementation to suit the generic hook.
This involves a cleanup of error handling to cope with NULL errp.
Signed-off-by: Andreas Färber
---
include/qom/cpu.h | 3 +++
target-i386/cpu.c | 36 +---
2 files changed, 24 insertions(+), 15 deletions(-
Gets it out of cpu_sparc_register() and aligns with target-arm.
Signed-off-by: Andreas Färber
---
target-sparc/cpu.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/target-sparc/cpu.c b/target-sparc/cpu.c
index c948b49..42c6de9 100644
--- a/target-sparc/cpu.c
++
Factor cpu_model parsing out of cpu_sparc_find_by_name() by passing
cpu_sparc_find_by_name() the name portion only and calling
CPUClass::parse_features() from cpu_sparc_register() afterwards.
Signed-off-by: Andreas Färber
---
target-sparc/cpu.c | 82 --
Replace non-debug fprintf() with error_report().
Signed-off-by: Andreas Färber
---
target-sparc/cpu.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/target-sparc/cpu.c b/target-sparc/cpu.c
index e91a2f3..ed005b2 100644
--- a/target-sparc/cpu.c
+++ b/target-
All targets using it gain the ability to set -cpu name,key=value,...
options via the default TYPE_CPU CPUClass::parse_features() implementation.
Signed-off-by: Andreas Färber
---
include/qom/cpu.h | 11 +++
qom/cpu.c | 41 ++
From: Riku Voipio
Make syscall.c slightly smaller by moving uname-related
functions to uname.c.
Signed-off-by: Riku Voipio
---
linux-user/syscall.c | 102 ---
linux-user/uname.c | 101 ++
linux-us
From: Riku Voipio
To move more uname related functions out of syscall.c,
rename cpu-uname.{c,h} to uname.{c.h}
Signed-off-by: Riku Voipio
---
linux-user/Makefile.objs | 2 +-
linux-user/cpu-uname.c | 72
linux-user/cpu-uname.h | 1 -
linux
This patch does below:
- Move the declaration of 2 translate functions from translate-all.h into
include/exec/translate.h
- remove file translate-all.h
Signed-off-by: Xuebing Wang
---
exec.c |2 --
include/exec/translate.h |4
translate-all.c |
> -Original Message-
> From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org
> [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On
> Behalf Of Jason Wang
> Sent: Friday, February 21, 2014 5:05 PM
> To: aligu...@amazon.com; m...@redhat.com; qemu-devel@nongnu.org
> Cc: Pao
Note: there is a FIXME to be addressed in this patch.
For every appearance of NEED_CPU_H, there must be '#include "cpu.h"' to
include "target-xxx/cpu.h", because the code below NEED_CPU_H depends on
architecture-specific information.
Signed-off-by: Xuebing Wang
---
include/exec/cpu-common.h |
include/exec/exec-all.h should ONLY be included in target-xxx/*
- 'git grep -nw exec-all.h' confirms this
Signed-off-by: Xuebing Wang
---
cputlb.c |1 -
tcg/README |2 +-
tci.c |2 +-
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/cputlb.c b/cputlb.c
index 72
From: Riku Voipio
Currently some distributors use --enable-uname-release=2.6.32 or
something similar to allow running new target binaries on
old host systems.
In 4a24a758101ff726c9bd3b867e12d5580c793af0 and more flexible
solution was created. However, if you continue to compile with
the --enab
From: Riku Voipio
Popular glibc based distributions[1] require minimum
2.6.32 as kernel version. For some targets 2.6.18
would be enough, but dropping so low would mean some
suboptimal system calls could get used.
Set the minimum kernel advertized to 2.6.32 for
all architectures but aarch64 to e
Hi Xuebing,
Am 04.03.2014 03:47, schrieb Xuebing Wang:
> Q2) Does it make sense to remove NEED_CPU_H from qemu-common.h?
IMO not in this way. Work has been ongoing to obsolete NEED_CPU_H by
introducing CPUState in addition to CPUArchState and moving fields into
CPUState, so that less files need t
From: Riku Voipio
The --enable-uname-release is rather heavyweight hammer, as it allows
providing values less that UNAME_MINIMUM_RELEASE. Also, it affects
all built linux-user targets, which in most cases not what you want.
Now that we have UNAME_MINIMUM_RELEASE for all linux-user platforms,
we
Public bug reported:
When running linux-user targetting AArch64, validate_guest_space() in
elfload.c reserves space in the guest address space for the ARM
commpage. Since there is no commpage on AArch64, this function should be
disable on that target.
** Affects: qemu
Importance: Undecided
This replaces DPRINTF macro with tracepoints.
This moves some messages from migration.c to savevm.c.
This adds tracepoint to signal about fileds failed to migrate.
Signed-off-by: Alexey Kardashevskiy
---
migration.c | 30 ++
qemu-file.c | 2 ++
savevm.c | 8
This adds @idstr to savevm_section_start and savevm_section_end
tracepoints.
Signed-off-by: Alexey Kardashevskiy
---
savevm.c | 12 ++--
trace-events | 4 ++--
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/savevm.c b/savevm.c
index 7329fc5..d094fbb 100644
--- a/save
Use vaddr (instead of target_ulong) for virtual address. See document HACKING
for more information about vaddr and target_ulong.
Signed-off-by: Xuebing Wang
---
include/sysemu/memory_mapping.h |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/sysemu/memory_mapping.
This reworks/adds traces for migration.
v2 is rework of an original single patch with the same subject.
Alexey Kardashevskiy (3):
vl: add system_wakeup_request tracepoint
migration: extend section_start/end traces
migration: add more traces
migration.c | 30 ++
It might be useful for tracing migration.
Signed-off-by: Alexey Kardashevskiy
---
trace-events | 1 +
vl.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/trace-events b/trace-events
index 3713063..dbbaa04 100644
--- a/trace-events
+++ b/trace-events
@@ -486,6 +486,7 @@ runstate_s
Hi!
-smp 8,sockets=1,cores=3,threads=4 does not produce an error and the actual
CPU topology is -smp 8,threads=2 which is not really the same. Also the
user actually expected 1*3*4=12 CPUs, conflict again.
What would the correct fix be? Or there is yet another SMP QOM rework
coming and it will fi
PowerPC kernel expects the number of SMT threads in a core to be a power
of 2. Since QEMU doesn't enforce this, it leads to an early guest kernel
crash if invalid threads count is specified.
Prevent this crash and make it a graceful exit from QEMU itself by
validating the user supplied threads cou
Bharata B Rao writes:
> @@ -7987,6 +7989,12 @@ static void ppc_cpu_realizefn(DeviceState *dev, Error
> **errp)
> max_smt, kvm_enabled() ? "KVM" : "TCG");
> return;
> }
> +threads_shift = log2(smp_threads);
> +if (smp_threads != (1 << threads_shift)) {
> +
Hi Andreas, thank you very much for your reply.
Would you please help review/correct doc/api-hierarchy too?
On 03/04/2014 11:45 AM, Andreas Färber wrote:
Hi Xuebing,
Am 04.03.2014 03:47, schrieb Xuebing Wang:
Q2) Does it make sense to remove NEED_CPU_H from qemu-common.h?
IMO not in this wa
Signed-off-by: Amos Kong
---
util/qemu-config.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/util/qemu-config.c b/util/qemu-config.c
index 9298f55..d624d92 100644
--- a/util/qemu-config.c
+++ b/util/qemu-config.c
@@ -39,7 +39,7 @@ QemuOptsList *qemu_find_opts(const
On Mon, Mar 03, 2014 at 05:37:57PM -0700, Eric Blake wrote:
> > ---
> > qapi-schema.json | 8 ++--
> > util/qemu-config.c | 52
> > ++--
> > 2 files changed, 52 insertions(+), 8 deletions(-)
> >
> > diff --git a/qapi-schema.json b/qapi-sche
From: Stefan Weil
There is no dependency on windows.h, and the standard include files are
already included by qemu-common.h.
Signed-off-by: Stefan Weil
Reviewed-by: Paolo Bonzini
Reviewed-by: Andreas Färber
Signed-off-by: Michael Tokarev
---
qemu-img.c |6 --
1 file changed, 6 delet
From: Stefan Weil
Signed-off-by: Stefan Weil
Signed-off-by: Michael Tokarev
---
tcg/tcg.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index ffc851e..f1e0763 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -41,7 +41,7 @@
#include "qemu/host-utils.h"
From: Peter Maydell
The function qobject_from_json() doesn't actually allow its
argument to be a format string -- it passes a NULL va_list*
to qobject_from_jsonv(), and the parser code will then never
actually interpret %-escape sequences (it tests whether the
va_list pointer is NULL and will sto
vm_config_groups[] only contains part of the options which have
argument, and all options which have no argument aren't added to
vm_config_groups[]. Current query-command-line-options only
checks options from vm_config_groups[], so some options will
be lost.
We have some macros in qemu-options.hx
From: "Dr. David Alan Gilbert"
Signed-off-by: Dr. David Alan Gilbert
Signed-off-by: Michael Tokarev
---
include/qemu/host-utils.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/qemu/host-utils.h b/include/qemu/host-utils.h
index de85d28..285c5fb 100644
--- a/inc
This patchset fixed some issues of query-command-line-options:
* some new options that haven't argument can't be queried. (eg: -enable-fips)
* some legacy options that have argument can't be queried. (eg: -vnc display)
More discussion:
http://marc.info/?l=qemu-devel&m=139081830416684&w=2
V2: r
From: Hani Benhabiles
Signed-off-by: Hani Benhabiles
Reviewed-by: Hu Tao
Acked-by: Paolo Bonzini
Signed-off-by: Michael Tokarev
---
qmp.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qmp.c b/qmp.c
index d0d98e7..f556a04 100644
--- a/qmp.c
+++ b/qmp.c
@@ -556,8 +
From: Peter Maydell
clang doesn't support the __noclone__ attribute and emits a warning about
it. Fortunately clang also implements a mechanism for asking if a particular
attribute is implemented; use it. We assume that if the compiler doesn't
support __has_attribute() then it must be GCC and mus
Am 04.03.2014 00:50, schrieb Peter Maydell:
>
> Do we have a definite version of this fix which everybody is happy
> with yet? I've got confused with the various versions and review
> comments on them. I'd like to apply the buildfix before I apply
> any further pull requests...
>
> thanks
> -- PM
From: Stefan Weil
The functions use uint16_t or uint32_t values, so show this in the function
prototypes. Non-optimizing compilers will avoid unnecessary type
conversions when generating calls of these inline functions.
stq_le_p, stq_be_p already use similar prototypes.
Signed-off-by: Stefan We
On 02/13/2014 12:08 PM, Alexey Kardashevskiy wrote:
> Currently interrupt priorities are set to 0 (highest) at the very
> beginning of the guest execution which is not correct and makes the guest
> produce random interrupt error messages such as:
> "Interrupt 0x1001 (real) is invalid, disabling it"
From: Stefan Weil
Signed-off-by: Stefan Weil
Reviewed-by: Paolo Bonzini
Reviewed-by: Andreas Färber
Signed-off-by: Michael Tokarev
---
util/iov.c |9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/util/iov.c b/util/iov.c
index 03934da..6569b5a 100644
--- a/util/io
From: Stefan Weil
This file does not depend on windows.h.
Cc: Anthony Liguori
Signed-off-by: Stefan Weil
Reviewed-by: Paolo Bonzini
Reviewed-by: Andreas Färber
Signed-off-by: Michael Tokarev
---
vl.c |4
1 file changed, 4 deletions(-)
diff --git a/vl.c b/vl.c
index 1d27b34..bf619
Here's another pull request for trivial-patches tree.
There's nothing exciting in there, small things here and there.
Please consider pulling/applying.
Thanks,
/mjt
The following changes since commit d844a7b6569fb2b5252773444b18841426e5b906:
modules: Fix building with --enable-modules (2014-0
Il 04/03/2014 07:57, Stefan Weil ha scritto:
Simply take the version without confusing review comments:
http://patchwork.ozlabs.org/patch/324909/. :-)
To be honest: the other patch fixes one build regression and introduces
a new one, so it would not improve the situation.
Paolo noticed that Mak
From: Stefan Weil
The function uses an uint8_t value, so show this in the function
prototype. Non-optimizing compilers will avoid unnecessary type
conversions from (u)int8_t to int and back to uint8_t when generating
calls of this inline function.
stw_p, stl_p and stq_p already use similar proto
From: Stefan Weil
This file does not depend on windows.h.
Signed-off-by: Stefan Weil
Reviewed-by: Paolo Bonzini
Reviewed-by: Andreas Färber
Signed-off-by: Michael Tokarev
---
exec.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/exec.c b/exec.c
index b69fd29..6802
From: Stefan Weil
It does not need qemu-common.h. Including exec/gdbstub.h fixes a warning
from static code analyzers and avoids mismatching declarations for
xml_builtin.
Signed-off-by: Stefan Weil
Signed-off-by: Michael Tokarev
---
stubs/gdbstub.c |4 +++-
1 file changed, 3 insertions(+)
From: Stefan Weil
This file does not depend on windows.h.
Signed-off-by: Stefan Weil
Reviewed-by: Paolo Bonzini
Reviewed-by: Andreas Färber
Signed-off-by: Michael Tokarev
---
qga/main.c |1 -
1 file changed, 1 deletion(-)
diff --git a/qga/main.c b/qga/main.c
index cfca291..d838c3e 1006
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
---
hw/i386/pc.c | 11 +--
hw/i386/pc_piix.c| 8 +++-
hw/i386/pc_q35.c | 4 +---
include/hw/i386/pc.h | 7 +++
4 files changed, 12 insertions(+), 18 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 4
201 - 285 of 285 matches
Mail list logo
